Re: [PATCH] irqdomain: remove debugfs_file from struct irq_domain

2021-02-17 Thread Michael Walle
Am 2021-02-17 22:50, schrieb Marc Zyngier: On Wed, 17 Feb 2021 20:10:50 +, Michael Walle wrote: Am 2021-02-17 21:02, schrieb Marc Zyngier: > On 2021-02-17 19:57, Michael Walle wrote: >> Hi Greg, >> >>> There's no need to keep around a dentry pointer to a simple file that >>> debugfs

[PATCH] remoteproc: qcom: wcnss: Allow specifying firmware-name

2021-02-17 Thread Aníbal Limón
From: Bjorn Andersson Introduce a firmware-name property, in order to be able to support device/platform specific firmware for the wireless connectivity subsystem; in line with other Qualcomm remoteproc drivers. Signed-off-by: Bjorn Andersson Tested-by: Aníbal Limón ---

Re: [PATCH RESEND v5] tpm: fix reference counting for struct tpm_chip

2021-02-17 Thread Jarkko Sakkinen
On Tue, Feb 16, 2021 at 08:53:11PM +0100, Lino Sanfilippo wrote: > From: Lino Sanfilippo > > The following sequence of operations results in a refcount warning: > > 1. Open device /dev/tpmrm. > 2. Remove module tpm_tis_spi. > 3. Write a TPM command to the file descriptor opened at step 1. > >

Re: [PATCH net-next v3 0/5] lan743x speed boost

2021-02-17 Thread David Miller
From: Sven Van Asbroeck Date: Wed, 17 Feb 2021 17:04:05 -0500 > Hi Jakub and Bryan, > > Jakub, is there anything else you'd like to see from us, before you > are satisfied that patches 1/5 and 2/5 can be merged into your tree? They are already merged into net-next

Re: [PATCH v2 1/2] dt-bindings: display: bridge: Add documentation for LT8912

2021-02-17 Thread Rob Herring
On Mon, Feb 15, 2021 at 12:29:03AM +0100, Adrien Grassein wrote: > Lontium LT8912 is a DSI to HDMI bridge. > > Signed-off-by: Adrien Grassein > --- > .../display/bridge/lontium,lt8912.yaml| 102 ++ > MAINTAINERS | 5 + > 2 files

[PATCH v7 3/3] docs/pinctrl: document debugfs files

2021-02-17 Thread Drew Fustini
Document debugfs directories and files created for pinctrl subsystem. Suggested-by: Andy Shevchenko Reviewed-by: Andy Shevchenko Reviewed-by: Tony Lindgren Signed-off-by: Drew Fustini --- Documentation/driver-api/pinctl.rst | 37 + 1 file changed, 37 insertions(+)

[PATCH v7 1/3] pinctrl: use to octal permissions for debugfs files

2021-02-17 Thread Drew Fustini
Switch over pinctrl debugfs files to use octal permissions as they are preferred over symbolic permissions. Refer to commit f90774e1fd27 ("checkpatch: look for symbolic permissions and suggest octal instead"). Note: S_IFREG flag is added to the mode by __debugfs_create_file() in

[PATCH v7 2/3] pinctrl: pinmux: Add pinmux-select debugfs file

2021-02-17 Thread Drew Fustini
Add "pinmux-select" to debugfs which will activate a function and group: echo "" > pinmux-select The write operation pinmux_select() handles this by checking that the names map to valid selectors and then calling ops->set_mux(). The existing "pinmux-functions" debugfs file lists the pin

Re: [PATCH v4] tpm: fix reference counting for struct tpm_chip

2021-02-17 Thread Jarkko Sakkinen
On Tue, Feb 16, 2021 at 04:31:26PM +, David Laight wrote: > ... > > > > + get_device(>dev); > > > > + chip->devs.release = tpm_devs_release; > > > > + chip->devs.devt = > > > > + MKDEV(MAJOR(tpm_devt), chip->dev_num + TPM_NUM_DEVICES); > > > > Isn't this less

[PATCH v2 2/3] media: camss: use v4l2_get_link_freq() to calculate the relevant clocks

2021-02-17 Thread Andrey Konovalov
There are places in the camss driver where camss_get_pixel_clock() is called to get the pixel rate (using V4L2_CID_PIXEL_RATE control) and to calculate the link frequency from it. There is a case when this would not work: when V4L2_CID_PIXEL_RATE gets the rate at which the pixels are read

[PATCH v7 0/3] pinctrl: pinmux: Add pinmux-select debugfs file

2021-02-17 Thread Drew Fustini
This series first converts the debugfs files in the pinctrl subsystem to octal permissions and then adds a new debugfs file "pinmux-select". Function name and group name can be written to "pinmux-select" which will cause the function and group to be activated on the pin controller. The final

[PATCH v2 3/3] media: qcom: camss: Fix overflows in clock rate calculations

2021-02-17 Thread Andrey Konovalov
From: Vladimir Lypak Because of u32 type being used to store pixel clock rate, expression used to calculate pipeline clocks (pixel_clock * bpp) produces wrong value due to integer overflow. This patch changes data type used to store, pass and retrieve pixel_clock from u32 to u64 to make this

[PATCH v2 0/3] media: qcom: camss: V4L2_CID_PIXEL_RATE/LINK_FREQ fixes

2021-02-17 Thread Andrey Konovalov
The first patch adds printing a warning in v4l2_get_link_freq() if V4L2_CID_LINK_FREQ isn't implemented (this is a mandatory control for CSI-2 transmitter drivers [1], but many sensor drivers don't have it currently). The second patch is the start of the work discussed in the "[RFC] Repurpose

[PATCH v2 1/3] v4l: common: v4l2_get_link_freq: add printing a warning

2021-02-17 Thread Andrey Konovalov
Print a warning if V4L2_CID_LINK_FREQ control is not implemented. Signed-off-by: Andrey Konovalov --- drivers/media/v4l2-core/v4l2-common.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/v4l2-core/v4l2-common.c b/drivers/media/v4l2-core/v4l2-common.c index

Re: [PATCH v2 bpf-next] bpf: fix a warning message in mark_ptr_not_null_reg()

2021-02-17 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to bpf/bpf-next.git (refs/heads/master): On Wed, 17 Feb 2021 10:45:25 +0300 you wrote: > The WARN_ON() argument is a condition, not an error message. So this > code will print a stack trace but will not print the warning message. > Fix that and also change it to

Re: [RFC PATCH 29/34] power/swap: use bio_new in hib_submit_io

2021-02-17 Thread Pavel Machek
Hi! > > diff --git a/kernel/power/swap.c b/kernel/power/swap.c > index c73f2e295167..e92e36c053a6 100644 > --- a/kernel/power/swap.c > +++ b/kernel/power/swap.c > @@ -271,13 +271,12 @@ static int hib_submit_io(int op, int op_flags, pgoff_t > page_off, void *addr, > struct

Re: [PATCH net-next v3 0/5] lan743x speed boost

2021-02-17 Thread Sven Van Asbroeck
Hi Jakub and Bryan, On Wed, Feb 17, 2021 at 4:43 PM wrote: > > Just to let you know, my colleague tested the patches 1 and 2 on x86 PC and > we are satisfied with the result. > We confirmed some performance improvements. > We also confirmed PTP is working. > > Thanks for your work on this. > >

Re: [PATCH v3 net-next 0/7] ptp: ptp_clockmatrix: Fix output 1 PPS alignment.

2021-02-17 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Wed, 17 Feb 2021 00:42:11 -0500 you wrote: > From: Vincent Cheng > > This series fixes a race condition that may result in the output clock > not aligned to internal 1 PPS clock. > > Part of device initialization is

Re: [PATCH v25 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2021-02-17 Thread Mathieu Poirier
On Wed, Feb 17, 2021 at 09:34:13PM +, Ben Levinsky wrote: > 1 more for the pnode_id comment > [...] > > > > > +static int parse_tcm_banks(struct rproc *rproc) > > > > > +{ > > > > > + int i, num_banks; > > > > > + struct zynqmp_r5_rproc *z_rproc = rproc->priv; > > > > > + struct

Re: [PATCH v2 3/3] vdpa/mlx5: defer clear_virtqueues to until DRIVER_OK

2021-02-17 Thread Si-Wei Liu
On 2/16/2021 7:21 AM, Eli Cohen wrote: On Thu, Feb 11, 2021 at 09:33:14AM +0200, Eli Cohen wrote: On Wed, Feb 10, 2021 at 01:48:00PM -0800, Si-Wei Liu wrote: While virtq is stopped, get_vq_state() is supposed to be called to get sync'ed with the latest internal avail_index from

Re: [PATCH 1/2] vdpa/mlx5: Fix suspend/resume index restoration

2021-02-17 Thread Si-Wei Liu
On 2/17/2021 1:20 PM, Michael S. Tsirkin wrote: On Wed, Feb 17, 2021 at 11:42:48AM -0800, Si-Wei Liu wrote: On 2/16/2021 8:20 AM, Eli Cohen wrote: When we suspend the VM, the VDPA interface will be reset. When the VM is resumed again, clear_virtqueues() will clear the available and used

Re: [PATCH] irqdomain: remove debugfs_file from struct irq_domain

2021-02-17 Thread Marc Zyngier
On Wed, 17 Feb 2021 20:10:50 +, Michael Walle wrote: > > Am 2021-02-17 21:02, schrieb Marc Zyngier: > > On 2021-02-17 19:57, Michael Walle wrote: > >> Hi Greg, > >> > >>> There's no need to keep around a dentry pointer to a simple file that > >>> debugfs itself can look up when we need to

Re: [PATCH net-next v2 0/5] dwmac-sun8i cleanup and shutdown hook

2021-02-17 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Tue, 16 Feb 2021 22:20:01 -0600 you wrote: > These patches clean up some things I noticed while fixing suspend/resume > behavior. The first four are minor code improvements. The last one adds > a shutdown hook to

Re: [PATCH v25 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2021-02-17 Thread Mathieu Poirier
On Wed, Feb 17, 2021 at 07:11:37PM +, Ben Levinsky wrote: > Hi Mathieu, > > I worked on this further and had 1 more comment on the prepare/unprepare for > TCM banks below > [...] > > > > + */ > > > > +static int tcm_mem_release(struct rproc *rproc, struct rproc_mem_entry > > > *mem) > > >

[PATCH v2 3/3] mm: Fix missing mem cgroup soft limit tree updates

2021-02-17 Thread Tim Chen
On a per node basis, the mem cgroup soft limit tree on each node tracks how much a cgroup has exceeded its soft limit memory limit and sorts the cgroup by its excess usage. On page release, the trees are not updated right away, until we have gathered a batch of pages belonging to the same cgroup.

RE: [PATCH net-next v3 0/5] lan743x speed boost

2021-02-17 Thread Bryan.Whitehead
> From: Sven Van Asbroeck > > Tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git # > 9ec5eea5b6ac > > v2 -> v3: > - Bryan Whitehead: > + add Bryan's reviewed-by tag to patch 1/5. > + Only use FRAME_LENGTH if the LS bit is checked. > If set use the smaller of

[PATCH v2 2/3] mm: Force update of mem cgroup soft limit tree on usage excess

2021-02-17 Thread Tim Chen
To rate limit updates to the mem cgroup soft limit tree, we only perform updates every SOFTLIMIT_EVENTS_TARGET (defined as 1024) memory events. However, this sampling based updates may miss a critical update: i.e. when the mem cgroup first exceeded its limit but it was not on the soft limit tree.

[PATCH v2 0/3] Soft limit memory management bug fixes

2021-02-17 Thread Tim Chen
During testing of tiered memory management based on memory soft limit, I found three issues with memory management using cgroup based soft limit in the mainline code. Fix the issues with the three patches in this series. Also updated patch 3 per Johannes' comments on the first version of this

[PATCH v2 1/3] mm: Fix dropped memcg from mem cgroup soft limit tree

2021-02-17 Thread Tim Chen
During soft limit memory reclaim, we will temporarily remove the target mem cgroup from the cgroup soft limit tree. We then perform memory reclaim, update the memory usage excess count and re-insert the mem cgroup back into the mem cgroup soft limit tree according to the new memory usage excess

Re: [PATCH 2/2] ath9k: fix ath_tx_process_buffer() potential null ptr dereference

2021-02-17 Thread Felix Fietkau
> On 17. Feb 2021, at 21:28, Shuah Khan wrote: > > On 2/17/21 7:56 AM, Shuah Khan wrote: >>> On 2/17/21 12:30 AM, Kalle Valo wrote: >>> Shuah Khan writes: >>> On 2/16/21 12:53 AM, Felix Fietkau wrote: > > On 2021-02-16 08:03, Kalle Valo wrote: >> Shuah Khan wrote: >>

RE: [PATCH v25 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2021-02-17 Thread Ben Levinsky
1 more for the pnode_id comment > -Original Message- > From: Ben Levinsky > Sent: Wednesday, February 17, 2021 11:12 AM > To: Mathieu Poirier > Cc: devicet...@vger.kernel.org; linux-remotep...@vger.kernel.org; linux- > ker...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; Michal

[PATCH 3/3] staging: rtl8192e: rename SeqNum to seq_num in sequence_control union

2021-02-17 Thread William Durand
Fixes a checkpatch CHECK message. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_BA.h | 2 +- drivers/staging/rtl8192e/rtl819x_BAProc.c | 2 +- drivers/staging/rtl8192e/rtllib_tx.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [RFC PATCH 5/7] dt-bindings: regulator: bd9576 add FET ON-resistance for OCW

2021-02-17 Thread Rob Herring
On Thu, Feb 11, 2021 at 02:35:41PM +0200, Matti Vaittinen wrote: > BD9576MUF provides over-current protection and detection. Current is > measured as voltage loss over external FET. Allow specifying FET's on > resistance so current monitoring limits can be converted to voltages. > >

[PATCH 1/3] staging: rtl8192e: rename ShortData to short_data in sequence_control union

2021-02-17 Thread William Durand
Fixes a checkpatch CHECK message. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_BA.h | 2 +- drivers/staging/rtl8192e/rtl819x_BAProc.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_BA.h

[PATCH 0/3] staging: rtl8192e: sequence_control union cleanups

2021-02-17 Thread William Durand
This patchset fixes the checkpatch issues related to the `sequence_control` union defined in `rtl8192e/rtl819x_BA.h` (avoid camelcase). William Durand (3): staging: rtl8192e: rename ShortData to short_data in sequence_control union staging: rtl8192e: rename FragNum to frag_num in

[PATCH 2/3] staging: rtl8192e: rename FragNum to frag_num in sequence_control union

2021-02-17 Thread William Durand
Fixes a checkpatch CHECK message. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_BA.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192e/rtl819x_BA.h b/drivers/staging/rtl8192e/rtl819x_BA.h index 34d66b8f5155..3e5bd3fc78ce 100644

Re: [RFC 1/2] mm: disable LRU pagevec during the migration temporarily

2021-02-17 Thread Minchan Kim
On Wed, Feb 17, 2021 at 09:16:12PM +, Matthew Wilcox wrote: > On Wed, Feb 17, 2021 at 12:46:19PM -0800, Minchan Kim wrote: > > > I suspect you do not want to add atomic_read inside hot paths, right? Is > > > this really something that we have to microoptimize for? atomic_read is > > > a simple

[RELEASE] LTTng-modules 2.11.8 and 2.12.5 (Linux kernel tracer)

2021-02-17 Thread Mathieu Desnoyers
Hi, This is a release announcement for the 2.11.8 and 2.12.5 releases of the LTTng kernel tracer. New and noteworthy in these releases: * Support for Linux kernel 5.11, * Deal with stable kernel version overflow (sublevel >= 256), * Prepare for Ubuntu, SLES, RHEL, and RT release version

Re: [PATCH] coccinelle: misc: add swap script

2021-02-17 Thread Julia Lawall
> +@depends on patch@ > +identifier tmp; > +expression a, b; > +type T; > +@@ > + > +( > +- T tmp; > +| > +- T tmp = 0; > +| > +- T *tmp = NULL; > +) > +... when != tmp > +- tmp = a; > +- a = b; > +- b = tmp; > ++ swap(a, b); > +... when != tmp In this rule and the next one, if you remove the

Re: [PATCH net-next] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-02-17 Thread Arnd Bergmann
On Wed, Feb 17, 2021 at 9:20 PM Min Li wrote: > > I attached the G.8273.2 document, where chapter 6 is about supporting > physical layer > frequency. And combo mode is Renesas way to support this requirement. Other > companies > may come up with different ways to support it. > > When EEC

[PATCH clocksource 4/5] clocksource: Provide a module parameter to fuzz per-CPU clock checking

2021-02-17 Thread paulmck
From: "Paul E. McKenney" Code that checks for clock desynchronization must itself be tested, so this commit creates a new clocksource.inject_delay_shift_percpu= kernel boot parameter that adds or subtracts a large value from the check read, using the specified bit of the CPU ID to determine

[PATCH clocksource 3/5] clocksource: Check per-CPU clock synchronization when marked unstable

2021-02-17 Thread paulmck
From: "Paul E. McKenney" Some sorts of per-CPU clock sources have a history of going out of synchronization with each other. However, this problem has purportedy been solved in the past ten years. Except that it is all too possible that the problem has instead simply been made less likely,

[PATCH clocksource 5/5] clocksource: Do pairwise clock-desynchronization checking

2021-02-17 Thread paulmck
From: "Paul E. McKenney" Although smp_call_function() has the advantage of simplicity, using it to check for cross-CPU clock desynchronization means that any CPU being slow reduces the sensitivity of the checking across all CPUs. And it is not uncommon for smp_call_function() latencies to be in

[PATCH clocksource 2/5] clocksource: Retry clock read if long delays detected

2021-02-17 Thread paulmck
From: "Paul E. McKenney" When the clocksource watchdog marks a clock as unstable, this might be due to that clock being unstable or it might be due to delays that happen to occur between the reads of the two clocks. Yes, interrupts are disabled across those two reads, but there are no shortage

[PATCH clocksource 1/5] clocksource: Provide module parameters to inject delays in watchdog

2021-02-17 Thread paulmck
From: "Paul E. McKenney" When the clocksource watchdog marks a clock as unstable, this might be due to that clock being unstable or it might be due to delays that happen to occur between the reads of the two clocks. Yes, interrupts are disabled across those two reads, but there are no shortage

Re: [PATCH v3 clocksource] Do not mark clocks unstable due to delays

2021-02-17 Thread Paul E. McKenney
Hello! If there is a sufficient delay between reading the watchdog clock and the clock under test, the clock under test will be marked unstable through no fault of its own. This series checks for this, doing limited retries to get a good set of clock reads. If the clock is marked unstable and

Re: [PATCH v3 1/1] rcuscale: add kfree_rcu() single-argument scale test

2021-02-17 Thread Paul E. McKenney
On Wed, Feb 17, 2021 at 07:51:10PM +0100, Uladzislau Rezki (Sony) wrote: > To stress and test a single argument of kfree_rcu() call, we > should to have a special coverage for it. We used to have it > in the test-suite related to vmalloc stressing. The reason is > the rcuscale is a correct place

Re: output: was: Re: [PATCH v4] printk: Userspace format enumeration support

2021-02-17 Thread Chris Down
Steven Rostedt writes: OK, now do the same in C. "%q" "and I guess that "f" in the print statement in python (but I don't know for sure) does some magic with converting the "\n" and such. I agree with Petr on this. Print the format itself, and not what is converted. It's much easier to convert

Re: [PATCH v5 07/19] remoteproc: Add new get_loaded_rsc_table() to rproc_ops

2021-02-17 Thread Mathieu Poirier
On Mon, Feb 15, 2021 at 02:10:10PM +0100, Arnaud POULIQUEN wrote: > Hi Mathieu, > > On 2/12/21 12:46 AM, Mathieu Poirier wrote: > > Add a new get_loaded_rsc_table() operation in order to support > > scenarios where the remoteproc core has booted a remote processor > > and detaches from it. When

Re: [PATCH 1/2] vdpa/mlx5: Fix suspend/resume index restoration

2021-02-17 Thread Michael S. Tsirkin
On Wed, Feb 17, 2021 at 11:42:48AM -0800, Si-Wei Liu wrote: > > > On 2/16/2021 8:20 AM, Eli Cohen wrote: > > When we suspend the VM, the VDPA interface will be reset. When the VM is > > resumed again, clear_virtqueues() will clear the available and used > > indices resulting in hardware

Re: [RFC 1/2] mm: disable LRU pagevec during the migration temporarily

2021-02-17 Thread Minchan Kim
On Wed, Feb 17, 2021 at 09:11:43PM +, Matthew Wilcox wrote: > On Wed, Feb 17, 2021 at 12:51:25PM -0800, Minchan Kim wrote: > > I'd like to avoid atomic operation if we could. > > Why do you think that the spinlock is better? > Michal suggested atomic_inc in writeside and atomic_read in

Re: [PATCH v4] drm/i915/gen9bc: Handle TGP PCH during suspend/resume

2021-02-17 Thread Lyude Paul
On Wed, 2021-02-17 at 23:18 +0200, Imre Deak wrote: > On Wed, Feb 17, 2021 at 01:00:16PM -0500, Lyude Paul wrote: > > From: Tejas Upadhyay > > > > For Legacy S3 suspend/resume GEN9 BC needs to enable and > > setup TGP PCH. > > > > v2: > > * Move Wa_14010685332 into it's own function - vsyrjala

Re: [PATCH net-next] net: mdio: Remove of_phy_attach()

2021-02-17 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 17 Feb 2021 12:25:57 -0800 you wrote: > We have no in-tree users, also update the sfp-phylink.rst documentation > to indicate that phy_attach_direct() is used instead of of_phy_attach(). > > Signed-off-by: Florian

Re: [PATCH] mm: vmstat: add cma statistics

2021-02-17 Thread Minchan Kim
On Wed, Feb 17, 2021 at 12:57:25PM -0800, John Hubbard wrote: > On 2/17/21 9:00 AM, Minchan Kim wrote: > > Since CMA is used more widely, it's worth to have CMA > > allocation statistics into vmstat. With it, we could > > know how agressively system uses cma allocation and > > how often it fails.

[PATCH 2/2] mtd: char: Get rid of Big MTD Lock

2021-02-17 Thread Alexander A Sverdlin
From: Alexander Sverdlin Get rid of central chrdev MTD lock, which prevents simultaneous operations on completely independent physical MTD chips. Replace it with newly introduced per-master mutex. Signed-off-by: Alexander Sverdlin --- drivers/mtd/mtdchar.c | 14 --

[PATCH 1/2] mtd: char: Drop mtd_mutex usage from mtdchar_open()

2021-02-17 Thread Alexander A Sverdlin
From: Alexander Sverdlin It looks unnecessary in the function, remove it from the function having in mind to remove it completely. Signed-off-by: Alexander Sverdlin --- drivers/mtd/mtdchar.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/mtd/mtdchar.c

Re: [PATCH] PCI: quirk for preventing bus reset on TI C667X

2021-02-17 Thread Bjorn Helgaas
On Thu, Jan 21, 2021 at 05:55:47PM -0600, Bjorn Helgaas wrote: > On Tue, Jan 12, 2021 at 03:36:43PM +, Antti Järvinen wrote: > > TI C667X does not support bus/hot reset. > > See https://e2e.ti.com/support/processors/f/791/t/954382 > > You can cite the URL as the source, but the URL will

Re: [PATCH v4] drm/i915/gen9bc: Handle TGP PCH during suspend/resume

2021-02-17 Thread Imre Deak
On Wed, Feb 17, 2021 at 01:00:16PM -0500, Lyude Paul wrote: > From: Tejas Upadhyay > > For Legacy S3 suspend/resume GEN9 BC needs to enable and > setup TGP PCH. > > v2: > * Move Wa_14010685332 into it's own function - vsyrjala > * Add TODO comment about figuring out if we can move this

Re: [RFC 1/2] mm: disable LRU pagevec during the migration temporarily

2021-02-17 Thread Matthew Wilcox
On Wed, Feb 17, 2021 at 12:46:19PM -0800, Minchan Kim wrote: > > I suspect you do not want to add atomic_read inside hot paths, right? Is > > this really something that we have to microoptimize for? atomic_read is > > a simple READ_ONCE on many archs. > > It's also spin_lock_irq_save in some

Re: [PATCH 1/4] add generic builtin command line

2021-02-17 Thread Andrew Morton
On Mon, 15 Feb 2021 11:32:01 -0800 Daniel Gimpelevich wrote: > On Thu, 2019-03-21 at 15:15 -0700, Andrew Morton wrote: > > On Thu, 21 Mar 2019 08:13:08 -0700 Daniel Walker wrote: > > > On Wed, Mar 20, 2019 at 08:14:33PM -0700, Andrew Morton wrote: > > > > The patches (or some version of them)

[PATCH] Revert "ath9k: fix ath_tx_process_buffer() potential null ptr dereference"

2021-02-17 Thread Shuah Khan
ath_tx_process_buffer() doesn't dereference or check sta and passes it to ath_tx_complete_aggr() and ath_tx_complete_buf(). ath_tx_complete_aggr() checks the pointer before use. No problem here. ath_tx_complete_buf() doesn't check or dereference sta and passes it on to ath_tx_complete().

Re: [PATCH] coccinelle: misc: add minmax script

2021-02-17 Thread Julia Lawall
On Tue, 16 Feb 2021, Denis Efremov wrote: > Check for opencoded min(), max() implementations. Some cases that could be improved: diff -u -p a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c --- a/drivers/platform/x86/asus-laptop.c +++

Re: [RFC 1/2] mm: disable LRU pagevec during the migration temporarily

2021-02-17 Thread Matthew Wilcox
On Wed, Feb 17, 2021 at 12:51:25PM -0800, Minchan Kim wrote: > I'd like to avoid atomic operation if we could. Why do you think that the spinlock is better?

Re: [PATCH 1/4] hugetlb: Pass vma into huge_pte_alloc() and huge_pmd_share()

2021-02-17 Thread kernel test robot
Hi Peter, Thank you for the patch! Yet something to improve: [auto build test ERROR on arm64/for-next/core] [also build test ERROR on linux/master linus/master hnaz-linux-mm/master v5.11 next-20210217] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting

Re: [PATCH v2 2/3] dt-bindings: fpga: Add binding doc for versal fpga manager

2021-02-17 Thread Rob Herring
On Fri, Feb 12, 2021 at 06:13:33AM +, Nava kishore Manne wrote: > Hi Rob, > > Please find my response inline. > > > -Original Message- > > From: Rob Herring > > Sent: Thursday, February 11, 2021 8:26 PM > > To: Nava kishore Manne > > Cc: linux-arm-ker...@lists.infradead.org;

Re: [PATCH 3/3] Input: applespi: Add trace_event module param for early tracing.

2021-02-17 Thread Dmitry Torokhov
On Wed, Feb 17, 2021 at 12:52:57PM -0800, Life is hard, and then you die wrote: > > Hi Dmitry, > > On Wed, Feb 17, 2021 at 12:26:18PM -0800, Dmitry Torokhov wrote: > > > > On Wed, Feb 17, 2021 at 11:07:18AM -0800, Ronald Tschalär wrote: > > > The problem is that tracing can't be set via sysfs

Re: [PATCH v5 1/4] dt-bindings: usb: Add binding for discrete onboard USB hubs

2021-02-17 Thread Rob Herring
On Wed, Feb 10, 2021 at 09:10:36AM -0800, Matthias Kaehlcke wrote: > Discrete onboard USB hubs (an example for such a hub is the Realtek > RTS5411) need to be powered and may require initialization of other > resources (like GPIOs or clocks) to work properly. This adds a device > tree binding for

[PATCH] USB: gadget: dummy-hcd: remove redundant initialization of variable 'value'

2021-02-17 Thread Colin King
From: Colin Ian King The variable 'value' is being initialized with 1 that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King ---

[PATCH 2/2] arm64: dts: mt8183: add mt8183 pumpkin board

2021-02-17 Thread Fabien Parent
The MT8183 Pumpkin board is manufactured by OLogic and includes a MediaTek MT8183 SoC with 2GB of RAM. The board provides the following IOs: * 2 USB Type-A ports * Ethernet * Serial UART over micro-USB port * 1 USB Type-C dual role port * 1 USB Type-C power

[PATCH 1/2] dt-bindings: arm64: dts: mediatek: Add mt8183-pumpkin board

2021-02-17 Thread Fabien Parent
Add binding documentation for the MT8183 Pumpkin board. Signed-off-by: Fabien Parent --- Documentation/devicetree/bindings/arm/mediatek.yaml | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml

[PATCH RESEND] mm, kasan: don't poison boot memory

2021-02-17 Thread Andrey Konovalov
During boot, all non-reserved memblock memory is exposed to the buddy allocator. Poisoning all that memory with KASAN lengthens boot time, especially on systems with large amount of RAM. This patch makes page_alloc to not call kasan_free_pages() on all new memory. __free_pages_core() is used when

[PATCH] mm, kasan: don't poison boot memory

2021-02-17 Thread Andrey Konovalov
During boot, all non-reserved memblock memory is exposed to the buddy allocator. Poisoning all that memory with KASAN lengthens boot time, especially on systems with large amount of RAM. This patch makes page_alloc to not call kasan_free_pages() on all new memory. __free_pages_core() is used when

Re: [PATCH] mm: vmstat: add cma statistics

2021-02-17 Thread John Hubbard
On 2/17/21 9:00 AM, Minchan Kim wrote: Since CMA is used more widely, it's worth to have CMA allocation statistics into vmstat. With it, we could know how agressively system uses cma allocation and how often it fails. Signed-off-by: Minchan Kim --- include/linux/vm_event_item.h | 3 +++

[GIT PULL] seccomp updates for v5.12-rc1

2021-02-17 Thread Kees Cook
Hi Linus, Please pull these two small seccomp updates for v5.12-rc1. This contains a fix for a build failure that went unnoticed for many years, and a memory barrier correction. Thanks! -Kees The following changes since commit e71ba9452f0b5b2e8dc8aa5445198cd9214a6a62: Linux 5.11-rc2

Re: [PATCH v3 4/8] cgroup: rstat: support cgroup1

2021-02-17 Thread Johannes Weiner
On Wed, Feb 17, 2021 at 06:42:32PM +0100, Michal Koutný wrote: > Hello. > > On Tue, Feb 09, 2021 at 11:33:00AM -0500, Johannes Weiner > wrote: > > @@ -1971,10 +1978,14 @@ int cgroup_setup_root(struct cgroup_root *root, u16 > > ss_mask) > > if (ret) > > goto destroy_root; > >

Re: [PATCH 3/3] Input: applespi: Add trace_event module param for early tracing.

2021-02-17 Thread Life is hard, and then you die
Hi Dmitry, On Wed, Feb 17, 2021 at 12:26:18PM -0800, Dmitry Torokhov wrote: > > On Wed, Feb 17, 2021 at 11:07:18AM -0800, Ronald Tschalär wrote: > > The problem is that tracing can't be set via sysfs until the module is > > loaded, at which point the keyboard and trackpad initialization

Re: [PATCH 1/3] Input: applespi: Don't wait for responses to commands indefinitely.

2021-02-17 Thread Life is hard, and then you die
Hi Dmitry, On Wed, Feb 17, 2021 at 12:23:23PM -0800, Dmitry Torokhov wrote: > > On Wed, Feb 17, 2021 at 11:07:16AM -0800, Ronald Tschalär wrote: > > @@ -869,7 +878,7 @@ static int applespi_send_cmd_msg(struct applespi_data > > *applespi) > > return sts; > > } > > > > -

Re: [RFC 1/2] mm: disable LRU pagevec during the migration temporarily

2021-02-17 Thread Minchan Kim
On Wed, Feb 17, 2021 at 10:50:55AM +0100, Michal Hocko wrote: > On Wed 17-02-21 09:59:54, Michal Hocko wrote: > > On Tue 16-02-21 09:03:47, Minchan Kim wrote: > [...] > > > /* > > > * migrate_prep() needs to be called before we start compiling a list of > > > pages > > > * to be migrated

Re: [PATCH v2] IMA: support for duplicate data measurement

2021-02-17 Thread Tushar Sugandhi
On 2021-02-17 12:39 p.m., Mimi Zohar wrote: On Wed, 2021-02-17 at 10:53 -0800, Tushar Sugandhi wrote: Thanks for the feedback Mimi. Appreciate it. On 2021-02-17 7:03 a.m., Mimi Zohar wrote: Hi Tushar, The Subject line could be improved. Perhaps something like - "IMA: support for

Re: [PATCH v3] vfs: fix copy_file_range regression in cross-fs copies

2021-02-17 Thread Amir Goldstein
On Wed, Feb 17, 2021 at 7:25 PM Luis Henriques wrote: > > A regression has been reported by Nicolas Boichat, found while using the > copy_file_range syscall to copy a tracefs file. Before commit > 5dae222a5ff0 ("vfs: allow copy_file_range to copy across devices") the > kernel would return -EXDEV

[PATCH v2 2/4] hugetlb/userfaultfd: Forbid huge pmd sharing when uffd enabled

2021-02-17 Thread Peter Xu
Huge pmd sharing could bring problem to userfaultfd. The thing is that userfaultfd is running its logic based on the special bits on page table entries, however the huge pmd sharing could potentially share page table entries for different address ranges. That could cause issues on either: -

[PATCH v2 4/4] hugetlb/userfaultfd: Unshare all pmds for hugetlbfs when register wp

2021-02-17 Thread Peter Xu
Huge pmd sharing for hugetlbfs is racy with userfaultfd-wp because userfaultfd-wp is always based on pgtable entries, so they cannot be shared. Walk the hugetlb range and unshare all such mappings if there is, right before UFFDIO_REGISTER will succeed and return to userspace. This will pair with

[PATCH v2 3/4] mm/hugetlb: Move flush_hugetlb_tlb_range() into hugetlb.h

2021-02-17 Thread Peter Xu
Prepare for it to be called outside of mm/hugetlb.c. Reviewed-by: Mike Kravetz Signed-off-by: Peter Xu --- include/linux/hugetlb.h | 8 mm/hugetlb.c| 8 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/include/linux/hugetlb.h

Re: [RFC 1/2] mm: disable LRU pagevec during the migration temporarily

2021-02-17 Thread Minchan Kim
On Wed, Feb 17, 2021 at 09:59:54AM +0100, Michal Hocko wrote: > On Tue 16-02-21 09:03:47, Minchan Kim wrote: > > LRU pagevec holds refcount of pages until the pagevec are drained. > > It could prevent migration since the refcount of the page is greater > > than the expection in migration logic. To

Re: [PATCH v1 13/18] media: hantro: Introduce G2/HEVC decoder

2021-02-17 Thread Ezequiel Garcia
Hi Benjamin, Before I review the implementation in detail, there's one thing that looks suspicious. On Wed, 2021-02-17 at 09:03 +0100, Benjamin Gaignard wrote: > Implement all the logic to get G2 hardware decoding HEVC frames. > It support up level 5.1 HEVC stream. > It doesn't support yet 10

Re: [PATCH v1 18/18] arm64: dts: imx8mq: Add node to G2 hardware

2021-02-17 Thread Ezequiel Garcia
On Wed, 2021-02-17 at 09:03 +0100, Benjamin Gaignard wrote: > Split VPU node in two: one for G1 and one for G2 since they are > different hardware blocks. > > Signed-off-by: Benjamin Gaignard > --- >  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 43 +-- >  1 file changed, 33

[PATCH v2 0/4] hugetlb: Disable huge pmd unshare for uffd-wp

2021-02-17 Thread Peter Xu
v2: - patch 4: move hugetlb_unshare_all_pmds() into mm/hugetlb.c, so it can be used even outside userfaultfd.c This series tries to disable huge pmd unshare of hugetlbfs backed memory for uffd-wp. Although uffd-wp of hugetlbfs is still during rfc stage, the idea of this series may be needed

Re: [PATCH v1 11/18] media: hantro: Add helper function for auxiliary buffers allocation

2021-02-17 Thread Ezequiel Garcia
Hi Benjamin, On Wed, 2021-02-17 at 09:02 +0100, Benjamin Gaignard wrote: > Add helper functions to allocate and free auxiliary buffers. > These buffers aren't for frames but are needed by the hardware > to store scaling matrix, tiles size, border filters etc... > > Signed-off-by: Benjamin

[GIT PULL] Performance events updates for v5.12

2021-02-17 Thread Ingo Molnar
Linus, Please pull the latest perf/core git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git perf-core-2021-02-17 # HEAD: 8bcfdd7cad3dffdd340f9a79098cbf331eb2cd53 Merge branch 'perf/kprobes' into perf/core, to pick up finished branch The performance event updates

[PATCH v2 1/4] hugetlb: Pass vma into huge_pte_alloc() and huge_pmd_share()

2021-02-17 Thread Peter Xu
It is a preparation work to be able to behave differently in the per architecture huge_pte_alloc() according to different VMA attributes. Pass it deeper into huge_pmd_share() so that we can avoid the find_vma() call. Suggested-by: Mike Kravetz Reviewed-by: Mike Kravetz Signed-off-by: Peter Xu

Re: [PATCH v2] IMA: support for duplicate data measurement

2021-02-17 Thread Mimi Zohar
On Wed, 2021-02-17 at 10:53 -0800, Tushar Sugandhi wrote: > Thanks for the feedback Mimi. > Appreciate it. > > On 2021-02-17 7:03 a.m., Mimi Zohar wrote: > > Hi Tushar, > > > > The Subject line could be improved. Perhaps something like - "IMA: > > support for duplicate measurement records" > >

Re: [PATCH] drm/msm/a6xx: fix for kernels without CONFIG_NVMEM

2021-02-17 Thread Jonathan Marek
On 2/17/21 3:18 PM, Rob Clark wrote: On Wed, Feb 17, 2021 at 11:08 AM Jordan Crouse wrote: On Wed, Feb 17, 2021 at 07:14:16PM +0530, Akhil P Oommen wrote: On 2/17/2021 8:36 AM, Rob Clark wrote: On Tue, Feb 16, 2021 at 12:10 PM Jonathan Marek wrote: Ignore nvmem_cell_get() EOPNOTSUPP

Re: [PATCH v1 10/18] media: hantro: Add helper functions for buffer information

2021-02-17 Thread Ezequiel Garcia
Hi Benjamin, On Wed, 2021-02-17 at 09:02 +0100, Benjamin Gaignard wrote: > Add help functions to retrieve buffer address and size. > > Signed-off-by: Benjamin Gaignard > Signed-off-by: Ezequiel Garcia > Signed-off-by: Adrian Ratiu > --- >  drivers/staging/media/hantro/hantro.h | 16

Re: [PATCH net-next] net: mdio: Remove of_phy_attach()

2021-02-17 Thread Andrew Lunn
On Wed, Feb 17, 2021 at 12:25:57PM -0800, Florian Fainelli wrote: > We have no in-tree users, also update the sfp-phylink.rst documentation > to indicate that phy_attach_direct() is used instead of of_phy_attach(). > > Signed-off-by: Florian Fainelli Reviewed-by: Andrew Lunn Andrew

[GIT PULL] f2fs update for 5.12-rc1

2021-02-17 Thread Jaegeuk Kim
Hi Linus, Could you please consider this pull request? Thanks, The following changes since commit 76c057c84d286140c6c416c3b4ba832cd1d8984e: Merge branch 'parisc-5.11-2' of git://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux (2021-01-27 11:06:15 -0800) are available in the

Re: [PATCH 2/2] ath9k: fix ath_tx_process_buffer() potential null ptr dereference

2021-02-17 Thread Shuah Khan
On 2/17/21 7:56 AM, Shuah Khan wrote: On 2/17/21 12:30 AM, Kalle Valo wrote: Shuah Khan writes: On 2/16/21 12:53 AM, Felix Fietkau wrote: On 2021-02-16 08:03, Kalle Valo wrote: Shuah Khan wrote: ath_tx_process_buffer() references ieee80211_find_sta_by_ifaddr() return pointer (sta)

Re: [RFC PATCH 5/5] mm proc/task_mmu.c: add hugetlb specific routine for clear_refs

2021-02-17 Thread Peter Xu
On Wed, Feb 10, 2021 at 04:03:22PM -0800, Mike Kravetz wrote: > There was is no hugetlb specific routine for clearing soft dirty and > other referrences. The 'default' routines would only clear the > VM_SOFTDIRTY flag in the vma. > > Add new routine specifically for hugetlb vmas. > >

Re: [PATCH 3/3] Input: applespi: Add trace_event module param for early tracing.

2021-02-17 Thread Dmitry Torokhov
Hi Ronald, On Wed, Feb 17, 2021 at 11:07:18AM -0800, Ronald Tschalär wrote: > The problem is that tracing can't be set via sysfs until the module is > loaded, at which point the keyboard and trackpad initialization commands > have already been run and hence tracing can't be used to debug problems

[PATCH net-next] net: mdio: Remove of_phy_attach()

2021-02-17 Thread Florian Fainelli
We have no in-tree users, also update the sfp-phylink.rst documentation to indicate that phy_attach_direct() is used instead of of_phy_attach(). Signed-off-by: Florian Fainelli --- Documentation/networking/sfp-phylink.rst | 2 +- drivers/net/mdio/of_mdio.c | 30

Re: [PATCH v2 1/2] dt-bindings: display: bridge: Add documentation for LT8912

2021-02-17 Thread Rob Herring
On Mon, 15 Feb 2021 00:29:03 +0100, Adrien Grassein wrote: > Lontium LT8912 is a DSI to HDMI bridge. > > Signed-off-by: Adrien Grassein > --- > .../display/bridge/lontium,lt8912.yaml| 102 ++ > MAINTAINERS | 5 + > 2 files changed, 107

<    1   2   3   4   5   6   7   8   9   10   >