Re: [PATCH 4/4] sched: Rename arch_update_thermal_pressure into arch_update_hw_pressure

2023-12-14 Thread Vincent Guittot
On Thu, 14 Dec 2023 at 09:30, Lukasz Luba wrote: > > > On 12/12/23 14:27, Vincent Guittot wrote: > > Now that cpufreq provides a pressure value to the scheduler, rename > > arch_update_thermal_pressure into hw pressure to reflect that it returns > > a pressure applied by HW with a high frequency

Re: [PATCH net-next v9 2/4] virtio/vsock: send credit update during setting SO_RCVLOWAT

2023-12-14 Thread Michael S. Tsirkin
On Thu, Dec 14, 2023 at 12:19:45PM +0300, Arseniy Krasnov wrote: > Send credit update message when SO_RCVLOWAT is updated and it is bigger > than number of bytes in rx queue. It is needed, because 'poll()' will > wait until number of bytes in rx queue will be not smaller than > SO_RCVLOWAT, so

Re: [PATCH v5 4/4] dax: add a sysfs knob to control memmap_on_memory behavior

2023-12-14 Thread Greg Kroah-Hartman
On Thu, Dec 14, 2023 at 12:37:57AM -0700, Vishal Verma wrote: > +static ssize_t memmap_on_memory_show(struct device *dev, > + struct device_attribute *attr, char *buf) > +{ > + struct dev_dax *dev_dax = to_dev_dax(dev); > + > + return sprintf(buf, "%d\n",

Re: [PATCH 4/4] sched: Rename arch_update_thermal_pressure into arch_update_hw_pressure

2023-12-14 Thread Lukasz Luba
On 12/12/23 14:27, Vincent Guittot wrote: Now that cpufreq provides a pressure value to the scheduler, rename arch_update_thermal_pressure into hw pressure to reflect that it returns a pressure applied by HW with a high frequency and which needs filtering. I would elaborte this meaning

Re: [PATCH net-next v8 0/4] send credit update during setting SO_RCVLOWAT

2023-12-14 Thread Stefano Garzarella
On Wed, Dec 13, 2023 at 08:11:57PM +0300, Arseniy Krasnov wrote: On 13.12.2023 18:13, Michael S. Tsirkin wrote: On Wed, Dec 13, 2023 at 10:05:44AM -0500, Michael S. Tsirkin wrote: On Wed, Dec 13, 2023 at 12:08:27PM +0300, Arseniy Krasnov wrote: On 13.12.2023 11:43, Stefano Garzarella

[ANNOUNCE] 4.19.299-rt130

2023-12-14 Thread Daniel Wagner
Hello RT-list! I'm pleased to announce the 4.19.299-rt130 stable release. This is just updating the stable release 4.19.299. No RT specific changes. There was a conflict due to the backport of 56e894982522 ("sched/rt: Provide migrate_disable/enable() inlines") to stable. Thus I dropped the

[PATCH net-next v9 2/4] virtio/vsock: send credit update during setting SO_RCVLOWAT

2023-12-14 Thread Arseniy Krasnov
Send credit update message when SO_RCVLOWAT is updated and it is bigger than number of bytes in rx queue. It is needed, because 'poll()' will wait until number of bytes in rx queue will be not smaller than SO_RCVLOWAT, so kick sender to send more data. Otherwise mutual hungup for tx/rx is

[PATCH net-next v9 1/4] virtio/vsock: fix logic which reduces credit update messages

2023-12-14 Thread Arseniy Krasnov
Add one more condition for sending credit update during dequeue from stream socket: when number of bytes in the rx queue is smaller than SO_RCVLOWAT value of the socket. This is actual for non-default value of SO_RCVLOWAT (e.g. not 1) - idea is to "kick" peer to continue data transmission, because

Re: [PATCH v2] virtio: Add support for no-reset virtio PCI PM

2023-12-14 Thread David Hildenbrand
On 08.12.23 08:07, David Stevens wrote: If a virtio_pci_device supports native PCI power management and has the No_Soft_Reset bit set, then skip resetting and reinitializing the device when suspending and restoring the device. This allows system-wide low power states like s2idle to be used in

Re: [PATCH net-next v9 3/4] vsock: update SO_RCVLOWAT setting callback

2023-12-14 Thread Arseniy Krasnov
On 14.12.2023 13:29, Michael S. Tsirkin wrote: > On Thu, Dec 14, 2023 at 12:19:46PM +0300, Arseniy Krasnov wrote: >> Do not return if transport callback for SO_RCVLOWAT is set (only in >> error case). In this case we don't need to set 'sk_rcvlowat' field in >> each transport - only in

Re: [PATCH net-next v9 3/4] vsock: update SO_RCVLOWAT setting callback

2023-12-14 Thread Michael S. Tsirkin
On Thu, Dec 14, 2023 at 01:52:50PM +0300, Arseniy Krasnov wrote: > > > On 14.12.2023 13:29, Michael S. Tsirkin wrote: > > On Thu, Dec 14, 2023 at 12:19:46PM +0300, Arseniy Krasnov wrote: > >> Do not return if transport callback for SO_RCVLOWAT is set (only in > >> error case). In this case we

[PATCH RT 0/1] Linux v4.19.302-rt131-rc1

2023-12-14 Thread Daniel Wagner
Dear RT Folks, This is the RT stable review cycle of patch 4.19.302-rt131-rc1. Please scream at me if I messed something up. Please test the patches too. The -rc release is also available on kernel.org https://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-stable-rt.git on the

[PATCH RT 1/1] Linux 4.19.302-rt131

2023-12-14 Thread Daniel Wagner
v4.19.302-rt131-rc1 stable review patch. If anyone has any objections, please let me know. --- Signed-off-by: Daniel Wagner --- localversion-rt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/localversion-rt b/localversion-rt index 6fa797e5b850..a328b97369c2 100644

Re: [PATCH 1/4] cpufreq: Add a cpufreq pressure feedback for the scheduler

2023-12-14 Thread Lukasz Luba
On 12/14/23 07:57, Vincent Guittot wrote: On Thu, 14 Dec 2023 at 06:43, Viresh Kumar wrote: On 12-12-23, 15:27, Vincent Guittot wrote: @@ -2618,6 +2663,9 @@ static int cpufreq_set_policy(struct cpufreq_policy *policy, policy->max = __resolve_freq(policy, policy->max,

Re: [PATCH 0/5] Rework system pressure interface to the scheduler

2023-12-14 Thread Vincent Guittot
On Thu, 14 Dec 2023 at 09:21, Lukasz Luba wrote: > > Hi Vincent, > > I've been waiting for this feature, thanks! > > > On 12/12/23 14:27, Vincent Guittot wrote: > > Following the consolidation and cleanup of CPU capacity in [1], this serie > > reworks how the scheduler gets the pressures on CPUs.

Re: [PATCH 4/4] sched: Rename arch_update_thermal_pressure into arch_update_hw_pressure

2023-12-14 Thread Lukasz Luba
On 12/14/23 08:36, Vincent Guittot wrote: On Thu, 14 Dec 2023 at 09:30, Lukasz Luba wrote: On 12/12/23 14:27, Vincent Guittot wrote: [snip] update_rq_clock(rq); - thermal_pressure = arch_scale_thermal_pressure(cpu_of(rq)); - update_thermal_load_avg(rq_clock_thermal(rq),

Re: [PATCH v5 3/4] mm/memory_hotplug: export mhp_supports_memmap_on_memory()

2023-12-14 Thread David Hildenbrand
On 14.12.23 08:37, Vishal Verma wrote: In preparation for adding sysfs ABI to toggle memmap_on_memory semantics for drivers adding memory, export the mhp_supports_memmap_on_memory() helper. This allows drivers to check if memmap_on_memory support is available before trying to request it, and

Re: [PATCH net-next v9 2/4] virtio/vsock: send credit update during setting SO_RCVLOWAT

2023-12-14 Thread Stefano Garzarella
On Thu, Dec 14, 2023 at 12:19:45PM +0300, Arseniy Krasnov wrote: Send credit update message when SO_RCVLOWAT is updated and it is bigger than number of bytes in rx queue. It is needed, because 'poll()' will wait until number of bytes in rx queue will be not smaller than SO_RCVLOWAT, so kick

Re: [PATCH net-next v9 0/4] send credit update during setting SO_RCVLOWAT

2023-12-14 Thread Stefano Garzarella
On Thu, Dec 14, 2023 at 12:19:43PM +0300, Arseniy Krasnov wrote: Hello, DESCRIPTION This patchset fixes old problem with hungup of both rx/tx sides and adds test for it. This happens due to non-default SO_RCVLOWAT value and deferred credit update in virtio/vsock.

Re: [PATCH 0/5] Rework system pressure interface to the scheduler

2023-12-14 Thread Lukasz Luba
Hi Vincent, I've been waiting for this feature, thanks! On 12/12/23 14:27, Vincent Guittot wrote: Following the consolidation and cleanup of CPU capacity in [1], this serie reworks how the scheduler gets the pressures on CPUs. We need to take into account all pressures applied by cpufreq on

Re: [PATCH 0/5] Rework system pressure interface to the scheduler

2023-12-14 Thread Lukasz Luba
On 12/14/23 08:29, Vincent Guittot wrote: On Thu, 14 Dec 2023 at 09:21, Lukasz Luba wrote: Hi Vincent, I've been waiting for this feature, thanks! On 12/12/23 14:27, Vincent Guittot wrote: Following the consolidation and cleanup of CPU capacity in [1], this serie reworks how the

Re: [PATCH 1/4] cpufreq: Add a cpufreq pressure feedback for the scheduler

2023-12-14 Thread Vincent Guittot
On Thu, 14 Dec 2023 at 10:20, Lukasz Luba wrote: > > > > On 12/12/23 14:27, Vincent Guittot wrote: > > Provide to the scheduler a feedback about the temporary max available > > capacity. Unlike arch_update_thermal_pressure, this doesn't need to be > > filtered as the pressure will happen for

[PATCH] [v2] nvdimm-btt: simplify code with the scope based resource management

2023-12-14 Thread Dinghao Liu
Use the scope based resource management (defined in linux/cleanup.h) to automate resource lifetime control on struct btt_sb *super in discover_arenas(). Signed-off-by: Dinghao Liu --- Changelog: v2: Set the __free attribute before kzalloc. --- drivers/nvdimm/btt.c | 13 - 1 file

Re: [PATCH 4/4] sched: Rename arch_update_thermal_pressure into arch_update_hw_pressure

2023-12-14 Thread Vincent Guittot
On Thu, 14 Dec 2023 at 09:53, Lukasz Luba wrote: > > > > On 12/14/23 08:36, Vincent Guittot wrote: > > On Thu, 14 Dec 2023 at 09:30, Lukasz Luba wrote: > >> > >> > >> On 12/12/23 14:27, Vincent Guittot wrote: > > [snip] > > >>>update_rq_clock(rq); > >>> - thermal_pressure =

Re: [PATCH 1/4] cpufreq: Add a cpufreq pressure feedback for the scheduler

2023-12-14 Thread Lukasz Luba
On 12/12/23 14:27, Vincent Guittot wrote: Provide to the scheduler a feedback about the temporary max available capacity. Unlike arch_update_thermal_pressure, this doesn't need to be filtered as the pressure will happen for dozens ms or more. Signed-off-by: Vincent Guittot ---

[PATCH net-next v9 0/4] send credit update during setting SO_RCVLOWAT

2023-12-14 Thread Arseniy Krasnov
Hello, DESCRIPTION This patchset fixes old problem with hungup of both rx/tx sides and adds test for it. This happens due to non-default SO_RCVLOWAT value and deferred credit update in virtio/vsock. Link to previous old patchset:

[PATCH net-next v9 4/4] vsock/test: two tests to check credit update logic

2023-12-14 Thread Arseniy Krasnov
Both tests are almost same, only differs in two 'if' conditions, so implemented in a single function. Tests check, that credit update message is sent: 1) During setting SO_RCVLOWAT value of the socket. 2) When number of 'rx_bytes' become smaller than SO_RCVLOWAT value. Signed-off-by: Arseniy

[PATCH net-next v9 3/4] vsock: update SO_RCVLOWAT setting callback

2023-12-14 Thread Arseniy Krasnov
Do not return if transport callback for SO_RCVLOWAT is set (only in error case). In this case we don't need to set 'sk_rcvlowat' field in each transport - only in 'vsock_set_rcvlowat()'. Also, if 'sk_rcvlowat' is now set only in af_vsock.c, change callback name from 'set_rcvlowat' to

Re: [PATCH net-next v9 3/4] vsock: update SO_RCVLOWAT setting callback

2023-12-14 Thread Michael S. Tsirkin
On Thu, Dec 14, 2023 at 12:19:46PM +0300, Arseniy Krasnov wrote: > Do not return if transport callback for SO_RCVLOWAT is set (only in > error case). In this case we don't need to set 'sk_rcvlowat' field in > each transport - only in 'vsock_set_rcvlowat()'. Also, if 'sk_rcvlowat' > is now set only

Re: [PATCH 0/2] ARM: dts: qcom: msm8926-motorola-peregrine: Add initial device tree

2023-12-14 Thread André Apitzsch
Am Mittwoch, dem 13.12.2023 um 21:44 +0100 schrieb Konrad Dybcio: > > > On 12/13/23 21:33, André Apitzsch wrote: > > This dts adds support for Motorola Moto G 4G released in 2013. > I have a similar one in my drawer.. not the 4g kind, titan IIRC? > Wasn't this one codenamed thea? > > Konrad

Re: [PATCH 1/4] cpufreq: Add a cpufreq pressure feedback for the scheduler

2023-12-14 Thread Rafael J. Wysocki
On Thu, Dec 14, 2023 at 10:07 AM Lukasz Luba wrote: > > On 12/14/23 07:57, Vincent Guittot wrote: > > On Thu, 14 Dec 2023 at 06:43, Viresh Kumar wrote: > >> > >> On 12-12-23, 15:27, Vincent Guittot wrote: > >>> @@ -2618,6 +2663,9 @@ static int cpufreq_set_policy(struct cpufreq_policy > >>>

Re: [PATCH 1/4] cpufreq: Add a cpufreq pressure feedback for the scheduler

2023-12-14 Thread Lukasz Luba
On 12/14/23 09:40, Rafael J. Wysocki wrote: On Thu, Dec 14, 2023 at 10:07 AM Lukasz Luba wrote: On 12/14/23 07:57, Vincent Guittot wrote: On Thu, 14 Dec 2023 at 06:43, Viresh Kumar wrote: On 12-12-23, 15:27, Vincent Guittot wrote: @@ -2618,6 +2663,9 @@ static int

[PATCH net-next v10 0/3] send credit update during setting SO_RCVLOWAT

2023-12-14 Thread Arseniy Krasnov
Hello, DESCRIPTION This patchset fixes old problem with hungup of both rx/tx sides and adds test for it. This happens due to non-default SO_RCVLOWAT value and deferred credit update in virtio/vsock. Link to previous old patchset:

[PATCH net-next v10 3/3] vsock/test: two tests to check credit update logic

2023-12-14 Thread Arseniy Krasnov
Both tests are almost same, only differs in two 'if' conditions, so implemented in a single function. Tests check, that credit update message is sent: 1) During setting SO_RCVLOWAT value of the socket. 2) When number of 'rx_bytes' become smaller than SO_RCVLOWAT value. Signed-off-by: Arseniy

Re: [PATCH net-next v9 3/4] vsock: update SO_RCVLOWAT setting callback

2023-12-14 Thread Arseniy Krasnov
On 14.12.2023 13:29, Michael S. Tsirkin wrote: > On Thu, Dec 14, 2023 at 12:19:46PM +0300, Arseniy Krasnov wrote: >> Do not return if transport callback for SO_RCVLOWAT is set (only in >> error case). In this case we don't need to set 'sk_rcvlowat' field in >> each transport - only in

[PATCH net-next v10 2/3] virtio/vsock: send credit update during setting SO_RCVLOWAT

2023-12-14 Thread Arseniy Krasnov
Send credit update message when SO_RCVLOWAT is updated and it is bigger than number of bytes in rx queue. It is needed, because 'poll()' will wait until number of bytes in rx queue will be not smaller than O_RCVLOWAT, so kick sender to send more data. Otherwise mutual hungup for tx/rx is possible:

[PATCH net-next v10 1/3] virtio/vsock: fix logic which reduces credit update messages

2023-12-14 Thread Arseniy Krasnov
Add one more condition for sending credit update during dequeue from stream socket: when number of bytes in the rx queue is smaller than SO_RCVLOWAT value of the socket. This is actual for non-default value of SO_RCVLOWAT (e.g. not 1) - idea is to "kick" peer to continue data transmission, because

Re: [PATCH vhost v2 4/8] vdpa/mlx5: Mark vq addrs for modification in hw vq

2023-12-14 Thread Dragos Tatulea
On Tue, 2023-12-12 at 15:44 -0800, Si-Wei Liu wrote: > > On 12/12/2023 11:21 AM, Eugenio Perez Martin wrote: > > On Tue, Dec 5, 2023 at 11:46 AM Dragos Tatulea wrote: > > > Addresses get set by .set_vq_address. hw vq addresses will be updated on > > > next modify_virtqueue. > > > > > >

Re: [PATCH] driver core: Add a guard() definition for the device_lock()

2023-12-14 Thread Dave Jiang
On 12/13/23 16:02, Dan Williams wrote: > At present there are ~200 usages of device_lock() in the kernel. Some of > those usages lead to "goto unlock;" patterns which have proven to be > error prone. Define a "device" guard() definition to allow for those to > be cleaned up and prevent new ones

Re: [PATCH] driver core: Add a guard() definition for the device_lock()

2023-12-14 Thread Greg KH
On Wed, Dec 13, 2023 at 03:02:35PM -0800, Dan Williams wrote: > At present there are ~200 usages of device_lock() in the kernel. Some of > those usages lead to "goto unlock;" patterns which have proven to be > error prone. Define a "device" guard() definition to allow for those to > be cleaned up

Re: [PATCH RFC v2 11/27] arm64: mte: Reserve tag storage memory

2023-12-14 Thread Alexandru Elisei
Hi, On Wed, Dec 13, 2023 at 02:30:42PM -0600, Rob Herring wrote: > On Wed, Dec 13, 2023 at 11:44 AM Alexandru Elisei > wrote: > > > > On Wed, Dec 13, 2023 at 11:22:17AM -0600, Rob Herring wrote: > > > On Wed, Dec 13, 2023 at 8:51 AM Alexandru Elisei > > > wrote: > > > > > > > > Hi, > > > > > >

Re: [PATCH] [v2] nvdimm-btt: simplify code with the scope based resource management

2023-12-14 Thread Dave Jiang
On 12/14/23 01:39, Dinghao Liu wrote: > Use the scope based resource management (defined in > linux/cleanup.h) to automate resource lifetime > control on struct btt_sb *super in discover_arenas(). > > Signed-off-by: Dinghao Liu Reviewed-by: Dave Jiang > --- > > Changelog: > > v2: Set the

Re: [PATCH vhost v2 4/8] vdpa/mlx5: Mark vq addrs for modification in hw vq

2023-12-14 Thread Michael S. Tsirkin
On Thu, Dec 14, 2023 at 01:39:55PM +, Dragos Tatulea wrote: > On Tue, 2023-12-12 at 15:44 -0800, Si-Wei Liu wrote: > > > > On 12/12/2023 11:21 AM, Eugenio Perez Martin wrote: > > > On Tue, Dec 5, 2023 at 11:46 AM Dragos Tatulea > > > wrote: > > > > Addresses get set by .set_vq_address. hw

Re: [PATCH vhost v2 4/8] vdpa/mlx5: Mark vq addrs for modification in hw vq

2023-12-14 Thread Dragos Tatulea
On Thu, 2023-12-14 at 08:45 -0500, Michael S. Tsirkin wrote: > On Thu, Dec 14, 2023 at 01:39:55PM +, Dragos Tatulea wrote: > > On Tue, 2023-12-12 at 15:44 -0800, Si-Wei Liu wrote: > > > > > > On 12/12/2023 11:21 AM, Eugenio Perez Martin wrote: > > > > On Tue, Dec 5, 2023 at 11:46 AM Dragos

Re: [PATCH -next 2/2] mm: vmscan: add new event to trace shrink lru

2023-12-14 Thread kernel test robot
://lore.kernel.org/r/20231212032640.6968-3-cuibixuan%40vivo.com patch subject: [PATCH -next 2/2] mm: vmscan: add new event to trace shrink lru config: i386-buildonly-randconfig-003-20231214 (https://download.01.org/0day-ci/archive/20231214/202312142212.vbse7cms-...@intel.com/config) compiler: gcc-11 (Debian

[PATCH RERESEND 04/11] tracing: tracing_buffers_splice_read: behave as-if non-blocking I/O

2023-12-14 Thread Ahelenia Ziemiańska
Otherwise we risk sleeping with the pipe locked for indeterminate lengths of time. Link: https://lore.kernel.org/linux-fsdevel/qk6hjuam54khlaikf2ssom6custxf5is2ekkaequf4hvode3ls@zgf7j5j4ubvw/t/#u Signed-off-by: Ahelenia Ziemiańska --- kernel/trace/trace.c | 32

[PATCH RERESEND 00/11] splice(file<>pipe) I/O on file as-if O_NONBLOCK

2023-12-14 Thread Ahelenia Ziemiańska
First: https://lore.kernel.org/lkml/cover.1697486714.git.nabijaczlew...@nabijaczleweli.xyz/t/#u Resend: https://lore.kernel.org/lkml/1cover.1697486714.git.nabijaczlew...@nabijaczleweli.xyz/t/#u Resending again per https://lore.kernel.org/lkml/20231214093859.01f6e...@kernel.org/t/#u Hi! As it

Re: [PATCH v3] ring-buffer: Remove 32bit timestamp logic

2023-12-14 Thread Linus Torvalds
On Thu, 14 Dec 2023 at 09:53, Steven Rostedt wrote: > > + /* > +* For architectures that can not do cmpxchg() in NMI, or require > +* disabling interrupts to do 64-bit cmpxchg(), do not allow them > +* to record in NMI context. > +*/ > + if

Re: [PATCH] ring-buffer: Remove 32bit timestamp logic

2023-12-14 Thread Steven Rostedt
On Thu, 14 Dec 2023 11:44:55 -0800 Linus Torvalds wrote: > On Thu, 14 Dec 2023 at 08:55, Steven Rostedt wrote: > > > > And yes, this does get called in NMI context. > > Not on an i486-class machine they won't. You don't have a local apic > on those, and they won't have any NMI sources under

Re: [PATCH v3] ring-buffer: Remove 32bit timestamp logic

2023-12-14 Thread Steven Rostedt
On Thu, 14 Dec 2023 12:32:38 -0800 Linus Torvalds wrote: > On Thu, 14 Dec 2023 at 12:30, Linus Torvalds > wrote: > > > > Read my email. Don't do random x86-centric things. We have that > > > > #ifndef system_has_cmpxchg64 > > #define system_has_cmpxchg64() false > > #endif > > > >

Re: [PATCH -next 2/2] mm: vmscan: add new event to trace shrink lru

2023-12-14 Thread kernel test robot
://lore.kernel.org/r/20231212032640.6968-3-cuibixuan%40vivo.com patch subject: [PATCH -next 2/2] mm: vmscan: add new event to trace shrink lru config: i386-randconfig-014-20231214 (https://download.01.org/0day-ci/archive/20231215/202312150018.eie4fkef-...@intel.com/config) compiler: clang version 16.0.4 (https

Re: [PATCH RFC v2 11/27] arm64: mte: Reserve tag storage memory

2023-12-14 Thread Rob Herring
On Thu, Dec 14, 2023 at 9:45 AM Alexandru Elisei wrote: > > Hi, > > On Wed, Dec 13, 2023 at 02:30:42PM -0600, Rob Herring wrote: > > On Wed, Dec 13, 2023 at 11:44 AM Alexandru Elisei > > wrote: > > > > > > On Wed, Dec 13, 2023 at 11:22:17AM -0600, Rob Herring wrote: > > > > On Wed, Dec 13, 2023

Re: [PATCH v3] ring-buffer: Remove 32bit timestamp logic

2023-12-14 Thread Steven Rostedt
On Thu, 14 Dec 2023 15:19:11 -0500 Steven Rostedt wrote: > For this issue of the 64bit cmpxchg, is there any config that works for any > arch that do not have a safe 64-bit cmpxchg? At least for 486, is the > second half of the if condition reasonable? > > if (IS_ENABLED(CONFIG_X86_32) &&

Re: [PATCH 0/2] ARM: dts: qcom: msm8926-motorola-peregrine: Add initial device tree

2023-12-14 Thread Konrad Dybcio
On 12/14/23 09:18, André Apitzsch wrote: Am Mittwoch, dem 13.12.2023 um 21:44 +0100 schrieb Konrad Dybcio: On 12/13/23 21:33, André Apitzsch wrote: This dts adds support for Motorola Moto G 4G released in 2013. I have a similar one in my drawer.. not the 4g kind, titan IIRC? Wasn't this

Re: [PATCH vhost v2 4/8] vdpa/mlx5: Mark vq addrs for modification in hw vq

2023-12-14 Thread Eugenio Perez Martin
On Thu, Dec 14, 2023 at 4:51 PM Dragos Tatulea wrote: > > On Thu, 2023-12-14 at 08:45 -0500, Michael S. Tsirkin wrote: > > On Thu, Dec 14, 2023 at 01:39:55PM +, Dragos Tatulea wrote: > > > On Tue, 2023-12-12 at 15:44 -0800, Si-Wei Liu wrote: > > > > > > > > On 12/12/2023 11:21 AM, Eugenio

Re: [PATCH RERESEND 00/11] splice(file<>pipe) I/O on file as-if O_NONBLOCK

2023-12-14 Thread Jens Axboe
On 12/14/23 11:44 AM, Ahelenia Ziemia?ska wrote: > First: > https://lore.kernel.org/lkml/cover.1697486714.git.nabijaczlew...@nabijaczleweli.xyz/t/#u > Resend: > https://lore.kernel.org/lkml/1cover.1697486714.git.nabijaczlew...@nabijaczleweli.xyz/t/#u > Resending again per >

Re: [PATCH v3] ring-buffer: Remove 32bit timestamp logic

2023-12-14 Thread Steven Rostedt
On Thu, 14 Dec 2023 11:46:55 -0800 Linus Torvalds wrote: > On Thu, 14 Dec 2023 at 09:53, Steven Rostedt wrote: > > > > + /* > > +* For architectures that can not do cmpxchg() in NMI, or require > > +* disabling interrupts to do 64-bit cmpxchg(), do not allow them > > +

Re: [PATCH v3] ring-buffer: Remove 32bit timestamp logic

2023-12-14 Thread Linus Torvalds
On Thu, 14 Dec 2023 at 12:18, Steven Rostedt wrote: > > For this issue of the 64bit cmpxchg, is there any config that works for any > arch that do not have a safe 64-bit cmpxchg? At least for 486, is the > second half of the if condition reasonable? > > if (IS_ENABLED(CONFIG_X86_32) &&

ARM64 Livepatch based on SFrame

2023-12-14 Thread Madhavan T. Venkataraman
Hi Mark, I attended your presentation in the LPC. You mentioned that you could use some help with some pre-requisites for the Livepatch feature. I would like to lend a hand. What would you like me to implement? I would also like to implement Unwind Hints for the feature. If you want a

[PATCH v3] ring-buffer: Remove 32bit timestamp logic

2023-12-14 Thread Steven Rostedt
From: "Steven Rostedt (Google)" Each event has a 27 bit timestamp delta that is used to hold the delta from the last event. If the time between events is greater than 2^27, then a timestamp is added that holds a 59 bit absolute timestamp. Until a389d86f7fd09 ("ring-buffer: Have nested events

Re: [PATCH v3] ring-buffer: Remove 32bit timestamp logic

2023-12-14 Thread Linus Torvalds
On Thu, 14 Dec 2023 at 12:30, Linus Torvalds wrote: > > Read my email. Don't do random x86-centric things. We have that > > #ifndef system_has_cmpxchg64 > #define system_has_cmpxchg64() false > #endif > > which should work. And again, by "should work" I mean that it would disable this

Re: [PATCH] ring-buffer: Remove 32bit timestamp logic

2023-12-14 Thread Steven Rostedt
On Wed, 13 Dec 2023 22:53:19 -0800 Linus Torvalds wrote: > On Wed, 13 Dec 2023 at 18:45, Steven Rostedt wrote: > > > > tl;dr; The ring-buffer timestamp requires a 64-bit cmpxchg to keep the > > timestamps in sync (only in the slow paths). I was told that 64-bit cmpxchg > > can be extremely

Re: [PATCH] ring-buffer: Remove 32bit timestamp logic

2023-12-14 Thread Linus Torvalds
On Thu, 14 Dec 2023 at 08:55, Steven Rostedt wrote: > > And yes, this does get called in NMI context. Not on an i486-class machine they won't. You don't have a local apic on those, and they won't have any NMI sources under our control (ie NMI does exist, but we're talking purely legacy NMI for

Re: [PATCH RERESEND 00/11] splice(file<>pipe) I/O on file as-if O_NONBLOCK

2023-12-14 Thread Ahelenia Ziemiańska
On Thu, Dec 14, 2023 at 12:06:57PM -0700, Jens Axboe wrote: > On 12/14/23 11:44 AM, Ahelenia Ziemiańska wrote: > > This does that, effectively making splice(file -> pipe) > > request (and require) O_NONBLOCK on reads fron the file: > > this doesn't affect splicing from regular files and blockdevs,

Re: [PATCH] ring-buffer: Remove 32bit timestamp logic

2023-12-14 Thread Linus Torvalds
On Thu, 14 Dec 2023 at 12:35, Steven Rostedt wrote: > > On Thu, 14 Dec 2023 11:44:55 -0800 > Linus Torvalds wrote: > > > On Thu, 14 Dec 2023 at 08:55, Steven Rostedt wrote: > > > > > > And yes, this does get called in NMI context. > > > > Not on an i486-class machine they won't. You don't have

Re: [PATCH] ring-buffer: Remove 32bit timestamp logic

2023-12-14 Thread Steven Rostedt
On Thu, 14 Dec 2023 12:50:29 -0800 Linus Torvalds wrote: > > But do all archs have an implementation of cmpxchg64, even if it requires > > disabling interrupts? If not, then I definitely cannot remove this code. > > We have a generic header file, so anybody who uses that would get the >

[PATCH v2 0/2] ARM: dts: qcom: msm8926-motorola-peregrine: Add initial device tree

2023-12-14 Thread André Apitzsch
This dts adds support for Motorola Moto G 4G released in 2013. Add a device tree with initial support for: - GPIO keys - Hall sensor - SDHCI - Vibrator Signed-off-by: André Apitzsch --- Changes in v2: - Make clear it's about Moto G 4G released in 2013. - Add a-b to patch 1/2. - Combine nodes

[PATCH] rpmsg: virtio: free driver_override when rpmsg_remove()

2023-12-14 Thread Xiaolei Wang
free driver_override when rpmsg_remove(), otherwise the following memory leak will occur: unreferenced object 0xd55d7080 (size 128): comm "kworker/u8:2", pid 56, jiffies 4294893188 (age 214.272s) hex dump (first 32 bytes): 72 70 6d 73 67 5f 6e 73 00 00 00 00 00 00 00 00

Re: [PATCH v2] virtio: Add support for no-reset virtio PCI PM

2023-12-14 Thread David Stevens
On Thu, Dec 14, 2023 at 6:47 PM David Hildenbrand wrote: > > On 08.12.23 08:07, David Stevens wrote: > > If a virtio_pci_device supports native PCI power management and has the > > No_Soft_Reset bit set, then skip resetting and reinitializing the device > > when suspending and restoring the

[PATCH v2 1/2] dt-bindings: arm: qcom: Add Motorola Moto G 4G (2013)

2023-12-14 Thread André Apitzsch
Document the compatible for the MSM8926-based Motorola Moto G 4G smartphone released in 2013. Acked-by: Krzysztof Kozlowski Signed-off-by: André Apitzsch --- Documentation/devicetree/bindings/arm/qcom.yaml | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH v2 2/2] ARM: dts: qcom: msm8926-motorola-peregrine: Add initial device tree

2023-12-14 Thread Konrad Dybcio
On 12/14/23 21:59, André Apitzsch wrote: This dts adds support for Motorola Moto G 4G released in 2013. Add a device tree with initial support for: - GPIO keys - Hall sensor - SDHCI - Vibrator Signed-off-by: André Apitzsch --- Excellent, thanks! Reviewed-by: Konrad Dybcio [...] +

Re: [PATCH] [v2] nvdimm-btt: fix several memleaks

2023-12-14 Thread Ira Weiny
Dinghao Liu wrote: > Resources allocated by kcalloc() in btt_freelist_init(), > btt_rtt_init(), and btt_maplocks_init() are not correctly > released in their callers when an error happens. For > example, when an error happens in btt_freelist_init(), its > caller discover_arenas() will directly

Re: [PATCH RESEND] mac802154: Fix uninit-value access in ieee802154_hdr_push_sechdr

2023-12-14 Thread Alexander Aring
Hi, On Mon, Dec 4, 2023 at 3:57 AM Miquel Raynal wrote: > > Hi Zhang, > > zhang_shur...@foxmail.com wrote on Sat, 2 Dec 2023 22:58:52 +0800: > > > The syzkaller reported an issue: > > Subject should start with [PATCH wpan] > > > > > BUG: KMSAN: uninit-value in ieee802154_hdr_push_sechdr > >

[PATCH v6 3/4] mm/memory_hotplug: export mhp_supports_memmap_on_memory()

2023-12-14 Thread Vishal Verma
In preparation for adding sysfs ABI to toggle memmap_on_memory semantics for drivers adding memory, export the mhp_supports_memmap_on_memory() helper. This allows drivers to check if memmap_on_memory support is available before trying to request it, and display an appropriate message if it isn't

[PATCH v6 4/4] dax: add a sysfs knob to control memmap_on_memory behavior

2023-12-14 Thread Vishal Verma
Add a sysfs knob for dax devices to control the memmap_on_memory setting if the dax device were to be hotplugged as system memory. The default memmap_on_memory setting for dax devices originating via pmem or hmem is set to 'false' - i.e. no memmap_on_memory semantics, to preserve legacy behavior.

Re: [PATCH RESEND] mac802154: Fix uninit-value access in ieee802154_hdr_push_sechdr

2023-12-14 Thread Alexander Aring
Hi, On Thu, Dec 14, 2023 at 10:01 PM Alexander Aring wrote: > > Hi, > > On Mon, Dec 4, 2023 at 3:57 AM Miquel Raynal > wrote: > > > > Hi Zhang, > > > > zhang_shur...@foxmail.com wrote on Sat, 2 Dec 2023 22:58:52 +0800: > > > > > The syzkaller reported an issue: > > > > Subject should start

[PATCH] ring-buffer: Do not try to put back write_stamp

2023-12-14 Thread Steven Rostedt
From: "Steven Rostedt (Google)" If an update to an event is interrupted by another event between the time the initial event allocated its buffer and where it wrote to the write_stamp, the code try to reset the write stamp back to the what it had just overwritten. It knows that it was overwritten

[PATCH v6 1/4] Documentatiion/ABI: Add ABI documentation for sys-bus-dax

2023-12-14 Thread Vishal Verma
Add the missing sysfs ABI documentation for the device DAX subsystem. Various ABI attributes under this have been present since v5.1, and more have been added over time. In preparation for adding a new attribute, add this file with the historical details. Cc: Dan Williams Signed-off-by: Vishal

[PATCH v6 0/4] Add DAX ABI for memmap_on_memory

2023-12-14 Thread Vishal Verma
2024 as that's likely when the 6.8 merge window will fall (Greg) - Fix dev->driver check (Ying) - Link to v5: https://lore.kernel.org/r/20231214-vv-dax_abi-v5-0-3f7b00696...@intel.com Changes in v5: - Export and check mhp_supports_memmap_on_memory() in the DAX sysfs ABI (David) - Obt

[PATCH v6 2/4] dax/bus: Use guard(device) in sysfs attribute helpers

2023-12-14 Thread Vishal Verma
Use the guard(device) macro to lock a 'struct device', and unlock it automatically when going out of scope using Scope Based Resource Management semantics. A lot of the sysfs attribute writes in drivers/dax/bus.c benefit from a cleanup using these, so change these where applicable. Cc: Joao

Re: [PATCH v6 2/4] dax/bus: Use guard(device) in sysfs attribute helpers

2023-12-14 Thread Verma, Vishal L
On Fri, 2023-12-15 at 05:56 +, Matthew Wilcox wrote: > On Thu, Dec 14, 2023 at 10:25:27PM -0700, Vishal Verma wrote: > > @@ -294,13 +294,10 @@ static ssize_t available_size_show(struct device *dev, > > struct device_attribute *attr, char *buf) > >  { > > struct

Re: [PATCH] ring-buffer: Do not try to put back write_stamp

2023-12-14 Thread Steven Rostedt
On Thu, 14 Dec 2023 22:18:03 -0500 Steven Rostedt wrote: > From: "Steven Rostedt (Google)" > > If an update to an event is interrupted by another event between the time > the initial event allocated its buffer and where it wrote to the > write_stamp, the code try to reset the write stamp back

Re: [PATCH v5 4/4] dax: add a sysfs knob to control memmap_on_memory behavior

2023-12-14 Thread Huang, Ying
Vishal Verma writes: > Add a sysfs knob for dax devices to control the memmap_on_memory setting > if the dax device were to be hotplugged as system memory. > > The default memmap_on_memory setting for dax devices originating via > pmem or hmem is set to 'false' - i.e. no memmap_on_memory

[PATCH v2] ring-buffer: Do not try to put back write_stamp

2023-12-14 Thread Steven Rostedt
From: "Steven Rostedt (Google)" If an update to an event is interrupted by another event between the time the initial event allocated its buffer and where it wrote to the write_stamp, the code try to reset the write stamp back to the what it had just overwritten. It knows that it was overwritten

Re: [PATCH v6 2/4] dax/bus: Use guard(device) in sysfs attribute helpers

2023-12-14 Thread Matthew Wilcox
On Thu, Dec 14, 2023 at 10:25:27PM -0700, Vishal Verma wrote: > @@ -294,13 +294,10 @@ static ssize_t available_size_show(struct device *dev, > struct device_attribute *attr, char *buf) > { > struct dax_region *dax_region = dev_get_drvdata(dev); > - unsigned long long size;

Re: [PATCH v6 4/4] dax: add a sysfs knob to control memmap_on_memory behavior

2023-12-14 Thread Huang, Ying
Vishal Verma writes: > Add a sysfs knob for dax devices to control the memmap_on_memory setting > if the dax device were to be hotplugged as system memory. > > The default memmap_on_memory setting for dax devices originating via > pmem or hmem is set to 'false' - i.e. no memmap_on_memory

Re: [PATCH v6 2/4] dax/bus: Use guard(device) in sysfs attribute helpers

2023-12-14 Thread Greg Kroah-Hartman
On Thu, Dec 14, 2023 at 10:25:27PM -0700, Vishal Verma wrote: > Use the guard(device) macro to lock a 'struct device', and unlock it > automatically when going out of scope using Scope Based Resource > Management semantics. A lot of the sysfs attribute writes in > drivers/dax/bus.c benefit from a