Re: [PATCH] hwtracing: intel_th: Change return type to vm_fault_t

2018-06-16 Thread Souptick Joarder
On Wed, May 2, 2018 at 7:32 PM, Souptick Joarder wrote: > On 02-May-2018 7:28 PM, "Alexander Shishkin" > wrote: >> >> On Wed, May 02, 2018 at 11:14:48AM +0530, Souptick Joarder wrote: >> > Any comment for this patch ? >> >> Looks good, I'm queuing this one for the next merge window. >> This

Re: [PATCH] hwtracing: intel_th: Change return type to vm_fault_t

2018-06-16 Thread Souptick Joarder
On Wed, May 2, 2018 at 7:32 PM, Souptick Joarder wrote: > On 02-May-2018 7:28 PM, "Alexander Shishkin" > wrote: >> >> On Wed, May 02, 2018 at 11:14:48AM +0530, Souptick Joarder wrote: >> > Any comment for this patch ? >> >> Looks good, I'm queuing this one for the next merge window. >> This

[PATCH 05/11] staging: rtl8723bs: Remove empty else-if conditional.

2018-06-16 Thread Quytelda Kahja
This else-if conditional block does nothing; remove it. Signed-off-by: Quytelda Kahja --- drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c index

[PATCH 05/11] staging: rtl8723bs: Remove empty else-if conditional.

2018-06-16 Thread Quytelda Kahja
This else-if conditional block does nothing; remove it. Signed-off-by: Quytelda Kahja --- drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c index

[PATCH 02/11] staging: rtl8723bs: Rename PHY_GetTxPowerLimit().

2018-06-16 Thread Quytelda Kahja
Rename camel-case 'PHY_GetTxPowerLimit()' to 'phy_get_tx_pwr_lmt()'. Signed-off-by: Quytelda Kahja --- drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 6 +++--- drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c| 2 +- drivers/staging/rtl8723bs/include/hal_com_phycfg.h | 2 +- 3 files

[PATCH 02/11] staging: rtl8723bs: Rename PHY_GetTxPowerLimit().

2018-06-16 Thread Quytelda Kahja
Rename camel-case 'PHY_GetTxPowerLimit()' to 'phy_get_tx_pwr_lmt()'. Signed-off-by: Quytelda Kahja --- drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 6 +++--- drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c| 2 +- drivers/staging/rtl8723bs/include/hal_com_phycfg.h | 2 +- 3 files

[PATCH 01/11] staging: rtl8723bs: Clean up whitespace in 'PHY_GetTxPowerLimit()'.

2018-06-16 Thread Quytelda Kahja
Wrap lines longer than 80 characters where possible, delete double newlines, and fix alignment per the kernel coding style guidelines. Signed-off-by: Quytelda Kahja --- .../staging/rtl8723bs/hal/hal_com_phycfg.c| 110 ++ 1 file changed, 59 insertions(+), 51 deletions(-)

[PATCH 07/11] staging: rtl8723bs: Move bandwidth index lookup to new function.

2018-06-16 Thread Quytelda Kahja
Factoring out the conditional lookup of bandwidth index into the power limit table into it's own function simplifies the logic of 'phy_get_tx_pwr_lmt()'. Signed-off-by: Quytelda Kahja --- .../staging/rtl8723bs/hal/hal_com_phycfg.c| 26 --- 1 file changed, 17 insertions(+), 9

[PATCH 06/11] staging: rtl8723bs: Move rate section index lookup to new function.

2018-06-16 Thread Quytelda Kahja
The rate section lookup is a large switch statement in the middle of 'phy_get_tx_pwr_lmt()'; refactor this statement into it's own function for increased readability. Signed-off-by: Quytelda Kahja --- .../staging/rtl8723bs/hal/hal_com_phycfg.c| 109 -- 1 file changed, 47

[PATCH 01/11] staging: rtl8723bs: Clean up whitespace in 'PHY_GetTxPowerLimit()'.

2018-06-16 Thread Quytelda Kahja
Wrap lines longer than 80 characters where possible, delete double newlines, and fix alignment per the kernel coding style guidelines. Signed-off-by: Quytelda Kahja --- .../staging/rtl8723bs/hal/hal_com_phycfg.c| 110 ++ 1 file changed, 59 insertions(+), 51 deletions(-)

[PATCH 07/11] staging: rtl8723bs: Move bandwidth index lookup to new function.

2018-06-16 Thread Quytelda Kahja
Factoring out the conditional lookup of bandwidth index into the power limit table into it's own function simplifies the logic of 'phy_get_tx_pwr_lmt()'. Signed-off-by: Quytelda Kahja --- .../staging/rtl8723bs/hal/hal_com_phycfg.c| 26 --- 1 file changed, 17 insertions(+), 9

[PATCH 06/11] staging: rtl8723bs: Move rate section index lookup to new function.

2018-06-16 Thread Quytelda Kahja
The rate section lookup is a large switch statement in the middle of 'phy_get_tx_pwr_lmt()'; refactor this statement into it's own function for increased readability. Signed-off-by: Quytelda Kahja --- .../staging/rtl8723bs/hal/hal_com_phycfg.c| 109 -- 1 file changed, 47

[PATCH 04/11] staging: rtl8723bs: Combine if statements with equivalent body.

2018-06-16 Thread Quytelda Kahja
Two if statements that carry out the same operation can be combined with a logical OR. Signed-off-by: Quytelda Kahja --- drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c

[PATCH 08/11] staging: rtl8723bs: Fix spelling mistake in comment.

2018-06-16 Thread Quytelda Kahja
Signed-off-by: Quytelda Kahja --- drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c index 6d8a07ac7bb3..dd097df86fa3 100644 ---

[PATCH 04/11] staging: rtl8723bs: Combine if statements with equivalent body.

2018-06-16 Thread Quytelda Kahja
Two if statements that carry out the same operation can be combined with a logical OR. Signed-off-by: Quytelda Kahja --- drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c

[PATCH 08/11] staging: rtl8723bs: Fix spelling mistake in comment.

2018-06-16 Thread Quytelda Kahja
Signed-off-by: Quytelda Kahja --- drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c index 6d8a07ac7bb3..dd097df86fa3 100644 ---

[PATCH 11/11] staging: rtl8723bs: Add missing curly braces on else statement.

2018-06-16 Thread Quytelda Kahja
Fix 'braces {} should be used on all arms of this statement' coding style problem in 'phy_get_tx_pwr_lmt()'. Signed-off-by: Quytelda Kahja --- drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH 03/11] staging: rtl8723bs: Fix camel-case names in phy_get_tx_pwr_lmt().

2018-06-16 Thread Quytelda Kahja
Change camel-case names to snake-case names; to avoid variable name conflicts, rename table index variables to idx_*. Signed-off-by: Quytelda Kahja --- .../staging/rtl8723bs/hal/hal_com_phycfg.c| 200 +- 1 file changed, 105 insertions(+), 95 deletions(-) diff --git

[PATCH 11/11] staging: rtl8723bs: Add missing curly braces on else statement.

2018-06-16 Thread Quytelda Kahja
Fix 'braces {} should be used on all arms of this statement' coding style problem in 'phy_get_tx_pwr_lmt()'. Signed-off-by: Quytelda Kahja --- drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH 03/11] staging: rtl8723bs: Fix camel-case names in phy_get_tx_pwr_lmt().

2018-06-16 Thread Quytelda Kahja
Change camel-case names to snake-case names; to avoid variable name conflicts, rename table index variables to idx_*. Signed-off-by: Quytelda Kahja --- .../staging/rtl8723bs/hal/hal_com_phycfg.c| 200 +- 1 file changed, 105 insertions(+), 95 deletions(-) diff --git

[PATCH 09/11] staging: rtl8723bs: Merge conditionals with similar bodies.

2018-06-16 Thread Quytelda Kahja
Two conditionals that set 'channel' based on 'band_type' in 'phy_get_tx_pwr_lmt()' can be simplified into one single-line conditional. Signed-off-by: Quytelda Kahja --- drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git

[PATCH 09/11] staging: rtl8723bs: Merge conditionals with similar bodies.

2018-06-16 Thread Quytelda Kahja
Two conditionals that set 'channel' based on 'band_type' in 'phy_get_tx_pwr_lmt()' can be simplified into one single-line conditional. Signed-off-by: Quytelda Kahja --- drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git

[PATCH 10/11] staging: rtl8723bs: Merge workaround conditionals into single else-if.

2018-06-16 Thread Quytelda Kahja
The if conditionals used to work around wrong TX power limit indices can be condensed into a single if/else-if statement for more concise expression. Signed-off-by: Quytelda Kahja --- drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-)

[PATCH 10/11] staging: rtl8723bs: Merge workaround conditionals into single else-if.

2018-06-16 Thread Quytelda Kahja
The if conditionals used to work around wrong TX power limit indices can be condensed into a single if/else-if statement for more concise expression. Signed-off-by: Quytelda Kahja --- drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-)

v4.18-rc1: Build and qemu test results

2018-06-16 Thread Guenter Roeck
Build results: total: 134 pass: 113 fail: 21 Failed builds: arm:allmodconfig c6x:dsk6455_defconfig c6x:evmc6457_defconfig c6x:evmc6678_defconfig h8300:allnoconfig h8300:edosk2674_defconfig h8300:h8300h-sim_defconfig

v4.18-rc1: Build and qemu test results

2018-06-16 Thread Guenter Roeck
Build results: total: 134 pass: 113 fail: 21 Failed builds: arm:allmodconfig c6x:dsk6455_defconfig c6x:evmc6457_defconfig c6x:evmc6678_defconfig h8300:allnoconfig h8300:edosk2674_defconfig h8300:h8300h-sim_defconfig

Re: [PATCH] PM / devfreq: Fix devfreq_add_device() when drivers are built as modules.

2018-06-16 Thread Chanwoo Choi
Hi Enric, This issue will happen on the position to use find_devfreq_governor() as following: - devfreq_add_governora() and governor_store() If device driver with module type after loaded want to change the scaling governor, new governor might be not yet loaded. So, devfreq bettero to consider

Re: [PATCH] PM / devfreq: Fix devfreq_add_device() when drivers are built as modules.

2018-06-16 Thread Chanwoo Choi
Hi Enric, This issue will happen on the position to use find_devfreq_governor() as following: - devfreq_add_governora() and governor_store() If device driver with module type after loaded want to change the scaling governor, new governor might be not yet loaded. So, devfreq bettero to consider

Re: XArray -next inclusion request

2018-06-16 Thread Stephen Rothwell
Hi Willy, On Sat, 16 Jun 2018 19:15:22 -0700 Matthew Wilcox wrote: > > Please add > > git://git.infradead.org/users/willy/linux-dax.git xarray > > to linux-next. It is based on -rc1. You will find some conflicts > against Dan's current patches to DAX; these are all resolved correctly > in

Re: XArray -next inclusion request

2018-06-16 Thread Stephen Rothwell
Hi Willy, On Sat, 16 Jun 2018 19:15:22 -0700 Matthew Wilcox wrote: > > Please add > > git://git.infradead.org/users/willy/linux-dax.git xarray > > to linux-next. It is based on -rc1. You will find some conflicts > against Dan's current patches to DAX; these are all resolved correctly > in

Re: [PATCH] devfreq: rk3399_dmc: Fix duplicated opp table on reload.

2018-06-16 Thread Chanwoo Choi
Hi Enric, 2018-06-16 0:12 GMT+09:00 Enric Balletbo i Serra : > The opp table is not removed when the driver is unloaded neither when > there is an error within probe, so if the driver is reloaded the opp > core shows the following warning: > > rk3399-dmc-freq dmc: _opp_add: duplicate OPPs

Re: [PATCH] devfreq: rk3399_dmc: Fix duplicated opp table on reload.

2018-06-16 Thread Chanwoo Choi
Hi Enric, 2018-06-16 0:12 GMT+09:00 Enric Balletbo i Serra : > The opp table is not removed when the driver is unloaded neither when > there is an error within probe, so if the driver is reloaded the opp > core shows the following warning: > > rk3399-dmc-freq dmc: _opp_add: duplicate OPPs

[PATCH v2] proc: Simplify and fix proc by removing the kernel mount

2018-06-16 Thread Eric W. Biederman
Today there are three users of proc_mnt. - The legacy sysctl system call implementation. - The uml mconsole driver. - The process cleanup function proc_flush_task. The first two are slow path and essentially unused. I expect soon we will be able to remove the legacy sysctl system call

[PATCH v2] proc: Simplify and fix proc by removing the kernel mount

2018-06-16 Thread Eric W. Biederman
Today there are three users of proc_mnt. - The legacy sysctl system call implementation. - The uml mconsole driver. - The process cleanup function proc_flush_task. The first two are slow path and essentially unused. I expect soon we will be able to remove the legacy sysctl system call

linux-next: stats (Was: Linux 4.18-rc1)

2018-06-16 Thread Stephen Rothwell
Hi all, As usual, the executive friendly graph is at http://neuling.org/linux-next-size.html :-) (No merge commits counted, next-20180604 was the first linux-next after the merge window opened.) Commits in v4.18-rc1 (relative to v4.17): 11594 Commits in next-20180604:

linux-next: stats (Was: Linux 4.18-rc1)

2018-06-16 Thread Stephen Rothwell
Hi all, As usual, the executive friendly graph is at http://neuling.org/linux-next-size.html :-) (No merge commits counted, next-20180604 was the first linux-next after the merge window opened.) Commits in v4.18-rc1 (relative to v4.17): 11594 Commits in next-20180604:

XArray -next inclusion request

2018-06-16 Thread Matthew Wilcox
Hi Stephen, Please add git://git.infradead.org/users/willy/linux-dax.git xarray to linux-next. It is based on -rc1. You will find some conflicts against Dan's current patches to DAX; these are all resolved correctly in the xarray-20180615 branch which is based on next-20180615. In a

[PATCH v14 32/74] page cache: Convert delete_batch to XArray

2018-06-16 Thread Matthew Wilcox
Rename the function from page_cache_tree_delete_batch to just page_cache_delete_batch. Signed-off-by: Matthew Wilcox --- mm/filemap.c | 28 +--- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/mm/filemap.c b/mm/filemap.c index 4204d9df003b..025077bc82be

XArray -next inclusion request

2018-06-16 Thread Matthew Wilcox
Hi Stephen, Please add git://git.infradead.org/users/willy/linux-dax.git xarray to linux-next. It is based on -rc1. You will find some conflicts against Dan's current patches to DAX; these are all resolved correctly in the xarray-20180615 branch which is based on next-20180615. In a

[PATCH v14 32/74] page cache: Convert delete_batch to XArray

2018-06-16 Thread Matthew Wilcox
Rename the function from page_cache_tree_delete_batch to just page_cache_delete_batch. Signed-off-by: Matthew Wilcox --- mm/filemap.c | 28 +--- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/mm/filemap.c b/mm/filemap.c index 4204d9df003b..025077bc82be

[PATCH] linux/device.h: fix kernel-doc notation warning

2018-06-16 Thread Randy Dunlap
From: Randy Dunlap Fix kernel-doc build warning (missing " *" at beginning of line): ../include/linux/device.h:93: warning: bad line: this bus. Fixes: 07397df29e57c ("dma-mapping: move dma configuration to bus infrastructure") Signed-off-by: Randy Dunlap Cc: Nipun

[PATCH] linux/device.h: fix kernel-doc notation warning

2018-06-16 Thread Randy Dunlap
From: Randy Dunlap Fix kernel-doc build warning (missing " *" at beginning of line): ../include/linux/device.h:93: warning: bad line: this bus. Fixes: 07397df29e57c ("dma-mapping: move dma configuration to bus infrastructure") Signed-off-by: Randy Dunlap Cc: Nipun

[PATCH 2/2] mm: set PG_dma_pinned on get_user_pages*()

2018-06-16 Thread john . hubbard
From: John Hubbard This fixes a few problems that come up when using devices (NICs, GPUs, for example) that want to have direct access to a chunk of system (CPU) memory, so that they can DMA to/from that memory. Problems [1] come up if that memory is backed by persistence storage; for example,

[PATCH 1/2] consolidate get_user_pages error handling

2018-06-16 Thread john . hubbard
From: John Hubbard In preparation for a subsequent patch, consolidate the error handling for __get_user_pages(). This provides a single location (the "out:" label) for operating on the collected set of pages that are about to be returned. As long as we are already touching every use of the

[PATCH 0/2] mm: gup: don't unmap or drop filesystem buffers

2018-06-16 Thread john . hubbard
From: John Hubbard Hi, I'm including people who have been talking about this. This is in one sense a medium-term work around, because there is a plan to talk about more extensive fixes at the upcoming Linux Plumbers Conference. I am seeing several customer bugs, though, and I really want to fix

[PATCH 2/2] mm: set PG_dma_pinned on get_user_pages*()

2018-06-16 Thread john . hubbard
From: John Hubbard This fixes a few problems that come up when using devices (NICs, GPUs, for example) that want to have direct access to a chunk of system (CPU) memory, so that they can DMA to/from that memory. Problems [1] come up if that memory is backed by persistence storage; for example,

[PATCH 1/2] consolidate get_user_pages error handling

2018-06-16 Thread john . hubbard
From: John Hubbard In preparation for a subsequent patch, consolidate the error handling for __get_user_pages(). This provides a single location (the "out:" label) for operating on the collected set of pages that are about to be returned. As long as we are already touching every use of the

[PATCH 0/2] mm: gup: don't unmap or drop filesystem buffers

2018-06-16 Thread john . hubbard
From: John Hubbard Hi, I'm including people who have been talking about this. This is in one sense a medium-term work around, because there is a plan to talk about more extensive fixes at the upcoming Linux Plumbers Conference. I am seeing several customer bugs, though, and I really want to fix

Re: [RFC PATCH 5/5] fsi/scom: Major overhaul

2018-06-16 Thread Benjamin Herrenschmidt
On Sun, 2018-06-17 at 11:17 +1000, Benjamin Herrenschmidt wrote: > > We have everything that cronus needs and more than pdbg needs afaik :-) > > That said, cronus does a bunch of other stupid things that I'm still > trying to figure out how to fix. > > We might need to create a /dev/cfam rather

Re: [RFC PATCH 5/5] fsi/scom: Major overhaul

2018-06-16 Thread Benjamin Herrenschmidt
On Sun, 2018-06-17 at 11:17 +1000, Benjamin Herrenschmidt wrote: > > We have everything that cronus needs and more than pdbg needs afaik :-) > > That said, cronus does a bunch of other stupid things that I'm still > trying to figure out how to fix. > > We might need to create a /dev/cfam rather

Re: [RFC PATCH 5/5] fsi/scom: Major overhaul

2018-06-16 Thread Benjamin Herrenschmidt
On Sat, 2018-06-16 at 14:34 +0930, Joel Stanley wrote: > On 12 June 2018 at 14:49, Benjamin Herrenschmidt > wrote: > > This was too hard to split ... this adds a number of features > > to the SCOM user interface: > > > > - Support for indirect SCOMs > > > > - read()/write() interface now

Re: [RFC PATCH 5/5] fsi/scom: Major overhaul

2018-06-16 Thread Benjamin Herrenschmidt
On Sat, 2018-06-16 at 14:34 +0930, Joel Stanley wrote: > On 12 June 2018 at 14:49, Benjamin Herrenschmidt > wrote: > > This was too hard to split ... this adds a number of features > > to the SCOM user interface: > > > > - Support for indirect SCOMs > > > > - read()/write() interface now

Re: [PATCH v4 1/9] Makefile: Prepare for using macros for inline asm

2018-06-16 Thread Masahiro Yamada
2018-06-14 5:36 GMT+09:00 Sam Ravnborg : >> >> > +macros: $(obj)/macros.s >> > + @: >> >> If you add a phony target, it should be added to 'PHONY'. > > Or this part: >> +archmacros: >> + $(Q)$(MAKE) $(build)=arch/x86/kernel macros > > could be modified to specify the exact filename so

Re: [PATCH v4 1/9] Makefile: Prepare for using macros for inline asm

2018-06-16 Thread Masahiro Yamada
2018-06-14 5:36 GMT+09:00 Sam Ravnborg : >> >> > +macros: $(obj)/macros.s >> > + @: >> >> If you add a phony target, it should be added to 'PHONY'. > > Or this part: >> +archmacros: >> + $(Q)$(MAKE) $(build)=arch/x86/kernel macros > > could be modified to specify the exact filename so

Re: [PATCH v4 1/9] Makefile: Prepare for using macros for inline asm

2018-06-16 Thread Masahiro Yamada
Hi. 2018-06-14 7:19 GMT+09:00 Nadav Amit : >> >> >> I have not fully understood this series yet. >> >> I do not have enough skill in x86 architecture, >> but just some comments from the build system point of view. >> >> >> >> I guess this will probably break the parallel building. >> >> Kbuild

Re: [PATCH v4 1/9] Makefile: Prepare for using macros for inline asm

2018-06-16 Thread Masahiro Yamada
Hi. 2018-06-14 7:19 GMT+09:00 Nadav Amit : >> >> >> I have not fully understood this series yet. >> >> I do not have enough skill in x86 architecture, >> but just some comments from the build system point of view. >> >> >> >> I guess this will probably break the parallel building. >> >> Kbuild

[RFC PATCH] x86/arch_prctl: Add ARCH_SET_XCR0 to mask XCR0 per-thread

2018-06-16 Thread Keno Fischer
From: Keno Fischer The rr (http://rr-project.org/) debugger provides user space record-and-replay functionality by carefully controlling the process environment in order to ensure completely deterministic execution of recorded traces. The recently added ARCH_SET_CPUID arch_prctl allows rr to

[RFC PATCH] x86/arch_prctl: Add ARCH_SET_XCR0 to mask XCR0 per-thread

2018-06-16 Thread Keno Fischer
From: Keno Fischer The rr (http://rr-project.org/) debugger provides user space record-and-replay functionality by carefully controlling the process environment in order to ensure completely deterministic execution of recorded traces. The recently added ARCH_SET_CPUID arch_prctl allows rr to

Re: [PATCH] extcon: Release locking when sending the notification of connector state

2018-06-16 Thread Chanwoo Choi
Hi, 2018-06-14 20:33 GMT+09:00 H. Nikolaus Schaller : > >> Am 14.06.2018 um 12:39 schrieb H. Nikolaus Schaller : >> >> Hi Roger and Chanwoo, >> >>> Am 14.06.2018 um 12:18 schrieb Chanwoo Choi : >>> >>> + H. Nikolaus Schaller >>> >>> On 2018년 06월 14일 13:14, Chanwoo Choi wrote: Previously,

Re: [PATCH] extcon: Release locking when sending the notification of connector state

2018-06-16 Thread Chanwoo Choi
Hi, 2018-06-14 20:33 GMT+09:00 H. Nikolaus Schaller : > >> Am 14.06.2018 um 12:39 schrieb H. Nikolaus Schaller : >> >> Hi Roger and Chanwoo, >> >>> Am 14.06.2018 um 12:18 schrieb Chanwoo Choi : >>> >>> + H. Nikolaus Schaller >>> >>> On 2018년 06월 14일 13:14, Chanwoo Choi wrote: Previously,

[PATCH 2/2] kbuild: do not update config for 'make kernelrelease'

2018-06-16 Thread Masahiro Yamada
'make kernelrelease' depends on CONFIG_LOCALVERSION(_AUTO), but for the same reason as install targets, we do not want to update the configuration just for printing the kernelrelease string. This is likely to happen if you forget to pass CROSS_COMPILE when running 'make kernelrelease' in the

[PATCH 2/2] kbuild: do not update config for 'make kernelrelease'

2018-06-16 Thread Masahiro Yamada
'make kernelrelease' depends on CONFIG_LOCALVERSION(_AUTO), but for the same reason as install targets, we do not want to update the configuration just for printing the kernelrelease string. This is likely to happen if you forget to pass CROSS_COMPILE when running 'make kernelrelease' in the

[PATCH 1/2] kbuild: do not update config when running install targets

2018-06-16 Thread Masahiro Yamada
"make syncconfig" is automatically invoked when any of the following happens: - .config is updated - any of Kconfig files is updated - any of environment variables referenced in Kconfig is changed Then, it updates configuration files such as include/config/auto.conf

[PATCH 1/2] kbuild: do not update config when running install targets

2018-06-16 Thread Masahiro Yamada
"make syncconfig" is automatically invoked when any of the following happens: - .config is updated - any of Kconfig files is updated - any of environment variables referenced in Kconfig is changed Then, it updates configuration files such as include/config/auto.conf

Linux 4.18-rc1

2018-06-16 Thread Linus Torvalds
You may think it's still Saturday for me, and that I should give you one more day of merge window to send in some last-minute pull requests, but I know better. I'm in Japan, and it's Sunday here. Plus I hope to spend much of this Sunday on a boat (assuming the swells allow it), so I'm closing the

Linux 4.18-rc1

2018-06-16 Thread Linus Torvalds
You may think it's still Saturday for me, and that I should give you one more day of merge window to send in some last-minute pull requests, but I know better. I'm in Japan, and it's Sunday here. Plus I hope to spend much of this Sunday on a boat (assuming the swells allow it), so I'm closing the

Re: [PATCH] staging: rtl8192u: fix line over 80 characters

2018-06-16 Thread Joe Perches
On Sat, 2018-06-16 at 15:22 -0400, valdis.kletni...@vt.edu wrote: > On Sat, 16 Jun 2018 15:00:31 +0900, Hyunil Kim said: > > *fix checkpatch.pl warnings: > > WARNING: line over 80 characters > > + if (((ieee->wpa_ie[0] == 0xdd) && > > + (!memcmp(&(ieee->wpa_ie[14]),

Re: [PATCH] staging: rtl8192u: fix line over 80 characters

2018-06-16 Thread Joe Perches
On Sat, 2018-06-16 at 15:22 -0400, valdis.kletni...@vt.edu wrote: > On Sat, 16 Jun 2018 15:00:31 +0900, Hyunil Kim said: > > *fix checkpatch.pl warnings: > > WARNING: line over 80 characters > > + if (((ieee->wpa_ie[0] == 0xdd) && > > + (!memcmp(&(ieee->wpa_ie[14]),

Re: [PATCH v2] staging: rtl8712: Adjust if statements to reduce indentation level

2018-06-16 Thread Joe Perches
On Sat, 2018-06-16 at 15:03 +0900, Joonhwan Kim wrote: > Merge two condition of if statements in > r8712_surveydone_event_callback() Are you sure you are not changing the logic here? I think it'd be nicer to refactor the code instead. Something like: --- drivers/staging/rtl8712/rtl871x_mlme.c

Re: [PATCH v2] staging: rtl8712: Adjust if statements to reduce indentation level

2018-06-16 Thread Joe Perches
On Sat, 2018-06-16 at 15:03 +0900, Joonhwan Kim wrote: > Merge two condition of if statements in > r8712_surveydone_event_callback() Are you sure you are not changing the logic here? I think it'd be nicer to refactor the code instead. Something like: --- drivers/staging/rtl8712/rtl871x_mlme.c

Re: [PATCH 01/11] staging: lustre: simplify use of interval-tree.

2018-06-16 Thread NeilBrown
On Sat, Jun 16 2018, James Simmons wrote: >> Lustre has a private interval-tree implementation. This >> implementation (inexplicably) refuses to insert an interval if an >> identical interval already exists. It is OK with all sorts of >> overlapping intervals, but identical intervals are

Re: [PATCH 01/11] staging: lustre: simplify use of interval-tree.

2018-06-16 Thread NeilBrown
On Sat, Jun 16 2018, James Simmons wrote: >> Lustre has a private interval-tree implementation. This >> implementation (inexplicably) refuses to insert an interval if an >> identical interval already exists. It is OK with all sorts of >> overlapping intervals, but identical intervals are

[PATCH] firmware: Update Kconfig help text for Google firmware

2018-06-16 Thread Ben Hutchings
The help text for GOOGLE_FIRMWARE states that it should only be enabled when building a kernel for Google's own servers. However, it is now also a dependency for various Chromebook firmware drivers. Update the help text to reflect this double duty. Add the qualifier "server" to the help text

[PATCH] firmware: Update Kconfig help text for Google firmware

2018-06-16 Thread Ben Hutchings
The help text for GOOGLE_FIRMWARE states that it should only be enabled when building a kernel for Google's own servers. However, it is now also a dependency for various Chromebook firmware drivers. Update the help text to reflect this double duty. Add the qualifier "server" to the help text

Re: wmi: usercopy: Kernel memory overwrite attempt detected to spans multiple pages (offset 0, size 4104)

2018-06-16 Thread Mihai Donțu
On Sun, 2018-06-17 at 00:01 +0300, Mihai Donțu wrote: > While trying to adjust the keyboard backlight mode, I hit this BUG: > > Jun 16 22:16:07 mdontu-l kernel: usercopy: Kernel memory overwrite attempt > detected to spans multiple pages (offset 0, size 4104)! > Jun 16 22:16:07 mdontu-l kernel:

Re: wmi: usercopy: Kernel memory overwrite attempt detected to spans multiple pages (offset 0, size 4104)

2018-06-16 Thread Mihai Donțu
On Sun, 2018-06-17 at 00:01 +0300, Mihai Donțu wrote: > While trying to adjust the keyboard backlight mode, I hit this BUG: > > Jun 16 22:16:07 mdontu-l kernel: usercopy: Kernel memory overwrite attempt > detected to spans multiple pages (offset 0, size 4104)! > Jun 16 22:16:07 mdontu-l kernel:

x86_64: movdqu rarely stores bad data (movdqu works fine). Kernel bug, fried CPU or glibc bug?

2018-06-16 Thread Sergei Trofimovich
TL;DR: on master string/test-memmove glibc test fails on my machine and I don't know why. Other tests work fine. $ elf/ld.so --inhibit-cache --library-path . string/test-memmove simple_memmove __memmove_ssse3_rep __memmove_ssse3 __memmove_sse2_unaligned

x86_64: movdqu rarely stores bad data (movdqu works fine). Kernel bug, fried CPU or glibc bug?

2018-06-16 Thread Sergei Trofimovich
TL;DR: on master string/test-memmove glibc test fails on my machine and I don't know why. Other tests work fine. $ elf/ld.so --inhibit-cache --library-path . string/test-memmove simple_memmove __memmove_ssse3_rep __memmove_ssse3 __memmove_sse2_unaligned

Re: [PATCH 3.16 000/410] 3.16.57-rc1 review

2018-06-16 Thread Ben Hutchings
On Fri, 2018-06-08 at 07:14 -0700, Guenter Roeck wrote: > On Thu, Jun 07, 2018 at 03:05:20PM +0100, Ben Hutchings wrote: > > This is the start of the stable review cycle for the 3.16.57 release. > > There are 410 patches in this series, which will be posted as responses > > to this one. If anyone

Re: [PATCH 3.16 000/410] 3.16.57-rc1 review

2018-06-16 Thread Ben Hutchings
On Fri, 2018-06-08 at 07:14 -0700, Guenter Roeck wrote: > On Thu, Jun 07, 2018 at 03:05:20PM +0100, Ben Hutchings wrote: > > This is the start of the stable review cycle for the 3.16.57 release. > > There are 410 patches in this series, which will be posted as responses > > to this one. If anyone

Re: [PATCH 3.16 183/410] mm: pin address_space before dereferencing it while isolating an LRU page

2018-06-16 Thread Ben Hutchings
On Sun, 2018-06-10 at 11:06 -0700, Hugh Dickins wrote: > On Thu, 7 Jun 2018, Ben Hutchings wrote: > > > 3.16.57-rc1 review patch. If anyone has any objections, please let me know. > > Not an objection as such, but if you're including this one, > please be sure to add

Re: [PATCH 3.16 183/410] mm: pin address_space before dereferencing it while isolating an LRU page

2018-06-16 Thread Ben Hutchings
On Sun, 2018-06-10 at 11:06 -0700, Hugh Dickins wrote: > On Thu, 7 Jun 2018, Ben Hutchings wrote: > > > 3.16.57-rc1 review patch. If anyone has any objections, please let me know. > > Not an objection as such, but if you're including this one, > please be sure to add

Re: [PATCH 3.16 012/410] scsi: libsas: direct call probe and destruct

2018-06-16 Thread Ben Hutchings
On Fri, 2018-06-08 at 09:32 +0800, Jason Yan wrote: > On 2018/6/8 2:18, Ben Hutchings wrote: > > On Thu, 2018-06-07 at 17:32 +0100, John Garry wrote: > > > On 07/06/2018 15:05, Ben Hutchings wrote: > > > > 3.16.57-rc1 review patch. If anyone has any objections, please let me > > > > know. > > >

Re: [PATCH 3.16 012/410] scsi: libsas: direct call probe and destruct

2018-06-16 Thread Ben Hutchings
On Fri, 2018-06-08 at 09:32 +0800, Jason Yan wrote: > On 2018/6/8 2:18, Ben Hutchings wrote: > > On Thu, 2018-06-07 at 17:32 +0100, John Garry wrote: > > > On 07/06/2018 15:05, Ben Hutchings wrote: > > > > 3.16.57-rc1 review patch. If anyone has any objections, please let me > > > > know. > > >

wmi: usercopy: Kernel memory overwrite attempt detected to spans multiple pages (offset 0, size 4104)

2018-06-16 Thread Mihai Donțu
Hi, While trying to adjust the keyboard backlight mode, I hit this BUG: Jun 16 22:16:07 mdontu-l kernel: usercopy: Kernel memory overwrite attempt detected to spans multiple pages (offset 0, size 4104)! Jun 16 22:16:07 mdontu-l kernel: [ cut here ] Jun 16 22:16:07

wmi: usercopy: Kernel memory overwrite attempt detected to spans multiple pages (offset 0, size 4104)

2018-06-16 Thread Mihai Donțu
Hi, While trying to adjust the keyboard backlight mode, I hit this BUG: Jun 16 22:16:07 mdontu-l kernel: usercopy: Kernel memory overwrite attempt detected to spans multiple pages (offset 0, size 4104)! Jun 16 22:16:07 mdontu-l kernel: [ cut here ] Jun 16 22:16:07

Re: [PATCH 2/4] MIPS: Add syscall detection for restartable sequences

2018-06-16 Thread Mathieu Desnoyers
- On Jun 15, 2018, at 2:43 PM, Paul Burton paul.bur...@mips.com wrote: > Hi Mathieu, > > On Fri, Jun 15, 2018 at 01:41:25PM -0400, Mathieu Desnoyers wrote: >> > diff --git a/arch/mips/kernel/entry.S b/arch/mips/kernel/entry.S >> > index 38a302919e6b..d7de8adcfcc8 100644 >> > ---

Re: [PATCH 2/4] MIPS: Add syscall detection for restartable sequences

2018-06-16 Thread Mathieu Desnoyers
- On Jun 15, 2018, at 2:43 PM, Paul Burton paul.bur...@mips.com wrote: > Hi Mathieu, > > On Fri, Jun 15, 2018 at 01:41:25PM -0400, Mathieu Desnoyers wrote: >> > diff --git a/arch/mips/kernel/entry.S b/arch/mips/kernel/entry.S >> > index 38a302919e6b..d7de8adcfcc8 100644 >> > ---

Re: [PATCH 0/4] MIPS: Restartable sequences (rseq) support

2018-06-16 Thread Mathieu Desnoyers
- On Jun 14, 2018, at 7:52 PM, Paul Burton paul.bur...@mips.com wrote: > This series implements MIPS support for restartable sequences, hooks up > the rseq syscall & implements MIPS support in the rseq selftests. > > Applies atop Linus' master as of 2837461dbe6f ("Merge tag 'scsi-fixes' > of

Re: [PATCH 0/4] MIPS: Restartable sequences (rseq) support

2018-06-16 Thread Mathieu Desnoyers
- On Jun 14, 2018, at 7:52 PM, Paul Burton paul.bur...@mips.com wrote: > This series implements MIPS support for restartable sequences, hooks up > the rseq syscall & implements MIPS support in the rseq selftests. > > Applies atop Linus' master as of 2837461dbe6f ("Merge tag 'scsi-fixes' > of

[RFC PATCH for 4.18] rseq: cleanup: no need to abort rseq c.s. in child on fork

2018-06-16 Thread Mathieu Desnoyers
Considering that we explicitly forbid system calls in rseq critical sections, it is not valid to issue a fork or clone system call within a rseq critical section, so rseq_fork() is not required to restart an active rseq c.s. in the child process. Signed-off-by: Mathieu Desnoyers Cc: Thomas

[RFC PATCH for 4.18] rseq: cleanup: no need to abort rseq c.s. in child on fork

2018-06-16 Thread Mathieu Desnoyers
Considering that we explicitly forbid system calls in rseq critical sections, it is not valid to issue a fork or clone system call within a rseq critical section, so rseq_fork() is not required to restart an active rseq c.s. in the child process. Signed-off-by: Mathieu Desnoyers Cc: Thomas

[RFC PATCH man-pages] Add rseq manpage

2018-06-16 Thread Mathieu Desnoyers
Signed-off-by: Mathieu Desnoyers CC: "Paul E. McKenney" CC: Peter Zijlstra CC: Paul Turner CC: Thomas Gleixner CC: Andrew Hunter CC: Andy Lutomirski CC: Andi Kleen CC: Dave Watson CC: Chris Lameter CC: Ingo Molnar CC: "H. Peter Anvin" CC: Ben Maurer CC: Steven Rostedt CC: Josh

[RFC PATCH man-pages] Add rseq manpage

2018-06-16 Thread Mathieu Desnoyers
Signed-off-by: Mathieu Desnoyers CC: "Paul E. McKenney" CC: Peter Zijlstra CC: Paul Turner CC: Thomas Gleixner CC: Andrew Hunter CC: Andy Lutomirski CC: Andi Kleen CC: Dave Watson CC: Chris Lameter CC: Ingo Molnar CC: "H. Peter Anvin" CC: Ben Maurer CC: Steven Rostedt CC: Josh

[RFC PATCH for 4.18 1/2] rseq/selftests: run_param_test.sh should be executable

2018-06-16 Thread Mathieu Desnoyers
The executable bit of the run_param_test.sh script got lost in the merge. Signed-off-by: Mathieu Desnoyers Cc: Thomas Gleixner Cc: Joel Fernandes Cc: Peter Zijlstra Cc: Catalin Marinas Cc: Dave Watson Cc: Will Deacon Cc: Shuah Khan Cc: Andi Kleen Cc: linux-kselft...@vger.kernel.org Cc:

[RFC PATCH for 4.18 2/2] rseq/selftests: arm: align struct rseq_cs on 32 bytes

2018-06-16 Thread Mathieu Desnoyers
uapi/linux/rseq.h aligns struct rseq_cs on 32 bytes. Satisfy this alignment requirement in its definition within the rseq-arm.h inline assembly. Signed-off-by: Mathieu Desnoyers Cc: Thomas Gleixner Cc: Joel Fernandes Cc: Peter Zijlstra Cc: Catalin Marinas Cc: Dave Watson Cc: Will Deacon

[RFC PATCH for 4.18 1/2] rseq/selftests: run_param_test.sh should be executable

2018-06-16 Thread Mathieu Desnoyers
The executable bit of the run_param_test.sh script got lost in the merge. Signed-off-by: Mathieu Desnoyers Cc: Thomas Gleixner Cc: Joel Fernandes Cc: Peter Zijlstra Cc: Catalin Marinas Cc: Dave Watson Cc: Will Deacon Cc: Shuah Khan Cc: Andi Kleen Cc: linux-kselft...@vger.kernel.org Cc:

[RFC PATCH for 4.18 2/2] rseq/selftests: arm: align struct rseq_cs on 32 bytes

2018-06-16 Thread Mathieu Desnoyers
uapi/linux/rseq.h aligns struct rseq_cs on 32 bytes. Satisfy this alignment requirement in its definition within the rseq-arm.h inline assembly. Signed-off-by: Mathieu Desnoyers Cc: Thomas Gleixner Cc: Joel Fernandes Cc: Peter Zijlstra Cc: Catalin Marinas Cc: Dave Watson Cc: Will Deacon

[RFC PATCH for 4.18 0/2] Restartable Sequences selftests fixes

2018-06-16 Thread Mathieu Desnoyers
Those are trivial restartable sequences selftest fixes for 4.18. The executable flag of run_param_test.sh got lost in the merge of the rseq patchset. On ARM, align the struct rseq_cs definition in the inline asm to match the alignment of that structure in the uapi headers. Thanks, Mathieu

[RFC PATCH for 4.18 0/2] Restartable Sequences selftests fixes

2018-06-16 Thread Mathieu Desnoyers
Those are trivial restartable sequences selftest fixes for 4.18. The executable flag of run_param_test.sh got lost in the merge of the rseq patchset. On ARM, align the struct rseq_cs definition in the inline asm to match the alignment of that structure in the uapi headers. Thanks, Mathieu

  1   2   3   >