Re: [PATCH v2] usb: dwc2: Enable RPi in ACPI mode

2021-04-09 Thread Greg KH
On Fri, Apr 09, 2021 at 03:38:09PM -0500, Jeremy Linton wrote: > The dwc2 driver has everything we need to run > in ACPI mode except for the ACPI module device table > boilerplate. With that added and identified as "BCM2848", > an id in use by other OSs for this device, the dw2 > controller on the

Re: [PATCH] um: add 2 missing libs to fix various build errors

2021-04-09 Thread Anton Ivanov
On 10/04/2021 05:13, Randy Dunlap wrote: On 4/4/21 11:20 AM, Randy Dunlap wrote: Fix many build errors (at least 18 build error reports) for uml on i386 by adding 2 more library object files. All missing symbols are either cmpxchg8b_emu or atomic*386. Here are a few examples of the build

[PATCH v13 3/4] staging: mt7621-dts: use valid vendor 'mediatek' instead of invalid 'mtk'

2021-04-09 Thread Sergio Paracuellos
Vendor listed for mediatek in kernel vendor file 'vendor-prefixes.yaml' contains 'mediatek' as a valid vendor string. Some nodes in the device tree are using an invalid vendor string vfor 'mtk' instead. Fix all of them in dts file. Update also ralink mt7621 related code to properly match new

[PATCH v13 4/4] MAINTAINERS: add MT7621 CLOCK maintainer

2021-04-09 Thread Sergio Paracuellos
Adding myself as maintainer for mt7621 clock driver. Signed-off-by: Sergio Paracuellos --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 4d68184d3f76..02986055fdbc 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -11484,6 +11484,12 @@ L:

[PATCH v13 1/4] clk: ralink: add clock driver for mt7621 SoC

2021-04-09 Thread Sergio Paracuellos
The documentation for this SOC only talks about two registers regarding to the clocks: * SYSC_REG_CPLL_CLKCFG0 - provides some information about boostrapped refclock. PLL and dividers used for CPU and some sort of BUS. * SYSC_REG_CPLL_CLKCFG1 - a banch of gates to enable/disable clocks for all or

[PATCH v13 2/4] staging: mt7621-dts: make use of new 'mt7621-clk'

2021-04-09 Thread Sergio Paracuellos
Clocks for SoC mt7621 have been properly integrated so there is no need to declare fixed clocks at all in the device tree. Remove all of them, add new device tree nodes for mt7621-clk and update the rest of the nodes to use them. Acked-by: Greg Kroah-Hartman Signed-off-by: Sergio Paracuellos

[PATCH v13 0/4] MIPS: ralink: add CPU clock detection and clock driver for MT7621

2021-04-09 Thread Sergio Paracuellos
of a clock plan for the platform that time. It seems that now he has a better idea of how the clocks are dispossed for this SoC so he share code[1] where some frequencies and clock parents for the gates are coded from a real mediatek private clock plan.

Re: [PATCH v2] kconfig: nconf: stop endless search-up loops

2021-04-09 Thread Masahiro Yamada
On Sun, Mar 28, 2021 at 6:52 PM Mihai Moldovan wrote: > > If the user selects the very first entry in a page and performs a > search-up operation (e.g., via [/][a][Up Arrow]), nconf will never > terminate searching the page. > > The reason is that in this case, the starting point will be set to

Re: [PATCH] iommu/mediatek: always enable the clk on resume

2021-04-09 Thread Yong Wu
On Thu, 2021-04-08 at 14:28 +0200, Dafna Hirschfeld wrote: > In mtk_iommu_runtime_resume always enable the clk, even > if m4u_dom is null. Otherwise the 'suspend' cb might > disable the clk which is already disabled causing the warning: Hi Dafna, Thanks very much for testing and report. I have

Re: [PATCH v2] arm64: dts: qcom: Update iommu property for simultaneous playback

2021-04-09 Thread Srinivasa Rao Mandadapu
Hi Stephen. Thanks for your time!!! On 4/9/2021 10:31 PM, Stephen Boyd wrote: Quoting Srinivasa Rao Mandadapu (2021-04-06 09:33:30) From: V Sujith Kumar Reddy Update iommu property in lpass cpu node for supporting simultaneous playback on headset and speaker. Signed-off-by: V Sujith Kumar

[PATCH v2 2/5] dt-bindings: usb: mtk-xhci: add wakeup interrupt

2021-04-09 Thread Chunfeng Yun
Add an interrupt which is EINT usually to support runtime PM, meanwhile add "interrupt-names" property, for backward compatibility, it's optional and used when wakeup interrupt exists Reviewed-by: Rob Herring Signed-off-by: Chunfeng Yun --- v2: add Reviewed-by Rob ---

[PATCH v2 3/5] usb: xhci-mtk: add support runtime PM

2021-04-09 Thread Chunfeng Yun
A dedicated wakeup irq will be used to handle runtime suspend/resume, we use dev_pm_set_dedicated_wake_irq API to take care of requesting and attaching wakeup irq, then the suspend/resume framework will help to enable/disable wakeup irq. The runtime PM is default off since some platforms may not

[PATCH v2 4/5] usb: xhci-mtk: use clock bulk to get clocks

2021-04-09 Thread Chunfeng Yun
Use clock bulk helpers to get/enable/disable clocks, meanwhile make sys_ck optional, then will be easier to handle clocks. Signed-off-by: Chunfeng Yun --- v2: no changes --- drivers/usb/host/xhci-mtk.c | 109 +++- drivers/usb/host/xhci-mtk.h | 10 ++-- 2 files

[PATCH v2 1/5] usb: xhci-mtk: check return value in suspend/resume hooks

2021-04-09 Thread Chunfeng Yun
Return error number if encounter errors during suspend and resume. Signed-off-by: Chunfeng Yun --- v2: no changes --- drivers/usb/host/xhci-mtk.c | 37 +++-- 1 file changed, 27 insertions(+), 10 deletions(-) diff --git a/drivers/usb/host/xhci-mtk.c

[PATCH v2 5/5] usb: xhci-mtk: remove unused members

2021-04-09 Thread Chunfeng Yun
Now some members about phys and wakeup are not used anymore, remove them. Signed-off-by: Chunfeng Yun --- v2: no changes --- drivers/usb/host/xhci-mtk.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/usb/host/xhci-mtk.h b/drivers/usb/host/xhci-mtk.h index

[PATCH v3 6/6] perf arm-spe: Don't wait for PERF_RECORD_EXIT event

2021-04-09 Thread Leo Yan
When decode Arm SPE trace, it waits for PERF_RECORD_EXIT event (the last perf event) for processing trace data, which is needless and even might cause logic error, e.g. it might fail to correlate perf events with Arm SPE events correctly. So this patch removes the condition checking for

[PATCH v3 5/6] perf arm-spe: Bail out if the trace is later than perf event

2021-04-09 Thread Leo Yan
It's possible that record in Arm SPE trace is later than perf event and vice versa. This asks to correlate the perf events and Arm SPE synthesized events to be processed in the manner of correct timing. To achieve the time ordering, this patch reverses the flow, it firstly calls arm_spe_sample()

[PATCH v3 4/6] perf arm-spe: Assign kernel time to synthesized event

2021-04-09 Thread Leo Yan
In current code, it assigns the arch timer counter to the synthesized samples Arm SPE trace, thus the samples don't contain the kernel time but only contain the raw counter value. To fix the issue, this patch converts the timer counter to kernel time and assigns it to sample timestamp.

[PATCH v3 3/6] perf arm-spe: Convert event kernel time to counter value

2021-04-09 Thread Leo Yan
When handle a perf event, Arm SPE decoder needs to decide if this perf event is earlier or later than the samples from Arm SPE trace data; to do comparision, it needs to use the same unit for the time. This patch converts the event kernel time to arch timer's counter value, thus it can be used to

[PATCH v3 2/6] perf arm-spe: Save clock parameters from TIME_CONV event

2021-04-09 Thread Leo Yan
During the recording phase, "perf record" tool synthesizes event PERF_RECORD_TIME_CONV for the hardware clock parameters and saves the event into the data file. Afterwards, when processing the data file, the event TIME_CONV will be processed at the very early time and is stored into session

[PATCH v3 1/6] perf arm-spe: Remove unused enum value ARM_SPE_PER_CPU_MMAPS

2021-04-09 Thread Leo Yan
The enum value 'ARM_SPE_PER_CPU_MMAPS' is never used so remove it. Signed-off-by: Leo Yan --- tools/perf/util/arm-spe.h | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/perf/util/arm-spe.h b/tools/perf/util/arm-spe.h index 98d3235781c3..105ce0ea0a01 100644 ---

[PATCH v3 0/6] perf arm-spe: Enable timestamp

2021-04-09 Thread Leo Yan
This patch set is to enable timestamp for Arm SPE trace. It reads out TSC parameters from the TIME_CONV event, the parameters are used for conversion between timer counter and kernel time and which is applied for Arm SPE samples. This version dropped the change for adding hardware clock

Re: [PATCH v1] libnvdimm, dax: Fix a missing check in nd_dax_probe()

2021-04-09 Thread Dan Williams
On Fri, Apr 9, 2021 at 5:33 PM wrote: > > From: Yingjie Wang > > In nd_dax_probe(), nd_dax_alloc() may fail and return NULL. > Check for NULL before attempting to > use nd_dax to avoid a NULL pointer dereference. > > Fixes: c5ed9268643c ("libnvdimm, dax: autodetect support") > Signed-off-by:

Re: [PATCH 4.14 00/14] 4.14.230-rc1 review

2021-04-09 Thread Guenter Roeck
On Fri, Apr 09, 2021 at 01:13:06PM -0700, Guenter Roeck wrote: > On Fri, Apr 09, 2021 at 11:53:25AM +0200, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.14.230 release. > > There are 14 patches in this series, all will be posted as a response > > to this one.

[tip:sched/core] BUILD SUCCESS 4aed8aa41524a1fc6439171881c2bb7ace197528

2021-04-09 Thread kernel test robot
allyesconfig mips allmodconfig powerpc allyesconfig powerpc allmodconfig powerpc allnoconfig i386 randconfig-a006-20210409 i386 randconfig

Re: [PATCH] watchdog: mtk: support pre-timeout when the bark irq is available

2021-04-09 Thread Guenter Roeck
On 4/9/21 8:11 PM, 王擎 wrote: > >> On 4/9/21 7:42 PM, 王擎 wrote: >>> On 4/9/21 2:55 AM, Wang Qing wrote: > Use the bark interrupt as the pretimeout notifier if available. > > By default, the pretimeout notification shall occur one second earlier > than the timeout. > >

Re: [External] Re: [RFC PATCH v2 09/18] mm: vmscan: remove noinline_for_stack

2021-04-09 Thread Muchun Song
On Sat, Apr 10, 2021 at 2:31 AM Johannes Weiner wrote: > > On Fri, Apr 09, 2021 at 08:29:50PM +0800, Muchun Song wrote: > > The noinline_for_stack is introduced by commit 666356297ec4 ("vmscan: > > set up pagevec as late as possible in shrink_inactive_list()"), its > > purpose is to delay the

Re: [PATCH] um: add 2 missing libs to fix various build errors

2021-04-09 Thread Randy Dunlap
On 4/4/21 11:20 AM, Randy Dunlap wrote: > Fix many build errors (at least 18 build error reports) for uml on i386 > by adding 2 more library object files. All missing symbols are > either cmpxchg8b_emu or atomic*386. > > Here are a few examples of the build errors that are eliminated: > >

Re: [PATCH net-next 0/7] net: ipa: a few small fixes

2021-04-09 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Fri, 9 Apr 2021 13:07:15 -0500 you wrote: > This series implements some minor bug fixes or improvements. > > The first patch removes an apparently unnecessary restriction, which > results in an error on a 32-bit ARM

Re: [PATCH 10/10] mm/migrate: new zone_reclaim_mode to enable reclaim migration

2021-04-09 Thread Wei Xu
On Thu, Apr 1, 2021 at 11:35 AM Dave Hansen wrote: > This proposes extending the existing "zone_reclaim_mode" (now > now really node_reclaim_mode) as a method to enable it. Nit: now now -> now > We are open to any alternative that allows end users to enable > this mechanism or disable it it

Re: [PATCH] Documentation: kunit: add tips for running KUnit

2021-04-09 Thread David Gow
Thanks for writing this: it's good to have these things documented at last! There are definitely a few things this document points out which still need deciding, which does make this document lean a bit into "design discussion" territory in a few of the notes. This doesn't bother me -- it's an

Re: [PATCH 1/2] linux/kconfig.h: replace IF_ENABLED() with PTR_IF() in

2021-04-09 Thread Masahiro Yamada
On Fri, Apr 9, 2021 at 6:24 PM Andy Shevchenko wrote: > > On Fri, Apr 9, 2021 at 12:00 AM Masahiro Yamada wrote: > > > > is included from all the kernel-space source files, > > including C, assembly, linker scripts. It is intended to contain minimal > > a minimal > > > set of macros to evaluate

[PATCH -next] nvmem: sprd: Add missing MODULE_DEVICE_TABLE

2021-04-09 Thread Bixuan Cui
This patch adds missing MODULE_DEVICE_TABLE definition which generates correct modalias for automatic loading of this driver when it is built as an external module. Reported-by: Hulk Robot Signed-off-by: Bixuan Cui --- drivers/nvmem/sprd-efuse.c | 1 + 1 file changed, 1 insertion(+) diff

[PATCH -next] staging: ralink-gdma: Add missing MODULE_DEVICE_TABLE

2021-04-09 Thread Bixuan Cui
This patch adds missing MODULE_DEVICE_TABLE definition which generates correct modalias for automatic loading of this driver when it is built as an external module. Reported-by: Hulk Robot Signed-off-by: Bixuan Cui --- drivers/staging/ralink-gdma/ralink-gdma.c | 1 + 1 file changed, 1

[PATCH -next] usb: dwc3: qcom: Remove redundant dev_err call in dwc3_qcom_probe()

2021-04-09 Thread Bixuan Cui
There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Reported-by: Hulk Robot Signed-off-by: Bixuan Cui --- drivers/usb/dwc3/dwc3-qcom.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/dwc3/dwc3-qcom.c

Re: [PATCH 06/10] mm/vmscan: add page demotion counter

2021-04-09 Thread Wei Xu
On Thu, Apr 1, 2021 at 11:35 AM Dave Hansen wrote: > > > From: Yang Shi > > Account the number of demoted pages into reclaim_state->nr_demoted. > > Add pgdemote_kswapd and pgdemote_direct VM counters showed in > /proc/vmstat. > > [ daveh: >- __count_vm_events() a bit, and made them look at

Re: [PATCH 05/10] mm/migrate: demote pages during reclaim

2021-04-09 Thread Wei Xu
> +static unsigned int demote_page_list(struct list_head *demote_pages, > +struct pglist_data *pgdat, > +struct scan_control *sc) sc is not needed and can be removed from demote_page_list(). Reviewed-by: Wei Xu

[PATCH -next] drm/mediatek: Fix PM reference leak in mtk_crtc_ddp_hw_init()

2021-04-09 Thread Wang Li
pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to putting operation will result in reference leak here. Fix it by replacing it with pm_runtime_resume_and_get to keep usage counter balanced. Reported-by: Hulk Robot Signed-off-by: Wang Li ---

Re: [PATCH] ext4: fix debug format string warning

2021-04-09 Thread tytso
On Fri, Apr 09, 2021 at 10:12:05PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > Using no_printk() for jbd_debug() revealed two warnings: > > fs/jbd2/recovery.c: In function 'fc_do_one_pass': > fs/jbd2/recovery.c:256:30: error: format '%d' expects a matching 'int' > argument

Re: [PATCH 0/8] EXT4: Trivial typo fixes

2021-04-09 Thread Theodore Ts'o
On Sat, Mar 27, 2021 at 04:00:04PM +0530, Bhaskar Chowdhury wrote: > This patch series fixed few mundane typos in the below specific files. > > Bhaskar Chowdhury (8): > EXT4: migrate.c: Fixed few typos > EXT4: namei.c: Fixed a typo > EXT4: inline.c: A typo fixed > Fix a typo > EXT4:

[PATCH] perf session: Dump PERF_RECORD_TIME_CONV event

2021-04-09 Thread Leo Yan
Now perf tool uses the common stub function process_event_op2_stub() for dumping TIME_CONV event, thus it doesn't output the clock parameters contained in the event. This patch adds the callback function for dumping the hardware clock parameters in TIME_CONV event. Before: # perf report -D

Re: [PATCH v2] integrity: Add declarations to init_once void arguments.

2021-04-09 Thread Jiele Zhao
Okay, thank you. I'll keep an eye on that ! On 2021/4/10 2:55, Mimi Zohar wrote: Hi Jiele, On Wed, 2021-04-07 at 01:44 +, Jiele Zhao wrote: init_once is a callback to kmem_cache_create. The parameter type of this function is void *, so it's better to give a explicit cast here.

Re: [PATCH 2/5] swap: fix do_swap_page() race with swapoff

2021-04-09 Thread Miaohe Lin
On 2021/4/10 1:17, Tim Chen wrote: > > > On 4/9/21 1:42 AM, Miaohe Lin wrote: >> On 2021/4/9 5:34, Tim Chen wrote: >>> >>> >>> On 4/8/21 6:08 AM, Miaohe Lin wrote: When I was investigating the swap code, I found the below possible race window: CPU 1

Re:Re: [PATCH] watchdog: mtk: support pre-timeout when the bark irq is available

2021-04-09 Thread 王擎
>On 4/9/21 7:42 PM, 王擎 wrote: >> >>> On 4/9/21 2:55 AM, Wang Qing wrote: Use the bark interrupt as the pretimeout notifier if available. By default, the pretimeout notification shall occur one second earlier than the timeout. Signed-off-by: Wang Qing ---

Re: [PATCH 02/10] mm/numa: automatically generate node migration order

2021-04-09 Thread Wei Xu
On Thu, Apr 1, 2021 at 11:35 AM Dave Hansen wrote: > +/* > + * node_demotion[] example: > + * > + * Consider a system with two sockets. Each socket has > + * three classes of memory attached: fast, medium and slow. > + * Each memory class is placed in its own NUMA node. The > + * CPUs are

Re: [GIT PULL] clk fixes for v5.12-rc6

2021-04-09 Thread pr-tracker-bot
The pull request you sent on Fri, 9 Apr 2021 18:46:03 -0700: > https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git > tags/clk-fixes-for-linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/d4961772226de3b48a395a26c076d450d7044c76 Thank you! --

Re: [PATCH] fs: cifs: Fix spelling of 'security'

2021-04-09 Thread Steve French
Merged into cifs-2.6.git for-next (strangely ... this patch was sent to my spam folder in gmail so didn't notice it until today, and by accident). On Wed, Apr 7, 2021 at 9:03 AM wrote: > > From: "jack1.li_cp" > > secuirty -> security > > Signed-off-by: jack1.li_cp > --- > fs/cifs/cifsacl.c |

Re: [PATCH] watchdog: mtk: support pre-timeout when the bark irq is available

2021-04-09 Thread Guenter Roeck
On 4/9/21 7:42 PM, 王擎 wrote: > >> On 4/9/21 2:55 AM, Wang Qing wrote: >>> Use the bark interrupt as the pretimeout notifier if available. >>> >>> By default, the pretimeout notification shall occur one second earlier >>> than the timeout. >>> >>> Signed-off-by: Wang Qing >>> --- >>>

Re: [PATCH] x86/efi: Do not release sub-1MB memory regions when the crashkernel option is specified

2021-04-09 Thread lijiang
Hi, Baoquan Thank you for the comment. 在 2021年04月09日 20:44, Baoquan He 写道: > On 04/07/21 at 10:03pm, Lianbo Jiang wrote: >> Some sub-1MB memory regions may be reserved by EFI boot services, and the >> memory regions will be released later in the efi_free_boot_services(). >> >> Currently, always

Re:Re: [PATCH] softdog: make pretimeout available when SOFT_WATCHDOG_PRETIMEOUT enabled

2021-04-09 Thread 王擎
>On 4/6/21 2:44 AM, Wang Qing wrote: >> Although softdog supports pretimeout, there is no way to set pretimeout, >> so pretimeout will never be processed in softdog_ping(). >> >This is wrong. The pretimeout can be set using WDIOC_SETPRETIMEOUT, as with >every other driver supporting it. There

Re: [PATCH v7 02/28] mm: Introduce struct folio

2021-04-09 Thread kernel test robot
Hi "Matthew, Thank you for the patch! Yet something to improve: [auto build test ERROR on next-20210409] [also build test ERROR on v5.12-rc6] [cannot apply to linux/master linus/master hnaz-linux-mm/master v5.12-rc6 v5.12-rc5 v5.12-rc4] [If your patch is applied to the wrong git tree, k

Bogus struct page layout on 32-bit

2021-04-09 Thread Matthew Wilcox
On Sat, Apr 10, 2021 at 06:45:35AM +0800, kernel test robot wrote: > >> include/linux/mm_types.h:274:1: error: static_assert failed due to > >> requirement '__builtin_offsetof(struct page, lru) == > >> __builtin_offsetof(struct folio, lru)' "offsetof(struct page, lru) == > >> offsetof(struct

Re:Re: [PATCH] watchdog: mtk: support pre-timeout when the bark irq is available

2021-04-09 Thread 王擎
>On 4/9/21 2:55 AM, Wang Qing wrote: >> Use the bark interrupt as the pretimeout notifier if available. >> >> By default, the pretimeout notification shall occur one second earlier >> than the timeout. >> >> Signed-off-by: Wang Qing >> --- >> drivers/watchdog/mtk_wdt.c | 47 >>

Re: [PATCH 4/6] staging: rtl8192e: matched alignment with open parenthesis

2021-04-09 Thread Joe Perches
On Sat, 2021-04-10 at 07:55 +0530, Mitali Borkar wrote: > On Fri, Apr 09, 2021 at 07:07:09PM -0700, Joe Perches wrote: > > On Sat, 2021-04-10 at 07:05 +0530, Mitali Borkar wrote: > > > Matched the alignment with open parenthesis to meet linux kernel coding > > > style. > > > Reported by

Re: [PATCH 4/6] staging: rtl8192e: matched alignment with open parenthesis

2021-04-09 Thread Mitali Borkar
On Fri, Apr 09, 2021 at 07:07:09PM -0700, Joe Perches wrote: > On Sat, 2021-04-10 at 07:05 +0530, Mitali Borkar wrote: > > Matched the alignment with open parenthesis to meet linux kernel coding > > style. > > Reported by checkpatch. > [] > > diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c

[PATCH -next] Bluetooth: use flexible-array member instead of zero-length array

2021-04-09 Thread Qiheng Lin
Fix the following coccicheck warning: net/bluetooth/msft.c:37:6-13: WARNING use flexible-array member instead net/bluetooth/msft.c:42:6-10: WARNING use flexible-array member instead net/bluetooth/msft.c:52:6-10: WARNING use flexible-array member instead Signed-off-by: Qiheng Lin ---

Re: [PATCH v1 1/2] arm64: dts: qcom: sc7280: Add cpufreq hw node

2021-04-09 Thread Stephen Boyd
Quoting Taniya Das (2021-04-09 19:04:39) > @@ -1116,6 +1124,17 @@ > #clock-cells = <1>; > }; > }; > + > + cpufreq_hw: cpufreq@18591000 { > + compatible = "qcom,cpufreq-epss"; > +

[PATCH 3/3] staging: rtl8192e: remove unncessary parentheses

2021-04-09 Thread Mitali Borkar
Removed unnecessary parentheses because they must be used only when it is necessary or they improve readability. Reported by checkpatch. Signed-off-by: Mitali Borkar --- drivers/staging/rtl8192e/rtl819x_HTProc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[PATCH 0/3] staging: rtl8192e: cleanup patchset for style issues

2021-04-09 Thread Mitali Borkar
These patches fix the cleanup style issues identified by checkpatch Mitali Borkar (3): staging: rtl8192e: replace comparison to NULL by boolean expression staging: rtl8192e: remove unnecessary ftrace-like logging staging: rtl8192e: remove unncessary parentheses

[PATCH 2/3] staging: rtl8192e: remove unnecessary ftrace-like logging

2021-04-09 Thread Mitali Borkar
Removed unncessary ftrace-like logging by simply deleting that statement as we have other modes of logging like ftrace. Reported by checkpatch. Signed-off-by: Mitali Borkar --- drivers/staging/rtl8192e/rtl819x_HTProc.c | 4 1 file changed, 4 deletions(-) diff --git

[PATCH 1/3] staging: rtl8192e: replace comparison to NULL by boolean

2021-04-09 Thread Mitali Borkar
Replaced comparison to NULL by boolean expressions (here used boolean negations). This improves readability of code. Reported by checkpatch. Signed-off-by: Mitali Borkar --- drivers/staging/rtl8192e/rtl819x_HTProc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

Re: [PATCH v2 4/6] usb: typec: tcpm: Honour pSnkStdby requirement during negotiation

2021-04-09 Thread Guenter Roeck
On 4/7/21 1:07 PM, Badhri Jagan Sridharan wrote: >>From PD Spec: > The Sink Shall transition to Sink Standby before a positive or > negative voltage transition of VBUS. During Sink Standby > the Sink Shall reduce its power draw to pSnkStdby. This allows > the Source to manage the voltage

Re: [PATCH v2 3/6] usb: typec: tcpm: update power supply once partner accepts

2021-04-09 Thread Guenter Roeck
On 4/7/21 1:07 PM, Badhri Jagan Sridharan wrote: > power_supply_changed needs to be called to notify clients > after the partner accepts the requested values for the pps > case. > > Also, remove the redundant power_supply_changed at the end > of the tcpm_reset_port as power_supply_changed is

Re: [PATCH v2 2/6] usb: typec: tcpm: Address incorrect values of tcpm psy for pps supply

2021-04-09 Thread Guenter Roeck
On 4/7/21 1:07 PM, Badhri Jagan Sridharan wrote: > tcpm_pd_select_pps_apdo overwrites port->pps_data.min_volt, > port->pps_data.max_volt, port->pps_data.max_curr even before > port partner accepts the requests. This leaves incorrect values > in current_limit and supply_voltage that get exported by

Re: [PATCH 4/6] staging: rtl8192e: matched alignment with open parenthesis

2021-04-09 Thread Joe Perches
On Sat, 2021-04-10 at 07:05 +0530, Mitali Borkar wrote: > Matched the alignment with open parenthesis to meet linux kernel coding > style. > Reported by checkpatch. [] > diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c > b/drivers/staging/rtl8192e/rtl819x_HTProc.c [] > @@ -154,7 +154,7 @@

[PATCH v1 2/2] arm64: dts: qcom: sc7280: Add clock controller nodes

2021-04-09 Thread Taniya Das
Add support for the video, gpu, display, lpass clock controller device nodes for SC7280 SoC. Signed-off-by: Taniya Das --- arch/arm64/boot/dts/qcom/sc7280.dtsi | 58 1 file changed, 58 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi

[PATCH v1 0/2] Add device nodes for SC7280 SoCs

2021-04-09 Thread Taniya Das
Add device node for cpufreq HW and clock controllers of GPU, DISP, VIDEO, LPASS. The clock controller nodes are dependent on the following VIDEO/DISP/GPU: https://lkml.org/lkml/2021/3/16/1624 LPASS: https://lkml.org/lkml/2021/4/9/812 Taniya Das (2): arm64: dts: qcom: sc7280: Add cpufreq hw

[PATCH v1 1/2] arm64: dts: qcom: sc7280: Add cpufreq hw node

2021-04-09 Thread Taniya Das
Add cpufreq HW device node to scale 4-Silver/3-Gold/1-Gold+ cores on SC7280 SoCs. Signed-off-by: Taniya Das --- arch/arm64/boot/dts/qcom/sc7280.dtsi | 19 +++ 1 file changed, 19 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi

Re: [PATCH v2] platform/chrome: Don't populate lightbar device if it isn't there

2021-04-09 Thread Stephen Boyd
Quoting Stephen Boyd (2020-09-10 17:53:07) > Quoting Enric Balletbo i Serra (2020-09-10 08:49:42) > > On 10/9/20 16:52, Guenter Roeck wrote: > > > On Thu, Sep 10, 2020 at 7:32 AM Enric Balletbo i Serra > > > wrote: > > >> On 10/9/20 16:18, Guenter Roeck wrote: > > >>> On Wed, Sep 9, 2020 at 3:42

Re: [PATCH] usb: dwc3: qcom: Fixed an issue that the ret value is incorrect in dwc3_qcom_probe()

2021-04-09 Thread Bixuan Cui
On 2021/4/9 18:00, Manivannan Sadhasivam wrote: > But this error message can be removed altogether as devm_ioremap_resource() > reports it already. Thank you for your reply. I'll revise it. Thanks, Bixuan Cui

[PATCH v4 13/13] kdump: Use vmlinux_build_id to simplify

2021-04-09 Thread Stephen Boyd
We can use the vmlinux_build_id array here now instead of open coding it. This mostly consolidates code. Cc: Jiri Olsa Cc: Alexei Starovoitov Cc: Jessica Yu Cc: Evan Green Cc: Hsin-Yi Wang Cc: Dave Young Cc: Baoquan He Cc: Vivek Goyal Cc: Signed-off-by: Stephen Boyd ---

[PATCH v4 09/13] scripts/decode_stacktrace.sh: Silence stderr messages from addr2line/nm

2021-04-09 Thread Stephen Boyd
Sometimes if you're using tools that have linked things improperly or have new features/sections that older tools don't expect you'll see warnings printed to stderr. We don't really care about these warnings, so let's just silence these messages to cleanup output of this script. Cc: Jiri Olsa

[PATCH v4 12/13] buildid: Fix kernel-doc notation

2021-04-09 Thread Stephen Boyd
Kernel doc should use "Return:" instead of "Returns" to properly reflect the return values. Cc: Jiri Olsa Cc: Alexei Starovoitov Cc: Jessica Yu Cc: Evan Green Cc: Hsin-Yi Wang Signed-off-by: Stephen Boyd --- lib/buildid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v4 11/13] buildid: Mark some arguments const

2021-04-09 Thread Stephen Boyd
These arguments are never modified so they can be marked const to indicate as such. Cc: Jiri Olsa Cc: Alexei Starovoitov Cc: Jessica Yu Cc: Evan Green Cc: Hsin-Yi Wang Signed-off-by: Stephen Boyd --- lib/buildid.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH v4 10/13] scripts/decode_stacktrace.sh: Indicate 'auto' can be used for base path

2021-04-09 Thread Stephen Boyd
Add "auto" to the usage message so that it's a little clearer that you can pass "auto" as the second argument. When passing "auto" the script tries to find the base path automatically instead of requiring it be passed on the commandline. Also use [] to indicate the variable argument and that it is

[PATCH v4 08/13] scripts/decode_stacktrace.sh: Support debuginfod

2021-04-09 Thread Stephen Boyd
Now that stacktraces contain the build ID information we can update this script to use debuginfod-find to locate the debuginfo for the vmlinux and modules automatically. This can replace the existing code that requires specifying a path to vmlinux or tries to find the vmlinux and modules

[PATCH v4 07/13] x86/dumpstack: Use %pSb/%pBb for backtrace printing

2021-04-09 Thread Stephen Boyd
Let's use the new printk formats to print the stacktrace entries when printing a backtrace to the kernel logs. This will include any module's build ID[1] in it so that offline/crash debugging can easily locate the debuginfo for a module via something like debuginfod[2]. Cc: Thomas Gleixner Cc:

[PATCH v4 05/13] module: Add printk formats to add module build ID to stacktraces

2021-04-09 Thread Stephen Boyd
Let's make kernel stacktraces easier to identify by including the build ID[1] of a module if the stacktrace is printing a symbol from a module. This makes it simpler for developers to locate a kernel module's full debuginfo for a particular stacktrace. Combined with scripts/decode_stracktrace.sh,

[PATCH v4 06/13] arm64: stacktrace: Use %pSb for backtrace printing

2021-04-09 Thread Stephen Boyd
Let's use the new printk format to print the stacktrace entry when printing a backtrace to the kernel logs. This will include any module's build ID[1] in it so that offline/crash debugging can easily locate the debuginfo for a module via something like debuginfod[2]. Cc: Catalin Marinas Cc: Will

[PATCH v4 03/13] buildid: Stash away kernels build ID on init

2021-04-09 Thread Stephen Boyd
Parse the kernel's build ID at initialization so that other code can print a hex format string representation of the running kernel's build ID. This will be used in the kdump and dump_stack code so that developers can easily locate the vmlinux debug symbols for a crash/stacktrace. Cc: Jiri Olsa

[PATCH v4 04/13] dump_stack: Add vmlinux build ID to stack traces

2021-04-09 Thread Stephen Boyd
Add the running kernel's build ID[1] to the stacktrace information header. This makes it simpler for developers to locate the vmlinux with full debuginfo for a particular kernel stacktrace. Combined with scripts/decode_stracktrace.sh, a developer can download the correct vmlinux from a

[PATCH v4 02/13] buildid: Add API to parse build ID out of buffer

2021-04-09 Thread Stephen Boyd
Add an API that can parse the build ID out of a buffer, instead of a vma, to support printing a kernel module's build ID for stack traces. Cc: Jiri Olsa Cc: Alexei Starovoitov Cc: Jessica Yu Cc: Evan Green Cc: Hsin-Yi Wang Signed-off-by: Stephen Boyd --- include/linux/buildid.h | 1 +

[PATCH v4 01/13] buildid: Only consider GNU notes for build ID parsing

2021-04-09 Thread Stephen Boyd
Some kernel elf files have various notes that also happen to have an elf note type of '3', which matches NT_GNU_BUILD_ID but the note name isn't "GNU". For example, this note trips up the existing logic: Owner Data size Description Xen0x0008 Unknown note type: (0x0003)

[PATCH v4 00/13] Add build ID to stacktraces

2021-04-09 Thread Stephen Boyd
This series adds the kernel's build ID[1] to the stacktrace header printed in oops messages, warnings, etc. and the build ID for any module that appears in the stacktrace after the module name. The goal is to make the stacktrace more self-contained and descriptive by including the relevant build

Re: [PATCH 0/5] mm/memcg: Reduce kmemcache memory accounting overhead

2021-04-09 Thread Roman Gushchin
On Fri, Apr 09, 2021 at 07:18:37PM -0400, Waiman Long wrote: > With the recent introduction of the new slab memory controller, we > eliminate the need for having separate kmemcaches for each memory > cgroup and reduce overall kernel memory usage. However, we also add > additional memory accounting

[GIT PULL] clk fixes for v5.12-rc6

2021-04-09 Thread Stephen Boyd
The following changes since commit 148ddaa89d4a0a927c4353398096cc33687755c1: clk: qcom: gcc-sc7180: Use floor ops for the correct sdcc1 clk (2021-03-13 13:00:05 -0800) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git

Re: [PATCH 1/6] PM: runtime: enable wake irq after runtime_suspend hook called

2021-04-09 Thread Chunfeng Yun
On Fri, 2021-04-09 at 13:14 +0200, Rafael J. Wysocki wrote: > On Fri, Apr 9, 2021 at 10:36 AM Chunfeng Yun > wrote: > > > > On Fri, 2021-04-09 at 08:39 +0300, Tony Lindgren wrote: > > > * Chunfeng Yun [210409 01:54]: > > > > On Thu, 2021-04-08 at 19:41 +0200, Rafael J. Wysocki wrote: > > > > >

[PATCH 6/6] staging: rtl8192e: align statements properly

2021-04-09 Thread Mitali Borkar
Aligned the statements properly in one line to make code neater and to improve readability. Signed-off-by: Mitali Borkar --- drivers/staging/rtl8192e/rtl819x_HTProc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c

[PATCH 5/6] staging: rtl8192e: removed multiple blank lines

2021-04-09 Thread Mitali Borkar
Removed multiple blank lines to make code better and neater. Reported by checkpatch. Signed-off-by: Mitali Borkar --- drivers/staging/rtl8192e/rtl819x_HTProc.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c

[PATCH 4/6] staging: rtl8192e: matched alignment with open parenthesis

2021-04-09 Thread Mitali Borkar
Matched the alignment with open parenthesis to meet linux kernel coding style. Reported by checkpatch. Signed-off-by: Mitali Borkar --- drivers/staging/rtl8192e/rtl819x_HTProc.c | 20 ++-- drivers/staging/rtl8192e/rtl819x_TSProc.c | 18 +- 2 files changed, 19

[PATCH 3/6] staging: rtl8192e: remove unncessary blank line after brace

2021-04-09 Thread Mitali Borkar
Removed an exra blank line after close brace '{' as it was not necessary. Reported by checkpatch Signed-off-by: Mitali Borkar --- drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c

[PATCH 2/6] staging: rtl8192e: remove unnecessary blank line before brace

2021-04-09 Thread Mitali Borkar
Removed an extra blank line before close brace as it was not necessary. Reported by checkpatch. Signed-off-by: Mitali Borkar --- drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 -- drivers/staging/rtl8192e/rtl819x_TSProc.c | 2 -- 2 files changed, 4 deletions(-) diff --git

[PATCH 1/6] staging: rtl8192e: add spaces around binary operators

2021-04-09 Thread Mitali Borkar
Added spaces around binary operators like '+', '*', '|', '-', '&', to improve readability and to meet linux kernel coding style. Signed-off-by: Mitali Borkar --- drivers/staging/rtl8192e/rtl819x_HTProc.c | 8 drivers/staging/rtl8192e/rtl819x_TSProc.c | 8 2 files changed, 8

[PATCH 0/6] staging: rtl8192e: cleanup patchset for style issues

2021-04-09 Thread Mitali Borkar
This patches fix the cleanup style issues. Mitali Borkar (6): staging: rtl8192e: add spaces around binary operators staging: rtl8192e: remove unnecessary blank line before brace staging: rtl8192e: remove unncessary blank line after brace staging: rtl8192e: matched alignment with open

Re: [RFC PATCH v2 00/18] Use obj_cgroup APIs to charge the LRU pages

2021-04-09 Thread Roman Gushchin
On Fri, Apr 09, 2021 at 08:29:41PM +0800, Muchun Song wrote: > Since the following patchsets applied. All the kernel memory are charged > with the new APIs of obj_cgroup. > > [v17,00/19] The new cgroup slab memory controller > [v5,0/7] Use obj_cgroup APIs to charge kmem pages > > But

Re: [PATCH -next] ext4: fix error return code in ext4_fc_perform_commit()

2021-04-09 Thread Theodore Ts'o
On Thu, Apr 08, 2021 at 03:00:33PM +0800, Xu Yihang wrote: > In case of if not ext4_fc_add_tlv branch, an error return code is missing. > > Fixes: aa75f4d3daae ("ext4: main fast-commit commit path") > Reported-by: Hulk Robot > Signed-off-by: Xu Yihang Thanks, applied.

Re: [PATCH v2] usb: cdnsp: Fixes issue with Configure Endpoint command

2021-04-09 Thread Peter Chen
On 21-04-07 08:36:29, Pawel Laszczak wrote: > From: Pawel Laszczak > > Patch adds flag EP_UNCONFIGURED to detect whether endpoint was > unconfigured. This flag is set in cdnsp_reset_device after Reset Device > command. Among others this command disables all non control endpoints. > Flag is used

[PATCH v2] usb: core: reduce power-on-good delay time of root hub

2021-04-09 Thread Chunfeng Yun
Return the exactly delay time given by root hub descriptor, this helps to reduce resume time etc. Due to the root hub descriptor is usually provided by the host controller driver, if there is compatibility for a root hub, we can fix it easily without affect other root hub Acked-by: Alan Stern

Re:Re: [PATCH v1] drm/radeon: Fix a missing check bug in radeon_dp_mst_detect()

2021-04-09 Thread Yingjie Wang
My pleasure! At 2021-04-09 04:17:36, "Alex Deucher" wrote: >Applied. Thanks! > >Alex > >On Wed, Apr 7, 2021 at 2:23 AM wrote: >> >> From: Yingjie Wang >> >> In radeon_dp_mst_detect(), We should check whether or not @connector >> has been unregistered from userspace. If the connector is

RE: [PATCH v7 06/11] scsi: ufshpb: Region inactivation in host mode

2021-04-09 Thread Avri Altman
> > >> On 2021-04-06 13:20, Avri Altman wrote: > > >> >> > -static void __ufshpb_evict_region(struct ufshpb_lu *hpb, > > >> >> > - struct ufshpb_region *rgn) > > >> >> > +static int __ufshpb_evict_region(struct ufshpb_lu *hpb, > > >> >> > +

  1   2   3   4   5   6   7   8   9   10   >