RE: [PATCH v6 1/9] rpmb: add Replay Protected Memory Block (RPMB) subsystem

> > Signed-off-by: Tomas Winkler <tomas.wink...@intel.com> > Signed-off-by: Alexander Usyskin <alexander.usys...@intel.com> Tested-by: Avri Altman <avri.alt...@sandisk.com> - mmc - full functionality. One issue found that was fixed on V6: patch V6 2/9. - ufs

RE: [PATCH V9 09/15] mmc: core: Add parameter use_blk_mq

> -Original Message- > From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- > ow...@vger.kernel.org] On Behalf Of Linus Walleij > Sent: Wednesday, September 27, 2017 2:42 AM > To: Adrian Hunter > Cc: Ulf Hansson ; linux-mmc

RE: [PATCH 4/4] scsi: ufs: make ufshcd_config_pwr_mode of non-static func

o that other vendors like > exynos can use the same. > > Signed-off-by: Seungwon Jeon <ess...@gmail.com> > Signed-off-by: Alim Akhtar <alim.akh...@samsung.com> Acked-by: Avri Altman <avri.alt...@wdc.com> Might be also useful exporting an API for all uic commands? Thanks, Avri

RE: [PATCH 1/1] scsi: ufs: make sure all interrupts are processed

Hi, Can you elaborate how this can even happen? Isn't the interrupt aggregation capability should attend for those cases? Thanks, Avri > -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Asutosh Das > Sent: Tuesday,

RE: [PATCH 1/1] scsi: ufs: make sure all interrupts are processed

> >>> -Original Message- > >>> From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > >>> ow...@vger.kernel.org] On Behalf Of Asutosh Das > >>> Sent: Tuesday, January 30, 2018 6:54 AM > >>> To: subha...@codeaurora.org; c...@codeaurora.org; > >>> vivek.gau...@codeaurora.org;

RE: [PATCH 1/1] scsi: ufs: Add support for Auto-Hibernate Idle Timer

> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Adrian Hunter > Sent: Friday, February 16, 2018 2:01 PM > To: Vinayak Holikatti ; Martin K. Petersen > ; James E.J.

RE: [PATCH 2/2 v4] scsi: ufs: introduce sysfs entries exposing UFS health info

> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Greg Kroah-Hartman > Sent: Thursday, December 21, 2017 10:00 AM > To: Jaegeuk Kim > Cc: linux-kernel@vger.kernel.org; linux-s...@vger.kernel.org;

RE: [PATCH v6] mmc: Export host capabilities to debugfs.

> -Original Message- > From: Harish Jenny K N [mailto:harish_kand...@mentor.com] > Sent: Wednesday, March 07, 2018 7:38 AM > To: ulf.hans...@linaro.org; linus.wall...@linaro.org; > adrian.hun...@intel.com; shawn@rock-chips.com; Avri Altman > <avri.alt...@wdc

RE: [PATCH v9] mmc: Export host capabilities to debugfs.

lin@rock- > chips.com; Avri Altman <avri.alt...@wdc.com> > Cc: linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; > vladimir_zapols...@mentor.com > Subject: Re: [PATCH v9] mmc: Export host capabilities to debugfs. > > On Mon, 2018-03-12 at 10:01 +0530, Harish Jen

RE: [PATCH v9] mmc: Export host capabilities to debugfs.

> -Original Message- > From: Harish Jenny K N [mailto:harish_kand...@mentor.com] > Sent: Monday, March 12, 2018 1:17 PM > To: Avri Altman <avri.alt...@wdc.com>; Andy Shevchenko > <andriy.shevche...@linux.intel.com>; ulf.hans...@linaro.org; > linus.

RE: [PATCH 2/7] mmc-utils: treat FIRMWARE_VERSION as binary field instead of string

> +++ b/mmc_cmds.c > @@ -1758,8 +1758,15 @@ int do_read_extcsd(int nargs, char **argv) > } > > if (ext_csd_rev >= 7) { > - printf("eMMC Firmware Version: %s\n", > - (char*)_csd[EXT_CSD_FIRMWARE_VERSION]); > + printf("Firmware Version: >

RE: [PATCH 1/7] mmc-utils: interpret OPTIMAL_*_SIZE fields in extcsd

Looks fine. Thanks, Avri > eMMC 5.0 introduced OPTIMAL_READ_SIZE, OPTIMAL_WRITE_SIZE and > OPTIMAL > TRIM_UNIT_SIZE fields in the extcsd > > Interpret these fields when reading out the extcsd with human-readable > results > > Signed-off-by: James Nuss Reviewed-by: Avri Altman

RE: [PATCH 2/7] mmc-utils: treat FIRMWARE_VERSION as binary field instead of string

> > On Wed, Oct 10, 2018 at 4:43 AM Avri Altman wrote: > > > > > > > +++ b/mmc_cmds.c > > > @@ -1758,8 +1758,15 @@ int do_read_extcsd(int nargs, char **argv) > > > } > > > > > > if (ext_csd_rev

RE: [PATCH 5/8] bsg: refactor bsg_ioctl

; > --- > > block/bsg.c | 158 > > 1 file changed, 72 insertions(+), 86 deletions(-) > > > > Looks fine to me. Did ran the same small test-tool I ran against Jens' > patches, nothing broke. > > Reviewed-by: Benjamin Block > Tested-by: Benjamin Block Tested-by

RE: [PATCH 6/8] bsg-lib: handle bidi requests without block layer help

ld, allowing for the eventual > removal of the latter. > > Signed-off-by: Christoph Hellwig Tested-by: Avri Altman Regardless of the ongoing discussion with Benjamin - Tested the scsi pass-through (ufs-bsg) path - nothing is broken.

RE: [PATCH v9] mmc: Export host capabilities to debugfs.

> -Original Message- > From: Andy Shevchenko [mailto:andriy.shevche...@linux.intel.com] > Sent: Monday, March 12, 2018 12:08 PM > To: Harish Jenny K N ; ulf.hans...@linaro.org; > linus.wall...@linaro.org; adrian.hun...@intel.com; shawn.lin@rock- > chips.com; Avri A

RE: [PATCH v9] mmc: Export host capabilities to debugfs.

> -Original Message- > From: Harish Jenny K N [mailto:harish_kand...@mentor.com] > Sent: Monday, March 12, 2018 1:17 PM > To: Avri Altman ; Andy Shevchenko > ; ulf.hans...@linaro.org; > linus.wall...@linaro.org; adrian.hun...@intel.com; shawn@rock-chi

RE: [PATCH 4/4] scsi: ufs: make ufshcd_config_pwr_mode of non-static func

the same. > > Signed-off-by: Seungwon Jeon > Signed-off-by: Alim Akhtar Acked-by: Avri Altman Might be also useful exporting an API for all uic commands? Thanks, Avri

RE: [PATCH 2/2 v4] scsi: ufs: introduce sysfs entries exposing UFS health info

> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Greg Kroah-Hartman > Sent: Thursday, December 21, 2017 10:00 AM > To: Jaegeuk Kim > Cc: linux-kernel@vger.kernel.org; linux-s...@vger.kernel.org; Jaegeuk Kim > >

RE: [PATCH v6] mmc: Export host capabilities to debugfs.

> -Original Message- > From: Harish Jenny K N [mailto:harish_kand...@mentor.com] > Sent: Wednesday, March 07, 2018 7:38 AM > To: ulf.hans...@linaro.org; linus.wall...@linaro.org; > adrian.hun...@intel.com; shawn@rock-chips.com; Avri Altman > ; andriy.shevche...@li

RE: [PATCH 1/1] scsi: ufs: make sure all interrupts are processed

> >>> -Original Message- > >>> From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > >>> ow...@vger.kernel.org] On Behalf Of Asutosh Das > >>> Sent: Tuesday, January 30, 2018 6:54 AM > >>> To: subha...@codeaurora.org; c...@codeaurora.org; > >>> vivek.gau...@codeaurora.org;

RE: [PATCH 1/1] scsi: ufs: Add support for Auto-Hibernate Idle Timer

> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Adrian Hunter > Sent: Friday, February 16, 2018 2:01 PM > To: Vinayak Holikatti ; Martin K. Petersen > ; James E.J. Bottomley > > Cc: Stanislav Nijnikov ; Jaegeuk Kim

RE: [PATCH] scsi: ufs: delete redundant if statement in ufshcd_intr()

> > > From: Bean Huo > > Once going into while-do loop, intr_status is already true, > this if-statement is redundant, remove it. > > Signed-off-by: Bean Huo Reviewed-by: Avri Altman

RE: [PATCH 1/2] scsi: ufs: Add DeepSleep feature

> + /* > +* DeepSleep requires the Immediate flag. DeepSleep state is actually > +* entered when the link state goes to Hibern8. > +*/ > + if (pwr_mode == UFS_DEEPSLEEP_PWR_MODE) > + cmd[1] = 1; Shouldn't it be bit1, i.e. cmd[1] = 2 ? >

RE: [PATCH 1/2] scsi: ufs: Add DeepSleep feature

Please ignore - I was confused with pre-fetch. Sorry, Avri > -Original Message- > From: Avri Altman > Sent: Sunday, October 4, 2020 10:21 AM > To: 'Adrian Hunter' ; Martin K . Petersen > ; James E . J . Bottomley > Cc: linux-s...@vger.kernel.org; linux-kernel@vger.kerne

RE: [PATCH 1/2] scsi: ufs: Add DeepSleep feature

HI, > Drivers that wish to support DeepSleep need to set a new capability flag > UFSHCD_CAP_DEEPSLEEP and provide a hardware reset via the existing > ->device_reset() callback. I would expect that this capability controls sending SSU 4, but it only controls the sysfs entry? > > It is assumed

RE: [PATCH 2/2] scsi: ufs: Workaround UFS devices that object to DeepSleep IMMED

> > The UFS specification says to set the IMMED (immediate) flag for the > Start/Stop Unit command when entering DeepSleep. However some UFS > devices object to that. Workaround that by retrying without IMMED. > Whichever possibility works, the result is recorded for the next > time. As

RE: [PATCH 1/2] scsi: ufs: Add DeepSleep feature

> > > On 5/10/20 11:02 am, Avri Altman wrote: > > HI, > > > >> Drivers that wish to support DeepSleep need to set a new capability flag > >> UFSHCD_CAP_DEEPSLEEP and provide a hardware reset via the existing > >> ->device_reset() callbac

RE: [PATCH 1/2] scsi: ufs: Add DeepSleep feature

> > On 5/10/20 12:51 pm, Avri Altman wrote: > >> > >> > >> On 5/10/20 11:02 am, Avri Altman wrote: > >>> HI, > >>> > >>>> Drivers that wish to support DeepSleep need to set a new capability flag > >>>> UF

RE: [PATCH v1] scsi: ufs-mediatek: Fix incorrect time to wait link status

> > Fix incorrect calculation of "ms" based waiting time in > function ufs_mtk_setup_clocks(). > > Fixes: 9006e3986f66 ("scsi: ufs-mediatek: Do not gate clocks if auto-hibern8 > is > not entered yet") > Signed-off-by: Stanley Chu Reviewed-by: Avri Altman

RE: [PATCH 1/2] scsi: ufs: Fix interrupt error message for shared interrupts

> The interrupt might be shared, in which case it is not an error for the > interrupt handler to be called when the interrupt status is zero, so > remove the message print and register dump. > > Signed-off-by: Adrian Hunter > Fixes: 9333d77573485 ("scsi: ufs: Fix irq return code") > --- >

RE: [PATCH V2 1/2] scsi: ufs: Fix interrupt error message for shared interrupts

("scsi: ufs: Fix irq return code") Reviewed-by: Avri Altman

RE: [PATCH 4/4] scsi: ufs-mediatek: Add host reset mechanism

> > > Add host reset mechanism to try to recover host-side errors > during recovery flow. > > Signed-off-by: Stanley Chu Reviewed-by Avri Altman See some nit below as well. Thanks, Avri > +static void ufs_mtk_init_reset_contro

RE: [PATCH V2] scsi: ufs-pci: Add LTR support for Intel controllers

> > Intel host controllers support the setting of latency tolerance. > Accordingly, implement the PM QoS ->set_latency_tolerance() callback. The > raw register values are also exposed via debugfs. > > Signed-off-by: Adrian Hunter Reviewed-by: Avri Altman

RE: [PATCH V2 2/2] scsi: ufs: Improve interrupt handling for shared interrupts

> > For shared interrupts, the interrupt status might be zero, so check that > first. > > Signed-off-by: Adrian Hunter Reviewed-by: Avri Altman

RE: [PATCH v2 1/2] scsi: ufs: Cleanup completed request without interrupt notification

> > > > Signed-off-by: Stanley Chu > > Reviewed-by: Can Guo > > Signed-off-by: Bean Huo Acked-by: Avri Altman

RE: [PATCH v1 1/2] scsi: dt-bindings: ufs: Add vcc-voltage-level for UFS

> > > UFS's specifications supports a range of Vcc operating > voltage levels. Add documentation for the UFS's Vcc voltage > levels setting. > > Signed-off-by: Can Guo > Signed-off-by: Asutosh Das > Signed-off-by: Bao D. Nguyen > --- >

RE: [PATCH v1 2/2] scsi: ufs: Support reading UFS's Vcc voltage from device tree

> > The UFS specifications supports a range of Vcc operating voltage > from 2.4-3.6V depending on the device and manufacturers. > Allows selecting the UFS Vcc voltage level by setting the > UFS's entry vcc-voltage-level in the device tree. If UFS's > vcc-voltage-level setting is not found in

RE: [PATCH] scsi: ufs: Fix NOP OUT timeout value

n to check whether > the device transport protocol is ready or not. This issue is resolved by > releasing NOP_OUT_TIMEOUT value. > > NOP_OUT_TIMEOUT: 30ms -> 50ms > > Signed-off-by: Daejun Park Acked-by: Avri Altman

RE: [PATCH v1 1/1] scsi: ufshcd: Properly set the device Icc Level

> > On 2020-08-31 18:19, Bao D. Nguyen wrote: > > UFS version 3.0 and later devices require Vcc and Vccq power supplies > > with Vccq2 being optional. While earlier UFS version 2.0 and 2.1 > > devices, the Vcc and Vccq2 are required with Vccq being optional. > > Check the required power supplies

RE: [PATCH v1 2/2] scsi: ufs: Support reading UFS's Vcc voltage from device tree

> > Maybe instead call ufshcd_populate_vreg with the new name, > > To not break the function flow, and just add another else if ? > Could you please clarify your comments? Are you suggesting to create a > new function? > Thank you. No, just call ufshcd_populate_vreg with the new name, e.g.

RE: [PATCH v1] scsi: ufs-mediatek: Enable UFSHCI_QUIRK_SKIP_MANUAL_WB_FLUSH_CTRL

Hi, Just to clarify things: > > Do you see any substantial benefit of having fWriteBoosterBufferFlushEn > > disabled? > > 1. The definition of fWriteBoosterBufferFlushEn is that host allows > device to do flush in anytime after fWriteBoosterBufferFlushEn is set as > on. This is not what we want.

RE: [PATCH v1] scsi: ufs-mediatek: Enable UFSHCI_QUIRK_SKIP_MANUAL_WB_FLUSH_CTRL

hibern8 is sufficient on MediaTek platforms, thus > > >> > enable UFSHCI_QUIRK_SKIP_MANUAL_WB_FLUSH_CTRL to skip > > enabling > > >> > fWriteBoosterBufferFlush during WriteBooster initialization. > > >> > > > >> > Signed-off-by: Stanley Chu Reviewed-by: Avri Altman

RE: [PATCH v3 2/3] scsi: ufs: Keep device active mode only fWriteBoosterBufferFlushDuringHibernate == 1

> From: Bean Huo > > According to the JEDEC UFS 3.1 Spec, If > fWriteBoosterBufferFlushDuringHibernate > is set to one, the device flushes the WriteBooster Buffer data automatically > whenever the link enters the hibernate (HIBERN8) state. While the flushing > operation is in progress, the

RE: [PATCH v3 2/3] scsi: ufs: Keep device active mode only fWriteBoosterBufferFlushDuringHibernate == 1

> On Wed, 2020-12-09 at 07:40 +0000, Avri Altman wrote: > > > According to the JEDEC UFS 3.1 Spec, If > > > fWriteBoosterBufferFlushDuringHibernate > > > is set to one, the device flushes the WriteBooster Buffer data > > > automatically > > > whenev

RE: [PATCH] scsi: ufs: fix livelock of ufshcd_clear_ua_wluns

> > > > > > > In order to avoid it, ufshcd_clear_ua_wluns() can be called per > > > recovery > > > > > > > flows > > > > > > > such as suspend/resume, link_recovery, and error_handler. > > > > > > Not sure that suspend/resume are UAC events? > > > > > > > > > > Could you elaborate a bit? The goal

RE: [PATCH v1] scsi: ufs-mediatek: Enable UFSHCI_QUIRK_SKIP_MANUAL_WB_FLUSH_CTRL

> > On 2020-12-23 12:19, Stanley Chu wrote: > > Hi Can, > > > > On Tue, 2020-12-22 at 19:34 +0800, Can Guo wrote: > >> On 2020-12-22 15:29, Stanley Chu wrote: > >> > Flush during hibern8 is sufficient on MediaTek platforms, thus > >> > enable UFSHCI_QUIRK_SKIP_MANUAL_WB_FLUSH_CTRL to skip >

RE: [PATCH RFC v4 1/1] scsi: ufs: Fix ufs power down/on specs violation

Hi, > > As per specs, e.g, JESD220E chapter 7.2, while powering > off/on the ufs device, RST_N signal and REF_CLK signal > should be between VSS(Ground) and VCCQ/VCCQ2. > > To flexibly control device reset line, refactor the function > ufschd_vops_device_reset(sturct ufs_hba *hba) to ufshcd_ >

RE: [PATCH v1 1/2] scsi: ufs: Replace sprintf and snprintf with sysfs_emit

> > From: Bean Huo > > sprintf and snprintf may cause output defect in sysfs content, it is > better to use new added sysfs_emit function which knows the size of the > temporary buffer. > > Suggested-by: Greg Kroah-Hartman > Signed-off-by: Bean Huo Reviewed-by: Avri Altman

RE: [PATCH v16 1/3] scsi: ufs: Introduce HPB feature

> > > On Sat, Dec 19, 2020 at 06:18:47PM +0900, Daejun Park wrote: > > +static int ufshpb_get_state(struct ufshpb_lu *hpb) > > +{ > > + return atomic_read(>hpb_state); > > +} > > + > > +static void ufshpb_set_state(struct ufshpb_lu *hpb, int state) > > +{ > > + atomic_set(>hpb_state,

RE: [PATCH] scsi: ufs: fix livelock of ufshcd_clear_ua_wluns

Hi J, > > When gate_work/ungate_work gets an error during hibern8_enter or exit, > ufshcd_err_handler() >ufshcd_scsi_block_requests() >ufshcd_reset_and_restore() > ufshcd_clear_ua_wluns() -> stuck >ufshcd_scsi_unblock_requests() > > In order to avoid it,

RE: [PATCH] scsi: ufs: fix livelock of ufshcd_clear_ua_wluns

> > > When gate_work/ungate_work gets an error during hibern8_enter or > exit, > > > ufshcd_err_handler() > > >ufshcd_scsi_block_requests() > > >ufshcd_reset_and_restore() > > > ufshcd_clear_ua_wluns() -> stuck > > >ufshcd_scsi_unblock_requests() > > > > > > In order to avoid it,

RE: [PATCH] scsi: ufs: fix livelock of ufshcd_clear_ua_wluns

> > > On 12/21, Avri Altman wrote: > > > > > When gate_work/ungate_work gets an error during hibern8_enter or > > > exit, > > > > > ufshcd_err_handler() > > > > >ufshcd_scsi_block_requests() > > > > >

RE: [PATCH v3 0/6] Several changes for the UPIU trace

tever makes sense to you. Thanks, Avri > -Original Message- > From: Bean Huo > Sent: Monday, December 14, 2020 10:20 PM > To: alim.akh...@samsung.com; Avri Altman ; > asuto...@codeaurora.org; j...@linux.ibm.com; > martin.peter...@oracle.com; stanley@mediatek.com; >

RE: [PATCH V2] scsi: ufs-debugfs: Add error counters

Please add my reviewed-by once you fix that. Thanks, Avri > However I do see a problem. When builtin, initcalls are ordered according > to link order, but the Makefile does not have ufshcd-core at the top i.e. > > $ cat drivers/scsi/ufs/Makefile > # SPDX-License-Identifier: GPL-2.0 > # UFSHCD

RE: [PATCH] scsi: ufs: Correct the lun used in eh_device_reset_handler() callback

r() callback > to count on the lun get from hba->lrb[-1]. Fix it by getting lun from the > SCSI device associated with the SCSI cmd. > > Signed-off-by: Can Guo Reviewed-by: Avri Altman Btw, am surprised to see that you guys are still using sg_reset instead of ufs-utils? Thanks, Avri

RE: [PATCH v2 1/1] scsi: ufs: Fix unexpected values get from ufshcd_read_desc_param()

> On 2020-10-22 14:37, Avri Altman wrote: > >> Since WB feature has been added, WB related sysfs entries can be > >> accessed > >> even when an UFS device does not support WB feature. In that case, the > >> descriptors which are not supported by the UFS d

RE: [PATCH 4/4] scsi: add more contexts in the ufs tracepoints

> > On 2020-10-06 06:36, Jaegeuk Kim wrote: > > From: Jaegeuk Kim > > > > This adds user-friendly tracepoints with group id. You have the entire cdb as part of the upiu trace, Can't you parse what you need from there? Thanks, Avri

RE: [PATCH 4/4] scsi: add more contexts in the ufs tracepoints

> > On 2020-10-20 18:51, Avri Altman wrote: > >> > >> On 2020-10-06 06:36, Jaegeuk Kim wrote: > >> > From: Jaegeuk Kim > >> > > >> > This adds user-friendly tracepoints with group id. > > You have the entire cdb

RE: [PATCH v2 1/1] scsi: ufs: Fix unexpected values get from ufshcd_read_desc_param()

> Since WB feature has been added, WB related sysfs entries can be accessed > even when an UFS device does not support WB feature. In that case, the > descriptors which are not supported by the UFS device may be wrongly > reported when they are accessed from their corrsponding sysfs entries. > Fix

RE: [PATCH] scsi: ufs: make sure scan sequence for multiple hosts

> > > > Did you mean /dev/disk/by-[part]label/ symlink? It's quite reasonable to > > > use them by udev in userspace such as initramfs but some cases does not > > use > > > initramfs or initrd. In that case, we need to load the root > > > device(/dev/sda[N]) directly from kernel. > > > > Please

RE: [PATCH v2] scsi: ufshcd: fix missing destroy_workqueue()

> > > Add the missing destroy_workqueue() before return from > ufshcd_init in the error handling case as well as in > ufshcd_remove. > > Fixes: 4db7a2360597 ("scsi: ufs: Fix concurrency of error handler and other > error recovery paths") > Suggested-by: A

RE: [RFC PATCH v1] scsi: ufs: Remove pre-defined initial VCC voltage values

> > Hi Stanley > > > > Thanks for the patch. Bao (nguyenb) was also working towards > something > > similar. > > Would it be possible for you to take into account the scenario in > which the > > same platform supports both 2.x and 3.x UFS devices? > > > >

RE: [PATCH v2] scsi: ufs: Remove pre-defined initial voltage values of device powers

e NULL > by default and UFS core driver will enable or disable the regulator > only without adjusting its voltage. > > Reviewed-by: Bjorn Andersson > Signed-off-by: Stanley Chu Acked-by: Avri Altman

RE: [PATCH v4 0/8] Refine error history and introduce event_notify vop

Hi Stanley, Will you split this series to 3 separate series: Phy initialization cleanup, Error history, and event notification? As those 3 aren't really connected? Please maintain Can's reviewed-by tag for the error history patches, And add mine for the phy initialization, so Martin can pick

RE: [PATCH v4 0/8] Refine error history and introduce event_notify vop

> > Hi Stanley, > Will you split this series to 3 separate series: > Phy initialization cleanup, Error history, and event notification? > As those 3 aren't really connected? > > Please maintain Can's reviewed-by tag for the error history patches, > And add mine for the phy initialization, so

RE: [PATCH] ufshcd: fix Wsometimes-uninitialized warning

; > Turn the BUG_ON(1) into an unconditional BUG() that makes it clear > to clang that this code path is never hit. > > Fixes: 4f3e900b6282 ("scsi: ufs: Clear UAC for FFU and RPMB LUNs") > Signed-off-by: Arnd Bergmann Reviewed-by: Avri Altman > --- > drivers/scsi/uf

RE: [PATCH] ufshcd: fix Wsometimes-uninitialized warning

; > Turn the BUG_ON(1) into an unconditional BUG() that makes it clear > to clang that this code path is never hit. > > Fixes: 4f3e900b6282 ("scsi: ufs: Clear UAC for FFU and RPMB LUNs") > Signed-off-by: Arnd Bergmann Reviewed-by: Avri Altman > --- > drivers/scsi/uf

RE: [PATCH v2 1/3] scsi: ufs: Add "wb_on" sysfs node to control WB on/off

/0 to "wb_on" sysfs node to enable/disable UFS WB. > > Signed-off-by: Bean Huo Reviewed-by: Avri Altman

RE: [PATCH v1 1/3] scsi: ufs: Distinguish between query REQ and query RSP in query trace

00 0e 00 81 00 00 00 00 00 00, CDB:06 0e 03 00 00 00 00 > 00 00 00 00 00 00 00 00 00 > ufshcd_upiu: HDR:36 00 00 0e 00 81 00 00 00 00 00 00, CDB:06 0e 03 00 00 00 00 > 00 00 00 00 01 00 00 00 00 > > Signed-off-by: Bean Huo Acked-by: Avri Altman But you need to cha

RE: [PATCH 2/3] scsi: ufs: Keep device power on only fWriteBoosterBufferFlushDuringHibernate == 1

> > From: Bean Huo > > Keep device power mode as active power mode and VCC supply only if > fWriteBoosterBufferFlushDuringHibernate setting 1 is successful. Why would it fail? Since UFSHCD_CAP_WB_EN is toggled off on ufshcd_wb_probe If the device doesn't support wb, The check

RE: [PATCH v2 3/3] scsi: ufs: Introduce event_notify variant function

> > Introduce event_notify variant function to allow > vendor to get notification of important events and connect > to vendor-specific debugging facilities. You need to add an implementation of this vop, otherwise it's just dead code. Thanks, Avri

RE: [PATCH 2/3] scsi: ufs: Keep device power on only fWriteBoosterBufferFlushDuringHibernate == 1

> > On Thu, 2020-12-03 at 07:27 +, Avri Altman wrote: > > > > > > From: Bean Huo > > > > > > Keep device power mode as active power mode and VCC supply only if > > > fWriteBoosterBufferFlushDuringHibernate setting 1 is successful. > &g

RE: [PATCH 2/3] scsi: ufs: Keep device power on only fWriteBoosterBufferFlushDuringHibernate == 1

> On Thu, 2020-12-03 at 10:46 +0000, Avri Altman wrote: > > > > > From: Bean Huo > > > > > > > > > > Keep device power mode as active power mode and VCC supply only > > > > > if > > > > > fWriteBoosterBufferFlushDurin

RE: [PATCH] mmc: core: MMC_CAP2_HS200_1_8V_SDR with mmc-hs400-1_8v

001 DG4008 partition 2 4.00 MiB > [1.859182] mmcblk1rpmb: mmc1:0001 DG4008 partition 3 4.00 MiB, chardev > (242:0) > > Fixes: c373eb489b27b mmc: core: add DT bindings for eMMC HS400 1.8/1.2V > > Signed-off-by: Chris Ruehl Acked-by: Avri Altman

RE: [PATCH 2/2] mmc: core: MMC_CAP2_HS200_1_8V_SDR with mmc-hs400-1_8v

001 DG4008 partition 2 4.00 MiB > [1.859182] mmcblk1rpmb: mmc1:0001 DG4008 partition 3 4.00 MiB, chardev > (242:0) > > Fixes: c373eb489b27b mmc: core: add DT bindings for eMMC HS400 1.8/1.2V > > Signed-off-by: Chris Ruehl Acked-by: Avri Altman

RE: [PATCH] scsi: ufshcd: fix missing destroy_workqueue() on error in ufshcd_init

> > Add the missing destroy_workqueue() before return from > ufshcd_init in the error handling case. It seems that > exit_gating is an appropriate place. > > Fixes: 4db7a2360597 ("scsi: ufs: Fix concurrency of error handler and other > error recovery paths") > Signed-off-by: Qinglang Miao > ---

RE: [PATCH -next] scsi: ufshcd: use devm_platform_ioremap_resource() to simplify code

> > > Use devm_platform_ioremap_resource() to simplify the code a bit. > This is detected by coccinelle. > > Reported-by: Hulk Robot > Signed-off-by: YueHaibing Reviewed-by: Avri Altman

RE: [PATCH -next] scsi: ufs-hisi: use devm_platform_ioremap_resource() to simplify code

> Use devm_platform_ioremap_resource() to simplify the code a bit. > This is detected by coccinelle. > > Reported-by: Hulk Robot > Signed-off-by: YueHaibing Reviewed-by: Avri Altman

RE: [PATCH 2/2] mmc: block: add CMD13 polling for ioctl() cmd with R1B response

> static int __mmc_blk_ioctl_cmd(struct mmc_card *card, struct > mmc_blk_data *md, >struct mmc_blk_ioc_data *idata) > { > @@ -623,6 +675,9 @@ static int __mmc_blk_ioctl_cmd(struct mmc_card > *card, struct mmc_blk_data *md, >

RE: [PATCH] scsi: ufs: Additional clock initialization in Cadence UFS

hce_enable_notify > will be called everytime controller is reenabled. > > Signed-off-by: Anil Varughese Reviewed-by: Avri Altman

RE: [PATCH] scsi: ufs: Check that space was properly alloced in copy_query_response

Hi Alim, Thank you for your review. Sorry for the late response - I was away for a couple of weeks. Thanks, Avri > Subject: Re: [PATCH] scsi: ufs: Check that space was properly alloced in > copy_query_response > > Hi Avri > > On 5/21/19 1:54 PM, Avri Altman wrote: >

RE: [PATCH] scsi: ufs-pci: Add LTR support for Intel controllers

> > Intel host controllers support the setting of latency tolerance. > Accordingly, implement the PM QoS ->set_latency_tolerance() callback. The > raw register values are also exposed via debugfs. > > Signed-off-by: Adrian Hunter Reviewed-by: Avri Altman Some nits

RE: [PATCH] scsi: ufs-mediatek: Modify the minimum RX/TX lane count to 2

nes properly during power mode change. So we could relax > the limitation in ufs_dev_params. > > Reviewed-by: Stanley Chu > Signed-off-by: Andy Teng > Singed-off-by: Stanley Chu Reviewed-by: Avri Altman But then again, why those constants needs to be re-negotiated every pre-change? Thanks, Avri

RE: [PATCH] scsi: ufs: Remove an unpaired ufshcd_scsi_unblock_requests() in err_handler()

> > Commit 5586dd8ea250a ("scsi: ufs: Fix a race condition between error > handler and runtime PM ops") moves the ufshcd_scsi_block_requests() inside > err_handler(), but forgets to remove the ufshcd_scsi_unblock_requests() in > the early return path. Correct the coding mistake. "fixes" tag

RE: [PATCH v1 1/1] scsi: ufshcd: Allow zero value setting to Auto-Hibernate Timer

> > On 2020-08-29 00:32, Avri Altman wrote: > >> > >> The zero value Auto-Hibernate Timer is a valid setting, and it > >> indicates the Auto-Hibernate feature being disabled. Correctly > > Right. So " ufshcd_auto_hibern8_enable"

RE: [PATCH v1 1/1] scsi: ufshcd: Allow zero value setting to Auto-Hibernate Timer

> > The zero value Auto-Hibernate Timer is a valid setting, and it > indicates the Auto-Hibernate feature being disabled. Correctly Right. So " ufshcd_auto_hibern8_enable" is no longer an appropriate name. Maybe ufshcd_auto_hibern8_set instead? Also, did you verified that no other platform

RE: [PATCH v2] scsi: ufs: ti-j721e-ufs: Fix error return in ti_j721e_ufs_probe()

> > Fix to return error code PTR_ERR() from the error handling case instead > of 0. > > Fixes: 22617e216331 ("scsi: ufs: ti-j721e-ufs: Fix unwinding of pm_runtime > changes") > Signed-off-by: Jing Xiangfeng Reviewed-by: Avri Altman

RE: [PATCH v8 0/4] scsi: ufs: Add Host Performance Booster Support

> > Hi Avri > what is your plan for this series patchset? I already acked it. Waiting for the senior members to decide. Thanks, Avri > > Bean

RE: [PATCH v8 0/4] scsi: ufs: Add Host Performance Booster Support

> > On Thu, 2020-08-06 at 09:56 +, Avri Altman wrote: > > > > > > Hi Avri > > > what is your plan for this series patchset? > > > > I already acked it. > > Waiting for the senior members to decide. > > > > Thanks,

RE: [PATCH v8 0/4] scsi: ufs: Add Host Performance Booster Support

> > On Thu, 2020-08-06 at 10:12 +, Avri Altman wrote: > > > > > > > > > > we didn't see you Acked-by in the pathwork, would you like to add > > > them? > > > Just for reminding us that you have agreed to mainline this series > > &g

RE: [PATCH 1/4] scsi: ufs-mediatek: Eliminate error message for unbound mphy

> > Some MediaTek platforms does not have to bind MPHY so users > shall not see any unnecessary logs. Simply remove logs for this > case. > > Fixes: fc4983018fea ("scsi: ufs-mediatek: Allow unbound mphy") > Signed-off-by: Stanley Chu Reviewed-by: Avri Altman

RE: [PATCH 2/4] scsi: ufs-mediatek: Fix HOST_PA_TACTIVATE quirk

> > Simply add HOST_PA_TACTIVATE quirk back since it was incorrectly > removed before. > > Fixes: 47d054580a75 ("scsi: ufs-mediatek: fix HOST_PA_TACTIVATE quirk for > Samsung UFS Devices") > Signed-off-by: Stanley Chu Reviewed-by: Avri Altman

RE: [PATCH 3/4] scsi: ufs-mediatek: Fix flag of unipro low-power mode

> > Forcibly leave UniPro low-power mode if UIC commands is failed. > This makes hba_enable_delay_us as correct (default) value for > re-enabling the host. > > At the same time, change type of parameter "lpm" in function > ufs_mtk_unipro_set_pm() to "bool". Semantically, better leave it u32 as

RE: [PATCH v2 1/2] scsi: ufs: Put hba into LPM during clk gating

> > > From: Can Guo > > During clock gating, after clocks are disabled, > put hba into LPM to save more power. > > Acked-by: Stanley Chu > Signed-off-by: Can Guo > Signed-off-by: Asutosh Das Reviewed-by: Avri Altman

RE: [PATCH v2 2/2] ufs: qcom: Enable aggressive power collapse for ufs hba

> > Enabling this capability to let hba power-collapse > more often to save power. > > Reviewed-by: Can Guo > Signed-off-by: Asutosh Das Reviewed-by: Avri Altman

RE: [PATCH v1 1/6] scsi: ufs-mediatek: Assign arguments with correct type

> > In ufs_mtk_unipro_set_lpm(), use specific unsigned values > as the argument to invoke ufshcd_dme_set(). > > In the same time, change the name of ufs_mtk_unipro_set_pm() > to ufs_mtk_unipro_set_lpm() to align the naming convention > in MediaTek UFS driver. > > Signed-off-by: Stanley Chu

RE: [PATCH v1 1/6] scsi: ufs-mediatek: Assign arguments with correct type

> > Hi Avri, > > On Tue, 2020-11-03 at 07:12 +, Avri Altman wrote: > > > > > > In ufs_mtk_unipro_set_lpm(), use specific unsigned values > > > as the argument to invoke ufshcd_dme_set(). > > > > > > In the same time, change the name o

[PATCH 1/8] scsi: ufshpb: Cache HPB Control mode on init

We will use it later, when we'll need to differentiate between device and host control modes. Signed-off-by: Avri Altman --- drivers/scsi/ufs/ufshpb.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/ufs/ufshpb.c b/drivers/scsi/ufs/ufshpb.c index

[PATCH 3/8] scsi: ufshpb: Add region's reads counter

t. Signed-off-by: Avri Altman --- drivers/scsi/ufs/ufshpb.c | 96 +-- drivers/scsi/ufs/ufshpb.h | 5 ++ 2 files changed, 86 insertions(+), 15 deletions(-) diff --git a/drivers/scsi/ufs/ufshpb.c b/drivers/scsi/ufs/ufshpb.c index 5fa1f5bc08e6..51c360716

  1   2   3   4   5   6   >