From: Christina Jacob
CGX supports setting advertised link modes on physical link.
This patch adds support to derive cgx mode from ethtool
link mode and pass it to firmware to configure the same.
Signed-off-by: Christina Jacob
Signed-off-by: Sunil Goutham
Signed-off-by: Hariprasad Kelam
This series of patches add support for forward error correction(fec) and
physical link configuration. Patches 1&2 adds necessary mbox handlers
for fec mode configuration request and to fetch stats. Patch 3 registers
driver callbacks for fec mode configuration and display. Patch 4&5 adds
support of
and
CGX_CMD_DISPLAY_EYE to enum cgx_cmd_id so that Linux's enum list is in sync
with firmware's enum list.
Signed-off-by: Felix Manlunas
Signed-off-by: Christina Jacob
Signed-off-by: Sunil Kovvuri Goutham
Signed-off-by: Hariprasad Kelam
---
drivers/net/ethernet/marvell/octeontx2/af/cgx.c| 12
-off-by: Sunil Goutham
Signed-off-by: Hariprasad Kelam
---
.../ethernet/marvell/octeontx2/nic/otx2_ethtool.c | 59 ++
1 file changed, 59 insertions(+)
diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c
b/drivers/net/ethernet/marvell/octeontx2/nic
-off-by: Sunil Goutham
Signed-off-by: Hariprasad Kelam
---
.../ethernet/marvell/octeontx2/nic/otx2_common.c | 23 +++
.../ethernet/marvell/octeontx2/nic/otx2_common.h | 6 +
.../ethernet/marvell/octeontx2/nic/otx2_ethtool.c | 174 -
.../net/ethernet/marvell/octeontx2
timeout
to accomdate firmware command response timeout.
Along with new CGX_CMD_SET_FEC command add other commands to
sync with kernel enum list with firmware.
Signed-off-by: Christina Jacob
Signed-off-by: Sunil Goutham
Signed-off-by: Hariprasad Kelam
---
drivers/net/ethernet/marvell/octeontx2
and read these parameters.
Signed-off-by: Christina Jacob
Signed-off-by: Sunil Goutham
Signed-off-by: Hariprasad Kelam
---
drivers/net/ethernet/marvell/octeontx2/af/cgx.c| 60 +-
drivers/net/ethernet/marvell/octeontx2/af/cgx.h| 2 +
.../net/ethernet/marvell/octeontx2/af
:
Speed: 10Mb/s
Duplex: Full
Signed-off-by: Christina Jacob
Signed-off-by: Sunil Goutham
Signed-off-by: Hariprasad Kelam
---
.../ethernet/marvell/octeontx2/nic/otx2_ethtool.c | 157 +
1 file changed, 157 insertions(+)
diff --git a/drivers/net/ethernet
Hi Jakub,
> -Original Message-
> From: Jakub Kicinski
> Sent: Saturday, January 23, 2021 10:00 AM
> To: Hariprasad Kelam
> Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org;
> da...@davemloft.net; Sunil Kovvuri Goutham ;
> Linu Cherian ; Geethasowjanya
Remove unused macro IS_MAC_ADDRESS_BROADCAST. In future if one wants use
it ,use generic API "is_broadcast_ether_addr"
Signed-off-by: Hariprasad Kelam
---
drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/staging/rtl8
Remove unneeded declaration "extern unsigned char WFD_OUI"
Signed-off-by: Hariprasad Kelam
---
drivers/staging/rtl8723bs/core/rtw_ap.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c
b/drivers/staging/rtl8723bs/core/rtw_ap.c
index 02f547
As mt6358_codec_init_reg function always returns 0 , change return type
from int to void.
fixes below issue reported by coccicheck
sound/soc/codecs/mt6358.c:2260:5-8: Unneeded variable: "ret". Return "0"
on line 2289
Signed-off-by: Hariprasad Kelam
---
sound/soc/codecs/mt
5-8: Unneeded variable: "ret". Return
"0" on line 3784
sound/soc/codecs/wcd9335.c:3896:5-8: Unneeded variable: "ret". Return
"0" on line 3934
sound/soc/codecs/wcd9335.c:3026:5-8: Unneeded variable: "ret". Return
"0" on line 3038
We cann
of these functions as they are callback
functions of snd_pcm_ops
Signed-off-by: Hariprasad Kelam
---
sound/soc/bcm/cygnus-pcm.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/sound/soc/bcm/cygnus-pcm.c b/sound/soc/bcm/cygnus-pcm.c
index 123ecf5..8966b02 100644
--- a/sound/
On Fri, Jul 05, 2019 at 10:10:06PM +0200, Ladislav Michl wrote:
> On Fri, Jul 05, 2019 at 12:40:26AM +0530, Hariprasad Kelam wrote:
> > Add IRQF_ONESHOT to ensure "Interrupt is not reenabled after the hardirq
> > handler finished".
> >
> > fixes below issue
Add IRQF_ONESHOT to ensure "Interrupt is not reenabled after the hardirq
handler finished".
fixes below issue reported by coccicheck
sound/soc/codecs/wcd9335.c:4068:8-33: ERROR: Threaded IRQ with no
primary handler requested without IRQF_ONESHOT
Signed-off-by: Hariprasad Kelam
--
This patch fixes below issue reported by coccicheck
sound/pci/lx6464es/lx6464es.c:256:5-8: Unneeded variable: "err". Return
"0" on line 258
We cannot change return value as its registered with snd_pcm_ops->close
Signed-off-by: Hariprasad Kelam
---
sound/pci/lx6464es/lx6
This patch fixes below issue reported by coccicheck
sound/ppc/snd_ps3.c:631:5-8: Unneeded variable: "ret". Return "0" on
line 668
We cannot change return type of snd_ps3_pcm_trigger as it is registered
with snd_pcm_ops->trigger
Signed-off-by: Hariprasad Kelam
---
sound/p
this patch fixes "Comparison to NULL" warnings reported by
checkpatch
Signed-off-by: Hariprasad Kelam
---
drivers/staging/rtl8723bs/core/rtw_xmit.c | 54 +++
1 file changed, 27 insertions(+), 27 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw
ned-off-by: Hariprasad Kelam
---
drivers/scsi/dpt_i2o.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c
index a3afd14..128d4f9 100644
--- a/drivers/scsi/dpt_i2o.c
+++ b/drivers/scsi/dpt_i2o.c
@@ -1334,7 +1334,6 @@ static s32 adpt_i2o_reset_
This patch fixes below warning reported by coccicheck
./drivers/scsi/pmcraid.c:4728:3-21: WARNING: dma_alloc_coherent use in
pinstance -> hrrq_start [ i ] already zeroes out memory, so memset is
not needed
Signed-off-by: Hariprasad Kelam
---
drivers/scsi/pmcraid.c | 2 --
1 file changed
fix below issues reported by checkpatch
CHECK: Using comparison to false is error prone
CHECK: Using comparison to true is error prone
Signed-off-by: Hariprasad Kelam
changes in v2: send proper patch without corruption
---
drivers/staging/rtl8723bs/hal/sdio_halinit.c | 18
This patch fixes below issues reported by checkpatch
CHECK: spaces preferred around that '+' (ctx:VxV)
CHECK: spaces preferred around that '<<' (ctx:VxV)
CHECK: spaces preferred around that '|' (ctx:VxV)
Signed-off-by: Hariprasad Kelam
--
changes in v2: Send proper patch without corr
This patch fixes below issue reported by checkpatch
CHECK: Comparison to NULL could be written "psta"
CHECK: Comparison to NULL could be written "psta"
Signed-off-by: Hariprasad Kelam
-
changes in v2: Send proper patch with out corruption
---
drivers/s
On Mon, Jul 22, 2019 at 11:26:09AM +0100, Steven Price wrote:
> On 19/07/2019 19:46, Hariprasad Kelam wrote:
> > Memory allocated by devm_ alloc will be freed upon device detachment. So
> > we may not require free memory.
> >
> > Signed-off-by: Hariprasad Kelam
>
-off-by: Sunil Goutham
Signed-off-by: Hariprasad Kelam
---
.../ethernet/marvell/octeontx2/nic/otx2_ethtool.c | 67 ++
1 file changed, 67 insertions(+)
diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c
b/drivers/net/ethernet/marvell/octeontx2/nic
:
Speed: 10Mb/s
Duplex: Full
Signed-off-by: Christina Jacob
Signed-off-by: Sunil Goutham
Signed-off-by: Hariprasad Kelam
---
.../ethernet/marvell/octeontx2/nic/otx2_ethtool.c | 151 +
1 file changed, 151 insertions(+)
diff --git a/drivers/net/ethernet
-off-by: Sunil Goutham
Signed-off-by: Hariprasad Kelam
---
.../ethernet/marvell/octeontx2/nic/otx2_common.c | 20 +++
.../ethernet/marvell/octeontx2/nic/otx2_common.h | 6 +
.../ethernet/marvell/octeontx2/nic/otx2_ethtool.c | 181 -
.../net/ethernet/marvell/octeontx2
This series of patches add support for forward error correction(fec) and
physical link configuration. Patches 1&2 adds necessary mbox handlers for fec
mode configuration request and to fetch stats. Patch 3 registers driver
callbacks for fec mode configuration and display. Patch 4&5 adds support of
timeout
to accomdate firmware command response timeout.
Along with new CGX_CMD_SET_FEC command add other commands to
sync with kernel enum list with firmware.
Signed-off-by: Christina Jacob
Signed-off-by: Sunil Goutham
Signed-off-by: Hariprasad Kelam
---
drivers/net/ethernet/marvell/octeontx2
and
CGX_CMD_DISPLAY_EYE to enum cgx_cmd_id so that Linux's enum list is in sync
with firmware's enum list.
Signed-off-by: Felix Manlunas
Signed-off-by: Christina Jacob
Signed-off-by: Sunil Kovvuri Goutham
Signed-off-by: Hariprasad Kelam
---
drivers/net/ethernet/marvell/octeontx2/af/cgx.c| 12
and read these parameters.
Signed-off-by: Christina Jacob
Signed-off-by: Sunil Goutham
Signed-off-by: Hariprasad Kelam
---
drivers/net/ethernet/marvell/octeontx2/af/cgx.c| 58 +-
drivers/net/ethernet/marvell/octeontx2/af/cgx.h| 2 +
.../net/ethernet/marvell/octeontx2/af
From: Christina Jacob
CGX supports setting advertised link modes on physical link.
This patch adds support to derive cgx mode from ethtool
link mode and pass it to firmware to configure the same.
Signed-off-by: Christina Jacob
Signed-off-by: Sunil Goutham
Signed-off-by: Hariprasad Kelam
-off-by: Sunil Goutham
Signed-off-by: Hariprasad Kelam
---
.../ethernet/marvell/octeontx2/nic/otx2_common.c | 20 +++
.../ethernet/marvell/octeontx2/nic/otx2_common.h | 6 +
.../ethernet/marvell/octeontx2/nic/otx2_ethtool.c | 181 -
.../net/ethernet/marvell/octeontx2
timeout
to accomdate firmware command response timeout.
Along with new CGX_CMD_SET_FEC command add other commands to
sync with kernel enum list with firmware.
Signed-off-by: Christina Jacob
Signed-off-by: Sunil Goutham
Signed-off-by: Hariprasad Kelam
---
drivers/net/ethernet/marvell/octeontx2
This series of patches add support for forward error correction(fec) and
physical link configuration. Patches 1&2 adds necessary mbox handlers for fec
mode configuration request and to fetch stats. Patch 3 registers driver
callbacks for fec mode configuration and display. Patch 4&5 adds support of
and read these parameters.
Signed-off-by: Christina Jacob
Signed-off-by: Sunil Goutham
Signed-off-by: Hariprasad Kelam
---
drivers/net/ethernet/marvell/octeontx2/af/cgx.c| 58 +-
drivers/net/ethernet/marvell/octeontx2/af/cgx.h| 2 +
.../net/ethernet/marvell/octeontx2/af
-off-by: Sunil Goutham
Signed-off-by: Hariprasad Kelam
---
.../ethernet/marvell/octeontx2/nic/otx2_ethtool.c | 67 ++
1 file changed, 67 insertions(+)
diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c
b/drivers/net/ethernet/marvell/octeontx2/nic
and
CGX_CMD_DISPLAY_EYE to enum cgx_cmd_id so that Linux's enum list is in sync
with firmware's enum list.
Signed-off-by: Felix Manlunas
Signed-off-by: Christina Jacob
Signed-off-by: Sunil Kovvuri Goutham
Signed-off-by: Hariprasad Kelam
---
drivers/net/ethernet/marvell/octeontx2/af/cgx.c| 12
:
Speed: 10Mb/s
Duplex: Full
Signed-off-by: Christina Jacob
Signed-off-by: Sunil Goutham
Signed-off-by: Hariprasad Kelam
---
.../ethernet/marvell/octeontx2/nic/otx2_ethtool.c | 151 +
1 file changed, 151 insertions(+)
diff --git a/drivers/net/ethernet
From: Christina Jacob
CGX supports setting advertised link modes on physical link.
This patch adds support to derive cgx mode from ethtool
link mode and pass it to firmware to configure the same.
Signed-off-by: Christina Jacob
Signed-off-by: Sunil Goutham
Signed-off-by: Hariprasad Kelam
This series of patches add support for forward error correction(fec) and
physical link configuration. Patches 1&2 adds necessary mbox handlers for fec
mode configuration request and to fetch stats. Patch 3 registers driver
callbacks for fec mode configuration and display. Patch 4&5 adds support of
and read these parameters.
Signed-off-by: Christina Jacob
Signed-off-by: Sunil Goutham
Signed-off-by: Hariprasad Kelam
---
drivers/net/ethernet/marvell/octeontx2/af/cgx.c| 60 +-
drivers/net/ethernet/marvell/octeontx2/af/cgx.h| 2 +
.../net/ethernet/marvell/octeontx2/af
:
Speed: 10Mb/s
Duplex: Full
Signed-off-by: Christina Jacob
Signed-off-by: Sunil Goutham
Signed-off-by: Hariprasad Kelam
---
.../ethernet/marvell/octeontx2/nic/otx2_ethtool.c | 159 +
1 file changed, 159 insertions(+)
diff --git a/drivers/net/ethernet
Hi Willem,
> -Original Message-
> From: Willem de Bruijn
> Sent: Thursday, January 28, 2021 2:04 AM
> To: Hariprasad Kelam
> Cc: Network Development ; LKML ker...@vger.kernel.org>; David Miller ; Jakub
> Kicinski ; Sunil Kovvuri Goutham
> ; Linu Cherian
Hi Andrew Lunn,
> -Original Message-
> From: Andrew Lunn
> Sent: Wednesday, January 27, 2021 7:22 PM
> To: Hariprasad Kelam
> Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org;
> da...@davemloft.net; k...@kernel.org; Sunil Kovvuri Goutham
> ; Linu Cheri
Hi Willem,
> -Original Message-
> From: Willem de Bruijn
> Sent: Thursday, January 28, 2021 2:01 AM
> To: Hariprasad Kelam
> Cc: Network Development ; LKML ker...@vger.kernel.org>; David Miller ; Jakub
> Kicinski ; Sunil Kovvuri Goutham
> ; Linu Cherian ;
> G
Hi Willem,
> -Original Message-
> From: Willem de Bruijn
> Sent: Thursday, January 28, 2021 1:45 AM
> To: Hariprasad Kelam
> Cc: Network Development ; LKML ker...@vger.kernel.org>; David Miller ; Jakub
> Kicinski ; Sunil Kovvuri Goutham
> ; Linu Cherian ;
> G
Hi Andrew Lunn,
> -Original Message-
> From: Andrew Lunn
> Sent: Wednesday, January 27, 2021 6:56 PM
> To: Hariprasad Kelam
> Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org;
> da...@davemloft.net; k...@kernel.org; Sunil Kovvuri Goutham
> ; Linu Cheri
Hi Willem,
> -Original Message-
> From: Willem de Bruijn
> Sent: Thursday, January 28, 2021 1:50 AM
> To: Hariprasad Kelam
> Cc: Network Development ; LKML ker...@vger.kernel.org>; David Miller ; Jakub
> Kicinski ; Sunil Kovvuri Goutham
> ; Linu Cherian ;
> G
Hi Willem,
> -Original Message-
> From: Willem de Bruijn
> Sent: Saturday, January 30, 2021 7:57 PM
> To: Hariprasad Kelam
> Cc: Network Development ; LKML ker...@vger.kernel.org>; David Miller ; Jakub
> Kicinski ; Sunil Kovvuri Goutham
> ; Linu Cherian ;
> G
As init_mlme_ext_priv function always returns SUCCESS , We can change
return type from int to void.
Fixes below issue identified by coccicheck
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c:464:5-8: Unneeded
variable: "res". Return "_SUCCESS" on line 492
Signed-off-
.
net/sctp/sm_make_chunk.c:2667:3-8: WARNING: NULL check before some
freeing functions is not needed.
net/sctp/sm_make_chunk.c:2684:3-8: WARNING: NULL check before some
freeing functions is not needed.
Signed-off-by: Hariprasad Kelam
---
net/sctp/sm_make_chunk.c | 12
1 file changed, 4
fix below issue reported by coccicheck
drivers/infiniband/hw/qib/qib_file_ops.c:1792:5-8: Unneeded variable:
"ret". Return "0" on line 1876
Signed-off-by: Hariprasad Kelam
---
drivers/infiniband/hw/qib/qib_file_ops.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
fix below issue reported by coccicheck
drivers/infiniband/hw/qedr/verbs.c:2454:5-7: Unneeded variable: "rc".
Return "0" on line 2499
Signed-off-by: Hariprasad Kelam
---
drivers/infiniband/hw/qedr/verbs.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/d
Change return type of rtw_suspend_ap_wow as its always return SUCCCESS.
Issue found with coccicheck
Signed-off-by: Hariprasad Kelam
---
drivers/staging/rtl8723bs/os_dep/os_intfs.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
Remove Unneeded variable ret . Return _FAIL .
We cannot change return type of on_action_spct as its callback function.
Issue identified with coccicheck.
Signed-off-by: Hariprasad Kelam
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions
This patch adds release of unlock in fail case.
Issue identified by coccicheck
Signed-off-by: Hariprasad Kelam
---
net/dsa/tag_sja1105.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/dsa/tag_sja1105.c b/net/dsa/tag_sja1105.c
index 1d96c9d..26363d7 100644
--- a/net/dsa/tag_sja1105.c
.c:804:5-12: Unneeded variable: "changed".
Return "1" on line 813
sound/pci/au88x0/au88x0_a3d.c:786:8-15: Unneeded variable: "changed".
Return "1" on line 796
Signed-off-by: Hariprasad Kelam
---
sound/pci/au88x0/au88x0_a3d.c | 15 +++
1 file change
fix below issue reported by coccicheck
sound/pci/emu10k1/emu10k1x.c:1077:5-11: Unneeded variable: "change".
Return "0" on line 1092
Signed-off-by: Hariprasad Kelam
---
sound/pci/emu10k1/emu10k1x.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/sound/pc
This patch fixes below issue reported by coccicheck
sound/pci/rme9652/rme9652.c:2161:5-11: Unneeded variable: "result".
Return "0" on line 2167
Signed-off-by: Hariprasad Kelam
---
sound/pci/rme9652/rme9652.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
di
Fix below issue reported by coccicheck
sound/soc/codecs/wcd9335.c:3991:25-30: WARNING: conversion to bool not
needed here
Signed-off-by: Hariprasad Kelam
---
sound/soc/codecs/wcd9335.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/sound/soc/codecs/wcd9335.c b/sound
fix below issue reported by coccicheck
drivers//rtc/rtc-wm831x.c:436:7-32: ERROR: Threaded IRQ with no primary
handler requested without IRQF_ONESHOT
Signed-off-by: Hariprasad Kelam
---
drivers/rtc/rtc-wm831x.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/rtc
fix below issue reported by coccicheck
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c:514:1-3:
WARNING: possible condition with no effect (if == else)
Signed-off-by: Hariprasad Kelam
---
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c | 8 +---
1 file changed, 1
On Thu, Jul 11, 2019 at 03:00:00PM -0700, Joe Perches wrote:
> On Thu, 2019-07-11 at 23:19 +0530, Hariprasad Kelam wrote:
> > Fix below issue reported by coccicheck
> > sound/soc/codecs/wcd9335.c:3991:25-30: WARNING: conversion to bool not
> > needed here
> >
> >
On Thu, Jul 11, 2019 at 03:00:00PM -0700, Joe Perches wrote:
> On Thu, 2019-07-11 at 23:19 +0530, Hariprasad Kelam wrote:
> > Fix below issue reported by coccicheck
> > sound/soc/codecs/wcd9335.c:3991:25-30: WARNING: conversion to bool not
> > needed here
> >
> >
As per TODO ,remove code valid only for 5 GHz(channel > 14).
Signed-off-by: Hariprasad Kelam
---
drivers/staging/rtl8723bs/hal/hal_com.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c
b/drivers/staging/rtl8723bs/hal/hal_co
As per TODO ,remove code valid only for 5 GHz(channel > 14).
Signed-off-by: Hariprasad Kelam
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
b/drivers/staging/rtl8723bs/c
As per TODO ,remove code valid only for 5 GHz(channel > 14).
Signed-off-by: Hariprasad Kelam
---
drivers/staging/rtl8723bs/os_dep/os_intfs.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
in
Function "rtw_sta_flush" always returns 0 value.
So change return type of rtw_sta_flush from int to void.
Same thing applies for rtw_hostapd_sta_flush
Signed-off-by: Hariprasad Kelam
--
Changes v2 -
change return type of rtw_sta_flush
-
drivers/staging/rtl8723bs/cor
Function "rtw_sta_flush" always returns 0 value.
So change return type of rtw_sta_flush from int to void.
Same thing applies for rtw_hostapd_sta_flush
Signed-off-by: Hariprasad Kelam
--
Changes v2 -
change return type of rtw_sta_flush
--
Changes v3 -
fix indent
and other situations where you
cannot sleep
And we can take advantage of GFP_KERNEL , as when system is in low
memory chances of getting success is high compared to GFP_ATOMIC.
As visornic_probe is in process context we can use GPF_KERNEL.
Signed-off-by: Hariprasad Kelam
---
drivers/staging/unisys
Function "rtw_sta_flush" always returns 0 value.
So change return type of rtw_sta_flush from int to void.
Same thing applies for rtw_hostapd_sta_flush
Signed-off-by: Hariprasad Kelam
--
Changes v2 -
change return type of rtw_sta_flush
--
Changes v3 -
fix indent
t;_SUCCESS" on line 494
Signed-off-by: Hariprasad Kelam
changes in v2:
change return type of init_mlme_ext_priv() from int to
void
We cant change return type of on_action_spct() it is a
call back function from action_handler.
fix below warning reported by checkpatch
CHECK: Comparison to NULL could be written
"!precvpriv->pallocated_frame_buf"
CHECK: Comparison to NULL could be written "padapter"
Signed-off-by: Hariprasad Kelam
-
changes in v2:
Corected few erorrs like (
t;_SUCCESS" on line 494
Signed-off-by: Hariprasad Kelam
changes in v2:
change return type of init_mlme_ext_priv() from int to
void
We cant change return type of on_action_spct() it is a
call back function from action_handler.
Function "rtw_sta_flush" always returns 0 value. So change
return type of rtw_sta_flush from int to void.
Same thing applies for rtw_hostapd_sta_flush
Signed-off-by: Hariprasad Kelam
--
Changes v2 -
change return type of rtw_sta_flush
Changes v3 -
fix indent
devm_request_pci_bus_resources function will return -EBUSY/-ENOMEM
in fail case and returns 0 on success.
So no need to store return value in err variable.
Signed-off-by: Hariprasad Kelam
---
drivers/staging/mt7621-pci/pci-mt7621.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions
fix below issue reported by coccicheck
/drivers/staging/media/hantro/hantro_vp8.c:149:16-34: WARNING:
dma_alloc_coherent use in aux_buf -> cpu already zeroes out memory, so
memset is not needed
Signed-off-by: Hariprasad Kelam
---
drivers/staging/media/hantro/hantro_vp8.c | 2 --
1 file chan
Both pu8 and pU1Tmp are of same data type u8. So replace pU1Tmp with u8.
Signed-off-by: Hariprasad Kelam
---
drivers/staging/rtl8723bs/hal/hal_btcoex.c | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/hal_btcoex.c
b/drivers
This function simply returns _regdom_rd . So replace this function
with actual code
Signed-off-by: Hariprasad Kelam
---
drivers/staging/rtl8723bs/os_dep/wifi_regd.c | 9 +
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/wifi_regd.c
b
Inthis file all functions has below common functionality
1.Check flag padapter->bSurpriseRemoved
2.Get sdio_func structure from intf_hdl.
This patch introduces two new APIs
rtw_isadapter_removed,rtw_sdio_get_func which helps to do above common
functionality.
Signed-off-by: Hariprasad Ke
Fix below warning reported by coccicheck
net/ipv6/exthdrs.c:180:9-29: WARNING: Comparison to bool
Signed-off-by: Hariprasad Kelam
---
net/ipv6/exthdrs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv6/exthdrs.c b/net/ipv6/exthdrs.c
index ab5add0..e137325 100644
Fix below warning reported by coccicheck
net/nfc/nci/ntf.c:367:5-15: WARNING: Comparison to bool
Signed-off-by: Hariprasad Kelam
---
net/nfc/nci/ntf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/nfc/nci/ntf.c b/net/nfc/nci/ntf.c
index 1e8c1a1..81e8570 100644
fix below warnings reported by coccicheck
net/key/af_key.c:932:2-5: WARNING: Use BUG_ON instead of if condition
followed by BUG.
net/key/af_key.c:948:2-5: WARNING: Use BUG_ON instead of if condition
followed by BUG.
Signed-off-by: Hariprasad Kelam
---
net/key/af_key.c | 6 ++
1 file
Remove unneeded variable ret in function sisusb_set_default_mode.
Change return type of sisusb_set_default_mode from int to void
as it never fails.
Issue identified by coccicheck
Signed-off-by: Hariprasad Kelam
-
changes in v2: Change return type of sisusb_set_default_mode from int to
void
nk line after declarations
WARNING: braces {} are not necessary for single statement blocks
CHECK: spaces preferred around that '/' (ctx:VxV)
CHECK: Using comparison to true is error prone
Signed-off-by: Hariprasad Kelam
---
drivers/staging/rtl8723bs/os_dep/xmit_linux.c | 21 ++---
1
CRO
HAL_BTC8723B2ANT_DMA_DURATION_ADJUST
Signed-off-by: Hariprasad Kelam
---
drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c | 746 ++--
1 file changed, 293 insertions(+), 453 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c
b/drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c
index cb62
In halbtc8723b2ant_TdmaDurationAdjust function,below piece of code is
repeated many times.
halbtc8723b2ant_PsTdma(pBtCoexist, NORMAL_EXEC, true, val);
pCoexDm->psTdmaDuAdjType = val;
So replace the same with "HAL_BTC8723B2ANT_DMA_DURATION_ADJUST" MACRO.
Signed-off-by: Har
This patch fixes below issue reported by checkpatch
CHECK: Comparison to NULL could be written "!pxmitbuf->pallocated_buf"
+ if (pxmitbuf->pallocated_buf == NULL)
Signed-off-by: Hariprasad Kelam
---
drivers/staging/rtl8723bs/os_dep/xmit_linux.c | 2 +-
1 file chan
this patch fixes below issue reported by checkpatch
CHECK: Using comparison to true is error prone
+ if (res == true)
Signed-off-by: Hariprasad Kelam
---
drivers/staging/rtl8723bs/os_dep/xmit_linux.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
mitframe_cnt > (NR_XMITFRAME/4)) {
^
Signed-off-by: Hariprasad Kelam
---
drivers/staging/rtl8723bs/os_dep/xmit_linux.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/xmit_lin
this patch fixes below issues reported by checkpatch
ERROR: spaces required around that '=' (ctx:WxV)
ERROR: spaces required around that '=' (ctx:WxV)
ERROR: spaces required around that '<' (ctx:VxV)
Signed-off-by: Hariprasad Kelam
---
drivers/staging/rtl8723bs/os_dep/osdep_service.c |
This patch fixes below issues reported by checkpatch
CHECK: Comparison to NULL could be written "rtw_proc"
CHECK: Comparison to NULL could be written "!rtw_proc"
CHECK: Comparison to NULL could be written "!rtw_proc"
Signed-off-by: Hariprasad Kelam
---
dr
CHECK: spaces preferred around that '|' (ctx:VxV)
CHECK: spaces preferred around that '|' (ctx:VxV)
CHECK: spaces preferred around that '+' (ctx:VxV)
Signed-off-by: Hariprasad Kelam
---
drivers/staging/rtl8723bs/os_dep/rtw_proc.c | 24
1 file changed, 12 insertions
This function simply returns _regdom_rd . So replace this function
with actual code
Signed-off-by: Hariprasad Kelam
---
v2 - Add patch number
drivers/staging/rtl8723bs/os_dep/wifi_regd.c | 9 +
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/staging/rtl8723bs
Inthis file all functions has below common functionality
1.Check flag padapter->bSurpriseRemoved
2.Get sdio_func structure from intf_hdl.
This patch introduces two new APIs
rtw_isadapter_removed,rtw_sdio_get_func which helps to do above common
functionality.
Signed-off-by: Hariprasad Ke
Remove passing pdid as function argument to rtw_sdio_if1_init as it is
not being used
Signed-off-by: Hariprasad Kelam
---
v3 - Add patch number
drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep
Remove function argument "padapter" in rtl8723bs_init_recv_priv function
as its not being used
Signed-off-by: Hariprasad Kelam
---
v4 - Add patch number
drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c | 4 ++--
drivers/staging/rtl8723bs/include/recv_osdep.h | 2 +-
drivers/staging
Remove below unused defines RTW_CH_MAX_2G_CHANNEL rtw_a_rates
RTW_A_RATES_NUM RTW_5G_CHANNELS_NUM
Signed-off-by: Hariprasad Kelam
---
v2 - Add patch number
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep
1 - 100 of 309 matches
Mail list logo
