[PATCH] mtd: cmdlinepart: fix the overflow of big mtd partitions

2012-11-01 Thread Huang Shijie
changes the size/offset to unsigned long long type, and replaces the UINT_MAX with ULLONG_MAX for macros SIZE_REMAINING and OFFSET_CONTINUOUS. Signed-off-by: Huang Shijie b32...@freescale.com --- drivers/mtd/cmdlinepart.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff

Re: [PATCH] mtd: gpmi: remove unneccessary header

2012-10-24 Thread Huang Shijie
ping. On Sun, Oct 14, 2012 at 1:03 AM, Huang Shijie shij...@gmail.com wrote: The whole gpmi-nand driver has turned to pure devicetree supported. So the linux/mtd/gpmi-nand.h is not neccessary now. Just remove it, and move some macros to the gpmi-nand driver itself. Signed-off-by: Huang

Re: [PATCH] mtd: use the NAND_STATUS_FAIL to replace the hardcode

2012-10-24 Thread Huang Shijie
ping On Mon, Oct 15, 2012 at 11:47 AM, Huang Shijie shij...@gmail.com wrote: Use the NAND_STATUS_FAIL to replace the hardcode 0x01, which make the code more readable. Signed-off-by: Huang Shijie shij...@gmail.com --- drivers/mtd/nand/nand_base.c |4 ++-- 1 files changed, 2 insertions

[PATCH] mtd: gpmi: remove unneccessary header

2012-10-12 Thread Huang Shijie
The whole gpmi-nand driver has turned to pure devicetree supported. So the linux/mtd/gpmi-nand.h is not neccessary now. Just remove it, and move some macros to the gpmi-nand driver itself. Signed-off-by: Huang Shijie shij...@gmail.com --- drivers/mtd/nand/gpmi-nand/gpmi-lib.c |1 - drivers

[PATCH] mtd: de-select the chip when it is not used

2012-11-09 Thread Huang Shijie
. To make the logic clear, we'd better de-select the chip when it is not used. This patch de-select the nand chip if it is not used any more. Signed-off-by: Huang Shijie b32...@freescale.com --- drivers/mtd/nand/nand_base.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff

Re: [PATCH] mtd: gpmi: remove unneccessary header

2012-11-09 Thread Huang Shijie
On Fri, Nov 9, 2012 at 10:10 AM, Artem Bityutskiy dedeki...@gmail.com wrote: On Sat, 2012-10-27 at 10:23 +0800, Huang Shijie wrote: 于 2012年10月26日 21:41, Artem Bityutskiy 写道: On Sat, 2012-10-13 at 13:03 -0400, Huang Shijie wrote: The whole gpmi-nand driver has turned to pure devicetree

[PATCH] mtd: use the NAND_STATUS_FAIL to replace the hardcode

2012-10-14 Thread Huang Shijie
Use the NAND_STATUS_FAIL to replace the hardcode 0x01, which make the code more readable. Signed-off-by: Huang Shijie shij...@gmail.com --- drivers/mtd/nand/nand_base.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand

[PATCH] dma: add new DMA control commands

2012-10-18 Thread Huang Shijie
From: Huang Shijie shij...@gmail.com [1] Why add these new DMA control commands? In mx6q, the gpmi-nand driver is the only user of the APBH-DMA. The dma clock is enabled when we have successfully requested a DMA channel. So even when the gpmi-nand driver does not work, the dma clock

Re: [PATCH] dma: add new DMA control commands

2012-10-18 Thread Huang Shijie
, the system has to enable the clock chain and it's parents ... But with this patch, we only need to enable/disable dma clock one time, just at we select the nand chip. thanks Huang Shijie -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH] dma: add new DMA control commands

2012-10-18 Thread Huang Shijie
于 2012年10月18日 15:14, Marek Vasut 写道: Dear Huang Shijie, Why such massive CC ? 于 2012年10月18日 14:18, Vinod Koul 写道: Why cant you do start (prepare clock etc) when you submit the descriptor to dmaengine. Can be done in tx_submit callback. Similarly remove the clock when dma transaction gets

Re: [PATCH] dma: add new DMA control commands

2012-10-18 Thread Huang Shijie
于 2012年10月18日 16:16, Marek Vasut 写道: So we can't stream data from the chip? About time to adjust the MTD framework to allow that. Maybe implement a command queue? to Artem David: is this possible to stream the data out with a command queue? thanks Huang Shijie -- To unsubscribe from

Re: [PATCH] dma: add new DMA control commands

2012-10-18 Thread Huang Shijie
in the middle, so we can not chain the all the read-pages DMA commands. thanks Huang Shijie -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

Re: [PATCH] dma: add new DMA control commands

2012-10-18 Thread Huang Shijie
于 2012年10月18日 16:52, Russell King - ARM Linux 写道: On Thu, Oct 18, 2012 at 02:45:41PM +0800, Huang Shijie wrote: 于 2012年10月18日 14:18, Vinod Koul 写道: Why cant you do start (prepare clock etc) when you submit the descriptor to dmaengine. Can be done in tx_submit callback. Similarly remove

Re: [PATCH] dma: add new DMA control commands

2012-10-18 Thread Huang Shijie
于 2012年10月18日 16:49, Marek Vasut 写道: Dear Huang Shijie, 于 2012年10月18日 16:16, Marek Vasut 写道: So we can't stream data from the chip? About time to adjust the MTD framework to allow that. Maybe implement a command queue? IMHO, it's not possible. Because the READ-PAGE(00h-30h) command needs

Re: [PATCH] dma: add new DMA control commands

2012-10-18 Thread Huang Shijie
On Thu, Oct 18, 2012 at 6:51 AM, Marek Vasut ma...@denx.de wrote: Dear Huang Shijie, 于 2012年10月18日 16:49, Marek Vasut 写道: Dear Huang Shijie, 于 2012年10月18日 16:16, Marek Vasut 写道: So we can't stream data from the chip? About time to adjust the MTD framework to allow that. Maybe

Re: [PATCH] dma: add new DMA control commands

2012-10-18 Thread Huang Shijie
On Thu, Oct 18, 2012 at 5:29 AM, Jassi Brar jaswinder.si...@linaro.org wrote: On 18 October 2012 12:15, Huang Shijie b32...@freescale.com wrote: 于 2012年10月18日 14:18, Vinod Koul 写道: Why cant you do start (prepare clock etc) when you submit the descriptor to dmaengine. Can be done in tx_submit

[PATCH v2 0/8] mtd: add datasheet's ECC information to nand_chip{}

2013-04-22 Thread Huang Shijie
] I re-test this patch set again. Huang Shijie (8): mtd: add data structures for Extended Parameter Page mtd: add a helper to get the supported features for ONFI nand mtd: get the ECC info from the Extended Parameter Page mtd: replace the hardcode with the onfi_get_feature() mtd: add a new

[PATCH v2 2/8] mtd: add a helper to get the supported features for ONFI nand

2013-04-22 Thread Huang Shijie
From: Huang Shijie shij...@gmail.com add a helper to get the supported features for ONFI nand. Also add the neccessary macros. Signed-off-by: Huang Shijie b32...@freescale.com --- include/linux/mtd/nand.h | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git

[PATCH v2 7/8] mtd: add the ecc info for some full-id nand chips

2013-04-22 Thread Huang Shijie
Add the ecc info for TC58NVG2S0F, TC58NVG3S0F, TC58NVG5D2 and TC58NVG6D2. From these chips' datasheets, we know that: The TC58NVG2S0F and TC58NVG3S0F require 4bit ECC for per 512byte. The TC58NVG5D2 and TC58NVG6D2 require 40bits ECC for per 1024byte. Signed-off-by: Huang Shijie b32

[PATCH v2 8/8] mtd: gpmi: set the BCH's geometry with the ecc info

2013-04-22 Thread Huang Shijie
info case. Signed-off-by: Huang Shijie b32...@freescale.com Signed-off-by: Huang Shijie shij...@gmail.com --- drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 128 +++- 1 files changed, 127 insertions(+), 1 deletions(-) diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b

[PATCH v2 4/8] mtd: replace the hardcode with the onfi_get_feature()

2013-04-22 Thread Huang Shijie
The current code uses the hardcode to detect the 16-bit bus width. Use the onfi_get_feature() to replace it. Signed-off-by: Huang Shijie b32...@freescale.com --- drivers/mtd/nand/nand_base.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/mtd/nand

[PATCH v2 5/8] mtd: add a new field for ecc info in the nand_flash_dev{}

2013-04-22 Thread Huang Shijie
Add the @ecc_info in the nand_flash_dev{}. The lower 16 bits are used to store the ECC bits, while the upper 16 bits are used to store the ECC data chunk size. Signed-off-by: Huang Shijie b32...@freescale.com --- include/linux/mtd/nand.h | 10 ++ 1 files changed, 10 insertions(+), 0

[PATCH v2 6/8] mtd: parse out the ECC info for the full-id nand chips

2013-04-22 Thread Huang Shijie
Parse out the ECC information for the full-id nand chips. Signed-off-by: Huang Shijie b32...@freescale.com --- drivers/mtd/nand/nand_base.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c index ba87e43..1611b7a

[PATCH v2 3/8] mtd: get the ECC info from the Extended Parameter Page

2013-04-22 Thread Huang Shijie
of the extended parameter page to retrieve the ECC requirements for this device. This patch implement the reading of the Extended Parameter Page, and parses the sections for ECC type, and get the ECC info from the ECC section. Tested this patch with Micron MT29F64G08CBABAWP. Signed-off-by: Huang Shijie b32

[PATCH v5 0/3] mtd: use the full-id as the keyword for some nand chips

2013-03-13 Thread Huang Shijie
-id nand in the nand_flash_lds. v2 -- v3: [1] remove the duplicated header. [2] remove the field ecc_len in nand_flash_dev{}. [3] fix some coding style warnings. [4] add more comments Huang Shijie (3): mtd: add a new field for nand_flash_dev{} mtd: add

[PATCH v5 1/3] mtd: add a new field for nand_flash_dev{}

2013-03-13 Thread Huang Shijie
for the nand_flash_dev{} to store the oob size for these nands. Signed-off-by: Huang Shijie b32...@freescale.com --- include/linux/mtd/nand.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h index e2c7173..42862e9 100644 --- a/include

[PATCH v5 3/3] mtd: add 4 Toshiba nand chips for the full-id case

2013-03-13 Thread Huang Shijie
to parse other non-full-id nand types, else it will continue to parse the non-full-id nands. Signed-off-by: Huang Shijie b32...@freescale.com --- drivers/mtd/nand/nand_ids.c | 22 ++ 1 files changed, 22 insertions(+), 0 deletions(-) diff --git a/drivers/mtd/nand/nand_ids.c b

[PATCH v5 2/3] mtd: add the support to parse out the full-id nand type

2013-03-13 Thread Huang Shijie
When we meet a full-id nand type which @mfr_id is true, we can use the find_full_id_nand() to parse out the neccessary information for a nand chip. If we meet a non full-id nand type, we can handle it in the lagacy way. Signed-off-by: Huang Shijie b32...@freescale.com --- drivers/mtd/nand

Re: [PATCH v5 3/3] mtd: add 4 Toshiba nand chips for the full-id case

2013-03-14 Thread Huang Shijie
for my poor english. Some incompatible NAND chips share device ID's and so must be listed by full ID. We list them first so that we can easily identify the most specific match. thanks. I will use this description. Huang Shijie -- To unsubscribe from this list: send the line unsubscribe linux

[PATCH v6 0/3] mtd: use the full-id as the keyword for some nand chips

2013-03-14 Thread Huang Shijie
] remove the field ecc_len in nand_flash_dev{}. [3] fix some coding style warnings. [4] add more comments Huang Shijie (3): mtd: add new fields to nand_flash_dev{} mtd: add the support to parse out the full-id nand type mtd: add 4 Toshiba nand chips for the full-id case

[PATCH v6 2/3] mtd: add the support to parse out the full-id nand type

2013-03-14 Thread Huang Shijie
When we meet a full-id nand type whose @id_len is not zero, we can use the find_full_id_nand() to parse out the necessary information for a nand chip. If we meet a non full-id nand type, we can handle it in the legacy way. Signed-off-by: Huang Shijie b32...@freescale.com --- drivers/mtd/nand

[PATCH v6 1/3] mtd: add new fields to nand_flash_dev{}

2013-03-14 Thread Huang Shijie
to the nand_flash_dev{}: @id_len: the valid length of the id data. See the comments in nand_id_has_period() @oobsize: the oob size. Signed-off-by: Huang Shijie b32...@freescale.com --- include/linux/mtd/nand.h |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/include

[PATCH v6 3/3] mtd: add 4 Toshiba nand chips for the full-id case

2013-03-14 Thread Huang Shijie
I have 4 Toshiba nand chips which can not be parsed out by the id data. We can not get the oob size from the id data. So add them as the full-id nand chips in the first of nand_flash_ids. The comment for the full-id items is from Brian. Signed-off-by: Huang Shijie b32...@freescale.com

Re: [PATCH V4 1/3] mtd: add new fields to nand_flash_dev{}

2013-03-13 Thread Huang Shijie
On Wed, Mar 13, 2013 at 6:54 PM, Artem Bityutskiy artem.bityuts...@linux.intel.com wrote: On Thu, 2013-03-07 at 18:49 +0800, Huang Shijie wrote: diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h index 591eeeb..f0a9d93 100644 --- a/include/linux/mtd/nand.h +++ b/include/linux

Re: [PATCH V3 1/3] mtd: add new fields to nand_flash_dev{}

2013-03-03 Thread Huang Shijie
于 2013年03月02日 22:19, Artem Bityutskiy 写道: On Mon, 2013-01-28 at 12:57 +0800, Huang Shijie wrote: As time goes on, we begin to meet the situation that we can not get enough information from some nand chips's id data. Take some Toshiba's nand chips for example. I have 4 Toshiba's nand chips in my

Re: [PATCH V3 1/3] mtd: add new fields to nand_flash_dev{}

2013-03-03 Thread Huang Shijie
于 2013年03月02日 22:21, Artem Bityutskiy 写道: On Sat, 2013-02-16 at 11:56 +0800, Huang Shijie wrote: On Tue, Feb 12, 2013 at 11:47 PM, Artem Bityutskiydedeki...@gmail.com wrote: On Mon, 2013-01-28 at 12:57 +0800, Huang Shijie wrote: + {SmartMedia 256MiB 3,3V, {0, 0x71}, 512, 256

Re: [PATCH V3 1/3] mtd: add new fields to nand_flash_dev{}

2013-03-04 Thread Huang Shijie
于 2013年03月04日 15:50, Artem Bityutskiy 写道: On Mon, 2013-03-04 at 13:57 +0800, Huang Shijie wrote: The current code uses the @id to store the device id(byte 1). But if we use the 8 bytes id data as the keyword, and expand the @id field to 8byte array, the device id is the second byte now. All

Re: [PATCH V3 1/3] mtd: add new fields to nand_flash_dev{}

2013-03-04 Thread Huang Shijie
于 2013年03月04日 16:24, Artem Bityutskiy 写道: On Mon, 2013-03-04 at 16:08 +0800, Huang Shijie wrote: 于 2013年03月04日 15:50, Artem Bityutskiy 写道: On Mon, 2013-03-04 at 13:57 +0800, Huang Shijie wrote: The current code uses the @id to store the device id(byte 1). But if we use the 8 bytes id data

Re: [PATCH V3 1/3] mtd: add new fields to nand_flash_dev{}

2013-03-04 Thread Huang Shijie
于 2013年03月04日 16:37, Artem Bityutskiy 写道: On Mon, 2013-03-04 at 16:08 +0800, Huang Shijie wrote: 于 2013年03月04日 15:50, Artem Bityutskiy 写道: On Mon, 2013-03-04 at 13:57 +0800, Huang Shijie wrote: The current code uses the @id to store the device id(byte 1). But if we use the 8 bytes id data

Re: [PATCH V3 1/3] mtd: add new fields to nand_flash_dev{}

2013-03-04 Thread Huang Shijie
Huang Shijie -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH V4 0/3] mtd: use the full-id as the keyword for some nand chips

2013-03-07 Thread Huang Shijie
{}. [3] fix some coding style warnings. [4] add more comments Huang Shijie (3): mtd: add new fields to nand_flash_dev{} mtd: add 4 Toshiba nand chips for the full-id case mtd: add the support to parse out the full-id nand type drivers/mtd/nand/nand_base.c | 36

[PATCH V4 1/3] mtd: add new fields to nand_flash_dev{}

2013-03-07 Thread Huang Shijie
to the nand_flash_dev{}: @id_len: the valid length of the id data. See the comments in nand_id_has_period() @oobsize: the oob size. Signed-off-by: Huang Shijie b32...@freescale.com --- include/linux/mtd/nand.h |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/include

[PATCH V4 2/3] mtd: add 4 Toshiba nand chips for the full-id case

2013-03-07 Thread Huang Shijie
I have 4 Toshiba nand chips which can not be parsed out by the id data. We can not get the oob size from the id data. So add them as the full-id nand chips in the first of nand_flash_ids. Signed-off-by: Huang Shijie b32...@freescale.com --- drivers/mtd/nand/nand_ids.c | 15 +++ 1

[PATCH V4 3/3] mtd: add the support to parse out the full-id nand type

2013-03-07 Thread Huang Shijie
When we meet a full-id nand type which @mfr_id is true, we can use the find_full_id_nand() to parse out the neccessary information for a nand chip. If we meet a non full-id nand type, we can handle it in the lagacy way. Signed-off-by: Huang Shijie b32...@freescale.com --- drivers/mtd/nand

Re: [PATCH v2 1/3] mtd: add new fields to nand_flash_dev{}

2013-02-04 Thread Huang Shijie
于 2013年02月04日 16:42, Artem Bityutskiy 写道: On Mon, 2013-01-28 at 10:06 +0800, Huang Shijie wrote: + unsigned int id_len; + unsigned long oobsize; + unsigned long ecc_len; I think it's better to submit another patch set to solve the ECC problem. Would you please strip the cited text

[PATCH 2/2] mtd: torturetest: add the support for random data pattern

2013-02-04 Thread Huang Shijie
Add a new module parameter 'pattern'. If it is set to zero, we will use the 55/AA pattern to torture the nand blocks; if it is set to a non-zero value, we will use the random data pattern. Signed-off-by: Huang Shijie b32...@freescale.com --- drivers/mtd/tests/mtd_torturetest.c | 72

[PATCH 1/2] mtd: torturetest: rewrite the erase-write-verify process into one block unit.

2013-02-04 Thread Huang Shijie
Rewrite the torture cycle, do the erase-write-verify process in one block unit, not in several blocks unit. This patch makes preparations for adding the rand data pattern support. Signed-off-by: Huang Shijie b32...@freescale.com --- drivers/mtd/tests/mtd_torturetest.c | 29

[PATCH] mm: introduce __linear_page_index()

2013-02-05 Thread Huang Shijie
There are many places we should get the offset(in PAGE_SIZE unit) of an address within a non-hugetlb vma. In order to simplify the code, add a new helper __linear_page_index() to do the work. Signed-off-by: Huang Shijie b32...@freescale.com --- This patch is based on linux-next tree. --- arch

Re: [PATCH 2/2] mtd: torturetest: add the support for random data pattern

2013-02-05 Thread Huang Shijie
于 2013年02月05日 16:05, Ricard Wanderlof 写道: On Tue, 5 Feb 2013, Huang Shijie wrote: Add a new module parameter 'pattern'. If it is set to zero, we will use the 55/AA pattern to torture the nand blocks; if it is set to a non-zero value, we will use the random data pattern. Not a big issue

Re: [PATCH v2] mtd: fix the wrong timeo for panic_nand_wait()

2013-01-29 Thread Huang Shijie
于 2013年01月30日 05:00, Florian Fainelli 写道: Hello Huang, Le mardi 22 janvier 2013 02:30:30, Huang Shijie a écrit : In nand_wait(), the timeo for panic_nand_wait() is assigned with wrong value(jiffies + some delay). The timeo should be set like the panic_nand_write() does. This patch fixes

[PATCH v3] mtd: fix the wrong timeo for panic_nand_wait()

2013-01-29 Thread Huang Shijie
also passes timeo in jiffies(converted by msecs_to_jiffies) to time_before() which makes the code more readable. Signed-off-by: Huang Shijie b32...@freescale.com --- v1 -- v2: fixed a compiler error. v2 -- v3: add more comments. --- drivers/mtd/nand/nand_base.c |8 ++-- 1

Re: [PATCH V3 1/3] mtd: add new fields to nand_flash_dev{}

2013-02-28 Thread Huang Shijie
于 2013年02月12日 23:47, Artem Bityutskiy 写道: On Mon, 2013-01-28 at 12:57 +0800, Huang Shijie wrote: + {SmartMedia 256MiB 3,3V, {0, 0x71}, 512, 256, 0x4000 }, + {SmartMedia 256MiB 3,3V ROM, {0, 0x5b}, 512, 256, 0x4000, NAND_ROM}, Sorry for a possibly stupid question, but what

Re: [PATCH v2 2/3] mtd: add a new table for the unparsable nand chips

2013-01-27 Thread Huang Shijie
于 2013年01月24日 14:11, Huang Shijie 写道: We have 4 Toshiba nand chips which can not be parsed out by the id data. Add a new table for the unparsable nand chips. It makes mess if we add these entries to the nand_flash_ids table. The entries in the nand_flash_ids stands for a class of nand chips

Re: [PATCH v2 1/3] mtd: add new fields to nand_flash_dev{}

2013-01-27 Thread Huang Shijie
于 2013年01月24日 14:11, Huang Shijie 写道: As time goes on, we begin to meet the situation that we can not get enough information from some nand chips's id data. Take some Toshiba's nand chips for example. I have 4 Toshiba's nand chips in my hand: TC58NVG2S0F, TC58NVG3S0F, TC58NVG5D2

[PATCH V3 0/3] mtd: use the full-id as the keyword

2013-01-27 Thread Huang Shijie
From: Huang Shijie b32...@freescale.com I ever submitted a patch to use the full-id as the keyword for some unparsable nand chips. This is the second tries. As time goes on, we begin to meet the situation that we can not get enough information from some nand chips's id data. Take some Toshiba's

[PATCH V3 2/3] mtd: add a new table for the unparsable nand chips

2013-01-27 Thread Huang Shijie
some singular chips. Signed-off-by: Huang Shijie b32...@freescale.com --- drivers/mtd/nand/nand_ids.c | 21 + include/linux/mtd/nand.h|1 + 2 files changed, 22 insertions(+), 0 deletions(-) diff --git a/drivers/mtd/nand/nand_ids.c b/drivers/mtd/nand/nand_ids.c index

[PATCH V3 3/3] mtd: add the new detection method for the unparsable nand chips

2013-01-27 Thread Huang Shijie
Add the new detection method find_nand_type_by_fullid() for the unparsable nand chips. The new detection method is called firstly before all the other detection methods. Signed-off-by: Huang Shijie b32...@freescale.com --- drivers/mtd/nand/nand_base.c | 33 - 1

[PATCH V3 1/3] mtd: add new fields to nand_flash_dev{}

2013-01-27 Thread Huang Shijie
to the nand_flash_dev{}, and update the detection mechanisms. This patch just adds some new fields to the nand_flash_dev{}: @id[8] : the 8 bytes id data. @id_len: the valid length of the id data. @oobsize: the oob size. Signed-off-by: Huang Shijie b32...@freescale.com --- drivers/mtd/devices

[PATCH] mtd: fix the wrong timeo for panic_nand_wait()

2013-01-21 Thread Huang Shijie
In nand_wait(), the timeo for panic_nand_wait() is assigned with wrong value(jiffies + some delay). This patch fixes it, and also uses the msecs_to_jiffies() to make the code more readable. Signed-off-by: Huang Shijie shij...@gmail.com --- drivers/mtd/nand/nand_base.c |8 ++-- 1 files

Re: [PATCH] mtd: fix the wrong timeo for panic_nand_wait()

2013-01-21 Thread Huang Shijie
in panic_nand_write(). thanks Huang Shijie Huang Shijie a écrit : In nand_wait(), the timeo for panic_nand_wait() is assigned with wrong value(jiffies + some delay). This patch fixes it, and also uses the msecs_to_jiffies() to make the code more readable. Signed-off-by: Huang Shijie shij

[PATCH v2] mtd: fix the wrong timeo for panic_nand_wait()

2013-01-21 Thread Huang Shijie
In nand_wait(), the timeo for panic_nand_wait() is assigned with wrong value(jiffies + some delay). The timeo should be set like the panic_nand_write() does. This patch fixes it, and also uses the msecs_to_jiffies() to make the code more readable. Signed-off-by: Huang Shijie b32...@freescale.com

[PATCH v2 0/3] mtd: use the full-id as the keyword.

2013-01-23 Thread Huang Shijie
But we can not parse out the correct oob size for these chips from the id data. So it is time to add some new fields to the nand_flash_dev{}, and update the detection mechanisms. Huang Shijie (3): mtd: add new fields to nand_flash_dev{} mtd: add a new table for the unparsable nand chips mtd: add

[PATCH v2 1/3] mtd: add new fields to nand_flash_dev{}

2013-01-23 Thread Huang Shijie
to the nand_flash_dev{}, and update the detection mechanisms. This patch just adds some new fields to the nand_flash_dev{}. Signed-off-by: Huang Shijie b32...@freescale.com --- drivers/mtd/devices/doc2000.c |2 +- drivers/mtd/devices/doc2001.c |2 +- drivers/mtd/devices/doc2001plus.c

[PATCH v2 2/3] mtd: add a new table for the unparsable nand chips

2013-01-23 Thread Huang Shijie
some singular chips. Signed-off-by: Huang Shijie b32...@freescale.com --- drivers/mtd/nand/nand_ids.c | 22 ++ include/linux/mtd/nand.h|1 + 2 files changed, 23 insertions(+), 0 deletions(-) diff --git a/drivers/mtd/nand/nand_ids.c b/drivers/mtd/nand/nand_ids.c index

[PATCH v2 3/3] mtd: add the new detection method for the unparsable nand chips

2013-01-23 Thread Huang Shijie
Add the new detection method find_nand_type_by_fullid() for the unparsable nand chips. The new detection method is called firstly before all the other detection methods. Signed-off-by: Huang Shijie b32...@freescale.com --- drivers/mtd/nand/nand_base.c | 33 - 1

Re: [PATCH V3 1/3] mtd: add new fields to nand_flash_dev{}

2013-02-15 Thread Huang Shijie
On Tue, Feb 12, 2013 at 11:47 PM, Artem Bityutskiy dedeki...@gmail.com wrote: On Mon, 2013-01-28 at 12:57 +0800, Huang Shijie wrote: + {SmartMedia 256MiB 3,3V, {0, 0x71}, 512, 256, 0x4000 }, + {SmartMedia 256MiB 3,3V ROM, {0, 0x5b}, 512, 256, 0x4000, NAND_ROM}, Sorry

Re: [PATCH] mm: introduce __linear_page_index()

2013-02-16 Thread Huang Shijie
you agree? thanks Huang Shijie -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH 1/2] serial: mxs-auart: fix the wrong setting order

2012-09-06 Thread Huang Shijie
+ AUART_INTR_CLR); To fix this issue, the patch moves this gate-off line to the end of setting registers. Signed-off-by: Huang Shijie shij...@gmail.com --- drivers/tty/serial/mxs-auart.c |4 ++-- 1 files changed, 2

[PATCH 2/2] serial: mxs-auart: put the device in mxs_auart_probe()

2012-09-06 Thread Huang Shijie
We call the get_device() in the mxs_auart_probe(). For the balance of the reference count, we should put the device in the mxs_auart_remove(). Signed-off-by: Huang Shijie shij...@gmail.com --- drivers/tty/serial/mxs-auart.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git

Re: [PATCH 1/2] serial: mxs-auart: fix the wrong setting order

2012-09-06 Thread Huang Shijie
于 2012年09月07日 10:38, Shawn Guo 写道: On Thu, Sep 06, 2012 at 10:38:40PM -0400, Huang Shijie wrote: After set the AUART_CTRL0_CLKGATE, the UART will gate all the clocks off. So the following line will not take effect

Re: [PATCH 2/2] serial: mxs-auart: put the device in mxs_auart_probe()

2012-09-06 Thread Huang Shijie
于 2012年09月07日 10:43, Shawn Guo 写道: On Thu, Sep 06, 2012 at 10:38:41PM -0400, Huang Shijie wrote: We call the get_device() in the mxs_auart_probe(). For the balance of the reference count, we should put the device in the mxs_auart_remove(). Signed-off-by: Huang Shijieshij...@gmail.com

[PATCH] serial: mxs-auart: put the device when exit or error

2012-09-06 Thread Huang Shijie
We call the get_device() in the mxs_auart_probe(). For the balance of the reference count, we should put the device in the mxs_auart_remove() or in the error path of probe. Signed-off-by: Huang Shijie b32...@freescale.com --- drivers/tty/serial/mxs-auart.c |2 ++ 1 files changed, 2

[PATCH 2/2] mtd: add helpers to get the supportted ONFI timing mode

2012-09-10 Thread Huang Shijie
add onfi_get_async_timing_mode() to get the supportted asynchronous timing mode. add onfi_get_sync_timing_mode() to get the supportted synchronous timing mode. Also add the neccessary macros : the timing modes. Signed-off-by: Huang Shijie b32...@freescale.com --- include/linux/mtd/nand.h

[PATCH 1/2] mtd: add helpers to set/get features for ONFI nand

2012-09-10 Thread Huang Shijie
Add the set-features(0xef)/get-features(0xee) helpers for ONFI nand. Also add the necessary macros. Signed-off-by: Huang Shijie b32...@freescale.com --- drivers/mtd/nand/nand_base.c | 50 ++ include/linux/mtd/nand.h | 14 +++ 2 files

Re: [PATCH] tlg2300: Declare MODULE_FIRMWARE usage

2012-07-25 Thread Huang Shijie
thanks. Acked-by: Huang Shijie shij...@gmail.com On Thu, Jul 26, 2012 at 3:41 AM, Tim Gardner tim.gard...@canonical.com wrote: Cc: Huang Shijie shij...@gmail.com Cc: Kang Yong kangy...@telegent.com Cc: Zhang Xiaobing xbzh...@telegent.com Cc: Mauro Carvalho Chehab mche...@infradead.org Cc

Re: [PATCH v2] mtd: cmdlinepart: fix the wrong partitions number when truncating occurs

2012-08-29 Thread Huang Shijie
于 2012年08月29日 16:24, Artem Bityutskiy 写道: While appreciating Shmulik's attention to details, I vote this way: On Sun, 2012-08-26 at 02:47 -0400, Huang Shijie wrote: Could Artem or David point us a direction about this? [1] Should the unsorted partitions be supported? No, it is asking

Re: [PATCH 3/3] mtd: cmdlinepart: fix the wrong partitions number when truncating occurs

2012-08-30 Thread Huang Shijie
On Thu, Aug 30, 2012 at 2:43 PM, Artem Bityutskiy dedeki...@gmail.com wrote: On Sun, 2012-08-26 at 13:21 -0400, Huang Shijie wrote: This patch is based on the assumption that all the partitions are in the right offset order. Assume we have a 1GB(8Gb) nand chip, and we set the partitions

Re: [PATCH 1/3] mtd: cmdlinepart: make the partitions rule more strict

2012-08-31 Thread Huang Shijie
On Fri, Aug 31, 2012 at 7:45 AM, Artem Bityutskiy dedeki...@gmail.com wrote: On Sun, 2012-08-26 at 13:21 -0400, Huang Shijie wrote: There are typically two types to set the mtd partitions: 1 set with the `size`, such as gpmi-nand:100m(boot),100m(kernel),1g(rootfs) 2 set with the `offset

Re: [PATCH 2/3] mtd: cmdlinepart: sort the unsorted partitions

2012-08-31 Thread Huang Shijie
On Fri, Aug 31, 2012 at 9:59 AM, Artem Bityutskiy dedeki...@gmail.com wrote: On Sun, 2012-08-26 at 13:21 -0400, Huang Shijie wrote: Assume we have a 1GB(8Gb) nand chip. It is legit if we set the partitions as the following: gpmi-nand:1g@200m(rootfs),100m@0(boot),100m@100m(kernel

Re: [PATCH 1/3] mtd: cmdlinepart: make the partitions rule more strict

2012-08-31 Thread Huang Shijie
On Fri, Aug 31, 2012 at 7:45 AM, Artem Bityutskiy dedeki...@gmail.com wrote: On Sun, 2012-08-26 at 13:21 -0400, Huang Shijie wrote: There are typically two types to set the mtd partitions: 1 set with the `size`, such as gpmi-nand:100m(boot),100m(kernel),1g(rootfs) 2 set with the `offset

Re: [PATCH 1/3] mtd: cmdlinepart: make the partitions rule more strict

2012-09-03 Thread Huang Shijie
On Mon, Sep 3, 2012 at 3:18 AM, Artem Bityutskiy dedeki...@gmail.com wrote: On Sun, 2012-08-26 at 13:21 -0400, Huang Shijie wrote: + * + * Note: + * If you choose to set the @offset for the partdef, please set all + * the partitions with the same syntax, such as: + * gpmi-nand:100m@0

[PATCH] mtd: kill MTD_NAND_VERIFY_WRITE

2012-08-14 Thread Huang Shijie
MTD_NAND_VERIFY_WRITE entirely. Signed-off-by: Huang Shijie shij...@gmail.com --- drivers/mtd/nand/Kconfig |9 - drivers/mtd/nand/ams-delta.c | 13 drivers/mtd/nand/au1550nd.c | 46 --- drivers/mtd/nand/bcm_umi_nand.c | 22 - drivers/mtd

Re: [PATCH] mtd: kill MTD_NAND_VERIFY_WRITE

2012-08-15 Thread Huang Shijie
patch that removes CONFIG_MTD_NAND_VERIFY_WRITE from all defconfig files. thanks a lot. I will send out a separate patch to fix it. Huang Shijie (also, trimmed the CC list for this specific discussion, seems unrelated to all of the parties) Regards, Shmulik

[PATCH] kconfig: remove CONFIG_MTD_NAND_VERIFY_WRITE

2012-08-15 Thread Huang Shijie
MTD_NAND_VERIFY_WRITE entirely. Please see the patch: http://lists.infradead.org/pipermail/linux-mtd/2012-August/043189.html This patch removes the CONFIG_MTD_NAND_VERIFY_WRITE in the defconfigs. Signed-off-by: Huang Shijie b32...@freescale.com --- arch/arm/configs/bcmring_defconfig |1 - arch

Re: [PATCH] mtd: kill MTD_NAND_VERIFY_WRITE

2012-08-16 Thread Huang Shijie
于 2012年08月15日 20:09, Marek Vasut 写道: I'd still prefer for this to be rather fixed. It seems to be able to find some obvious mistakes etc. could you please point out the mistakes? thanks Huang Shijie -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

[PATCH] serial: mxs-auart: fix the wrong RTS hardware flow control

2012-08-07 Thread Huang Shijie
(DCE). This patch also replaces the AUART_CTRL2_RTS with AUART_CTRL2_RTSEN. We should use the real the hardware flow control, not the software-controled hardware flow control. Signed-off-by: Huang Shijie b32...@freescale.com --- drivers/tty/serial/mxs-auart.c | 14 +- 1 files changed

[PATCH V2] serial: mxs-auart: fix the wrong RTS hardware flow control

2012-08-07 Thread Huang Shijie
(DCE). This patch also replaces the AUART_CTRL2_RTS with AUART_CTRL2_RTSEN. We should use the real the hardware flow control, not the software-controled hardware flow control. Signed-off-by: Huang Shijie b32...@freescale.com --- v1 -- v2: The ASYNC_CTS_FLOW is set in the `flags` field

Re: [PATCH] tty: move the async flags from the serial code into the tty includes

2012-08-21 Thread Huang Shijie
change my patch based on it. thanks Huang Shijie -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH v3] serial: add a new helper function

2012-08-22 Thread Huang Shijie
In most of the time, the driver needs to check if the cts flow control is enabled. But now, the driver checks the ASYNC_CTS_FLOW flag manually, which is not a grace way. So add a new wraper function to make the code tidy and clean. Signed-off-by: Huang Shijie shij...@gmail.com --- v2 -- v3

[PATCH v2] mtd: cmdlinepart: fix the wrong partitions number when truncating occurs

2012-08-24 Thread Huang Shijie
mtd0: 0640 0004 boot mtd1: 0640 0004 kernel mtd2: 3380 0004 rootfs -- We get the right result. Signed-off-by: Huang Shijie shij...@gmail.com --- v1 -- v2: [1] add more commit info. --- drivers/mtd/cmdlinepart.c

[PATCH v2] mtd: cmdlinepart: fix the wrong check condition

2012-08-25 Thread Huang Shijie
parses out several mtd partitions right now. This is obviously wrong. We even do not enable the gpmi-nand in this case. The patch comes from Artem's suggestion code which is better then mine. Signed-off-by: Huang Shijie shij...@gmail.com --- drivers/mtd/cmdlinepart.c |5 - 1 files

Re: [PATCH v2] mtd: cmdlinepart: fix the wrong partitions number when truncating occurs

2012-08-25 Thread Huang Shijie
On Sat, Aug 25, 2012 at 5:02 AM, Shmulik Ladkani shmulik.ladk...@gmail.com wrote: Hi Huang, On Sat, 25 Aug 2012 10:26:07 -0400 Huang Shijie shij...@gmail.com wrote: diff --git a/drivers/mtd/cmdlinepart.c b/drivers/mtd/cmdlinepart.c index 4558e0f..fc960a3 100644 --- a/drivers/mtd

Re: [PATCH v2] mtd: cmdlinepart: fix the wrong partitions number when truncating occurs

2012-08-25 Thread Huang Shijie
On Sat, Aug 25, 2012 at 5:42 AM, Shmulik Ladkani shmulik.ladk...@gmail.com wrote: On Sat, 25 Aug 2012 05:26:51 -0400 Huang Shijie shij...@gmail.com wrote: The specified cmdline partitions might not be ordered (according to start offset), so next partition specified after the truncated one

[PATCH 1/3] mtd: cmdlinepart: make the partitions rule more strict

2012-08-25 Thread Huang Shijie
-by: Huang Shijie shij...@gmail.com --- drivers/mtd/cmdlinepart.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/drivers/mtd/cmdlinepart.c b/drivers/mtd/cmdlinepart.c index fe7e3a5..0b7b2ad 100644 --- a/drivers/mtd/cmdlinepart.c +++ b/drivers/mtd/cmdlinepart.c

[PATCH 3/3] mtd: cmdlinepart: fix the wrong partitions number when truncating occurs

2012-08-25 Thread Huang Shijie
: -- root@freescale ~$ cat /proc/mtd dev:size erasesize name mtd0: 0640 0004 boot mtd1: 0640 0004 kernel mtd2: 3380 0004 rootfs -- We get the right result. Signed-off-by: Huang Shijie

[PATCH 2/3] mtd: cmdlinepart: sort the unsorted partitions

2012-08-25 Thread Huang Shijie
. For there are maybe only several partitions, i use the simple Bubble sort algorithm. Signed-off-by: Huang Shijie shij...@gmail.com --- drivers/mtd/cmdlinepart.c | 29 + 1 files changed, 29 insertions(+), 0 deletions(-) diff --git a/drivers/mtd/cmdlinepart.c b/drivers/mtd

Re: [PATCH v2] mtd: cmdlinepart: fix the wrong partitions number when truncating occurs

2012-08-26 Thread Huang Shijie
On Sun, Aug 26, 2012 at 2:06 AM, Shmulik Ladkani shmulik.ladk...@gmail.com wrote: Hi, On Sat, 25 Aug 2012 05:26:51 -0400 Huang Shijie shij...@gmail.com wrote: On Sat, Aug 25, 2012 at 5:02 AM, Shmulik Ladkani shmulik.ladk...@gmail.com wrote: Your analysis seems right, but let me offer

Re: [PATCH v2] mtd: cmdlinepart: fix the wrong check condition

2012-08-26 Thread Huang Shijie
On Sat, Aug 25, 2012 at 5:31 AM, Shmulik Ladkani shmulik.ladk...@gmail.com wrote: Hi Huang, Artem, On Sat, 25 Aug 2012 16:06:50 -0400 Huang Shijie shij...@gmail.com wrote: diff --git a/drivers/mtd/cmdlinepart.c b/drivers/mtd/cmdlinepart.c index fc960a3..216d751 100644 --- a/drivers/mtd

[PATCH] serial: add a new helper function

2012-08-19 Thread Huang Shijie
In most of the time, the driver needs to check if the cts flow control is enabled. But now, the driver checks the ASYNC_CTS_FLOW flag manually, which is not a grace way. So add a new wraper function to make the code tidy and clean. Signed-off-by: Huang Shijie shij...@gmail.com --- drivers/char

Re: [PATCH] serial: add a new helper function

2012-08-19 Thread Huang Shijie
On Sun, Aug 19, 2012 at 2:44 AM, Greg KH gre...@linuxfoundation.org wrote: On Sun, Aug 19, 2012 at 02:27:12PM -0400, Huang Shijie wrote: --- a/include/linux/tty.h +++ b/include/linux/tty.h @@ -43,6 +43,7 @@ #include linux/tty_driver.h #include linux/tty_ldisc.h #include linux/mutex.h

  1   2   3   4   5   6   7   8   9   >