Re:Re: [PATCH V3] watchdog: mtk: support pre-timeout when the bark irq is available

2021-04-15 Thread
>On 4/14/21 4:48 AM, Wang Qing wrote: >> Use the bark interrupt as the pretimeout notifier if available. >> >> By default, the pretimeout notification shall occur one second earlier >> than the timeout. >> >> V2: >> - panic() by default if WATCHDOG_PRETIMEOUT_GOV is not enabled. >> >> V3: >> -

Re:Re: [PATCH] watchdog: mtk: support pre-timeout when the bark irq is available

2021-04-10 Thread
>On 4/9/21 8:11 PM, 王擎 wrote: >> >>> On 4/9/21 7:42 PM, 王擎 wrote: >>>> >>>>> On 4/9/21 2:55 AM, Wang Qing wrote: >>>>>> Use the bark interrupt as the pretimeout notifier if available. >>>>>> >>>>>

Re:Re: [PATCH] watchdog: mtk: support pre-timeout when the bark irq is available

2021-04-09 Thread
>On 4/9/21 7:42 PM, 王擎 wrote: >> >>> On 4/9/21 2:55 AM, Wang Qing wrote: >>>> Use the bark interrupt as the pretimeout notifier if available. >>>> >>>> By default, the pretimeout notification shall occur one second earlier >

Re:Re: [PATCH] softdog: make pretimeout available when SOFT_WATCHDOG_PRETIMEOUT enabled

2021-04-09 Thread
>On 4/6/21 2:44 AM, Wang Qing wrote: >> Although softdog supports pretimeout, there is no way to set pretimeout, >> so pretimeout will never be processed in softdog_ping(). >> >This is wrong. The pretimeout can be set using WDIOC_SETPRETIMEOUT, as with >every other driver supporting it. There

Re:Re: [PATCH] watchdog: mtk: support pre-timeout when the bark irq is available

2021-04-09 Thread
>On 4/9/21 2:55 AM, Wang Qing wrote: >> Use the bark interrupt as the pretimeout notifier if available. >> >> By default, the pretimeout notification shall occur one second earlier >> than the timeout. >> >> Signed-off-by: Wang Qing >> --- >> drivers/watchdog/mtk_wdt.c | 47 >>

Re:[PATCH V3,RESEND] workqueue/watchdog: Make unbound workqueues aware of touch_softlockup_watchdog()

2021-03-26 Thread
>V3: >- Modify the commit message clearly according to Petr's suggestion. > >Signed-off-by: Wang Qing >--- > kernel/watchdog.c | 5 +++-- > kernel/workqueue.c | 17 ++--- > 2 files changed, 9 insertions(+), 13 deletions(-) > >diff --git a/kernel/watchdog.c b/kernel/watchdog.c >index

Re:Re: Re: Re: [PATCH V2] workqueue: watchdog: update wq_watchdog_touched for unbound lockup checking

2021-03-24 Thread
>On Wed 2021-03-24 10:16:46, 王擎 wrote: >> >> >On Tue 2021-03-23 20:37:35, 王擎 wrote: >> >> >> >> >On Fri 2021-03-19 16:00:36, Wang Qing wrote: >> >> >> When touch_softlockup_watchdog() is called, only >> >> >>

Re:Re: Re: [PATCH V2] workqueue: watchdog: update wq_watchdog_touched for unbound lockup checking

2021-03-23 Thread
>On Tue 2021-03-23 20:37:35, 王擎 wrote: >> >> >On Fri 2021-03-19 16:00:36, Wang Qing wrote: >> >> When touch_softlockup_watchdog() is called, only wq_watchdog_touched_cpu >> >> updated, while the unbound worker_pool running on its core uses >> &g

Re:Re: [PATCH V2] workqueue: watchdog: update wq_watchdog_touched for unbound lockup checking

2021-03-23 Thread
>On Fri 2021-03-19 16:00:36, Wang Qing wrote: >> When touch_softlockup_watchdog() is called, only wq_watchdog_touched_cpu >> updated, while the unbound worker_pool running on its core uses >> wq_watchdog_touched to determine whether locked up. This may be mischecked. > >By other words, unbound

Re:Re: [PATCH V2] workqueue: watchdog: update wq_watchdog_touched for unbound lockup checking

2021-03-21 Thread
>On Fri, Mar 19, 2021 at 04:00:36PM +0800, Wang Qing wrote: >> When touch_softlockup_watchdog() is called, only wq_watchdog_touched_cpu >> updated, while the unbound worker_pool running on its core uses >> wq_watchdog_touched to determine whether locked up. This may be mischecked. > >Can you

Re:Re: [PATCH] futex: use wake_up_process() instead of wake_up_state()

2021-03-19 Thread
>> On Fri, 2021-03-19 at 10:59 +0800, Wang Qing wrote: >> > Using wake_up_process() is more simpler and friendly, >> > and it is more convenient for analysis and statistics >> >> I likely needn't bother, and don't have a NAK to paste on this thing, >> but here's another copy of my NOPE for yet

Re:Re: [PATCH] dma-buf: use wake_up_process() instead of wake_up_state()

2021-03-19 Thread
>> Using wake_up_process() is more simpler and friendly, >> and it is more convenient for analysis and statistics >> >> Signed-off-by: Wang Qing > >Reviewed-by: Christian König > >Should I pick it up or do you want to push it through some other tree >than DRM? Pick it up just fine, thanks,

Re:Re: [PATCH] sched: swait: use wake_up_process() instead of wake_up_state()

2021-03-17 Thread
>> >> * Mike Galbraith wrote: >> >> > On Tue, 2021-03-16 at 19:20 +0800, Wang Qing wrote: >> > > Why not just use wake_up_process(). >> > >> > IMO this is not an improvement. There are other places where explicit >> > TASK_NORMAL is used as well, and they're all perfectly clear as is. >> >>

Re:Re: [PATCH] arc: kernel: Return -EFAULT if copy_to_user() fails

2021-03-09 Thread
Subject: Re: [PATCH] arc: kernel: Return -EFAULT if copy_to_user() fails>On 3/1/21 4:05 AM, Wang Qing wrote: >> The copy_to_user() function returns the number of bytes remaining to be >> copied, but we want to return -EFAULT if the copy doesn't complete. >> >> Signed-off-by: Wang Qing >

Re:Re: [PATCH V4 net-bugfixs] net/ethernet: Update ret when ptp_clock is ERROR

2020-11-11 Thread
>On Thu, 12 Nov 2020 09:15:05 +0800 (GMT+08:00) 王擎 wrote: >> >Grygorii, would you mind sending a correct patch in so Wang Qing can >> >see how it's done? I've been asking for a fixes tag multiple times >> >already :( >> >> I still don't quite understa

Re:Re: [PATCH V4 net-bugfixs] net/ethernet: Update ret when ptp_clock is ERROR

2020-11-11 Thread
>> On Wed, Nov 11, 2020 at 03:24:33PM +0200, Grygorii Strashko wrote: >> > >> > Following Richard's comments v1 of the patch has to be applied [1]. >> > I've also added my Reviewed-by there. >> > >> > [1] https://lore.kernel.org/patchwork/patch/1334067/ >> >> +1 >> >> Jakub, can you please

Re:Re: [PATCH] sched/rt, powerpc: Prepare for PREEMPT_RT

2020-11-09 Thread
>Quoting Wang Qing : > >> Add PREEMPT_RT output to die(). >> >> Signed-off-by: Wang Qing >> --- >> arch/powerpc/kernel/traps.c | 10 +- >> 1 file changed, 9 insertions(+), 1 deletion(-) >> >> diff --git a/arch/powerpc/kernel/traps.c b/arch/powerpc/kernel/traps.c >> index 5006dcb..6dfe567

Re:Re: [PATCH] usb: Assign NULL ​​to phy that may be returned

2020-11-05 Thread
>> Assign initial values to local variables that may be returned >> >> Signed-off-by: Wang Qing > >Your subject, and body of text, seem to have 2 "odd" characters in it, >please fix up. > >Also, your subject and changelog body here are identical, please be much >more verbose in the body

Re:Re: [PATCH V4] doc: zh_CN: add translatation for btrfs

2020-09-27 Thread
;> @@ -0,0 +1,37 @@ >>> +.. SPDX-License-Identifier: GPL-2.0 >>> + >>> +.. include:: ../disclaimer-zh_CN.rst >>> + >>> +:Original: :ref:`Documentation/filesystems/ext3.rst ` >>> + >>> +translated by 王擎 Wang Qing >>> + >>&g

Re:Re: [PATCH] drivers\block: Use kobj_to_dev() API

2020-06-15 Thread
Subject: Re: [PATCH] drivers\block: Use kobj_to_dev() API>On Fri, Jun 12, 2020 at 03:10:56PM +0800, Wang Qing wrote: >> Use kobj_to_dev() API instead of container_of(). >> >> Signed-off-by: Wang Qing >> --- >> drivers/block/virtio_blk.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-)