Re: [REGRESSION][v6.8-rc1] virtio-pci: Introduce admin virtqueue

2024-05-16 Thread Jason Wang
el: random: crng reseeded on system resumption >> > May 08 11:08:42 kernel-test-202405080702.c.ubuntu-catred.internal >> > kernel: PM: suspend exit >> > May 08 11:08:42 kernel-test-202405080702.c.ubuntu-catred.internal >> > kernel: PM: suspend entry (s2idle) >> > -- Boot 6182

Re: [PATCH] vhost/vsock: always initialize seqpacket_allow

2024-05-15 Thread Jason Wang
S. Miller > Cc: Stefan Hajnoczi > Signed-off-by: Michael S. Tsirkin > Acked-by: Arseniy Krasnov > Tested-by: Arseniy Krasnov > Acked-by: Jason Wang Thanks

Re: [REGRESSION][v6.8-rc1] virtio-pci: Introduce admin virtqueue

2024-05-07 Thread Jason Wang
On Sat, May 4, 2024 at 2:10 AM Joseph Salisbury wrote: > > Hi Feng, > > During testing, a kernel bug was identified with the suspend/resume > functionality on instances running in a public cloud [0]. This bug is a > regression introduced in v6.8-rc1. After a kernel bisect, the following >

Re: [PATCH] virtio_net: Warn if insufficient queue length for transmitting

2024-05-05 Thread Jason Wang
On Wed, May 1, 2024 at 4:07 AM Michael S. Tsirkin wrote: > > On Tue, Apr 30, 2024 at 03:35:09PM -0400, Darius Rad wrote: > > The transmit queue is stopped when the number of free queue entries is less > > than 2+MAX_SKB_FRAGS, in start_xmit(). If the queue length (QUEUE_NUM_MAX) > > is less than

Re: [PATCH v5 3/5] vduse: Add function to get/free the pages for reconnection

2024-04-24 Thread Jason Wang
On Wed, Apr 24, 2024 at 5:51 PM Michael S. Tsirkin wrote: > > On Wed, Apr 24, 2024 at 08:44:10AM +0800, Jason Wang wrote: > > On Tue, Apr 23, 2024 at 4:42 PM Michael S. Tsirkin wrote: > > > > > > On Tue, Apr 23, 2024 at 11:09:59AM +0800, Jason Wang wrote: > >

Re: [PATCH v5 3/5] vduse: Add function to get/free the pages for reconnection

2024-04-23 Thread Jason Wang
On Wed, Apr 24, 2024 at 11:15 AM Cindy Lu wrote: > > On Wed, Apr 24, 2024 at 8:44 AM Jason Wang wrote: > > > > On Tue, Apr 23, 2024 at 4:42 PM Michael S. Tsirkin wrote: > > > > > > On Tue, Apr 23, 2024 at 11:09:59AM +0800, Jason Wang wrote: > > >

Re: [PATCH v5 3/5] vduse: Add function to get/free the pages for reconnection

2024-04-23 Thread Jason Wang
On Tue, Apr 23, 2024 at 4:42 PM Michael S. Tsirkin wrote: > > On Tue, Apr 23, 2024 at 11:09:59AM +0800, Jason Wang wrote: > > On Tue, Apr 23, 2024 at 4:05 AM Michael S. Tsirkin wrote: > > > > > > On Thu, Apr 18, 2024 at 08:57:51AM +0800, Jason Wang wrote: > >

Re: [PATCH v5 3/5] vduse: Add function to get/free the pages for reconnection

2024-04-22 Thread Jason Wang
On Tue, Apr 23, 2024 at 4:05 AM Michael S. Tsirkin wrote: > > On Thu, Apr 18, 2024 at 08:57:51AM +0800, Jason Wang wrote: > > On Wed, Apr 17, 2024 at 5:29 PM Michael S. Tsirkin wrote: > > > > > > On Fri, Apr 12, 2024 at 09:28:23PM +0800, Cindy Lu w

Re: [PATCH v5 3/5] vduse: Add function to get/free the pages for reconnection

2024-04-17 Thread Jason Wang
On Wed, Apr 17, 2024 at 5:29 PM Michael S. Tsirkin wrote: > > On Fri, Apr 12, 2024 at 09:28:23PM +0800, Cindy Lu wrote: > > Add the function vduse_alloc_reconnnect_info_mem > > and vduse_alloc_reconnnect_info_mem > > These functions allow vduse to allocate and free memory for reconnection > >

Re: [PATCH net-next v9] virtio_net: Support RX hash XDP hint

2024-04-17 Thread Jason Wang
.@daynix.com/#r > > Signed-off-by: Liang Chen > --- Acked-by: Jason Wang Thanks

Re: [PATCH net-next v8] virtio_net: Support RX hash XDP hint

2024-04-16 Thread Jason Wang
On Tue, Apr 16, 2024 at 2:20 PM Liang Chen wrote: > > The RSS hash report is a feature that's part of the virtio specification. > Currently, virtio backends like qemu, vdpa (mlx5), and potentially vhost > (still a work in progress as per [1]) support this feature. While the > capability to obtain

Re: [PATCH v5 5/5] Documentation: Add reconnect process for VDUSE

2024-04-15 Thread Jason Wang
On Fri, Apr 12, 2024 at 9:31 PM Cindy Lu wrote: > > Add a document explaining the reconnect process, including what the > Userspace App needs to do and how it works with the kernel. > > Signed-off-by: Cindy Lu > --- > Documentation/userspace-api/vduse.rst | 41 +++ > 1

Re: [PATCH v2] vhost-vdpa: Remove usage of the deprecated ida_simple_xx() API

2024-04-15 Thread Jason Wang
usive. So a -1 has been added when needed. > > Signed-off-by: Christophe JAILLET > Reviewed-by: Simon Horman Acked-by: Jason Wang Thanks

Re: [PATCH] drivers/virtio: delayed configuration descriptor flags

2024-04-08 Thread Jason Wang
On Tue, Apr 9, 2024 at 1:27 AM ni.liqiang wrote: > > In our testing of the virtio hardware accelerator, we found that > configuring the flags of the descriptor after addr and len, > as implemented in DPDK, seems to be more friendly to the hardware. > > In our Virtio hardware implementation tests,

Re: [PATCH v3] vp_vdpa: fix the method of calculating vectors

2024-04-08 Thread Jason Wang
vp_vdpa->msix_name, vp_vdpa); > if (ret) { > dev_err(>dev, > - "vp_vdpa: fail to request irq for vq %d\n", i); > + "vp_vdpa: fail to request irq for config\n"); > goto err; > } > - vp_modern_config_vector(mdev, queues); > + vp_modern_config_vector(mdev, msix_vec); > vp_vdpa->config_irq = irq; > - Unnecessary changes. Others look good. Acked-by: Jason Wang Thanks > return 0; > err: > vp_vdpa_free_irq(vp_vdpa); > -- > 2.43.0 >

Re: [PATCH net-next v5] virtio_net: Support RX hash XDP hint

2024-04-08 Thread Jason Wang
On Mon, Apr 1, 2024 at 11:38 AM Liang Chen wrote: > > On Thu, Feb 29, 2024 at 4:37 PM Liang Chen wrote: > > > > On Tue, Feb 27, 2024 at 4:42 AM John Fastabend > > wrote: > > > > > > Jason Wang wrote: > > > > On Fri, Feb 23, 2024 at 9:42 AM

Re: Re: [PATCH v3] vhost/vdpa: Add MSI translation tables to iommu for software-managed MSI

2024-04-08 Thread Jason Wang
On Wed, Apr 3, 2024 at 10:47 AM tab wrote: > > > > > > > On Fri, Mar 29, 2024 at 11:55:50AM +0800, Jason Wang wrote: > > > > On Wed, Mar 27, 2024 at 5:08 PM Jason Wang wrote: > > > > > > > > > > On Thu, Mar 21, 2024 at 3:00 PM Micha

Re: [PATCH v3] vhost/vdpa: Add MSI translation tables to iommu for software-managed MSI

2024-04-06 Thread Jason Wang
On Fri, Mar 29, 2024 at 6:42 PM Michael S. Tsirkin wrote: > > On Fri, Mar 29, 2024 at 06:39:33PM +0800, Jason Wang wrote: > > On Fri, Mar 29, 2024 at 5:13 PM Michael S. Tsirkin wrote: > > > > > > On Wed, Mar 27, 2024 at 05:08:57PM +0800, Jason Wang wrote: > >

Re: [PATCH] vhost-vdpa: change ioctl # for VDPA_GET_VRING_SIZE

2024-04-06 Thread Jason Wang
vhost-vdpa: uapi to support reporting per vq size") > Cc: "Zhu Lingshan" > Signed-off-by: Michael S. Tsirkin Acked-by: Jason Wang Thanks > --- > > Build tested only - userspace patches using this will have to adjust. > I will merge this in a week or so unless

Re: [PATCH v3] vhost/vdpa: Add MSI translation tables to iommu for software-managed MSI

2024-03-29 Thread Jason Wang
On Fri, Mar 29, 2024 at 5:13 PM Michael S. Tsirkin wrote: > > On Fri, Mar 29, 2024 at 11:55:50AM +0800, Jason Wang wrote: > > On Wed, Mar 27, 2024 at 5:08 PM Jason Wang wrote: > > > > > > On Thu, Mar 21, 2024 at 3:00 PM Michael S. Tsirkin > > > wrote: >

Re: [PATCH v3] vhost/vdpa: Add MSI translation tables to iommu for software-managed MSI

2024-03-29 Thread Jason Wang
On Fri, Mar 29, 2024 at 5:13 PM Michael S. Tsirkin wrote: > > On Wed, Mar 27, 2024 at 05:08:57PM +0800, Jason Wang wrote: > > On Thu, Mar 21, 2024 at 3:00 PM Michael S. Tsirkin wrote: > > > > > > On Wed, Mar 20, 2024 at 06:19:12PM +0800, Wang Rong

Re: [PATCH v3] vhost/vdpa: Add MSI translation tables to iommu for software-managed MSI

2024-03-28 Thread Jason Wang
On Wed, Mar 27, 2024 at 5:08 PM Jason Wang wrote: > > On Thu, Mar 21, 2024 at 3:00 PM Michael S. Tsirkin wrote: > > > > On Wed, Mar 20, 2024 at 06:19:12PM +0800, Wang Rong wrote: > > > From: Rong Wang > > > > > > Once enable iommu domain for one

Re: [PATCH v2 1/1] vhost: Added pad cleanup if vnet_hdr is not present.

2024-03-27 Thread Jason Wang
d to set up qemu with > vhost=on,vnet_hdr=off, or do not configure vhost in the custom program. > > Signed-off-by: Andrew Melnychenko Acked-by: Jason Wang It seems it has been merged by Michael. Thanks > --- > drivers/vhost/net.c | 3 +++ > 1 file changed, 3 insertions(+) > >

Re: [PATCH v3 3/3] vhost: Improve vhost_get_avail_idx() with smp_rmb()

2024-03-27 Thread Jason Wang
_rmb() is executed when > the avail_idx is advanced. With it, the callers needn't to worry > about the memory barrier. > > Suggested-by: Michael S. Tsirkin > Signed-off-by: Gavin Shan Acked-by: Jason Wang Thanks

Re: [PATCH v3] vhost/vdpa: Add MSI translation tables to iommu for software-managed MSI

2024-03-27 Thread Jason Wang
On Thu, Mar 21, 2024 at 3:00 PM Michael S. Tsirkin wrote: > > On Wed, Mar 20, 2024 at 06:19:12PM +0800, Wang Rong wrote: > > From: Rong Wang > > > > Once enable iommu domain for one device, the MSI > > translation tables have to be there for software-managed MSI. > > Otherwise, platform with

Re: [PATCH v2 1/2] vhost: Add smp_rmb() in vhost_vq_avail_empty()

2024-03-27 Thread Jason Wang
On Wed, Mar 27, 2024 at 3:35 PM Gavin Shan wrote: > > On 3/27/24 14:08, Gavin Shan wrote: > > On 3/27/24 12:44, Jason Wang wrote: > >> On Wed, Mar 27, 2024 at 10:34 AM Jason Wang wrote: > >>> On Wed, Mar 27, 2024 at 7:39 AM Gavin Shan wrote: > >

Re: [PATCH v2 1/2] vhost: Add smp_rmb() in vhost_vq_avail_empty()

2024-03-26 Thread Jason Wang
On Wed, Mar 27, 2024 at 10:34 AM Jason Wang wrote: > > On Wed, Mar 27, 2024 at 7:39 AM Gavin Shan wrote: > > > > A smp_rmb() has been missed in vhost_vq_avail_empty(), spotted by > > Will Deacon . Otherwise, it's not ensured the > > available ring entries pushed by

Re: [PATCH v2 2/2] vhost: Add smp_rmb() in vhost_enable_notify()

2024-03-26 Thread Jason Wang
mb(); > + return true; > + } > > - return vq->avail_idx != vq->last_avail_idx; > + return false; So we only care about the case when vhost_enable_notify() returns true. In that case, I think you want to order with vhost_get_vq_desc(): last_avail_i

Re: [PATCH v2 1/2] vhost: Add smp_rmb() in vhost_vq_avail_empty()

2024-03-26 Thread Jason Wang
On Wed, Mar 27, 2024 at 7:39 AM Gavin Shan wrote: > > A smp_rmb() has been missed in vhost_vq_avail_empty(), spotted by > Will Deacon . Otherwise, it's not ensured the > available ring entries pushed by guest can be observed by vhost > in time, leading to stale available ring entries fetched by

Re: [PATCH v3] vhost/vdpa: Add MSI translation tables to iommu for software-managed MSI

2024-03-21 Thread Jason Wang
On Wed, Mar 20, 2024 at 6:20 PM Wang Rong wrote: > > From: Rong Wang > > Once enable iommu domain for one device, the MSI > translation tables have to be there for software-managed MSI. > Otherwise, platform with software-managed MSI without an > irq bypass function, can not get a correct memory

Re: [PATCH net-next v2 3/3] tun: AF_XDP Tx zero-copy support

2024-03-12 Thread Jason Wang
On Mon, Mar 11, 2024 at 9:28 PM wangyunjian wrote: > > > > > -Original Message- > > From: Jason Wang [mailto:jasow...@redhat.com] > > Sent: Monday, March 11, 2024 12:01 PM > > To: wangyunjian > > Cc: Michael S. Tsirkin ; Paolo Abeni ; > > wil

Re: [PATCH net-next v2 3/3] tun: AF_XDP Tx zero-copy support

2024-03-10 Thread Jason Wang
On Mon, Mar 4, 2024 at 9:45 PM wangyunjian wrote: > > > > > -Original Message- > > From: Michael S. Tsirkin [mailto:m...@redhat.com] > > Sent: Friday, March 1, 2024 7:53 PM > > To: wangyunjian > > Cc: Paolo Abeni ; willemdebruijn.ker...@gmail.com; > > jasow...@redhat.com;

Re: [PATCH net-next v6 5/5] tools: virtio: introduce vhost_net_test

2024-03-05 Thread Jason Wang
sending in the tun side. > > 3. Kick the vhost_net to do rx processing. > > 4. verify the data received by vhost_net is correct. > > > > Signed-off-by: Yunsheng Lin > > @Jason: AFAICS this addresses the points you raised on v5, could you > please have a look? > > Thanks! Looks good to me. Acked-by: Jason Wang Thanks > > Paolo > >

Re: [PATCH net-next v2 3/3] tun: AF_XDP Tx zero-copy support

2024-03-05 Thread Jason Wang
On Sat, Mar 2, 2024 at 2:40 AM Willem de Bruijn wrote: > > Maciej Fijalkowski wrote: > > On Wed, Feb 28, 2024 at 07:05:56PM +0800, Yunjian Wang wrote: > > > This patch set allows TUN to support the AF_XDP Tx zero-copy feature, > > > which can significantly reduce CPU utilization for XDP programs.

Re: [PATCH net-next v2 3/3] tun: AF_XDP Tx zero-copy support

2024-03-05 Thread Jason Wang
On Mon, Mar 4, 2024 at 7:24 PM wangyunjian wrote: > > > > > -Original Message- > > From: Jason Wang [mailto:jasow...@redhat.com] > > Sent: Monday, March 4, 2024 2:56 PM > > To: wangyunjian > > Cc: m...@redhat.com; willemdebruijn.ker...@gmail.com

Re: [PATCH net-next v2 3/3] tun: AF_XDP Tx zero-copy support

2024-03-03 Thread Jason Wang
On Wed, Feb 28, 2024 at 7:06 PM Yunjian Wang wrote: > > This patch set allows TUN to support the AF_XDP Tx zero-copy feature, > which can significantly reduce CPU utilization for XDP programs. > > Since commit fc72d1d54dd9 ("tuntap: XDP transmission"), the pointer > ring has been utilized to

Re: [PATCH net-next v4 2/2] virtio-net: add cond_resched() to the command waiting loop

2024-02-25 Thread Jason Wang
On Fri, Feb 23, 2024 at 3:22 AM Michael S. Tsirkin wrote: > > On Tue, Jul 25, 2023 at 11:03:11AM +0800, Jason Wang wrote: > > On Mon, Jul 24, 2023 at 3:18 PM Michael S. Tsirkin wrote: > > > > > > On Mon, Jul 24, 2023 at 02:52:49PM +0800, Jason Wang wrote: > >

Re: [PATCH net-next v5] virtio_net: Support RX hash XDP hint

2024-02-25 Thread Jason Wang
On Fri, Feb 23, 2024 at 9:42 AM Xuan Zhuo wrote: > > On Fri, 09 Feb 2024 13:57:25 +0100, Paolo Abeni wrote: > > On Fri, 2024-02-09 at 18:39 +0800, Liang Chen wrote: > > > On Wed, Feb 7, 2024 at 10:27 PM Paolo Abeni wrote: > > > > > > > > On Wed, 2024-02-07 at 10:54 +0800, Liang Chen wrote: > >

Re: [PATCH] vhost-vdpa: fail enabling virtqueue in certain conditions

2024-02-06 Thread Jason Wang
On Tue, Feb 6, 2024 at 10:52 PM Stefano Garzarella wrote: > > If VHOST_BACKEND_F_ENABLE_AFTER_DRIVER_OK is not negotiated, we expect > the driver to enable virtqueue before setting DRIVER_OK. If the driver > tries anyway, better to fail right away as soon as we get the ioctl. > Let's also update

Re: [PATCH net-next v5 5/5] tools: virtio: introduce vhost_net_test

2024-02-05 Thread Jason Wang
On Mon, Feb 5, 2024 at 8:46 PM Yunsheng Lin wrote: > > introduce vhost_net_test for both vhost_net tx and rx basing > on virtio_test to test vhost_net changing in the kernel. > > Steps for vhost_net tx testing: > 1. Prepare a out buf. > 2. Kick the vhost_net to do tx processing. > 3. Do the

Re: [PATCH] virtio: make virtio_bus const

2024-02-05 Thread Jason Wang
gt; Cc: Greg Kroah-Hartman > Suggested-by: Greg Kroah-Hartman > Signed-off-by: Ricardo B. Marliere > --- Acked-by: Jason Wang Thanks

Re: [PATCH net-next v4 5/5] tools: virtio: introduce vhost_net_test

2024-02-04 Thread Jason Wang
On Sun, Feb 4, 2024 at 11:50 AM Yunsheng Lin wrote: > > On 2024/2/4 9:30, Jason Wang wrote: > > On Fri, Feb 2, 2024 at 8:24 PM Yunsheng Lin wrote: > >> > >> On 2024/2/2 12:05, Jason Wang wrote: > >>> On Tue, Jan 30, 2024 at 7:38 PM Yunsheng

Re: [PATCH net-next v4 5/5] tools: virtio: introduce vhost_net_test

2024-02-03 Thread Jason Wang
On Fri, Feb 2, 2024 at 8:24 PM Yunsheng Lin wrote: > > On 2024/2/2 12:05, Jason Wang wrote: > > On Tue, Jan 30, 2024 at 7:38 PM Yunsheng Lin wrote: > >> > >> introduce vhost_net_test basing on virtio_test to test > >> vhost_net changing in the kernel. &

Re: [PATCH net-next v4 5/5] tools: virtio: introduce vhost_net_test

2024-02-01 Thread Jason Wang
On Tue, Jan 30, 2024 at 7:38 PM Yunsheng Lin wrote: > > introduce vhost_net_test basing on virtio_test to test > vhost_net changing in the kernel. Let's describe what kind of test is being done and how it is done here. > > Signed-off-by: Yunsheng Lin > --- > tools/virtio/.gitignore |

Re: [PATCH v4] virtio_net: Support RX hash XDP hint

2024-01-31 Thread Jason Wang
.@daynix.com/#r > > Signed-off-by: Liang Chen > Reviewed-by: Xuan Zhuo Acked-by: Jason Wang Thanks

Re: [PATCH net-next 2/2] tun: AF_XDP Rx zero-copy support

2024-01-29 Thread Jason Wang
On Mon, Jan 29, 2024 at 7:40 PM wangyunjian wrote: > > > -Original Message- > > From: Jason Wang [mailto:jasow...@redhat.com] > > Sent: Monday, January 29, 2024 11:03 AM > > To: wangyunjian > > Cc: m...@redhat.com; willemdebruijn.ker...@gmail.com; k...@ke

Re: [PATCH net-next 2/2] tun: AF_XDP Rx zero-copy support

2024-01-29 Thread Jason Wang
On Mon, Jan 29, 2024 at 7:10 PM wangyunjian wrote: > > > -Original Message- > > From: Jason Wang [mailto:jasow...@redhat.com] > > Sent: Monday, January 29, 2024 11:05 AM > > To: wangyunjian > > Cc: m...@redhat.com; willemdebruijn.ker...@gmail.com; k...@ke

Re: [PATCH net-next 2/2] tun: AF_XDP Rx zero-copy support

2024-01-28 Thread Jason Wang
On Sat, Jan 27, 2024 at 5:34 PM wangyunjian wrote: > > > > -Original Message- > > > From: Jason Wang [mailto:jasow...@redhat.com] > > > Sent: Thursday, January 25, 2024 12:49 PM > > > To: wangyunjian > > > Cc: m...@redhat.com; willemdebr

Re: [PATCH net-next 2/2] tun: AF_XDP Rx zero-copy support

2024-01-28 Thread Jason Wang
On Thu, Jan 25, 2024 at 8:54 PM wangyunjian wrote: > > > > > -Original Message- > > From: Jason Wang [mailto:jasow...@redhat.com] > > Sent: Thursday, January 25, 2024 12:49 PM > > To: wangyunjian > > Cc: m...@redhat.com; willemdebruijn.ke

Re: [PATCH net-next 2/2] tun: AF_XDP Rx zero-copy support

2024-01-24 Thread Jason Wang
On Wed, Jan 24, 2024 at 5:38 PM Yunjian Wang wrote: > > Now the zero-copy feature of AF_XDP socket is supported by some > drivers, which can reduce CPU utilization on the xdp program. > This patch set allows tun to support AF_XDP Rx zero-copy feature. > > This patch tries to address this by: > -

Re: [PATCH v2 2/3] virtio_net: Add missing virtio header in skb for XDP_PASS

2024-01-24 Thread Jason Wang
On Wed, Jan 24, 2024 at 5:16 PM Xuan Zhuo wrote: > > On Wed, 24 Jan 2024 16:57:20 +0800, Liang Chen > wrote: > > For the XDP_PASS scenario of the XDP path, the skb constructed with > > xdp_buff does not include the virtio header. Adding the virtio header > > information back when creating the

Re: [PATCH net-next 2/2] tun: AF_XDP Rx zero-copy support

2024-01-24 Thread Jason Wang
On Thu, Jan 25, 2024 at 3:05 AM Willem de Bruijn wrote: > > Yunjian Wang wrote: > > Now the zero-copy feature of AF_XDP socket is supported by some > > drivers, which can reduce CPU utilization on the xdp program. > > This patch set allows tun to support AF_XDP Rx zero-copy feature. > > > > This

Re: [PATCH] virtio_net: Support RX hash XDP hint

2024-01-23 Thread Jason Wang
On Mon, Jan 22, 2024 at 6:23 PM Liang Chen wrote: > > The RSS hash report is a feature that's part of the virtio specification. > Currently, virtio backends like qemu, vdpa (mlx5), and potentially vhost > (still a work in progress as per [1]) support this feature. While the > capability to obtain

Re: [PATCH V1] vdpa_sim: reset must not run

2024-01-21 Thread Jason Wang
set. > > Fixes: 0c89e2a3a9d0 ("vdpa_sim: Implement suspend vdpa op") > Signed-off-by: Steve Sistare > Reviewed-by: Eugenio Pérez Acked-by: Jason Wang Thanks

Re: [RFC V1 00/13] vdpa live update

2024-01-21 Thread Jason Wang
On Thu, Jan 18, 2024 at 4:32 AM Steven Sistare wrote: > > On 1/10/2024 9:55 PM, Jason Wang wrote: > > On Thu, Jan 11, 2024 at 4:40 AM Steve Sistare > > wrote: > >> > >> Live update is a technique wherein an application saves its state, exec's > >>

Re: [RFC V1 05/13] vhost-vdpa: VHOST_IOTLB_REMAP

2024-01-21 Thread Jason Wang
On Thu, Jan 18, 2024 at 4:32 AM Steven Sistare wrote: > > On 1/10/2024 10:08 PM, Jason Wang wrote: > > On Thu, Jan 11, 2024 at 4:40 AM Steve Sistare > > wrote: > >> > >> When device ownership is passed to a new process via VHOST_NEW_OWNER, > >&g

Re: [RFC V1 07/13] vhost-vdpa: flush workers on suspend

2024-01-11 Thread Jason Wang
On Fri, Jan 12, 2024 at 12:18 AM Mike Christie wrote: > > On 1/10/24 9:09 PM, Jason Wang wrote: > > On Thu, Jan 11, 2024 at 4:40 AM Steve Sistare > > wrote: > >> > >> To pass ownership of a live vdpa device to a new process, the user > >> suspend

Re: [PATCH] driver/virtio: Add Memory Balloon Support for SEV/SEV-ES

2024-01-10 Thread Jason Wang
On Wed, Jan 10, 2024 at 2:23 PM Zheyun Shen wrote: > > For now, SEV pins guest's memory to avoid swapping or > moving ciphertext, but leading to the inhibition of > Memory Ballooning. > > In Memory Ballooning, only guest's free pages will be relocated > in balloon inflation and deflation, so the

Re: [PATCH v7 2/3] vduse: Temporarily fail if control queue feature requested

2024-01-10 Thread Jason Wang
. > > Some work is on-going to make the control queue > implementation robust with VDUSE. Until it is completed, > let's fail features check if control-queue feature is > requested. > > Signed-off-by: Maxime Coquelin Acked-by: Jason Wang Thanks > --- > drivers/vdpa

Re: [RFC V1 08/13] vduse: flush workers on suspend

2024-01-10 Thread Jason Wang
On Thu, Jan 11, 2024 at 4:40 AM Steve Sistare wrote: > > To pass ownership of a live vdpa device to a new process, the user > suspends the device, calls VHOST_NEW_OWNER to change the mm, and calls > VHOST_IOTLB_REMAP to change the user virtual addresses to match the new > mm. Flush workers in

Re: [RFC V1 07/13] vhost-vdpa: flush workers on suspend

2024-01-10 Thread Jason Wang
On Thu, Jan 11, 2024 at 4:40 AM Steve Sistare wrote: > > To pass ownership of a live vdpa device to a new process, the user > suspends the device, calls VHOST_NEW_OWNER to change the mm, and calls > VHOST_IOTLB_REMAP to change the user virtual addresses to match the new > mm. Flush workers in

Re: [RFC V1 05/13] vhost-vdpa: VHOST_IOTLB_REMAP

2024-01-10 Thread Jason Wang
On Thu, Jan 11, 2024 at 4:40 AM Steve Sistare wrote: > > When device ownership is passed to a new process via VHOST_NEW_OWNER, > some devices need to know the new userland addresses of the dma mappings. > Define the new iotlb message type VHOST_IOTLB_REMAP to update the uaddr > of a mapping. The

Re: [RFC V1 00/13] vdpa live update

2024-01-10 Thread Jason Wang
On Thu, Jan 11, 2024 at 4:40 AM Steve Sistare wrote: > > Live update is a technique wherein an application saves its state, exec's > to an updated version of itself, and restores its state. Clients of the > application experience a brief suspension of service, on the order of > 100's of

Re: [PATCH v6 2/3] vduse: Temporarily fail if control queue features requested

2024-01-07 Thread Jason Wang
On Fri, Jan 5, 2024 at 6:14 PM Maxime Coquelin wrote: > > > > On 1/5/24 10:59, Eugenio Perez Martin wrote: > > On Fri, Jan 5, 2024 at 9:12 AM Maxime Coquelin > > wrote: > >> > >> > >> > >> On 1/5/24 03:45, Jason Wang wrote: > &

Re: [PATCH v6 3/3] vduse: enable Virtio-net device type

2024-01-04 Thread Jason Wang
d-only. It also fails with > -EPERM if the CAP_NET_ADMIN is missing. > > Signed-off-by: Maxime Coquelin > --- Acked-by: Jason Wang Thanks

Re: [PATCH v6 2/3] vduse: Temporarily fail if control queue features requested

2024-01-04 Thread Jason Wang
F_CTRL_VQ) |\ > +BIT_ULL(VIRTIO_NET_F_CTRL_RX) | \ > +BIT_ULL(VIRTIO_NET_F_CTRL_VLAN) | \ > +BIT_ULL(VIRTIO_NET_F_GUEST_ANNOUNCE) | \ > +BIT_ULL(VIRTIO_NET_F_MQ) | \ > +BIT_ULL(VIRTIO_NET_F_CTRL_MAC_ADDR) | \ > +

Re: [PATCH v4] virtio_pmem: support feature SHMEM_REGION

2023-12-26 Thread Jason Wang
the device, the driver looks for a shared memory region of id 0. > If it is found, this feature is understood. Otherwise, this feature > bit is cleared. > > During probe, if VIRTIO_PMEM_F_SHMEM_REGION has been negotiated, > virtio pmem ignores the `start` and `size` fields in dev

Re: [PATCH vhost v4 06/15] vdpa: Track device suspended state

2023-12-24 Thread Jason Wang
On Fri, Dec 22, 2023 at 7:22 PM Dragos Tatulea wrote: > > On Wed, 2023-12-20 at 13:55 +0100, Dragos Tatulea wrote: > > On Wed, 2023-12-20 at 11:46 +0800, Jason Wang wrote: > > > On Wed, Dec 20, 2023 at 2:09 AM Dragos Tatulea > > > wrote: > > > &g

Re: [PATCH vhost v4 02/15] vdpa: Add VHOST_BACKEND_F_CHANGEABLE_VQ_ADDR_IN_SUSPEND flag

2023-12-21 Thread Jason Wang
On Thu, Dec 21, 2023 at 3:47 PM Eugenio Perez Martin wrote: > > On Thu, Dec 21, 2023 at 3:03 AM Jason Wang wrote: > > > > On Wed, Dec 20, 2023 at 9:32 PM Eugenio Perez Martin > > wrote: > > > > > > On Wed, Dec 20, 2023 at 5:06 AM Jason Wang wrote: >

Re: [PATCH net-next 6/6] tools: virtio: introduce vhost_net_test

2023-12-20 Thread Jason Wang
On Thu, Dec 21, 2023 at 10:48 AM Yunsheng Lin wrote: > > On 2023/12/21 10:33, Jason Wang wrote: > > On Wed, Dec 20, 2023 at 8:45 PM Yunsheng Lin wrote: > >> > >> On 2023/12/12 12:35, Jason Wang wrote:>>>> +done: > >>>>>> + ba

Re: [PATCH net-next 6/6] tools: virtio: introduce vhost_net_test

2023-12-20 Thread Jason Wang
On Wed, Dec 20, 2023 at 8:45 PM Yunsheng Lin wrote: > > On 2023/12/12 12:35, Jason Wang wrote:>>>> +done: > >>>> + backend.fd = tun_alloc(); > >>>> + assert(backend.fd >= 0); > >>>> + vdev_info_init(, features

Re: [PATCH vhost v4 02/15] vdpa: Add VHOST_BACKEND_F_CHANGEABLE_VQ_ADDR_IN_SUSPEND flag

2023-12-20 Thread Jason Wang
On Wed, Dec 20, 2023 at 9:32 PM Eugenio Perez Martin wrote: > > On Wed, Dec 20, 2023 at 5:06 AM Jason Wang wrote: > > > > On Wed, Dec 20, 2023 at 11:46 AM Jason Wang wrote: > > > > > > On Wed, Dec 20, 2023 at 2:09 AM Dragos Tatulea > > > wrote:

Re: [PATCH vhost v4 02/15] vdpa: Add VHOST_BACKEND_F_CHANGEABLE_VQ_ADDR_IN_SUSPEND flag

2023-12-19 Thread Jason Wang
On Wed, Dec 20, 2023 at 11:46 AM Jason Wang wrote: > > On Wed, Dec 20, 2023 at 2:09 AM Dragos Tatulea wrote: > > > > The virtio spec doesn't allow changing virtqueue addresses after > > DRIVER_OK. Some devices do support this operation when the

Re: [PATCH] vdpa: Fix an error handling path in eni_vdpa_probe()

2023-12-19 Thread Jason Wang
register_device(_vdpa->vdpa, eni_vdpa->queues); > > if (ret) { > > ENI_ERR(pdev, "failed to register to vdpa bus\n"); > > - goto err; > > + goto err_remove_vp_legacy; > > } > > > > return 0; > > > > +err_remove_vp_legacy: > > + vp_legacy_remove(_vdpa->ldev); > > err: > > put_device(_vdpa->vdpa.dev); > > return ret; > > Polite reminder on a (very) old patch. Acked-by: Jason Wang Thanks > > CJ >

Re: [PATCH] virtio_pmem: support feature SHMEM_REGION

2023-12-19 Thread Jason Wang
On Tue, Dec 19, 2023 at 3:19 PM Changyuan Lyu wrote: > > As per virtio spec 1.2 section 5.19.5.2, if the feature > VIRTIO_PMEM_F_SHMEM_REGION has been negotiated, the driver MUST query > shared memory ID 0 for the physical address ranges. > > Signed-off-by: Changyuan Lyu > --- >

Re: [PATCH] vdpa: Remove usage of the deprecated ida_simple_xx() API

2023-12-19 Thread Jason Wang
On Mon, Dec 11, 2023 at 1:52 AM Christophe JAILLET wrote: > > ida_alloc() and ida_free() should be preferred to the deprecated > ida_simple_get() and ida_simple_remove(). > > This is less verbose. > > Signed-off-by: Christophe JAILLET Acked-by: Jason Wang Thanks > --

Re: [PATCH v5 2/4] vduse: Temporarily disable control queue features

2023-12-19 Thread Jason Wang
On Mon, Dec 18, 2023 at 5:21 PM Maxime Coquelin wrote: > > > > On 12/18/23 03:50, Jason Wang wrote: > > On Wed, Dec 13, 2023 at 7:23 PM Maxime Coquelin > > wrote: > >> > >> Hi Jason, > >> > >> On 12/13/23 05:52, Jason Wang wrote: > &

Re: [PATCH RFC 0/4] virtio-net: add tx-hash, rx-tstamp, tx-tstamp and tx-time

2023-12-19 Thread Jason Wang
On Tue, Dec 19, 2023 at 12:36 AM Willem de Bruijn wrote: > > Steffen Trumtrar wrote: > > This series tries to pick up the work on the virtio-net timestamping > > feature from Willem de Bruijn. > > > > Original series > > Message-Id: 20210208185558.995292-1-willemdebruijn.ker...@gmail.com > >

Re: [PATCH vhost v4 14/15] vdpa/mlx5: Introduce reference counting to mrs

2023-12-19 Thread Jason Wang
hen the mkey is unlinked from the vq (trough modify/destroy) > and from the mr asid table. > > To make things consistent, get rid of mlx5_vdpa_destroy_mr and use > get/put semantics everywhere. > > Reviewed-by: Gal Pressman > Acked-by: Eugenio Pérez > Signed-off-by: Dragos Tatulea > --- Acked-by: Jason Wang Thanks

Re: [PATCH vhost v4 13/15] vdpa/mlx5: Use vq suspend/resume during .set_map

2023-12-19 Thread Jason Wang
n't support resumable vqs, do the old teardown and > setup dance. > > Reviewed-by: Gal Pressman > Acked-by: Eugenio Pérez > Signed-off-by: Dragos Tatulea > --- Acked-by: Jason Wang Thanks

Re: [PATCH vhost v4 12/15] vdpa/mlx5: Mark vq state for modification in hw vq

2023-12-19 Thread Jason Wang
eviewed-by: Gal Pressman > Signed-off-by: Dragos Tatulea > --- Acked-by: Jason Wang Thanks

Re: [PATCH vhost v4 10/15] vdpa/mlx5: Introduce per vq and device resume

2023-12-19 Thread Jason Wang
On Wed, Dec 20, 2023 at 2:10 AM Dragos Tatulea wrote: > > Implement vdpa vq and device resume if capability detected. Add support > for suspend -> ready state change. > > Reviewed-by: Gal Pressman > Acked-by: Eugenio Pérez > Signed-off-by: Dragos Tatulea Acked-by: Jason Wang Thanks

Re: [PATCH vhost v4 09/15] vdpa/mlx5: Allow modifying multiple vq fields in one modify command

2023-12-19 Thread Jason Wang
Gal Pressman > Acked-by: Eugenio Pérez > Signed-off-by: Dragos Tatulea Acked-by: Jason Wang Thanks

Re: [PATCH vhost v4 06/15] vdpa: Track device suspended state

2023-12-19 Thread Jason Wang
On Wed, Dec 20, 2023 at 2:09 AM Dragos Tatulea wrote: > > Set vdpa device suspended state on successful suspend. Clear it on > successful resume and reset. > > The state will be locked by the vhost_vdpa mutex. The mutex is taken > during suspend, resume and reset in vhost_vdpa_unlocked_ioctl. The

Re: [PATCH vhost v4 02/15] vdpa: Add VHOST_BACKEND_F_CHANGEABLE_VQ_ADDR_IN_SUSPEND flag

2023-12-19 Thread Jason Wang
On Wed, Dec 20, 2023 at 2:09 AM Dragos Tatulea wrote: > > The virtio spec doesn't allow changing virtqueue addresses after > DRIVER_OK. Some devices do support this operation when the device is > suspended. The VHOST_BACKEND_F_CHANGEABLE_VQ_ADDR_IN_SUSPEND flag > advertises this support as a

Re: [PATCH mlx5-vhost v4 01/15] vdpa/mlx5: Expose resumable vq capability

2023-12-19 Thread Jason Wang
On Wed, Dec 20, 2023 at 2:09 AM Dragos Tatulea wrote: > > Necessary for checking if resumable vqs are supported by the hardware. > Actual support will be added in a downstream patch. > > Reviewed-by: Gal Pressman > Acked-by: Eugenio Pérez > Signed-off-by: Dragos Tatulea

Re: [PATCH v5 2/4] vduse: Temporarily disable control queue features

2023-12-17 Thread Jason Wang
On Wed, Dec 13, 2023 at 7:23 PM Maxime Coquelin wrote: > > Hi Jason, > > On 12/13/23 05:52, Jason Wang wrote: > > On Tue, Dec 12, 2023 at 9:17 PM Maxime Coquelin > > wrote: > >> > >> Virtio-net driver control queue implementation is not safe > >

Re: [PATCH v5 2/4] vduse: Temporarily disable control queue features

2023-12-12 Thread Jason Wang
On Tue, Dec 12, 2023 at 9:17 PM Maxime Coquelin wrote: > > Virtio-net driver control queue implementation is not safe > when used with VDUSE. If the VDUSE application does not > reply to control queue messages, it currently ends up > hanging the kernel thread sending this command. > > Some work

Re: [PATCH net-next 6/6] tools: virtio: introduce vhost_net_test

2023-12-11 Thread Jason Wang
On Thu, Dec 7, 2023 at 7:28 PM Yunsheng Lin wrote: > > On 2023/12/7 14:00, Jason Wang wrote: > > On Tue, Dec 5, 2023 at 7:35 PM Yunsheng Lin wrote: > ... > > >> + > >> +static int tun_alloc(void) > >> +{ > >> + struct ifreq ifr; >

Re: [PATCH v2] virtio: Add support for no-reset virtio PCI PM

2023-12-11 Thread Jason Wang
On Tue, Dec 12, 2023 at 12:37 AM Michael S. Tsirkin wrote: > > On Fri, Dec 08, 2023 at 04:07:54PM +0900, David Stevens wrote: > > If a virtio_pci_device supports native PCI power management and has the > > No_Soft_Reset bit set, then skip resetting and reinitializing the device > > when

Re: Re: Re: EEVDF/vhost regression (bisected to 86bfbb7ce4f6 sched/fair: Add lag based placement)

2023-12-11 Thread Jason Wang
On Tue, Dec 12, 2023 at 12:54 AM Michael S. Tsirkin wrote: > > On Mon, Dec 11, 2023 at 03:26:46PM +0800, Jason Wang wrote: > > > Try reducing the VHOST_NET_WEIGHT limit and see if that improves things > > > any? > > > > Or a dirty hack like cond_resched()

Re: [PATCH v2] virtio: Add support for no-reset virtio PCI PM

2023-12-10 Thread Jason Wang
wer states like s2idle to be used in systems with stateful virtio > devices that can't simply be re-initialized (e.g. virtio-fs). > > Signed-off-by: David Stevens Acked-by: Jason Wang Thanks > --- > v1 -> v2: > - Check the No_Soft_Reset bit > >

Re: Re: Re: EEVDF/vhost regression (bisected to 86bfbb7ce4f6 sched/fair: Add lag based placement)

2023-12-10 Thread Jason Wang
On Sat, Dec 9, 2023 at 6:42 PM Michael S. Tsirkin wrote: > > On Fri, Dec 08, 2023 at 12:41:38PM +0100, Tobias Huschle wrote: > > On Fri, Dec 08, 2023 at 05:31:18AM -0500, Michael S. Tsirkin wrote: > > > On Fri, Dec 08, 2023 at 10:24:16AM +0100, Tobias Huschle wrote: > > > > On Thu, Dec 07, 2023

Re: [PATCH net-next 6/6] tools: virtio: introduce vhost_net_test

2023-12-06 Thread Jason Wang
On Tue, Dec 5, 2023 at 7:35 PM Yunsheng Lin wrote: > > introduce vhost_net_test basing on virtio_test to test > vhost_net changing in the kernel. > > Signed-off-by: Yunsheng Lin > --- > tools/virtio/Makefile | 8 +- > tools/virtio/vhost_net_test.c | 441

Re: [PATCH net-next 4/6] vhost/net: remove vhost_net_page_frag_refill()

2023-12-06 Thread Jason Wang
st_net_test introduced in the > last patch. > > Signed-off-by: Yunsheng Lin > --- Acked-by: Jason Wang Thanks

Re: [PATCH net-next 5/6] net: introduce page_frag_cache_drain()

2023-12-06 Thread Jason Wang
On Tue, Dec 5, 2023 at 7:35 PM Yunsheng Lin wrote: > > When draining a page_frag_cache, most user are doing > the similar steps, so introduce an API to avoid code > duplication. > > Signed-off-by: Yunsheng Lin > --- For vhost part: Acked-by: Jason Wang Thanks

Re: [GIT PULL] virtio: features

2023-11-30 Thread Jason Wang
On Thu, Nov 30, 2023 at 5:44 PM Michael S. Tsirkin wrote: > > On Wed, Nov 29, 2023 at 06:20:31PM +0800, Jason Wang wrote: > > On Wed, Nov 29, 2023 at 6:12 PM Ning, Hongyu > > wrote: > > > > > > > > > On 2023/11/29 17:16, Jason Wang wrote: > &g

Re: [GIT PULL] virtio: features

2023-11-29 Thread Jason Wang
flag > >vdpa: accept VHOST_BACKEND_F_ENABLE_AFTER_DRIVER_OK backend feature > >vdpa: add get_backend_features vdpa operation > >vdpa_sim: offer VHOST_BACKEND_F_ENABLE_AFTER_DRIVER_OK > > > > Jason Wang (1): > >virtio_v

Re: [RFC v1 3/8] vhost: Add 3 new uapi to support iommufd

2023-11-09 Thread Jason Wang
On Wed, Nov 8, 2023 at 3:09 PM Jason Wang wrote: > > On Wed, Nov 8, 2023 at 2:39 PM Cindy Lu wrote: > > > > On Wed, Nov 8, 2023 at 11:03 AM Jason Wang wrote: > > > > > > On Tue, Nov 7, 2023 at 2:57 PM Cindy Lu wrote: > > > > > >

Re: [RFC v1 3/8] vhost: Add 3 new uapi to support iommufd

2023-11-07 Thread Jason Wang
On Wed, Nov 8, 2023 at 2:39 PM Cindy Lu wrote: > > On Wed, Nov 8, 2023 at 11:03 AM Jason Wang wrote: > > > > On Tue, Nov 7, 2023 at 2:57 PM Cindy Lu wrote: > > > > > > On Mon, Nov 6, 2023 at 3:30 PM Jason Wang wrote: > > > > > &

  1   2   3   4   5   6   7   8   9   10   >