Re: [PATCH 4/5] HID: apple-ibridge: Add Apple iBridge HID driver for T1 chip.

2021-02-28 Thread Life is hard, and then you die
Hi Jonathan, On Sun, Feb 28, 2021 at 03:02:39PM +, Jonathan Cameron wrote: > On Sat, 27 Feb 2021 17:26:42 -0800 > Ronald Tschal?r wrote: [snip] > > +#ifdef CONFIG_PM > > +/** > > + * appleib_forward_int_op() - Forward a hid-driver callback to all drivers > > on > > + * all virtual HID

Re: [PATCH 3/3] Input: applespi: Add trace_event module param for early tracing.

2021-02-17 Thread Life is hard, and then you die
Hi Dmitry, On Wed, Feb 17, 2021 at 01:06:27PM -0800, Dmitry Torokhov wrote: > On Wed, Feb 17, 2021 at 12:52:57PM -0800, Life is hard, and then you die > wrote: > > > > On Wed, Feb 17, 2021 at 12:26:18PM -0800, Dmitry Torokhov wrote: > > > > > > On W

Re: [PATCH 3/3] Input: applespi: Add trace_event module param for early tracing.

2021-02-17 Thread Life is hard, and then you die
Hi Dmitry, On Wed, Feb 17, 2021 at 12:26:18PM -0800, Dmitry Torokhov wrote: > > On Wed, Feb 17, 2021 at 11:07:18AM -0800, Ronald Tschalär wrote: > > The problem is that tracing can't be set via sysfs until the module is > > loaded, at which point the keyboard and trackpad initialization

Re: [PATCH 1/3] Input: applespi: Don't wait for responses to commands indefinitely.

2021-02-17 Thread Life is hard, and then you die
Hi Dmitry, On Wed, Feb 17, 2021 at 12:23:23PM -0800, Dmitry Torokhov wrote: > > On Wed, Feb 17, 2021 at 11:07:16AM -0800, Ronald Tschalär wrote: > > @@ -869,7 +878,7 @@ static int applespi_send_cmd_msg(struct applespi_data > > *applespi) > > return sts; > > } > > > > -

Re: [PATCH] Input: applespi - Fix build error

2019-07-30 Thread Life is hard, and then you die
On Mon, Jul 29, 2019 at 04:04:38PM +0200, Dmitry Torokhov wrote: > On Mon, Jul 29, 2019 at 11:14:55AM +0800, YueHaibing wrote: > > If CONFIG_KEYBOARD_APPLESPI=y but CONFIG_LEDS_CLASS=m > > building fails: > > > > drivers/input/keyboard/applespi.o: In function `applespi_probe': > >

Re: [PATCH v2] Input: applespi - register touchpad device synchronously in probe

2019-07-30 Thread Life is hard, and then you die
Hi Dmitry, On Mon, Jul 29, 2019 at 03:22:03PM +0200, Dmitry Torokhov wrote: > Hi Ronald, > > On Sun, Jul 21, 2019 at 12:05:23AM -0700, Ronald Tschalär wrote: > > This allows errors during registration to properly fail the probe > > function. > > > > Doing this requires waiting for a

Re: [PATCH 2/2] Input: applespi: fix warnings detected by sparse

2019-07-21 Thread Life is hard, and then you die
Hi Dmitry, On Sun, Jul 21, 2019 at 10:24:27AM +0300, Dmitry Torokhov wrote: > On Sun, Jul 21, 2019 at 12:06:29AM -0700, Ronald Tschalär wrote: > > Reported-by: kbuild test robot > > Signed-off-by: Ronald Tschalär > > --- > > drivers/input/keyboard/applespi.c | 18 +++--- > > 1

Re: [PATCH] Input: applespi: Fix build error without CONFIG_PCI

2019-07-18 Thread Life is hard, and then you die
Hi Arnd, On Thu, Jul 18, 2019 at 09:15:59AM +0200, Arnd Bergmann wrote: > On Thu, Jul 18, 2019 at 4:07 AM YueHaibing wrote: > > > > If CONFIG_KEYBOARD_APPLESPI is set to y, but > > CONFIG_PCI is not set, building will fails: > > > > drivers/spi/spi-pxa2xx-pci.c: In function

Re: [PATCH] Input: applespi: Fix build error without CONFIG_PCI

2019-07-18 Thread Life is hard, and then you die
On Thu, Jul 18, 2019 at 10:06:54AM +0800, YueHaibing wrote: > If CONFIG_KEYBOARD_APPLESPI is set to y, but > CONFIG_PCI is not set, building will fails: > > drivers/spi/spi-pxa2xx-pci.c: In function pxa2xx_spi_pci_probe: > drivers/spi/spi-pxa2xx-pci.c:208:8: error: implicit declaration of

Re: [PATCH 1/3] mfd: apple-ibridge: Add Apple iBridge MFD driver.

2019-06-10 Thread Life is hard, and then you die
Hi Benjamin, Sorry for the extremely late reply - RL etc. On Fri, Apr 26, 2019 at 08:26:25AM +0200, Benjamin Tissoires wrote: > On Fri, Apr 26, 2019 at 7:56 AM Life is hard, and then you die > wrote: > > > > On Thu, Apr 25, 2019 at 11:39:12AM +0200, Benjamin Tissoires w

Re: [PATCH 1/3] mfd: apple-ibridge: Add Apple iBridge MFD driver.

2019-06-09 Thread Life is hard, and then you die
On Tue, May 07, 2019 at 01:24:15PM +0100, Lee Jones wrote: > On Sun, 21 Apr 2019, Ronald Tschalär wrote: > > > The iBridge device provides access to several devices, including: > > - the Touch Bar > > - the iSight webcam > > - the light sensor > > - the fingerprint sensor > > > > This driver

Re: [PATCH 1/3] mfd: apple-ibridge: Add Apple iBridge MFD driver.

2019-04-25 Thread Life is hard, and then you die
Hi Benjamin, On Thu, Apr 25, 2019 at 11:39:12AM +0200, Benjamin Tissoires wrote: > On Thu, Apr 25, 2019 at 10:19 AM Life is hard, and then you die > wrote: > > > > Hi Benjamin, > > > > Thank you for looking at this. > > > > On Wed, Apr 24, 2019 at

Re: [PATCH 1/3] mfd: apple-ibridge: Add Apple iBridge MFD driver.

2019-04-25 Thread Life is hard, and then you die
Hi Jonathan, On Wed, Apr 24, 2019 at 08:13:17PM +0100, Jonathan Cameron wrote: > On Wed, 24 Apr 2019 03:47:18 -0700 > "Life is hard, and then you die" wrote: > > > Hi Jonathan, > > > > On Mon, Apr 22, 2019 at 12:34:26PM +0100, Jonathan Cameron wrot

Re: [PATCH 1/3] mfd: apple-ibridge: Add Apple iBridge MFD driver.

2019-04-25 Thread Life is hard, and then you die
Hi Benjamin, Thank you for looking at this. On Wed, Apr 24, 2019 at 04:18:23PM +0200, Benjamin Tissoires wrote: > On Mon, Apr 22, 2019 at 5:13 AM Ronald Tschalär wrote: > > > > The iBridge device provides access to several devices, including: > > - the Touch Bar > > - the iSight webcam > >

Re: [PATCH 1/3] mfd: apple-ibridge: Add Apple iBridge MFD driver.

2019-04-24 Thread Life is hard, and then you die
Hi Jonathan, On Mon, Apr 22, 2019 at 12:34:26PM +0100, Jonathan Cameron wrote: > On Sun, 21 Apr 2019 20:12:49 -0700 > Ronald Tschalär wrote: > > > The iBridge device provides access to several devices, including: > > - the Touch Bar > > - the iSight webcam > > - the light sensor > > - the

Re: [PATCH 3/3] iio: light: apple-ib-als: Add driver for ALS on iBridge chip.

2019-04-23 Thread Life is hard, and then you die
Hi Jonathan, Peter, On Mon, Apr 22, 2019 at 01:01:38PM +0100, Jonathan Cameron wrote: > On Mon, 22 Apr 2019 11:17:27 +0200 (CEST) > Peter Meerwald-Stadler wrote: > > > On Sun, 21 Apr 2019, Ronald Tschalär wrote: > > > > > On 2016/2017 MacBook Pro's with a Touch Bar the ALS is attached to,

Re: [PATCH v4 1/2] drm/bridge: sil_sii8620: make remote control optional.

2019-04-15 Thread Life is hard, and then you die
Hi Andrzej, On Wed, Apr 10, 2019 at 11:42:50AM +0200, Andrzej Hajda wrote: > On 07.04.2019 07:03, Ronald Tschalär wrote: > > commit d6abe6df706c (drm/bridge: sil_sii8620: do not have a dependency > > of RC_CORE) changed the driver to select both RC_CORE and INPUT. > > However, this causes

Re: [PATCH v4 2/2] Input: add Apple SPI keyboard and trackpad driver.

2019-04-08 Thread Life is hard, and then you die
On Mon, Apr 08, 2019 at 03:33:43PM +0300, Andy Shevchenko wrote: > On Sat, Apr 06, 2019 at 10:03:58PM -0700, Ronald Tschalär wrote: > > The keyboard and trackpad on recent MacBook's (since 8,1) and > > MacBookPro's (13,* and 14,*) are attached to an SPI controller instead > > of USB, as

Re: [PATCH v3 3/4] driver core: add dev_print_hex_dump() logging function.

2019-04-06 Thread Life is hard, and then you die
> On Mon, Apr 01, 2019 at 07:47:14PM -0700, Life is hard, and then you die > wrote: > > > > On Thu, Mar 28, 2019 at 12:29:52PM +0100, Greg Kroah-Hartman wrote: > > > On Thu, Mar 28, 2019 at 03:27:55AM -0700, Life is hard, and then you die > > > wrote: &

Re: [PATCH v3 3/4] driver core: add dev_print_hex_dump() logging function.

2019-04-01 Thread Life is hard, and then you die
On Thu, Mar 28, 2019 at 12:29:52PM +0100, Greg Kroah-Hartman wrote: > On Thu, Mar 28, 2019 at 03:27:55AM -0700, Life is hard, and then you die > wrote: > > > > On Thu, Mar 28, 2019 at 06:29:17AM +0100, Greg Kroah-Hartman wrote: > > > On Wed, Mar 27, 2019 at 05:

Re: [PATCH v3 2/4] lib/hexdump.c: factor out generic hexdump formatting for reuse.

2019-03-28 Thread Life is hard, and then you die
On Thu, Mar 28, 2019 at 11:03:50AM +0200, Andy Shevchenko wrote: > On Wed, Mar 27, 2019 at 05:34:59PM -0700, Life is hard, and then you die > wrote: > > > > On Wed, Mar 27, 2019 at 09:46:48AM +0200, Andy Shevchenko wrote: > > > On Wed, Mar 27, 2019 at 3:49 AM Ro

Re: [PATCH v3 3/4] driver core: add dev_print_hex_dump() logging function.

2019-03-28 Thread Life is hard, and then you die
On Thu, Mar 28, 2019 at 06:29:17AM +0100, Greg Kroah-Hartman wrote: > On Wed, Mar 27, 2019 at 05:28:17PM -0700, Life is hard, and then you die > wrote: > > > > On Wed, Mar 27, 2019 at 11:37:57AM +0900, Greg Kroah-Hartman wrote: > > > On Tue, Mar 26, 2019 at 06:48:

Re: [PATCH v3 2/4] lib/hexdump.c: factor out generic hexdump formatting for reuse.

2019-03-27 Thread Life is hard, and then you die
On Wed, Mar 27, 2019 at 09:46:48AM +0200, Andy Shevchenko wrote: > On Wed, Mar 27, 2019 at 3:49 AM Ronald Tschalär wrote: > > > > This introduces print_hex_dump_to_cb() which contains all the hexdump > > formatting minus the actual printk() call, allowing an arbitrary print > > function to be

Re: [PATCH v3 3/4] driver core: add dev_print_hex_dump() logging function.

2019-03-27 Thread Life is hard, and then you die
On Wed, Mar 27, 2019 at 11:37:57AM +0900, Greg Kroah-Hartman wrote: > On Tue, Mar 26, 2019 at 06:48:06PM -0700, Ronald Tschalär wrote: > > This is the dev_xxx() analog to print_hex_dump(), using dev_printk() > > instead of straight printk() to match other dev_xxx() logging functions. > > --- > >

Re: [PATCH v3 4/4] Input: add Apple SPI keyboard and trackpad driver.

2019-03-27 Thread Life is hard, and then you die
On Wed, Mar 27, 2019 at 11:35:30AM +0200, Andy Shevchenko wrote: > On Tue, Mar 26, 2019 at 06:48:07PM -0700, Ronald Tschalär wrote: > > The keyboard and trackpad on recent MacBook's (since 8,1) and > > MacBookPro's (13,* and 14,*) are attached to an SPI controller instead > > of USB, as

Re: [PATCH v2] drm/bridge: sil_sii8620: make remote control optional.

2019-03-03 Thread Life is hard, and then you die
On Thu, Jan 24, 2019 at 05:33:55PM -0800, Ronald Tschalär wrote: > commit d6abe6df706c (drm/bridge: sil_sii8620: do not have a dependency > of RC_CORE) changed the driver to select both RC_CORE and INPUT. > However, this causes problems with other drivers, in particular an input > driver that

Re: [PATCH v2 2/2] Input: add Apple SPI keyboard and trackpad driver.

2019-02-26 Thread Life is hard, and then you die
On Tue, Feb 26, 2019 at 11:20:59AM +0200, Andy Shevchenko wrote: > On Thu, Feb 21, 2019 at 02:56:09AM -0800, Ronald Tschalär wrote: > > The keyboard and trackpad on recent MacBook's (since 8,1) and > > MacBookPro's (13,* and 14,*) are attached to an SPI controller instead > > of USB, as

Re: [PATCH v2 2/2] Input: add Apple SPI keyboard and trackpad driver.

2019-02-25 Thread Life is hard, and then you die
On Thu, Feb 21, 2019 at 02:56:09AM -0800, Ronald Tschalär wrote: > The keyboard and trackpad on recent MacBook's (since 8,1) and > MacBookPro's (13,* and 14,*) are attached to an SPI controller instead > of USB, as previously. The higher level protocol is not publicly > documented and hence has

Re: [PATCH 2/2] Input: add Apple SPI keyboard and trackpad driver.

2019-02-18 Thread Life is hard, and then you die
On Sat, Feb 16, 2019 at 02:44:26AM +0200, Andy Shevchenko wrote: > On Sun, Feb 10, 2019 at 03:18:34AM -0800, Life is hard, and then you die > wrote: > > On Wed, Feb 06, 2019 at 10:22:56PM +0200, Andy Shevchenko wrote: > > > On Mon, Feb 04, 2019 at 12:19:47AM -0800,

Re: [PATCH 2/2] Input: add Apple SPI keyboard and trackpad driver.

2019-02-10 Thread Life is hard, and then you die
Hi Andy, On Wed, Feb 06, 2019 at 10:22:56PM +0200, Andy Shevchenko wrote: > On Mon, Feb 04, 2019 at 12:19:47AM -0800, Ronald Tschalär wrote: > > The keyboard and trackpad on recent MacBook's (since 8,1) and > > MacBookPro's (13,* and 14,*) are attached to an SPI controller instead > > of USB,

Re: [PATCH 2/2] Input: add Apple SPI keyboard and trackpad driver.

2019-02-05 Thread Life is hard, and then you die
Hi Andy, On Tue, Feb 05, 2019 at 01:45:22PM +0200, Andy Shevchenko wrote: > On Mon, Feb 04, 2019 at 12:19:47AM -0800, Ronald Tschalär wrote: > > The keyboard and trackpad on recent MacBook's (since 8,1) and > > MacBookPro's (13,* and 14,*) are attached to an SPI controller instead > > of USB,

Re: [PATCH 2/2] Input: add Apple SPI keyboard and trackpad driver.

2019-02-05 Thread Life is hard, and then you die
Hi Dan, On Tue, Feb 05, 2019 at 01:21:10PM +0300, Dan Carpenter wrote: > Hi Ronald, > > Thank you for the patch! Perhaps something to improve: > > url: >

Re: [PATCH 0/2] Add Apple SPI keyboard and trackpad driver

2019-02-05 Thread Life is hard, and then you die
Hi Henrik, On Mon, Feb 04, 2019 at 09:47:55PM +0100, Henrik Rydberg wrote: > Hi Ronald, > > > This changeset adds a driver for the SPI keyboard and trackpad on recent > > MacBook's and MacBook Pro's. The driver has seen a fair amount of use > > over the last 2 years (basically anybody

Re: [PATCH] drm/bridge: sil_sii8620: depend on INPUT instead of selecting it.

2019-01-23 Thread Life is hard, and then you die
Hi Laurent, On Tue, Jan 22, 2019 at 11:10:28PM +0200, Laurent Pinchart wrote: > > Thank you for the patch. > > On Tue, Jan 22, 2019 at 06:13:11AM -0800, Ronald Tschalär wrote: > > commit d6abe6df706c66d803e6dd4fe98c1b6b7f125a56 (drm/bridge: > > Commits are usually quoted using the short 12

Re: [PATCH] drm/bridge: sil_sii8620: depend on INPUT instead of selecting it.

2019-01-23 Thread Life is hard, and then you die
On Thu, Jan 24, 2019 at 12:22:00AM +0200, Laurent Pinchart wrote: > > On Wed, Jan 23, 2019 at 02:21:05PM -0800, Dmitry Torokhov wrote: > > On Thu, Jan 24, 2019 at 12:17:35AM +0200, Laurent Pinchart wrote: > > > On Wed, Jan 23, 2019 at 02:03:42PM -0800, Dmitry Torokhov wrote: > > >> On Wed, Jan

Re: [PATCH v2] Bluetooth: hci_ldisc: Allow sleeping while proto locks are held.

2017-10-26 Thread Life is hard, and then you die
On Thu, Oct 26, 2017 at 08:58:28AM +0200, Lukas Wunner wrote: > On Wed, Oct 25, 2017 at 10:14:53PM -0700, =?UTF-8?q?Ronald=20Tschal=C3=A4r?= > wrote: > > Commit dec2c92880cc5435381d50e3045ef018a762a917 ("Bluetooth: hci_ldisc: > > Use rwlocking to avoid closing proto races") introduced locks in >

Re: [PATCH v2] Bluetooth: hci_ldisc: Allow sleeping while proto locks are held.

2017-10-26 Thread Life is hard, and then you die
On Thu, Oct 26, 2017 at 08:58:28AM +0200, Lukas Wunner wrote: > On Wed, Oct 25, 2017 at 10:14:53PM -0700, =?UTF-8?q?Ronald=20Tschal=C3=A4r?= > wrote: > > Commit dec2c92880cc5435381d50e3045ef018a762a917 ("Bluetooth: hci_ldisc: > > Use rwlocking to avoid closing proto races") introduced locks in >

Re: [PATCH] Bluetooth: hci_ldisc: Allow sleeping while proto locks are held.

2017-10-17 Thread Life is hard, and then you die
Hi Dean, apologies for the slow reply, and thank you for the detailed response. On Mon, Oct 16, 2017 at 06:08:37PM +0100, Dean Jenkins wrote: > > On 15/10/17 11:40, =?UTF-8?q?Ronald=20Tschal=C3=A4r?= wrote: > >Lastly, the read-lock in the hci_uart_tx_wakeup() callback now needed > >to be

Re: [PATCH] Bluetooth: hci_ldisc: Allow sleeping while proto locks are held.

2017-10-17 Thread Life is hard, and then you die
Hi Dean, apologies for the slow reply, and thank you for the detailed response. On Mon, Oct 16, 2017 at 06:08:37PM +0100, Dean Jenkins wrote: > > On 15/10/17 11:40, =?UTF-8?q?Ronald=20Tschal=C3=A4r?= wrote: > >Lastly, the read-lock in the hci_uart_tx_wakeup() callback now needed > >to be