Re: [PATCH net-next] virtio_net: Fix error code in __virtnet_get_hw_stats()

2024-05-11 Thread Simon Horman
, all, Strictly this is doing two things. But I agree that the "ok" variable in virtnet_get_hw_stats() was very confusing, and I'm not sure how long it would have taken me to grasp the fix without that change being here too. Reviewed-by: Simon Horman

Re: [PATCH net-next v7 1/7] net: introduce rstreason to detect why the RST is sent

2024-04-23 Thread Simon Horman
On Tue, Apr 23, 2024 at 10:17:31AM +0800, Jason Xing wrote: > On Tue, Apr 23, 2024 at 10:14 AM Jason Xing wrote: > > > > Hi Simon, > > > > On Tue, Apr 23, 2024 at 2:28 AM Simon Horman wrote: > > > > > > On Mon, Apr 2

Re: [PATCH net-next v7 1/7] net: introduce rstreason to detect why the RST is sent

2024-04-22 Thread Simon Horman
On Mon, Apr 22, 2024 at 11:01:03AM +0800, Jason Xing wrote: ... > diff --git a/include/net/rstreason.h b/include/net/rstreason.h ... > +/** > + * There are three parts in order: > + * 1) reset reason in MPTCP: only for MPTCP use > + * 2) skb drop reason: relying on drop reasons for such as

Re: [PATCH net-next v5] net/ipv4: add tracepoint for icmp_send

2024-04-13 Thread Simon Horman
On Thu, Apr 11, 2024 at 06:01:54PM +0800, xu.xi...@zte.com.cn wrote: > From: hepeilin nit: it's nicer if this From line matches one of the Signed-off-by lines From: Peilin He > Introduce a tracepoint for icmp_send, which can help users to get more > detail information conveniently when

Re: [RFC PATCH v2 1/4] tracing: add __print_sym() to replace __print_symbolic()

2024-03-27 Thread Simon Horman
On Tue, Mar 26, 2024 at 08:15:56PM +0100, Johannes Berg wrote: > From: Johannes Berg > > The way __print_symbolic() works is limited and inefficient > in multiple ways: > - you can only use it with a static list of symbols, but >e.g. the SKB dropreasons are now a dynamic list > > - it

Re: [PATCH] net: hns3: tracing: fix hclgevf trace event strings

2024-03-19 Thread Simon Horman
On Thu, Mar 14, 2024 at 12:00:27PM -0400, Steven Rostedt wrote: > On Thu, 14 Mar 2024 15:39:28 +0100 > Paolo Abeni wrote: > > > On Wed, 2024-03-13 at 09:34 -0400, Steven Rostedt wrote: ... > > > Fixes: d8355240cf8fb ("net: hns3: add trace event support for PF/VF > > > mailbox") > > > >

Re: [PATCH net] ipvs: Simplify the allocation of ip_vs_conn slab caches

2024-01-19 Thread Simon Horman
On Thu, Jan 18, 2024 at 10:22:05AM +0800, Kunwu Chan wrote: > Hi Simon, > > Thanks for your reply. > > On 2024/1/17 17:29, Simon Horman wrote: > > On Wed, Jan 17, 2024 at 03:20:45PM +0800, Kunwu Chan wrote: > > > Use the new KMEM_CACHE() macro inste

Re: [PATCH net] ipvs: Simplify the allocation of ip_vs_conn slab caches

2024-01-17 Thread Simon Horman
uld probably be targeted at 'nf-next' rather than 'net'. If it is a fix, then I would suggest targeting it at 'nf' and providing a Fixes tag. The above notwithstanding, this looks good to me. Acked-by: Simon Horman > --- > net/netfilter/ipvs/ip_vs_conn.c | 4 +--- > 1 file changed, 1 inse

Re: [PATCH net] net: ipvs: avoid stat macros calls from preemptible context

2024-01-16 Thread Simon Horman
enter (linuxtesting.org). > > Fixes: 8d8e20e2d7bb ("ipvs: Decrement ttl") > Signed-off-by: Fedor Pchelkin Acked-by: Simon Horman

Re: [PATCH] vhost-vdpa: Remove usage of the deprecated ida_simple_xx() API

2024-01-16 Thread Simon Horman
max() is inclusive. So a -1 has been added when needed. > > Signed-off-by: Christophe JAILLET Reviewed-by: Simon Horman

Re: [PATCH V1] net: qrtr: ns: Ignore ENODEV failures in ns

2024-01-04 Thread Simon Horman
On Tue, Dec 26, 2023 at 04:20:03PM -0800, Chris Lew wrote: > > > On 12/23/2023 5:56 AM, Simon Horman wrote: > > [Dropped bjorn.anders...@kernel.org, as the correct address seems > > to be anders...@kernel.org, which is already in the CC list. > > kernel.org

Re: [PATCH V1] net: qrtr: ns: Return 0 if server port is not present

2023-12-23 Thread Simon Horman
ny other error return value. > > Signed-off-by: Sarannya Sasikumar Thanks, I have a suggestion below. But that notwithstanding this change looks good to me. Reviewed-by: Simon Horman > --- > net/qrtr/ns.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > di

Re: [PATCH V1] net: qrtr: ns: Ignore ENODEV failures in ns

2023-12-23 Thread Simon Horman
e things clearer to the reader (me?) if the return type of service_announce_del was updated void. Because as things stand -ENODEV may be returned, which implies something might handle that, even though it doe not. The above notwithstanding, this change looks good to me. Reviewed-by: Simon Horman ...

Re: [PATCH net-next v3 3/3] net: add netmem_ref to skb_frag_t

2023-12-21 Thread Simon Horman
On Wed, Dec 20, 2023 at 01:45:02PM -0800, Mina Almasry wrote: > Use netmem_ref instead of page in skb_frag_t. Currently netmem_ref > is always a struct page underneath, but the abstraction allows efforts > to add support for skb frags not backed by pages. > > There is unfortunately 1 instance

Re: [PATCH] neighbor: tracing: Move pin6 inside CONFIG_IPV6=y section

2023-10-17 Thread Simon Horman
ing section protected by a check > for CONFIG_IPV6. > > Fixes: fc651001d2c5ca4f ("neighbor: Add tracepoint to __neigh_create") > Signed-off-by: Geert Uytterhoeven Reviewed-by: Simon Horman Tested-by: Simon Horman # build-tested

Re: [PATCH v4 net] net: hv_netvsc: fix netvsc_send_completion to avoid multiple message length checks

2023-09-10 Thread Simon Horman
On Thu, Sep 07, 2023 at 12:56:47PM -0700, Sonia Sharma wrote: > From: Sonia Sharma > > The switch statement in netvsc_send_completion() is incorrectly validating > the length of incoming network packets by falling through to the next case. > Avoid the fallthrough. Instead break after a case

Re: [PATCH 08/19] netfilter: ipvs: A spello fix

2021-03-27 Thread Simon Horman
+ netfilter-de...@vger.kernel.org On Sat, Mar 27, 2021 at 04:43:01AM +0530, Bhaskar Chowdhury wrote: > s/registerd/registered/ > > Signed-off-by: Bhaskar Chowdhury Reviewed-by: Simon Horman > --- > net/netfilter/ipvs/ip_vs_core.c | 2 +- > 1 file changed, 1 insert

Re: [PATCH] netfilter: ipvs: A spello fix

2021-03-27 Thread Simon Horman
+ netfilter-de...@vger.kernel.org On Sat, Mar 27, 2021 at 04:42:48AM +0530, Bhaskar Chowdhury wrote: > s/registerd/registered/ > > Signed-off-by: Bhaskar Chowdhury Reviewed-by: Simon Horman > --- > net/netfilter/ipvs/ip_vs_core.c | 2 +- > 1 file changed, 1 insert

Re: [PATCH] drivers: net: ethernet: struct sk_buff is declared duplicately

2021-03-25 Thread Simon Horman
On Thu, Mar 25, 2021 at 02:35:55PM +0800, Wan Jiabing wrote: > struct sk_buff has been declared. Remove the duplicate. > > Signed-off-by: Wan Jiabing Thanks, nice catch. Reviewed-by: Simon Horman

Re: [PATCH RESEND][next] nfp: Fix fall-through warnings for Clang

2021-03-05 Thread Simon Horman
inux/issues/115 > Signed-off-by: Gustavo A. R. Silva Thanks Gustavo, this looks good to me. Acked-by: Simon Horman > --- > drivers/net/ethernet/netronome/nfp/nfp_net_repr.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net

Re: [PATCH] nfp: remove h from printk format specifier

2020-12-24 Thread Simon Horman
if its intentionally that the following was left alone in ethernet/netronome/nfp/nfp_net_ethtool.c:nfp_net_get_nspinfo() snprintf(version, ETHTOOL_FWVERS_LEN, "%hu.%hu" If the above was not intentional then perhaps you could respin with that updated and resubmit when net-next re-opens. Feel free to add: Reviewed-by: Simon Horman

Re: [PATCH] ethernet: select CONFIG_CRC32 as needed

2020-12-04 Thread Simon Horman
+ > drivers/net/ethernet/rocker/Kconfig | 1 + > 10 files changed, 10 insertions(+) Hi Arnd, I'm slightly curious to know how you configured the kernel to build the Netronome NFP driver but not CRC32 but nonetheless I have no objection to this change. For the Netronome portion: Acked-by: Simon Horman

Re: [PATCH][next] nfp: tls: Fix unreachable code issue

2020-11-17 Thread Simon Horman
of macro 'fallthrough' > 299 | fallthrough; > | ^~~ > > Reported-by: kernel test robot > Signed-off-by: Gustavo A. R. Silva Reviewed-by: Simon Horman

Re: [PATCH] nfp: Fix passing zero to 'PTR_ERR'

2020-11-12 Thread Simon Horman
Thanks, this does indeed seem to be the case. Reviewed-by: Simon Horman

Re: [PATCH] ipvs: adjust the debug order of src and dst

2020-09-24 Thread Simon Horman
On Wed, Sep 23, 2020 at 01:49:59PM +0800, longguang.yue wrote: > From: ylg > > adjust the debug order of src and dst when tcp state changes > > Signed-off-by: ylg Hi, This sounds reasonable to me but please provide your real name in the Signed-off-by name, which should be consistent with the

Re: [PATCH net-next] ipvs: Remove unused macros

2020-09-21 Thread Simon Horman
On Fri, Sep 18, 2020 at 09:16:56PM +0800, YueHaibing wrote: > They are not used since commit e4ff67513096 ("ipvs: add > sync_maxlen parameter for the sync daemon") > > Signed-off-by: YueHaibing Thanks, this look good to me. Acked-by: Simon Horman Pablo, please con

Re: [oss-drivers] [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

2020-09-17 Thread Simon Horman
On Wed, Sep 09, 2020 at 01:06:39PM -0700, Joe Perches wrote: > fallthrough to a separate case/default label break; isn't very readable. > > Convert pseudo-keyword fallthrough; statements to a simple break; when > the next label is case or default and the only statement in the next > label block

Re: [PATCH] drivers/net/ethernet: fix a typo for stmmac_pltfr_suspend

2020-09-09 Thread Simon Horman
Hi Wang, On Wed, Sep 09, 2020 at 08:19:21PM +0800, Wang Qing wrote: > Change the comment typo: "direcly" -> "directly". > > Signed-off-by: Wang Qing > --- > drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) git log tells me that the

Re: [PATCH] net/netfilter: fix a typo for nf_conntrack_proto_dccp.c

2020-09-09 Thread Simon Horman
Hi Wang, On Wed, Sep 09, 2020 at 08:12:44PM +0800, Wang Qing wrote: > Change the comment typo: "direcly" -> "directly". > > Signed-off-by: Wang Qing git log tells me that the correct prefix for this patch is "netfilter: conntrack:" rather than "net/netfilter:" Probably this patch is

Re: [PATCH net-next v2 3/3] ipmr: Use full VIF ID in netlink cache reports

2020-09-09 Thread Simon Horman
On Tue, Sep 08, 2020 at 10:04:08AM +1200, Paul Davey wrote: > Insert the full 16 bit VIF ID into ipmr Netlink cache reports. > > The VIF_ID attribute has 32 bits of space so can store the full VIF ID > extracted from the high and low byte fields in the igmpmsg. > > Signed-off-by: Paul Davey >

Re: [oss-drivers] [PATCH 16/20] ethernet: netronome: convert tasklets to use new tasklet_setup() API

2020-08-17 Thread Simon Horman
ned-off-by: Romain Perier > Signed-off-by: Allen Pais Reviewed-by: Simon Horman But: This series should be targeted at net-next, and thus have net-next in its subject [PATCH net-next x/y] ... And it should be posted when net-next is open: it is currently closed. http://v

Re: [Linux-kernel-mentees] [PATCH net-next v2] ipvs: Fix uninit-value in do_ip_vs_set_ctl()

2020-08-11 Thread Simon Horman
Anastasov Pablo, could you consider this for nf-next or should we repost when net-next re-opens? Reviewed-by: Simon Horman

Re: [PATCH] Replace HTTP links with HTTPS ones: kdump

2020-07-01 Thread Simon Horman
: > For each line: > If doesn't contain `\bxmlns\b`: > For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`: > If both the HTTP and HTTPS versions > return 200 OK and serve the same content: > Replace HTTP with HTTPS. > > Signed-off-by: Alexander A. Klimov Reviewed-by: Simon Horman

Re: [v2,net-next] net: qos offload add flow status with dropped count

2020-06-19 Thread Simon Horman
| 3 ++- > 25 files changed, 60 insertions(+), 50 deletions(-) Netronome portion: Reviewed-by: Simon Horman

Re: [ovs-dev] [PATCH 1/1] openvswitch: fix infoleak in conntrack

2020-06-16 Thread Simon Horman
On Mon, Jun 15, 2020 at 07:13:01PM -0700, Xidong Wang wrote: > From: xidongwang > > The stack object “zone_limit” has 3 members. In function > ovs_ct_limit_get_default_limit(), the member "count" is > not initialized and sent out via “nla_put_nohdr”. Hi Xidong, thanks for your patch. It

Re: [PATCH] iommu/renesas: fix unused-function warning

2020-05-12 Thread Simon Horman
gt; Change the #ifdef to an equivalent IS_ENABLED(). > > Fixes: 6580c8a78424 ("iommu/renesas: Convert to probe/release_device() > call-backs") > Signed-off-by: Arnd Bergmann Reviewed-by: Simon Horman > --- > drivers/iommu/ipmmu-vmsa.c | 7 ++- > 1 file changed, 2 ins

Re: [PATCH 37/38] docs: networking: convert ipvs-sysctl.txt to ReST

2020-04-28 Thread Simon Horman
gt; Signed-off-by: Mauro Carvalho Chehab Acked-by: Simon Horman

Re: [PATCH net-next 4/4] bonding: balance ICMP echoes in layer3+4 mode

2019-10-23 Thread Simon Horman
On Wed, Oct 23, 2019 at 06:58:16PM +0200, Matteo Croce wrote: > On Wed, Oct 23, 2019 at 12:01 PM Simon Horman > wrote: > > > > On Mon, Oct 21, 2019 at 10:09:48PM +0200, Matteo Croce wrote: > > > The bonding uses the L4 ports to balance flows between slaves. > > &g

Re: [PATCH net-next 3/4] flow_dissector: extract more ICMP information

2019-10-23 Thread Simon Horman
On Wed, Oct 23, 2019 at 12:53:37PM +0200, Matteo Croce wrote: > On Wed, Oct 23, 2019 at 12:00 PM Simon Horman > wrote: > > On Mon, Oct 21, 2019 at 10:09:47PM +0200, Matteo Croce wrote: > > > + switch (ih->type) { > > > + case ICMP_ECHO: > > > +

Re: [RFC 1/2] vhost: IFC VF hardware operation layer

2019-10-23 Thread Simon Horman
On Wed, Oct 23, 2019 at 06:36:13PM +0800, Jason Wang wrote: > > On 2019/10/23 下午6:13, Simon Horman wrote: > > On Tue, Oct 22, 2019 at 09:32:36AM +0800, Jason Wang wrote: > > > On 2019/10/22 上午12:31, Simon Horman wrote: > > > > On Mon, Oct 21, 2019 at 05:5

Re: [RFC 1/2] vhost: IFC VF hardware operation layer

2019-10-23 Thread Simon Horman
On Tue, Oct 22, 2019 at 09:32:36AM +0800, Jason Wang wrote: > > On 2019/10/22 上午12:31, Simon Horman wrote: > > On Mon, Oct 21, 2019 at 05:55:33PM +0800, Zhu, Lingshan wrote: > > > On 10/16/2019 5:53 PM, Simon Horman wrote: > > > > Hi Zhu, >

Re: [PATCH net-next 4/4] bonding: balance ICMP echoes in layer3+4 mode

2019-10-23 Thread Simon Horman
On Mon, Oct 21, 2019 at 10:09:48PM +0200, Matteo Croce wrote: > The bonding uses the L4 ports to balance flows between slaves. > As the ICMP protocol has no ports, those packets are sent all to the > same device: > > # tcpdump -qltnni veth0 ip |sed 's/^/0: /' & > # tcpdump -qltnni veth1

Re: [PATCH net-next 3/4] flow_dissector: extract more ICMP information

2019-10-23 Thread Simon Horman
On Mon, Oct 21, 2019 at 10:09:47PM +0200, Matteo Croce wrote: > The ICMP flow dissector currently parses only the Type and Code fields. > Some ICMP packets (echo, timestamp) have a 16 bit Identifier field which > is used to correlate packets. > Add such field in flow_dissector_key_icmp and replace

Re: [PATCH net-next 2/4] flow_dissector: skip the ICMP dissector for non ICMP packets

2019-10-23 Thread Simon Horman
ICMP packets. > > Signed-off-by: Matteo Croce Reviewed-by: Simon Horman > --- > net/core/flow_dissector.c | 34 +- > 1 file changed, 25 insertions(+), 9 deletions(-) > > diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c &

Re: [PATCH net-next 1/4] flow_dissector: add meaningful comments

2019-10-23 Thread Simon Horman
On Mon, Oct 21, 2019 at 10:09:45PM +0200, Matteo Croce wrote: > Documents two piece of code which can't be understood at a glance. > > Signed-off-by: Matteo Croce Reviewed-by: Simon Horman > --- > include/net/flow_dissector.h | 1 + > net/core/flow_dissector.c| 6

Re: [RFC 1/2] vhost: IFC VF hardware operation layer

2019-10-21 Thread Simon Horman
On Mon, Oct 21, 2019 at 05:55:33PM +0800, Zhu, Lingshan wrote: > > On 10/16/2019 5:53 PM, Simon Horman wrote: > > Hi Zhu, > > > > thanks for your patch. > > > > On Wed, Oct 16, 2019 at 09:10:40AM +0800, Zhu Lingshan wrote: ... > > > +static void i

Re: [PATCH] RFC: Bluetooth: missed cpu_to_le16 conversion in hci_init4_req

2019-10-17 Thread Simon Horman
On Wed, Oct 16, 2019 at 08:42:48PM +0200, Marcel Holtmann wrote: > Hi Simon, > > >> It looks like in hci_init4_req() the request is being > >> initialised from cpu-endian data but the packet is specified > >> to be little-endian. This causes an warning from sparse due > >> to __le16 to u16

Re: [PATCH] usb: renesas_usbhs: fix __le16 warnings

2019-10-17 Thread Simon Horman
On Thu, Oct 17, 2019 at 08:57:26AM +0200, Geert Uytterhoeven wrote: > Hi Shimoda-san, Simon, > > On Thu, Oct 17, 2019 at 4:18 AM Yoshihiro Shimoda > wrote: > > > From: Simon Horman, Sent: Wednesday, October 16, 2019 9:27 PM > > > > > > diff --git a/driver

Re: [PATCH] usb: renesas_usbhs: fix __le16 warnings

2019-10-16 Thread Simon Horman
ument 3 (different base types) > drivers/usb/renesas_usbhs/common.c:175:39:expected unsigned short > [usertype] data > > Note. I belive this to be correct, and should be a no-op on arm. > > Signed-off-by: Ben Dooks > --- > Cc: Greg Kroah-Hartman > Cc: Yoshihiro Shimoda

Re: [PATCH] RFC: Bluetooth: missed cpu_to_le16 conversion in hci_init4_req

2019-10-16 Thread Simon Horman
On Wed, Oct 16, 2019 at 12:39:43PM +0100, Ben Dooks (Codethink) wrote: > It looks like in hci_init4_req() the request is being > initialised from cpu-endian data but the packet is specified > to be little-endian. This causes an warning from sparse due > to __le16 to u16 conversion. > > Fix this

[PATCH] MAINTAINERS: Add Marek and Shimoda-san as R-Car PCIE co-maintainers

2019-10-16 Thread Simon Horman
At the end of the v5.3 upstream development cycle I stepped down from my role at Renesas. Pass maintainership of the R-Car PCIE to Marek and Shimoda-san. Signed-off-by: Simon Horman --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS

Re: [RFC 2/2] vhost: IFC VF vdpa layer

2019-10-16 Thread Simon Horman
Hi Zhu, thanks for your patch. On Wed, Oct 16, 2019 at 09:03:18AM +0800, Zhu Lingshan wrote: > This commit introduced IFC VF operations for vdpa, which complys to > vhost_mdev interfaces, handles IFC VF initialization, > configuration and removal. > > Signed-off-by: Zhu Lingshan > --- >

Re: [RFC 1/2] vhost: IFC VF hardware operation layer

2019-10-16 Thread Simon Horman
Hi Zhu, thanks for your patch. On Wed, Oct 16, 2019 at 09:10:40AM +0800, Zhu Lingshan wrote: > This commit introduced ifcvf_base layer, which handles IFC VF NIC > hardware operations and configurations. > > Signed-off-by: Zhu Lingshan > --- > drivers/vhost/ifcvf/ifcvf_base.c | 390 >

Re: [PATCH net-next] can: ifi: use devm_platform_ioremap_resource() to simplify code

2019-10-15 Thread Simon Horman
On Tue, Oct 15, 2019 at 10:20:46PM +0800, YueHaibing wrote: > Use devm_platform_ioremap_resource() to simplify the code a bit. > This is detected by coccinelle. > > Signed-off-by: YueHaibing Reviewed-by: Simon Horman > --- > drivers/net/can/ifi_canfd/ifi_canfd.c | 4 +--- &g

Re: [PATCH] can: m_can: fix boolreturn.cocci warnings

2019-10-15 Thread Simon Horman
On Tue, Oct 15, 2019 at 06:37:54AM +, Jeroen Hofstee wrote: > Hi, > > On 10/15/19 7:57 AM, Simon Horman wrote: > > On Mon, Oct 14, 2019 at 11:04:28PM +0800, kbuild test robot wrote: > >> From: kbuild test robot > >> > >> drivers/net/can/m_ca

Re: [PATCH] can: m_can: fix boolreturn.cocci warnings

2019-10-14 Thread Simon Horman
On Mon, Oct 14, 2019 at 11:04:28PM +0800, kbuild test robot wrote: > From: kbuild test robot > > drivers/net/can/m_can/m_can.c:783:9-10: WARNING: return of 0/1 in function > 'is_protocol_err' with return type bool > > Return statements in functions returning bool should use > true/false

Re: [PATCH] MAINTAINERS: Remove Simon as Renesas SoC Co-Maintainer

2019-10-11 Thread Simon Horman
nd add an entry to the CREDITS file to honor his > work. > > Signed-off-by: Geert Uytterhoeven Acked-by: Simon Horman > --- > CREDITS | 4 > MAINTAINERS | 4 > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/CREDITS b/CREDITS > in

Re: [PATCH v6 0/3] selftests: netfilter: introduce test cases for ipvs

2019-10-11 Thread Simon Horman
On Thu, Oct 10, 2019 at 10:50:52PM +0800, Haishuang Yan wrote: > This series patch include test cases for ipvs. > > The test topology is who as below: > +--+ > | | | > |

Re: [PATCH v5 1/3] selftests: netfilter: add ipvs test script

2019-10-10 Thread Simon Horman
Haishuang Yan > --- > v5: use cmp to compare two file contents suggested by Simon Horman > v4: use #!/bin/bash -p suggested by Duncan Roe > v3: use bash style > v2: optimize test script > --- > tools/testing/selftests/netfilter/Makefile | 2 +-

Re: [PATCH v4 1/3] selftests: netfilter: add ipvs test script

2019-10-08 Thread Simon Horman
On Sat, Oct 05, 2019 at 10:37:43PM +0800, Haishuang Yan wrote: > Test virutal server via directing routing for IPv4. > > Tested: > > # selftests: netfilter: ipvs.sh > # Testing DR mode... > # ipvs.sh: PASS > ok 6 selftests: netfilter: ipvs.sh > > Signed-off-by: Haishuang Yan > --- > v4: use

Re: [PATCH] r8152: Set macpassthru in reset_resume callback

2019-10-05 Thread Simon Horman
On Sat, Oct 05, 2019 at 07:54:15PM +0800, Kai-Heng Feng wrote: > > > > On Oct 5, 2019, at 19:46, Simon Horman wrote: > > > > On Fri, Oct 04, 2019 at 08:51:04PM +0800, Kai-Heng Feng wrote: > >> r8152 may fail to establish network connection afte

Re: [PATCH] r8152: Set macpassthru in reset_resume callback

2019-10-05 Thread Simon Horman
On Fri, Oct 04, 2019 at 08:51:04PM +0800, Kai-Heng Feng wrote: > r8152 may fail to establish network connection after resume from system > suspend. > > If the USB port connects to r8152 lost its power during system suspend, > the MAC address was written before is lost. The reason is that The MAC

Re: [PATCH v3 0/3] selftests: netfilter: introduce test cases for ipvs

2019-10-02 Thread Simon Horman
On Wed, Oct 02, 2019 at 11:27:26AM +1000, Duncan Roe wrote: > On Tue, Oct 01, 2019 at 09:34:13PM +0300, Julian Anastasov wrote: > > > > Hello, > > > > On Tue, 1 Oct 2019, Haishuang Yan wrote: > > > > > This series patch include test cases for ipvs. > > > > > > The test topology is who as

Re: [PATCH v2 0/2] ipvs: speedup ipvs netns dismantle

2019-10-01 Thread Simon Horman
On Mon, Sep 30, 2019 at 10:08:23PM +0300, Julian Anastasov wrote: > > Hello, > > On Fri, 27 Sep 2019, Haishuang Yan wrote: > > > Implement exit_batch() method to dismantle more ipvs netns > > per round. > > > > Tested: > > $ cat add_del_unshare.sh > > #!/bin/bash > > > > for i in `seq

Re: [PATCH v2 1/3] selftests: netfilter: add ipvs test script

2019-10-01 Thread Simon Horman
On Fri, Sep 27, 2019 at 02:21:04PM +0800, Haishuang Yan wrote: > Test virutal server via directing routing for IPv4. > > Tested: > > # selftests: netfilter: ipvs.sh > # Testing DR mode... > # ipvs.sh: PASS > ok 6 selftests: netfilter: ipvs.sh > > Signed-off-by: Haishuang Yan > --- > v2:

Re: [PATCH] soc: renesas: rcar-sysc: fix memory leak in rcar_sysc_pd_init

2019-09-26 Thread Simon Horman
Ni Navid, thanks for your patch. On Wed, Sep 25, 2019 at 04:03:53PM -0500, Navid Emamdoost wrote: > In rcar_sysc_pd_init when looping over info->areas errors may happen but > the error handling path does not clean up the intermediate allocated > memories. > > This patch changes the error

Re: [PATCH v7 1/7] nfc: pn533: i2c: "pn532" as dt compatible string

2019-09-18 Thread Simon Horman
On Tue, Sep 10, 2019 at 11:31:21AM +0200, Lars Poeschel wrote: > It is favourable to have one unified compatible string for devices that > have multiple interfaces. So this adds simply "pn532" as the devicetree > binding compatible string and makes a note that the old ones are > deprecated. Do

Re: [PATCH] arm64: dts: renesas: r8a77970: Fix PWM3

2019-09-13 Thread Simon Horman
: r8a779{7|8}0: add PWM support") > Signed-off-by: Kieran Bingham Reviewed-by: Simon Horman > --- > arch/arm64/boot/dts/renesas/r8a77970.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/renesas/r8a77970.dtsi > b/

Re: [PATCH] arm: dts: renesas: r8a77980: Remove r8a77970 DU compatible

2019-09-13 Thread Simon Horman
ned-off-by: Kieran Bingham Reviewed-by: Simon Horman > --- > Please note, this patch should not be integrated until the renesas,du-r8a77980 > compatible string makes it into the DU [0]. > > [0] > https://lore.kernel.org/linux-renesas-soc/a9cc2193-0a18-0490-c273-c64bd7099...@id

Re: [PATCH 5/6] dt-bindings: timer: renesas: tmu: Document r8a774a1 bindings

2019-09-02 Thread Simon Horman
On Fri, Aug 30, 2019 at 10:37:54AM +, Fabrizio Castro wrote: > Dear All, > > This patch has been reviewed by Geert, Simon, and Rob, so I think it's ok to > apply. > Is anybody willing to take this patch? <2c> I think Geert can take this > Thanks, > Fab > > > From: Fabrizio Castro > >

Re: [PATCH] thermal: rcar_gen3_thermal: Fix Wshift-negative-value

2019-08-31 Thread Simon Horman
gt; Try developing the macro with the coef.a2 computation ... > > > > > > The code quality of this driver could be better, it deserves a rework > > > IMHO ... > > > > > > I suggest to revert: > > > > > > 4eb39f79ef443fa5

Re: [PATCH] ARM: ARM_ERRATA_775420: Spelling s/date/data/

2019-08-31 Thread Simon Horman
On Wed, Aug 28, 2019 at 03:31:51PM +0200, Geert Uytterhoeven wrote: > Caching dates is never a good idea ;-) > > Signed-off-by: Geert Uytterhoeven Reviewed-by: Simon Horman > --- > arch/arm/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --

Re: [PATCH v3 3/3] clocksource/drivers/ostm: Use unique device name instead of ostm

2019-08-21 Thread Simon Horman
On Fri, Aug 16, 2019 at 03:18:06PM +0200, Geert Uytterhoeven wrote: > Hi Simon, > > On Fri, Aug 16, 2019 at 3:11 PM Simon Horman wrote: > > On Wed, Aug 07, 2019 at 10:46:35AM +0200, Geert Uytterhoeven wrote: > > > Currently all OSTM devices are called "o

Re: [PATCH 6/7] clocksource/drivers/sh_cmt: r8a7740 and sh73a0 SoC-specific match

2019-08-20 Thread Simon Horman
On Tue, Aug 20, 2019 at 09:34:13PM +0900, Magnus Damm wrote: > Hi Simon, > > On Wed, Jul 24, 2019 at 8:12 PM Simon Horman wrote: > > > > On Thu, Jul 18, 2019 at 08:45:24PM +0900, Magnus Damm wrote: > > > From: Magnus Damm > > > > > > Add SoC-

Re: [PATCH v3 2/3] clocksource/drivers/renesas-ostm: Fix probe error path

2019-08-16 Thread Simon Horman
. Split the single cleanup block in separate phases, to avoid > > clk_put() calling WARN() when passed an error pointer. > > Does it make sense to convert to timer-of API? I don't have an opinion on that at this time, but as an improvement this patch looks good to me. Reviewed-by: Simon Horman > > Signed-off-by: Geert Uytterhoeven

Re: [PATCH v3 3/3] clocksource/drivers/ostm: Use unique device name instead of ostm

2019-08-16 Thread Simon Horman
On Fri, Aug 16, 2019 at 03:11:29PM +0200, Simon Horman wrote: > On Wed, Aug 07, 2019 at 10:46:35AM +0200, Geert Uytterhoeven wrote: > > Currently all OSTM devices are called "ostm", also in kernel messages. > > > > As there can be multiple instances in an SoC, this

Re: [PATCH v3 3/3] clocksource/drivers/ostm: Use unique device name instead of ostm

2019-08-16 Thread Simon Horman
On Wed, Aug 07, 2019 at 10:46:35AM +0200, Geert Uytterhoeven wrote: > Currently all OSTM devices are called "ostm", also in kernel messages. > > As there can be multiple instances in an SoC, this can confuse the user. > Hence construct a unique name from the DT node name, like is done for >

Re: [PATCH v3 1/3] clocksource/drivers/renesas-ostm: Use DIV_ROUND_CLOSEST() helper

2019-08-16 Thread Simon Horman
On Wed, Aug 07, 2019 at 10:46:33AM +0200, Geert Uytterhoeven wrote: > Use the DIV_ROUND_CLOSEST() helper instead of open-coding the same > operation. > > Signed-off-by: Geert Uytterhoeven Reviewed-by: Simon Horman > --- > v3: > - New. > --- > drivers/clocksource

Re: [PATCH] MAINTAINERS: Add Geert as Renesas SoC Co-Maintainer

2019-08-01 Thread Simon Horman
MAINTAINERS | 4 > 1 file changed, 4 insertions(+) For the record: Acked-by: Simon Horman > diff --git a/MAINTAINERS b/MAINTAINERS > index 6426db5198f05377..6de667021591fb52 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -2155,10 +2155,12 @@ F: > Documentati

Re: [PATCH 7/7] clocksource/drivers/sh_cmt: Document "cmt-48" as deprecated

2019-07-24 Thread Simon Horman
top-down based on available data sheet > information and make use of part numbers in the DT compat string. > > In case of the only in-tree users r8a7740 and sh73a0 the compat strings > "renesas,r8a7740-cmt1" and "renesas,sh73a0-cmt1" may be used instead. > > Signed-off-by: Magnus Damm Reviewed-by: Simon Horman

Re: [PATCH 5/7] dt-bindings: timer: renesas, cmt: Update R-Car Gen3 CMT1 usage

2019-07-24 Thread Simon Horman
on by describing R-Car Gen3 and > RZ/G2 CMT1 as "48-bit CMT devices". > > Signed-off-by: Magnus Damm > Reviewed-by: Geert Uytterhoeven > Reviewed-by: Rob Herring Reviewed-by: Simon Horman

Re: [PATCH 2/7] dt-bindings: timer: renesas, cmt: Update CMT1 on sh73a0 and r8a7740

2019-07-24 Thread Simon Horman
am > SoCs will now also be used by r8a7740 and sh73a0. The DT binding "cmt-48" > is removed from the DT binding documentation, however software support for > this deprecated binding will still remain in the CMT driver for some time. > > Signed-off-by: Magnus Damm >

Re: [PATCH 3/7] dt-bindings: timer: renesas, cmt: Add CMT0 and CMT1 to r8a7792

2019-07-24 Thread Simon Horman
: Rob Herring Reviewed-by: Simon Horman

Re: [PATCH 4/7] dt-bindings: timer: renesas, cmt: Add CMT0 and CMT1 to r8a77995

2019-07-24 Thread Simon Horman
: Rob Herring Reviewed-by: Simon Horman

Re: [PATCH 1/7] dt-bindings: timer: renesas, cmt: Add CMT0234 to sh73a0 and r8a7740

2019-07-24 Thread Simon Horman
; > Because of this one unique compat string per CMT device is selected. > > Signed-off-by: Magnus Damm > Reviewed-by: Rob Herring Reviewed-by: Simon Horman

Re: [PATCH 6/7] clocksource/drivers/sh_cmt: r8a7740 and sh73a0 SoC-specific match

2019-07-24 Thread Simon Horman
cmt-48-r8a7740" > - "renesas,cmt-48" > in favour for the now commonly used format "renesas,-" > > Signed-off-by: Magnus Damm Reviewed-by: Simon Horman > --- > > drivers/clocksource/sh_cmt.c |8 > 1 file changed, 8 insertions(+) > &g

Re: [PATCH] ipvs: remove unnecessary space

2019-07-10 Thread Simon Horman
On Wed, Jul 10, 2019 at 03:45:52PM +0800, yangxingwu wrote: > this patch removes the extra space. > > Signed-off-by: yangxingwu Thanks, this looks good to me. Acked-by: Simon Horman Pablo, please consider including this in nf-next. > --- > net/netfilter/ipvs/ip_vs_mh.c | 4

Re: [PATCH] ipvs: Delete some unused space characters in Kconfig

2019-07-10 Thread Simon Horman
-- > > This is my first patch to the Linux kernel, so please forgive > me if anything went wrong. Acked-by: Simon Horman Thanks Hu, this looks good to me. Pablo, please consider this for inclusion in nf-next. > > net/netfilter/ipvs/Kconfig | 10 +- > 1 file changed,

Re: [PATCH v2] dt-binding: mmc: rename tmio_mmc.txt to renesas,sdhi.txt

2019-07-02 Thread Simon Horman
ternals such as how the drivers are probed, how platform data are > handed off, etc. > > [1] https://www.spinics.net/lists/linux-mmc/msg46952.html > > Signed-off-by: Masahiro Yamada Reviewed-by: Simon Horman > --- > > Changes in v2: > - Rename to renesas,sdhi.txt inst

Re: [PATCH] mmc: remove another TMIO MMC variant usdhi6rol0.c

2019-06-21 Thread Simon Horman
On Fri, Jun 21, 2019 at 03:05:11PM +0900, Masahiro Yamada wrote: > Renesas upstreamed two different drivers for (almost) the same hardware. > usdhi6rol0.c is (what we call) "TMIO MMC", which I am 100% sure from the > the register macros in usdhi6rol0.c. > > As commit b6147490e6aa ("mmc: tmio:

Re: [PATCH] dt-binding: mmc: rename tmio_mmc.txt to renesas_sdhi.txt

2019-06-21 Thread Simon Horman
On Fri, Jun 21, 2019 at 12:50:10PM +0900, Masahiro Yamada wrote: > As commit b6147490e6aa ("mmc: tmio: split core functionality, DMA and > MFD glue") said, these MMC controllers use the IP from Panasonic. > > TMIO (Toshiba Mobile IO) MMC was the first upstreamed user of this IP. > The common

Re: [PATCH repost] dt-bindings: timer: renesas, cmt: Document r8a779{5|65|90} CMT support

2019-06-17 Thread Simon Horman
On Thu, Jun 13, 2019 at 01:09:08PM +0200, Daniel Lezcano wrote: > On 13/06/2019 12:12, Simon Horman wrote: > > On Thu, May 09, 2019 at 02:29:49PM +0200, Simon Horman wrote: > >> From: Cao Van Dong > >> > >> Document SoC specific bindings for R-Car H3/M3-N/E3

Re: [PATCH repost 0/5] Repost CAN and CANFD dt-bindings

2019-06-13 Thread Simon Horman
On Wed, Jun 12, 2019 at 09:49:08AM -0700, David Miller wrote: > From: Simon Horman > Date: Wed, 12 Jun 2019 14:20:20 +0200 > > > are you comfortable with me taking these patches > > through the renesas tree? Or perhaps should they be reposted > > to yo

Re: [PATCH v3] phy: renesas: rcar-gen3-usb2: fix imbalance powered flag

2019-06-13 Thread Simon Horman
517af ]--- > [ 56.273290] phy phy-ee080200.usb-phy.10: phy poweroff failed --> -5 > > Reported-by: Geert Uytterhoeven > Fixes: 549b6b55b005 ("phy: renesas: rcar-gen3-usb2: enable/disable > independent irqs") > Signed-off-by: Yoshihiro Shimoda > Reviewed-by: Geert Uytterhoeven > Tested-by: Geert Uytterhoeven Reviewed-by: Simon Horman

Re: [PATCH 05/34] leds: leds-tca6507: simplify getting the adapter of a client

2019-06-13 Thread Simon Horman
On Sat, Jun 08, 2019 at 12:55:44PM +0200, Wolfram Sang wrote: > We have a dedicated pointer for that, so use it. Much easier to read and > less computation involved. > > Signed-off-by: Wolfram Sang Reviewed-by: Simon Horman > --- > > Please apply to your subsystem tre

Re: [PATCH 01/34] clk: clk-cdce706: simplify getting the adapter of a client

2019-06-13 Thread Simon Horman
On Sat, Jun 08, 2019 at 12:55:40PM +0200, Wolfram Sang wrote: > We have a dedicated pointer for that, so use it. Much easier to read and > less computation involved. > > Signed-off-by: Wolfram Sang Reviewed-by: Simon Horman > --- > > Please apply to your subsystem tree.

Re: [PATCH 10/34] media: i2c: ov2640: simplify getting the adapter of a client

2019-06-13 Thread Simon Horman
On Sat, Jun 08, 2019 at 12:55:49PM +0200, Wolfram Sang wrote: > We have a dedicated pointer for that, so use it. Much easier to read and > less computation involved. > > Signed-off-by: Wolfram Sang Reviewed-by: Simon Horman > --- > > Please apply to your subsystem tree

Re: [PATCH 07/34] media: i2c: mt9m001: simplify getting the adapter of a client

2019-06-13 Thread Simon Horman
On Sat, Jun 08, 2019 at 12:55:46PM +0200, Wolfram Sang wrote: > We have a dedicated pointer for that, so use it. Much easier to read and > less computation involved. > > Signed-off-by: Wolfram Sang Reviewed-by: Simon Horman

Re: [PATCH 08/34] media: i2c: mt9m111: simplify getting the adapter of a client

2019-06-13 Thread Simon Horman
On Sat, Jun 08, 2019 at 12:55:47PM +0200, Wolfram Sang wrote: > We have a dedicated pointer for that, so use it. Much easier to read and > less computation involved. > > Signed-off-by: Wolfram Sang Reviewed-by: Simon Horman > --- > > Please apply to your subsystem tree

Re: [PATCH 06/34] media: i2c: ak881x: simplify getting the adapter of a client

2019-06-13 Thread Simon Horman
On Sat, Jun 08, 2019 at 12:55:45PM +0200, Wolfram Sang wrote: > We have a dedicated pointer for that, so use it. Much easier to read and > less computation involved. > > Signed-off-by: Wolfram Sang Reviewed-by: Simon Horman > --- > > Please apply to your subsystem tree

  1   2   3   4   5   6   7   8   9   10   >