Re: [PATCH v2] arm64: dts: qcom: Update iommu property for simultaneous playback

2021-04-09 Thread Srinivasa Rao Mandadapu
Hi Stephen. Thanks for your time!!! On 4/9/2021 10:31 PM, Stephen Boyd wrote: Quoting Srinivasa Rao Mandadapu (2021-04-06 09:33:30) From: V Sujith Kumar Reddy Update iommu property in lpass cpu node for supporting simultaneous playback on headset and speaker. Signed-off-by: V Sujith Kumar

[PATCH v2] arm64: dts: qcom: Update iommu property for simultaneous playback

2021-04-06 Thread Srinivasa Rao Mandadapu
From: V Sujith Kumar Reddy Update iommu property in lpass cpu node for supporting simultaneous playback on headset and speaker. Signed-off-by: V Sujith Kumar Reddy Signed-off-by: Srinivasa Rao Mandadapu --- Changes since v1: -- Commit messge header change arch/arm64/boot/dts/qcom/sc7180

[PATCH v7 2/2] arm64: dts: qcom: Add sound node for sc7180-trogdor-coachz

2021-03-13 Thread Srinivasa Rao Mandadapu
This is a trgodor variant, required to have sound node variable for coachz specific platform. Signed-off-by: Srinivasa Rao Mandadapu Reviewed-by: Stephen Boyd --- arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm64/boot

[PATCH v7 1/2] arm64: dts: qcom: sc7180-trogdor: Add lpass dai link for I2S driver

2021-03-13 Thread Srinivasa Rao Mandadapu
From: Ajit Pandey Add dai link for supporting lpass I2S driver, which is used for audio capture and playback. Add lpass-cpu node with pin controls and i2s primary and secondary dai-links Signed-off-by: Ajit Pandey Signed-off-by: V Sujith Kumar Reddy Signed-off-by: Srinivasa Rao Mandadapu

[PATCH v7 0/2] Qualcomm's lpass device tree changes for I2s dai

2021-03-13 Thread Srinivasa Rao Mandadapu
): arm64: dts: qcom: sc7180-trogdor: Add lpass dai link for I2S driver Srinivasa Rao Mandadapu (1): arm64: dts: qcom: Add sound node for sc7180-trogdor-coachz .../boot/dts/qcom/sc7180-trogdor-coachz.dtsi | 10 arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 58 +++ 2 files

Re: [PATCH v6 1/2] arm64: dts: qcom: sc7180-trogdor: Add lpass dai link for I2S driver

2021-03-13 Thread Srinivasa Rao Mandadapu
Hi Stephen, Thanks for Your Time and Inputs!!! On 3/14/2021 2:26 AM, Stephen Boyd wrote: Quoting Srinivasa Rao Mandadapu (2021-03-12 21:46:53) From: Ajit Pandey Add dai link for supporting lpass I2S driver, which is used for audio capture and playback. Add lpass-cpu node with pin controls

[PATCH v6 1/2] arm64: dts: qcom: sc7180-trogdor: Add lpass dai link for I2S driver

2021-03-12 Thread Srinivasa Rao Mandadapu
From: Ajit Pandey Add dai link for supporting lpass I2S driver, which is used for audio capture and playback. Add lpass-cpu node with pin controls and i2s primary and secondary dai-links Signed-off-by: Ajit Pandey Signed-off-by: V Sujith Kumar Reddy Signed-off-by: Srinivasa Rao Mandadapu

[PATCH v6 2/2] arm64: dts: qcom: Add sound node for sc7180-trogdor-coachz

2021-03-12 Thread Srinivasa Rao Mandadapu
This is a trgodor variant, required to have sound node variable for coachz specific platform. Signed-off-by: Srinivasa Rao Mandadapu --- arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor

[PATCH v6 0/2] Qualcomm's lpass device tree changes for I2s dai

2021-03-12 Thread Srinivasa Rao Mandadapu
link for I2S driver Srinivasa Rao Mandadapu (1): arm64: dts: qcom: Add sound node for sc7180-trogdor-coachz .../boot/dts/qcom/sc7180-trogdor-coachz.dtsi | 10 arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 58 +++ 2 files changed, 68 insertions(+) -- Qualcomm India

Re: [PATCH v5 2/2] arm64: dts: qcom: Add sound node for sc7180-trogdor-coachz

2021-03-12 Thread Srinivasa Rao Mandadapu
Hi Doug, Thanks for your time and inputs!!! On 3/13/2021 2:58 AM, Doug Anderson wrote: Hi, On Fri, Mar 12, 2021 at 8:07 AM Srinivasa Rao Mandadapu wrote: This is a trgodor variant, required to have sound node variable for coachz specific platform. Signed-off-by: Srinivasa Rao Mandadapu

Re: [PATCH v5 1/2] arm64: dts: qcom: sc7180-trogdor: Add lpass dai link for I2S driver

2021-03-12 Thread Srinivasa Rao Mandadapu
Hi Doug, Thanks for your time and inputs!!! On 3/13/2021 2:58 AM, Doug Anderson wrote: Hi, On Fri, Mar 12, 2021 at 8:06 AM Srinivasa Rao Mandadapu wrote: + dai-link@0 { + link-name = "MultiMedia0"; +

[PATCH v5 1/2] arm64: dts: qcom: sc7180-trogdor: Add lpass dai link for I2S driver

2021-03-12 Thread Srinivasa Rao Mandadapu
From: Ajit Pandey Add dai link for supporting lpass I2S driver, which is used for audio capture and playback. Add lpass-cpu node with pin controls and i2s primary and secondary dai-links Signed-off-by: Ajit Pandey Signed-off-by: V Sujith Kumar Reddy Signed-off-by: Srinivasa Rao Mandadapu

[PATCH v5 0/2] Qualcomm's lpass device tree changes for I2s dai

2021-03-12 Thread Srinivasa Rao Mandadapu
with common dt-bindings macros Changes Since v1: -- Ajith's Certification is added. -- Alias name added for sound dai link node Ajit Pandey (1): arm64: dts: qcom: sc7180-trogdor: Add lpass dai link for I2S driver Srinivasa Rao Mandadapu (1): arm64: dts: qcom: Add sound node for sc7180-trogdor

[PATCH v5 2/2] arm64: dts: qcom: Add sound node for sc7180-trogdor-coachz

2021-03-12 Thread Srinivasa Rao Mandadapu
This is a trgodor variant, required to have sound node variable for coachz specific platform. Signed-off-by: Srinivasa Rao Mandadapu --- arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor

Re: [PATCH v4 1/2] arm64: dts: qcom: sc7180-trogdor: Add lpass dai link for I2S driver

2021-03-12 Thread Srinivasa Rao Mandadapu
Hi Doug, On 3/12/2021 6:32 PM, Srinivasa Rao Mandadapu wrote: Hi Doug, Thanks for your time!!! On 3/12/2021 1:26 AM, Doug Anderson wrote: Hi, On Thu, Mar 11, 2021 at 8:49 AM Srinivasa Rao Mandadapu wrote: From: Ajit Pandey Add dai link for supporting lpass I2S driver, which is used

Re: [PATCH v4 2/2] arm64: dts: qcom: Add sound node for sc7180-trogdor-coachz

2021-03-12 Thread Srinivasa Rao Mandadapu
Hi Doug, Thanks for time and valuable inputs!!! On 3/12/2021 1:24 AM, Doug Anderson wrote: Hi, On Thu, Mar 11, 2021 at 8:48 AM Srinivasa Rao Mandadapu wrote: This is a trgodor variant, required to have sound node variable for coachz specific platform. Signed-off-by: Srinivasa Rao Mandadapu

Re: [PATCH v4 1/2] arm64: dts: qcom: sc7180-trogdor: Add lpass dai link for I2S driver

2021-03-12 Thread Srinivasa Rao Mandadapu
Hi Doug, Thanks for your time!!! On 3/12/2021 1:26 AM, Doug Anderson wrote: Hi, On Thu, Mar 11, 2021 at 8:49 AM Srinivasa Rao Mandadapu wrote: From: Ajit Pandey Add dai link for supporting lpass I2S driver, which is used for audio capture and playback. Add lpass-cpu node with pin

[PATCH v4 2/2] arm64: dts: qcom: Add sound node for sc7180-trogdor-coachz

2021-03-11 Thread Srinivasa Rao Mandadapu
This is a trgodor variant, required to have sound node variable for coachz specific platform. Signed-off-by: Srinivasa Rao Mandadapu --- .../boot/dts/qcom/sc7180-trogdor-coachz.dtsi | 18 ++ 1 file changed, 18 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor

[PATCH v4 1/2] arm64: dts: qcom: sc7180-trogdor: Add lpass dai link for I2S driver

2021-03-11 Thread Srinivasa Rao Mandadapu
From: Ajit Pandey Add dai link for supporting lpass I2S driver, which is used for audio capture and playback. Add lpass-cpu node with pin controls and i2s primary and secondary dai-links Signed-off-by: Ajit Pandey Signed-off-by: V Sujith Kumar Reddy Signed-off-by: Srinivasa Rao Mandadapu

[PATCH v4 0/2] Qualcomm's lpass device tree changes for I2s dai

2021-03-11 Thread Srinivasa Rao Mandadapu
having different codecs. -- Replaced reg values with common dt-bindings macros Changes Since v1: -- Ajith's Certification is added. -- Alias name added for sound dai link node Ajit Pandey (1): arm64: dts: qcom: sc7180-trogdor: Add lpass dai link for I2S driver Srinivasa Rao Mandadapu (1

[PATCH v2] ASoC: qcom: lpass-cpu: Fix lpass dai ids parse

2021-03-11 Thread Srinivasa Rao Mandadapu
The max boundary check while parsing dai ids makes sound card registration fail after common up dai ids. Fixes: cd3484f7f138 ("ASoC: qcom: Fix broken support to MI2S TERTIARY and QUATERNARY") Signed-off-by: Srinivasa Rao Mandadapu --- Changes since v1: -- Fixes commit messa

Re: [PATCH] ASoC: qcom: lpass-cpu: Fix lpass dai ids parse

2021-03-11 Thread Srinivasa Rao Mandadapu
Thanks for the info Mark!! Sorry for the typo mistake. Will re-post with proper subject. On 3/11/2021 6:52 PM, Mark Brown wrote: git log -1 --format='Fixes: %h ("%s")' -- Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc., is a member of Code Aurora Forum, a Linux

[PATCH] ASoC: qcom: lpass-cpu: Fix lpass dai ids parse

2021-03-11 Thread Srinivasa Rao Mandadapu
The max boundary check while parsing dai ids makes sound card registration fail after common up dai ids. Fixes: cd3484f7f1386 (ASoC: dt-bindings: lpass: Fix and common up lpass dai ids) Signed-off-by: Srinivasa Rao Mandadapu --- sound/soc/qcom/lpass-cpu.c | 2 +- 1 file changed, 1 insertion

[PATCH v3 2/2] arm64: dts: qcom: Add sound node for sc7180-trogdor-coachz

2021-03-10 Thread Srinivasa Rao Mandadapu
This is a trgodor variant, required to have sound node variable for coachz specific platform. Signed-off-by: Srinivasa Rao Mandadapu --- .../boot/dts/qcom/sc7180-trogdor-coachz.dtsi | 18 ++ 1 file changed, 18 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor

[PATCH v3 0/2] Qualcomm's lpass device tree changes for I2s dai

2021-03-10 Thread Srinivasa Rao Mandadapu
create conflicts with the boards having different codecs. Ajit Pandey (1): arm64: dts: qcom: sc7180-trogdor: Add lpass dai link for I2S driver Srinivasa Rao Mandadapu (1): arm64: dts: qcom: Add sound node for sc7180-trogdor-coachz .../boot/dts/qcom/sc7180-trogdor-coachz.dtsi | 18

[PATCH v3 1/2] arm64: dts: qcom: sc7180-trogdor: Add lpass dai link for I2S driver

2021-03-10 Thread Srinivasa Rao Mandadapu
From: Ajit Pandey Add dai link for supporting lpass I2S driver, which is used for audio capture and playback. Add lpass-cpu node with pin controls and i2s primary and secondary dai-links Signed-off-by: Ajit Pandey Signed-off-by: V Sujith Kumar Reddy Signed-off-by: Srinivasa Rao Mandadapu

[PATCH] ASoC: qcom: Fix typo error in HDMI regmap config callbacks

2021-02-01 Thread Srinivasa Rao Mandadapu
ASoC: qcom: Add support for lpass hdmi driver") Signed-off-by: Srinivasa Rao Mandadapu --- sound/soc/qcom/lpass-cpu.c| 8 sound/soc/qcom/lpass-sc7180.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/sound/soc/qcom/lpass-cpu.c b/sound/soc/qcom/lpass-cpu.

[PATCH v2] ASoC: qcom: lpass-cpu: Remove bit clock state check

2021-01-27 Thread Srinivasa Rao Mandadapu
and playback continues. It can resolve the errors in such scenarios. Fixes: b1824968221c ("ASoC: qcom: Fix enabling BCLK and LRCLK in LPAIF invalid state") Signed-off-by: Srinivasa Rao Mandadapu --- Changes since v1: -- Commit message changed sound/soc/qcom/lpass-cpu.c

Re: [PATCH] ASoC: qcom: lpass-cpu: Remove bit clock state check

2021-01-27 Thread Srinivasa Rao Mandadapu
Thanks Srinivas For Your time!!! On 1/27/2021 3:21 PM, Srinivas Kandagatla wrote: On 27/01/2021 06:30, Srinivasa Rao Mandadapu wrote: No need of BCLK state maintenance from driver side as clock_enable and clk_disable API's maintaing state counter. One of the major issue was spotted when

[PATCH] ASoC: qcom: lpass-cpu: Remove bit clock state check

2021-01-26 Thread Srinivasa Rao Mandadapu
and playback continues. It can resolve the errors in such scenarios. Signed-off-by: Srinivasa Rao Mandadapu --- sound/soc/qcom/lpass-cpu.c | 22 -- sound/soc/qcom/lpass-lpaif-reg.h | 3 --- sound/soc/qcom/lpass.h | 1 - 3 files changed, 8 insertions(+), 18

Re: [PATCH] ASoC: qcom: Fix number of HDMI RDMA channels on sc7180

2021-01-22 Thread Srinivasa Rao Mandadapu
Hi Mark and Boyd, Thanks for your time on this issue. In my opinion, It 's better not to apply this patch. I will post patch with changing size in sc7180.dtsi file. On 1/22/2021 1:09 AM, Mark Brown wrote: On Fri, 15 Jan 2021 12:33:29 -0800, Stephen Boyd wrote: Suspending/resuming with an

Re: [PATCH v4 1/2] Partially revert ASoC: qcom: Fix enabling BCLK and LRCLK in LPAIF invalid state

2020-12-17 Thread Srinivasa Rao Mandadapu
Thanks Mark for your Time!!! On 12/14/2020 11:20 PM, Mark Brown wrote: On Mon, Dec 14, 2020 at 06:13:22PM +0530, Srinivasa Rao Mandadapu wrote: On 12/1/2020 11:21 PM, Mark Brown wrote: Later from review comments by Srinivas kandagatla, I got to know about regcache sync APIs, which can

Re: [PATCH v4 1/2] Partially revert ASoC: qcom: Fix enabling BCLK and LRCLK in LPAIF invalid state

2020-12-17 Thread Srinivasa Rao Mandadapu
Thanks Mark for your Time!!! On 12/14/2020 11:20 PM, Mark Brown wrote: On Mon, Dec 14, 2020 at 06:13:22PM +0530, Srinivasa Rao Mandadapu wrote: On 12/1/2020 11:21 PM, Mark Brown wrote: Later from review comments by Srinivas kandagatla, I got to know about regcache sync APIs, which can

[PATCH v6 2/2] ASoC: qcom: Add support for playback recover after resume

2020-12-17 Thread Srinivasa Rao Mandadapu
To support playback continuation after hard suspend(bypass powerd) and resume do regcache sync with component driver pm ops. Signed-off-by: V Sujith Kumar Reddy Signed-off-by: Srinivasa Rao Mandadapu Reviewed-by: Srinivas Kandagatla Tested-by: Steev Klimaszewski --- sound/soc/qcom/lpass

[PATCH v6 1/2] ASoC: qcom: Fix incorrect volatile registers

2020-12-17 Thread Srinivasa Rao Mandadapu
API, so remove redundant initialization. Fixes commit b1824968221cc ("ASoC: qcom: Fix enabling BCLK and LRCLK in LPAIF invalid state") Signed-off-by: V Sujith Kumar Reddy Signed-off-by: Srinivasa Rao Mandadapu --- sound/soc/qcom/lpass-cpu.c | 20 ++-- sound/soc/

[PATCH v6 0/2] Platform driver update to support playback recover after resume

2020-12-17 Thread Srinivasa Rao Mandadapu
: -- Subject lines changed Changes Since v3: -- Patch is splitted into 2 patches Changes Since v4: -- Subject lines changed Changes Since v5: -- Removed redundant initialization of map variable in lpass-platform.c Srinivasa Rao Mandadapu (2): ASoC: qcom: Fix incorrect volatile registers ASoC: qcom

Re: [PATCH v4 1/2] Partially revert ASoC: qcom: Fix enabling BCLK and LRCLK in LPAIF invalid state

2020-12-14 Thread Srinivasa Rao Mandadapu
Thanks Mark for Your time!!! On 12/1/2020 11:21 PM, Mark Brown wrote: On Tue, Dec 01, 2020 at 11:01:21PM +0530, Srinivasa Rao Mandadapu wrote: On 11/30/2020 6:16 PM, Mark Brown wrote: Part of this commit message says that the problem was making the registers non-volatile but both the change

[PATCH v5 2/2] ASoC: qcom: Add support for playback recover after resume

2020-12-02 Thread Srinivasa Rao Mandadapu
To support playback continuation after hard suspend(bypass powerd) and resume do regcache sync with component driver pm ops. Signed-off-by: V Sujith Kumar Reddy Signed-off-by: Srinivasa Rao Mandadapu Reviewed-by: Srinivas Kandagatla Tested-by: Steev Klimaszewski --- sound/soc/qcom/lpass

[PATCH v5 1/2] ASoC: qcom: Fix incorrect volatile registers

2020-12-02 Thread Srinivasa Rao Mandadapu
BCLK and LRCLK in LPAIF invalid state") Signed-off-by: V Sujith Kumar Reddy Signed-off-by: Srinivasa Rao Mandadapu --- sound/soc/qcom/lpass-cpu.c | 20 ++-- sound/soc/qcom/lpass-platform.c | 11 --- 2 files changed, 2 insertions(+), 29 deletions(-) diff --git a

[PATCH v5 0/2] Platform driver update to support playback recover after resume

2020-12-02 Thread Srinivasa Rao Mandadapu
: -- Subject lines changed Changes Since v3: -- Patch is splitted into 2 patches Changes Since v4: -- Subject lines changed Srinivasa Rao Mandadapu (2): ASoC: qcom: Fix incorrect volatile registers ASoC: qcom: Add support for playback recover after resume sound/soc/qcom/lpass-cpu.c | 20

Re: [PATCH v4 1/2] Partially revert ASoC: qcom: Fix enabling BCLK and LRCLK in LPAIF invalid state

2020-12-01 Thread Srinivasa Rao Mandadapu
Thanks Mark for your time!!! On 11/30/2020 6:16 PM, Mark Brown wrote: On Sat, Nov 28, 2020 at 10:29:18AM +0530, Srinivasa Rao Mandadapu wrote: This reverts part of commit b1824968221c ("ASoC: qcom: Fix enabling BCLK and LRCLK in LPAIF invalid state") To identify LPAIF invalid s

Re: [PATCH] arm64: dts: qcom: sc7180-trogdor: Add lpass dai link for I2S driver

2020-11-30 Thread Srinivasa Rao Mandadapu
Thanks Bjorn For your comments!!! On 11/30/2020 10:22 PM, Bjorn Andersson wrote: On Fri 18 Sep 09:51 CDT 2020, Srinivasa Rao Mandadapu wrote: From: Ajit Pandey Add dai link for supporting lpass I2S driver, which is used for audio capture and playback. Add lpass-cpu node with pin controls

[PATCH v4 1/2] Partially revert ASoC: qcom: Fix enabling BCLK and LRCLK in LPAIF invalid state

2020-11-28 Thread Srinivasa Rao Mandadapu
be handled with regcache APIs. The BCLK ref count is necessary to enable clock only it's in disable state. Signed-off-by: V Sujith Kumar Reddy Signed-off-by: Srinivasa Rao Mandadapu --- sound/soc/qcom/lpass-cpu.c | 20 ++-- sound/soc/qcom/lpass-platform.c | 11 --- 2 files

[PATCH v4 0/2] Platform driver update to support playback recover after resume

2020-11-28 Thread Srinivasa Rao Mandadapu
This patch set is to add support for playback recover after hard suspend and resume. It includes: 1. Reverting part of previous commit, which is for handling registers invalid state after hard suspend. 2. Adding pm ops in component driver and do regcache sync. Srinivasa Rao Mandadapu (2

[PATCH v4 2/2] ASoC: qcom: Add support for playback recover after resume

2020-11-28 Thread Srinivasa Rao Mandadapu
To support playback continuation after hard suspend(bypass powerd) and resume add component driver ops and do regcache sync. Signed-off-by: V Sujith Kumar Reddy Signed-off-by: Srinivasa Rao Mandadapu --- sound/soc/qcom/lpass-platform.c | 35 +++ 1 file changed

Re: [PATCH] Asoc: qcom: Fix for problem in resume with CRAS

2020-11-27 Thread Srinivasa Rao Mandadapu
Thanks Mark  for your time!!! On 11/27/2020 6:08 PM, Mark Brown wrote: On Fri, Nov 27, 2020 at 09:42:03AM +0530, Srinivasa Rao Mandadapu wrote: To support playback continuation after resume problem in chrome audio server: Prepare device in platform trigger callback. Make I2s and DMA control

Re: [PATCH v3] ASoC: qcom: Fix playback recover problem in suspend resume

2020-11-27 Thread Srinivasa Rao Mandadapu
Thanks a lot  Srinivas for your valuable review comments and for your time!!! On 11/27/2020 5:39 PM, Srinivas Kandagatla wrote: On 27/11/2020 09:56, Srinivasa Rao Mandadapu wrote: To support playback continuation after hard suspend(bypass powerd)   and resume: Prepare device in  platform

[PATCH v3] ASoC: qcom: Fix playback recover problem in suspend resume

2020-11-27 Thread Srinivasa Rao Mandadapu
To support playback continuation after hard suspend(bypass powerd) and resume: Prepare device in platform trigger callback. Make I2s and DMA control registers as non volatile. Signed-off-by: V Sujith Kumar Reddy Signed-off-by: Srinivasa Rao Mandadapu --- Changes Since v1 and v2: -- Subject

[PATCH v2] Asoc: qcom: Fix plaback recover problem in suspend resume

2020-11-27 Thread Srinivasa Rao Mandadapu
To support playback continuation after hard suspend(bypass powerd) and resume: Prepare device in platform trigger callback. Make I2s and DMA control registers as non volatile. Signed-off-by: V Sujith Kumar Reddy Signed-off-by: Srinivasa Rao Mandadapu --- Changes Since v1: -- Subject lines

[PATCH] Asoc: qcom: Fix for problem in resume with CRAS

2020-11-26 Thread Srinivasa Rao Mandadapu
To support playback continuation after resume problem in chrome audio server: Prepare device in platform trigger callback. Make I2s and DMA control registers as non volatile. Signed-off-by: V Sujith Kumar Reddy Signed-off-by: Srinivasa Rao Mandadapu --- sound/soc/qcom/lpass-cpu.c | 8

[PATCH] Asoc: qcom: Fix enabling BCLK and LRCLK in LPAIF invalid state

2020-11-23 Thread Srinivasa Rao Mandadapu
enable, and by maintaining BLCK state information. Fixes: 7e6799d8f87d ("ASoC: qcom: lpass-cpu: Enable MI2S BCLK and LRCLK together") Signed-off-by: V Sujith Kumar Reddy Signed-off-by: Srinivasa Rao Mandadapu --- sound/soc/qcom/lpass-cpu.c

[PATCH] Asoc: qcom: dts: Change MI2S GPIO configuration to pulldown

2020-11-16 Thread Srinivasa Rao Mandadapu
From: V Sujith Kumar Reddy Change LPASS MI2S gpio configuration to pull down from pull up. Fixes: 9b72f4e6a3f8 (arm64: dts: qcom: sc7180: Add lpass cpu node for I2S driver) Signed-off-by: V Sujith Kumar Reddy Signed-off-by: Srinivasa Rao Mandadapu --- arch/arm64/boot/dts/qcom/sc7180.dtsi

[PATCH] Asoc: qcom: lpass-sc7180: Add 32 bit format support for capture

2020-11-15 Thread Srinivasa Rao Mandadapu
From: V Sujith Kumar Reddy Add 32 bit format support for capture in lpass-sc7180 snd_soc_dai_driver capabilities. Need to add contstraints in machine driver so that only specific format allowed. Signed-off-by: V Sujith Kumar Reddy Signed-off-by: Srinivasa Rao Manidadapu ---

[PATCH] Asoc: qcom: lpass-platform: Fix memory leak

2020-11-14 Thread Srinivasa Rao Mandadapu
lpass_pcm_data is not freed in error paths. Free it in error paths to avoid memory leak. Fixes: 022d00ee0b55 ("ASoC: lpass-platform: Fix broken pcm data usage") Signed-off-by: Pavel Machek Signed-off-by: V Sujith Kumar Reddy Signed-off-by: Srinivasa Rao Mandadapu --- sound/soc/

[PATCH] Asoc: qcom: sc7180: Register shutdown handler for lpass platform

2020-11-13 Thread Srinivasa Rao Mandadapu
From: V Sujith Kumar Reddy Register shutdown handler to stop sc7180 lpass platform driver and to disable audio clocks. Signed-off-by: V Sujith Kumar Reddy Signed-off-by: Srinivasa Rao Mandadapu --- sound/soc/qcom/lpass-cpu.c| 10 ++ sound/soc/qcom/lpass-sc7180.c | 1 + sound/soc

[PATCH] Asoc: qcom: dts: Update iommu property for simultaneous playback

2020-11-13 Thread Srinivasa Rao Mandadapu
From: V Sujith Kumar Reddy Update iommu property in lpass cpu node for supporting simultaneous playback on headset and speaker. Signed-off-by: V Sujith Kumar Reddy Signed-off-by: Srinivasa Rao Mandadapu --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 4 +++- 1 file changed, 3 insertions(+), 1

[PATCH v2] Asoc: qcom: lpass-sc7180: Fix MI2S bitwidth field bit positions

2020-10-27 Thread Srinivasa Rao Mandadapu
dy Signed-off-by: Srinivasa Rao Mandadapu --- Changes Since v1: -- Commit message is changed sound/soc/qcom/lpass-sc7180.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/qcom/lpass-sc7180.c b/sound/soc/qcom/lpass-sc7180.c index c6292f9e..bc998d5 100644 --- a/soun

Re: [PATCH] Asoc: qcom: lpass-sc7180: Fix MI2S bitwidth field bit positions

2020-10-26 Thread Srinivasa Rao Mandadapu
Thanks for your time srinivas!!! On 10/26/2020 8:31 PM, Srinivas Kandagatla wrote: On 22/10/2020 14:26, Srinivasa Rao Mandadapu wrote: From: V Sujith Kumar Reddy Update SC7180 lpass_variant structure with proper I2S bitwidth field bit positions, as bitwidth denotes 0 to 1 bits

[PATCH] Asoc: qcom: lpass-sc7180: Fix MI2S bitwidth field bit positions

2020-10-22 Thread Srinivasa Rao Mandadapu
rom Rohit kumar :") Signed-off-by: V Sujith Kumar Reddy Signed-off-by: Srinivasa Rao Mandadapu --- sound/soc/qcom/lpass-sc7180.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/qcom/lpass-sc7180.c b/sound/soc/qcom/lpass-sc7180.c index c6292f9e..bc998d5 100644 --- a/

[PATCH v2] Asoc: qcom: lpass-cpu: Fix clock disable failure

2020-10-19 Thread Srinivasa Rao Mandadapu
ble" in trigger, as trigger is being called from atomic context. Fixes: commit 7e6799d8f87d ("ASoC: qcom: lpass-cpu: Enable MI2S BCLK and LRCLK together") Signed-off-by: V Sujith Kumar Reddy Signed-off-by: Srinivasa Rao Mandadapu --- sound/soc/qcom/lpass-cpu.c | 14 ++ 1 fil

Re: [PATCH 1/2] Asoc: qcom: lpass-cpu: Fix clock disable failure

2020-10-13 Thread Srinivasa Rao Mandadapu
Thanks  Mark Brown for your time !!! On 10/13/2020 8:45 PM, Mark Brown wrote: On Tue, Oct 13, 2020 at 07:09:46PM +0530, Srinivasa Rao Mandadapu wrote: From: V Sujith Kumar Reddy Disable MI2S bit clock from PAUSE/STOP/SUSPEND usecase instead of shutdown time. Acheive this by invoking

[PATCH] Asoc: qcom: lpass-cpu: Fix dp audio failure on monitors

2020-10-13 Thread Srinivasa Rao Mandadapu
Rao Mandadapu --- sound/soc/qcom/lpass-cpu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/qcom/lpass-cpu.c b/sound/soc/qcom/lpass-cpu.c index ba2aca3..78de888 100644 --- a/sound/soc/qcom/lpass-cpu.c +++ b/sound/soc/qcom/lpass-cpu.c @@ -660,6 +660,8 @@ static bool

[PATCH 1/2] Asoc: qcom: lpass-cpu: Fix clock disable failure

2020-10-13 Thread Srinivasa Rao Mandadapu
/ Signed-off-by: V Sujith Kumar Reddy Signed-off-by: Srinivasa Rao Mandadapu --- sound/soc/qcom/lpass-cpu.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/soc/qcom/lpass-cpu.c b/sound/soc/qcom/lpass-cpu.c index ba2aca3..2dfb921 100644 --- a/sound/soc/qcom/lpass-cpu.c

[PATCH v11 6/7] Asoc: qcom: lpass-platform : Increase buffer size

2020-10-07 Thread Srinivasa Rao Mandadapu
From: V Sujith Kumar Reddy Increase buffer size to support audio over DP. Signed-off-by: V Sujith Kumar Reddy Signed-off-by: Srinivasa Rao Mandadapu --- sound/soc/qcom/lpass-platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/qcom/lpass-platform.c b/sound

[PATCH v11 5/7] ASoC: qcom: Add support for lpass hdmi driver

2020-10-07 Thread Srinivasa Rao Mandadapu
From: V Sujith Kumar Reddy Upadate lpass cpu and platform driver to support audio over dp. Also add lpass-hdmi.c and lpass-hdmi.h. Signed-off-by: V Sujith Kumar Reddy Signed-off-by: Srinivasa Rao --- sound/soc/qcom/Kconfig | 5 + sound/soc/qcom/Makefile | 2 +

[PATCH v11 1/7] ASoC: Add sc7180-lpass binding header hdmi define

2020-10-07 Thread Srinivasa Rao Mandadapu
From: V Sujith Kumar Reddy Add header defining hdmi dai-id for SC7180 lpass soc in dt bindings. Signed-off-by: V Sujith Kumar Reddy Acked-by: Rob Herring Signed-off-by: Srinivasa Rao --- include/dt-bindings/sound/sc7180-lpass.h | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v11 0/7] Qualcomm's lpass-hdmi ASoC driver to support audio over dp port

2020-10-07 Thread Srinivasa Rao Mandadapu
These patches are to support audio over DP port on Qualcomm's SC7180 LPASS Asoc. It includes machine driver, cpu driver, platform driver updates for HDMI path support, device tree documention, lpass variant structure optimization and configuration changes. These patches depends on the DP patch

[PATCH v11 3/7] Asoc:qcom:lpass-cpu:Update dts property read API

2020-10-07 Thread Srinivasa Rao Mandadapu
From: V Sujith Kumar Reddy Update dts property read API call with platform get property by name, as it make code more readable and avoid conflicts when array of properties to be used. Signed-off-by: V Sujith Kumar Reddy Reviewed-by: Srinivas Kandagatla Signed-off-by: Srinivasa Rao ---

[PATCH v11 4/7] Asoc: qcom: lpass:Update lpaif_dmactl members order

2020-10-07 Thread Srinivasa Rao Mandadapu
From: V Sujith Kumar Reddy Update the lpaif_dmactl struct members order to match HDMI reg map members sequence. Separate Interface reg map as it is used for I2S control but not for HDMI control, to make use of bulk API, which makes code more readable. Signed-off-by: V Sujith Kumar Reddy

[PATCH v11 2/7] ASoC: dt-bindings: Add dt binding for lpass hdmi

2020-10-07 Thread Srinivasa Rao Mandadapu
From: V Sujith Kumar Reddy Adds bindings for lpass hdmi interface which can support audio path over dp. Signed-off-by: V Sujith Kumar Reddy Reviewed-by: Rob Herring Signed-off-by: Srinivasa Rao --- .../devicetree/bindings/sound/qcom,lpass-cpu.yaml | 74 +++--- 1 file

[PATCH v11 7/7] ASoC: qcom: sc7180: Add support for audio over DP

2020-10-07 Thread Srinivasa Rao Mandadapu
From: V Sujith Kumar Reddy Add support for audio playback over DP in lpass sc7180 platform driver. Update lpass_variant structure for hdmi data configuaration. Signed-off-by: V Sujith Kumar Reddy Signed-off-by: Srinivasa Rao --- sound/soc/qcom/lpass-sc7180.c | 116

Re: [PATCH v10 5/7] ASoC: qcom: Add support for lpass hdmi driver

2020-10-07 Thread Srinivasa Rao Mandadapu
Thanks for review comments Srinivas!!! On 10/7/2020 2:00 AM, Srinivas Kandagatla wrote: On 05/10/2020 05:48, Srinivasa Rao Mandadapu wrote: From: V Sujith Kumar Reddy Upadate lpass cpu and platform driver to support audio over dp. Also add lpass-hdmi.c and lpass-hdmi.h. Signed-off-by: V

[PATCH v2] arm64: dts: qcom: sc7180-trogdor: Add lpass dai link for I2S driver

2020-10-06 Thread Srinivasa Rao Mandadapu
From: Ajit Pandey Add dai link for supporting lpass I2S driver, which is used for audio capture and playback. Add lpass-cpu node with pin controls and i2s primary and secondary dai-links Signed-off-by: Ajit Pandey Signed-off-by: V Sujith Kumar Reddy Signed-off-by: Srinivasa Rao Mandadapu

[PATCH v10 6/7] Asoc: qcom: lpass-platform : Increase buffer size

2020-10-04 Thread Srinivasa Rao Mandadapu
From: V Sujith Kumar Reddy Increase buffer size to support audio over DP. Signed-off-by: V Sujith Kumar Reddy Signed-off-by: Srinivasa Rao Mandadapu --- sound/soc/qcom/lpass-platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/qcom/lpass-platform.c b/sound

[PATCH v10 7/7] ASoC: qcom: sc7180: Add support for audio over DP

2020-10-04 Thread Srinivasa Rao Mandadapu
From: V Sujith Kumar Reddy Add support for audio playback over DP in lpass sc7180 platform driver. Update lpass_variant structure for hdmi data configuaration. Signed-off-by: V Sujith Kumar Reddy Signed-off-by: Srinivasa Rao --- sound/soc/qcom/lpass-sc7180.c | 116

[PATCH v10 5/7] ASoC: qcom: Add support for lpass hdmi driver

2020-10-04 Thread Srinivasa Rao Mandadapu
From: V Sujith Kumar Reddy Upadate lpass cpu and platform driver to support audio over dp. Also add lpass-hdmi.c and lpass-hdmi.h. Signed-off-by: V Sujith Kumar Reddy Signed-off-by: Srinivasa Rao --- sound/soc/qcom/Kconfig | 5 + sound/soc/qcom/Makefile | 2 +

[PATCH v10 3/7] Asoc:qcom:lpass-cpu:Update dts property read API

2020-10-04 Thread Srinivasa Rao Mandadapu
From: V Sujith Kumar Reddy Update dts property read API call with platform get property by name, as it make code more readable and avoid conflicts when array of properties to be used. Signed-off-by: V Sujith Kumar Reddy Reviewed-by: Srinivas Kandagatla Signed-off-by: Srinivasa Rao ---

[PATCH v10 4/7] Asoc: qcom: lpass:Update lpaif_dmactl members order

2020-10-04 Thread Srinivasa Rao Mandadapu
From: V Sujith Kumar Reddy Update the lpaif_dmactl struct members order to match HDMI reg map members sequence. Separate Interface reg map as it is used for I2S control but not for HDMI control, to make use of bulk API, which makes code more readable. Signed-off-by: V Sujith Kumar Reddy

[PATCH v10 0/7] Qualcomm's lpass-hdmi ASoC driver to support audio over dp port

2020-10-04 Thread Srinivasa Rao Mandadapu
These patches are to support audio over DP port on Qualcomm's SC7180 LPASS Asoc. It includes machine driver, cpu driver, platform driver updates for HDMI path support, device tree documention, lpass variant structure optimization and configuration changes. These patches depends on the DP patch

[PATCH v10 2/7] ASoC: dt-bindings: Add dt binding for lpass hdmi

2020-10-04 Thread Srinivasa Rao Mandadapu
From: V Sujith Kumar Reddy Adds bindings for lpass hdmi interface which can support audio path over dp. Signed-off-by: V Sujith Kumar Reddy Reviewed-by: Rob Herring Signed-off-by: Srinivasa Rao --- .../devicetree/bindings/sound/qcom,lpass-cpu.yaml | 74 +++--- 1 file

[PATCH v10 1/7] ASoC: Add sc7180-lpass binding header hdmi define

2020-10-04 Thread Srinivasa Rao Mandadapu
From: V Sujith Kumar Reddy Add header defining hdmi dai-id for SC7180 lpass soc in dt bindings. Signed-off-by: V Sujith Kumar Reddy Acked-by: Rob Herring Signed-off-by: Srinivasa Rao --- include/dt-bindings/sound/sc7180-lpass.h | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v9 0/7] Qualcomm's lpass-hdmi ASoC driver to support audio over dp port

2020-10-04 Thread Srinivasa Rao Mandadapu
These patches are to support audio over DP port on Qualcomm's SC7180 LPASS Asoc. It includes machine driver, cpu driver, platform driver updates for HDMI path support, device tree documention, lpass variant structure optimization and configuration changes. These patches depends on the DP patch

[PATCH v9 7/7] ASoC: qcom: sc7180: Add support for audio over DP

2020-10-04 Thread Srinivasa Rao Mandadapu
From: V Sujith Kumar Reddy Add support for audio playback over DP in lpass sc7180 platform driver. Update lpass_variant structure for hdmi data configuaration. Signed-off-by: V Sujith Kumar Reddy Signed-off-by: Srinivasa Rao --- sound/soc/qcom/lpass-sc7180.c | 116

[PATCH v9 2/7] ASoC: dt-bindings: Add dt binding for lpass hdmi

2020-10-04 Thread Srinivasa Rao Mandadapu
From: V Sujith Kumar Reddy Adds bindings for lpass hdmi interface which can support audio path over dp. Signed-off-by: V Sujith Kumar Reddy Reviewed-by: Rob Herring Signed-off-by: Srinivasa Rao --- .../devicetree/bindings/sound/qcom,lpass-cpu.yaml | 74 +++--- 1 file

[PATCH v9 5/7] ASoC: qcom: Add support for lpass hdmi driver

2020-10-04 Thread Srinivasa Rao Mandadapu
From: V Sujith Kumar Reddy Upadate lpass cpu and platform driver to support audio over dp. Also add lpass-hdmi.c and lpass-hdmi.h. Signed-off-by: V Sujith Kumar Reddy Signed-off-by: Srinivasa Rao --- sound/soc/qcom/Kconfig | 5 + sound/soc/qcom/Makefile | 2 +

[PATCH v9 6/7] Asoc: qcom: lpass-platform : Increase buffer size

2020-10-04 Thread Srinivasa Rao Mandadapu
From: V Sujith Kumar Reddy Increase buffer size to support audio over DP. Signed-off-by: V Sujith Kumar Reddy Signed-off-by: Srinivasa Rao Mandadapu --- sound/soc/qcom/lpass-platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/qcom/lpass-platform.c b/sound

[PATCH v9 4/7] Asoc: qcom: lpass:Update lpaif_dmactl members order

2020-10-04 Thread Srinivasa Rao Mandadapu
From: V Sujith Kumar Reddy Update the lpaif_dmactl struct members order to match HDMI reg map members sequence. Separate Interface reg map as it is used for I2S control but not for HDMI control, to make use of bulk API, which makes code more readable. Signed-off-by: V Sujith Kumar Reddy

[PATCH v9 1/7] ASoC: Add sc7180-lpass binding header hdmi define

2020-10-04 Thread Srinivasa Rao Mandadapu
From: V Sujith Kumar Reddy Add header defining hdmi dai-id for SC7180 lpass soc in dt bindings. Signed-off-by: V Sujith Kumar Reddy Acked-by: Rob Herring Signed-off-by: Srinivasa Rao --- include/dt-bindings/sound/sc7180-lpass.h | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v9 3/7] Asoc:qcom:lpass-cpu:Update dts property read API

2020-10-04 Thread Srinivasa Rao Mandadapu
From: V Sujith Kumar Reddy Update dts property read API call with platform get property by name, as it make code more readable and avoid conflicts when array of properties to be used. Signed-off-by: V Sujith Kumar Reddy Reviewed-by: Srinivas Kandagatla Signed-off-by: Srinivasa Rao ---

Re: [PATCH v8 5/7] ASoC: qcom: Add support for lpass hdmi driver

2020-10-03 Thread Srinivasa Rao Mandadapu
Thanks for bringing up this point Srinivas!!! On 9/30/2020 8:57 PM, Srinivas Kandagatla wrote: On 30/09/2020 07:39, Srinivasa Rao Mandadapu wrote: +} + +static bool lpass_hdmi_regmap_volatile(struct device *dev, unsigned int reg) +{ +    return true; +} I did ask this question

[PATCH v3 0/2] Qualcomm's lpass device tree changes

2020-09-30 Thread Srinivasa Rao Mandadapu
These patches are device tree changes to support audio over DP. It includes changes of HDMI reg, interrupt and iommu and hdmi dai link. These patches depends on the lpass I2S patch series and DP dts node patch series: -- https://patchwork.kernel.org/patch/11785073/ --

[PATCH v3 1/2] arm64: dts: qcom: sc7180: Update lpass cpu node for audio over dp

2020-09-30 Thread Srinivasa Rao Mandadapu
From: V Sujith Kumar Reddy Updaate lpass dts node with HDMI reg, interrupt and iommu for supporting audio over dp. Signed-off-by: Srinivasa Rao Mandadapu Signed-off-by: V Sujith Kumar Reddy --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 17 ++--- 1 file changed, 10 insertions(+), 7

[PATCH v3 2/2] arm64: dts: qcom: sc7180-trogdor: Add lpass dai link for HDMI

2020-09-30 Thread Srinivasa Rao Mandadapu
From: V Sujith Kumar Reddy Add dai link in sc7180-trogdor.dtsi for supporting audio over DP Signed-off-by: V Sujith Kumar Reddy Signed-off-by: Srinivasa Rao Mandadapu --- arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 15 +++ 1 file changed, 15 insertions(+) diff --git a/arch

[PATCH v8 4/7] Asoc: qcom: lpass:Update lpaif_dmactl members order

2020-09-30 Thread Srinivasa Rao Mandadapu
From: V Sujith Kumar Reddy Update the lpaif_dmactl struct members order to match HDMI reg map members sequence. Separate Interface reg map as it is used for I2S control but not for HDMI control, to make use of bulk API, which makes code more readable. Signed-off-by: V Sujith Kumar Reddy

[PATCH v8 2/7] ASoC: dt-bindings: Add dt binding for lpass hdmi

2020-09-30 Thread Srinivasa Rao Mandadapu
From: V Sujith Kumar Reddy Adds bindings for lpass hdmi interface which can support audio path over dp. Signed-off-by: V Sujith Kumar Reddy Reviewed-by: Rob Herring Signed-off-by: Srinivasa Rao --- .../devicetree/bindings/sound/qcom,lpass-cpu.yaml | 74 +++--- 1 file

[PATCH v8 5/7] ASoC: qcom: Add support for lpass hdmi driver

2020-09-30 Thread Srinivasa Rao Mandadapu
From: V Sujith Kumar Reddy Upadate lpass cpu and platform driver to support audio over dp. Also add lpass-hdmi.c and lpass-hdmi.h. Signed-off-by: V Sujith Kumar Reddy Signed-off-by: Srinivasa Rao --- sound/soc/qcom/Kconfig | 5 + sound/soc/qcom/Makefile | 2 +

[PATCH v8 7/7] ASoC: qcom: sc7180: Add support for audio over DP

2020-09-30 Thread Srinivasa Rao Mandadapu
From: V Sujith Kumar Reddy Add support for audio playback over DP in lpass sc7180 platform driver. Update lpass_variant structure for hdmi data configuaration. Signed-off-by: V Sujith Kumar Reddy Signed-off-by: Srinivasa Rao --- sound/soc/qcom/lpass-sc7180.c | 116

[PATCH v8 3/7] Asoc:qcom:lpass-cpu:Update dts property read API

2020-09-30 Thread Srinivasa Rao Mandadapu
From: V Sujith Kumar Reddy Update dts property read API call with platform get property by name, as it make code more readable and avoid conflicts when array of properties to be used. Signed-off-by: V Sujith Kumar Reddy Reviewed-by: Srinivas Kandagatla Signed-off-by: Srinivasa Rao ---

[PATCH v8 6/7] Asoc: qcom: lpass-platform : Increase buffer size

2020-09-30 Thread Srinivasa Rao Mandadapu
From: V Sujith Kumar Reddy Increase buffer size to support audio over DP. Signed-off-by: V Sujith Kumar Reddy Signed-off-by: Srinivasa Rao Mandadapu --- sound/soc/qcom/lpass-platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/qcom/lpass-platform.c b/sound

[PATCH v8 1/7] ASoC: Add sc7180-lpass binding header hdmi define

2020-09-30 Thread Srinivasa Rao Mandadapu
From: V Sujith Kumar Reddy Add header defining hdmi dai-id for SC7180 lpass soc in dt bindings. Signed-off-by: V Sujith Kumar Reddy Acked-by: Rob Herring Signed-off-by: Srinivasa Rao --- include/dt-bindings/sound/sc7180-lpass.h | 1 + 1 file changed, 1 insertion(+) diff --git

  1   2   >