On Sat, 2021-04-17 at 06:57 +0200, Daniel Lezcano wrote:
> On 14/04/2021 07:52, Matti Vaittinen wrote:
> > Thermal core contains a logic for safety shutdown. System is
> > attempted to
> > be powered off if temperature exceeds safety limits.
> >
> > Currently this can be also utilized by
Hello Lee, Mark, Stephen, Linus, Alexandre,
On Wed, 2021-04-14 at 15:53 +0100, Lee Jones wrote:
> On Wed, 14 Apr 2021, Lee Jones wrote:
>
> > Please note that this PR will break your build unless you have the
> > required Regulator API update.
> >
> > fb8fee9efdcf0 regulator: Add regmap helper
Hi,
On Mon, 2021-04-12 at 09:05 +0300, Matti Vaittinen wrote:
> Hi All,
>
> On Wed, 2021-03-10 at 16:39 -0800, Guru Das Srinagesh wrote:
> > Qualcomm's MFD chips have a top level interrupt status register and
> > sub-irqs (peripherals). When a bit in the main status register
> > goes
> > high,
On Thu, 2021-04-08 at 20:20 -0700, Kees Cook wrote:
> On Wed, Apr 07, 2021 at 03:50:15PM +0300, Andy Shevchenko wrote:
> > On Wed, Apr 7, 2021 at 12:49 PM Vaittinen, Matti
> > wrote:
> > > On Wed, 2021-04-07 at 12:10 +0300, Andy Shevchenko wrote:
> > > >
On Thu, 2021-04-08 at 12:58 +0300, Andy Shevchenko wrote:
> On Thu, Apr 8, 2021 at 11:21 AM Matti Vaittinen
> wrote:
> > Hello Andy,
> >
> > On Wed, 2021-04-07 at 16:21 +0300, Andy Shevchenko wrote:
> > > On Wed, Apr 7, 2021 at 1:04 PM Matti Vaittinen
> > > wrote:
> > > > Provide helper
Hello Andy,
On Wed, 2021-04-07 at 12:10 +0300, Andy Shevchenko wrote:
> On Wed, Apr 7, 2021 at 8:02 AM Matti Vaittinen
> wrote:
> > On Wed, 2021-04-07 at 01:44 +0300, Andy Shevchenko wrote:
> > > On Tuesday, April 6, 2021, Matti Vaittinen <
> > > matti.vaitti...@fi.rohmeurope.com> wrote:
>
>
On Fri, 2021-04-02 at 20:19 +0100, Mark Brown wrote:
> On Tue, Mar 30, 2021 at 11:06:53AM +0000, Vaittinen, Matti wrote:
>
> > Do you think Lee could merge other but the regulator parts to MFD
> > if
> > Mark is busy? I'd like to be able to squeeze the amount of patche
On Sun, 2021-04-04 at 19:21 +0300, Matti Vaittinen wrote:
> On Fri, 2021-04-02 at 18:42 +0100, Mark Brown wrote:
> > On Mon, Mar 29, 2021 at 03:59:51PM +0300, Matti Vaittinen wrote:
> >
> > Acked-by: Mark Brown
> >
> > but...
>
> Do you want me to respin the series or do you think this can be
On Fri, 2021-04-02 at 18:42 +0100, Mark Brown wrote:
> On Mon, Mar 29, 2021 at 03:59:51PM +0300, Matti Vaittinen wrote:
>
> Acked-by: Mark Brown
>
> but...
Do you want me to respin the series or do you think this can be applied
as-is and fixed by a follow-up?
Best Regards
Matti
On Fri, 2021-04-02 at 18:19 +0100, Mark Brown wrote:
> On Thu, Mar 11, 2021 at 12:24:29PM +0200, Matti Vaittinen wrote:
> > Driver name was changed in MFD cell:
> > https://lore.kernel.org/lkml/560b9748094392493ebf7af11b6cc558776c4fd5.1613031055.git.matti.vaitti...@fi.rohmeurope.com/
> > Fix the
Hi Mark,
Thanks for the review(s)!
On Fri, 2021-04-02 at 18:18 +0100, Mark Brown wrote:
> On Thu, Mar 11, 2021 at 12:23:02PM +0200, Matti Vaittinen wrote:
>
> > + /*
> > +* Existing logic does not warn if over_current_protection is
> > given as
> > +* a constraint but driver does not
On Tue, 2021-03-30 at 13:11 +0300, Andy Shevchenko wrote:
> On Mon, Mar 29, 2021 at 3:58 PM Matti Vaittinen
> wrote:
> >
> > +struct bd71815_gpio {
> > + struct gpio_chip chip;
> > + struct device *dev;
>
> Wondering why you need this. Is it the same as chip.parent?
>
This is
On Mon, 2021-03-29 at 15:52 +0300, Matti Vaittinen wrote:
> Patch series introducing support for ROHM BD71815 PMIC
>
> ROHM BD71815 is a power management IC used in some battery powered
> systems. It contains regulators, GPO(s), charger + coulomb counter,
> RTC
> and a clock gate.
Lee, Mark,
On Tue, 2021-03-30 at 13:54 +0300, Andy Shevchenko wrote:
> On Tue, Mar 30, 2021 at 1:43 PM Matti Vaittinen
> wrote:
> > On Tue, 2021-03-30 at 13:11 +0300, Andy Shevchenko wrote:
>
> ...
>
> > Andy, how fatal do you think these issues are? I did put these
> > comments
> > on my 'things to
On Thu, 2021-03-25 at 09:49 +0900, Chanwoo Choi wrote:
> On 3/24/21 6:51 PM, Vaittinen, Matti wrote:
> > Hello Hans, Chanwoo, Greg,
> >
> > On Wed, 2021-03-24 at 10:25 +0100, Hans de Goede wrote:
> > > Hi,
> > >
> > > On 3/24/21 10:21 AM, Matti Va
Hello Hans, Chanwoo, Greg,
On Wed, 2021-03-24 at 10:25 +0100, Hans de Goede wrote:
> Hi,
>
> On 3/24/21 10:21 AM, Matti Vaittinen wrote:
> > Add error print for probe failure when resource managed work-queue
> > initialization fails.
> >
> > Signed-off-by: Matti Vaittinen
> > Suggested-by:
Hi Greg,
On Tue, 2021-03-23 at 13:43 +0100, Greg KH wrote:
> On Mon, Mar 22, 2021 at 09:41:13AM +0200, Matti Vaittinen wrote:
> > It's not rare that device drivers need delayed work.
> > It's not rare that this work needs driver's data.
>
> I don't normally comment on "RFC" patch series as I
On Tue, 2021-01-19 at 12:07 +0100, Bartosz Golaszewski wrote:
> On Tue, Jan 19, 2021 at 8:23 AM Matti Vaittinen
> wrote:
> > Support GPO(s) found from ROHM BD71815 power management IC. The IC
> > has two
> > GPO pins but only one is properly documented in data-sheet. The
> > driver
> > exposes
Hello Lee,
On Wed, 2021-03-10 at 10:36 +, Lee Jones wrote:
> On Mon, 08 Mar 2021, Matti Vaittinen wrote:
>
> > Add chip ID for ROHM BD71815 and PMIC so that drivers can identify
> > this IC.
> >
> > Signed-off-by: Matti Vaittinen
> > Acked-for-MFD-by: Lee Jones
> > ---
> >
On Mon, 2021-03-08 at 18:06 +0200, Andy Shevchenko wrote:
> On Mon, Mar 8, 2021 at 5:29 PM Arnd Bergmann wrote:
>
> > - depends on EXTCON || !EXTCON
>
> I stumbled over this.
> What is the point of having this line at all?
> What magic trick does it serve for?
The logic was somewhat
oamp'. Perhaps
> regulator-oc-protection-microamp and similar.
I like this idea but...
regulator-over-current-protection:
description: Enable over current protection.
type: boolean
is an existing property so it kind of makes sen
uot;regulator.yaml#"
> >
> > +properties:
> > + rohm,ocw-fet-ron-milliohms:
>
> We have '-ohms' and '-micro-ohms' already. Neither range works for
> you?
Thanks for taking a look at this :)
I expect values to be magnitude of few hundred milliohms - which
On Mon, 2021-02-15 at 12:43 +0100, Hans de Goede wrote:
> Hi,
>
> On 2/15/21 12:31 PM, gre...@linuxfoundation.org wrote:
> > On Mon, Feb 15, 2021 at 11:37:26AM +0100, Hans de Goede wrote:
> > > Hi,
> > >
> > > On 2/15/21 8:22 AM, Vaittinen, Matti wrote:
On Thu, 2021-02-11 at 14:35 +0200, Matti Vaittinen wrote:
> Provide helper function for IC's implementing regulator notifications
> when an IRQ fires. The helper also works for IRQs which can not be
> acked.
> Helper can be set to disable the IRQ at handler and then re-enabling
> it
> on delayed
On Sat, 2021-02-13 at 16:59 +0100, Hans de Goede wrote:
> Hi,
>
> On 2/13/21 4:27 PM, Guenter Roeck wrote:
> > On 2/13/21 7:03 AM, Hans de Goede wrote:
> > [ ... ]
> > > I think something like this should work:
> > >
> > > static int devm_delayed_work_autocancel(struct device *dev,
> > > struct
On Sat, 2021-02-13 at 13:16 +0100, Greg Kroah-Hartman wrote:
> On Sat, Feb 13, 2021 at 01:58:44PM +0200, Matti Vaittinen wrote:
> > A few drivers which need a delayed work-queue must cancel work at
> > exit.
> > Some of those implement remove solely for this purpose. Help
> > drivers
> > to avoid
g to go through _all_ drivers, but I guess I
could go through at least few of them :)
And sorry for noise if this has been suggested and rejected before - I
didn't spot something like this from mail lists. (Maybe I am missing
something?)
Best Regards
Matti Vaittinen
--
Matti Vaittinen, Linux
Hello Again Lee & All,
On Wed, 2021-02-10 at 09:01 +0200, Matti Vaittinen wrote:
> On Tue, 2021-02-09 at 15:25 +, Lee Jones wrote:
> > On Fri, 22 Jan 2021, Matti Vaittinen wrote:
> > + /* BD9573 only supports fatal IRQs which we do not
> > > handle */
> >
> > Why not?
>
> Because
Hello Lee, Mark All,
On Fri, 2021-01-22 at 16:30 +0200, Matti Vaittinen wrote:
> Initial support for ROHM BD9576MUF and BD9573MUF PMICs.
>
> These PMICs are primarily intended to be used to power the R-Car
> family
> processors. BD9576MUF includes some additional safety features the
> BD9573MUF
Hello Again Rob,
And thanks for reviewing the bindings!
On Mon, 2021-02-08 at 20:24 -0600, Rob Herring wrote:
> On Tue, Jan 19, 2021 at 09:17:09AM +0200, Matti Vaittinen wrote:
> > Add binding documentation for regulators on ROHM BD71815 PMIC.
> > 5 bucks, 7 LDOs and a boost for LED.
> >
> >
On Thu, 2021-01-28 at 12:10 +, Mark Brown wrote:
> On Thu, Jan 28, 2021 at 09:23:08AM +0000, Vaittinen, Matti wrote:
> > On Wed, 2021-01-27 at 16:32 +, Mark Brown wrote:
> > > Note that the events the API currently has are expected to be for
> > > the
&g
On Wed, 2021-01-27 at 16:32 +, Mark Brown wrote:
> On Wed, Jan 27, 2021 at 03:34:46PM +0100, AngeloGioacchino Del Regno
> wrote:
> > Il 27/01/21 13:56, Matti Vaittinen ha scritto:
> > > I can only speak for BD9576MUF - which has two limits for
> > > monitored
> > > entity
wrote:
> > > On Wed, Jan 27, 2021 at 12:01:55PM +, Vaittinen, Matti wrote:
>
> > I will see if I can cook-up something decent - but as I said, I
> > would
> > appreciate any/all testing if I get patch crafted :)
>
> I develop this stuff in my spare time
Hi dee Ho peeps,
I just noticed the
390af53e04114f790d60b63802a4de9d815ade03 ("regulator: qcom-labibb:
Implement short-circuit and over-current IRQs")
in regulator tree. No worries - I haven't hit any problem with it :]
I've been working with ROHM BD9576MUF - which implements warning IRQs
for
Hi Bartosz,
On Tue, 2021-01-19 at 12:07 +0100, Bartosz Golaszewski wrote:
> On Tue, Jan 19, 2021 at 8:23 AM Matti Vaittinen
> wrote:
> > Support GPO(s) found from ROHM BD71815 power management IC. The IC
> > has two
> > GPO pins but only one is properly documented in data-sheet. The
> > driver
>
On Fri, 2021-01-15 at 14:41 +, Lee Jones wrote:
> On Fri, 15 Jan 2021, Matti Vaittinen wrote:
>
> > The ROHM BD718x7 and BD71828 drivers support setting HW state
> > specific voltages from device-tree. This is used also by various
> > in-tree DTS files.
> >
> > These drivers do incorrectly
On Fri, 2021-01-15 at 13:47 +, Lee Jones wrote:
> On Fri, 15 Jan 2021, Matti Vaittinen wrote:
>
> > The ROHM BD718x7 and BD71828 drivers support setting HW state
> > specific voltages from device-tree. This is used also by various
> > in-tree DTS files.
> >
> > These drivers do incorrectly
Hello Lee,
Thanks for carefull review! I do appreciate this!
On Fri, 2021-01-15 at 08:26 +, Lee Jones wrote:
> On Fri, 08 Jan 2021, Matti Vaittinen wrote:
>
> > The helper for obtaining HW-state based DVS voltage levels
> > currently only
> > works for regulators using linear-ranges. Extend
Hello Lee,
Nice to see you are back :)
On Thu, 2021-01-14 at 10:00 +, Lee Jones wrote:
> On Tue, 29 Dec 2020, Vaittinen, Matti wrote:
>
> > Hello Again peeps,
> >
> > On Thu, 2020-12-17 at 12:04 +0200, Matti Vaittinen wrote:
> > > On Wed, 2020-12-02 at 1
On Wed, 2021-01-13 at 07:53 -0600, Rob Herring wrote:
> On Tue, Jan 12, 2021 at 08:10:14AM +0200, Matti Vaittinen wrote:
> > On Mon, 2021-01-11 at 13:09 -0600, Rob Herring wrote:
> > > On Fri, Jan 08, 2021 at 03:36:38PM +0200, Matti Vaittinen wrote:
> > > > Add binding documentation for
On Mon, 2021-01-11 at 13:06 -0600, Rob Herring wrote:
> On Fri, Jan 08, 2021 at 03:34:52PM +0200, Matti Vaittinen wrote:
> > Document DT bindings for ROHM BD71815.
> >
> > BD71815 is a single-chip power management IC mainly for battery-
> > powered
> > portable devices. The IC integrates 5
On Mon, 2021-01-11 at 13:38 +0100, Matthias Brugger wrote:
> Hi Matti,
>
> On 11/01/2021 11:32, Vaittinen, Matti wrote:
> > Hello Matthias & All,
> >
> > On Mon, 2021-01-11 at 11:08 +0100, Matthias Brugger wrote:
> > > On 11/01/2021 03:18, gene_chen(陳俊宇)
ces.
As a "tradeoff" subdevices must retrieve the DT node from the parent
device.
For my uneducated eyes the DT binding for regulators should be changed.
Compatible should not be required and the example node should be moved
to MFD binding document in the MFD node. But that's just my v
Hello Peeps,
On Thu, 2020-12-24 at 11:19 +0800, Gene Chen wrote:
> From: Gene Chen
>
> Add bindings for MT6360 PMIC
>
> Signed-off-by: Gene Chen
> ---
> Documentation/devicetree/bindings/mfd/mt6360.yaml | 69
> +++
> 1 file changed, 69 insertions(+)
> create mode 100644
On Mon, 2021-01-11 at 08:15 +0200, Matti Vaittinen wrote:
> On Sat, 2021-01-09 at 01:45 +0100, Linus Walleij wrote:
> > On Fri, Jan 8, 2021 at 2:39 PM Matti Vaittinen
> > wrote:
> >
> > > Support GPO(s) found from ROHM BD71815 power management IC. The
> > > IC
> > > has two
> > > GPO pins but
Hi Linus,
Thanks a lot for review!
On Sat, 2021-01-09 at 01:45 +0100, Linus Walleij wrote:
> On Fri, Jan 8, 2021 at 2:39 PM Matti Vaittinen
> wrote:
>
> > Support GPO(s) found from ROHM BD71815 power management IC. The IC
> > has two
> > GPO pins but only one is properly documented in
On Thu, 2021-01-07 at 20:15 +0200, Matti Vaittinen wrote:
> Thanks a lot for taking a careful look at this Guenter!
>
> On Thu, 2021-01-07 at 07:12 -0800, Guenter Roeck wrote:
> > On Thu, Jan 07, 2021 at 08:37:03AM +0200, Matti Vaittinen wrote:
> > > If config for BD70528 watchdog is enabled
Thanks a lot for taking a careful look at this Guenter!
On Thu, 2021-01-07 at 07:12 -0800, Guenter Roeck wrote:
> On Thu, Jan 07, 2021 at 08:37:03AM +0200, Matti Vaittinen wrote:
> > If config for BD70528 watchdog is enabled when BD71828 or BD71815
> > are used the RTC module will issue call to
Thanks for making this better :)
On Wed, 2021-01-06 at 11:11 +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski
>
> Using a helper local variable to store the address of >dev adds
> to readability and allows us to avoid unnecessary line breaks.
>
> Signed-off-by: Bartosz Golaszewski
Hello Again peeps,
On Thu, 2020-12-17 at 12:04 +0200, Matti Vaittinen wrote:
> On Wed, 2020-12-02 at 15:32 +0200, Matti Vaittinen wrote:
> > Hello Lee,
> >
> > On Wed, 2020-12-02 at 12:57 +, Lee Jones wrote:
> > > On Fri, 27 Nov 2020, Vaittinen, Matti w
On Tue, 2020-12-22 at 09:23 +, Yoshihiro Shimoda wrote:
> Hi Geert-san,
>
> Thank you for your review!
>
> > From: Geert Uytterhoeven, Sent: Tuesday, December 22, 2020 5:53 PM
> > On Mon, Dec 21, 2020 at 3:56 AM Yoshihiro Shimoda
> > wrote:
>
> > > --- a/drivers/mfd/bd9571mwv.c
> > > +++
On Tue, 2020-12-22 at 09:25 +, Yoshihiro Shimoda wrote:
> Hi Matti-san,
>
> > From: Vaittinen, Matti, Sent: Tuesday, December 22, 2020 6:15 PM
> >
> > On Tue, 2020-12-22 at 09:49 +0100, Geert Uytterhoeven wrote:
> > > On Mon, Dec 21, 2020 at 3:57
On Tue, 2020-12-22 at 09:49 +0100, Geert Uytterhoeven wrote:
> On Mon, Dec 21, 2020 at 3:57 AM Yoshihiro Shimoda
> wrote:
> > Use dev_regmap_add_irq_chip() to simplify the code.
> >
> > Signed-off-by: Yoshihiro Shimoda
> > Acked-for-MFD-by: Lee Jones
>
> Reviewed-by: Geert Uytterhoeven
On Tue, 2020-12-22 at 09:41 +0100, Geert Uytterhoeven wrote:
> On Mon, Dec 21, 2020 at 3:57 AM Yoshihiro Shimoda
> wrote:
> > To remove mfd devices when unload this driver, should use
> > devm_mfd_add_devices() instead.
> >
> > Fixes: d3ea21272094 ("mfd: Add ROHM BD9571MWV-M MFD PMIC driver")
>
Thanks for corrections!
On Sun, 2020-12-20 at 20:06 -0800, Randy Dunlap wrote:
> Change "which which" to "for which" in 3 places.
> Change "ranges" to possessive "range's" in 1 place.
>
> Signed-off-by: Randy Dunlap
> Cc: Andrew Morton
> Cc: Mark Brown
> Cc: Matti Vaittinen
Reviewed-by:
On Fri, 2020-12-18 at 19:38 +0100, Guido Günther wrote:
> Use the typical startup times from the data sheet so boards get a
> reasonable default. Not setting any enable time can lead to board
> hangs
> when e.g. clocks are enabled too soon afterwards.
>
> This fixes gpu power domain resume on
On Wed, 2020-12-16 at 13:41 +0100, Guido Günther wrote:
> Hi Matti,
> On Wed, Dec 16, 2020 at 12:29:20PM +, Vaittinen, Matti wrote:
> > Hello Guido,
> >
> > Thanks for looking at this!
> >
> > On Wed, 2020-12-16 at 12:05 +0100, Guido Günther wrote:
>
Hi deee Ho Lee,
On Wed, 2020-12-02 at 15:32 +0200, Matti Vaittinen wrote:
> Hello Lee,
>
> On Wed, 2020-12-02 at 12:57 +, Lee Jones wrote:
> > On Fri, 27 Nov 2020, Vaittinen, Matti wrote:
> >
> > > Hello Lee,
> > >
> > > On Fri, 2020-11-27
On Wed, 2020-12-16 at 08:53 +, Lee Jones wrote:
> On Fri, 04 Dec 2020, Matti Vaittinen wrote:
>
> > Add BD71827 driver header. For a record - Header is originally
> > based on work authored by Cong Pham although not much of original
> > work is left now.
> >
> > Signed-off-by: Matti
On Wed, 2020-12-16 at 12:48 +, Mark Brown wrote:
> On Wed, Dec 16, 2020 at 01:41:33PM +0100, Guido Günther wrote:
> > On Wed, Dec 16, 2020 at 12:29:20PM +, Vaittinen, Matti wrote:
> > > > + .enable_time = 144,
> > > Where are thes
Hello Guido,
Thanks for looking at this!
On Wed, 2020-12-16 at 12:05 +0100, Guido Günther wrote:
> Use the typical startup times from the data sheet so boards get a
> reasonable default. Not setting any enable time can lead to board
> hangs
> when e.g. clocks are enabled too soon afterwards.
>
On Wed, 2020-12-16 at 09:02 +, Lee Jones wrote:
> On Wed, 16 Dec 2020, Vaittinen, Matti wrote:
>
> > On Wed, 2020-12-16 at 16:37 +0900, Yoshihiro Shimoda wrote:
> > > From: Khiem Nguyen
> > >
> > > The new PMIC BD9574MWF inherits features from BD957
On Wed, 2020-12-16 at 09:00 +, Lee Jones wrote:
> On Wed, 16 Dec 2020, Vaittinen, Matti wrote:
>
> > On Wed, 2020-12-16 at 16:37 +0900, Yoshihiro Shimoda wrote:
> > > From: Khiem Nguyen
> > >
> > > Since the driver supports BD9571MWV PMIC only,
> &
On Wed, 2020-12-16 at 10:25 +0200, Matti Vaittinen wrote:
> On Wed, 2020-12-16 at 16:37 +0900, Yoshihiro Shimoda wrote:
> > From: Khiem Nguyen
> >
> > Since the driver supports BD9571MWV PMIC only,
> > this patch makes the functions and data structure become more
> > generic
> > so that it can
On Wed, 2020-12-16 at 16:37 +0900, Yoshihiro Shimoda wrote:
> From: Khiem Nguyen
>
> The new PMIC BD9574MWF inherits features from BD9571MWV.
> Add the support of new PMIC to existing bd9571mwv driver.
>
> Signed-off-by: Khiem Nguyen
> [shimoda: rebase and refactor]
> Signed-off-by: Yoshihiro
On Wed, 2020-12-16 at 16:37 +0900, Yoshihiro Shimoda wrote:
> From: Khiem Nguyen
>
> Since the driver supports BD9571MWV PMIC only,
> this patch makes the functions and data structure become more generic
> so that it can support other PMIC variants as well.
>
> Signed-off-by: Khiem Nguyen
>
On Wed, 2020-12-16 at 16:37 +0900, Yoshihiro Shimoda wrote:
> Use dev_regmap_add_irq_chip() to simplify the code.
>
> Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Matti Vaittinen
> ---
> drivers/mfd/bd9571mwv.c | 27 ++-
> 1 file changed, 6 insertions(+), 21
On Wed, 2020-12-16 at 06:29 +, Yoshihiro Shimoda wrote:
> Hi Matti-san,
>
> > From: Vaittinen, Matti, Sent: Wednesday, December 16, 2020 3:00 PM
> > On Wed, 2020-12-16 at 02:13 +, Yoshihiro Shimoda wrote:
> > > Hi Geert-san, Matti-san,
> > >
&g
gt; > > On Fri, Dec 11, 2020 at 3:03 PM Vaittinen, Matti
> > > wrote:
> > > > On Fri, 2020-12-11 at 20:27 +0900, Yoshihiro Shimoda wrote:
>
> > > > > --- a/drivers/regulator/bd9571mwv-regulator.c
> > > > > +++ b/drivers/regulator/
Hello Shimoda-san,
On Mon, 2020-12-14 at 04:57 +, Yoshihiro Shimoda wrote:
> Hello Matti-san,
>
> > From: Vaittinen, Matti, Sent: Friday, December 11, 2020 9:34 PM
> >
> > Hello again Shimada-san,
> >
> > On Fri, 2020-12-11 at 20:27 +0900, Yoshih
Hi Yoshihiro-san,
On Fri, 2020-12-11 at 20:27 +0900, Yoshihiro Shimoda wrote:
> From: Khiem Nguyen
>
> Since the driver supports BD9571MWV PMIC only,
> this patch makes the functions and data structure become more generic
> so that it can support other PMIC variants as well.
>
>
On Fri, 2020-12-11 at 20:27 +0900, Yoshihiro Shimoda wrote:
> Add support for BD9574MWF which is silimar chip with BD9571MWV.
> Note that BD9574MWF has an additional feature, but doesn't
> support it for now.
nit:
Perhaps mention which feature? And I think you mean the driver does not
support it
On Fri, 2020-12-11 at 20:27 +0900, Yoshihiro Shimoda wrote:
> To simplify this driver, use dev_get_regmap() and
> rid of using struct bd9571mwv.
>
> Signed-off-by: Yoshihiro Shimoda
FWIW:
Reviewed-By: Matti Vaittinen
> ---
> drivers/gpio/gpio-bd9571mwv.c | 19 +--
> 1 file
Hello again Shimada-san,
On Fri, 2020-12-11 at 20:27 +0900, Yoshihiro Shimoda wrote:
> Add support for BD9574MWF which is silimar chip with BD9571MWV.
> Note that BD9574MWF doesn't support AVS and VID.
I'd like to understand what is VID?
>
> Signed-off-by: Yoshihiro Shimoda
> ---
>
On Fri, 2020-12-11 at 20:27 +0900, Yoshihiro Shimoda wrote:
> To simplify this driver, use dev_get_regmap() and
> rid of using struct bd9571mwv.
>
> Signed-off-by: Yoshihiro Shimoda
> ---
> drivers/regulator/bd9571mwv-regulator.c | 49 +
>
> 1 file changed, 26
CHIP_TYPE_BD71828,
> + ROHM_CHIP_TYPE_BD9571,
> + ROHM_CHIP_TYPE_BD9574,
> ROHM_CHIP_TYPE_AMOUNT
> };
>
Just a note to Lee & Others:
This will probably conflict with the BD9573/BD9576 patch series (which
introduces those chip IDs here). Conflict should be trivial though.
With that note:
Reviewed-By: Matti Vaittinen
--Matti
Hi Yoshihiro san,
On Thu, 2020-12-10 at 10:58 +, Yoshihiro Shimoda wrote:
> Hi Matti,
>
> > From: Vaittinen, Matti, Sent: Thursday, December 10, 2020 5:28 PM
> >
> > On Tue, 2020-12-08 at 17:04 +0900, Yoshihiro Shimoda wrote:
> > > From: Khiem Nguyen
&g
On Thu, 2020-12-10 at 09:19 +0100, Geert Uytterhoeven wrote:
> Hi Matti, Shimoda-san,
>
> On Thu, Dec 10, 2020 at 8:33 AM Vaittinen, Matti
> wrote:
> > On Thu, 2020-12-10 at 04:44 +, Yoshihiro Shimoda wrote:
> > > > From: Geert Uytterhoeven, Sent: Wednesday,
On Tue, 2020-12-08 at 17:04 +0900, Yoshihiro Shimoda wrote:
> From: Khiem Nguyen
>
> The new PMIC BD9574MWF inherits features from BD9571MWV.
> Add the support of new PMIC to existing bd9571mwv driver.
>
> Signed-off-by: Khiem Nguyen
> [shimoda: rebase and refactor]
> Signed-off-by: Yoshihiro
On Thu, 2020-12-10 at 04:44 +, Yoshihiro Shimoda wrote:
> Hi Geert-san,
>
> Thank you for your review!
>
> > From: Geert Uytterhoeven, Sent: Wednesday, December 9, 2020 10:30
> > PM
>
> > > --- a/drivers/mfd/bd9571mwv.c
> > > +++ b/drivers/mfd/bd9571mwv.c
> > >
> > > @@ -182,6 +272,8 @@
Hi deee Ho Yoshihiro-san, Geert, All,
On Wed, 2020-12-09 at 14:30 +0100, Geert Uytterhoeven wrote:
> Hi Shimoda-san,
>
> CC Matti (BD9573/6 driver for R-Car platforms)
Thank Geert! I wouldn't have noticed this :)
>
> (I don't have the BD9574 datasheet, so I have to base my review on
>
Hi deee Ho Linus,
Thanks (again) for taking a look at this! Highly appreciated :]
On Tue, 2020-12-08 at 09:54 +0100, Linus Walleij wrote:
> On Fri, Dec 4, 2020 at 1:41 PM Matti Vaittinen
> wrote:
>
> > The power-supply core supports concept of OCV (Open Circuit
> > Voltage) =>
> > SOC (State
On Wed, 2020-12-02 at 12:57 +, Lee Jones wrote:
> On Fri, 27 Nov 2020, Vaittinen, Matti wrote:
>
> > Hello Lee,
> >
> > On Fri, 2020-11-27 at 08:32 +, Lee Jones wrote:
> > > On Mon, 23 Nov 2020, Matti Vaittinen wrote:
> > >
> > > > A
Hello Lee,
On Wed, 2020-12-02 at 12:57 +, Lee Jones wrote:
> On Fri, 27 Nov 2020, Vaittinen, Matti wrote:
>
> > Hello Lee,
> >
> > On Fri, 2020-11-27 at 08:32 +, Lee Jones wrote:
> > > On Mon, 23 Nov 2020, Matti Vaittinen wrote:
> > >
&
Hello Lee,
On Fri, 2020-11-27 at 08:32 +, Lee Jones wrote:
> On Mon, 23 Nov 2020, Matti Vaittinen wrote:
>
> > Add core support for ROHM BD9576MUF and BD9573MUF PMICs which are
> > mainly used to power the R-Car series processors.
> >
> > Signed-off-by: Matti Vaittinen
> > ---
> >
On Thu, 2020-11-26 at 12:13 +0200, Matti Vaittinen wrote:
> Add generic 'sw gauge' helper for performing iterative SOC estimation
> and coulomb counter correction for devices with a (drifting) coulomb
> counter. This should allow few charger/fuel-gauge drivers to use
> generic
> loop instead of
On Wed, 2020-11-11 at 06:41 -0800, Guenter Roeck wrote:
> On 11/11/20 6:01 AM, Vaittinen, Matti wrote:
> > On Thu, 2020-11-05 at 13:38 +0200, Matti Vaittinen wrote:
> > > Add Watchdog support for ROHM BD9576MUF and BD9573MUF PMICs which
> > > are
> > > m
On Thu, 2020-11-05 at 13:38 +0200, Matti Vaittinen wrote:
> Add Watchdog support for ROHM BD9576MUF and BD9573MUF PMICs which are
> mainly used to power the R-Car series processors. The watchdog is
> pinged using a GPIO and enabled using another GPIO. Additionally
> watchdog time-out can be
On Thu, 2020-11-05 at 08:58 +, Lee Jones wrote:
> On Thu, 05 Nov 2020, Vaittinen, Matti wrote:
>
> > On Thu, 2020-11-05 at 08:21 +, Lee Jones wrote:
> > > On Thu, 05 Nov 2020, Vaittinen, Matti wrote:
> > >
> > > > On Thu, 2020-1
On Thu, 2020-11-05 at 08:23 +, Lee Jones wrote:
> On Wed, 04 Nov 2020, Lee Jones wrote:
>
> > On Wed, 28 Oct 2020, Matti Vaittinen wrote:
> >
> > > Add core support for ROHM BD9576MUF and BD9573MUF PMICs which are
> > > mainly used to power the R-Car series processors.
> > >
> > >
On Thu, 2020-11-05 at 08:21 +, Lee Jones wrote:
> On Thu, 05 Nov 2020, Vaittinen, Matti wrote:
>
> > On Thu, 2020-11-05 at 08:46 +0200, Matti Vaittinen wrote:
> > > Morning Lee,
> > >
> > > Thanks for taking a look at this :) I see most of the comments
On Thu, 2020-11-05 at 08:46 +0200, Matti Vaittinen wrote:
> Morning Lee,
>
> Thanks for taking a look at this :) I see most of the comments being
> valid. There's two I would like to clarify though...
>
> On Wed, 2020-11-04 at 15:51 +, Lee Jones wrote:
> > On Wed, 28 Oct 2020, Matti
Morning Lee,
Thanks for taking a look at this :) I see most of the comments being
valid. There's two I would like to clarify though...
On Wed, 2020-11-04 at 15:51 +, Lee Jones wrote:
> On Wed, 28 Oct 2020, Matti Vaittinen wrote:
>
> > Add core support for ROHM BD9576MUF and BD9573MUF PMICs
Hello,
On Wed, 2020-10-21 at 07:39 -0700, Joe Perches wrote:
> On Wed, 2020-10-21 at 07:25 +0000, Vaittinen, Matti wrote:
> > Hello Joe & All,
> > On Tue, 2020-10-20 at 11:36 -0700, Joe Perches wrote:
> > > On Tue, 2020-10-20 at 11:48 +, Vaittinen, Matti wrote:
&g
On Tue, 2020-10-20 at 14:46 +0300, Andy Shevchenko wrote:
> On Tue, Oct 20, 2020 at 2:26 PM Vaittinen, Matti
> wrote:
> > On Mon, 2020-10-19 at 12:33 -0700, t...@redhat.com wrote:
> > > - break;
> > My personal taste is also to omit these breaks but I a
On Tue, 2020-10-20 at 13:07 +0300, Matti Vaittinen wrote:
> Thanks Tom,
>
> On Mon, 2020-10-19 at 12:33 -0700, t...@redhat.com wrote:
> > From: Tom Rix
> >
> > A break is not needed if it is preceded by a return
> >
> > Signed-off-by: Tom Rix
> > ---
> > drivers/gpio/gpio-bd70528.c | 3 ---
>
Thanks Tom,
On Mon, 2020-10-19 at 12:33 -0700, t...@redhat.com wrote:
> From: Tom Rix
>
> A break is not needed if it is preceded by a return
>
> Signed-off-by: Tom Rix
> ---
> drivers/gpio/gpio-bd70528.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpio/gpio-bd70528.c
Hi dee Ho peeps!
On Thu, 2020-09-24 at 09:12 +0300, Matti Vaittinen wrote:
> On Wed, 2020-09-23 at 08:27 -0600, Rob Herring wrote:
> > On Sat, Sep 19, 2020 at 5:46 AM Vaittinen, Matti
> > wrote:
> > > Thanks Rob for taking a look at this!
> > >
> > &
On Wed, 2020-09-23 at 08:27 -0600, Rob Herring wrote:
> On Sat, Sep 19, 2020 at 5:46 AM Vaittinen, Matti
> wrote:
> > Thanks Rob for taking a look at this!
> >
> > On Fri, 2020-09-18 at 11:28 -0600, Rob Herring wrote:
> > > On Thu, Sep 17, 2020 at 11:01:
Thanks Rob for taking a look at this!
On Fri, 2020-09-18 at 11:28 -0600, Rob Herring wrote:
> On Thu, Sep 17, 2020 at 11:01:52AM +0300, Matti Vaittinen wrote:
> > Add bindings for ROHM BD9576MUF and BD9573MUF PMICs. These
> > PMICs are primarily intended to be used to power the R-Car series
> >
1 - 100 of 171 matches
Mail list logo
