Re: [PATCH] net: Adding parameter detection in __ethtool_get_link_ksettings.

2019-08-29 Thread Michal Kubecek
On Tue, Aug 27, 2019 at 07:01:41PM +, Saeed Mahameed wrote: > On Mon, 2019-08-26 at 17:47 +0800, Dongxu Liu wrote: > > > Maybe "if (!dev->ethtool_ops)" is more accurate for this bug. > > > > Also i am not sure about this, could be a bug in the device driver your > enslaving. > >

Re: [PATCH] net: Adding parameter detection in __ethtool_get_link_ksettings.

2019-08-27 Thread Saeed Mahameed
On Mon, 2019-08-26 at 17:47 +0800, Dongxu Liu wrote: > > On 8/26/19 9:23 AM, Dongxu Liu wrote: > > The __ethtool_get_link_ksettings symbol will be exported, > > and external users may use an illegal address. > > We should check the parameters before using them, > > otherwise the system will crash.

Re: [PATCH] net: Adding parameter detection in __ethtool_get_link_ksettings.

2019-08-26 Thread Dongxu Liu
> On 8/26/19 9:23 AM, Dongxu Liu wrote: > The __ethtool_get_link_ksettings symbol will be exported, > and external users may use an illegal address. > We should check the parameters before using them, > otherwise the system will crash. > > [ 8980.991134] BUG: unable to handle kernel NULL pointer

Re: [PATCH] net: Adding parameter detection in __ethtool_get_link_ksettings.

2019-08-26 Thread Eric Dumazet
On 8/26/19 9:23 AM, Dongxu Liu wrote: > The __ethtool_get_link_ksettings symbol will be exported, > and external users may use an illegal address. > We should check the parameters before using them, > otherwise the system will crash. > > [ 8980.991134] BUG: unable to handle kernel NULL pointer

[PATCH] net: Adding parameter detection in __ethtool_get_link_ksettings.

2019-08-26 Thread Dongxu Liu
The __ethtool_get_link_ksettings symbol will be exported, and external users may use an illegal address. We should check the parameters before using them, otherwise the system will crash. [ 8980.991134] BUG: unable to handle kernel NULL pointer dereference at (null) [ 8980.993049] IP: