Re: [PATCH] nfs lockd reclaimer: Convert to kthread API

2007-04-21 Thread Eric W. Biederman
Trond Myklebust <[EMAIL PROTECTED]> writes: > On Thu, 2007-04-19 at 14:40 -0700, Andrew Morton wrote: >> Using signals to communicate with kernel threads is fairly unpleasant, IMO. >> We have much simpler, faster and more idiomatic ways of communicating >> between threads in-kernel and there are

Re: [PATCH] nfs lockd reclaimer: Convert to kthread API

2007-04-21 Thread Eric W. Biederman
Dave Hansen <[EMAIL PROTECTED]> writes: > On Thu, 2007-04-19 at 17:19 -0400, Trond Myklebust wrote: >> > With pid namespaces all kernel threads will disappear so how do >> > we cope with the problem when the sysadmin can not see the kernel >> > threads? > > Do they actually always disappear, or

Re: [PATCH] nfs lockd reclaimer: Convert to kthread API

2007-04-21 Thread Eric W. Biederman
Dave Hansen [EMAIL PROTECTED] writes: On Thu, 2007-04-19 at 17:19 -0400, Trond Myklebust wrote: With pid namespaces all kernel threads will disappear so how do we cope with the problem when the sysadmin can not see the kernel threads? Do they actually always disappear, or do we keep them

Re: [PATCH] nfs lockd reclaimer: Convert to kthread API

2007-04-21 Thread Eric W. Biederman
Trond Myklebust [EMAIL PROTECTED] writes: On Thu, 2007-04-19 at 14:40 -0700, Andrew Morton wrote: Using signals to communicate with kernel threads is fairly unpleasant, IMO. We have much simpler, faster and more idiomatic ways of communicating between threads in-kernel and there are better

Re: [PATCH] nfs lockd reclaimer: Convert to kthread API

2007-04-19 Thread Trond Myklebust
On Thu, 2007-04-19 at 14:40 -0700, Andrew Morton wrote: > Using signals to communicate with kernel threads is fairly unpleasant, IMO. > We have much simpler, faster and more idiomatic ways of communicating > between threads in-kernel and there are better ways in which userspace can > communicate

Re: [PATCH] nfs lockd reclaimer: Convert to kthread API

2007-04-19 Thread Andrew Morton
On Thu, 19 Apr 2007 17:19:24 -0400 Trond Myklebust <[EMAIL PROTECTED]> wrote: > > Regardless kernel threads should be an implementation detail > > not a part of the user interface. If kernel threads are part > > of the user interface it makes them very hard to change. > > > > So it isn't that

Re: [PATCH] nfs lockd reclaimer: Convert to kthread API

2007-04-19 Thread Dave Hansen
On Thu, 2007-04-19 at 17:19 -0400, Trond Myklebust wrote: > > With pid namespaces all kernel threads will disappear so how do > > we cope with the problem when the sysadmin can not see the kernel > > threads? Do they actually always disappear, or do we keep them in the init_pid_namespace? --

Re: [PATCH] nfs lockd reclaimer: Convert to kthread API

2007-04-19 Thread Trond Myklebust
On Thu, 2007-04-19 at 13:20 -0600, Eric W. Biederman wrote: > Trond Myklebust <[EMAIL PROTECTED]> writes: > > > On Thu, 2007-04-19 at 01:58 -0600, Eric W. Biederman wrote: > >> From: Eric W. Biederman <[EMAIL PROTECTED]> > >> > >> Start the reclaimer thread using kthread_run instead > >> of a

Re: [PATCH] nfs lockd reclaimer: Convert to kthread API

2007-04-19 Thread Eric W. Biederman
Trond Myklebust <[EMAIL PROTECTED]> writes: > On Thu, 2007-04-19 at 01:58 -0600, Eric W. Biederman wrote: >> From: Eric W. Biederman <[EMAIL PROTECTED]> >> >> Start the reclaimer thread using kthread_run instead >> of a combination of kernel_thread and daemonize. >> The small amount of signal

Re: [PATCH] nfs lockd reclaimer: Convert to kthread API

2007-04-19 Thread Trond Myklebust
On Thu, 2007-04-19 at 01:58 -0600, Eric W. Biederman wrote: > From: Eric W. Biederman <[EMAIL PROTECTED]> > > Start the reclaimer thread using kthread_run instead > of a combination of kernel_thread and daemonize. > The small amount of signal handling code is also removed > as it makes no sense

[PATCH] nfs lockd reclaimer: Convert to kthread API

2007-04-19 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> Start the reclaimer thread using kthread_run instead of a combination of kernel_thread and daemonize. The small amount of signal handling code is also removed as it makes no sense and is a maintenance problem to handle signals in kernel threads. Cc:

[PATCH] nfs lockd reclaimer: Convert to kthread API

2007-04-19 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted Start the reclaimer thread using kthread_run instead of a combination of kernel_thread and daemonize. The small amount of signal handling code is also removed as it makes no sense and is a maintenance problem to handle signals in kernel

[PATCH] nfs lockd reclaimer: Convert to kthread API

2007-04-19 Thread Eric W. Biederman
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted Start the reclaimer thread using kthread_run instead of a combination of kernel_thread and daemonize. The small amount of signal handling code is also removed as it makes no sense and is a maintenance problem to handle signals in kernel

[PATCH] nfs lockd reclaimer: Convert to kthread API

2007-04-19 Thread Eric W. Biederman
From: Eric W. Biederman [EMAIL PROTECTED] Start the reclaimer thread using kthread_run instead of a combination of kernel_thread and daemonize. The small amount of signal handling code is also removed as it makes no sense and is a maintenance problem to handle signals in kernel threads. Cc: Neil

Re: [PATCH] nfs lockd reclaimer: Convert to kthread API

2007-04-19 Thread Trond Myklebust
On Thu, 2007-04-19 at 01:58 -0600, Eric W. Biederman wrote: From: Eric W. Biederman [EMAIL PROTECTED] Start the reclaimer thread using kthread_run instead of a combination of kernel_thread and daemonize. The small amount of signal handling code is also removed as it makes no sense and is a

Re: [PATCH] nfs lockd reclaimer: Convert to kthread API

2007-04-19 Thread Eric W. Biederman
Trond Myklebust [EMAIL PROTECTED] writes: On Thu, 2007-04-19 at 01:58 -0600, Eric W. Biederman wrote: From: Eric W. Biederman [EMAIL PROTECTED] Start the reclaimer thread using kthread_run instead of a combination of kernel_thread and daemonize. The small amount of signal handling code is

Re: [PATCH] nfs lockd reclaimer: Convert to kthread API

2007-04-19 Thread Trond Myklebust
On Thu, 2007-04-19 at 13:20 -0600, Eric W. Biederman wrote: Trond Myklebust [EMAIL PROTECTED] writes: On Thu, 2007-04-19 at 01:58 -0600, Eric W. Biederman wrote: From: Eric W. Biederman [EMAIL PROTECTED] Start the reclaimer thread using kthread_run instead of a combination of

Re: [PATCH] nfs lockd reclaimer: Convert to kthread API

2007-04-19 Thread Dave Hansen
On Thu, 2007-04-19 at 17:19 -0400, Trond Myklebust wrote: With pid namespaces all kernel threads will disappear so how do we cope with the problem when the sysadmin can not see the kernel threads? Do they actually always disappear, or do we keep them in the init_pid_namespace? -- Dave -

Re: [PATCH] nfs lockd reclaimer: Convert to kthread API

2007-04-19 Thread Andrew Morton
On Thu, 19 Apr 2007 17:19:24 -0400 Trond Myklebust [EMAIL PROTECTED] wrote: Regardless kernel threads should be an implementation detail not a part of the user interface. If kernel threads are part of the user interface it makes them very hard to change. So it isn't that it doesn't

Re: [PATCH] nfs lockd reclaimer: Convert to kthread API

2007-04-19 Thread Trond Myklebust
On Thu, 2007-04-19 at 14:40 -0700, Andrew Morton wrote: Using signals to communicate with kernel threads is fairly unpleasant, IMO. We have much simpler, faster and more idiomatic ways of communicating between threads in-kernel and there are better ways in which userspace can communicate with