Re: [PATCH] usb: dwc3: qcom: Fixed an issue that the ret value is incorrect in dwc3_qcom_probe()

2021-04-09 Thread Bixuan Cui
On 2021/4/9 18:00, Manivannan Sadhasivam wrote: > But this error message can be removed altogether as devm_ioremap_resource() > reports it already. Thank you for your reply. I'll revise it. Thanks, Bixuan Cui

Re: [PATCH] usb: dwc3: qcom: Fixed an issue that the ret value is incorrect in dwc3_qcom_probe()

2021-04-09 Thread Manivannan Sadhasivam
On Fri, Apr 09, 2021 at 08:49:45AM +0800, Bixuan Cui wrote: > There is a error message after devm_ioremap_resource failed, and the ret > is needs to be obtained through PTR_ERR(qcom->qscratch_base). > We need to move the dev_err() downwards to ensure that the ret value is > correct. > > Fixes:

[PATCH] usb: dwc3: qcom: Fixed an issue that the ret value is incorrect in dwc3_qcom_probe()

2021-04-08 Thread Bixuan Cui
There is a error message after devm_ioremap_resource failed, and the ret is needs to be obtained through PTR_ERR(qcom->qscratch_base). We need to move the dev_err() downwards to ensure that the ret value is correct. Fixes: a4333c3a6ba9 ('usb: dwc3: Add Qualcomm DWC3 glue driver') Reported-by: