Re: [PATCH 2/2] mm: Make alloc_contig_range handle in-use hugetlb pages

2021-02-17 Thread Oscar Salvador
On Wed, Feb 17, 2021 at 04:33:18PM +0100, Michal Hocko wrote: > OK, I have missed that. Maybe just extend the comment. > > /* >* Hugepage was succesfully isolated and on the tmigratepages >* list >*/ Sure, I will improve it. Thanks -- Oscar Salvador SUSE L3

Re: [PATCH 2/2] mm: Make alloc_contig_range handle in-use hugetlb pages

2021-02-17 Thread Michal Hocko
On Wed 17-02-21 16:27:27, Oscar Salvador wrote: > On 2021-02-17 16:06, Michal Hocko wrote: > > I do not follow. You have successfully isolated huge pages so why don't > > you add that page to the migratepages list to be migrated? > > It is added. Note that I pass de list (cc->migratepages) to >

Re: [PATCH 2/2] mm: Make alloc_contig_range handle in-use hugetlb pages

2021-02-17 Thread Oscar Salvador
On 2021-02-17 16:06, Michal Hocko wrote: I do not follow. You have successfully isolated huge pages so why don't you add that page to the migratepages list to be migrated? It is added. Note that I pass de list (cc->migratepages) to isolate_or_dissolve_huge_page(). It is done this way because

Re: [PATCH 2/2] mm: Make alloc_contig_range handle in-use hugetlb pages

2021-02-17 Thread Michal Hocko
On Wed 17-02-21 11:08:16, Oscar Salvador wrote: > In-use hugetlb pages can be migrated as any other page (LRU > and Movable), so let alloc_contig_range handle them. > > All we need is to succesfully isolate such page. > > Signed-off-by: Oscar Salvador > --- > include/linux/hugetlb.h | 5 +++--

Re: [PATCH 2/2] mm: Make alloc_contig_range handle in-use hugetlb pages

2021-02-17 Thread Michal Hocko
On Wed 17-02-21 14:46:49, Oscar Salvador wrote: > On Wed, Feb 17, 2021 at 02:36:31PM +0100, Michal Hocko wrote: > > On Wed 17-02-21 11:08:16, Oscar Salvador wrote: > > > In-use hugetlb pages can be migrated as any other page (LRU > > > and Movable), so let alloc_contig_range handle them. > > > >

Re: [PATCH 2/2] mm: Make alloc_contig_range handle in-use hugetlb pages

2021-02-17 Thread Oscar Salvador
On Wed, Feb 17, 2021 at 02:36:31PM +0100, Michal Hocko wrote: > On Wed 17-02-21 11:08:16, Oscar Salvador wrote: > > In-use hugetlb pages can be migrated as any other page (LRU > > and Movable), so let alloc_contig_range handle them. > > > > All we need is to succesfully isolate such page. > >

Re: [PATCH 2/2] mm: Make alloc_contig_range handle in-use hugetlb pages

2021-02-17 Thread Michal Hocko
On Wed 17-02-21 11:08:16, Oscar Salvador wrote: > In-use hugetlb pages can be migrated as any other page (LRU > and Movable), so let alloc_contig_range handle them. > > All we need is to succesfully isolate such page. Again, this is missing a problem statement and a justification why we

[PATCH 2/2] mm: Make alloc_contig_range handle in-use hugetlb pages

2021-02-17 Thread Oscar Salvador
In-use hugetlb pages can be migrated as any other page (LRU and Movable), so let alloc_contig_range handle them. All we need is to succesfully isolate such page. Signed-off-by: Oscar Salvador --- include/linux/hugetlb.h | 5 +++-- mm/compaction.c | 11 ++- mm/hugetlb.c