Re: [PATCH 4/4] i2c: xlp9xx: Check for Bus state after every transfer

2018-02-27 Thread George Cherian
Hi Wolfram, On 02/27/2018 02:35 PM, Wolfram Sang wrote: Since you raised concern on the patch I thought of reworking this patch. But I can see that this patch is already applied for i2c/for-next. Kindly let me know whether I should be sending follow-up patches on top of i2c/for-next ? Oops,

Re: [PATCH 4/4] i2c: xlp9xx: Check for Bus state after every transfer

2018-02-27 Thread George Cherian
Hi Wolfram, On 02/27/2018 02:35 PM, Wolfram Sang wrote: Since you raised concern on the patch I thought of reworking this patch. But I can see that this patch is already applied for i2c/for-next. Kindly let me know whether I should be sending follow-up patches on top of i2c/for-next ? Oops,

Re: [PATCH 4/4] i2c: xlp9xx: Check for Bus state after every transfer

2018-02-27 Thread George Cherian
Hi Wolfram, On 02/27/2018 02:34 PM, Wolfram Sang wrote: On Tue, Feb 27, 2018 at 10:30:31AM +0530, George Cherian wrote: Hi Wolfram, Thanks for the review. On 02/27/2018 01:52 AM, Wolfram Sang wrote: On Thu, Jan 18, 2018 at 05:39:24AM +, George Cherian wrote: I2C bus enters the STOP

Re: [PATCH 4/4] i2c: xlp9xx: Check for Bus state after every transfer

2018-02-27 Thread George Cherian
Hi Wolfram, On 02/27/2018 02:34 PM, Wolfram Sang wrote: On Tue, Feb 27, 2018 at 10:30:31AM +0530, George Cherian wrote: Hi Wolfram, Thanks for the review. On 02/27/2018 01:52 AM, Wolfram Sang wrote: On Thu, Jan 18, 2018 at 05:39:24AM +, George Cherian wrote: I2C bus enters the STOP

Re: [PATCH 4/4] i2c: xlp9xx: Check for Bus state after every transfer

2018-02-27 Thread Wolfram Sang
> Since you raised concern on the patch I thought of reworking this patch. > But I can see that this patch is already applied for i2c/for-next. > Kindly let me know whether I should be sending follow-up patches on top > of i2c/for-next ? Oops, that was a mistake on my side. I'll revert that

Re: [PATCH 4/4] i2c: xlp9xx: Check for Bus state after every transfer

2018-02-27 Thread Wolfram Sang
> Since you raised concern on the patch I thought of reworking this patch. > But I can see that this patch is already applied for i2c/for-next. > Kindly let me know whether I should be sending follow-up patches on top > of i2c/for-next ? Oops, that was a mistake on my side. I'll revert that

Re: [PATCH 4/4] i2c: xlp9xx: Check for Bus state after every transfer

2018-02-27 Thread Wolfram Sang
On Tue, Feb 27, 2018 at 10:30:31AM +0530, George Cherian wrote: > Hi Wolfram, > > Thanks for the review. > > On 02/27/2018 01:52 AM, Wolfram Sang wrote: > > > > On Thu, Jan 18, 2018 at 05:39:24AM +, George Cherian wrote: > > > I2C bus enters the STOP condition after the DATA_DONE interrupt

Re: [PATCH 4/4] i2c: xlp9xx: Check for Bus state after every transfer

2018-02-27 Thread Wolfram Sang
On Tue, Feb 27, 2018 at 10:30:31AM +0530, George Cherian wrote: > Hi Wolfram, > > Thanks for the review. > > On 02/27/2018 01:52 AM, Wolfram Sang wrote: > > > > On Thu, Jan 18, 2018 at 05:39:24AM +, George Cherian wrote: > > > I2C bus enters the STOP condition after the DATA_DONE interrupt

Re: [PATCH 4/4] i2c: xlp9xx: Check for Bus state after every transfer

2018-02-26 Thread George Cherian
Hi Wolfram, On 02/27/2018 10:30 AM, George Cherian wrote: Hi Wolfram, Thanks for the review. On 02/27/2018 01:52 AM, Wolfram Sang wrote: On Thu, Jan 18, 2018 at 05:39:24AM +, George Cherian wrote: I2C bus enters the STOP condition after the DATA_DONE interrupt is raised. Essentially

Re: [PATCH 4/4] i2c: xlp9xx: Check for Bus state after every transfer

2018-02-26 Thread George Cherian
Hi Wolfram, On 02/27/2018 10:30 AM, George Cherian wrote: Hi Wolfram, Thanks for the review. On 02/27/2018 01:52 AM, Wolfram Sang wrote: On Thu, Jan 18, 2018 at 05:39:24AM +, George Cherian wrote: I2C bus enters the STOP condition after the DATA_DONE interrupt is raised. Essentially

Re: [PATCH 4/4] i2c: xlp9xx: Check for Bus state after every transfer

2018-02-26 Thread George Cherian
Hi Wolfram, Thanks for the review. On 02/27/2018 01:52 AM, Wolfram Sang wrote: On Thu, Jan 18, 2018 at 05:39:24AM +, George Cherian wrote: I2C bus enters the STOP condition after the DATA_DONE interrupt is raised. Essentially the driver should be checking the bus state before sending the

Re: [PATCH 4/4] i2c: xlp9xx: Check for Bus state after every transfer

2018-02-26 Thread George Cherian
Hi Wolfram, Thanks for the review. On 02/27/2018 01:52 AM, Wolfram Sang wrote: On Thu, Jan 18, 2018 at 05:39:24AM +, George Cherian wrote: I2C bus enters the STOP condition after the DATA_DONE interrupt is raised. Essentially the driver should be checking the bus state before sending the

Re: [PATCH 4/4] i2c: xlp9xx: Check for Bus state after every transfer

2018-02-26 Thread Wolfram Sang
On Thu, Jan 18, 2018 at 05:39:24AM +, George Cherian wrote: > I2C bus enters the STOP condition after the DATA_DONE interrupt is raised. > Essentially the driver should be checking the bus state before sending > the next transaction. Yes. > In case the next transaction is initiated while

Re: [PATCH 4/4] i2c: xlp9xx: Check for Bus state after every transfer

2018-02-26 Thread Wolfram Sang
On Thu, Jan 18, 2018 at 05:39:24AM +, George Cherian wrote: > I2C bus enters the STOP condition after the DATA_DONE interrupt is raised. > Essentially the driver should be checking the bus state before sending > the next transaction. Yes. > In case the next transaction is initiated while

[PATCH 4/4] i2c: xlp9xx: Check for Bus state after every transfer

2018-01-17 Thread George Cherian
I2C bus enters the STOP condition after the DATA_DONE interrupt is raised. Essentially the driver should be checking the bus state before sending the next transaction. In case the next transaction is initiated while the bus is busy, the prior transactions stop condition is not acheived. Add the

[PATCH 4/4] i2c: xlp9xx: Check for Bus state after every transfer

2018-01-17 Thread George Cherian
I2C bus enters the STOP condition after the DATA_DONE interrupt is raised. Essentially the driver should be checking the bus state before sending the next transaction. In case the next transaction is initiated while the bus is busy, the prior transactions stop condition is not acheived. Add the