Re: [PATCH v1] arch_topology: Make cpu_capacity sysfs node as ready-only

2019-03-08 Thread Dietmar Eggemann
On 3/6/19 4:27 PM, Lingutla Chandrasekhar wrote: [...] @@ -51,37 +50,7 @@ static ssize_t cpu_capacity_show(struct device *dev, static void update_topology_flags_workfn(struct work_struct *work); static DECLARE_WORK(update_topology_flags_work, update_topology_flags_workfn); -static

Re: [PATCH v1] arch_topology: Make cpu_capacity sysfs node as ready-only

2019-03-07 Thread Sudeep Holla
On Wed, Mar 06, 2019 at 08:57:53PM +0530, Lingutla Chandrasekhar wrote: > If user updates any cpu's cpu_capacity, then the new value is going to > be applied to all its online sibling cpus. But this need not to be correct > always, as sibling cpus (in ARM, same micro architecture cpus) would have

Re: [PATCH v1] arch_topology: Make cpu_capacity sysfs node as ready-only

2019-03-07 Thread Sudeep Holla
On Thu, Mar 07, 2019 at 12:14:03PM +, Quentin Perret wrote: > On Thursday 07 Mar 2019 at 10:57:50 (+0100), Juri Lelli wrote: > > If people think it's best to simply make this RO, I won't be against it. > > Just pointed out a conversation we recently had. Guess we could also > > make it RW

Re: [PATCH v1] arch_topology: Make cpu_capacity sysfs node as ready-only

2019-03-07 Thread Quentin Perret
On Thursday 07 Mar 2019 at 10:57:50 (+0100), Juri Lelli wrote: > If people think it's best to simply make this RO, I won't be against it. > Just pointed out a conversation we recently had. Guess we could also > make it RW again (properly) in the future if somebody complains. Right, now is

Re: [PATCH v1] arch_topology: Make cpu_capacity sysfs node as ready-only

2019-03-07 Thread Juri Lelli
Hi, On 07/03/19 09:31, Quentin Perret wrote: > Hi Juri, > > On Thursday 07 Mar 2019 at 08:28:56 (+0100), Juri Lelli wrote: > > There are cases in which this needs to be RW, as recently discussed > > https://lore.kernel.org/lkml/20181123135807.GA14964@e107155-lin/ > > Yeah there's that problem

Re: [PATCH v1] arch_topology: Make cpu_capacity sysfs node as ready-only

2019-03-07 Thread Quentin Perret
Hi Juri, On Thursday 07 Mar 2019 at 08:28:56 (+0100), Juri Lelli wrote: > There are cases in which this needs to be RW, as recently discussed > https://lore.kernel.org/lkml/20181123135807.GA14964@e107155-lin/ Yeah there's that problem when you can't fix your DT ... But I guess this is a problem

Re: [PATCH v1] arch_topology: Make cpu_capacity sysfs node as ready-only

2019-03-06 Thread Juri Lelli
Hi, On 06/03/19 20:57, Lingutla Chandrasekhar wrote: > If user updates any cpu's cpu_capacity, then the new value is going to > be applied to all its online sibling cpus. But this need not to be correct > always, as sibling cpus (in ARM, same micro architecture cpus) would have > different

[PATCH v1] arch_topology: Make cpu_capacity sysfs node as ready-only

2019-03-06 Thread Lingutla Chandrasekhar
If user updates any cpu's cpu_capacity, then the new value is going to be applied to all its online sibling cpus. But this need not to be correct always, as sibling cpus (in ARM, same micro architecture cpus) would have different cpu_capacity with different performance characteristics. So updating