Re: [PATCH v3 2/4] lib/hexdump.c: factor out generic hexdump formatting for reuse.

2019-03-28 Thread Life is hard, and then you die
On Thu, Mar 28, 2019 at 11:03:50AM +0200, Andy Shevchenko wrote: > On Wed, Mar 27, 2019 at 05:34:59PM -0700, Life is hard, and then you die > wrote: > > > > On Wed, Mar 27, 2019 at 09:46:48AM +0200, Andy Shevchenko wrote: > > > On Wed, Mar 27, 2019 at 3:49 AM Ronald Tschalär > > > wrote: > >

Re: [PATCH v3 2/4] lib/hexdump.c: factor out generic hexdump formatting for reuse.

2019-03-28 Thread Andy Shevchenko
On Wed, Mar 27, 2019 at 05:34:59PM -0700, Life is hard, and then you die wrote: > > On Wed, Mar 27, 2019 at 09:46:48AM +0200, Andy Shevchenko wrote: > > On Wed, Mar 27, 2019 at 3:49 AM Ronald Tschalär > > wrote: > > > > > > This introduces print_hex_dump_to_cb() which contains all the hexdump >

Re: [PATCH v3 2/4] lib/hexdump.c: factor out generic hexdump formatting for reuse.

2019-03-27 Thread Life is hard, and then you die
On Wed, Mar 27, 2019 at 09:46:48AM +0200, Andy Shevchenko wrote: > On Wed, Mar 27, 2019 at 3:49 AM Ronald Tschalär wrote: > > > > This introduces print_hex_dump_to_cb() which contains all the hexdump > > formatting minus the actual printk() call, allowing an arbitrary print > > function to be

Re: [PATCH v3 2/4] lib/hexdump.c: factor out generic hexdump formatting for reuse.

2019-03-27 Thread Andy Shevchenko
On Wed, Mar 27, 2019 at 3:49 AM Ronald Tschalär wrote: > > This introduces print_hex_dump_to_cb() which contains all the hexdump > formatting minus the actual printk() call, allowing an arbitrary print > function to be supplied instead. And print_hex_dump() is re-implemented > using

[PATCH v3 2/4] lib/hexdump.c: factor out generic hexdump formatting for reuse.

2019-03-26 Thread Ronald Tschalär
This introduces print_hex_dump_to_cb() which contains all the hexdump formatting minus the actual printk() call, allowing an arbitrary print function to be supplied instead. And print_hex_dump() is re-implemented using print_hex_dump_to_cb(). This allows other hex-dump logging functions to be