Re: [PATCH v5 11/44] clk: davinci: Add platform information for TI DA830 PSC

2018-01-17 Thread Sekhar Nori
On Wednesday 17 January 2018 11:02 PM, David Lechner wrote: > +    clk_register_clkdev(clk_data->clks[3], "gpio", NULL); This is pretty bad (and no fault of yours) - having a con_id but no device name. Can you please make a pre-series which passes NULL con_id in

Re: [PATCH v5 11/44] clk: davinci: Add platform information for TI DA830 PSC

2018-01-17 Thread Sekhar Nori
On Wednesday 17 January 2018 11:02 PM, David Lechner wrote: > +    clk_register_clkdev(clk_data->clks[3], "gpio", NULL); This is pretty bad (and no fault of yours) - having a con_id but no device name. Can you please make a pre-series which passes NULL con_id in

Re: [PATCH v5 11/44] clk: davinci: Add platform information for TI DA830 PSC

2018-01-17 Thread David Lechner
On 01/17/2018 06:18 AM, Sekhar Nori wrote: On Tuesday 16 January 2018 10:46 PM, David Lechner wrote: +static const struct davinci_psc_clk_info da830_psc0_info[] __initconst = { +    LPSC(0, 0, tpcc, pll0_sysclk2, LPSC_ALWAYS_ENABLED), +    LPSC(1, 0, tptc0, pll0_sysclk2, LPSC_ALWAYS_ENABLED),

Re: [PATCH v5 11/44] clk: davinci: Add platform information for TI DA830 PSC

2018-01-17 Thread David Lechner
On 01/17/2018 06:18 AM, Sekhar Nori wrote: On Tuesday 16 January 2018 10:46 PM, David Lechner wrote: +static const struct davinci_psc_clk_info da830_psc0_info[] __initconst = { +    LPSC(0, 0, tpcc, pll0_sysclk2, LPSC_ALWAYS_ENABLED), +    LPSC(1, 0, tptc0, pll0_sysclk2, LPSC_ALWAYS_ENABLED),

Re: [PATCH v5 11/44] clk: davinci: Add platform information for TI DA830 PSC

2018-01-17 Thread Sekhar Nori
On Tuesday 16 January 2018 10:46 PM, David Lechner wrote: >>> +static const struct davinci_psc_clk_info da830_psc0_info[] >>> __initconst = { >>> +    LPSC(0, 0, tpcc, pll0_sysclk2, LPSC_ALWAYS_ENABLED), >>> +    LPSC(1, 0, tptc0, pll0_sysclk2, LPSC_ALWAYS_ENABLED), >>> +    LPSC(2, 0, tptc1,

Re: [PATCH v5 11/44] clk: davinci: Add platform information for TI DA830 PSC

2018-01-17 Thread Sekhar Nori
On Tuesday 16 January 2018 10:46 PM, David Lechner wrote: >>> +static const struct davinci_psc_clk_info da830_psc0_info[] >>> __initconst = { >>> +    LPSC(0, 0, tpcc, pll0_sysclk2, LPSC_ALWAYS_ENABLED), >>> +    LPSC(1, 0, tptc0, pll0_sysclk2, LPSC_ALWAYS_ENABLED), >>> +    LPSC(2, 0, tptc1,

Re: [PATCH v5 11/44] clk: davinci: Add platform information for TI DA830 PSC

2018-01-16 Thread David Lechner
On 01/16/2018 07:38 AM, Sekhar Nori wrote: On Monday 08 January 2018 07:47 AM, David Lechner wrote: This adds platform-specific declarations for the PSC clocks on TI DA830/ OMAP-L137/AM17XX SoCs. Signed-off-by: David Lechner --- drivers/clk/davinci/Makefile| 1 +

Re: [PATCH v5 11/44] clk: davinci: Add platform information for TI DA830 PSC

2018-01-16 Thread David Lechner
On 01/16/2018 07:38 AM, Sekhar Nori wrote: On Monday 08 January 2018 07:47 AM, David Lechner wrote: This adds platform-specific declarations for the PSC clocks on TI DA830/ OMAP-L137/AM17XX SoCs. Signed-off-by: David Lechner --- drivers/clk/davinci/Makefile| 1 +

Re: [PATCH v5 11/44] clk: davinci: Add platform information for TI DA830 PSC

2018-01-16 Thread Sekhar Nori
On Monday 08 January 2018 07:47 AM, David Lechner wrote: > This adds platform-specific declarations for the PSC clocks on TI DA830/ > OMAP-L137/AM17XX SoCs. > > Signed-off-by: David Lechner > --- > drivers/clk/davinci/Makefile| 1 + > drivers/clk/davinci/psc-da830.c |

Re: [PATCH v5 11/44] clk: davinci: Add platform information for TI DA830 PSC

2018-01-16 Thread Sekhar Nori
On Monday 08 January 2018 07:47 AM, David Lechner wrote: > This adds platform-specific declarations for the PSC clocks on TI DA830/ > OMAP-L137/AM17XX SoCs. > > Signed-off-by: David Lechner > --- > drivers/clk/davinci/Makefile| 1 + > drivers/clk/davinci/psc-da830.c | 96 >

[PATCH v5 11/44] clk: davinci: Add platform information for TI DA830 PSC

2018-01-07 Thread David Lechner
This adds platform-specific declarations for the PSC clocks on TI DA830/ OMAP-L137/AM17XX SoCs. Signed-off-by: David Lechner --- drivers/clk/davinci/Makefile| 1 + drivers/clk/davinci/psc-da830.c | 96 +

[PATCH v5 11/44] clk: davinci: Add platform information for TI DA830 PSC

2018-01-07 Thread David Lechner
This adds platform-specific declarations for the PSC clocks on TI DA830/ OMAP-L137/AM17XX SoCs. Signed-off-by: David Lechner --- drivers/clk/davinci/Makefile| 1 + drivers/clk/davinci/psc-da830.c | 96 + include/linux/clk/davinci.h | 2 + 3