Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

On Tue, Jan 30, 2018 at 01:21:01PM +, shufan_lee(李書帆) wrote: > Hi Guenter, > > For now, it looks like there are two ways to implement vendor data. It > would be nice to hear your suggestion. > > 1. Set vendor data in the data field of of_device_id. > If I understand correctly, this

Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

On Tue, Jan 30, 2018 at 01:21:01PM +, shufan_lee(李書帆) wrote: > Hi Guenter, > > For now, it looks like there are two ways to implement vendor data. It > would be nice to hear your suggestion. > > 1. Set vendor data in the data field of of_device_id. > If I understand correctly, this

RE: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

'Jun Li'; ShuFanLee; cy_huang(黃啟原); linux-kernel@vger.kernel.org; linux-...@vger.kernel.org Subject: Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver On Mon, Jan 29, 2018 at 07:19:06AM +, shufan_lee(李書帆) wrote: > Hi Guenter, > > We try to use the TCPCI driver on RT1711H and here

RE: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

'Jun Li'; ShuFanLee; cy_huang(黃啟原); linux-kernel@vger.kernel.org; linux-...@vger.kernel.org Subject: Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver On Mon, Jan 29, 2018 at 07:19:06AM +, shufan_lee(李書帆) wrote: > Hi Guenter, > > We try to use the TCPCI driver on RT1711H and here

Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

On Mon, Jan 29, 2018 at 07:19:06AM +, shufan_lee(李書帆) wrote: > Hi Guenter, > > We try to use the TCPCI driver on RT1711H and here are some questions. > > Q1. Is current TCPCI driver written according to TypeC Port Controller > Interface Specification Revision 1.0 & Version 1.2?

Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

On Mon, Jan 29, 2018 at 07:19:06AM +, shufan_lee(李書帆) wrote: > Hi Guenter, > > We try to use the TCPCI driver on RT1711H and here are some questions. > > Q1. Is current TCPCI driver written according to TypeC Port Controller > Interface Specification Revision 1.0 & Version 1.2?

RE: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

On Behalf Of Guenter Roeck Sent: Tuesday, January 23, 2018 2:51 AM To: shufan_lee(李書帆) Cc: Heikki Krogerus; 'Jun Li'; ShuFanLee; cy_huang(黃啟原); linux-kernel@vger.kernel.org; linux-...@vger.kernel.org Subject: Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver On Mon, Jan 22, 2018 at 02:01:13AM +0

RE: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

On Behalf Of Guenter Roeck Sent: Tuesday, January 23, 2018 2:51 AM To: shufan_lee(李書帆) Cc: Heikki Krogerus; 'Jun Li'; ShuFanLee; cy_huang(黃啟原); linux-kernel@vger.kernel.org; linux-...@vger.kernel.org Subject: Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver On Mon, Jan 22, 2018 at 02:01:13AM +0

Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

* > > -Original Message- > From: Guenter Roeck [mailto:groe...@gmail.com] On Behalf Of Guenter Roeck > Sent: Saturday, January 20, 2018 12:03 AM > To: Heikki Krogerus > Cc: shufan_lee(李書帆); 'Jun Li'; ShuFanLee; cy_huang(黃啟原); > linux-kernel@vger.kernel.org

Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

* > > -Original Message- > From: Guenter Roeck [mailto:groe...@gmail.com] On Behalf Of Guenter Roeck > Sent: Saturday, January 20, 2018 12:03 AM > To: Heikki Krogerus > Cc: shufan_lee(李書帆); 'Jun Li'; ShuFanLee; cy_huang(黃啟原); > linux-kernel@vger.kernel.org

RE: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

; cy_huang(黃啟原); linux-kernel@vger.kernel.org; linux-...@vger.kernel.org Subject: Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver On Fri, Jan 19, 2018 at 11:24:13AM +0200, Heikki Krogerus wrote: > Hi, > > On Fri, Jan 19, 2018 at 09:01:24AM +, shufan_lee(?|) wrote: >

RE: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

; cy_huang(黃啟原); linux-kernel@vger.kernel.org; linux-...@vger.kernel.org Subject: Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver On Fri, Jan 19, 2018 at 11:24:13AM +0200, Heikki Krogerus wrote: > Hi, > > On Fri, Jan 19, 2018 at 09:01:24AM +, shufan_lee(?|) wrote: >

Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

On Fri, Jan 19, 2018 at 11:24:13AM +0200, Heikki Krogerus wrote: > Hi, > > On Fri, Jan 19, 2018 at 09:01:24AM +, shufan_lee(?|) wrote: > > Hi Heikki, > > > > For example, the flow of tcpci_init is a little bit different. > > In tcpci_init, there are more parameters need to be set for

Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

On Fri, Jan 19, 2018 at 11:24:13AM +0200, Heikki Krogerus wrote: > Hi, > > On Fri, Jan 19, 2018 at 09:01:24AM +, shufan_lee(?|) wrote: > > Hi Heikki, > > > > For example, the flow of tcpci_init is a little bit different. > > In tcpci_init, there are more parameters need to be set for

Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

Hi, On Fri, Jan 19, 2018 at 09:01:24AM +, shufan_lee(?|) wrote: > Hi Heikki, > > For example, the flow of tcpci_init is a little bit different. > In tcpci_init, there are more parameters need to be set for RT1711H. Different init parameters is really not a reason for a fork of the

Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

Hi, On Fri, Jan 19, 2018 at 09:01:24AM +, shufan_lee(?|) wrote: > Hi Heikki, > > For example, the flow of tcpci_init is a little bit different. > In tcpci_init, there are more parameters need to be set for RT1711H. Different init parameters is really not a reason for a fork of the

RE: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

TYPEC: RT1711H Type-C Chip Driver Hi Shu-Fan, On Fri, Jan 19, 2018 at 05:48:02AM +, shufan_lee(?) wrote: > Hi Jun, > > For now, RT1711H is not fully compatible with TCPCI. So the existing tcpci.c > may not work for it. The datasheet for RT1711H does talk about TCPCi a

RE: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

TYPEC: RT1711H Type-C Chip Driver Hi Shu-Fan, On Fri, Jan 19, 2018 at 05:48:02AM +, shufan_lee(?) wrote: > Hi Jun, > > For now, RT1711H is not fully compatible with TCPCI. So the existing tcpci.c > may not work for it. The datasheet for RT1711H does talk about TCPCi a

Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

Hi Shu-Fan, On Fri, Jan 19, 2018 at 05:48:02AM +, shufan_lee(?) wrote: > Hi Jun, > > For now, RT1711H is not fully compatible with TCPCI. So the existing tcpci.c > may not work for it. The datasheet for RT1711H does talk about TCPCi and TCPM+TCPC [1]. What are the differences

Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

Hi Shu-Fan, On Fri, Jan 19, 2018 at 05:48:02AM +, shufan_lee(?) wrote: > Hi Jun, > > For now, RT1711H is not fully compatible with TCPCI. So the existing tcpci.c > may not work for it. The datasheet for RT1711H does talk about TCPCi and TCPM+TCPC [1]. What are the differences

Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

On Thu, Jan 18, 2018 at 01:13:15PM +, shufan_lee(李書帆) wrote: > > + > > +#include "rt1711h.h" > > Why a .h file for a single .c file? > > Is the suggestion to move all content in rt1711h.h into rt1711h.c? If it can be, sure, you only need a .h file for things that are shared among other .c

Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

On Thu, Jan 18, 2018 at 01:13:15PM +, shufan_lee(李書帆) wrote: > > + > > +#include "rt1711h.h" > > Why a .h file for a single .c file? > > Is the suggestion to move all content in rt1711h.h into rt1711h.c? If it can be, sure, you only need a .h file for things that are shared among other .c

RE: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

- From: Jun Li [mailto:jun...@nxp.com] Sent: Friday, January 19, 2018 11:10 AM To: ShuFanLee; heikki.kroge...@linux.intel.com Cc: cy_huang(黃啟原); shufan_lee(李書帆); linux-kernel@vger.kernel.org; linux-...@vger.kernel.org; Guenter Roeck Subject: RE: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver Hi

RE: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

- From: Jun Li [mailto:jun...@nxp.com] Sent: Friday, January 19, 2018 11:10 AM To: ShuFanLee; heikki.kroge...@linux.intel.com Cc: cy_huang(黃啟原); shufan_lee(李書帆); linux-kernel@vger.kernel.org; linux-...@vger.kernel.org; Guenter Roeck Subject: RE: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver Hi

RE: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

Hi > -Original Message- > From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb- > ow...@vger.kernel.org] On Behalf Of ShuFanLee > Sent: Wednesday, January 10, 2018 2:59 PM > To: heikki.kroge...@linux.intel.com > Cc: cy_hu...@richtek.com; shufan_...@richtek.com; linux- >

RE: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

Hi > -Original Message- > From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb- > ow...@vger.kernel.org] On Behalf Of ShuFanLee > Sent: Wednesday, January 10, 2018 2:59 PM > To: heikki.kroge...@linux.intel.com > Cc: cy_hu...@richtek.com; shufan_...@richtek.com; linux- >

RE: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

-%s", dev_name(chip->dev)); > +if (!chip->dbgdir) { > +chip->dbgdir = debugfs_create_dir(dirname, NULL); > +if (!chip->dbgdir) > +return -ENOMEM; No need to ever check the return value of debugfs_ calls, you should not care and can always use the value to any future debugfs calls, if you reall

RE: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

-%s", dev_name(chip->dev)); > +if (!chip->dbgdir) { > +chip->dbgdir = debugfs_create_dir(dirname, NULL); > +if (!chip->dbgdir) > +return -ENOMEM; No need to ever check the return value of debugfs_ calls, you should not care and can always use the value to any future debugfs calls, if you reall

Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

On Wed, Jan 10, 2018 at 02:59:12PM +0800, ShuFanLee wrote: > From: ShuFanLee > > Richtek RT1711H Type-C chip driver that works with > Type-C Port Controller Manager to provide USB PD and > USB Type-C functionalities. > > Signed-off-by: ShuFanLee

Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

On Wed, Jan 10, 2018 at 02:59:12PM +0800, ShuFanLee wrote: > From: ShuFanLee > > Richtek RT1711H Type-C chip driver that works with > Type-C Port Controller Manager to provide USB PD and > USB Type-C functionalities. > > Signed-off-by: ShuFanLee Minor review of your main structure and your

Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

On Wed, Jan 10, 2018 at 02:59:12PM +0800, ShuFanLee wrote: > +static inline int rt1711h_reg_write_word(struct rt1711h_chip *chip, uint8_t > reg, > + uint16_t data) > +{ > + data = cpu_to_le16(data); > + return rt1711h_reg_block_write(chip, reg, 2, (uint8_t *)); > +} Did you run

Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

On Wed, Jan 10, 2018 at 02:59:12PM +0800, ShuFanLee wrote: > +static inline int rt1711h_reg_write_word(struct rt1711h_chip *chip, uint8_t > reg, > + uint16_t data) > +{ > + data = cpu_to_le16(data); > + return rt1711h_reg_block_write(chip, reg, 2, (uint8_t *)); > +} Did you run

Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

On Wed, Jan 10, 2018 at 02:59:12PM +0800, ShuFanLee wrote: > +static inline void rt1711h_poll_ctrl(struct rt1711h_chip *chip) > +{ > + cancel_delayed_work_sync(>poll_work); > + > + if (atomic_read(>poll_count) == 0) { > + atomic_inc(>poll_count); > +

Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

On Wed, Jan 10, 2018 at 02:59:12PM +0800, ShuFanLee wrote: > +static inline void rt1711h_poll_ctrl(struct rt1711h_chip *chip) > +{ > + cancel_delayed_work_sync(>poll_work); > + > + if (atomic_read(>poll_count) == 0) { > + atomic_inc(>poll_count); > +

Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

On Wed, Jan 17, 2018 at 02:00:28PM +0200, Heikki Krogerus wrote: > Hi Greg, > > On Wed, Jan 17, 2018 at 12:14:02PM +0100, Greg KH wrote: > > On Wed, Jan 17, 2018 at 01:08:58PM +0200, Heikki Krogerus wrote: > > > Hi, > > > > > > On Wed, Jan 17, 2018 at 09:30:45AM +, shufan_lee(?)

Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

On Wed, Jan 17, 2018 at 02:00:28PM +0200, Heikki Krogerus wrote: > Hi Greg, > > On Wed, Jan 17, 2018 at 12:14:02PM +0100, Greg KH wrote: > > On Wed, Jan 17, 2018 at 01:08:58PM +0200, Heikki Krogerus wrote: > > > Hi, > > > > > > On Wed, Jan 17, 2018 at 09:30:45AM +, shufan_lee(?)

Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

Hi Greg, On Wed, Jan 17, 2018 at 12:14:02PM +0100, Greg KH wrote: > On Wed, Jan 17, 2018 at 01:08:58PM +0200, Heikki Krogerus wrote: > > Hi, > > > > On Wed, Jan 17, 2018 at 09:30:45AM +, shufan_lee(?) wrote: > > > Dear Heikki, > > > > > > Sorry for bothering. > > > > > > Just

Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

Hi Greg, On Wed, Jan 17, 2018 at 12:14:02PM +0100, Greg KH wrote: > On Wed, Jan 17, 2018 at 01:08:58PM +0200, Heikki Krogerus wrote: > > Hi, > > > > On Wed, Jan 17, 2018 at 09:30:45AM +, shufan_lee(?) wrote: > > > Dear Heikki, > > > > > > Sorry for bothering. > > > > > > Just

Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

On Wed, Jan 17, 2018 at 01:08:58PM +0200, Heikki Krogerus wrote: > Hi, > > On Wed, Jan 17, 2018 at 09:30:45AM +, shufan_lee(?) wrote: > > Dear Heikki, > > > > Sorry for bothering. > > > > Just want to check is there anything we need to modify? > > I'll check the patch this

Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

On Wed, Jan 17, 2018 at 01:08:58PM +0200, Heikki Krogerus wrote: > Hi, > > On Wed, Jan 17, 2018 at 09:30:45AM +, shufan_lee(?) wrote: > > Dear Heikki, > > > > Sorry for bothering. > > > > Just want to check is there anything we need to modify? > > I'll check the patch this

Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

Hi, On Wed, Jan 17, 2018 at 09:30:45AM +, shufan_lee(?) wrote: > Dear Heikki, > > Sorry for bothering. > > Just want to check is there anything we need to modify? I'll check the patch this week, but please note that we are -rc8, so nothing is going to happen before -rc1 is out.

Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

Hi, On Wed, Jan 17, 2018 at 09:30:45AM +, shufan_lee(?) wrote: > Dear Heikki, > > Sorry for bothering. > > Just want to check is there anything we need to modify? I'll check the patch this week, but please note that we are -rc8, so nothing is going to happen before -rc1 is out.

RE: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

Dear Heikki, Sorry for bothering. Just want to check is there anything we need to modify? Thank you! Best Regards, * Shu-Fan Lee Richtek Technology Corporation TEL: +886-3-5526789 #2359 FAX: +886-3-5526612 * -Original

RE: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

Dear Heikki, Sorry for bothering. Just want to check is there anything we need to modify? Thank you! Best Regards, * Shu-Fan Lee Richtek Technology Corporation TEL: +886-3-5526789 #2359 FAX: +886-3-5526612 * -Original

RE: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

* -Original Message- From: Randy Dunlap [mailto:rdun...@infradead.org] Sent: Wednesday, January 10, 2018 1:26 AM To: shufan_lee(李書帆); heikki.kroge...@linux.intel.com Cc: linux-kernel@vger.kernel.org; cy_huang(黃啟原) Subject: Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver On 01/09/18 00:45

RE: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

* -Original Message- From: Randy Dunlap [mailto:rdun...@infradead.org] Sent: Wednesday, January 10, 2018 1:26 AM To: shufan_lee(李書帆); heikki.kroge...@linux.intel.com Cc: linux-kernel@vger.kernel.org; cy_huang(黃啟原) Subject: Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver On 01/09/18 00:45

Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

* > > -Original Message- > From: Randy Dunlap [mailto:rdun...@infradead.org] > Sent: Tuesday, January 09, 2018 2:19 PM > To: shufan_lee(李書帆); heikki.kroge...@linux.intel.com > Cc: linux-kernel@vger.kernel.org; cy_huang(黃啟原) > Subject: Re: [PATCH] USB TYP

Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

* > > -Original Message- > From: Randy Dunlap [mailto:rdun...@infradead.org] > Sent: Tuesday, January 09, 2018 2:19 PM > To: shufan_lee(李書帆); heikki.kroge...@linux.intel.com > Cc: linux-kernel@vger.kernel.org; cy_huang(黃啟原) > Subject: Re: [PATCH] USB TYP

RE: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

-5526612 * -Original Message- From: Randy Dunlap [mailto:rdun...@infradead.org] Sent: Tuesday, January 09, 2018 2:19 PM To: shufan_lee(李書帆); heikki.kroge...@linux.intel.com Cc: linux-kernel@vger.kernel.org; cy_huang(黃啟原) Subject: Re: [PATCH] USB TYPEC: RT1711H Type-C

RE: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

-5526612 * -Original Message- From: Randy Dunlap [mailto:rdun...@infradead.org] Sent: Tuesday, January 09, 2018 2:19 PM To: shufan_lee(李書帆); heikki.kroge...@linux.intel.com Cc: linux-kernel@vger.kernel.org; cy_huang(黃啟原) Subject: Re: [PATCH] USB TYPEC: RT1711H Type-C

Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

On 01/08/18 19:13, shufan_lee(李書帆) wrote: > From: ShuFan Lee > > Richtek RT1711H Type-C chip driver that works with > Type-C Port Controller Manager to provide USB PD and > USB Type-C functionalities. > > Signed-off-by: ShuFan Lee > ---​ > >

Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

On 01/08/18 19:13, shufan_lee(李書帆) wrote: > From: ShuFan Lee > > Richtek RT1711H Type-C chip driver that works with > Type-C Port Controller Manager to provide USB PD and > USB Type-C functionalities. > > Signed-off-by: ShuFan Lee > ---​ > >