Re: [PATCH v10 10/16] KVM: x86: Introduce KVM_GET_SHARED_PAGES_LIST ioctl

2021-04-02 Thread Ashish Kalra
Hello Steve, On Thu, Apr 01, 2021 at 06:40:06PM -0700, Steve Rutherford wrote: > On Fri, Mar 19, 2021 at 11:00 AM Ashish Kalra wrote: > > > > On Thu, Mar 11, 2021 at 12:48:07PM -0800, Steve Rutherford wrote: > > > On Thu, Mar 11, 2021 at 10:15 AM Ashish Kalra > > > wrote: > > > > > > > > On

Re: [PATCH v10 10/16] KVM: x86: Introduce KVM_GET_SHARED_PAGES_LIST ioctl

2021-04-01 Thread Steve Rutherford
On Fri, Mar 19, 2021 at 11:00 AM Ashish Kalra wrote: > > On Thu, Mar 11, 2021 at 12:48:07PM -0800, Steve Rutherford wrote: > > On Thu, Mar 11, 2021 at 10:15 AM Ashish Kalra wrote: > > > > > > On Wed, Mar 03, 2021 at 06:54:41PM +, Will Deacon wrote: > > > > [+Marc] > > > > > > > > On Tue, Mar

Re: [PATCH v10 10/16] KVM: x86: Introduce KVM_GET_SHARED_PAGES_LIST ioctl

2021-03-19 Thread Ashish Kalra
On Thu, Mar 11, 2021 at 12:48:07PM -0800, Steve Rutherford wrote: > On Thu, Mar 11, 2021 at 10:15 AM Ashish Kalra wrote: > > > > On Wed, Mar 03, 2021 at 06:54:41PM +, Will Deacon wrote: > > > [+Marc] > > > > > > On Tue, Mar 02, 2021 at 02:55:43PM +, Ashish Kalra wrote: > > > > On Fri, Feb

Re: [PATCH v10 10/16] KVM: x86: Introduce KVM_GET_SHARED_PAGES_LIST ioctl

2021-03-11 Thread Steve Rutherford
On Thu, Mar 11, 2021 at 10:15 AM Ashish Kalra wrote: > > On Wed, Mar 03, 2021 at 06:54:41PM +, Will Deacon wrote: > > [+Marc] > > > > On Tue, Mar 02, 2021 at 02:55:43PM +, Ashish Kalra wrote: > > > On Fri, Feb 26, 2021 at 09:44:41AM -0800, Sean Christopherson wrote: > > > > On Fri, Feb

Re: [PATCH v10 10/16] KVM: x86: Introduce KVM_GET_SHARED_PAGES_LIST ioctl

2021-03-11 Thread Ashish Kalra
On Wed, Mar 03, 2021 at 06:54:41PM +, Will Deacon wrote: > [+Marc] > > On Tue, Mar 02, 2021 at 02:55:43PM +, Ashish Kalra wrote: > > On Fri, Feb 26, 2021 at 09:44:41AM -0800, Sean Christopherson wrote: > > > On Fri, Feb 26, 2021, Ashish Kalra wrote: > > > > On Thu, Feb 25, 2021 at

Re: [PATCH v10 10/16] KVM: x86: Introduce KVM_GET_SHARED_PAGES_LIST ioctl

2021-03-09 Thread Steve Rutherford
On Tue, Mar 9, 2021 at 7:42 PM Kalra, Ashish wrote: > > > > > On Mar 9, 2021, at 3:22 AM, Steve Rutherford wrote: > > > > On Mon, Mar 8, 2021 at 1:11 PM Brijesh Singh wrote: > >> > >> > >>> On 3/8/21 1:51 PM, Sean Christopherson wrote: > >>> On Mon, Mar 08, 2021, Ashish Kalra wrote: > On

Re: [PATCH v10 10/16] KVM: x86: Introduce KVM_GET_SHARED_PAGES_LIST ioctl

2021-03-09 Thread Kalra, Ashish
> On Mar 9, 2021, at 3:22 AM, Steve Rutherford wrote: > > On Mon, Mar 8, 2021 at 1:11 PM Brijesh Singh wrote: >> >> >>> On 3/8/21 1:51 PM, Sean Christopherson wrote: >>> On Mon, Mar 08, 2021, Ashish Kalra wrote: On Fri, Feb 26, 2021 at 09:44:41AM -0800, Sean Christopherson wrote:

Re: [PATCH v10 10/16] KVM: x86: Introduce KVM_GET_SHARED_PAGES_LIST ioctl

2021-03-09 Thread Sean Christopherson
On Mon, Mar 08, 2021, Steve Rutherford wrote: > On Mon, Mar 8, 2021 at 1:11 PM Brijesh Singh wrote: > > On 3/8/21 1:51 PM, Sean Christopherson wrote: > > > If the guest does the hypercall after writing the page, then the guest is > > > hosed > > > if it gets migrated while writing the page

Re: [PATCH v10 10/16] KVM: x86: Introduce KVM_GET_SHARED_PAGES_LIST ioctl

2021-03-09 Thread Ashish Kalra
On Wed, Mar 03, 2021 at 06:54:41PM +, Will Deacon wrote: > [+Marc] > > On Tue, Mar 02, 2021 at 02:55:43PM +, Ashish Kalra wrote: > > On Fri, Feb 26, 2021 at 09:44:41AM -0800, Sean Christopherson wrote: > > > On Fri, Feb 26, 2021, Ashish Kalra wrote: > > > > On Thu, Feb 25, 2021 at

Re: [PATCH v10 10/16] KVM: x86: Introduce KVM_GET_SHARED_PAGES_LIST ioctl

2021-03-08 Thread Steve Rutherford
On Mon, Mar 8, 2021 at 1:11 PM Brijesh Singh wrote: > > > On 3/8/21 1:51 PM, Sean Christopherson wrote: > > On Mon, Mar 08, 2021, Ashish Kalra wrote: > >> On Fri, Feb 26, 2021 at 09:44:41AM -0800, Sean Christopherson wrote: > >>> +Will and Quentin (arm64) > >>> > >>> Moving the non-KVM x86 folks

Re: [PATCH v10 10/16] KVM: x86: Introduce KVM_GET_SHARED_PAGES_LIST ioctl

2021-03-08 Thread Steve Rutherford
On Mon, Mar 8, 2021 at 11:52 AM Sean Christopherson wrote: > > On Mon, Mar 08, 2021, Ashish Kalra wrote: > > On Fri, Feb 26, 2021 at 09:44:41AM -0800, Sean Christopherson wrote: > > > +Will and Quentin (arm64) > > > > > > Moving the non-KVM x86 folks to bcc, I don't they care about KVM details >

Re: [PATCH v10 10/16] KVM: x86: Introduce KVM_GET_SHARED_PAGES_LIST ioctl

2021-03-08 Thread Ashish Kalra
On Mon, Mar 08, 2021 at 03:11:41PM -0600, Brijesh Singh wrote: > > On 3/8/21 1:51 PM, Sean Christopherson wrote: > > On Mon, Mar 08, 2021, Ashish Kalra wrote: > >> On Fri, Feb 26, 2021 at 09:44:41AM -0800, Sean Christopherson wrote: > >>> +Will and Quentin (arm64) > >>> > >>> Moving the non-KVM

Re: [PATCH v10 10/16] KVM: x86: Introduce KVM_GET_SHARED_PAGES_LIST ioctl

2021-03-08 Thread Brijesh Singh
On 3/8/21 1:51 PM, Sean Christopherson wrote: > On Mon, Mar 08, 2021, Ashish Kalra wrote: >> On Fri, Feb 26, 2021 at 09:44:41AM -0800, Sean Christopherson wrote: >>> +Will and Quentin (arm64) >>> >>> Moving the non-KVM x86 folks to bcc, I don't they care about KVM details at >>> this >>> point.

Re: [PATCH v10 10/16] KVM: x86: Introduce KVM_GET_SHARED_PAGES_LIST ioctl

2021-03-08 Thread Ashish Kalra
On Mon, Mar 08, 2021 at 11:51:57AM -0800, Sean Christopherson wrote: > On Mon, Mar 08, 2021, Ashish Kalra wrote: > > On Fri, Feb 26, 2021 at 09:44:41AM -0800, Sean Christopherson wrote: > > > +Will and Quentin (arm64) > > > > > > Moving the non-KVM x86 folks to bcc, I don't they care about KVM

Re: [PATCH v10 10/16] KVM: x86: Introduce KVM_GET_SHARED_PAGES_LIST ioctl

2021-03-08 Thread Sean Christopherson
On Mon, Mar 08, 2021, Ashish Kalra wrote: > On Fri, Feb 26, 2021 at 09:44:41AM -0800, Sean Christopherson wrote: > > +Will and Quentin (arm64) > > > > Moving the non-KVM x86 folks to bcc, I don't they care about KVM details at > > this > > point. > > > > On Fri, Feb 26, 2021, Ashish Kalra

Re: [PATCH v10 10/16] KVM: x86: Introduce KVM_GET_SHARED_PAGES_LIST ioctl

2021-03-08 Thread Ashish Kalra
On Fri, Feb 26, 2021 at 09:44:41AM -0800, Sean Christopherson wrote: > +Will and Quentin (arm64) > > Moving the non-KVM x86 folks to bcc, I don't they care about KVM details at > this > point. > > On Fri, Feb 26, 2021, Ashish Kalra wrote: > > On Thu, Feb 25, 2021 at 02:59:27PM -0800, Steve

Re: [PATCH v10 10/16] KVM: x86: Introduce KVM_GET_SHARED_PAGES_LIST ioctl

2021-03-03 Thread Ashish Kalra
On Wed, Mar 03, 2021 at 06:54:41PM +, Will Deacon wrote: > [+Marc] > > On Tue, Mar 02, 2021 at 02:55:43PM +, Ashish Kalra wrote: > > On Fri, Feb 26, 2021 at 09:44:41AM -0800, Sean Christopherson wrote: > > > On Fri, Feb 26, 2021, Ashish Kalra wrote: > > > > On Thu, Feb 25, 2021 at

Re: [PATCH v10 10/16] KVM: x86: Introduce KVM_GET_SHARED_PAGES_LIST ioctl

2021-03-03 Thread Will Deacon
[+Marc] On Tue, Mar 02, 2021 at 02:55:43PM +, Ashish Kalra wrote: > On Fri, Feb 26, 2021 at 09:44:41AM -0800, Sean Christopherson wrote: > > On Fri, Feb 26, 2021, Ashish Kalra wrote: > > > On Thu, Feb 25, 2021 at 02:59:27PM -0800, Steve Rutherford wrote: > > > > On Thu, Feb 25, 2021 at 12:20

Re: [PATCH v10 10/16] KVM: x86: Introduce KVM_GET_SHARED_PAGES_LIST ioctl

2021-03-02 Thread Ashish Kalra
On Fri, Feb 26, 2021 at 09:44:41AM -0800, Sean Christopherson wrote: > +Will and Quentin (arm64) > > Moving the non-KVM x86 folks to bcc, I don't they care about KVM details at > this > point. > > On Fri, Feb 26, 2021, Ashish Kalra wrote: > > On Thu, Feb 25, 2021 at 02:59:27PM -0800, Steve

Re: [PATCH v10 10/16] KVM: x86: Introduce KVM_GET_SHARED_PAGES_LIST ioctl

2021-03-02 Thread Ashish Kalra
On Tue, Mar 02, 2021 at 02:55:43PM +, Ashish Kalra wrote: > On Fri, Feb 26, 2021 at 09:44:41AM -0800, Sean Christopherson wrote: > > +Will and Quentin (arm64) > > > > Moving the non-KVM x86 folks to bcc, I don't they care about KVM details at > > this > > point. > > > > On Fri, Feb 26,

Re: [PATCH v10 10/16] KVM: x86: Introduce KVM_GET_SHARED_PAGES_LIST ioctl

2021-02-26 Thread Sean Christopherson
+Will and Quentin (arm64) Moving the non-KVM x86 folks to bcc, I don't they care about KVM details at this point. On Fri, Feb 26, 2021, Ashish Kalra wrote: > On Thu, Feb 25, 2021 at 02:59:27PM -0800, Steve Rutherford wrote: > > On Thu, Feb 25, 2021 at 12:20 PM Ashish Kalra wrote: > > Thanks for

Re: [PATCH v10 10/16] KVM: x86: Introduce KVM_GET_SHARED_PAGES_LIST ioctl

2021-02-26 Thread Ashish Kalra
Hello Steve, On Thu, Feb 25, 2021 at 02:59:27PM -0800, Steve Rutherford wrote: > On Thu, Feb 25, 2021 at 12:20 PM Ashish Kalra wrote: > > > > On Wed, Feb 24, 2021 at 10:22:33AM -0800, Sean Christopherson wrote: > > > On Wed, Feb 24, 2021, Ashish Kalra wrote: > > > > # Samples: 19K of event

Re: [PATCH v10 10/16] KVM: x86: Introduce KVM_GET_SHARED_PAGES_LIST ioctl

2021-02-25 Thread Steve Rutherford
On Thu, Feb 25, 2021 at 2:59 PM Steve Rutherford wrote: > > On Thu, Feb 25, 2021 at 12:20 PM Ashish Kalra wrote: > > > > On Wed, Feb 24, 2021 at 10:22:33AM -0800, Sean Christopherson wrote: > > > On Wed, Feb 24, 2021, Ashish Kalra wrote: > > > > # Samples: 19K of event 'kvm:kvm_hypercall' > > >

Re: [PATCH v10 10/16] KVM: x86: Introduce KVM_GET_SHARED_PAGES_LIST ioctl

2021-02-25 Thread Steve Rutherford
On Thu, Feb 25, 2021 at 12:20 PM Ashish Kalra wrote: > > On Wed, Feb 24, 2021 at 10:22:33AM -0800, Sean Christopherson wrote: > > On Wed, Feb 24, 2021, Ashish Kalra wrote: > > > # Samples: 19K of event 'kvm:kvm_hypercall' > > > # Event count (approx.): 19573 > > > # > > > # Overhead Command

Re: [PATCH v10 10/16] KVM: x86: Introduce KVM_GET_SHARED_PAGES_LIST ioctl

2021-02-25 Thread Ashish Kalra
On Wed, Feb 24, 2021 at 10:22:33AM -0800, Sean Christopherson wrote: > On Wed, Feb 24, 2021, Ashish Kalra wrote: > > # Samples: 19K of event 'kvm:kvm_hypercall' > > # Event count (approx.): 19573 > > # > > # Overhead Command Shared Object Symbol > > # ...

Re: [PATCH v10 10/16] KVM: x86: Introduce KVM_GET_SHARED_PAGES_LIST ioctl

2021-02-24 Thread Sean Christopherson
On Wed, Feb 24, 2021, Ashish Kalra wrote: > # Samples: 19K of event 'kvm:kvm_hypercall' > # Event count (approx.): 19573 > # > # Overhead Command Shared Object Symbol > # ... . > # >100.00% qemu-system-x86

Re: [PATCH v10 10/16] KVM: x86: Introduce KVM_GET_SHARED_PAGES_LIST ioctl

2021-02-24 Thread Ashish Kalra
t.com; > h...@zytor.com; rkrc...@redhat.com; j...@8bytes.org; b...@suse.de; Lendacky, > Thomas ; x...@kernel.org; k...@vger.kernel.org; > linux-kernel@vger.kernel.org; srutherf...@google.com; > venu.busire...@oracle.com; Singh, Brijesh > Subject: Re: [PATCH v10 10/16] KVM: x86: Intro

RE: [PATCH v10 10/16] KVM: x86: Introduce KVM_GET_SHARED_PAGES_LIST ioctl

2021-02-18 Thread Kalra, Ashish
...@kernel.org; k...@vger.kernel.org; linux-kernel@vger.kernel.org; srutherf...@google.com; venu.busire...@oracle.com; Singh, Brijesh Subject: Re: [PATCH v10 10/16] KVM: x86: Introduce KVM_GET_SHARED_PAGES_LIST ioctl On Thu, Feb 04, 2021, Ashish Kalra wrote: > From: Brijesh Singh > > The ioct

Re: [PATCH v10 10/16] KVM: x86: Introduce KVM_GET_SHARED_PAGES_LIST ioctl

2021-02-18 Thread Sean Christopherson
On Thu, Feb 18, 2021, Kalra, Ashish wrote: > From: Sean Christopherson > > On Thu, Feb 18, 2021, Kalra, Ashish wrote: > > From: Sean Christopherson > > > > On Wed, Feb 17, 2021, Kalra, Ashish wrote: > > >> From: Sean Christopherson On Thu, Feb 04, 2021, > > >> Ashish Kalra wrote: > > >> >

RE: [PATCH v10 10/16] KVM: x86: Introduce KVM_GET_SHARED_PAGES_LIST ioctl

2021-02-18 Thread Kalra, Ashish
...@kernel.org; k...@vger.kernel.org; linux-kernel@vger.kernel.org; srutherf...@google.com; venu.busire...@oracle.com; Singh, Brijesh Subject: Re: [PATCH v10 10/16] KVM: x86: Introduce KVM_GET_SHARED_PAGES_LIST ioctl On Thu, Feb 18, 2021, Kalra, Ashish wrote: > From: Sean Christopherson > > On

Re: [PATCH v10 10/16] KVM: x86: Introduce KVM_GET_SHARED_PAGES_LIST ioctl

2021-02-18 Thread Sean Christopherson
On Thu, Feb 18, 2021, Kalra, Ashish wrote: > From: Sean Christopherson > > On Wed, Feb 17, 2021, Kalra, Ashish wrote: > >> From: Sean Christopherson On Thu, Feb 04, 2021, > >> Ashish Kalra wrote: > >> > From: Brijesh Singh > >> > > >> > The ioctl is used to retrieve a guest's shared pages

RE: [PATCH v10 10/16] KVM: x86: Introduce KVM_GET_SHARED_PAGES_LIST ioctl

2021-02-17 Thread Kalra, Ashish
...@kernel.org; k...@vger.kernel.org; linux-kernel@vger.kernel.org; srutherf...@google.com; venu.busire...@oracle.com; Singh, Brijesh Subject: Re: [PATCH v10 10/16] KVM: x86: Introduce KVM_GET_SHARED_PAGES_LIST ioctl On Wed, Feb 17, 2021, Kalra, Ashish wrote: >> From: Sean Christopherson On Thu,

Re: [PATCH v10 10/16] KVM: x86: Introduce KVM_GET_SHARED_PAGES_LIST ioctl

2021-02-17 Thread Sean Christopherson
On Wed, Feb 17, 2021, Kalra, Ashish wrote: > From: Sean Christopherson > On Thu, Feb 04, 2021, Ashish Kalra wrote: > > From: Brijesh Singh > > > > The ioctl is used to retrieve a guest's shared pages list. > > >What's the performance hit to boot time if KVM_HC_PAGE_ENC_STATUS is passed >

RE: [PATCH v10 10/16] KVM: x86: Introduce KVM_GET_SHARED_PAGES_LIST ioctl

2021-02-17 Thread Kalra, Ashish
...@kernel.org; k...@vger.kernel.org; linux-kernel@vger.kernel.org; srutherf...@google.com; venu.busire...@oracle.com; Singh, Brijesh Subject: Re: [PATCH v10 10/16] KVM: x86: Introduce KVM_GET_SHARED_PAGES_LIST ioctl On Thu, Feb 04, 2021, Ashish Kalra wrote: > From: Brijesh Singh > > The ioct

Re: [PATCH v10 10/16] KVM: x86: Introduce KVM_GET_SHARED_PAGES_LIST ioctl

2021-02-16 Thread Sean Christopherson
On Thu, Feb 04, 2021, Ashish Kalra wrote: > From: Brijesh Singh > > The ioctl is used to retrieve a guest's shared pages list. > > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: "H. Peter Anvin" > Cc: Paolo Bonzini > Cc: "Radim Krčmář" AFAIK, Radim is no longer involved with KVM, and his

Re: [PATCH v10 10/16] KVM: x86: Introduce KVM_GET_SHARED_PAGES_LIST ioctl

2021-02-16 Thread Sean Christopherson
On Thu, Feb 04, 2021, Ashish Kalra wrote: > From: Brijesh Singh > > The ioctl is used to retrieve a guest's shared pages list. What's the performance hit to boot time if KVM_HC_PAGE_ENC_STATUS is passed through to userspace? That way, userspace could manage the set of pages in whatever data

Re: [PATCH v10 10/16] KVM: x86: Introduce KVM_GET_SHARED_PAGES_LIST ioctl

2021-02-04 Thread Ashish Kalra
Hello Tom, On Thu, Feb 04, 2021 at 10:14:37AM -0600, Tom Lendacky wrote: > On 2/3/21 6:39 PM, Ashish Kalra wrote: > > From: Brijesh Singh > > > > The ioctl is used to retrieve a guest's shared pages list. > > > > ... > > > +int svm_get_shared_pages_list(struct kvm *kvm, > > +

Re: [PATCH v10 10/16] KVM: x86: Introduce KVM_GET_SHARED_PAGES_LIST ioctl

2021-02-04 Thread Tom Lendacky
On 2/3/21 6:39 PM, Ashish Kalra wrote: From: Brijesh Singh The ioctl is used to retrieve a guest's shared pages list. ... +int svm_get_shared_pages_list(struct kvm *kvm, + struct kvm_shared_pages_list *list) +{ + struct kvm_sev_info *sev =