Re: [PATCH v4] HID: core: move Usage Page concatenation to Main item

2019-04-02 Thread Benjamin Tissoires
On Wed, Mar 27, 2019 at 11:19 AM Nicolas Saenz Julienne wrote: > > As seen on some USB wireless keyboards manufactured by Primax, the HID > parser was using some assumptions that are not always true. In this case > it's s the fact that, inside the scope of a main item, an Usage Page > will always

Re: [PATCH v4] HID: core: move Usage Page concatenation to Main item

2019-03-29 Thread Benjamin Tissoires
On Fri, Mar 29, 2019 at 1:48 AM Junge, Terry wrote: > > On Thursday, March 28, 2019 6:49 AM Benjamin Tissoires > wrote: > >> > >> Hi Nicolas, > >> > >> V4 looks good to me. > > > >Looks good to me too. > > > >Terry, can I consider this as a formal Rev-by you? > > Benjamin, > > Yes, thank you.

RE: [PATCH v4] HID: core: move Usage Page concatenation to Main item

2019-03-28 Thread Junge, Terry
On Thursday, March 28, 2019 6:49 AM Benjamin Tissoires wrote: >> >> Hi Nicolas, >> >> V4 looks good to me. > >Looks good to me too. > >Terry, can I consider this as a formal Rev-by you? Benjamin, Yes, thank you. What is the normal way of formally indicating Rev-by? Regards, Terry > >Cheers,

Re: [PATCH v4] HID: core: move Usage Page concatenation to Main item

2019-03-28 Thread Benjamin Tissoires
On Thu, Mar 28, 2019 at 1:27 AM Junge, Terry wrote: > > Hi Nicolas, > > V4 looks good to me. Looks good to me too. Terry, can I consider this as a formal Rev-by you? Cheers, Benjamin > > Thanks, > Terry > > >-Original Message- > >Subject: [PATCH v4] HID: core: move Usage Page

RE: [PATCH v4] HID: core: move Usage Page concatenation to Main item

2019-03-27 Thread Junge, Terry
Hi Nicolas, V4 looks good to me. Thanks, Terry >-Original Message- >Subject: [PATCH v4] HID: core: move Usage Page concatenation to Main item >