Re: [PATCH v8 5/6] selftests: cgroup: update per-memcg zswap writeback selftest

2023-12-07 Thread Chris Li
Hi Nhat, Thanks for the self test. Acked-by: Chris Li (Google) Chris On Thu, Nov 30, 2023 at 11:40 AM Nhat Pham wrote: > > From: Domenico Cerasuolo > > The memcg-zswap self test is updated to adjust to the behavior change > implemented by commit 87730b165089 ("zswap:

Re: [PATCH v8 4/6] mm: memcg: add per-memcg zswap writeback stat (fix)

2023-12-07 Thread Chris Li
Acked-by: Chris Li (Google) Chris On Tue, Dec 5, 2023 at 11:33 AM Nhat Pham wrote: > > Rename ZSWP_WB to ZSWPWB to better match the existing counters naming > scheme. > > Suggested-by: Johannes Weiner > Signed-off-by: Nhat Pham > --- > include/linux/vm_event_item.h |

Re: [PATCH v8 2/6] memcontrol: implement mem_cgroup_tryget_online()

2023-12-05 Thread Chris Li
On Mon, Dec 4, 2023 at 5:39 PM Nhat Pham wrote: > > > > memcg as a candidate for the global limit reclaim. > > > > Very minor nitpick. This patch can fold with the later patch that uses > > it. That makes the review easier, no need to cross reference different > > patches. It will also make it

Re: [PATCH v8 3/6] zswap: make shrinking memcg-aware

2023-12-05 Thread Chris Li
Hi Nhat, Still working my way up of your patches series. On Thu, Nov 30, 2023 at 11:40 AM Nhat Pham wrote: > > From: Domenico Cerasuolo > > Currently, we only have a single global LRU for zswap. This makes it > impossible to perform worload-specific shrinking - an memcg cannot > determine

Re: [PATCH v8 2/6] memcontrol: implement mem_cgroup_tryget_online()

2023-12-04 Thread Chris Li
Hi Nhat, Very minor nitpick. This patch can fold with the later patch that uses it. That makes the review easier, no need to cross reference different patches. It will also make it harder to introduce API that nobody uses. Chris On Thu, Nov 30, 2023 at 11:40 AM Nhat Pham wrote: > > This patch

Re: [PATCH v8 1/6] list_lru: allows explicit memcg and NUMA node selection

2023-12-04 Thread Chris Li
On Thu, Nov 30, 2023 at 12:35 PM Johannes Weiner wrote: > > On Thu, Nov 30, 2023 at 12:07:41PM -0800, Nhat Pham wrote: > > On Thu, Nov 30, 2023 at 11:57 AM Matthew Wilcox wrote: > > > > > > On Thu, Nov 30, 2023 at 11:40:18AM -0800, Nhat Pham wrote: > > > > This patch changes list_lru interface

Re: [PATCH v5 0/6] workload-specific and memory pressure-driven zswap writeback

2023-11-19 Thread Chris Li
On Fri, Nov 17, 2023 at 8:23 AM Nhat Pham wrote: > > On Thu, Nov 16, 2023 at 4:57 PM Chris Li wrote: > > > > Hi Nhat, > > > > I want want to share the high level feedback we discussed here in the > > mailing list as well. > > > > It is my ob

Re: [PATCH v5 0/6] workload-specific and memory pressure-driven zswap writeback

2023-11-16 Thread Chris Li
. This idea is suggested by Yu Zhao, credit goes to him not me. In other words, the current patch is similar to the memcg page list pre MGLRU world. We can have a MRLRU like per memcg zswap shrink list. Chris On Wed, Nov 8, 2023 at 6:10 PM Chris Li wrote: > > On Wed, Nov 8, 2023 at 4:28 PM Nha

Re: [PATCH v5 0/6] workload-specific and memory pressure-driven zswap writeback

2023-11-08 Thread Chris Li
On Wed, Nov 8, 2023 at 4:28 PM Nhat Pham wrote: > > Hmm my guess is that I probably sent this out based on an outdated > mm-unstable. There has since been a new zswap selftest merged > to mm-unstable (written by no other than myself - oh the irony), so > maybe it does not apply cleanly anymore

Re: [PATCH v5 0/6] workload-specific and memory pressure-driven zswap writeback

2023-11-08 Thread Chris Li
Hi Nhat, On Wed, Nov 8, 2023 at 1:15 PM Nhat Pham wrote: > > Ah that was meant to be a fixlet - so that on top of the original > "zswap: make shrinking memcg-aware" patch. The intention was > to eventually squash it... > > But this is getting a bit annoyingly confusing, I admit. I just rebased

Re: [PATCH v5 0/6] workload-specific and memory pressure-driven zswap writeback

2023-11-08 Thread Chris Li
Hi Nhat, Sorry for being late to the party. I want to take a look at your patches series. However I wasn't able to "git am" your patches series cleanly on current mm-stable, mm-unstable or linux tip. $ git am