dd a dependency on !UML for our new option.
>
> Suggested-by: Guenter Roeck
> Link:
> https://lore.kernel.org/all/928249cc-e027-4f7f-b43f-502f99a1e...@roeck-us.net/
> Fixes: 82b0beff3497 ("kunit: Add tests for fault")
> Signed-off-by: David Gow
Reviewed-and-tested-by: Guenter Roeck
Thanks!
Guenter
On Tue, Apr 09, 2024 at 04:29:42PM +0800, David Gow wrote:
> > +ifeq ($(CCONFIG_KUNIT_SUPPRESS_BACKTRACE),y)
>
> s/CCONFIG_/CONFIG_/ ?
>
>
Odd, I know I tested this (and it still works ;-).
The additional "C" must have slipped in at some point.
Thanks for noticing!
Guenter
On Wed, Apr 03, 2024 at 06:34:12PM -0700, Jakub Kicinski wrote:
> On Wed, 3 Apr 2024 06:19:27 -0700 Guenter Roeck wrote:
> > dev_addr_lists_test generates lock warning noise at the end of tests
> > if lock debugging is enabled. There are two sets of warnings.
> >
> &g
Acked-by: Dan Carpenter
Cc: Michael Ellerman
Signed-off-by: Guenter Roeck
---
v2:
- Rebased to v6.9-rc1
- Added Tested-by:, Acked-by:, and Reviewed-by: tags
- Introduced KUNIT_SUPPRESS_BACKTRACE configuration option
v3:
- Rebased to v6.9-rc2
arch/powerpc/include/asm/bug.h | 37
the __BUG_ENTRY_ADDR and
__BUG_ENTRY_FILE macros into a single macro named __BUG_REL() which takes
the address, file, or function reference as parameter.
Tested-by: Linux Kernel Functional Testing
Acked-by: Dan Carpenter
Cc: Paul Walmsley
Cc: Palmer Dabbelt
Cc: Albert Ou
Signed-off-by: Guenter Roeck
for _EMIT_BUG_ENTRY
to make kerneldoc happy.
Reported-by: Simon Horman
Cc: Simon Horman
Cc: Yoshinori Sato
Cc: Rich Felker
Cc: John Paul Adrian Glaubitz
Signed-off-by: Guenter Roeck
---
v3: Added patch. Possibly squash into previous patch.
arch/sh/include/asm/bug.h | 16 +---
1 file
Acked-by: Dan Carpenter
Cc: Yoshinori Sato
Cc: Rich Felker
Cc: John Paul Adrian Glaubitz
Signed-off-by: Guenter Roeck
---
v2:
- Rebased to v6.9-rc1
- Added Tested-by:, Acked-by:, and Reviewed-by: tags
- Introduced KUNIT_SUPPRESS_BACKTRACE configuration option
v3:
- Rebased to v6.9-rc2
arch/sh
Acked-by: Dan Carpenter
Cc: Heiko Carstens
Cc: Vasily Gorbik
Cc: Alexander Gordeev
Signed-off-by: Guenter Roeck
---
v2:
- Rebased to v6.9-rc1 (simplified assembler changes after upstream commit
3938490e78f4 ("s390/bug: remove entry size from __bug_table section")
- Added Tested-
as constants where possible.
Refine .blockz instructions to calculate the necessary padding instead
of using fixed values.
Tested-by: Linux Kernel Functional Testing
Acked-by: Dan Carpenter
Acked-by: Helge Deller
Signed-off-by: Guenter Roeck
---
v2:
- Rebased to v6.9-rc1
- Added Tested-by:, Acked
Acked-by: Dan Carpenter
Cc: Huacai Chen
Signed-off-by: Guenter Roeck
---
v2:
- Rebased to v6.9-rc1; resolved context conflict
- Added Tested-by:, Acked-by:, and Reviewed-by: tags
- Introduced KUNIT_SUPPRESS_BACKTRACE configuration option
v3:
- Rebased to v6.9-rc2; resolved context conflict
arch
Acked-by: Dan Carpenter
Cc: Catalin Marinas
Cc: Will Deacon
Signed-off-by: Guenter Roeck
---
v2:
- Rebased to v6.9-rc1
- Added Tested-by:, Acked-by:, and Reviewed-by: tags
- Introduced KUNIT_SUPPRESS_BACKTRACE configuration option
v3:
- Rebased to v6.9-rc2
arch/arm64/include/asm/asm-bug.h | 29
Acked-by: Dan Carpenter
Cc: Thomas Gleixner
Cc: Ingo Molnar
Cc: Borislav Petkov
Cc: Dave Hansen
Signed-off-by: Guenter Roeck
---
v2:
- Rebased to v6.9-rc1
- Added Tested-by:, Acked-by:, and Reviewed-by: tags
- Introduced KUNIT_SUPPRESS_BACKTRACE configuration option
v3:
- Rebased to v6.9-rc2
.
Tested-by: Linux Kernel Functional Testing
Cc: David Gow
Cc: Jakub Kicinski
Cc: Eric Dumazet
Acked-by: Dan Carpenter
Signed-off-by: Guenter Roeck
---
v2:
- Rebased to v6.9-rc1
- Added Tested-by:, Acked-by:, and Reviewed-by: tags
v3:
- Rebased to v6.9-rc2
net/core/dev_addr_lists_test.c | 6
log and distraction from real problems.
Tested-by: Linux Kernel Functional Testing
Acked-by: Dan Carpenter
Acked-by: Maíra Canal
Cc: Maarten Lankhorst
Cc: David Airlie
Cc: Daniel Vetter
Signed-off-by: Guenter Roeck
---
v2:
- Rebased to v6.9-rc1
- Added Tested-by:, Acked-by:, and Reviewed
Document API functions for suppressing warning backtraces.
Tested-by: Linux Kernel Functional Testing
Acked-by: Dan Carpenter
Reviewed-by: Kees Cook
Signed-off-by: Guenter Roeck
---
v2:
- Rebased to v6.9-rc1
- Added Tested-by:, Acked-by:, and Reviewed-by: tags
v3:
- Rebased to v6.9-rc2
Acked-by: Dan Carpenter
Reviewed-by: Kees Cook
Signed-off-by: Guenter Roeck
---
v2:
- Rebased to v6.9-rc1
- Added Tested-by:, Acked-by:, and Reviewed-by: tags
- Introduced KUNIT_SUPPRESS_BACKTRACE configuration option
v3:
- Rebased to v6.9-rc2
lib/kunit/Makefile | 7 +-
lib
.
Acked-by: Dan Carpenter
Reviewed-by: Kees Cook
Tested-by: Linux Kernel Functional Testing
Signed-off-by: Guenter Roeck
---
v2:
- Rebased to v6.9-rc1
- Added Tested-by:, Acked-by:, and Reviewed-by: tags
- Introduced KUNIT_SUPPRESS_BACKTRACE configuration option
v3:
- Rebased to v6.9-rc2
include
Cc: Daniel Diaz
Cc: Naresh Kamboju
Cc: Kees Cook
Tested-by: Linux Kernel Functional Testing
Acked-by: Dan Carpenter
Reviewed-by: Kees Cook
Signed-off-by: Guenter Roeck
---
v2:
- Rebased to v6.9-rc1
- Added Tested-by:, Acked-by:, and Reviewed-by: tags
- Added CONFIG_KUNIT_SUPPRESS_BACKTRACE con
/asm/bug.h
to avoid kerneldoc warning
- Added architecture maintainers to Cc: for architecture specific patches
- No functional changes
--------
Guenter Roeck (15):
bug/kunit: Core support for suppressing warning backtraces
kunit:
On Wed, Mar 27, 2024 at 07:39:20PM +, Simon Horman wrote:
[ ... ]
> > >
> > > Hi Guenter,
> > >
> > > a minor nit from my side: this change results in a Kernel doc warning.
> > >
> > > .../bug.h:29: warning: expecting prototype for _EMIT_BUG_ENTRY().
> > > Prototype was for
On 3/27/24 07:44, Simon Horman wrote:
On Mon, Mar 25, 2024 at 10:52:46AM -0700, Guenter Roeck wrote:
Add name of functions triggering warning backtraces to the __bug_table
object section to enable support for suppressing WARNING backtraces.
To limit image size impact, the pointer
On 3/25/24 18:09, Maíra Canal wrote:
On 3/25/24 16:24, Guenter Roeck wrote:
Hi,
On Mon, Mar 25, 2024 at 04:05:06PM -0300, Maíra Canal wrote:
Hi Guenter,
On 3/25/24 14:52, Guenter Roeck wrote:
The drm_test_rect_calc_hscale and drm_test_rect_calc_vscale unit tests
intentionally trigger
Cc: Daniel Diaz
Cc: Naresh Kamboju
Cc: Kees Cook
Tested-by: Linux Kernel Functional Testing
Acked-by: Dan Carpenter
Reviewed-by: Kees Cook
Signed-off-by: Guenter Roeck
---
v2:
- Rebased to v6.9-rc1
- Added Tested-by:, Acked-by:, and Reviewed-by: tags
- Added CONFIG_KUNIT_SUPPRESS_BACKTRACE con
Acked-by: Dan Carpenter
Signed-off-by: Guenter Roeck
---
- Rebased to v6.9-rc1
- Added Tested-by:, Acked-by:, and Reviewed-by: tags
- Introduced KUNIT_SUPPRESS_BACKTRACE configuration option
arch/powerpc/include/asm/bug.h | 37 +-
1 file changed, 28 insertions(+), 9
Hi,
On Mon, Mar 25, 2024 at 04:05:06PM -0300, Maíra Canal wrote:
> Hi Guenter,
>
> On 3/25/24 14:52, Guenter Roeck wrote:
> > The drm_test_rect_calc_hscale and drm_test_rect_calc_vscale unit tests
> > intentionally trigger warning backtraces by providing bad paramet
the __BUG_ENTRY_ADDR and
__BUG_ENTRY_FILE macros into a single macro named __BUG_REL() which takes
the address, file, or function reference as parameter.
Tested-by: Linux Kernel Functional Testing
Acked-by: Dan Carpenter
Signed-off-by: Guenter Roeck
---
- Rebased to v6.9-rc1
- Added Tested-by:, Acked
Acked-by: Dan Carpenter
Signed-off-by: Guenter Roeck
---
- Rebased to v6.9-rc1
- Added Tested-by:, Acked-by:, and Reviewed-by: tags
- Introduced KUNIT_SUPPRESS_BACKTRACE configuration option
arch/sh/include/asm/bug.h | 26 ++
1 file changed, 22 insertions(+), 4 deletions
Acked-by: Dan Carpenter
Signed-off-by: Guenter Roeck
---
- Rebased to v6.9-rc1 (simplified assembler changes after upstream commit
3938490e78f4 ("s390/bug: remove entry size from __bug_table section")
- Added Tested-by:, Acked-by:, and Reviewed-by: tags
- Introduced KUNIT_SUPPRESS
Acked-by: Dan Carpenter
Signed-off-by: Guenter Roeck
---
- Rebased to v6.9-rc1; resolved context conflict
- Added Tested-by:, Acked-by:, and Reviewed-by: tags
- Introduced KUNIT_SUPPRESS_BACKTRACE configuration option
arch/loongarch/include/asm/bug.h | 38 +++-
1 file
as constants where possible.
Refine .blockz instructions to calculate the necessary padding instead
of using fixed values.
Tested-by: Linux Kernel Functional Testing
Acked-by: Dan Carpenter
Acked-by: Helge Deller
Signed-off-by: Guenter Roeck
---
- Rebased to v6.9-rc1
- Added Tested-by:, Acked
Acked-by: Dan Carpenter
Signed-off-by: Guenter Roeck
---
- Rebased to v6.9-rc1
- Added Tested-by:, Acked-by:, and Reviewed-by: tags
- Introduced KUNIT_SUPPRESS_BACKTRACE configuration option
arch/arm64/include/asm/asm-bug.h | 29 +++--
arch/arm64/include/asm/bug.h | 8
Acked-by: Dan Carpenter
Signed-off-by: Guenter Roeck
---
- Rebased to v6.9-rc1
- Added Tested-by:, Acked-by:, and Reviewed-by: tags
- Introduced KUNIT_SUPPRESS_BACKTRACE configuration option
arch/x86/include/asm/bug.h | 21 -
1 file changed, 16 insertions(+), 5 deletions(-)
diff
-by: Linux Kernel Functional Testing
Cc: David Gow
Cc: Jakub Kicinski
Acked-by: Dan Carpenter
Signed-off-by: Guenter Roeck
---
- Rebased to v6.9-rc1
- Added Tested-by:, Acked-by:, and Reviewed-by: tags
net/core/dev_addr_lists_test.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/net/core
log.
Tested-by: Linux Kernel Functional Testing
Acked-by: Dan Carpenter
Signed-off-by: Guenter Roeck
---
- Rebased to v6.9-rc1
- Added Tested-by:, Acked-by:, and Reviewed-by: tags
drivers/gpu/drm/tests/drm_rect_test.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm
Document API functions for suppressing warning backtraces.
Tested-by: Linux Kernel Functional Testing
Acked-by: Dan Carpenter
Reviewed-by: Kees Cook
Signed-off-by: Guenter Roeck
---
- Rebased to v6.9-rc1
- Added Tested-by:, Acked-by:, and Reviewed-by: tags
Documentation/dev-tools/kunit
Acked-by: Dan Carpenter
Reviewed-by: Kees Cook
Signed-off-by: Guenter Roeck
---
- Rebased to v6.9-rc1
- Added Tested-by:, Acked-by:, and Reviewed-by: tags
- Introduced KUNIT_SUPPRESS_BACKTRACE configuration option
lib/kunit/Makefile | 7 +-
lib/kunit/backtrace-suppression
.
Acked-by: Dan Carpenter
Reviewed-by: Kees Cook
Tested-by: Linux Kernel Functional Testing
Signed-off-by: Guenter Roeck
---
- Rebased to v6.9-rc1
- Added Tested-by:, Acked-by:, and Reviewed-by: tags
- Introduced KUNIT_SUPPRESS_BACKTRACE configuration option
include/kunit/bug.h | 7 ++-
lib
Some unit tests intentionally trigger warning backtraces by passing bad
parameters to kernel API functions. Such unit tests typically check the
return value from such calls, not the existence of the warning backtrace.
Such intentionally generated warning backtraces are neither desirable
nor
On 3/14/24 07:37, Guenter Roeck wrote:
On 3/14/24 06:36, Geert Uytterhoeven wrote:
Hi Günter,
On Tue, Mar 12, 2024 at 6:03 PM Guenter Roeck wrote:
Some unit tests intentionally trigger warning backtraces by passing bad
parameters to kernel API functions. Such unit tests typically check
On 3/14/24 08:02, Maxime Ripard wrote:
On Thu, Mar 14, 2024 at 07:37:13AM -0700, Guenter Roeck wrote:
On 3/14/24 06:36, Geert Uytterhoeven wrote:
Hi Günter,
On Tue, Mar 12, 2024 at 6:03 PM Guenter Roeck wrote:
Some unit tests intentionally trigger warning backtraces by passing bad
On 3/14/24 06:36, Geert Uytterhoeven wrote:
Hi Günter,
On Tue, Mar 12, 2024 at 6:03 PM Guenter Roeck wrote:
Some unit tests intentionally trigger warning backtraces by passing bad
parameters to kernel API functions. Such unit tests typically check the
return value from such calls
On 3/14/24 00:57, Geert Uytterhoeven wrote:
Hi Günter,
On Tue, Mar 12, 2024 at 6:06 PM Guenter Roeck wrote:
Add name of functions triggering warning backtraces to the __bug_table
object section to enable support for suppressing WARNING backtraces.
To limit image size impact, the pointer
are enabled. Otherwise, the __func__ assembly parameter is replaced with a
(dummy) NULL parameter to avoid an image size increase due to unused
__func__ entries (this is necessary because __func__ is not a define but a
virtual variable).
Signed-off-by: Guenter Roeck
---
arch/powerpc/include/asm/bug.h
and
__BUG_ENTRY_FILE macros into a single macro named __BUG_REL() which takes
the address, file, or function reference as parameter.
Signed-off-by: Guenter Roeck
---
arch/riscv/include/asm/bug.h | 38
1 file changed, 26 insertions(+), 12 deletions(-)
diff --git
are enabled. Otherwise, the __func__ assembly parameter is replaced with a
(dummy) NULL parameter to avoid an image size increase due to unused
__func__ entries (this is necessary because __func__ is not a define but a
virtual variable).
Signed-off-by: Guenter Roeck
---
arch/sh/include/asm/bug.h | 26
are enabled. Otherwise, the __func__ assembly parameter is replaced with a
(dummy) NULL parameter to avoid an image size increase due to unused
__func__ entries (this is necessary because __func__ is not a define but a
virtual variable).
Signed-off-by: Guenter Roeck
---
arch/s390/include/asm/bug.h | 19
possible.
Refine .blockz instructions to calculate the necessary padding instead
of using fixed values.
Signed-off-by: Guenter Roeck
---
arch/parisc/include/asm/bug.h | 29 +
1 file changed, 21 insertions(+), 8 deletions(-)
diff --git a/arch/parisc/include/asm/bug.h b/arch
are enabled. Otherwise, the __func__ assembly parameter is replaced with a
(dummy) NULL parameter to avoid an image size increase due to unused
__func__ entries (this is necessary because __func__ is not a define but a
virtual variable).
Signed-off-by: Guenter Roeck
---
arch/loongarch/include/asm/bug.h
are enabled. Otherwise, the __func__ assembly parameter is replaced with a
(dummy) NULL parameter to avoid an image size increase due to unused
__func__ entries (this is necessary because __func__ is not a define but a
virtual variable).
Signed-off-by: Guenter Roeck
---
arch/arm64/include/asm/asm-bug.h
are enabled. Otherwise, the __func__ assembly parameter is replaced with a
(dummy) NULL parameter to avoid an image size increase due to unused
__func__ entries (this is necessary because __func__ is not a define but a
virtual variable).
Signed-off-by: Guenter Roeck
---
arch/x86/include/asm/bug.h | 21
Cc: Jakub Kicinski
Signed-off-by: Guenter Roeck
---
net/core/dev_addr_lists_test.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/net/core/dev_addr_lists_test.c b/net/core/dev_addr_lists_test.c
index 4dbd0dc6aea2..b427dd1a3c93 100644
--- a/net/core/dev_addr_lists_test.c
+++ b/net/core
log.
Signed-off-by: Guenter Roeck
---
drivers/gpu/drm/tests/drm_rect_test.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/tests/drm_rect_test.c
b/drivers/gpu/drm/tests/drm_rect_test.c
index 76332cd2ead8..75614cb4deb5 100644
--- a/drivers/gpu/drm/tests/drm_rect_test.c
Document API functions for suppressing warning backtraces.
Signed-off-by: Guenter Roeck
---
Documentation/dev-tools/kunit/usage.rst | 30 -
1 file changed, 29 insertions(+), 1 deletion(-)
diff --git a/Documentation/dev-tools/kunit/usage.rst
b/Documentation/dev-tools
Add unit tests to verify that warning backtrace suppression works.
If backtrace suppression does _not_ work, the unit tests will likely
trigger unsuppressed backtraces, which should actually help to get
the affected architectures / platforms fixed.
Signed-off-by: Guenter Roeck
---
lib/kunit
.
Signed-off-by: Guenter Roeck
---
include/kunit/bug.h | 7 ++-
lib/kunit/bug.c | 4 +++-
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/include/kunit/bug.h b/include/kunit/bug.h
index 1e34da961599..2097a854ac8c 100644
--- a/include/kunit/bug.h
+++ b/include/kunit/bug.h
@@ -20,6
Cc: Naresh Kamboju
Cc: Kees Cook
Signed-off-by: Guenter Roeck
---
include/asm-generic/bug.h | 16 +---
include/kunit/bug.h | 51 +++
include/kunit/test.h | 1 +
include/linux/bug.h | 13 ++
lib/bug.c
Some unit tests intentionally trigger warning backtraces by passing bad
parameters to kernel API functions. Such unit tests typically check the
return value from such calls, not the existence of the warning backtrace.
Such intentionally generated warning backtraces are neither desirable
nor
On Tue, Mar 05, 2024 at 10:40:28AM -0800, Guenter Roeck wrote:
> Some unit tests intentionally trigger warning backtraces by passing bad
> parameters to kernel API functions. Such unit tests typically check the
> return value from such calls, not the existence of the warning
Hi Daniel,
On 3/6/24 10:24, Daniel Díaz wrote:
[ ... ]
Thank you SO very much for this work! This is very much appreciated!
Thanks a lot for the feedback.
We run into these warnings at LKFT all the time, and making sure that
the noise doesn't drown the relevant signal is very important.
On 3/5/24 11:54, Kees Cook wrote:
On Tue, Mar 05, 2024 at 10:40:29AM -0800, Guenter Roeck wrote:
[...]
warning = (bug->flags & BUGFLAG_WARNING) != 0;
once = (bug->flags & BUGFLAG_ONCE) != 0;
done = (bug->flags & BUGFLAG_DONE) !
and CONFIG_DEBUG_BUGVERBOSE
are enabled. Otherwise, the __func__ assembly parameter is replaced with a
(dummy) NULL parameter to avoid an image size increase due to unused
__func__ entries (this is necessary because __func__ is not a define but a
virtual variable).
Signed-off-by: Guenter Roeck
---
arch
and CONFIG_DEBUG_BUGVERBOSE
are enabled. Otherwise, the __func__ assembly parameter is replaced with a
(dummy) NULL parameter to avoid an image size increase due to unused
__func__ entries (this is necessary because __func__ is not a define but a
virtual variable).
Signed-off-by: Guenter Roeck
---
arch/arm64
and CONFIG_DEBUG_BUGVERBOSE
are enabled. Otherwise, the __func__ assembly parameter is replaced with a
(dummy) NULL parameter to avoid an image size increase due to unused
__func__ entries (this is necessary because __func__ is not a define but a
virtual variable).
Signed-off-by: Guenter Roeck
---
arch/x86
log.
Signed-off-by: Guenter Roeck
---
drivers/gpu/drm/tests/drm_rect_test.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/tests/drm_rect_test.c
b/drivers/gpu/drm/tests/drm_rect_test.c
index 76332cd2ead8..75614cb4deb5 100644
--- a/drivers/gpu/drm/tests/drm_rect_test.c
Cc: Naresh Kamboju
Cc: Kees Cook
Signed-off-by: Guenter Roeck
---
include/asm-generic/bug.h | 16 +---
include/kunit/bug.h | 51 +++
include/linux/bug.h | 13 ++
lib/bug.c | 51 ++
y of those of interest ?
--------
Guenter Roeck (5):
bug: Core support for suppressing warning backtraces
drm: Suppress intentional warning backtraces in scaling unit tests
x86: Add support for suppressing warning tracebacks
On Mon, Mar 4, 2024 at 9:09 AM Maxime Ripard wrote:
[ ...]
>
> And singling out DRM because it regularly allegedly breaks things on
> xtensa or m68k and claiming we're not taking CI seriously because of it
> is completely ridiculous. If the all the subsystems were taking CI as
> seriously as
On Mon, Mar 4, 2024 at 9:09 AM Maxime Ripard wrote:
> And singling out DRM because it regularly allegedly breaks things on
> xtensa or m68k and claiming we're not taking CI seriously because of it
> is completely ridiculous. If the all the subsystems were taking CI as
> seriously as DRM, we
On Mon, Mar 4, 2024 at 8:05 AM Maxime Ripard wrote:
>
> On Mon, Mar 04, 2024 at 07:46:34AM -0800, Guenter Roeck wrote:
> > On Mon, Mar 4, 2024 at 1:24 AM Maxime Ripard wrote:
> > [ ... ]
> > >
> > > If anything, it's more of a side-effect to the push
On Mon, Mar 4, 2024 at 1:24 AM Maxime Ripard wrote:
[ ... ]
>
> If anything, it's more of a side-effect to the push for COMPILE_TEST
> than anything.
>
If the drm subsystem maintainers don't want people to build it with
COMPILE_TEST while at the same time not limiting it to platforms where
it
On Thu, Feb 29, 2024 at 12:21 PM Linus Torvalds
wrote:
>
> On Thu, 29 Feb 2024 at 01:23, Nikolai Kondrashov wrote:
> >
> > However, I think a better approach would be *not* to add the .gitlab-ci.yaml
> > file in the root of the source tree, but instead change the very same repo
> > setting to
On 2/29/24 00:10, David Gow wrote:
On Thu, 29 Feb 2024 at 03:45, Guenter Roeck wrote:
Hi,
when running the dev_addr_lists unit test with lock debugging enabled,
I always get the following lockdep warning.
[7.031327]
[7.031393] WARNING
On 2/29/24 11:38, Charlie Jenkins wrote:
[ ... ]
Tough one. I can't enable CONFIG_NET_TEST on nios2, parisc, and arm with THUMB
enabled due to crashes or hangs in gso tests. I accept that. Downside is that I
have to disable CONFIG_NET_TEST on those architectures/platforms entirely,
meaning a
On 2/29/24 00:10, David Gow wrote:
On Thu, 29 Feb 2024 at 03:45, Guenter Roeck wrote:
Hi,
when running the dev_addr_lists unit test with lock debugging enabled,
I always get the following lockdep warning.
[7.031327]
[7.031393] WARNING
Hi,
when running the dev_addr_lists unit test with lock debugging enabled,
I always get the following lockdep warning.
[7.031327]
[7.031393] WARNING: kunit_try_catch/1886 still has locks held!
[7.031478] 6.8.0-rc6-00053-g0fec7343edb5-dirty #1
On 2/28/24 02:15, Geert Uytterhoeven wrote:
CC testing
On Wed, Feb 28, 2024 at 8:59 AM Guenter Roeck wrote:
On 2/27/24 23:25, Christophe Leroy wrote:
[ ... ]
This test case is supposed to be as true to the "general case" as
possible, so I have aligned the data along 14 + NE
should work on any platform to fix
> it.
>
> Fixes: d03c720e03bd ("kunit: Add APIs for managing devices")
> Signed-off-by: Maxime Ripard
Tested-by: Guenter Roeck
Guenter
that we've fixed these errors, to
> prevent them from recurring.
>
> Suggested-by: Linus Torvalds
> Signed-off-by: David Gow
Tested-by: Guenter Roeck
> ---
> include/kunit/test.h | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/include
ot;)
> Signed-off-by: David Gow
Tested-by: Guenter Roeck
> ---
> drivers/gpu/drm/xe/tests/xe_migrate.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/tests/xe_migrate.c
> b/drivers/gpu/drm/xe/tests/xe_migrate.c
> index a6
fix build failure on 32-bit
> targets")
> Fixes: fc8d29e298cf ("drm: selftest: convert drm_mm selftest to KUnit")
> Signed-off-by: David Gow
Tested-by: Guenter Roeck
> ---
> drivers/gpu/drm/tests/drm_buddy_test.c | 14 +++---
> drivers/gpu/drm/tests/dr
he actual error pointer. printk() will format
> it correctly (and give a symbolic name rather than a number if
> available, which should make the output more readable, too).
>
> Fixes: b3098d32ed6e ("net: add skb_segment kunit test")
> Signed-off-by: David Gow
Test
nce of rtc_time64_to_tm(). Add
> tests.")
> Signed-off-by: David Gow
Tested-by: Guenter Roeck
> ---
> drivers/rtc/lib_test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/lib_test.c b/drivers/rtc/lib_test.c
> index d5caf36c56cd
ormance of time64_to_tm()")
> Signed-off-by: David Gow
Tested-by: Guenter Roeck
> ---
> kernel/time/time_test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/time/time_test.c b/kernel/time/time_test.c
> index ca058c8af6ba..3e5d422dd15c 1006
s: bb95ebbe89a7 ("lib: Introduce CONFIG_MEMCPY_KUNIT_TEST")
> Signed-off-by: David Gow
Tested-by: Guenter Roeck
> ---
> lib/memcpy_kunit.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/memcpy_kunit.c b/lib/memcpy_kunit.c
>
gcc incorrectly suggested a %d or %ld
> specifier (depending on the pointer size of the architecture being
> built).
>
> Fixes: 0ea09083116d ("lib/cmdline: Allow get_options() to take 0 to validate
> the input")
> Signed-off-by: David Gow
Tested-by: Guenter Roeck
&g
et gcc validate
> the format string.
>
> Fixes: 76066f93f1df ("kunit: add tests for filtering attributes")
> Signed-off-by: David Gow
Tested-by: Guenter Roeck
> ---
> lib/kunit/executor_test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
86 matches
Mail list logo