On Thu, Jun 06, 2024 at 09:27:14PM +, Abhinav Jain wrote:
> This patch addresses the present TODO in the file.
> I have tested it manually on my system and added relevant filtering to
> ensure that the correct feature list is being checked.
>
> Signed-off-by: Abhinav Jain
> ---
>
On Mon, Jun 03, 2024 at 08:56:43PM +0200, Adrian Moreno wrote:
> Add a test to verify sampling packets via psample works.
>
> In order to do that, create a subcommand in ovs-dpctl.py to listen to
> on the psample multicast group and print samples.
>
> In order to also test simultaneous sFlow and
ected")
> Signed-off-by: Hangbin Liu
Tested-by: Simon Horman
Reviewed-by: Simon Horman
gic.
>
> Fixes: c08e8baea78e ("selftests: add amt interface selftest script")
> Signed-off-by: Taehee Yoo
Thanks for the updates.
Reviewed-by: Simon Horman
On Fri, May 17, 2024 at 12:04:20PM -0700, Jakub Kicinski wrote:
> On Fri, 17 May 2024 10:14:02 +0100 Simon Horman wrote:
> > Jakub, is there a way to tell how long a test took to execute?
> > Perhaps it's obvious, but I couldn't see it.
>
> It's not obvious, and it was bro
itive, albeit perhaps a bit too soon to call.
Jakub, is there a way to tell how long a test took to execute?
Perhaps it's obvious, but I couldn't see it.
Code changes look good to me.
Reviewed-by: Simon Horman
priate for cases like this - the test
is expected to fail and this can act like a TODO.
I also looked over how xfail_on_veth works and this usage seems
correct to me.
Reviewed-by: Simon Horman
On Mon, May 13, 2024 at 06:08:52AM +, Taehee Yoo wrote:
> The amt.sh requires smcrouted for multicasting routing.
> So, it starts smcrouted before forwarding tests.
> It must be stopped after all tests, but it isn't.
>
> To fix this issue, it kills smcrouted in the cleanup logic.
>
> Fixes:
On Tue, May 14, 2024 at 10:33:59AM +0800, Hangbin Liu wrote:
> There is no need to add the name to ns_list again if the netns already
> recoreded.
>
> Fixes: 25ae948b4478 ("selftests/net: add lib.sh")
> Signed-off-by: Hangbin Liu
Reviewed-by: Simon Horman
of LINE_MAX.
>
> Fixes: 38c957f07038 ("selftests: kselftest_harness: generate test name once")
> Signed-off-by: Tao Su
Reviewed-by: Simon Horman
late in the 6.9 cycle.
>
> Link: https://lore.kernel.org/linux-kselftest/zjua3ay_ihkjp...@google.com/
> Fixes: 809216233555 ("selftests/harness: remove use of LINE_MAX")
> Signed-off-by: Tao Su
Reviewed-by: Simon Horman
On Fri, May 10, 2024 at 09:48:11AM +0100, Colin Ian King wrote:
> There is a spelling mistake in a TH_LOG message. Fix it.
>
> Signed-off-by: Colin Ian King
Reviewed-by: Simon Horman
On Wed, May 08, 2024 at 04:06:43AM +, Taehee Yoo wrote:
> In the forwarding testcase, it opens a server and a client with the nc.
> The server receives the correct message from NC, it prints OK.
> The server prints FAIL if it receives the wrong message from the client.
>
> But If the server
On Tue, May 07, 2024 at 11:11:55AM +0200, Lukasz Majewski wrote:
> Without this change the created netns instances are not cleared after
> this script execution. To fix this problem the cleanup_all_ns function
> from ../lib.sh is called.
>
> Signed-off-by: Lukasz Majewski
Rev
On Thu, Apr 25, 2024 at 12:21:51PM -0700, Jakub Kicinski wrote:
> On Thu, 25 Apr 2024 19:57:19 +0100 Simon Horman wrote:
> > openvswitch.sh does not appear to have any dependencies on Open vSwitch
> > user-space. My understanding is that, rather, it makes use of
> > tools/
+ Aaron
On Thu, Apr 25, 2024 at 09:26:37AM +0100, Simon Horman wrote:
> On Wed, Apr 24, 2024 at 05:30:00PM -0700, Jakub Kicinski wrote:
> > On Wed, 24 Apr 2024 17:44:05 +0100 Simon Horman wrote:
> > > I have recently been exercising the Open vSwitch kernel selftest
On Wed, Apr 24, 2024 at 05:30:00PM -0700, Jakub Kicinski wrote:
> On Wed, 24 Apr 2024 17:44:05 +0100 Simon Horman wrote:
> > I have recently been exercising the Open vSwitch kernel selftests,
> > using vng,
>
> Speaking of ovs tests, we currently don't run them in CI (and s
On Wed, Apr 24, 2024 at 02:14:09PM -0400, Aaron Conole wrote:
> Simon Horman writes:
>
> > Hi Aaron, Jakub, all,
> >
> > I have recently been exercising the Open vSwitch kernel selftests,
> > using vng, something like this:
> >
> > TESTDI
On Wed, Apr 24, 2024 at 01:59:29PM -0400, Benjamin Poirier wrote:
> On 2024-04-24 18:37 +0100, Simon Horman wrote:
> > On Wed, Apr 24, 2024 at 05:44:05PM +0100, Simon Horman wrote:
> > > Hi Aaron, Jakub, all,
> > >
> > > I have recently been exercisi
On Wed, Apr 24, 2024 at 05:44:05PM +0100, Simon Horman wrote:
> Hi Aaron, Jakub, all,
>
> I have recently been exercising the Open vSwitch kernel selftests,
> using vng, something like this:
>
> TESTDIR="tools/testing/selftests/net/openvswitch"
>
>
Hi Aaron, Jakub, all,
I have recently been exercising the Open vSwitch kernel selftests,
using vng, something like this:
TESTDIR="tools/testing/selftests/net/openvswitch"
vng -v --run . --user root --cpus 2 \
--overlay-rwdir "$PWD" -- \
"modprobe
Prototype was for HAVE_BUG_FUNCTION() instead
>
> Move the defines above the kerneldoc entry for _EMIT_BUG_ENTRY
> to make kerneldoc happy.
>
> Reported-by: Simon Horman
> Cc: Simon Horman
> Cc: Yoshinori Sato
> Cc: Rich Felker
> Cc: John Paul Adrian Glaubitz
> Signed-o
On Tue, Apr 02, 2024 at 05:20:43PM -0700, Mina Almasry wrote:
> Abstrace the memory type from the page_pool so we can later add support
> for new memory types. Convert the page_pool to use the new netmem type
> abstraction, rather than use struct page directly.
>
> As of this patch the netmem
On Thu, Mar 28, 2024 at 11:55:23AM -0700, Mina Almasry wrote:
> On Thu, Mar 28, 2024 at 11:28 AM Simon Horman wrote:
> >
> > On Tue, Mar 26, 2024 at 03:50:35PM -0700, Mina Almasry wrote:
> > > Add a netdev_dmabuf_binding struct which represents the
> > > dma-buf-
On Tue, Mar 26, 2024 at 03:50:35PM -0700, Mina Almasry wrote:
> Add a netdev_dmabuf_binding struct which represents the
> dma-buf-to-netdevice binding. The netlink API will bind the dma-buf to
> rx queues on the netdevice. On the binding, the dma_buf_attach
> & dma_buf_map_attachment will occur.
On Wed, Mar 27, 2024 at 08:10:51AM -0700, Guenter Roeck wrote:
> On 3/27/24 07:44, Simon Horman wrote:
> > On Mon, Mar 25, 2024 at 10:52:46AM -0700, Guenter Roeck wrote:
> > > Add name of functions triggering warning backtraces to the __bug_table
> > > objec
On Mon, Mar 25, 2024 at 10:52:46AM -0700, Guenter Roeck wrote:
> Add name of functions triggering warning backtraces to the __bug_table
> object section to enable support for suppressing WARNING backtraces.
>
> To limit image size impact, the pointer to the function name is only added
> to the
kefile for selftests")
> Signed-off-by: Jakub Kicinski
Reviewed-by: Simon Horman
would be ok).
>
> Signed-off-by: Sabrina Dubroca
Reviewed-by: Simon Horman
On Sat, Feb 24, 2024 at 09:04:11AM +, Dmitry Safonov wrote:
> Two reasons:
> 1. It's grown up enough
> 2. In order to not do header spaghetti by including
>, which is necessary for TCP tracepoints.
>
> Signed-off-by: Dmitry Safonov
...
> diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
>
will take care of that.
>
> Signed-off-by: Paolo Abeni
> Reviewed-by: Matthieu Baerts (NGI0)
> Signed-off-by: Matthieu Baerts (NGI0)
Reviewed-by: Simon Horman
config entries.
>
> Fixes: 6d4efada3b82 ("selftests: forwarding: Add multicast routing test")
> Signed-off-by: Ido Schimmel
> ---
> Targeting at net-next because this is where 4acf4e62cd57 ("selftests:
> forwarding: Add missing config entries") was applied to, bu
On Tue, Feb 06, 2024 at 05:18:23PM -0800, Jakub Kicinski wrote:
> This exact case was fail for async crypto and we weren't
> catching it.
>
> Signed-off-by: Jakub Kicinski
Reviewed-by: Simon Horman
safe to run even on systems that don't have the fix
> applied.
>
> Signed-off-by: Aaron Conole
> ---
> v1->v2: Used a slightly more portable io redirection semantic for the
> clone() flow test case.
Reviewed-by: Simon Horman
than limited at the current userspace
> limit.
>
> Fixes: 798c166173ff ("openvswitch: Optimize sample action for the clone use
> cases")
> Signed-off-by: Aaron Conole
> ---
> v1->v2: Switch to tracking the stack depth by using a depth argument rather
> than
> a per-cpu counter.
Thanks for the update.
Reviewed-by: Simon Horman
("selftests: net: test IPV6_TCLASS")
> Signed-off-by: Jakub Kicinski
I'm not sure if it is important, but doesn't this also:
Fixes: 05ae83d5a4a2 ("selftests: net: test IPV6_HOPLIMIT")
In any case, this looks good to me.
Reviewed-by: Simon Horman
eues packets in FQ with a future
> delivery time to fill the qdisc.
>
> The test failed in a virtual environment (vng). Increase the delays
> to make it more tolerant to environments with timing variance.
>
> Signed-off-by: Willem de Bruijn
Reviewed-by: Simon Horman
rate.
>
> Signed-off-by: Willem de Bruijn
Reviewed-by: Simon Horman
n't interpret leading zeroes as oct
> so that should be good enough. Switch to bash, Simon reports that
> not all shells support this type of substitution.
>
> Fixes: c12e0d5f267d ("self-tests: introduce self-tests for RPS default mask")
> Signed-off-by: Jakub Kicinski
Reviewed-by: Simon Horman
; failures. Let's copy the WAIT_TIMEOUT from forwarding/lib.sh and set
> BUSYWAIT_TIMEOUT here.
>
> Fixes: 25ae948b4478 ("selftests/net: add lib.sh")
> Signed-off-by: Hangbin Liu
Reviewed-by: Simon Horman
sts: net: add a test for UDP tunnel info infra")
> Signed-off-by: Jakub Kicinski
I see some discussion of a follow-up to move away from ifconfig which I
agree with (which century are we in now?). But this patch looks good in
it's own right.
Reviewed-by: Simon Horman
On Sun, Jan 21, 2024 at 08:34:38PM +, Simon Horman wrote:
> On Sat, Jan 20, 2024 at 01:02:56PM -0800, Jakub Kicinski wrote:
> > If there is more than 32 cpus the bitmask will start to contain
> > commas, leading to:
> >
> > ./rps_default_mask.sh: line 36: [:
51248.3476897-1-k...@kernel.org/
Thanks,
this version looks good to me.
Reviewed-by: Simon Horman
On Fri, Jan 19, 2024 at 07:12:48AM -0800, Jakub Kicinski wrote:
> If there is more than 32 cpus the bitmask will start to contain
> commas, leading to:
>
> ./rps_default_mask.sh: line 36: [: ,: integer expression
> expected
>
> Remove the commas, bash doesn't interpret leading
On Fri, Jan 19, 2024 at 06:37:46PM +, Dmitry Safonov wrote:
> Hi Simon,
>
> On 1/19/24 16:25, Simon Horman wrote:
> > On Thu, Jan 18, 2024 at 02:51:36AM +, Dmitry Safonov wrote:
> >> Yeah, copy'n'paste typo.
> >>
> >> Fixes: 3c3ead555648 (&quo
On Thu, Jan 18, 2024 at 02:51:34AM +, Dmitry Safonov wrote:
> From: Mohammad Nassiri
>
> The end_server() function only operates in the server thread
> and always takes an accept socket instead of a listen socket as
> its input argument. To align with this, invert the boolean values
> used
On Thu, Jan 18, 2024 at 02:51:36AM +, Dmitry Safonov wrote:
> Yeah, copy'n'paste typo.
>
> Fixes: 3c3ead555648 ("selftests/net: Add TCP-AO key-management test")
> Reported-by: Nassiri, Mohammad
> Closes:
>
;)
> Signed-off-by: Jakub Kicinski
Reviewed-by: Simon Horman
On Fri, Dec 15, 2023 at 03:20:46PM +0200, Roger Quadros wrote:
> From: Grygorii Strashko
>
> This patch adds MQPRIO Qdisc offload in full 'channel' mode which allows
> not only setting up pri:tc mapping, but also configuring TX shapers
> (rate-limiting) on external port FIFOs.
>
> The MQPRIO
On Thu, Dec 07, 2023 at 04:52:46PM -0800, Mina Almasry wrote:
> Signed-off-by: Mina Almasry
> ---
> Documentation/networking/devmem.rst | 270
> 1 file changed, 270 insertions(+)
> create mode 100644 Documentation/networking/devmem.rst
>
> diff --git
On Thu, Dec 07, 2023 at 04:52:45PM -0800, Mina Almasry wrote:
> Add an interface for the user to notify the kernel that it is done
> reading the devmem dmabuf frags returned as cmsg. The kernel will
> drop the reference on the frags to make them available for re-use.
>
> Signed-off-by: Willem de
> reached and packets are dequeued.
>
> Also do not wait for timestamps to be queued unless timestamps are
> requested.
>
> Signed-off-by: Willem de Bruijn
Thanks Willem,
this looks nice and clean to me.
Reviewed-by: Simon Horman
he port changes.
>
> Signed-off-by: Ido Schimmel
> Reviewed-by: Petr Machata
> Signed-off-by: Petr Machata
Reviewed-by: Simon Horman
> ---
> .../selftests/drivers/net/mlxsw/pci_reset.sh | 58 +++
> 1 file changed, 58 insertions(+)
> create mode 100755 to
hanks Aaron,
this looks like a good incremental improvement to me.
For series,
Reviewed-by: Simon Horman
54 matches
Mail list logo
