Re: [PATCH] media: i2c: Kconfig: create dependency to MEDIA_CONTROLLER for adv7*

2014-02-06 Thread Prabhakar Lad
Hi Marcus, On Wed, Feb 5, 2014 at 9:26 PM, Marcus Folkesson marcus.folkes...@gmail.com wrote: These chips makes use of the media_entity in the v4l2_subdev struct and is therefor dependent of the MEDIA_CONTROLLER config. NAK, as you can currently see these drivers depend on

Re: [PATCH 1/2] [media] v4l2: Add settings for Horizontal and Vertical MV Search Range

2014-02-06 Thread Prabhakar Lad
On Tue, Feb 4, 2014 at 3:29 PM, Amit Grover amit.gro...@samsung.com wrote: Adding V4L2 controls for horizontal and vertical search range in pixels for motion estimation module in video encoder. Signed-off-by: Swami Nathan swaminat...@samsung.com Signed-off-by: Amit Grover

dvb-apps build failure

2014-02-06 Thread Quentin Glidic
Hello, When building dvb-apps from the Mercurial repository, you hit the following error: install: cannot stat 'atsc/*': No such file or directory In the latest changeset (http://linuxtv.org/hg/dvb-apps/rev/d40083fff895) scan files were deleted from the repository but not their install

Re: [PATCH v10 1/2] [media] exynos5-is: Adds DT binding documentation

2014-02-06 Thread Mark Rutland
On Mon, Feb 03, 2014 at 10:13:55AM +, Arun Kumar K wrote: Hi Mark, Hi Arun, This patch and hence a full series of 13 patches is waiting for a long time now due to your missing ack on this DT binding patch. I have addressed your review comments given on earlier version -

[patch] [media] stv0900: remove an unneeded check

2014-02-06 Thread Dan Carpenter
No need to check lock twice here. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git a/drivers/media/dvb-frontends/stv0900_sw.c b/drivers/media/dvb-frontends/stv0900_sw.c index 0a40edfad739..4ce1d260b3eb 100644 --- a/drivers/media/dvb-frontends/stv0900_sw.c +++

[patch] [media] stv090x: remove indent levels

2014-02-06 Thread Dan Carpenter
1) We can flip the if (!lock) check to if (lock) return lock; and then remove a big chunk of indenting. 2) There is a redundant if (!lock) which we can remove since we already know that lock is zero. This removes another indent level. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com

[PATCH] [media] stb0899: Fix DVB-S2 support for TechniSat SkyStar 2 HD CI USB ID 14f7:0002

2014-02-06 Thread David Jedelsky
My TechniSat SkyStar 2 HD CI USB ID 14f7:0002 wasn't tuning DVB-S2 channels. Investigation revealed that it doesn't read DVB-S2 registers out of stb0899. Comparison with usb trafic of the Windows driver showed the correct communication scheme. This patch implements it. The question is, whether the

Re: [RFC PATCH 0/4] rc: Adding support for sysfs wakeup scancodes

2014-02-06 Thread James Hogan
On 05/02/14 21:21, Mauro Carvalho Chehab wrote: Em Wed, 05 Feb 2014 20:16:04 +0200 Antti Seppälä a.sepp...@gmail.com escreveu: On 5 February 2014 11:42, James Hogan james.ho...@imgtec.com wrote: On 05/02/14 09:39, James Hogan wrote: Hi Antti, On 05/02/14 07:03, Antti Seppälä wrote: To

[RFCv2 PATCH 01/10] vb2: add debugging code to check for unbalanced ops.

2014-02-06 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com When a vb2_queue is freed check if all the mem_ops and queue ops were balanced. So the number of calls to e.g. buf_finish has to match the number of calls to buf_prepare, etc. This code is only enabled if CONFIG_VIDEO_ADV_DEBUG is set. Signed-off-by:

[RFCv2 PATCH 02/10] vb2: change result code of buf_finish to void.

2014-02-06 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com The buf_finish op should always work, so change the return type to void. Update the few drivers that use it. Note that buf_finish can be called both when the DMA is streaming and when it isn't (during queue_cancel). Update drivers to check that where

[RFCv2 PATCH 05/10] vb2: fix buf_init/buf_cleanup call sequences

2014-02-06 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Ensure that these ops are properly balanced. There two scenarios: 1) for MMAP buf_init is called when the buffers are created and buf_cleanup must be called when the queue is finally freed. This scenario was always working. 2) for USERPTR and

[RFCv2 PATCH 03/10] vb2: add note that buf_finish can be called with !vb2_is_streaming()

2014-02-06 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Drivers need to be aware that buf_finish can be called when there is no streaming going on, so make a note of that. Also add a bunch of missing periods at the end of sentences. Signed-off-by: Hans Verkuil hans.verk...@cisco.com ---

[RFCv2 PATCH 00/10] vb2: fixes, balancing callbacks

2014-02-06 Thread Hans Verkuil
This patch series is v2 of the previous series: http://www.spinics.net/lists/linux-media/msg72166.html Patches 1-6 are unchanged, 7-10 are new. This patch series fixes a series of bugs in vb2. Recently I have been converting the saa7134 driver to vb2 and as part of that work I discovered that

[RFCv2 PATCH 07/10] vb2: rename queued_count to owned_by_drv_count

2014-02-06 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com 'queued_count' is a bit vague since it is not clear to which queue it refers to: the vb2 internal list of buffers or the driver-owned list of buffers. Rename to make it explicit. Signed-off-by: Hans Verkuil hans.verk...@cisco.com ---

[RFCv2 PATCH 10/10] v4l2-ioctl: add CREATE_BUFS sanity checks.

2014-02-06 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Many drivers do not check anything. At least make sure that the various buffer size related fields are not obviously wrong. Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/v4l2-core/v4l2-ioctl.c | 52

[RFCv2 PATCH 06/10] vb2: fix read/write regression

2014-02-06 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Commit 88e268702bfba78448abd20a31129458707383aa (vb2: Improve file I/O emulation to handle buffers in any order) broke read/write support if the size of the buffer being read/written is less than the size of the image. When the commit was tested

[RFCv2 PATCH 04/10] vb2: call buf_finish from __dqbuf

2014-02-06 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com This ensures that it is also called from queue_cancel, which also calls __dqbuf(). Without this change any time queue_cancel is called while streaming the buf_finish op will not be called and any driver cleanup will not happen. Signed-off-by: Hans

[RFCv2 PATCH 08/10] vb2: only call start_streaming if sufficient buffers are queued

2014-02-06 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com In commit 02f142ecd24aaf891324ffba8527284c1731b561 support was added to start_streaming to return -ENOBUFS if insufficient buffers were queued for the DMA engine to start. The vb2 core would attempt calling start_streaming again if another buffer would be

[RFCv2 PATCH 09/10] vivi: correctly cleanup after a start_streaming failure.

2014-02-06 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com If start_streaming fails then any queued buffers must be given back to the vb2 core. Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/platform/vivi.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git

Re: [PATCH v2 06/15] dt: binding: add binding for ImgTec IR block

2014-02-06 Thread Mauro Carvalho Chehab
Em Fri, 17 Jan 2014 13:58:51 + James Hogan james.ho...@imgtec.com escreveu: Add device tree binding for ImgTec Consumer Infrared block, specifically major revision 1 of the hardware. @DT maintainers: ping. Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Mauro Carvalho Chehab

Re: Support for Empia 2980 video/audio capture chip set

2014-02-06 Thread Keith Lawson
On Mon, Jan 20, 2014 at 09:08:25PM +0100, Frank Schäfer wrote: On 17.01.2014 01:11, Keith Lawson wrote: On Wed, Jan 15, 2014 at 10:37:44PM +0100, Frank Schäfer wrote: Am 14.01.2014 01:48, schrieb Keith Lawson: On 2014-01-12 11:56, Frank Schäfer wrote: On 09.01.2014 02:02, Keith Lawson

Re: [PATCH 43/47] adv7604: Control hot-plug detect through a GPIO

2014-02-06 Thread Lars-Peter Clausen
On 02/05/2014 05:42 PM, Laurent Pinchart wrote: Replace the ADV7604-specific hotplug notifier with a GPIO to control the HPD pin directly instead of going through the bridge driver. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com This should probably use the new GPIO

[PATCH 1/2] [media] DocBook/media_api: Better organize the DocBook

2014-02-06 Thread Mauro Carvalho Chehab
All chapters/parts but Remote controllers have the revision tags inside the body. Move those to remote_controllers.xml and do some cleanup. No functional changes. Signed-off-by: Mauro Carvalho Chehab m.che...@samsung.com --- .../DocBook/media/v4l/remote_controllers.xml | 31 +

[PATCH 2/2] [media] DocBook: Add a description for the Remote Controller interface

2014-02-06 Thread Mauro Carvalho Chehab
Adds a missing section to describe the remote controller interface. The DocBook is just addin the same documentation as written at Documentation/ABI/testing/sysfs-class-rc, using the DocBook's way, and dropping timestamps/contact info. While that means that we'll have the same info on two parts,

Re: [PATCH v2 06/15] dt: binding: add binding for ImgTec IR block

2014-02-06 Thread Rob Herring
On Fri, Jan 17, 2014 at 7:58 AM, James Hogan james.ho...@imgtec.com wrote: Add device tree binding for ImgTec Consumer Infrared block, specifically major revision 1 of the hardware. Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Mauro Carvalho Chehab m.che...@samsung.com Cc:

Re: [PATCH v2 06/15] dt: binding: add binding for ImgTec IR block

2014-02-06 Thread James Hogan
Hi Rob, On 06/02/14 14:33, Rob Herring wrote: On Fri, Jan 17, 2014 at 7:58 AM, James Hogan james.ho...@imgtec.com wrote: +Required properties: +- compatible: Should be img,ir1 Kind of short for a name. I don't have anything much better, but how about img,ir-rev1. Okay, that

Re: [RFC PATCH 0/4] rc: Adding support for sysfs wakeup scancodes

2014-02-06 Thread Mauro Carvalho Chehab
Em Thu, 06 Feb 2014 10:46:04 + James Hogan james.ho...@imgtec.com escreveu: On 05/02/14 21:21, Mauro Carvalho Chehab wrote: Em Wed, 05 Feb 2014 20:16:04 +0200 Antti Seppälä a.sepp...@gmail.com escreveu: On 5 February 2014 11:42, James Hogan james.ho...@imgtec.com wrote: On

Re: [PATCH] [media] uvcvideo: Enable VIDIOC_CREATE_BUFS

2014-02-06 Thread Laurent Pinchart
Hi Hans, On Wednesday 05 February 2014 08:57:14 Hans Verkuil wrote: On 02/05/2014 12:04 AM, Sylwester Nawrocki wrote: On 02/03/2014 10:03 AM, Hans Verkuil wrote: On 02/02/2014 02:04 PM, Philipp Zabel wrote: On Sun, Feb 02, 2014 at 11:21:13AM +0100, Laurent Pinchart wrote: On Friday 31

Re: [PATCH 06/47] v4l: Add pad-level DV timings subdev operations

2014-02-06 Thread Sakari Ailus
Hi Laurent, On Wed, Feb 05, 2014 at 05:41:57PM +0100, Laurent Pinchart wrote: Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- include/media/v4l2-subdev.h| 4 include/uapi/linux/videodev2.h | 8 ++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff

Re: [PATCH 26/47] v4l: Improve readability by not wrapping ioctl number #define's

2014-02-06 Thread Sakari Ailus
On Wed, Feb 05, 2014 at 05:42:17PM +0100, Laurent Pinchart wrote: Wrapping the #define's at a 80 columns boundary just obfuscates the code. Don't do that. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Acked-by: Sakari Ailus sakari.ai...@linux.intel.com -- Sakari Ailus

Re: [PATCH 25/47] v4l: subdev: Remove deprecated video-level DV timings operations

2014-02-06 Thread Sakari Ailus
On Wed, Feb 05, 2014 at 05:42:16PM +0100, Laurent Pinchart wrote: The video enum_dv_timings and dv_timings_cap operations are deprecated and unused. Remove them. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Acked-by: Sakari Ailus sakari.ai...@linux.intel.com -- Sakari

[PATCH] v4l: vsp1: Update copyright notice

2014-02-06 Thread Laurent Pinchart
The Renesas Corporation listed in the copyright notice doesn't exist. Replace it with Renesas Electronics Corporation and update the copyright years. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/media/platform/vsp1/vsp1.h| 2 +-

Re: au0828 errors and mangled video with Hauppauge 950Q

2014-02-06 Thread Connor Behan
On 05/02/14 01:46 AM, Devin Heitmueller wrote: On Wed, Feb 5, 2014 at 1:05 AM, Connor Behan connor.be...@gmail.com wrote: Ccing Devin. I'm pretty sure the analog side has a problem at the driver level. On most days, one cannot pickup an ATSC signal where I am, so I am trying to capture

[RFC 1/4] rc: ir-raw: add scancode encoder callback

2014-02-06 Thread James Hogan
Add a callback to raw ir handlers for encoding and modulating a scancode to a set of raw events. This could be used for transmit, or for converting a wakeup scancode filter to a form that is more suitable for raw hardware wake up filters. Signed-off-by: James Hogan james.ho...@imgtec.com ---

[RFC 3/4] rc: ir-nec-decoder: add encode capability

2014-02-06 Thread James Hogan
Add the capability to encode NEC scancodes as raw events. The scancode_to_raw is pretty much taken from the img-ir NEC filter() callback, and modulation uses the pulse distance helper added in a previous commit. Signed-off-by: James Hogan james.ho...@imgtec.com ---

[RFC 2/4] rc: ir-raw: add modulation helpers

2014-02-06 Thread James Hogan
Add IR encoding helpers, particularly for pulse-distance modulation as used by the NEC protocol. Signed-off-by: James Hogan james.ho...@imgtec.com --- drivers/media/rc/ir-raw.c | 33 +++ drivers/media/rc/rc-core-priv.h | 44

[RFC 0/4] rc: ir-raw: Add encode, implement NEC encode

2014-02-06 Thread James Hogan
A recent discussion about proposed interfaces for setting up the hardware wakeup filter lead to the conclusion that it could help to have the generic capability to encode and modulate scancodes into raw IR events so that drivers for hardware with a low level wake filter (on the level of

[RFC 4/4] DEBUG: rc: img-ir: raw: Add loopback on s_filter

2014-02-06 Thread James Hogan
Purely for the purposes of debugging the raw IR encode, add the s_filter callback to the img-ir-raw driver, which instead of setting the filter just feeds it back through the input device so that it can be verified. --- drivers/media/rc/img-ir/img-ir-raw.c | 30 ++ 1

Re: [PATCH] [media] stb0899: Fix DVB-S2 support for TechniSat SkyStar 2 HD CI USB ID 14f7:0002

2014-02-06 Thread Antti Palosaari
Moi David On 06.02.2014 11:45, David Jedelsky wrote: My TechniSat SkyStar 2 HD CI USB ID 14f7:0002 wasn't tuning DVB-S2 channels. Investigation revealed that it doesn't read DVB-S2 registers out of stb0899. Comparison with usb trafic of the Windows driver showed the correct communication

Re: [PATCH 06/47] v4l: Add pad-level DV timings subdev operations

2014-02-06 Thread Laurent Pinchart
Hi Sakari, Thank you for the review. On Thursday 06 February 2014 19:33:23 Sakari Ailus wrote: Hi Laurent, On Wed, Feb 05, 2014 at 05:41:57PM +0100, Laurent Pinchart wrote: Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- include/media/v4l2-subdev.h| 4

Re: [PATCH 27/47] v4l: Add support for DV timings ioctls on subdev nodes

2014-02-06 Thread Laurent Pinchart
Hi Hans, Thank you for the comments. On Wednesday 05 February 2014 18:31:14 Hans Verkuil wrote: On 02/05/2014 05:42 PM, Laurent Pinchart wrote: Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- .../DocBook/media/v4l/vidioc-dv-timings-cap.xml| 27

cron job: media_tree daily build: ERRORS

2014-02-06 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Fri Feb 7 04:00:25 CET 2014 git branch: test git hash: 261cb200e7227820cd0056435d7c1a3a9c476766 gcc

Re: [PATCH] [media] stb0899: Fix DVB-S2 support for TechniSat SkyStar 2 HD CI USB ID 14f7:0002

2014-02-06 Thread Manu Abraham
Hi David, On Thu, Feb 6, 2014 at 3:15 PM, David Jedelsky david.jedel...@gmail.com wrote: My TechniSat SkyStar 2 HD CI USB ID 14f7:0002 wasn't tuning DVB-S2 channels. Investigation revealed that it doesn't read DVB-S2 registers out of stb0899. Comparison with usb trafic of the Windows driver

[PATCH 2/3] e4000: implement PLL lock v4l control

2014-02-06 Thread Antti Palosaari
Implement PLL lock control to get PLL lock flag status from tuner synthesizer. Cc: Mauro Carvalho Chehab m.che...@samsung.com Cc: Hans Verkuil hverk...@xs4all.nl Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/tuners/e4000.c | 53 ++-

[PATCH 3/3] DocBook: media: document PLL lock control

2014-02-06 Thread Antti Palosaari
Document PLL lock V4L2 control. It is read only RF tuner control which is used to inform if tuner is receiving frequency or not. Cc: Mauro Carvalho Chehab m.che...@samsung.com Cc: Hans Verkuil hverk...@xs4all.nl Signed-off-by: Antti Palosaari cr...@iki.fi ---

[PATCH 1/3] v4l: add control for RF tuner PLL lock flag

2014-02-06 Thread Antti Palosaari
Add volatile boolean control to indicate if tuner frequency synthesizer is locked to requested frequency. That means tuner is able to receive given frequency. Control is named as PLL lock, since frequency synthesizers are based of phase-locked-loop. Maybe more general name could be wise still?