Re: [PATCH v2 5/5] media: atmel-isc: Rework the format list

On 2017/9/27 16:03, Hans Verkuil wrote: On 09/27/2017 07:15 AM, Yang, Wenyou wrote: Hi Hans, Thank  you very much for your review. On 2017/9/25 21:24, Hans Verkuil wrote: Hi Wenyou, On 18/09/17 08:39, Wenyou Yang wrote: To improve the readability of code, split the format array into two,

cron job: media_tree daily build: ERRORS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Thu Sep 28 05:00:15 CEST 2017 media-tree git hash:d5426f4c2ebac8cf05de43988c3fccddbee13d28 media_build

Re: [PATCH v2 07/13] docs: kernel-doc.rst: add documentation about man pages

Em Wed, 27 Sep 2017 14:20:03 -0700 Randy Dunlap escreveu: > On 09/27/17 14:10, Mauro Carvalho Chehab wrote: > > kernel-doc-nano-HOWTO.txt has a chapter about man pages > > kernel-doc.rst has a chapter (or section) I actually meant to say that

Re: [PATCH v7 4/7] media: open.rst: document devnode-centric and mc-centric types

Hi Randy, Em Wed, 27 Sep 2017 15:32:12 -0700 Randy Dunlap escreveu: > > +Types of V4L2 media hardware control > > + > > + > > +V4L2 hardware periferal is usually complex: support for it is > > peripheral (in several

HYVÄÄ PÄIVÄÄ!

Hyvää päivää! Olen varma, että tämä posti olisi tulossa teille yllätyksenä, koska emme ole koskaan ennen tavannut, ja voit myös kysyä, miksi olen päättänyt valitsi sinulle joukossa lukuisia internetin käyttäjiä maailmassa. Sain sähköpostiosoitteesi läpi profiilin Internetissä, joka on tehnyt

Re: [PATCH v7 4/7] media: open.rst: document devnode-centric and mc-centric types

On 09/27/17 15:23, Mauro Carvalho Chehab wrote: > > Signed-off-by: Mauro Carvalho Chehab > --- > Documentation/media/uapi/v4l/open.rst | 40 > +++ > 1 file changed, 40 insertions(+) > > diff --git

[PATCH v7 4/7] media: open.rst: document devnode-centric and mc-centric types

When we added support for omap3, back in 2010, we added a new type of V4L2 devices that aren't fully controlled via the V4L2 device node. Yet, we have never clearly documented in the V4L2 specification the differences between the two types. Let's document them based on the the current

[PATCH v7 1/7] media: add glossary.rst with a glossary of terms used at V4L2 spec

Add a glossary of terms for V4L2, as several concepts are complex enough to cause misunderstandings. Signed-off-by: Mauro Carvalho Chehab --- Documentation/media/uapi/v4l/glossary.rst | 136 ++ Documentation/media/uapi/v4l/v4l2.rst | 1

[PATCH v7 6/7] media: videodev2: add a flag for MC-centric devices

As both vdev-centric and MC-centric devices may implement the same APIs, we need a flag to allow userspace to distinguish between them. Signed-off-by: Mauro Carvalho Chehab --- Documentation/media/uapi/v4l/open.rst| 7 +++

[PATCH v7 2/7] media: open.rst: better document device node naming

Right now, only kAPI documentation describes the device naming. However, such description is needed at the uAPI too. Add it, and describe how to get an unique identify for a given device. Acked-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab

[PATCH v7 0/7] document types of hardware control for V4L2

On Kernel 2.6.39, the omap3 driver was introduced together with a new way to control complex V4L2 devices used on embedded systems, but this was never documented, as the original idea were to have "soon" support for standard apps to use it as well, via libv4l, but that didn't happen so far. Also,

[PATCH v7 3/7] media: open.rst: remove the minor number range

minor numbers use to range between 0 to 255, but that was changed a long time ago. While it still applies when CONFIG_VIDEO_FIXED_MINOR_RANGES, when the minor number is dynamically allocated, this may not be true. In any case, this is not relevant, as udev will take care of it. So, remove this

[PATCH v7 5/7] media: open.rst: Adjust some terms to match the glossary

As we now have a glossary, some terms used on open.rst require adjustments. Acked-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab --- Documentation/media/uapi/v4l/open.rst | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-)

[PATCH v7 7/7] media: open.rst: add a notice about subdev-API on vdev-centric

The documentation doesn't mention if vdev-centric hardware control would have subdev API or not. Add a notice about that, reflecting the current status, where three drivers use it, in order to support some subdev-specific controls. Signed-off-by: Mauro Carvalho Chehab

Re: [PATCH v6 1/7] media: add glossary.rst with a glossary of terms used at V4L2 spec

Em Fri, 1 Sep 2017 12:26:39 +0200 Hans Verkuil escreveu: > On 29/08/17 15:17, Mauro Carvalho Chehab wrote: > > Add a glossary of terms for V4L2, as several concepts are complex > > enough to cause misunderstandings. > > > > Signed-off-by: Mauro Carvalho Chehab

Re: [RESEND RFC PATCH 4/7] dt-bindings: Document Allwinner DWC HDMI TX node

On Wed, Sep 20, 2017 at 10:01:21PM +0200, Jernej Skrabec wrote: > Add documentation about Allwinner DWC HDMI TX node, found in H3 SoC. > > Signed-off-by: Jernej Skrabec > --- > .../bindings/display/sunxi/sun4i-drm.txt | 158 > - > 1 file

Re: [PATCH v3 2/4] [media] dt-bindings: Document BCM283x CSI2/CCP2 receiver

On Fri, Sep 22, 2017 at 05:07:22PM +0100, Dave Stevenson wrote: > Hi Stefan > > On 22 September 2017 at 07:45, Stefan Wahren wrote: > > Hi Dave, > > > >> Dave Stevenson hat am 20. September 2017 > >> um 18:07 geschrieben: > >> > >> > >>

[PATCH v2 09/17] media: cec-pin.h: convert comments for cec_pin_state into kernel-doc

This enum is already documented, but it is not using a kernel-doc format. Convert its format, in order to produce documentation. Signed-off-by: Mauro Carvalho Chehab --- include/media/cec-pin.h | 81 +++-- 1 file changed, 52

[PATCH v2 16/17] media: videobuf2-core: improve kernel-doc markups

Now that nested structs are supported, change the documentation to use it. While here, add cross-references where pertinent and use monotonic fonts where pertinent, using the right markup tags. Signed-off-by: Mauro Carvalho Chehab --- include/media/videobuf2-core.h |

[PATCH v2 06/17] media: v4l2-dv-timings.h: convert comment into kernel-doc markup

The can_reduce_fps() is already documented, but it is not using the kernel-doc markup. Convert it, in order to generate documentation from it. Signed-off-by: Mauro Carvalho Chehab --- include/media/v4l2-dv-timings.h | 14 -- 1 file changed, 8 insertions(+),

[PATCH v2 07/17] media: v4l2-event.rst: improve events description

Both v4l2-event.rst and v4l2-event.h have an overview of events, but there are some inconsistencies there: - at v4l2-event, the event's ringbuffer is called kevent. Its name is, instead, v4l2_kevent; - Some things are mentioned on both places (with different words), others are either on one

[PATCH v2 11/17] media: rc-core.h: minor adjustments at rc_driver_type doc

The description of this enum doesn't match what it actually represents. Adjust it. Signed-off-by: Mauro Carvalho Chehab --- include/media/rc-core.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/media/rc-core.h b/include/media/rc-core.h

[PATCH v2 02/17] media: v4l2-common: get rid of v4l2_routing dead struct

This struct is not used anymore. Get rid of it and update the documentation about what should still be converted. Signed-off-by: Mauro Carvalho Chehab --- include/media/v4l2-common.h | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git

[PATCH v2 12/17] media: v4l2-fwnode.h: better describe bus union at fwnode endpoint struct

Now that kernel-doc handles nested unions, better document the bus union at struct v4l2_fwnode_endpoint. Signed-off-by: Mauro Carvalho Chehab --- include/media/v4l2-fwnode.h | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git

[PATCH v2 15/17] media: v4l2-ctrls: document nested members of structs

There are a few nested members at v4l2-ctrls.h. Now that kernel-doc supports, document them. Signed-off-by: Mauro Carvalho Chehab --- include/media/v4l2-ctrls.h | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/include/media/v4l2-ctrls.h

[PATCH v2 10/17] media: rc-core.rst: add an introduction for RC core

The RC core does several assumptions, but those aren't documented anywhere, with could make harder for ones that want to understand what's there. So, add an introduction explaining the basic concepts of RC and how they're related to the RC core implementation. Signed-off-by: Mauro Carvalho

[PATCH v2 14/17] media: v4l2-async: better describe match union at async match struct

Now that kernel-doc handles nested unions, better document the match union at struct v4l2_async_subdev. Signed-off-by: Mauro Carvalho Chehab --- include/media/v4l2-async.h | 35 --- 1 file changed, 32 insertions(+), 3 deletions(-) diff

[PATCH v2 17/17] media: media-entity.h: add kernel-doc markups for nested structs

Now that nested structs are parsed by kernel-doc, add markups to them. Signed-off-by: Mauro Carvalho Chehab --- include/media/media-entity.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/media/media-entity.h b/include/media/media-entity.h index

[PATCH v2 08/17] media: v4l2-ioctl.h: convert debug macros into enum and document

Currently, there's no way to document #define foo with kernel-doc. So, convert it to an enum, and document. Signed-off-by: Mauro Carvalho Chehab --- include/media/v4l2-ioctl.h | 33 +++-- 1 file changed, 19 insertions(+), 14 deletions(-)

[PATCH v2 04/17] media: v4l2-common.h: document ancillary functions

There are several ancillary functions that aren't documented. Document them. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/v4l2-core/v4l2-common.c | 14 - include/media/v4l2-common.h | 104 ++ 2 files changed, 94

[PATCH v2 05/17] media: v4l2-device.h: document ancillary macros

There are several widely macros that aren't documented using kernel-docs markups. Add it. Signed-off-by: Mauro Carvalho Chehab --- include/media/v4l2-device.h | 238 +--- 1 file changed, 204 insertions(+), 34 deletions(-) diff

[PATCH v2 01/17] media: tuner-types: add kernel-doc markups for struct tunertype

This struct is lacking documentation. Add it. Signed-off-by: Mauro Carvalho Chehab --- include/media/tuner-types.h | 15 +++ 1 file changed, 15 insertions(+) diff --git a/include/media/tuner-types.h b/include/media/tuner-types.h index

[PATCH v2 03/17] media: v4l2-common: get rid of struct v4l2_discrete_probe

This struct is there just two store two arguments of v4l2_find_nearest_format(). The other two arguments are passed as parameter. IMHO, there isn't much sense on doing that, and that will just add one more struct to document ;) So, let's get rid of the struct, passing the parameters directly.

[PATCH v2 00/17] V4L cleanups and documentation improvements

This patch series is meant to improve V4L documentation. It touches some files at the tree doing some cleanup, in order to simplify the source code. Mauro Carvalho Chehab (17): media: tuner-types: add kernel-doc markups for struct tunertype media: v4l2-common: get rid of v4l2_routing dead

[PATCH v2 13/37] media: dvbdev: convert DVB device types into an enum

Enums can be documented via kernel-doc. So, convert the DVB_DEVICE_* macros to an enum. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-core/dvbdev.c | 34 +++ drivers/media/dvb-core/dvbdev.h | 51

[PATCH v2 22/37] media: dvb_demux: mark a boolean field as such

The struct dvb_demux_filter.doneq is a boolean. Mark it as such, as it helps to understand what it does. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-core/dvb_demux.c | 4 ++-- drivers/media/dvb-core/dvb_demux.h | 2 +- 2 files changed, 3 insertions(+),

[PATCH v2 23/37] media: dvb_demux: dvb_demux_feed.pusi_seen is boolean

Instead of using an integer to represent it, use boolean, as this better describes what this field really means. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-core/dvb_demux.c| 12 ++-- drivers/media/dvb-core/dvb_demux.h| 2 +-

[PATCH v2 27/37] media: dvb_frontend: dtv_property_process_set() cleanups

From: Satendra Singh Thakur Since all properties in the func dtv_property_process_set() use at most 4 bytes arguments, change the code to pass u32 cmd and u32 data as function arguments, instead of passing a pointer to the entire struct dtv_property *tvp. Instead of

[PATCH v2 08/37] media: dvb_frontend: cleanup ioctl handling logic

Currently, there are two handlers for ioctls: - dvb_frontend_ioctl_properties() - dvb_frontend_ioctl_legacy() Despite their names, both handles non-legacy DVB ioctls. Besides that, there's no reason why to not handle all ioctls on a single handler function. So, merge them into a single

[PATCH v2 01/37] media: dvb_frontend: only use kref after initialized

As reported by Laurent, when a DVB frontend need to register two drivers (e. g. a tuner and a demod), if the second driver fails to register (for example because it was not compiled), the error handling logic frees the frontend by calling dvb_frontend_detach(). That used to work fine, but

[PATCH v2 09/37] media: dvb_frontend: get rid of property cache's state

In the past, I guess the idea was to use state in order to allow an autofush logic. However, in the current code, it is used only for debug messages, on a poor man's solution, as there's already a debug message to indicate when the properties got flushed. So, just get rid of it for good.

[PATCH v2 14/37] media: dvbdev: fully document its functions

There are several functions at the dvbdev that are common to all digital TV device nodes with aren't documented. Add documentation for them. No functional changes. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-core/dvbdev.h | 86

[PATCH v2 18/37] media: dtv-demux.rst: minor markup improvements

Add a cross-reference to a mentioned structure and split the kernel-doc stuff on a separate chapter. Signed-off-by: Mauro Carvalho Chehab --- Documentation/media/kapi/dtv-demux.rst | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git

[PATCH v2 07/37] media: dvb_frontend: cleanup dvb_frontend_ioctl_properties()

Use a switch() on this function, just like on other ioctl handlers and handle parameters inside each part of the switch. That makes it easier to integrate with the already existing ioctl handler function. Signed-off-by: Mauro Carvalho Chehab ---

[PATCH v2 05/37] media: dvb_frontend: get rid of get_property() callback

Only lg2160 implement gets_property, but there's no need for that, as no other driver calls this callback, as get_frontend() does the same, and set_frontend() also calls lg2160 get_frontend(). So, get rid of it. Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Michael

[PATCH v2 15/37] media: dvb_frontend.h: improve kernel-doc markups

Several minor adjustments at the kernel-doc markups: - some syntax fixes; - some cross-references; - add cross-references for the mentioned ioctls; - some constants marked as such. No functional changes. Signed-off-by: Mauro Carvalho Chehab ---

[PATCH v2 03/37] media: stv6110: get rid of a srate dead code

The stv6110 has a weird code that checks if get_property and set_property ioctls are defined. If they're, it initializes a "srate" var from properties cache. Otherwise, it sets to 15MBaud, with won't make any sense. Thankfully, it seems that someone else discovered the issue in the past, as

[PATCH v2 12/37] media: dvb_frontend: fix return values for FE_SET_PROPERTY

There are several problems with regards to the return of FE_SET_PROPERTY. The original idea were to return per-property return codes via tvp->result field, and to return an updated set of values. However, that never worked. What's actually implemented is: - the FE_SET_PROPERTY implementation

[PATCH v2 26/37] media: dvb_demux: document dvb_demux_filter and dvb_demux_feed

Document those two structs using kernel-doc markups. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-core/dvb_demux.h | 49 -- 1 file changed, 47 insertions(+), 2 deletions(-) diff --git

[PATCH v2 21/37] media: dvb_demux.h: get rid of unused timer at struct dvb_demux_filter

This field is not used. So, get rid of it. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-core/dvb_demux.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/dvb-core/dvb_demux.h b/drivers/media/dvb-core/dvb_demux.h index

[PATCH v2 31/37] media: dmxdev.h: add kernel-doc markups for data types and functions

Despite being used by DVB drivers, this header was not documented. Document it. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-core/dmxdev.h | 90 - 1 file changed, 88 insertions(+), 2 deletions(-) diff --git

[PATCH v2 06/37] media: dvb_frontend: get rid of set_property() callback

Now that all clients of set_property() were removed, get rid of this callback. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-core/dvb_frontend.c | 7 --- drivers/media/dvb-core/dvb_frontend.h | 5 - 2 files changed, 12 deletions(-) diff --git

[PATCH v2 28/37] media: dvb_frontend: get rid of dtv_get_property_dump()

Simplify the get property handling and move it to the existing code at dtv_property_process_get() directly. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-core/dvb_frontend.c | 43 ++- 1 file changed, 12 insertions(+), 31

[PATCH v2 20/37] media: dvb_demux.h: add an enum for DMX_STATE_* and document

kernel-doc allows documenting enums. Also, it makes clearer about the meaning of each field on structures. So, convert DMX_STATE_* to an enum. While here, get rid of the unused DMX_STATE_SET. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-core/dvb_demux.h

[PATCH v2 04/37] media: friio-fe: get rid of set_property()

This callback is not actually doing anything but making it to return an error depending on the DTV frontend command. Well, that could break userspace for no good reason, and, if needed, should be implemented, instead, at set_frontend() callback. So, get rid of it. Signed-off-by: Mauro Carvalho

[PATCH v2 24/37] media: dvb_demux.h: get rid of DMX_FEED_ENTRY() macro

This isn't used anywere. Get rid of it. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-core/dvb_demux.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/dvb-core/dvb_demux.h b/drivers/media/dvb-core/dvb_demux.h index

[PATCH v2 19/37] media: dvb_demux.h: add an enum for DMX_TYPE_* and document

kernel-doc allows documenting enums. Also, it makes clearer about the meaning of each field on structures. So, convert DMX_TYPE_* to an enum. While here, get rid of the unused DMX_TYPE_PES. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-core/dvb_demux.h |

[PATCH v2 32/37] media: dtv-demux.rst: parse other demux headers with kernel-doc

Now that we have kernel-doc markups at dvb_demux.h and dmxdev.h, parse them. Signed-off-by: Mauro Carvalho Chehab --- Documentation/media/kapi/dtv-demux.rst | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git

[PATCH v2 11/37] media: dvb_frontend: better document the -EPERM condition

Two readonly ioctls can't be allowed if the frontend device is opened in read only mode. Explain why. Reviewed by: Shuah Khan Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-core/dvb_frontend.c | 20 +--- 1 file

[PATCH v2 33/37] media: dvb-net.rst: document DVB network kAPI interface

That's the last DVB kAPI that misses documentation. Signed-off-by: Mauro Carvalho Chehab --- Documentation/media/kapi/dtv-core.rst | 1 + Documentation/media/kapi/dtv-net.rst | 4 Documentation/media/uapi/dvb/net-types.rst | 2 +-

[PATCH v2 02/37] media: stv0288: get rid of set_property boilerplate

This driver doesn't implement support for set_property(). Yet, it implements a boilerplate for it. Get rid of it. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/stv0288.c | 7 --- 1 file changed, 7 deletions(-) diff --git

[PATCH v2 36/37] media: dvb_demux: use the newly nested kernel-doc support

Now that kernel-doc supports nested structs/unions, use it. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-core/dvb_demux.h | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/drivers/media/dvb-core/dvb_demux.h

[PATCH v2 00/37] DVB cleanups and documentation improvements

This patch series merges a 6 patches series I sent earlier, and a 25 patch series. It comes after the patch series with add support for nexted structs/enums on kernel-doc. I"m pushing it on my experimental tree: https://git.linuxtv.org/mchehab/experimental.git/log/?h=dvb-fixes-v5 It is

[PATCH v2 37/37] media: frontend: use the newly nested kernel-doc support

Now that kernel-doc supports nested structs/unions, use it. Signed-off-by: Mauro Carvalho Chehab --- include/uapi/linux/dvb/frontend.h | 35 +-- 1 file changed, 17 insertions(+), 18 deletions(-) diff --git

[PATCH v2 10/37] media: dvb_frontend.h: fix alignment at the cache properties

There are too much tabs on several properties, for no good reason. That sounds confusing while reading the struct, so adjust them. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-core/dvb_frontend.h | 10 +- 1 file changed, 5 insertions(+), 5

[PATCH v2 35/37] media: dmxdev: use the newly nested kernel-doc support

Now that kernel-doc supports nested structs/unions, use it. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-core/dmxdev.h | 31 ++- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git a/drivers/media/dvb-core/dmxdev.h

[PATCH v2 16/37] media: dtv-core.rst: add chapters and introductory tests for common parts

Better document the DVB common parts by adding two sections and an introductory text for each. Signed-off-by: Mauro Carvalho Chehab --- Documentation/media/kapi/dtv-core.rst | 12 1 file changed, 12 insertions(+) diff --git

[PATCH v2 29/37] media: dvb_demux.h: document structs defined on it

There are three structs defined inside dvb_demux.h. None of them are currently documented. Add documentation for them. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-core/dvb_demux.c | 1 + drivers/media/dvb-core/dvb_demux.h | 58

[PATCH v2 25/37] media: dvb_demux: fix type of dvb_demux_feed.ts_type

Just like pes_type, this field represents an enum. Properly identify it as such. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-core/dvb_demux.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/dvb-core/dvb_demux.h

[PATCH v2 34/37] media: dvb uAPI docs: get rid of examples section

That section is too outdated and got superseded by DVBv5 and by libdvbv5. Maybe some day we'll end adding updated examples there, but while nobody has time or interest of doing that, just mention that there and get rid of the current examples for good. Signed-off-by: Mauro Carvalho Chehab

[PATCH v2 30/37] media: dvb_demux.h: document functions

The functions used on dvb_demux.h are largely used on DVB drivers. Yet, none of them are documented. No functional changes. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-core/dvb_demux.h | 106 +++-- 1 file changed, 103

[PATCH v2 17/37] media: dtv-core.rst: split into multiple files

Instead of document all kAPI into a single file, split it on multiple ones. That makes easier to maintain each part. As a side effect, it will produce multiple html pages, with is a good idea. No changes at the text. Just some chapter levels changed. Signed-off-by: Mauro Carvalho Chehab

Re: [PATCH v6 2/2] media:imx274 V4l2 driver for Sony imx274 CMOS sensor

Hi Leon, Thanks for the update. A couple of more comments below; I think we're soon done here. On Sun, Sep 24, 2017 at 12:53:29AM -0700, Leon Luo wrote: > The imx274 is a Sony CMOS image sensor that has 1/2.5 image size. > It supports up to 3840x2160 (4K) 60fps, 1080p 120fps. The interface > is

Re: [PATCH v2 07/13] docs: kernel-doc.rst: add documentation about man pages

On 09/27/17 14:10, Mauro Carvalho Chehab wrote: > kernel-doc-nano-HOWTO.txt has a chapter about man pages kernel-doc.rst has a chapter (or section) > production. While we don't have a working "make manpages" > target, add it. > > Signed-off-by: Mauro Carvalho Chehab

[PATCH v2 00/13] kernel-doc: add supported to document nested structs/$

Right now, it is not possible to document nested struct and nested unions. kernel-doc simply ignore them. Add support to document them. Patch 1 gets rid of the now unused output formats for kernel-doc: since we got rid of all DocBook stuff, we should not need them anymore. The reason for

[PATCH v2 05/13] docs: kernel-doc.rst: improve structs chapter

There is a mess on this chapter: it suggests that even enums and unions should be documented with "struct". That's not the way it should be ;-) Fix it and move it to happen earlier. Signed-off-by: Mauro Carvalho Chehab --- Documentation/doc-guide/kernel-doc.rst | 48

[PATCH v2 04/13] docs: kernel-doc.rst: improve function documentation section

Move its contents to happen earlier and improve the description of return values, adding a subsection to it. Most of the contents there came from kernel-doc-nano-HOWTO.txt. Signed-off-by: Mauro Carvalho Chehab --- Documentation/doc-guide/kernel-doc.rst | 100

[PATCH v2 08/13] docs: get rid of kernel-doc-nano-HOWTO.txt

Everything there is already described at Documentation/doc-guide/kernel-doc.rst. So, there's no reason why to keep it anymore. Signed-off-by: Mauro Carvalho Chehab --- Documentation/00-INDEX | 2 - Documentation/kernel-doc-nano-HOWTO.txt | 322

[PATCH v2 03/13] docs: kernel-doc.rst: improve private members description

The private members section can now be moved to be together with the arguments section. Move it there and add an example about the usage of public: Signed-off-by: Mauro Carvalho Chehab --- Documentation/doc-guide/kernel-doc.rst | 56 ++

[PATCH v2 11/13] scripts: kernel-doc: print the declaration name on warnings

The logic at create_parameterlist()'s ancillary push_parameter() function has already a way to output the declaration name, with would help to discover what declaration is missing. However, currently, the logic is utterly broken, as it uses the var $type with a wrong meaning. With the current

[PATCH v2 13/13] [RFC] w1_netlink.h: add support for nested structs

Describe nested struct/union fields NOTE: This is a pure test patch, meant to validate if the parsing logic for nested structs is working properly. I've no idea if the random text I added there is correct! Signed-off-by: Mauro Carvalho Chehab ---

[PATCH v2 09/13] scripts: kernel-doc: parse next structs/unions

There are several places within the Kernel tree with nested structs/unions, like this one: struct ingenic_cgu_clk_info { const char *name; enum { CGU_CLK_NONE = 0, CGU_CLK_EXT = BIT(0), CGU_CLK_PLL = BIT(1), CGU_CLK_GATE = BIT(2), CGU_CLK_MUX = BIT(3),

[PATCH v2 02/13] docs: kernel-doc.rst: better describe kernel-doc arguments

Add a new section to describe kernel-doc arguments, adding examples about how identation should happen, as failing to do that causes Sphinx to do the wrong thing. Signed-off-by: Mauro Carvalho Chehab --- Documentation/doc-guide/kernel-doc.rst | 44

[PATCH v2 12/13] scripts: kernel-doc: handle nested struct function arguments

Function arguments are different than usual ones. So, an special logic is needed in order to handle such arguments on nested structs. Signed-off-by: Mauro Carvalho Chehab --- scripts/kernel-doc | 38 ++ 1 file changed, 26

[PATCH v2 10/13] scripts: kernel-doc: get rid of $nested parameter

The check_sections() function has a $nested parameter, meant to identify when a nested struct is present. As we now have a logic that handles it, get rid of such parameter. Suggested-by: Markus Heiser Signed-off-by: Mauro Carvalho Chehab ---

[PATCH v2 01/13] scripts: kernel-doc: get rid of unused output formats

Since there isn't any docbook code anymore upstream, we can get rid of several output formats: - docbook/xml, html, html5 and list formats were used by the old build system; - As ReST is text, there's not much sense on outputting on a different text format. After this patch, only man and rst

[PATCH v2 07/13] docs: kernel-doc.rst: add documentation about man pages

kernel-doc-nano-HOWTO.txt has a chapter about man pages production. While we don't have a working "make manpages" target, add it. Signed-off-by: Mauro Carvalho Chehab --- Documentation/doc-guide/kernel-doc.rst | 34 ++ 1 file changed,

[PATCH v2 06/13] docs: kernel-doc.rst: improve typedef documentation

Add documentation about typedefs for function prototypes and move it to happen earlier. Signed-off-by: Mauro Carvalho Chehab --- Documentation/doc-guide/kernel-doc.rst | 32 ++-- 1 file changed, 22 insertions(+), 10 deletions(-) diff --git

Re: [PATCH 01/10] scripts: kernel-doc: get rid of unused output formats

Em Wed, 27 Sep 2017 17:36:59 +0300 Jani Nikula escreveu: > On Tue, 26 Sep 2017, Mauro Carvalho Chehab wrote: > > Since there isn't any docbook code anymore upstream, > > we can get rid of several output formats: > > > > - docbook/xml, html,

Re: [media] vimc: API proposal, configuring the topology from user space

Hi Hans, Thanks for your review. On 2017-07-28 10:39 AM, Hans Verkuil wrote: > Hi Helen, > > Finally after way too long I found some time to review this. See my comments > below. > > On 04/11/2017 12:53 AM, Helen Koike wrote: >> >> Hi, >> >> Continuing the discussion about the API of the vimc

Re: [RFT] [media] siano: FIX use-after-free in worker_thread

On Wed, Sep 27, 2017 at 8:38 PM, arvind wrote: > > > On Wednesday 27 September 2017 05:47 PM, Andrey Konovalov wrote: > > On Wed, Sep 27, 2017 at 2:00 PM, Andrey Konovalov > wrote: > > On Wed, Sep 27, 2017 at 11:21 AM, Arvind Yadav >

Re: [RFT v2] [media] siano: FIX use-after-free in worker_thread

On Wed, Sep 27, 2017 at 8:32 PM, Arvind Yadav wrote: > Call flush_work() on failure and disconnect. Work initialize and schedule > in smsusb_onresponse(). it should be freed in smsusb_stop_streaming(). > > Signed-off-by: Arvind Yadav Hi

[RFT v2] [media] siano: FIX use-after-free in worker_thread

Call flush_work() on failure and disconnect. Work initialize and schedule in smsusb_onresponse(). it should be freed in smsusb_stop_streaming(). Signed-off-by: Arvind Yadav --- This bug report by Andrey Konovalov "usb/media/smsusb: use-after-free in worker_thread".

Re: [PATCH] vimc: add test_pattern and h/vflip controls to the sensor

Hi Hans, Thanks for your patch and sorry for my late reply. Please see my comments and questions below On 2017-07-28 07:23 AM, Hans Verkuil wrote: > Add support for the test_pattern control and the h/vflip controls. > > This makes it possible to switch to more interesting test patterns and to >

[PATCH v1 08/13] staging: atomisp: Remove ->power_ctrl() callback

There is redundant callback which does nothing in upstreamed version of the driver. Remove it along with user call places. Mostly done with help of coccinelle. Signed-off-by: Andy Shevchenko --- drivers/staging/media/atomisp/i2c/gc0310.c

[PATCH v1 07/13] staging: atomisp: Remove ->gpio_ctrl() callback

There is redundant callback which does nothing in upstreamed version of the driver. Remove it along with user call places. Mostly done with help of coccinelle. Signed-off-by: Andy Shevchenko --- drivers/staging/media/atomisp/i2c/gc0310.c

[PATCH v1 10/13] staging: atomisp: Remove Gmin dead code #1

struct camera_af_platform_data and bound functions are not used anywhere. Signed-off-by: Andy Shevchenko --- .../media/atomisp/include/linux/atomisp_platform.h | 6 -- .../platform/intel-mid/atomisp_gmin_platform.c | 22 -- 2 files

[PATCH v1 03/13] staging: atomisp: Use module_i2c_driver() macro

This is done using coccinelle semantic patch: // @a@ identifier f, x; @@ -static f(...) { return i2c_add_driver(); } @b depends on a@ identifier e, a.x; @@ -static e(...) { i2c_del_driver(); } @c depends on a && b@ identifier a.f; declarer name module_init; @@ -module_init(f); @d depends on a

[PATCH v1 09/13] staging: atomisp: Remove unused members of camera_sensor_platform_data

Remove unused members along with dead code. Mostly done with help of coccinelle. Signed-off-by: Andy Shevchenko --- drivers/staging/media/atomisp/i2c/gc0310.c | 13 - drivers/staging/media/atomisp/i2c/gc2235.c |

[PATCH v1 02/13] staging: atomisp: Remove AP1302 sensor support

This sensor is not used by any known ACPI-enabled platform (and no kernel users for it so far). Just remove it for good until we get a platform which actually uses it. Signed-off-by: Andy Shevchenko --- drivers/staging/media/atomisp/i2c/Kconfig | 12 -

  1   2   >