RE: [PATCH v2 08/12] intel-ipu3: params: compute and program ccs

Hi, Andy, > -Original Message- > From: linux-media-ow...@vger.kernel.org [mailto:linux-media- > ow...@vger.kernel.org] On Behalf Of Andy Shevchenko > Sent: Friday, June 16, 2017 3:53 PM > To: Zhi, Yong > Cc: Linux Media Mailing List ; >

cron job: media_tree daily build: ERRORS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Wed Oct 11 05:00:15 CEST 2017 media-tree git hash:c1301077213d4dca34f01fc372b64d3c4a49a437 media_build

RE: [PATCH v2 09/12] intel-ipu3: css hardware setup

Hi, Andy, Thanks for the review. > -Original Message- > From: linux-media-ow...@vger.kernel.org [mailto:linux-media- > ow...@vger.kernel.org] On Behalf Of Andy Shevchenko > Sent: Saturday, June 17, 2017 12:07 PM > To: Sakari Ailus > Cc: Zhi, Yong

[PATCH]media: dvb-frontends: Add delay to Si2168 restart

On faster CPUs a delay is required after the POWER_UP/RESUME command and the DD_RESTART command. Without the delay, the DD_RESTART command often returns -EREMOTEIO and the Si2168 does not restart. diff --git a/drivers/media/dvb-frontends/si2168.c b/drivers/media/dvb-frontends/si2168.c index

Re: [PATCH v2] Staging: bcm2048 fix bare use of 'unsigned' in radio-bcm2048.c

Hi Branislav, On Tue, Oct 10, 2017 at 03:29:19PM +0200, Branislav Radocaj wrote: > This is a patch to the radio-bcm2048.c file that fixes up > a warning found by the checkpatch.pl tool. > > Signed-off-by: Branislav Radocaj Nice work, a few git log nit picks for you to

{PATCH] media: dvb-core: Crash from uninitialized pointer

In the function dvb_net_ule(), the pointer h.priv is not initialized. When a ULE packet is received, the kernel crashes. diff --git a/drivers/media/dvb-core/dvb_net.c b/drivers/media/dvb-core/dvb_net.c index 06b0dcc..abfa3e5 100644 --- a/drivers/media/dvb-core/dvb_net.c +++

Re: [PATCH v7 5/7] media: open.rst: Adjust some terms to match the glossary

Hi Mauro, On Tue, Oct 10, 2017 at 08:37:43AM -0300, Mauro Carvalho Chehab wrote: > Em Fri, 6 Oct 2017 15:48:22 +0300 > Sakari Ailus escreveu: > > > Hi Mauro, > > > > On Wed, Sep 27, 2017 at 07:23:47PM -0300, Mauro Carvalho Chehab wrote: > > > As we now have a glossary,

Re: [PATCH v7 1/7] media: add glossary.rst with a glossary of terms used at V4L2 spec

Hi Mauro, On Tue, Oct 10, 2017 at 09:49:38AM -0300, Mauro Carvalho Chehab wrote: > Em Tue, 10 Oct 2017 14:54:35 +0300 > Sakari Ailus escreveu: > > > On Tue, Oct 10, 2017 at 06:15:03AM -0300, Mauro Carvalho Chehab wrote: > > > Em Fri, 6 Oct 2017 14:51:06 +0300 > > > Sakari

[PATCH v2 4/6] tuner-simple: allow setting mono radio mode

For some types of tuners (Philips FMD1216ME(X) MK3 currently) we know that letting TDA9887 output port 1 remain high (inactive) will switch FM radio to mono mode. Let's make use of this functionality - nothing changes for the default stereo radio mode. Tested on a Medion 95700 board which has a

[PATCH v2 0/6] [media] Add analog mode support for Medion MD95700

This series adds support for analog part of Medion 95700 in the cxusb driver. What works: * Video capture at various sizes with sequential fields, * Input switching (TV Tuner, Composite, S-Video), * TV and radio tuning, * Video standard switching and auto detection, * Radio mode switching (stereo

[PATCH v2 6/6] [media] cxusb: add analog mode support for Medion MD95700

This patch adds support for analog part of Medion 95700 in the cxusb driver. What works: * Video capture at various sizes with sequential fields, * Input switching (TV Tuner, Composite, S-Video), * TV and radio tuning, * Video standard switching and auto detection, * Radio mode switching (stereo

[PATCH v2 5/6] [media] cxusb: implement Medion MD95700 digital / analog coexistence

This patch prepares cxusb driver for supporting the analog part of Medion 95700 (previously only the digital - DVB - mode was supported). Specifically, it adds support for: * switching the device between analog and digital modes of operation, * enforcing that only one mode is active at the same

[PATCH v2 1/6] cx25840: add pin to pad mapping and output format configuration

This commit adds pin to pad mapping and output format configuration support in CX2584x-series chips to cx25840 driver. This functionality is then used to allow disabling ivtv-specific hacks (called a "generic mode"), so cx25840 driver can be used for other devices not needing them without risking

[PATCH v2 3/6] cx25840: fix a possible divide by zero in set_fmt callback

If set_fmt callback is called with format->width or format->height set to zero and HACTIVE_CNT or VACTIVE_CNT bits (respectively) in chip are zero we will divide by zero later in this callback when we try to calculate HSC or VSC values. Fix this by explicitly rejecting these values.

[PATCH v2 2/6] cx25840: describe standard for 0b1100 value in AFD_FMT_STAT bits

A 0b1100 value in 4 LSBs of "General Status 1" register (AFD_FMT_STAT) has known meaning for CX2584x-series chips - it means that a SECAM signal is currently detected by the chip. Use this opportunity to also fix wrong binary values that were present as comments attached to some entries in an

Re: [PATCH 2/8] Documentation: fix admin-guide doc refs

On Tue, Oct 10, 2017 at 7:36 PM, Tom Saeger wrote: > Make admin-guide document refs valid. > > Signed-off-by: Tom Saeger Acked-by: Rafael J. Wysocki > --- > Documentation/ABI/stable/sysfs-devices | 2 +- >

Re: [PATCH 05/24] media: v4l2-dev: convert VFL_TYPE_* into an enum

On Mon, Oct 09, 2017 at 07:19:11AM -0300, Mauro Carvalho Chehab wrote: > Using enums makes easier to document, as it can use kernel-doc > markups. It also allows cross-referencing, with increases the > kAPI readability. > All changes look legit. But I'd expect cx88_querycap() return type

Re: IMX CSI max pixel rate

On Fri, Oct 6, 2017 at 3:14 AM, Philipp Zabel wrote: > > On Fri, 2017-10-06 at 10:49 +0300, Sakari Ailus wrote: > > On Thu, Oct 05, 2017 at 10:21:16AM -0700, Tim Harvey wrote: > > > Greetings, > > > > > > I'm working on a HDMI receiver driver for the TDA1997x > > >

[PATCH 5/8] Documentation: fix media related doc refs

Make media doc refs valid. Signed-off-by: Tom Saeger --- Documentation/admin-guide/kernel-parameters.txt| 4 ++-- Documentation/media/dvb-drivers/bt8xx.rst | 8 Documentation/media/uapi/v4l/dev-sliced-vbi.rst| 2 +-

[PATCH 2/8] Documentation: fix admin-guide doc refs

Make admin-guide document refs valid. Signed-off-by: Tom Saeger --- Documentation/ABI/stable/sysfs-devices | 2 +- Documentation/ABI/testing/sysfs-devices-system-cpu | 6 -- Documentation/ABI/testing/sysfs-power | 6 --

Re: [PATCH] media: vb2: unify calling of set_page_dirty_lock

Le mardi 29 août 2017 à 14:26 +0300, Stanimir Varbanov a écrit : > Currently videobuf2-dma-sg checks for dma direction for > every single page and videobuf2-dc lacks any dma direction > checks and calls set_page_dirty_lock unconditionally. > > Thus unify and align the invocations of

Re: [PATCH v8 4/7] media: open.rst: document vdevnode-centric and mc-centric types

More word-smithing... On 10/10/2017 01:45 PM, Mauro Carvalho Chehab wrote: > When we added support for omap3, back in 2010, we added a new > type of V4L2 devices that aren't fully controlled via the V4L2 > device node. > > Yet, we have never clearly documented in the V4L2 specification > the

Re: [PATCH v15 04/32] v4l: async: Fix notifier complete callback error handling

Hi Hans, On Tue, Oct 10, 2017 at 03:18:13PM +0200, Hans Verkuil wrote: > On 10/10/2017 02:57 PM, Sakari Ailus wrote: > > Hi Hans, > > > > On Mon, Oct 09, 2017 at 01:45:25PM +0200, Hans Verkuil wrote: > >> On 04/10/17 23:50, Sakari Ailus wrote: > >>> The notifier complete callback may return an

Re: [PATCH 18/24] media: vb2-core: use bitops for bits

On Mon, Oct 09, 2017 at 07:19:24AM -0300, Mauro Carvalho Chehab wrote: > Use the existing macros to identify vb2_io_modes bits. > > Signed-off-by: Mauro Carvalho Chehab Acked-by: Sakari Ailus -- Sakari Ailus e-mail: sakari.ai...@iki.fi

Re: [PATCH v8 1/7] media: add glossary.rst with a glossary of terms used at V4L2 spec

More (mostly) small stuff: On 10/10/2017 01:45 PM, Mauro Carvalho Chehab wrote: > Add a glossary of terms for V4L2, as several concepts are complex > enough to cause misunderstandings. > > Signed-off-by: Mauro Carvalho Chehab > --- >

Re: [PATCH 22/24] media: vb2: add cross references at memops and v4l2 kernel-doc markups

On Mon, Oct 09, 2017 at 07:19:28AM -0300, Mauro Carvalho Chehab wrote: > Add cross-references where needed and add periods at the end of > each kernel-doc paragraph, in order to make it coherent with other > VB2 descriptions. > > Signed-off-by: Mauro Carvalho Chehab

Re: [PATCH 21/24] media: vb2-core: fix descriptions for VB2-only functions

Hi Mauro, On Mon, Oct 09, 2017 at 07:19:27AM -0300, Mauro Carvalho Chehab wrote: > When we split VB2 into an independent streaming module and > a V4L2 one, some vb2-core functions started to have a wrong > description: they're meant to be used only by the API-specific > parts of VB2, like

[PATCH] dtv-scan-tables: Elisa cable-tv (PKS+Riihimäki)

Attached is the DVB-C tuning information for Elisa cable-TV in Finnish capital region and Riihimäki. -- Heikki Kantola fi-Elisa-PKS Description: Binary data

Re: [PATCH 19/24] media: vb2-core: Improve kernel-doc markups

Hi Mauro, On Mon, Oct 09, 2017 at 07:19:25AM -0300, Mauro Carvalho Chehab wrote: > There are several issues on the current markups: > - lack of cross-references; > - wrong cross-references; > - lack of a period of the end of several phrases; > - Some descriptions can be enhanced. > >

[PATCH v2] Staging: bcm2048 fix bare use of 'unsigned' in radio-bcm2048.c

This is a patch to the radio-bcm2048.c file that fixes up a warning found by the checkpatch.pl tool. Signed-off-by: Branislav Radocaj --- [1]: https://marc.info/?l=linux-driver-devel=150331308401055=2 Changes in v2: Removed unused 'size' argument from property_read

Re: [PATCH v15 04/32] v4l: async: Fix notifier complete callback error handling

On 10/10/2017 02:57 PM, Sakari Ailus wrote: > Hi Hans, > > On Mon, Oct 09, 2017 at 01:45:25PM +0200, Hans Verkuil wrote: >> On 04/10/17 23:50, Sakari Ailus wrote: >>> The notifier complete callback may return an error. This error code was >>> simply returned to the caller but never handled

Re: [PATCH v14 20/28] v4l: fwnode: Add a helper function to obtain device / integer references

On 10/10/2017 01:27 PM, Sakari Ailus wrote: > Hi Hans, > > On Mon, Oct 09, 2017 at 02:06:55PM +0200, Hans Verkuil wrote: >> Hi Sakari, >> >> My reply here is also valid for v15. >> >> On 26/09/17 13:30, Sakari Ailus wrote: >>> Hi Hans, >>> >>> Thanks for the review. >>> >>> On Tue, Sep 26, 2017

Re: [PATCH v15 04/32] v4l: async: Fix notifier complete callback error handling

Hi Hans, On Mon, Oct 09, 2017 at 01:45:25PM +0200, Hans Verkuil wrote: > On 04/10/17 23:50, Sakari Ailus wrote: > > The notifier complete callback may return an error. This error code was > > simply returned to the caller but never handled properly. > > > > Move calling the complete callback

Re: [PATCH v7 1/7] media: add glossary.rst with a glossary of terms used at V4L2 spec

Em Tue, 10 Oct 2017 14:54:35 +0300 Sakari Ailus escreveu: > On Tue, Oct 10, 2017 at 06:15:03AM -0300, Mauro Carvalho Chehab wrote: > > Em Fri, 6 Oct 2017 14:51:06 +0300 > > Sakari Ailus escreveu: > > > > > Hi Mauro, > > > > > > On Fri, Oct 06, 2017

Re: [PATCH v15 01/32] v4l: async: Remove re-probing support

Hi Sylwester, On Mon, Oct 09, 2017 at 06:44:52PM +0200, Sylwester Nawrocki wrote: > Hi Sakari, > > On 10/09/2017 04:18 PM, Sakari Ailus wrote: > > Sure, how about this at the end of the current commit message: > > > > If there is a need to support removing the clock provider in the future, > >

Re: [PATCH v7 1/7] media: add glossary.rst with a glossary of terms used at V4L2 spec

On Tue, Oct 10, 2017 at 06:15:03AM -0300, Mauro Carvalho Chehab wrote: > Em Fri, 6 Oct 2017 14:51:06 +0300 > Sakari Ailus escreveu: > > > Hi Mauro, > > > > On Fri, Oct 06, 2017 at 01:22:29PM +0300, Sakari Ailus wrote: > > > > +V4L2 device node > > > > + A device

Re: [PATCH v4] staging: atomisp: add a driver for ov5648 camera sensor

Hi Alan, On Tue, Oct 10, 2017 at 10:08:40AM +0100, Alan Cox wrote: > > Would it make sense to first get the other drivers to upstream and > > then see what's the status of atomisp? > > Agreed > > > the board specific information from firmware is conveyed to the > > sensor drivers will change

[PATCH v8 0/7] document types of hardware control for V4L2

On Kernel 2.6.39, the omap3 driver was introduced together with a new way to control complex V4L2 devices used on embedded systems, but this was never documented, as the original idea were to have "soon" support for standard apps to use it as well, via libv4l, but that didn't happen so far. Also,

[PATCH v8 2/7] media: open.rst: better document device node naming

Right now, only kAPI documentation describes the device naming. However, such description is needed at the uAPI too. Add it, and describe how to get an unique identify for a given device. Signed-off-by: Mauro Carvalho Chehab Acked-by: Hans Verkuil

[PATCH v8 4/7] media: open.rst: document vdevnode-centric and mc-centric types

When we added support for omap3, back in 2010, we added a new type of V4L2 devices that aren't fully controlled via the V4L2 device node. Yet, we have never clearly documented in the V4L2 specification the differences between the two types. Let's document them based on the the current

[PATCH v8 6/7] media: videodev2: add a flag for MC-centric devices

As both vdev-centric and MC-centric devices may implement the same APIs, we need a flag to allow userspace to distinguish between them. Signed-off-by: Mauro Carvalho Chehab Acked-by: Sakari Ailus Acked-by: Hans Verkuil

[PATCH v8 3/7] media: open.rst: remove the minor number range

minor numbers use to range between 0 to 255, but that was changed a long time ago. While it still applies when CONFIG_VIDEO_FIXED_MINOR_RANGES, when the minor number is dynamically allocated, this may not be true. In any case, this is not relevant, as udev will take care of it. So, remove this

[PATCH v8 5/7] media: open.rst: Adjust some terms to match the glossary

As we now have a glossary, some terms used on open.rst require adjustments. Acked-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab --- Documentation/media/uapi/v4l/open.rst | 25 + 1 file changed, 13 insertions(+),

[PATCH v8 7/7] media: open.rst: add a notice about subdev-API on vdev-centric

The documentation doesn't mention if vdev-centric hardware control would have subdev API or not. Add a notice about that, reflecting the current status, where three drivers use it, in order to support some subdev-specific controls. Signed-off-by: Mauro Carvalho Chehab

[PATCH v8 1/7] media: add glossary.rst with a glossary of terms used at V4L2 spec

Add a glossary of terms for V4L2, as several concepts are complex enough to cause misunderstandings. Signed-off-by: Mauro Carvalho Chehab --- Documentation/media/uapi/v4l/glossary.rst | 167 ++ Documentation/media/uapi/v4l/v4l2.rst | 1

Re: [PATCH v7 5/7] media: open.rst: Adjust some terms to match the glossary

Em Fri, 6 Oct 2017 15:48:22 +0300 Sakari Ailus escreveu: > Hi Mauro, > > On Wed, Sep 27, 2017 at 07:23:47PM -0300, Mauro Carvalho Chehab wrote: > > As we now have a glossary, some terms used on open.rst > > require adjustments. > > > > Acked-by: Hans Verkuil

Re: [PATCH v14 20/28] v4l: fwnode: Add a helper function to obtain device / integer references

Hi Hans, On Mon, Oct 09, 2017 at 02:06:55PM +0200, Hans Verkuil wrote: > Hi Sakari, > > My reply here is also valid for v15. > > On 26/09/17 13:30, Sakari Ailus wrote: > > Hi Hans, > > > > Thanks for the review. > > > > On Tue, Sep 26, 2017 at 10:47:40AM +0200, Hans Verkuil wrote: > >> On

Re: [PATCH] media: imon: Fix null-ptr-deref in imon_probe

On Mon, Oct 9, 2017 at 8:14 PM, Arvind Yadav wrote: > It seems that the return value of usb_ifnum_to_if() can be NULL and > needs to be checked. Hi Arvind, Your patch fixes the issue. Thanks! Tested-by: Andrey Konovalov > > Signed-off-by:

Re: [PATCH v7 4/7] media: open.rst: document devnode-centric and mc-centric types

Em Fri, 6 Oct 2017 15:24:27 +0300 Sakari Ailus escreveu: > > +When V4L2 was originally designed, there was only one type of > > +media hardware control: via the **V4L2 device nodes**. We refer to this > > kind > > +of control as **V4L2 device node centric** (or, simply, >

Re: [PATCH v7 1/7] media: add glossary.rst with a glossary of terms used at V4L2 spec

Em Fri, 6 Oct 2017 14:51:06 +0300 Sakari Ailus escreveu: > Hi Mauro, > > On Fri, Oct 06, 2017 at 01:22:29PM +0300, Sakari Ailus wrote: > > > +V4L2 device node > > > + A device node that is associated to a V4L2 main driver, > > > + as specified in

Re: [PATCH v4] staging: atomisp: add a driver for ov5648 camera sensor

> Would it make sense to first get the other drivers to upstream and > then see what's the status of atomisp? Agreed > the board specific information from firmware is conveyed to the > sensor drivers will change to what the rest of the sensor drivers are > using. I think a most straightforward

Re: [PATCH v7 1/7] media: add glossary.rst with a glossary of terms used at V4L2 spec

On Tue, Oct 10, 2017 at 05:30:04AM -0300, Mauro Carvalho Chehab wrote: > Em Fri, 6 Oct 2017 13:22:29 +0300 > Sakari Ailus escreveu: > > > > +Bridge driver > > > + The same as V4L2 main driver. > > > > Not all V4L2 main drivers can be bridge drivers. Mem-to-mem

Re: [PATCH] media: vb2: unify calling of set_page_dirty_lock

On Tue, Oct 10, 2017 at 10:01:36AM +0200, Marek Szyprowski wrote: > Hi Stanimir, > > On 2017-10-10 09:42, Stanimir Varbanov wrote: > > Marek, > > > > Any comments? > > Oh, I thought that this one has been already merged. If not (yet), > here is my ack. > > > On 08/29/2017 02:26 PM, Stanimir

[PATCH] media: add glossary.rst with a glossary of terms used at V4L2 spec

Add a glossary of terms for V4L2, as several concepts are complex enough to cause misunderstandings. Signed-off-by: Mauro Carvalho Chehab --- Documentation/media/uapi/v4l/glossary.rst | 150 ++ Documentation/media/uapi/v4l/v4l2.rst | 1

Re: [PATCH v7 1/7] media: add glossary.rst with a glossary of terms used at V4L2 spec

Em Fri, 6 Oct 2017 13:22:29 +0300 Sakari Ailus escreveu: > Hi Mauro, > > Thanks for continuing the work on this! > > On Wed, Sep 27, 2017 at 07:23:43PM -0300, Mauro Carvalho Chehab wrote: > > Add a glossary of terms for V4L2, as several concepts are complex > > enough to

[PATCH v3 26/26] kfifo: DECLARE_KIFO_PTR(fifo, u64) does not work on arm 32 bit

If you try to store u64 in a kfifo (or a struct with u64 members), then the buf member of __STRUCT_KFIFO_PTR will cause 4 bytes padding due to alignment (note that struct __kfifo is 20 bytes on 32 bit). That in turn causes the __is_kfifo_ptr() to fail, which is caught by kfifo_alloc(), which now

Re: [PATCH v7 1/7] media: add glossary.rst with a glossary of terms used at V4L2 spec

Em Tue, 10 Oct 2017 10:27:12 +0200 Hans Verkuil escreveu: > > +V4L2 sub-device driver > > + Part of the media hardware that implements support for > > + a hardware component. > > The description now no longer fits the term. I suggest: > > "The V4L2 driver that

Re: [PATCH v5 2/3] doc-rst: add IPU3 raw10 bayer pixel format definitions

Hi Yong, On Fri, Oct 06, 2017 at 06:39:00PM -0500, Yong Zhi wrote: > The formats added by this patch are: > > V4L2_PIX_FMT_IPU3_SBGGR10 > V4L2_PIX_FMT_IPU3_SGBRG10 > V4L2_PIX_FMT_IPU3_SGRBG10 > V4L2_PIX_FMT_IPU3_SRGGB10 > > Signed-off-by: Yong Zhi >

Re: [PATCH v7 1/7] media: add glossary.rst with a glossary of terms used at V4L2 spec

Em Fri, 6 Oct 2017 13:22:29 +0300 Sakari Ailus escreveu: > > +Bridge driver > > + The same as V4L2 main driver. > > Not all V4L2 main drivers can be bridge drivers. Mem-to-mem devices, for > instance. How about: > > A driver for a device receiving image data from

Re: [PATCH v7 1/7] media: add glossary.rst with a glossary of terms used at V4L2 spec

On 10/10/2017 10:20 AM, Mauro Carvalho Chehab wrote: > Em Tue, 10 Oct 2017 09:47:13 +0200 > Hans Verkuil escreveu: > >> On 09/28/2017 12:23 AM, Mauro Carvalho Chehab wrote: >>> Add a glossary of terms for V4L2, as several concepts are complex >>> enough to cause

Re: [PATCH v7 1/7] media: add glossary.rst with a glossary of terms used at V4L2 spec

Em Tue, 10 Oct 2017 09:47:13 +0200 Hans Verkuil escreveu: > On 09/28/2017 12:23 AM, Mauro Carvalho Chehab wrote: > > Add a glossary of terms for V4L2, as several concepts are complex > > enough to cause misunderstandings. > > > > Signed-off-by: Mauro Carvalho Chehab

Re: [PATCH v4 0/5] media: atmel-isc: Rework the format list and clock provider

On Tue, Oct 10, 2017 at 10:46:35AM +0800, Wenyou Yang wrote: > To improve the readability of code, rework the format list table, > split the format array into two. Meanwhile, fix the issue of the > clock provider operation and the pm runtime support. > > Changes in v4: > - Call

Re: [PATCH v7 7/7] media: open.rst: add a notice about subdev-API on vdev-centric

On 09/28/2017 12:23 AM, Mauro Carvalho Chehab wrote: > The documentation doesn't mention if vdev-centric hardware > control would have subdev API or not. > > Add a notice about that, reflecting the current status, where > three drivers use it, in order to support some subdev-specific > controls.

Re: [PATCH] media: vb2: unify calling of set_page_dirty_lock

Hi Stanimir, On 2017-10-10 09:42, Stanimir Varbanov wrote: Marek, Any comments? Oh, I thought that this one has been already merged. If not (yet), here is my ack. On 08/29/2017 02:26 PM, Stanimir Varbanov wrote: Currently videobuf2-dma-sg checks for dma direction for every single page and

Re: [PATCH v7 6/7] media: videodev2: add a flag for MC-centric devices

On 09/28/2017 12:23 AM, Mauro Carvalho Chehab wrote: > As both vdev-centric and MC-centric devices may implement the > same APIs, we need a flag to allow userspace to distinguish > between them. > > Signed-off-by: Mauro Carvalho Chehab > --- >

[PATCH v2] media: venus: venc: fix bytesused v4l2_plane field

This fixes wrongly filled bytesused field of v4l2_plane structure by include data_offset in the plane, Also fill data_offset and bytesused for capture type of buffers only. Signed-off-by: Stanimir Varbanov --- v2: Just delete pointless WARN_ON.

Re: [PATCH v7 1/7] media: add glossary.rst with a glossary of terms used at V4L2 spec

On 09/28/2017 12:23 AM, Mauro Carvalho Chehab wrote: > Add a glossary of terms for V4L2, as several concepts are complex > enough to cause misunderstandings. > > Signed-off-by: Mauro Carvalho Chehab > --- > Documentation/media/uapi/v4l/glossary.rst | 136 >

Re: [PATCH v5 3/3] intel-ipu3: cio2: Add new MIPI-CSI2 driver

Hi Yong, Thanks for the update! Please see my comments below. On Fri, Oct 06, 2017 at 06:39:01PM -0500, Yong Zhi wrote: > This patch adds CIO2 CSI-2 device driver for > Intel's IPU3 camera sub-system support. > > Signed-off-by: Yong Zhi > Signed-off-by: Hyungwoo Yang

Re: [PATCH] media: vb2: unify calling of set_page_dirty_lock

Marek, Any comments? On 08/29/2017 02:26 PM, Stanimir Varbanov wrote: > Currently videobuf2-dma-sg checks for dma direction for > every single page and videobuf2-dc lacks any dma direction > checks and calls set_page_dirty_lock unconditionally. > > Thus unify and align the invocations of

[PATCH v3 25/26] media: MAINTAINERS: add entry for zilog_ir

Add MAINTAINER's entry for this new driver ported from staging. Signed-off-by: Sean Young --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index fb5f548a568e..15d32348e902 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -14876,6

[PATCH v3 26/26] kfifo: DECLARE_KIFO_PTR(fifo, u64) does not work on arm 32 bit

If you try to store u64 in a kfifo (or a struct with u64 members), then the buf member of __STRUCT_KFIFO_PTR will cause 4 bytes padding due to alignment (note that struct __kfifo is 20 bytes on 32 bit). That in turn causes the __is_kfifo_ptr() to fail, which is caught by kfifo_alloc(), which now

[PATCH v3 24/26] media: MAINTAINERS: remove lirc staging area

Now that lirc is no longer in the staging area, remove the entry. Signed-off-by: Sean Young --- MAINTAINERS | 6 -- 1 file changed, 6 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index a8126830829b..fb5f548a568e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -12677,12

[PATCH v3 23/26] media: lirc: scancode rc devices should have a lirc device too

Now that the lirc interface supports scancodes, RC scancode devices can also have a lirc device. The only feature they will have enabled is LIRC_CAN_REC_SCANCODE. Note that CEC devices have no lirc device, since they can be controlled from their /dev/cecN chardev. Signed-off-by: Sean Young

[PATCH v3 21/26] media: lirc: document LIRC_MODE_SCANCODE

Lirc supports a new mode which requires documentation. Signed-off-by: Sean Young --- Documentation/media/lirc.h.rst.exceptions | 26 +++ Documentation/media/uapi/rc/lirc-dev-intro.rst | 51 +++---

[PATCH v3 19/26] media: lirc: implement reading scancode

This implements LIRC_MODE_SCANCODE reading from the lirc device. The scancode can be read from the input device too, but with this interface you get the rc protocol, keycode, toggle and repeat status in addition to just the scancode. int main() { int fd, mode, rc; fd =

[PATCH v3 18/26] media: lirc: remove last remnants of lirc kapi

rc-core has replaced the lirc kapi many years ago, and now with the last driver ported to rc-core, we can finally remove it. Note this has no effect on userspace. All future IR drivers should use the rc-core api. Signed-off-by: Sean Young ---

[PATCH v3 22/26] media: lirc: introduce LIRC_SET_POLL_MODES

If you want to poll for both decoded scancodes and raw IR, then this ioctl will help you. int fd = open("/dev/lirc0", O_RDONLY | O_NONBLOCK); for (;;) { unsigned mode = LIRC_MODE_SCANCODE | LIRC_MODE_MODE2; ioctl(fd, LIRC_SET_POLL_MODES, ); poll(&((struct pollfd){ .fd =

[PATCH v3 20/26] media: rc: ensure lirc device receives nec repeats

The lirc device should get lirc repeats whether there is a keymap match or not. Signed-off-by: Sean Young --- drivers/media/rc/rc-main.c | 27 +-- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/drivers/media/rc/rc-main.c

[PATCH v3 13/26] media: lirc: use kfifo rather than lirc_buffer for raw IR

Since the only mode lirc devices can handle is raw IR, handle this in a plain kfifo. Remove lirc_buffer since this is no longer needed. Signed-off-by: Sean Young --- drivers/media/rc/ir-lirc-codec.c | 79 +--- drivers/media/rc/lirc_dev.c | 199

[PATCH v3 11/26] media: rc: document and fix rc_validate_scancode()

For some IR protocols, some scancode values not valid, i.e. they're part of a different protocol variant. Signed-off-by: Sean Young --- drivers/media/rc/rc-main.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/media/rc/rc-main.c

[PATCH v3 17/26] media: lirc: remove name from lirc_dev

This is a duplicate of rcdev->driver_name. Signed-off-by: Sean Young --- Documentation/media/uapi/rc/lirc-dev-intro.rst | 2 +- drivers/media/rc/ir-lirc-codec.c | 2 -- drivers/media/rc/lirc_dev.c| 9 +++-- include/media/lirc_dev.h

[PATCH v3 14/26] media: lirc: move lirc_dev->attached to rc_dev->registered

This is done to further remove the lirc kernel api. Ensure that every fops checks for this. Signed-off-by: Sean Young --- drivers/media/rc/ir-lirc-codec.c | 16 ++-- drivers/media/rc/lirc_dev.c | 4 +--- drivers/media/rc/rc-main.c | 8

[PATCH v3 15/26] media: lirc: do not call rc_close() on unregistered devices

If a lirc chardev is held open after a device is unplugged, rc_close() will be called after rc_unregister_device(). The driver is not expecting any calls at this point, and the iguanair driver causes an oops in this scenario. Signed-off-by: Sean Young ---

[PATCH v3 12/26] media: lirc: merge lirc_dev_fop_ioctl and ir_lirc_ioctl

Calculate lirc features when necessary, and add LIRC_{S,G}ET_REC_MODE cases to ir_lirc_ioctl. This makes lirc_dev_fop_ioctl() unnecessary since all cases are already handled by ir_lirc_ioctl(). Signed-off-by: Sean Young --- drivers/media/rc/ir-lirc-codec.c | 85

[PATCH v3 16/26] media: lirc: create rc-core open and close lirc functions

Replace the generic kernel lirc api with ones which use rc-core, further reducing the lirc_dev members. Signed-off-by: Sean Young --- drivers/media/rc/ir-lirc-codec.c | 59 -- drivers/media/rc/lirc_dev.c | 68

[PATCH v3 10/26] media: lirc: validate scancode for transmit

Ensure we reject an attempt to transmit invalid scancodes. Signed-off-by: Sean Young --- drivers/media/rc/ir-lirc-codec.c | 10 drivers/media/rc/rc-core-priv.h | 1 + drivers/media/rc/rc-main.c | 53 +--- 3 files changed, 44

[PATCH v3 09/26] media: lirc: lirc interface should not be a raw decoder

The lirc user interface exists as a raw decoder, which does not make much sense for transmit-only devices. In addition, we want to have lirc char devices for devices which do not use raw IR, i.e. scancode only devices. Note that rc-code, lirc_dev, ir-lirc-codec are now calling functions of each

[PATCH v3 07/26] media: promote lirc_zilog out of staging

Rename to zilog_ir in the process. Signed-off-by: Sean Young --- drivers/media/rc/Kconfig | 12 drivers/media/rc/Makefile | 1 + .../lirc/lirc_zilog.c => media/rc/zilog_ir.c} | 0 drivers/staging/media/Kconfig

[PATCH v3 08/26] media: lirc: remove LIRCCODE and LIRC_GET_LENGTH

LIRCCODE is a lirc mode where a driver produces driver-dependent codes for receive and transmit. No driver uses this any more. The LIRC_GET_LENGTH ioctl was used for this mode only. Signed-off-by: Sean Young --- Documentation/media/lirc.h.rst.exceptions | 5 +++

[PATCH v3 05/26] media: lirc_zilog: fix variable types and other ugliness

Cleans up code and makes checkpatch happy. Signed-off-by: Sean Young --- drivers/staging/media/lirc/lirc_zilog.c | 162 +++- 1 file changed, 55 insertions(+), 107 deletions(-) diff --git a/drivers/staging/media/lirc/lirc_zilog.c

[PATCH v3 06/26] media: lirc_zilog: port to rc-core using scancode tx interface

Now that rc-core can send a scancode by rc protocol and scancode, port the lirc_zilog to this interface. The firmware file needs updating to contain the protocol and scancode, so we have haup-ir-blaster-v2.bin for this. The LIRC_MODE_LIRCCODE is no longer supported, and transmit can only be done

[PATCH v3 03/26] media: rc: auto load encoder if necessary

When sending scancodes, load the encoder if we need it. Signed-off-by: Sean Young --- drivers/media/rc/rc-core-priv.h | 1 + drivers/media/rc/rc-ir-raw.c| 2 ++ drivers/media/rc/rc-main.c | 2 +- 3 files changed, 4 insertions(+), 1 deletion(-) diff --git

[PATCH v3 02/26] media: lirc: use the correct carrier for scancode transmit

If the lirc device supports it, set the carrier for the protocol. Signed-off-by: Sean Young --- drivers/media/rc/ir-jvc-decoder.c | 1 + drivers/media/rc/ir-lirc-codec.c | 7 +++ drivers/media/rc/ir-mce_kbd-decoder.c | 1 + drivers/media/rc/ir-nec-decoder.c |

[PATCH v3 01/26] media: lirc: implement scancode sending

This introduces a new lirc mode: scancode. Any device which can send raw IR can now also send scancodes. int main() { int mode, fd = open("/dev/lirc0", O_RDWR); mode = LIRC_MODE_SCANCODE; if (ioctl(fd, LIRC_SET_SEND_MODE, )) { // kernel too old or lirc

[PATCH v3 04/26] media: lirc_zilog: remove receiver

The ir-kbd-i2c module already handles this very well. Signed-off-by: Sean Young --- drivers/staging/media/lirc/lirc_zilog.c | 901 +++- 1 file changed, 76 insertions(+), 825 deletions(-) diff --git a/drivers/staging/media/lirc/lirc_zilog.c

[PATCH v3 00/26] lirc scancode interface, and more

Introduce lirc scancode mode, use that to port lirc_zilog to rc-core using that interface, and then remove the lirc kernel api. In summary: - This removes the lirc staging directory. - lirc IR TX can use in-kernel encoders for scancode encoding - lirc_zilog uses the same interface - lirc kapi

Re: [PATCH] media: rc: ir-spi needs OF

On Mon, Oct 09, 2017 at 09:46:50AM +0100, Sean Young wrote: > Without device tree, there is no way to use this driver. > > Signed-off-by: Sean Young Thanks, Sean! Acked-by: Andi Shyti Andi > --- > drivers/media/rc/Kconfig | 1 + > 1 file changed, 1