Re: [PATCH v6 19/39] media: Add i.MX media core driver

On 04/06/2017 02:43 AM, Philipp Zabel wrote: On Mon, 2017-03-27 at 17:40 -0700, Steve Longerbeam wrote: Add the core media driver for i.MX SOC. Signed-off-by: Steve Longerbeam [...] diff --git a/drivers/staging/media/imx/imx-media-of.c

Re: [PATCH v6 19/39] media: Add i.MX media core driver

On Mon, 2017-03-27 at 17:40 -0700, Steve Longerbeam wrote: > Add the core media driver for i.MX SOC. > > Signed-off-by: Steve Longerbeam [...] > diff --git a/drivers/staging/media/imx/imx-media-of.c > b/drivers/staging/media/imx/imx-media-of.c > new file mode 100644

Re: [PATCH v6 19/39] media: Add i.MX media core driver

Hi! > +https://boundarydevices.com/products/nit6x_5mp I'd use /product/ in url, as it redirects there. > +https://boundarydevices.com/product/nit6x_5mp_mipi ..and for consistency. > +The following example configures a direct conversion pipeline to capture > +from the OV5640, transmitting on

Re: [PATCH v6 19/39] media: Add i.MX media core driver

Hi! > +References > +-- > + > +[1] "i.MX 6Dual/6Quad Applications Processor Reference Manual" > +[2] "i.MX 6Solo/6DualLite Applications Processor Reference Manual" [2] is not present in the text above. [1] is there many times. What is purpose of this section?

[PATCH v6 19/39] media: Add i.MX media core driver

Add the core media driver for i.MX SOC. Signed-off-by: Steve Longerbeam --- Documentation/media/v4l-drivers/imx.rst | 590 ++ drivers/staging/media/Kconfig | 2 + drivers/staging/media/Makefile| 1