Re: [PATCH v2 3/5] mfd: cros-ec: Introduce CEC commands and events definitions.

Hi Neil, Hi Stefan, On Fri, May 18, 2018 at 03:05:02PM +0200, Neil Armstrong wrote: > The EC can expose a CEC bus, this patch adds the CEC related definitions > needed by the cros-ec-cec driver. > Having a 16 byte mkbp event size makes it possible to send CEC > messages from the EC to the AP

Re: [PATCHv13 22/28] Documentation: v4l: document request API

Hi Laurent, Thanks for detailed review. Please let me add my thoughts inline as well. On Fri, May 18, 2018 at 11:46 PM Laurent Pinchart < laurent.pinch...@ideasonboard.com> wrote: > Hi Hans, > Thank you for the patch. > On Thursday, 3 May 2018 17:53:12 EEST Hans Verkuil wrote: [snip] > >

cron job: media_tree daily build: WARNINGS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Thu May 24 05:00:17 CEST 2018 media-tree git hash:8ed8bba70b4355b1ba029b151ade84475dd12991 media_build

Re: [PATCH v3 2/9] media: rcar-vin: Remove two empty lines

Hi Jacopo, Thanks for your work. On 2018-05-18 16:40:38 +0200, Jacopo Mondi wrote: > Remove un-necessary empty lines. > > Signed-off-by: Jacopo Mondi Acked-by: Niklas Söderlund > --- >

Re: [PATCH v3 1/9] media: rcar-vin: Rename 'digital' to 'parallel'

Hi Jacopo, Thanks for your patch. On 2018-05-18 16:40:37 +0200, Jacopo Mondi wrote: > As the term 'digital' is used all over the rcar-vin code in place of > 'parallel', rename all the occurrencies. > > Signed-off-by: Jacopo Mondi > --- >

Re: [PATCH 05/15] mtd: nand: pxa3xx: remove the dmaengine compat need

Hi Robert, Please refer to the attached patch instead of the one I sent earlier. I missed to also remove the platform_get_resource(IORESOURCE_DMA) call. Thanks, Daniel On Friday, May 18, 2018 11:31 PM, Daniel Mack wrote: Hi Robert, Thanks for this series. On Monday, April 02, 2018 04:26

Re: [PATCH 06/20] omap4iss: Add video_device and vb2_queue locks

On Tue, 2018-05-22 at 11:09 +0200, Hans Verkuil wrote: > On 18/05/18 20:51, Ezequiel Garcia wrote: > > video_device and vb2_queue locks are now both > > mandatory. Add them, remove driver ad-hoc locks, > > and implement wait_{prepare, finish}. > > > > To stay on the safe side, this commit uses a

Re: [PATCHv2 0/4] gspca: convert to vb2gspca: convert to vb2

On 22 May 2018 at 05:16, Hans Verkuil wrote: > On 18/05/18 19:51, Ezequiel Garcia wrote: >> On 13 May 2018 at 06:47, Hans Verkuil wrote: >>> From: Hans Verkuil >>> >>> The first patch converts the gspca driver to the vb2

Re: [PATCH v6 1/2] media: ov2680: dt: Add bindings for OV2680

On Fri, May 18, 2018 at 10:27 AM, Rui Miguel Silva wrote: > Hi Rob, > On Fri 18 May 2018 at 14:18, Rob Herring wrote: >> >> On Wed, May 09, 2018 at 03:31:58PM +0100, Rui Miguel Silva wrote: >>> >>> Add device tree binding documentation for the OV2680 camera sensor. >>> >>> CC:

Re: [PATCH 1/6] dt-bindings: media: rcar-vin: Describe optional ep properties

On Wed, May 23, 2018 at 2:38 PM, Laurent Pinchart wrote: > Hi Rob, > > On Wednesday, 23 May 2018 19:29:47 EEST Rob Herring wrote: >> On Wed, May 16, 2018 at 06:32:27PM +0200, Jacopo Mondi wrote: >> > Describe the optional endpoint properties for endpoint nodes

Re: [PATCH v4 0/3] IR decoding using BPF

On Wed, May 23, 2018 at 02:21:27PM +0200, Daniel Borkmann wrote: > On 05/18/2018 04:07 PM, Sean Young wrote: > > The kernel IR decoders (drivers/media/rc/ir-*-decoder.c) support the most > > widely used IR protocols, but there are many protocols which are not > > supported[1]. For example, the

Re: [PATCH 1/6] dt-bindings: media: rcar-vin: Describe optional ep properties

Hi Rob, On Wednesday, 23 May 2018 19:29:47 EEST Rob Herring wrote: > On Wed, May 16, 2018 at 06:32:27PM +0200, Jacopo Mondi wrote: > > Describe the optional endpoint properties for endpoint nodes of port@0 > > and port@1 of the R-Car VIN driver device tree bindings documentation. > > > >

Re: [ANN] Meeting to discuss improvements to support MC-based cameras on generic apps

Hi Hans, On Wednesday, 23 May 2018 19:19:37 EEST Hans Verkuil wrote: > On 18/05/18 13:24, Mauro Carvalho Chehab wrote: > > One of the biggest reasons why we decided to start libv4l project, > > in the past, was to ensure an open source solution. The problem we > > faced on that time is to ensure

Re: Bugfix for Tevii S650

+Cc: Olli The problem started with this commit. it added function dw2102_disconnect() to dw2102.c author     Olli Salonen     2015-03-16 17:14:05 (GMT) committer    Mauro Carvalho Chehab 2015-04-03 01:24:01 (GMT) commit   

Re: [PATCH] dt-bindings: media: rcar_vin: fix style for ports and endpoints

On Thu, May 17, 2018 at 01:32:12AM +0200, Niklas Söderlund wrote: > The style for referring to ports and endpoint are wrong. Refer to them > using lowercase and a unit address, port@x and endpoint@x. > > Signed-off-by: Niklas Söderlund > Reported-by: Geert

Re: [PATCH 2/6] dt-bindings: media: rcar-vin: Document data-active

On Wed, May 16, 2018 at 06:32:28PM +0200, Jacopo Mondi wrote: > Document 'data-active' property in R-Car VIN device tree bindings. > The property is optional when running with explicit synchronization > (eg. BT.601) but mandatory when embedded synchronization is in use (eg. > BT.656) as specified

Re: [PATCH 5/6] ARM: dts: rcar-gen2: Remove unused VIN properties

On Thu, May 17, 2018 at 12:13:07AM +0200, Niklas Söderlund wrote: > Hi Jacopo, > > Thanks for your work. > > On 2018-05-16 18:32:31 +0200, Jacopo Mondi wrote: > > The 'bus-width' and 'pclk-sample' properties are not parsed by the VIN > > driver and only confuse users. Remove them in all Gen2 SoC

Re: [PATCH 1/6] dt-bindings: media: rcar-vin: Describe optional ep properties

On Wed, May 16, 2018 at 06:32:27PM +0200, Jacopo Mondi wrote: > Describe the optional endpoint properties for endpoint nodes of port@0 > and port@1 of the R-Car VIN driver device tree bindings documentation. > > Signed-off-by: Jacopo Mondi > --- >

Re: [ANN] Meeting to discuss improvements to support MC-based cameras on generic apps

On 18/05/18 13:24, Mauro Carvalho Chehab wrote: > One of the biggest reasons why we decided to start libv4l project, > in the past, was to ensure an open source solution. The problem we > faced on that time is to ensure that, when a new media driver were > added with some proprietary output

Re: [PATCH v4 0/3] IR decoding using BPF

On 05/18/2018 04:07 PM, Sean Young wrote: > The kernel IR decoders (drivers/media/rc/ir-*-decoder.c) support the most > widely used IR protocols, but there are many protocols which are not > supported[1]. For example, the lirc-remotes[2] repo has over 2700 remotes, > many of which are not

Re: [PATCH v10 08/16] v4l: mark unordered formats

On 23/05/18 12:30, Ezequiel Garcia wrote: > On Tue, 2018-05-22 at 13:55 +0200, Hans Verkuil wrote: >> On 21/05/18 18:59, Ezequiel Garcia wrote: >>> From: Gustavo Padovan >>> >>> Now that we've introduced the V4L2_FMT_FLAG_UNORDERED flag, >>> mark the appropriate

Re: [PATCH] gpu: ipu-v3: Fix BT1120 interlaced CCIR codes

On 05/22/2018 01:07 PM, Philipp Zabel wrote: > Hi Marek, > > On Fri, 2018-05-18 at 18:21 +0200, Marek Vasut wrote: >> On 05/18/2018 05:51 PM, Philipp Zabel wrote: >>> Hi Marek, >>> >>> On Sat, 2018-04-07 at 15:04 +0200, Marek Vasut wrote: The BT1120 interlaced CCIR codes are the same as

Re: [PATCH v10 08/16] v4l: mark unordered formats

On Tue, 2018-05-22 at 13:55 +0200, Hans Verkuil wrote: > On 21/05/18 18:59, Ezequiel Garcia wrote: > > From: Gustavo Padovan > > > > Now that we've introduced the V4L2_FMT_FLAG_UNORDERED flag, > > mark the appropriate formats. > > > > v2: Set unordered flag before

Re: [PATCH v14 24/36] videobuf2-v4l2: Lock the media request for update for QBUF

On 21/05/18 10:54, Sakari Ailus wrote: > Lock the media request for updating on QBUF IOCTL using > media_request_lock_for_update(). > > Signed-off-by: Sakari Ailus > --- > drivers/media/common/videobuf2/videobuf2-v4l2.c | 17 ++--- > 1 file changed, 10

[PATCH v3 1/7] media: imx274: initialize format before v4l2 controls

The current probe function calls v4l2_ctrl_handler_setup() before initializing the format info. This triggers call paths such as: imx274_probe -> v4l2_ctrl_handler_setup -> imx274_s_ctrl -> imx274_set_exposure, where priv->mode_index is accessed before being assigned. This is wrong but does not

[PATCH v3 3/7] media: imx274: get rid of mode_index

After restructuring struct imx274_frmfmt, the mode_index field is still in use only for two dev_dbg() calls in imx274_s_stream(). Let's remove it and avoid duplicated information. Replacing the first usage requires some rather annoying but trivial pointer math. The other one can be removed

[PATCH v3 7/7] media: imx274: add SELECTION support for cropping

Currently this driver does not support cropping. The supported modes are the following, all capturing the entire area: - 3840x2160, 1:1 binning (native sensor resolution) - 1920x1080, 2:1 binning - 1280x720, 3:1 binning The set_fmt callback chooses among these 3 configurations the one that

[PATCH v3 4/7] media: imx274: actually use IMX274_DEFAULT_MODE

IMX274_DEFAULT_MODE is defined but not used. Start using it, so the default can be more easily changed without digging into the code. Signed-off-by: Luca Ceresoli Cc: Sakari Ailus --- Changed v2 -> v3: nothing Changed v1 -> v2: - add

[PATCH v3 5/7] media: imx274: simplify imx274_write_table()

imx274_write_table() is a mere wrapper (and the only user) to imx274_regmap_util_write_table_8(). Remove this useless indirection by merging the two functions into one. Also get rid of the wait_ms_addr and end_addr parameters since it does not make any sense to give them any values other than

[PATCH v3 0/7] media: imx274: cleanups, improvements and SELECTION API support

Hi, this patchset introduces cropping support for the Sony IMX274 sensor using the SELECTION API. v3 has a few minor improvements over v2. It also removes the first 6 patches, already applied on the media_tree master branch. After v2 there has been a short discussion with Sakari Ailus on how

[PATCH v3 2/7] media: imx274: consolidate per-mode data in imx274_frmfmt

Data about the implemented readout modes is partially stored in imx274_formats[], the rest is scattered in several arrays. The latter are then accessed using the mode index, e.g.: min_frame_len[priv->mode_index] Consolidate all these data in imx274_formats[], and store a pointer to the

[PATCH v3 6/7] media: imx274: add helper function to fill a reg_8 table chunk

Tables of struct reg_8 are used to simplify multi-byte register assignment. However filling these snippets with values computed at runtime is currently implemented by very similar functions doing the needed shift & mask manipulation. Replace all those functions with a unique helper function to

Re: [PATCH v14 06/36] media-request: Add support for updating request objects optimally

On 21/05/18 10:54, Sakari Ailus wrote: > Add a new request state (UPDATING) as well as a count for updating the > request objects. This way, several updates may take place simultaneously > without affecting each other. The drivers (as well as frameworks) still > must serialise access to their own

Re: [PATCH] media: uvcvideo: Support realtek's UVC 1.5 device

> > commit a9c002732695eab2096580a0d1a1687bc2f95928 > > Author: ming_qian > > Date: Wed May 9 10:13:08 2018 +0800 > > > > media: uvcvideo: Support UVC 1.5 video probe & commit controls > > > > The length of UVC 1.5 video control is 48, and it is 34 for UVC

Re: [PATCH 2/2] media: platform: add driver for TI SCAN921226H video deserializer

Hi Jan, Hans just pointed out a few issues in my video-mux compliance patch [1] that also apply to this driver, see below. [1] v1: https://patchwork.linuxtv.org/patch/49827/ v2: https://patchwork.linuxtv.org/patch/49839/ On Fri, 2018-05-04 at 14:49 +0200, Jan Luebbe wrote: [...] > diff

Re: [PATCH v3 03/12] media: ov5640: Remove the clocks registers initialization

Hi Maxime, On Tuesday, May 22, 2018 09:54 PM, Maxime Ripard wrote: On Mon, May 21, 2018 at 09:39:02AM +0200, Maxime Ripard wrote: On Fri, May 18, 2018 at 07:42:34PM -0700, Sam Bobrowicz wrote: This set of patches is also not working for my MIPI platform (mine has a 12 MHz external clock). I

Re: [PATCH] media: video-mux: fix compliance failures

On Wed, 2018-05-23 at 10:53 +0200, Hans Verkuil wrote: > On 23/05/18 10:47, Philipp Zabel wrote: > > Hi Hans, > > > > thank you for the review comments. > > > > On Tue, 2018-05-22 at 19:47 +0200, Hans Verkuil wrote: > > > On 22/05/18 18:29, Philipp Zabel wrote: > > > > Limit frame sizes to the

Re: [PATCH 0/6] Fix issues reported by static analysis tool.

Hi Pankaj, On Wed, May 23, 2018 at 10:51:30AM +0530, Pankaj Bharadiya wrote: > This patch series fixes some of the issues reported by static analysis > tool. > > Pankaj Bharadiya (6): > media: staging: atomisp: remove redundent check > media: staging: atomisp: Remove useless if statement >

[PATCH v2] media: video-mux: fix compliance failures

Limit frame sizes to the [1, 65536] interval, media bus formats to the available list of formats, and initialize pad and try formats. Reported-by: Rui Miguel Silva Signed-off-by: Philipp Zabel --- Changes since v1: - Limit to [1, 65536] instead of

Re: [PATCH v2] v4l: vsp1: Fix vsp1_regs.h license header

On Wed, May 23, 2018 at 11:37:47AM +0300, Laurent Pinchart wrote: > Hi Simon, > > On Wednesday, 23 May 2018 11:33:26 EEST Simon Horman wrote: > > On Tue, May 22, 2018 at 01:04:56PM +0200, Geert Uytterhoeven wrote: > > > On Tue, May 22, 2018 at 11:05 AM, Simon Horman wrote: >

Re: [PATCH] media: video-mux: fix compliance failures

On 23/05/18 10:47, Philipp Zabel wrote: > Hi Hans, > > thank you for the review comments. > > On Tue, 2018-05-22 at 19:47 +0200, Hans Verkuil wrote: >> On 22/05/18 18:29, Philipp Zabel wrote: >>> Limit frame sizes to the [1, UINT_MAX-1] interval, media bus formats to >>> the available list of

Re: [PATCH] media: dt-bindings: media: rcar_vin: add support for r8a77965

On Sun, May 13, 2018 at 08:58:18PM +0200, Niklas Söderlund wrote: > Signed-off-by: Niklas Söderlund Reviewed-by: Simon Horman > --- > Documentation/devicetree/bindings/media/rcar_vin.txt | 1 + > 1 file changed, 1 insertion(+)

Re: [PATCH] media: video-mux: fix compliance failures

Hi Hans, thank you for the review comments. On Tue, 2018-05-22 at 19:47 +0200, Hans Verkuil wrote: > On 22/05/18 18:29, Philipp Zabel wrote: > > Limit frame sizes to the [1, UINT_MAX-1] interval, media bus formats to > > the available list of formats, and initialize pad and try formats. > > > >

Re: [PATCH v2] v4l: vsp1: Fix vsp1_regs.h license header

Hi Simon, On Wednesday, 23 May 2018 11:33:26 EEST Simon Horman wrote: > On Tue, May 22, 2018 at 01:04:56PM +0200, Geert Uytterhoeven wrote: > > On Tue, May 22, 2018 at 11:05 AM, Simon Horman wrote: > >>> --- a/drivers/media/platform/vsp1/vsp1_regs.h > >>> +++

Re: [PATCH v2] v4l: vsp1: Fix vsp1_regs.h license header

On Tue, May 22, 2018 at 01:04:56PM +0200, Geert Uytterhoeven wrote: > Hi Simon, > > On Tue, May 22, 2018 at 11:05 AM, Simon Horman wrote: > >> --- a/drivers/media/platform/vsp1/vsp1_regs.h > >> +++ b/drivers/media/platform/vsp1/vsp1_regs.h > >> @@ -1,4 +1,4 @@ > >> -/*

Re: [PATCH v3] media: imx319: Add imx319 camera sensor driver

Hi Jacopo and Bingbu, On Tue, May 22, 2018 at 10:08:48PM +0200, jacopo mondi wrote: ... > > +/* Get bayer order based on flip setting. */ > > +static __u32 imx319_get_format_code(struct imx319 *imx319) > > +{ > > + /* > > +* Only one bayer order is supported. > > +* It depends on the

Re: [PATCH v3] media: imx319: Add imx319 camera sensor driver

On 2018年05月23日 04:08, jacopo mondi wrote: Hello Bingbu, thanks for the patch On Tue, May 22, 2018 at 12:33:01PM +0800, bingbu@intel.com wrote: From: Bingbu Cao Add a V4L2 sub-device driver for the Sony IMX319 image sensor. This is a camera sensor using the I2C