RE: [PATCH v4] nvdimm, btt: fix LBA masking during 'free list' population

2019-02-26 Thread Dexuan Cui
> From: Vishal Verma > Sent: Tuesday, February 26, 2019 3:14 PM > ... > diff --git a/drivers/nvdimm/btt.c b/drivers/nvdimm/btt.c > @@ -555,16 +555,21 @@ static int btt_freelist_init(struct arena_info *arena) > if (new < 0) > return new; > > + /*

Returned mail: Data format error

2019-02-26 Thread Returned mail
9]\F¦úÖE0¾Hí)T"ƒ¯zbö…8Z~úÌðàä×woؐ|ËGÏ¸ð†ÜË>˶ÔÛe ÷QÊ,VP‘’`Rùˆ‚5MÕZ{ç¤m­¼\_]Ä Ç’Øį><•Ýádu–÷PéDUíPì>Cž´è,V܂§èéÆ œFÁ¬—±s±/üÒ®õ ÚæÏûé¶mÚ Hº99¼Nyà&[¾S³ ñyYžJ8âEñӖk Yó邺C¹-`­Fc^sӆ4BõnºWÓr³âÅPj›œ†–7Š}d3_v~k-ɵµ}´0¸vˆ.oÚLJÁgHe—(Ñvê—J7ß÷D§&¬ÛOF-ÛlX¶W …

[PATCH v4] nvdimm, btt: fix LBA masking during 'free list' population

2019-02-26 Thread Vishal Verma
The Linux BTT implementation assumes that log entries will never have the 'zero' flag set, and indeed it never sets that flag for log entries itself. However, the UEFI spec is ambiguous on the exact format of the LBA field of a log entry, specifically as to whether it should include the

Re: [PATCH 2/2] nvdimm, btt: fix LBA masking during 'free list' population

2019-02-26 Thread Dan Williams
On Tue, Feb 26, 2019 at 2:52 PM Verma, Vishal L wrote: > > On Mon, 2019-02-25 at 22:48 +, Verma, Vishal L wrote: > > On Mon, 2019-02-25 at 15:43 -0700, Vishal Verma wrote: > > > The Linux BTT implementation assumes that log entries will never have > > > the 'zero' flag set, and indeed it

Re: [PATCH 2/2] nvdimm, btt: fix LBA masking during 'free list' population

2019-02-26 Thread Verma, Vishal L
On Mon, 2019-02-25 at 22:48 +, Verma, Vishal L wrote: > On Mon, 2019-02-25 at 15:43 -0700, Vishal Verma wrote: > > The Linux BTT implementation assumes that log entries will never have > > the 'zero' flag set, and indeed it never sets that flag for log entries > > itself. > > > > However, the

Re: [RFC v4 08/17] kunit: test: add support for test abort

2019-02-26 Thread Stephen Boyd
Quoting Brendan Higgins (2019-02-14 13:37:20) > Add support for aborting/bailing out of test cases. Needed for > implementing assertions. Can you add some more text here with the motivating reasons for implementing assertions and bailing out of test cases? For example, I wonder why unit tests

Re: find_get_entries_tag regression bisected

2019-02-26 Thread Matthew Wilcox
On Tue, Feb 26, 2019 at 04:08:21AM -0800, Matthew Wilcox wrote: > On Mon, Feb 25, 2019 at 09:03:00PM -0800, Dan Williams wrote: > > On Sat, Feb 16, 2019 at 1:11 PM Matthew Wilcox wrote: > > > > > > On Sat, Feb 16, 2019 at 09:29:48AM -0800, Matthew Wilcox wrote: > > > > On Sat, Feb 16, 2019 at

Re: find_get_entries_tag regression bisected

2019-02-26 Thread Matthew Wilcox
On Mon, Feb 25, 2019 at 09:03:00PM -0800, Dan Williams wrote: > On Sat, Feb 16, 2019 at 1:11 PM Matthew Wilcox wrote: > > > > On Sat, Feb 16, 2019 at 09:29:48AM -0800, Matthew Wilcox wrote: > > > On Sat, Feb 16, 2019 at 07:35:11AM -0800, Matthew Wilcox wrote: > > > > Another way to fix this would