Looks good,
Reviewed-by: Johannes Thumshirn
___
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-le...@lists.01.org
Looks good,
Reviewed-by: Johannes Thumshirn
___
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-le...@lists.01.org
Looks good,
Reviewed-by: Johannes Thumshirn
___
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-le...@lists.01.org
Looks good,
Reviewed-by: Johannes Thumshirn
___
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-le...@lists.01.org
Looks good,
Reviewed-by: Johannes Thumshirn
___
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-le...@lists.01.org
Looks good,
Reviewed-by: Johannes Thumshirn
___
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-le...@lists.01.org
Looks good,
Reviewed-by: Johannes Thumshirn
___
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-le...@lists.01.org
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs Filesystems
jthumsh...@suse.de+49 911 74053 689
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5
90409 Nürnberg
Germany
(HRB 36809, AG Nürnberg
looks good to me:
>> Reviewed-by: Vishal Verma
Another minor nit, the Subject says:
"bnvdimm/namsepace: Don't set claim_class on error"
a.k.a missing the 'li' part of libnvdimm
--
Johannes ThumshirnSUSE Labs Filesystems
jthumsh...@suse.de
Thanks,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs Filesystems
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg
On 12/09/2019 16:00, Jeff Moyer wrote:
> I'd rather avoid the churn and the risk of
> introducing regressions. This will also make backports to stable more
> of a pain, so it isn't without cost. Dan, is this really something you
> want to do?
I'm a 100% with Jeff on this!
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs Filesystems
jthumsh...@suse.de+49 911 74053 689
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5
90409 Nürnberg
Germany
(HRB 247165, AG München)
Key
_put_id:
ida_simple_remove(_region->btt_ida, nd_btt->id);
kfree(nd_btt);
return NULL;
}
--
Johannes ThumshirnSUSE Labs Filesystems
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F
[+CC dvyukov ]
On 20/02/2019 18:21, Johannes Thumshirn wrote:
> On 20/02/2019 17:15, Dan Williams wrote:> I wouldn't be opposed to
> syzkaller fuzzing the nvdimm-ioctl path.
> As a heads up, I've started adding the ioctl() definitions to syzcaller.
> Just so we don't duplicate a
On 20/02/2019 17:15, Dan Williams wrote:> I wouldn't be opposed to
syzkaller fuzzing the nvdimm-ioctl path.
As a heads up, I've started adding the ioctl() definitions to syzcaller.
Just so we don't duplicate any efforts.
Byte,
Johannes
--
Johannes Thumsh
annes this has end user / distro impact in that users may
> lose access to namespaces that are upgraded to v1.3 info-blocks and
> then boot an old kernel. I did not see a way around that sharp edge.
Oh sorry it was on my todo list and then I forgot about it again, I'll
give it a shot tomorrow
the bugs in a QA like environment than in the filed, I guess?
Byte,
Johannes
--
Johannes ThumshirnSUSE Labs Filesystems
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Sm
plication over interleave sets of NV-DIMMs.
And if you carve out a bit of your pmem space into an own namespace for
the metadata (did I understand you right here?) you still have the
problem that all data written to the DIMMs is interleaved in an
interleave set, if I understand i
, but they
are incompatible with DAX.
In this session Hannes and I would like to discuss eventual ways how we as an
operating system can mitigate these issues for our users.
Byte,
Johannes
--
Johannes ThumshirnSUSE Labs Filesystems
jthumsh...@suse.de
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs Filesystems
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs Filesystems
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
n XFS (but not EXT4) and we are supporting it for some limited
use-cases.
[1] https://lore.kernel.org/linux-fsdevel/20181002100531.gc4...@quack2.suse.cz/
Byte,
Johannes
--
Johannes ThumshirnSUSE Labs Filesystems
jthumsh...@suse.de+49 91
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
On Thu, Oct 04, 2018 at 11:25:24PM -0700, Christoph Hellwig wrote:
> Since when is an article on some website a promise (of what exactly)
> by linux kernel developers?
Let's stop it here, this doesn't make any sort of forward progress.
--
Johannes Thu
.net/Articles/684828/
Byte,
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
onal read(2)/write(2) interface
as well.
There is at least:
xfs_file_read_iter()
`-> if (IS_DAX(inode))
`-> xfs_file_dax_read()
`->dax_iomap_rw()
So IMHO something on an inode granularity would make more sens to me.
Byte,
Johannes
--
Johannes Thumshirn
t them to do it, it's more that they're actually
doing it in all kinds of interesting ways and then complaining when it
doesn't work anymore.
So it's less of an "API beauty price problem" but more of a "provide a
documented way which we won't break" way.
Byte,
Johan
On Tue, Oct 02, 2018 at 02:10:39PM +0200, Johannes Thumshirn wrote:
> On Tue, Oct 02, 2018 at 12:05:31PM +0200, Jan Kara wrote:
> > Hello,
> >
> > commit e1fb4a086495 "dax: remove VM_MIXEDMAP for fsdax and device dax" has
> > removed VM_MIXEDMAP flag
in inode::i_flags, so this should be doable
for both fsdax and devdax.
I haven't tried it yet but it should be fairly easy to come up with
something like this.
Byte,
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
hing as the LSS Latch stuff that went into ndctl?
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Woo no more ndctl create-namepsace -fe ... dances.
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
nto scsi and nvme now.
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC3
On Thu, Jul 05, 2018 at 07:46:05AM -0700, Dan Williams wrote:
> ...but that also allows 'echo "syncAndThenSomeGarbage" >
> /sys/.../memmap_state' to succeed.
Yep it does :-(.
Damn
--
Johannes Thumshirn Storage
if (strncmp(buf, "sync", 4))
return -EINVAL;
This collapses 6 lines into 4.
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Fel
()
function.
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
---
include/linux/nd.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/include/linux/nd.h b/include/linux/nd.h
index 5dc6b695437d..43c181a6add5 100644
--- a/include/linux/nd.h
+++ b/include/linux/nd.h
@@ -180,6 +
Use module_nd_driver() instead of having module_init() and
module_exit() callbacks which just call nd_driver_register() and
nd_driver_unregister().
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
---
drivers/nvdimm/pmem.c | 12 +---
1 file changed, 1 insertion(+), 11 del
(u64) s);
> >
> > I don't think you should remove this one. dev_info_once() is just a
> > printk(),
> > and doesn't inherit the +f flag from the dynamic debugging code. The
> > __func__
> > here does add value.
> >
> > The rest of these look correct, th
Looks good,
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard,
lly.
Sorry for the late response, I was some days off.
Thanks Dan,
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smi
:
[ 2391.935383] acpi_nfit_ctl: nfit ACPI0012:00: acpi_nfit_ctl:nmem8 cmd: 10:
func: 1 input length: 0
Thus remove the stray __func__ printing.
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
---
drivers/acpi/nfit/core.c | 75 +++-
1 file chang
On Mon, Oct 09, 2017 at 08:45:41AM -0700, Dan Williams wrote:
> On Mon, Oct 9, 2017 at 1:07 AM, Johannes Thumshirn <jthumsh...@suse.de> wrote:
> > On Sat, Oct 07, 2017 at 08:14:42AM -0700, Dan Williams wrote:
> > [...]
> >
> >> +rxe_cfg stop
> >> +rxe_
Acked-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Nort
ding eth0 might be problematic in this case. This works
on your test-setup but surely isn't portable.
Byte,
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90
Looks good,
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard,
mean we lose the tests for when an attribute is missing due to an
> incomplete backport.
Of cause, but all we loose is a group of testcases to be run and this can be
an indication of a bad backport as well, so I think this is quite helpful.
Byte,
Johannes
--
Joh
customers being able
to run the test-suite to verify their kernel is working properly.
[1] http://blog.ffwll.ch/2013/11/botching-up-ioctls.html
Byte,
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 91
available, not on a kernel version. We did discuss this a while ago.
> Let me go dig it up...
> https://lists.01.org/pipermail/linux-nvdimm/2017-March/009253.html
>
> We never came to any real conclusion on a good way forward, though.
I think I already said this before [1
Looks good,
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard,
ux-kernel=150175029403913=2
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC
On Tue, Aug 01, 2017 at 10:43:30AM -0700, Dan Williams wrote:
> On Tue, Aug 1, 2017 at 12:34 AM, Johannes Thumshirn <jthumsh...@suse.de>
> wrote:
> > Dave Jiang <dave.ji...@intel.com> writes:
> >
> >> Adding DMA support for pmem blk reads. This provides s
en = blk_rq_payload_bytes(req);
> + page = virt_to_page(pmem_addr);
> + off = (u64)pmem_addr & ~PAGE_MASK;
off = offset_in_page(pmem_addr); ?
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
Toshi,
can you please keep me on Cc for the thread and possible patches? I'd be
willing to play test monkey as well.
Byte,
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH
If you can't rely
on old kernels rejecting the new flags/modes or ioctls (since doing
that was botched in the past) then you need a driver feature flag or
revision number somewhere."
[1] http://blog.ffwll.ch/2013/11/botching-up-ioctls.html
Byte,
Johannes
--
Johannes Thumshirn
Jiang <dave.ji...@intel.com>
> ---
Thanks,
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnbe
ght, I just looked at the 'if (nd_btt || nd_pfn || nd_dax)' and
then missed out the *->ndns assignments.
Thanks,
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 904
ve.ji...@intel.com>
> ---
Thanks,
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Fe
= nd_btt->ndns;
else if (nd_pfn)
ndns = nd_pfn->ndns;
else if (nd_dax)
ndns = nd_dax->nd_pfn.ndns;
else
ndns = to_ndns(dev);
> + } else
> + ndns = to_ndns(dev);
> +
Thanks,
Johannes
--
On 03/06/2017 09:32 PM, Dave Jiang wrote:
> Adding sysfs attribute in order to export the physical address of the
> ND region. This is for supporting of user app poison clear via
> device dax.
>
> Signed-off-by: Dave Jiang <dave.ji...@intel.com>
> ---
Reviewed-by: Joh
-by: Dave Jiang <dave.ji...@intel.com>
> ---
Otherwise looks good to me,
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH,
t of modinfo.
>
> Signed-off-by: Linda Knippers <linda.knipp...@hpe.com>
> ---
Thanks,
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE
@hpe.com>
> ---
Looks good to me,
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörff
>
> Signed-off-by: Logan Gunthorpe <log...@deltatee.com>
> Reviewed-by: Dan Williams <dan.j.willi...@intel.com>
> ---
Looks good,
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@
ger.kernel.org>
> Reported-by: Jason Gunthorpe <jguntho...@obsidianresearch.com>
> Signed-off-by: Dan Williams <dan.j.willi...@intel.com>
> Signed-off-by: Logan Gunthorpe <log...@deltatee.com>
> ---
Looks good,
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
for
> namespaceX.0 if the seed has already advanced to another namespace.
>
> Cc: <sta...@vger.kernel.org>
> Fixes: 98a29c39dc68 ("libnvdimm, namespace: allow creation of multiple
> pmem-namespaces per region")
> Signed-off-by: Dan Williams <dan.j.willi...@intel.
x unit tests.
>
> Reported-by: Johannes Thumshirn <jthumsh...@suse.de>
> Signed-off-by: Dan Williams <dan.j.willi...@intel.com>
> ---
Thanks Dan,
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn
data pointer for the hosting device of a dax_region. Add a
> clarification.
>
> Reported-by: Johannes Thumshirn <jthumsh...@suse.de>
> Signed-off-by: Dan Williams <dan.j.willi...@intel.com>
> ---
Looks good,
Reviewed-by: Johannes Thumshirn <j
> dax_do_io and some uneeded i_flags manipulations introduced in commit
> bbab37 ("block: Add support for DAX reads/writes to block devices").
>
> Remove those leftovers.
>
> Signed-off-by: Christoph Hellwig <h...@lst.de>
> ---
Reviewed-b
n_object *jhealth;
>
> jhealth = util_dimm_health_to_json(dimm);
> + if (!jhealth)
> + jhealth =
> util_hpe_dimm_health_to_json(dimm);
Try and error probing for the correct vendor? There surely must be
brian.boyls...@hpe.com>
> Signed-off-by: Toshi Kani <toshi.k...@hpe.com>
> Cc: Dan Williams <dan.j.willi...@intel.com>
Tested-by: Johannes Thumshirn <jthumsh...@suse.de>
Acked-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshir
If either device_register() or nvdimm_bus_create_ndclt() fails we leak the
memory allocated for nvdimm_bus. Call kfree(nvdimm_bus) in the error path so
it's not leaked.
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
---
drivers/nvdimm/core.c | 1 +
1 file changed, 1 insertion(+)
e work twice.
I've pasted my current work to export HPE DIMM commands at the bottom of the
mail, but I don't like it very much (see below for a proposal of a more
elegant way).
>
> On 7/27/2016 6:35 AM, Johannes Thumshirn wrote:
> > Hi Dan and Jerry,
> >
> > I'm current
t; Linux-nvdimm@lists.01.org
> https://lists.01.org/mailman/listinfo/linux-nvdimm
Hi Dan,
Somehow the mailinglist dropped the patch attachment and patchwork didn't
pick it up either.
As you have a Tested-by by Jerry and Xiao, can you appliy it to your git so
downstream distros can pick
lemented in radix-tree.h.
>
> So, fix the comment.
>
> Signed-off-by: Ross Zwisler <ross.zwis...@linux.intel.com>
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de
el.com>
> Reported-by: Linda Knippers <linda.knipp...@hpe.com>
> Signed-off-by: Dan Williams <dan.j.willi...@intel.com>
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de
been already called by the helper if there was any error.
>
> Reported-by: Sudip Mukherjee <sudipm.mukher...@gmail.com>
> Signed-off-by: Vikas C Sajjan <vikas.cha.saj...@hpe.com>
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn
ed
[ 2738.166872] libndctl: ndctl_unref: context 0x1ae43d0 released
[ 2738.166910] test-libndctl: FAIL
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Im
80 matches
Mail list logo
