Re: [PATCH 08/18] dax: memcpy page in case of IOMAP_DAX_COW for mmap faults

2019-05-23 Thread Jan Kara
On Tue 21-05-19 10:46:25, Darrick J. Wong wrote: > On Mon, Apr 29, 2019 at 12:26:39PM -0500, Goldwyn Rodrigues wrote: > > From: Goldwyn Rodrigues > > > > Change dax_iomap_pfn to return the address as well in order to > > use it for performing a memcpy in case the type is IOMAP_DAX_COW. > > We

Re: [PATCH 08/18] dax: memcpy page in case of IOMAP_DAX_COW for mmap faults

2019-05-22 Thread Darrick J. Wong
On Wed, May 22, 2019 at 02:11:39PM -0500, Goldwyn Rodrigues wrote: > On 10:46 21/05, Darrick J. Wong wrote: > > On Mon, Apr 29, 2019 at 12:26:39PM -0500, Goldwyn Rodrigues wrote: > > > From: Goldwyn Rodrigues > > > > > > Change dax_iomap_pfn to return the address as well in order to > > > use it

Re: [PATCH 08/18] dax: memcpy page in case of IOMAP_DAX_COW for mmap faults

2019-05-22 Thread Goldwyn Rodrigues
On 10:46 21/05, Darrick J. Wong wrote: > On Mon, Apr 29, 2019 at 12:26:39PM -0500, Goldwyn Rodrigues wrote: > > From: Goldwyn Rodrigues > > > > Change dax_iomap_pfn to return the address as well in order to > > use it for performing a memcpy in case the type is IOMAP_DAX_COW. > > We don't handle

Re: [PATCH 08/18] dax: memcpy page in case of IOMAP_DAX_COW for mmap faults

2019-05-21 Thread Darrick J. Wong
On Mon, Apr 29, 2019 at 12:26:39PM -0500, Goldwyn Rodrigues wrote: > From: Goldwyn Rodrigues > > Change dax_iomap_pfn to return the address as well in order to > use it for performing a memcpy in case the type is IOMAP_DAX_COW. > We don't handle PMD because btrfs does not support hugepages. > >

[PATCH 08/18] dax: memcpy page in case of IOMAP_DAX_COW for mmap faults

2019-04-29 Thread Goldwyn Rodrigues
From: Goldwyn Rodrigues Change dax_iomap_pfn to return the address as well in order to use it for performing a memcpy in case the type is IOMAP_DAX_COW. We don't handle PMD because btrfs does not support hugepages. Question: The sequence of bdev_dax_pgoff() and dax_direct_access() is used

Re: [PATCH 08/18] dax: memcpy page in case of IOMAP_DAX_COW for mmap faults

2019-04-17 Thread Darrick J. Wong
On Tue, Apr 16, 2019 at 11:41:44AM -0500, Goldwyn Rodrigues wrote: > From: Goldwyn Rodrigues > > Change dax_iomap_pfn to return the address as well in order to > use it for performing a memcpy in case the type is IOMAP_DAX_COW. > > Question: > The sequence of bdev_dax_pgoff() and

[PATCH 08/18] dax: memcpy page in case of IOMAP_DAX_COW for mmap faults

2019-04-16 Thread Goldwyn Rodrigues
From: Goldwyn Rodrigues Change dax_iomap_pfn to return the address as well in order to use it for performing a memcpy in case the type is IOMAP_DAX_COW. Question: The sequence of bdev_dax_pgoff() and dax_direct_access() is used multiple times to calculate address and pfn's. Would it make sense