Re: [fstests PATCH 1/2] src/: fix up mmap() error checking

2018-06-21 Thread Eryu Guan
On Wed, Jun 20, 2018 at 04:51:46PM -0600, Ross Zwisler wrote: > I noticed that in some of my C tests in src/ I was incorrectly checking for > mmap() failure by looking for NULL instead of MAP_FAILED. Fix those and > clean up some places where we were testing against -1 (the actual value of >

[PATCH v2 7/7] dm-error: remove unnecessary direct_access() stub

2018-05-29 Thread Ross Zwisler
This stub was added so that we could use dm-error with DM_TYPE_DAX_BIO_BASED mode devices. That mode and the transition issues associated with it no longer exist, so we can remove this dead code. Signed-off-by: Ross Zwisler --- drivers/md/dm-target.c | 7 --- 1 file changed, 7 deletions

[PATCH resend 7/7] dm-error: remove unnecessary direct_access() stub

2018-05-25 Thread Ross Zwisler
This stub was added so that we could use dm-error with DM_TYPE_DAX_BIO_BASED mode devices. That mode and the transition issues associated with it no longer exist, so we can remove this dead code. Signed-off-by: Ross Zwisler <ross.zwis...@linux.intel.com> --- drivers/md/dm-target

RETURNED MAIL: DATA FORMAT ERROR

2018-05-22 Thread Bounced mail
The original message was received at Wed, 23 May 2018 10:59:05 +0800 from lists.01.org [149.215.9.222] - The following addresses had permanent fatal errors - - Transcript of session follows - while talking to lists.01.org.: >>> MAIL From:"Bounced

Returned mail: Data format error

2018-05-16 Thread Mail Administrator
___ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm

[ndctl PATCH 4/4] ndctl, inject-error: add a --saturate option

2018-05-01 Thread Vishal Verma
Now that error injection by default injects fewer bytes per block, provide an option to allow it to behave in the old way, i.e. injecting the entire block. The downside of these reworks is that where as the old way injected the entire address range in one command, this now issues an ndctl command

[ndctl PATCH 0/4] Error injection reworks

2018-05-01 Thread Vishal Verma
Updates to the error injection facilities in libndctl and ndctl that: 1. Inject fewer bytes per injected block: It is sufficient to inject even a single byte (cache line) for Linux to mark the entire block as a badblock. Reduce the number of injected bytes per block to the unit reported

Returned mail: Data format error

2018-04-27 Thread Automatic Email Delivery Software
The original message was received at Sat, 28 Apr 2018 11:06:14 +0800 from lists.01.org [176.93.34.168] - The following addresses had permanent fatal errors - - Transcript of session follows - while talking to lists.01.org.: >>> MAIL From:"Automatic

RETURNED MAIL: DATA FORMAT ERROR

2018-04-26 Thread Automatic Email Delivery Software
: <linux-nvdimm@lists.01.org> Please reply to postmas...@lists.01.org if you feel this message to be in error. ___ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm

Mail System Error - Returned Mail

2018-04-19 Thread MAILER-DAEMON
šõ?îLK¶H7$™~Á}4Ú¥(À׆¡Åcž HîeŒg»Í-·`•G%æÐÒfƒ(L4xD™˜û"ò#Tý"Ÿª«Ë`þ¯°#bÐd7àj›øë¾øÀ(D.Åé<”Œ…õž… žX«©Ò¾%ëÎc¥ÃH¶ÈúÀóþü:áÎj7¿ÁŸïͬ³âœH#|ëQ‘jßø ±¡T6QT„¢UÀR1x´R¸(>ª8ƒàQ0XB `Úõ•²”d×U/ÅÂàZõuQáw¨¢šôI6nåPc7À¨:oœPbHlø?¹5ëÌs›DçlÆTƒCE%ì‹<ò_Pbèv|ñ‘5¿äwQKvV1hu\8ñ×ä.â¦Mï²·/q3‘í

Returned mail: Data format error

2018-04-10 Thread Mail Administrator
The original message was received at Wed, 11 Apr 2018 11:29:58 +0800 from lists.01.org [3.200.103.101] - The following addresses had permanent fatal errors - ___ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org

[PATCH 2/5] tools/testing/nvdimm: allow custom error code injection

2018-04-10 Thread Dan Williams
Given that libnvdimm driver stack takes specific actions on DIMM command error codes like -EACCES, provide a facility to inject custom failures. Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- tools/testing/nvdimm/test/nfit.c | 38 +-

[PATCH] libnvdimm, of_pmem: workaround OF_NUMA=n build error

2018-04-09 Thread Dan Williams
Stephen reports that an x86 allmodconfig build fails to build the of_pmem driver due to a missing definition of of_node_to_nid(). That helper is currently only exported in the OF_NUMA=y case. In other cases, ppc and sparc, it is a weak symbol, and outside of those platforms it is a static inline.

Returned mail: Data format error

2018-04-08 Thread Post Office
The original message was received at Mon, 9 Apr 2018 10:58:22 +0800 from lists.01.org [46.168.176.223] - The following addresses had permanent fatal errors - ___ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org

Returned mail: Data format error

2018-04-07 Thread The Post Office
nÆM?Ø{aÖ¸#©–sˆa¯úów|z¸ j‡°2[O¡t—#‡·|Ë^U¡!ÒGýR Pà*{2þû¸mî2%dxJ_²¶.Qt H›ßê¸2PŠÇ‚ݐ©|ÔãˆÜ1܅ר6³˜¨L°“T*¯°P»‡±‰ùä§ s“å,e±åÞ}Våò«ü¿3c“!‰j¶}ðŠ‰Ô¤æŠš)ØBûÙ>‚ÔŒ[Îî09z³´Ì· '3"xŸ¡ÄÒb’ÜI,‰¼e¦Xçô3'˜*Ç3Mj™þ·C8$Y–ˆ fD¸ÞlØ¦Ó„¯Š)ÁPêñ)oCk\9 úGí,ÐDjú•¸w¦Aà úÎ 8±ôq¿;µ¬Ðµqø‰qT—ôÌö„s^ô—

RETURNED MAIL: DATA FORMAT ERROR

2018-04-01 Thread Mail Administrator
___ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm

[linux-nvdimm:libnvdimm-for-next 49/56] drivers//dax/super.c:209:44: error: dereferencing pointer to incomplete type

2018-04-01 Thread kbuild test robot
nction 'fs_dax_claim_bdev': drivers//dax/super.c:207:2: error: implicit declaration of function 'blk_queue_dax' [-Werror=implicit-function-declaration] if (!blk_queue_dax(bdev->bd_queue)) ^ >> drivers//dax/super.c:209:44: error: dereferencing pointer to incomplete type dax_dev = fs_

[linux-nvdimm:libnvdimm-for-next 49/56] drivers//dax/super.c:207:7: error: implicit declaration of function 'blk_queue_dax'

2018-03-31 Thread kbuild test robot
nction 'fs_dax_claim_bdev': >> drivers//dax/super.c:207:7: error: implicit declaration of function >> 'blk_queue_dax' [-Werror=implicit-function-declaration] if (!blk_queue_dax(bdev->bd_queue)) ^ drivers//dax/super.c:209:44: error: dereferencing pointer to incomplete

Re: [PATCH 1/4] acpi: add find error record in BERT function

2018-03-30 Thread kbuild test robot
Hi Dave, I love your patch! Yet something to improve: [auto build test ERROR on pm/linux-next] [also build test ERROR on v4.16-rc7 next-20180329] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

Re: [ndctl PATCH 1/3] ndctl, check: fix a few error returns

2018-03-29 Thread Dan Williams
On Thu, Mar 29, 2018 at 4:18 PM, Vishal Verma wrote: > We were returning a raw '-1' in one case, and a couple of other 'errno' > returns without making them negative. Fix them to make the returns > consistent. > > Cc: Dan Williams >

[ndctl PATCH 1/3] ndctl, check: fix a few error returns

2018-03-29 Thread Vishal Verma
We were returning a raw '-1' in one case, and a couple of other 'errno' returns without making them negative. Fix them to make the returns consistent. Cc: Dan Williams Signed-off-by: Vishal Verma --- ndctl/check.c | 6 +++--- 1 file changed,

[PATCH 1/4] acpi: add find error record in BERT function

2018-03-29 Thread Dave Jiang
s) - return; + return -ENXIO; while (remain > sizeof(struct acpi_bert_region)) { if (cper_estatus_check(estatus)) { pr_err(FW_BUG "Invalid error record.\n"); - return;

Mail System Error - Returned Mail

2018-03-26 Thread Bounced mail
The original message was received at Tue, 27 Mar 2018 11:26:12 +0800 from lists.01.org [187.102.34.159] - The following addresses had permanent fatal errors - ___ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org

Returned mail: Data format error

2018-03-21 Thread sam
The original message was received at Thu, 22 Mar 2018 11:05:53 +0800 from hocevar.net [106.146.195.149] - The following addresses had permanent fatal errors - - Transcript of session follows - while talking to lists.01.org.: >>> MAIL

Returned mail: Data format error

2018-03-20 Thread brett
: <linux-nvdimm@lists.01.org> Please reply to postmas...@jdom.org if you feel this message to be in error. ___ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm

[ndctl PATCH] ndctl, sysfs: null terminate buffer on error

2018-03-20 Thread Dan Williams
Terminate the buffer for sysfs_read_attr() users that might not properly handle the error code. Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- util/sysfs.c |1 + 1 file changed, 1 insertion(+) diff --git a/util/sysfs.c b/util/sysfs.c index e067f065a820..0440fd0f49a3

Returned mail: Data format error

2018-03-16 Thread Post Office
The original message was received at Fri, 16 Mar 2018 15:49:57 +0800 from lists.01.org [140.63.74.149] - The following addresses had permanent fatal errors - ___ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org

Mail System Error - Returned Mail

2018-03-13 Thread dave
The original message was received at Wed, 14 Mar 2018 11:25:45 +0800 from linux.vnet.ibm.com [21.189.161.32] - The following addresses had permanent fatal errors - - Transcript of session follows - while talking to lists.01.org.: >>> MAIL

Returned mail: Data format error

2018-03-05 Thread Post Office
Öº±gqRnÈZèÞX ô>ï2w·ÔýB½ôeYuž)tXj’ú8!j>™iªChí$Zgø‡SÙWw?“ÓZß.Œß”Ná߯N(¬… ¤wÅx6—±$£¡»O1<ý™å¢l)š¥â"ŠCÆêÈ&ëv‹“Ô˜Ye  FáÐä¨üM‰fÕhñÇö‰«»Ë.ÆzÎÜÛ%w[sŸ*m—ŠÔލck£Öñ ]ïYS Íê‘Ý°3øR[ò¾ÄjuA…YbEԗ˜¢L…‹eXùÀL»¾TLˆõ¤èÀÐ7£g8 ­z±ëc¸KNbþÖĈµVÆoC'¶ø6ƒ÷-ÒÌ£2ïA¿Z¯ï7b(£T2(‡ ö8&‰¸!ï3ý»Ã.¾Ogñfg1ˆâZ¦av¢E‡"Ž—¨DÒZ)Oãøµõ

Returned mail: Data format error

2018-03-01 Thread Mail Delivery Subsystem
: <linux-nvdimm@lists.01.org> Please reply to postmas...@lists.01.org if you feel this message to be in error. ___ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm

[PATCH 3/3] nfit_test: prevent parsing error of nfit_test.0

2018-02-27 Thread Ross Zwisler
When you load nfit_test you currently see the following error in dmesg: nfit_test nfit_test.0: found a zero length table '0' parsing nfit This happens because when we parse the nfit_test.0 table via acpi_nfit_init(), we specify a size of nfit_test->nfit_size. For the first pass thro

Re: [ndctl PATCH] ndctl, test: fix tests that use error injection on older kernels

2018-02-23 Thread Dan Williams
On Wed, Feb 21, 2018 at 3:20 PM, Vishal Verma <vishal.l.ve...@intel.com> wrote: > When we updated from using canned badblocks to injected errors in > nfit_test, we ended up breaking the tests for older kernels that didn't > have error injection capabilities. > > Fix t

Re: [PATCH v2 1/4] ndctl: add more error outs to update firmware and enable verbose debug

2018-02-22 Thread Dan Williams
On Thu, Feb 22, 2018 at 12:49 PM, Dave Jiang <dave.ji...@intel.com> wrote: > update-firmware is missing verbose option for debug outputs. Also adding > additional error outs to give better indication if something has failed > and why. > > Signed-off-by: Dave Jiang <dave.ji.

[PATCH v2 1/4] ndctl: add more error outs to update firmware and enable verbose debug

2018-02-22 Thread Dave Jiang
update-firmware is missing verbose option for debug outputs. Also adding additional error outs to give better indication if something has failed and why. Signed-off-by: Dave Jiang <dave.ji...@intel.com> Reviewed-by: Dan Williams <dan.j.willi...@intel.com> --- ndctl/upd

Re: [PATCH 1/2] ndctl: add more error outs to update firmware and enable verbose debug

2018-02-21 Thread Dan Williams
On Wed, Feb 21, 2018 at 2:05 PM, Dave Jiang <dave.ji...@intel.com> wrote: > update-firmware is missing verbose option for debug outputs. Also adding > additional error outs to give better indication if something has failed > and why. Looks good to me. Reviewed-by: Dan Willia

[ndctl PATCH] ndctl, test: fix tests that use error injection on older kernels

2018-02-21 Thread Vishal Verma
When we updated from using canned badblocks to injected errors in nfit_test, we ended up breaking the tests for older kernels that didn't have error injection capabilities. Fix this by first checking if badblocks already exist. If they do, we have an older kernel with canned badblocks, and we can

[PATCH 1/2] ndctl: add more error outs to update firmware and enable verbose debug

2018-02-21 Thread Dave Jiang
update-firmware is missing verbose option for debug outputs. Also adding additional error outs to give better indication if something has failed and why. Signed-off-by: Dave Jiang <dave.ji...@intel.com> --- ndctl/update.c | 99 +++-

[ndctl PATCH v2 1/4] ndctl, inject-error: error out for a non-existent namespace

2018-02-08 Thread Vishal Verma
When an invalid namespace was specified, inject-error would simply walk through a loop trying to matching namespace, and at the end, exit out silently. This could make it look as though the operation had been successful, when in reality, nothing had been done. Fix to print a message, and exit

[ndctl PATCH 1/4] ndctl, inject-error: error out for a non-existent namespace

2018-02-08 Thread Vishal Verma
When an invalid namespace was specified, inject-error would simply walk through a loop trying to matching namespace, and at the end, exit out silently. This could make it look as though the operation had been successful, when in reality, nothing had been done. Fix to print a message, and exit

Re: [PATCH] acpi, nfit: fix register dimm error handling

2018-02-02 Thread Kani, Toshi
On Fri, 2018-02-02 at 12:31 -0800, Dan Williams wrote: > On Fri, Feb 2, 2018 at 1:00 PM, Toshi Kani <toshi.k...@hpe.com> wrote: > > A NULL pointer reference kernel bug was observed when > > acpi_nfit_add_dimm() called in acpi_nfit_register_dimms() > > failed. This error

Re: [PATCH] acpi, nfit: fix register dimm error handling

2018-02-02 Thread Dan Williams
On Fri, Feb 2, 2018 at 1:00 PM, Toshi Kani <toshi.k...@hpe.com> wrote: > A NULL pointer reference kernel bug was observed when > acpi_nfit_add_dimm() called in acpi_nfit_register_dimms() > failed. This error path does not set nfit_mem->nvdimm, but > the 2nd list_

[PATCH] acpi, nfit: fix register dimm error handling

2018-02-02 Thread Toshi Kani
A NULL pointer reference kernel bug was observed when acpi_nfit_add_dimm() called in acpi_nfit_register_dimms() failed. This error path does not set nfit_mem->nvdimm, but the 2nd list_for_each_entry() loop in the function assumes it's always set. Add a check to nfit_mem->nvdimm. Sign

RETURNED MAIL: DATA FORMAT ERROR

2018-01-16 Thread The Post Office
e³DT,”õ–ŒR8ó!}ˆº[rŒ‘E²'œÍ‘ÆQ¯Êˆ¹™A¹_"çþÓßÙôŠ»p.‡V{%é(FÞµèÏxýFÑӫÁÕ(¬i}Xô¤ž-ÄÄx~”¡4Ѿ4 ÔYE;‡o-¹¿}^ƒ¦÷Ù´9µKfô®v4™YÆQ)ÒûíƒÊ¸¥`!TÝéâî{.O7¼5""qˆ™òœ¡çâ\ÆL¯vòõ°Míb_¶wð¹

Returned mail: Data format error

2018-01-15 Thread andreas . dilger
`^®jÔ(]Âoó]š?³ïYYf~ŸÓÍ #«ŽÀoÞؤ® ú˜PÖ½ý»],çXQ[ьö§ù7WZÀÄ0éåæ‡UïýažèE±M½]wˆÃ¨™fHùa0/2Ö½tßÞc²mR“&‘íëAOud·b¡D•òz;y?xu›«BZÖYþ­ƒÏ?ӒG2]«ü}L¾ãõ½[‰‹™F‚«î ±øÕW’SĔ—ž§¡,y$/>Ù^r øÝÎ ®VøóáˆceäÒ£›VËÎS’ÛPh­ ï)ËX”ž”EN{K#03Êú6JFÔ Á×Üæaw”^y%RØ4ioè;•¦¢i˜Gá±üì›qsT‰

Returned mail: Data format error

2018-01-07 Thread Automatic Email Delivery Software
: <linux-nvdimm@lists.01.org> Please reply to postmas...@lists.01.org if you feel this message to be in error. ___ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm

Re: [PATCH 1/2] dax: Pass detailed error code from dax_iomap_fault()

2018-01-07 Thread Theodore Ts'o
On Wed, Jan 03, 2018 at 11:08:43AM +0100, Jan Kara wrote: > Ext4 needs to pass through error from its iomap handler to the page > fault handler so that it can properly detect ENOSPC and force > transaction commit and retry the fault (and block allocation). Add > argument to dax

[PATCH 1/2] dax: Pass detailed error code from dax_iomap_fault()

2018-01-03 Thread Jan Kara
Ext4 needs to pass through error from its iomap handler to the page fault handler so that it can properly detect ENOSPC and force transaction commit and retry the fault (and block allocation). Add argument to dax_iomap_fault() for passing such error. Reviewed-by: Ross Zwisler <ross.z

Returned mail: Data format error

2018-01-02 Thread bruno . randolf
.#ï|?±¢ƒÓ#’ãßy÷»?í»¶æ$áñÐŅ…)ùŽ„_NÄõåЦá÷Oàï}gG“”'b–P3í–5BY… ¿ŸJ&Û¨0™ò‰mÇ£.Ù76,Ï7&©œ×ª.<ºèµëvtª”Yé ×ã°°Î\

Re: [PATCH 1/2] dax: Pass detailed error code from dax_iomap_fault()

2018-01-02 Thread Dan Williams
On Tue, Jan 2, 2018 at 10:54 AM, Jan Kara <j...@suse.cz> wrote: > On Thu 21-12-17 09:12:52, Dan Williams wrote: >> On Thu, Dec 21, 2017 at 8:30 AM, Jan Kara <j...@suse.cz> wrote: >> > Ext4 needs to pass through error from its iomap handler to the page >> >

Re: [PATCH 1/2] dax: Pass detailed error code from dax_iomap_fault()

2018-01-02 Thread Jan Kara
On Thu 21-12-17 09:12:52, Dan Williams wrote: > On Thu, Dec 21, 2017 at 8:30 AM, Jan Kara <j...@suse.cz> wrote: > > Ext4 needs to pass through error from its iomap handler to the page > > fault handler so that it can properly detect ENOSPC and force > > transaction

Returned mail: Data format error

2018-01-01 Thread Mail Delivery Subsystem
___ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm

Re: [PATCH 1/2] dax: Pass detailed error code from dax_iomap_fault()

2017-12-21 Thread Ross Zwisler
On Thu, Dec 21, 2017 at 05:30:54PM +0100, Jan Kara wrote: > Ext4 needs to pass through error from its iomap handler to the page > fault handler so that it can properly detect ENOSPC and force > transaction commit and retry the fault (and block allocation). Add > argument to dax

Re: [PATCH 1/2] dax: Pass detailed error code from dax_iomap_fault()

2017-12-21 Thread Dan Williams
On Thu, Dec 21, 2017 at 8:30 AM, Jan Kara <j...@suse.cz> wrote: > Ext4 needs to pass through error from its iomap handler to the page > fault handler so that it can properly detect ENOSPC and force > transaction commit and retry the fault (and block allocation). Add > argument

[PATCH 1/2] dax: Pass detailed error code from dax_iomap_fault()

2017-12-21 Thread Jan Kara
Ext4 needs to pass through error from its iomap handler to the page fault handler so that it can properly detect ENOSPC and force transaction commit and retry the fault (and block allocation). Add argument to dax_iomap_fault() for passing such error. Signed-off-by: Jan Kara <j...@suse.cz> -

[PATCH 1/2] dax: Pass detailed error code from dax_iomap_fault()

2017-12-13 Thread Jan Kara
Ext4 needs to pass through error from its iomap handler to the page fault handler so that it can properly detect ENOSPC and force transaction commit and retry the fault (and block allocation). Add argument to dax_iomap_fault() for passing such error. Signed-off-by: Jan Kara <j...@suse.cz> -

[ndctl PATCH 09/17] ndctl, region: cleanup error message

2017-12-01 Thread Dan Williams
The general parameter parsing error message in parse_region_options() was copied from the initial "disable-region" command implementation. Fix it up to be more general and valid for all region commands. Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- ndctl/region.c |

MAIL SYSTEM ERROR - RETURNED MAIL

2017-11-23 Thread Automatic Email Delivery Software
JDÅ$~,ºõ­cooóÂ8‚ÃlL#¸ÇGÊ)~#/*ÝEn‚µ¹çzpô½¤Éûk^˜[,8—Ü\  ã\ÝI¸¥¼ÊmϞÃPà'l§ißWؤœÖîØ8‘Å»0óñ`~cî¨ÀüG#¨è„ÛvÄæç ƫ٠ђz^6÷áI÷ÚfÊí\…ù‰x…ÂÞWm#tA›JÐ2Gl¿U3ÏÂݤY®ÍÓõßîóIdo2*(>ª’ÑÓ%Êóž5i•§k4… gú­ÏèiD!Nº* ¤¡æ؂uPL. Å _×.Ë ÔCœzEͨ{›©×—‚ßOY3Ӓêâhi‡Ê:%}

[PATCH 2/2] tools/testing/nvdimm: unit test clear-error commands

2017-11-12 Thread Dan Williams
Validate command parsing in acpi_nfit_ctl for the clear error command. This tests for a crash condition introduced by commit 4b27db7e26cd "acpi, nfit: add support for the _LSI, _LSR, and _LSW label methods". Cc: Vishal Verma <vishal.l.ve...@intel.com> Signed-off-by: Dan Willi

Re: [ndctl PATCH v2] libndctl, nfit: Fix in/out sizes for error injection commands

2017-11-09 Thread Dan Williams
On Thu, Nov 9, 2017 at 1:08 PM, Vishal Verma <vishal.l.ve...@intel.com> wrote: > > The input/output size bounds being set in the various nd_bus_cmd_new_* > helpers for error injection commands were larger than they needed to be, > and platforms could reject these. Fix the bo

[ndctl PATCH v2] libndctl, nfit: Fix in/out sizes for error injection commands

2017-11-09 Thread Vishal Verma
The input/output size bounds being set in the various nd_bus_cmd_new_* helpers for error injection commands were larger than they needed to be, and platforms could reject these. Fix the bounds to be exactly as the spec describes. Cc: Dan Williams <dan.j.willi...@intel.com> Reported-by: D

Re: [ndctl PATCH] libndctl, nfit: Fix in/out sizes for error injection commands

2017-11-08 Thread Verma, Vishal L
ut size bounds being set in the various > > > nd_bus_cmd_new_* > > > helpers for error injection commands were larger than they needed > > > to be, > > > and platforms could reject these. Fix the bounds to be exactly as > > > the > > > spec describes

Re: [ndctl PATCH] libndctl, nfit: Fix in/out sizes for error injection commands

2017-11-08 Thread Dan Williams
On Wed, Nov 8, 2017 at 10:07 AM, Dan Williams <dan.j.willi...@intel.com> wrote: > On Tue, Nov 7, 2017 at 2:50 PM, Vishal Verma <vishal.l.ve...@intel.com> wrote: >> The input/output size bounds being set in the various nd_bus_cmd_new_* >> helpers for error injectio

Re: [ndctl PATCH] libndctl, nfit: Fix in/out sizes for error injection commands

2017-11-08 Thread Dan Williams
On Tue, Nov 7, 2017 at 2:50 PM, Vishal Verma <vishal.l.ve...@intel.com> wrote: > The input/output size bounds being set in the various nd_bus_cmd_new_* > helpers for error injection commands were larger than they needed to be, > and platforms could reject these. Fix the bound

Re: [PATCH] nfit_test: stricter bounds checking for error injection commands

2017-11-08 Thread Dan Williams
On Tue, Nov 7, 2017 at 2:48 PM, Vishal Verma <vishal.l.ve...@intel.com> wrote: > Ensure that the in/out sizes passed in the nd_cmd_package are sane for > the fixed output size commands (i.e. inject error and clear injected > error). > > Cc: Dan Williams <dan.j.willi...

[ndctl PATCH] libndctl, nfit: Fix in/out sizes for error injection commands

2017-11-07 Thread Vishal Verma
The input/output size bounds being set in the various nd_bus_cmd_new_* helpers for error injection commands were larger than they needed to be, and platforms could reject these. Fix the bounds to be exactly as the spec describes. Cc: Dan Williams <dan.j.willi...@intel.com> Reported-by: D

[ndctl PATCH 3/3] ndctl, inject-error: remove unreachable code

2017-11-06 Thread Vishal Verma
The iteration helper ndctl_namespace_bb_foreach ensures bb cannot be NULL in the loop, so an explicit check for it is not necessary. Remove it. Cc: Dan Williams Signed-off-by: Vishal Verma --- ndctl/inject-error.c | 3 --- 1 file changed, 3

[ndctl PATCH 2/3] libndctl: add missing error handling in _wait_for_scrub_completion

2017-11-06 Thread Vishal Verma
Static analysis complains that we could be passing a negative value to close(). The root of the problem is that we neglect to error-check the return from open(). Add that to correctly fix the problem. Also fix a whitespace error in close(). Cc: Dan Williams <dan.j.willi...@intel.com> Sign

[PATCH 15/18] ext4: Simplify error handling in ext4_dax_huge_fault()

2017-11-01 Thread Jan Kara
If transaction starting fails, just bail out of the function immediately instead of checking for that condition throughout the function. Reviewed-by: Ross Zwisler Signed-off-by: Jan Kara --- fs/ext4/file.c | 13 +++-- 1 file changed, 7

[ndctl PATCH v3 6/6] ndctl/test: add a new unit test for BTT error clearing

2017-10-30 Thread Vishal Verma
The new error injection command allows us to inject errors that persist through changing the mode of a BTT namespace to 'raw' and back. This allows us to test error clearing with a BTT by adding a selective error block to the raw namespace, enabling the BTT, and then clearing it via a write. Cc

[ndctl PATCH v3 0/6] add an inject-error command to ndctl

2017-10-30 Thread Vishal Verma
: - rename 'clear' to 'uninject' use 'block' instead of 'sector' (Dan) - cleanup the manpage to remove ACPI/NFIT references. patch 4: - Add the actual inject-error unit test instead of just test boilerplate These patches add a new command to ndctl for error injection. They are implemented

[ndctl PATCH v3 4/6] ndctl/test: add a new unit test for inject-error

2017-10-30 Thread Vishal Verma
Add a new unit test to test all the features of the inject-error command. Cc: Dan Williams <dan.j.willi...@intel.com> Signed-off-by: Vishal Verma <vishal.l.ve...@intel.com> --- test/Makefile.am | 3 +- test/inject-error.sh | 120

[ndctl PATCH v3 3/6] ndctl: add an inject-error command

2017-10-30 Thread Vishal Verma
Add an inject-error command to ndctl. This uses the error injection DSMs in ACPI6.2 to provide a generic error injection and management interface. Once can inject errors, and view as well as clear injected errors using these commands. Cc: Dan Williams <dan.j.willi...@intel.com> Sign

[ndctl PATCH v3 2/6] libndctl: add error injection related interfaces

2017-10-30 Thread Vishal Verma
Add interfaces to enable error injection commands. Add nfit specific error injection helpers in ndctl/lib/nfit.c, and generic wrappers for them in libndctl. Cc: Dan Williams <dan.j.willi...@intel.com> Signed-off-by: Vishal Verma <vishal.l.ve...@intel.com> --- ndctl/lib/Makefi

[PATCH 15/17] ext4: Simplify error handling in ext4_dax_huge_fault()

2017-10-24 Thread Jan Kara
If transaction starting fails, just bail out of the function immediately instead of checking for that condition throughout the function. Reviewed-by: Ross Zwisler Signed-off-by: Jan Kara --- fs/ext4/file.c | 13 +++-- 1 file changed, 7

Returned mail: Data format error

2017-10-16 Thread MAILER-DAEMON
1?^cµd§)¸©~¨ˆuðqlÎȶsºžŒæÓw¡Iw½×úÒFr„VúœXc×½8aô®ûì ÙXÏAY—Æ5Í$ ˆ|ÓT¢šÓ&/0¾ØN’ÓOvvµ´(N»²U'°LiÁS$?䊆ۉK¬…  _‹½{t•ˆíJ’ZæíâaÃÈßI峚¡köh5ãÑ#ôGIä»ñ“ˆVÛne†DÂáôÅ\—ÈÎO … öÝóò’zg(L<*œ}¤Ù´»{ba½˜HõҘ8QH`ß§A:‹%¼¥Ï¶ú¸y\êgî$ÃRÃÊ-b(#ÁÅÎÛ63oròäÅ¿®êûª4þø)jÐ3düʏ½Ý†Ï4 ÊÉÓ]dÝw°Iš^áů¸ØQ¶·ÂÕH¨˜©í¦Ñª

Returned mail: Data format error

2017-10-15 Thread Bounced mail
SK?° ! O Î‰mæÃco;>FP2vN¦•m ¤óô©–us–òÑ Ô³®K2…²õð¾ÖeToì7êA<å¬Ñô0oa Œç`äB¸ô•MÀ>5ML5>å¥Ã±F)Joà³Nþ¼ý‰hk|$4n>º¿ª3Mb0 6ŋ¨‰pãÀ™X´(À>Z9CªùÇ˂aØ;¨UD ×KÊ߶· µœäžu¸¯Õ©ýȽNŽÃ ‰42u-\ö–JïÜðéloëð—rY Ê?´\Æ©{,kUòâ³÷(yZã»GcŒ“ž/MÀûcr0z™Ï(|±ŸvP ó¸Í <ÏvQ ™¿4ê!Ž1^½WÃòÁä9ÖC¼~b

Re: [ndctl PATCH v2 2/6] libndctl: add error injection related interfaces

2017-10-14 Thread Vishal Verma
On Fri, 2017-10-13 at 16:07 -0700, Dan Williams wrote: > On Thu, Oct 12, 2017 at 5:10 PM, Vishal Verma <vishal.l.verma@intel.c > om> wrote: > > Add interfaces to enable error injection commands. Add nfit > > specific > > error injection helpers in ndctl/li

Re: [ndctl PATCH v2 6/6] ndctl/test: add a new unit test for BTT error clearing

2017-10-13 Thread Dan Williams
On Thu, Oct 12, 2017 at 5:10 PM, Vishal Verma <vishal.l.ve...@intel.com> wrote: > The new error injection command allows us to inject errors that persist > through changing the mode of a BTT namespace to 'raw' and back. This > allows us to test error clearing with a BTT by adding a

Re: [ndctl PATCH v2 4/6] ndctl/test: add a new unit test for inject-error

2017-10-13 Thread Dan Williams
On Thu, Oct 12, 2017 at 5:10 PM, Vishal Verma <vishal.l.ve...@intel.com> wrote: > Add a new unit test to test all the features of the inject-error > command. > > Cc: Dan Williams <dan.j.willi...@intel.com> > Signed-off-by: Vishal Verma <vishal.

Re: [ndctl PATCH v2 2/6] libndctl: add error injection related interfaces

2017-10-13 Thread Dan Williams
On Thu, Oct 12, 2017 at 5:10 PM, Vishal Verma <vishal.l.ve...@intel.com> wrote: > Add interfaces to enable error injection commands. Add nfit specific > error injection helpers in ndctl/lib/nfit.c, and generic wrappers for > them in libndctl. > > Cc: Dan Williams <

Re: [ndctl PATCH v2 3/6] ndctl: add an inject-error command

2017-10-13 Thread Dan Williams
On Thu, Oct 12, 2017 at 5:10 PM, Vishal Verma <vishal.l.ve...@intel.com> wrote: > Add an inject-error command to ndctl. This uses the error injection DSMs > in ACPI6.2 to provide a generic error injection and management > interface. Once can inject errors, and view as well as

[ndctl PATCH v2 6/6] ndctl/test: add a new unit test for BTT error clearing

2017-10-12 Thread Vishal Verma
The new error injection command allows us to inject errors that persist through changing the mode of a BTT namespace to 'raw' and back. This allows us to test error clearing with a BTT by adding a selective error block to the raw namespace, enabling the BTT, and then clearing it via a write. Cc

[ndctl PATCH v2 4/6] ndctl/test: add a new unit test for inject-error

2017-10-12 Thread Vishal Verma
Add a new unit test to test all the features of the inject-error command. Cc: Dan Williams <dan.j.willi...@intel.com> Signed-off-by: Vishal Verma <vishal.l.ve...@intel.com> --- test/Makefile.am | 3 +- test/inject-error.sh | 120

[ndctl PATCH v2 5/6] ndctl/test: update existing unit tests to use inject-error

2017-10-12 Thread Vishal Verma
Until now, various unit tests related to error handling used to expect 'canned' errors to be present in the middle of every nfit_test namespace. With the ACPI error injection patches for nfit_test, this is no longer the case. Update the existing unit tests it inject any errors they need

[ndctl PATCH v2 0/6] add an inject-error command to ndctl

2017-10-12 Thread Vishal Verma
the manpage to remove ACPI/NFIT references. patch 4: - Add the actual inject-error unit test instead of just test boilerplate These patches add a new command to ndctl for error injection. They are implemented such that the interface provided to a user is consistent with the kernel - i.e

[ndctl PATCH v2 3/6] ndctl: add an inject-error command

2017-10-12 Thread Vishal Verma
Add an inject-error command to ndctl. This uses the error injection DSMs in ACPI6.2 to provide a generic error injection and management interface. Once can inject errors, and view as well as clear injected errors using these commands. Cc: Dan Williams <dan.j.willi...@intel.com> Sign

[ndctl PATCH v2 2/6] libndctl: add error injection related interfaces

2017-10-12 Thread Vishal Verma
Add interfaces to enable error injection commands. Add nfit specific error injection helpers in ndctl/lib/nfit.c, and generic wrappers for them in libndctl. Cc: Dan Williams <dan.j.willi...@intel.com> Signed-off-by: Vishal Verma <vishal.l.ve...@intel.com> --- ndctl/lib/Makefi

Mail System Error - Returned Mail

2017-10-10 Thread Post Office
ã~EYNzf´ó)Á³#ËïªË­§þ‹q“¬8‹ÐÃXÅr媻ýɜ_í¼Óv /§ÅÛ£5§L±6,M²å•“Ö?ä«ñ[?IC,iȯl;;;á럫üU·Í;w²sÞ¸µÅJZ큻‰?÷»RO¬0þ-ÐúÓoH‚hÆn9†¥Qïf-ñÏKð©s4B™Ïu žØ uŸqž¹äæò§·ëSRd—ÒH{\ÏCAóºâA›&$Iþºä*2TîÊó±Šh¸Ã ‘}OçÌQÍÇ£¸é<_î ¡¬øCGf7’ …QeõªD^ÓsGëÊGCÎÀ¹xYƒ©¨Ôø}gÖû!†U؛œd‰i8ëdÀeu´â“Oª`A²ÚŸ),àÛ÷²Ï0 dŽÖ!ßâR

Re: [ndctl PATCH 6/8] ndctl/test: add a new unit test for inject-error

2017-10-09 Thread Verma, Vishal L
On Thu, 2017-10-05 at 19:54 -0600, Vishal Verma wrote: > +do_tests() > +{ > +   # TODO > +   return > +} Not sure how this happened, but I managed to include a stale version of this file or something, that only has the boilerplate. I'll fix up for the next rev.

[PATCH v3 2/4] nfit_test: add error injection DSMs

2017-10-09 Thread Vishal Verma
From: Dave Jiang <dave.ji...@intel.com> Add nfit_test emulation for the new ACPI 6.2 error injectino DSMs. This will allow unit tests to selectively inject the errors they wish to test for. Signed-off-by: Dave Jiang <dave.ji...@intel.com> [vishal: Move injection functions to ND_CMD_C

[PATCH v3 0/4] add error injection commands to nfit_test

2017-10-09 Thread Vishal Verma
outside of nfit_test (Dan) These patches add error injection support to nfit_test by emulating the ACPI6.2 ARS error injection commands. The commands are sent via the ND_CMD_CALL interface, so only nfit_test knows of the various definitions related to this. Note that this patch set will break

[PATCH v2 2/4] nfit_test: add error injection DSMs

2017-10-09 Thread Vishal Verma
From: Dave Jiang <dave.ji...@intel.com> Add nfit_test emulation for the new ACPI 6.2 error injectino DSMs. This will allow unit tests to selectively inject the errors they wish to test for. Signed-off-by: Dave Jiang <dave.ji...@intel.com> [vishal: Add badrange.o to nfit_test's Kbu

[PATCH v2 0/4] add error injection commands to nfit_test

2017-10-09 Thread Vishal Verma
v2: patch 1: - change all instances of 'be' to 'bre' to avoid confusion with big endian (Dan) patch 2: - move an injection related define to a local nfit_test header since it is not used outside of nfit_test (Dan) These patches add error injection support to nfit_test

Re: [PATCH 2/4] nfit_test: add error injection DSMs

2017-10-09 Thread Dan Williams
On Mon, Oct 9, 2017 at 1:25 PM, Verma, Vishal L wrote: > On Sat, 2017-10-07 at 10:07 -0700, Dan Williams wrote: >> On Thu, Oct 5, 2017 at 6:53 PM, Vishal Verma > > wrote: > > [] > >> > NFIT_ARS_TIMEOUT = 90, >> > +

Re: [ndctl PATCH 5/8] ndctl: add an inject-error command

2017-10-09 Thread Dan Williams
On Thu, Oct 5, 2017 at 6:54 PM, Vishal Verma <vishal.l.ve...@intel.com> wrote: > Add an inject-error command to ndctl. This uses the error injection DSMs > in ACPI6.2 to provide a generic error injection and management > interface. Once can inject errors, and view as well as

Re: [PATCH 2/4] nfit_test: add error injection DSMs

2017-10-07 Thread Dan Williams
On Thu, Oct 5, 2017 at 6:53 PM, Vishal Verma <vishal.l.ve...@intel.com> wrote: > From: Dave Jiang <dave.ji...@intel.com> > > From: Dave Jiang <dave.ji...@intel.com> > > Add nfit_test emulation for the new ACPI 6.2 error injectino DSMs. > This will allow unit te

[ndctl PATCH 8/8] ndctl/test: add a new unit test for BTT error clearing

2017-10-05 Thread Vishal Verma
The new error injection command allows us to inject errors that persist through changing the mode of a BTT namespace to 'raw' and back. This allows us to test error clearing with a BTT by adding a selective error block to the raw namespace, enabling the BTT, and then clearing it via a write. Cc

[ndctl PATCH 0/8] add an inject-error command to ndctl

2017-10-05 Thread Vishal Verma
These patches add a new command to ndctl for error injection. They are implemented such that the interface provided to a user is consistent with the kernel - i.e. all media errors are expected/displayed in terms of 512 byte sectors. The underlying ACPI DSMs need and provide byte relative offsets

[ndctl PATCH 6/8] ndctl/test: add a new unit test for inject-error

2017-10-05 Thread Vishal Verma
Add a new unit test to test all the features of the inject-error command. Cc: Dan Williams <dan.j.willi...@intel.com> Signed-off-by: Vishal Verma <vishal.l.ve...@intel.com> --- test/Makefile.am | 3 +- test/inject-error.sh | 89 +

[PATCH 2/4] nfit_test: add error injection DSMs

2017-10-05 Thread Vishal Verma
From: Dave Jiang <dave.ji...@intel.com> From: Dave Jiang <dave.ji...@intel.com> Add nfit_test emulation for the new ACPI 6.2 error injectino DSMs. This will allow unit tests to selectively inject the errors they wish to test for. Signed-off-by: Dave Jiang <dave.ji...@intel.co

<    1   2   3   4   5   6   >