On Wed, Jun 20, 2018 at 04:51:46PM -0600, Ross Zwisler wrote:
> I noticed that in some of my C tests in src/ I was incorrectly checking for
> mmap() failure by looking for NULL instead of MAP_FAILED. Fix those and
> clean up some places where we were testing against -1 (the actual value of
>
This stub was added so that we could use dm-error with
DM_TYPE_DAX_BIO_BASED mode devices. That mode and the transition issues
associated with it no longer exist, so we can remove this dead code.
Signed-off-by: Ross Zwisler
---
drivers/md/dm-target.c | 7 ---
1 file changed, 7 deletions
This stub was added so that we could use dm-error with
DM_TYPE_DAX_BIO_BASED mode devices. That mode and the transition issues
associated with it no longer exist, so we can remove this dead code.
Signed-off-by: Ross Zwisler <ross.zwis...@linux.intel.com>
---
drivers/md/dm-target
The original message was received at Wed, 23 May 2018 10:59:05 +0800
from lists.01.org [149.215.9.222]
- The following addresses had permanent fatal errors -
- Transcript of session follows -
while talking to lists.01.org.:
>>> MAIL From:"Bounced
___
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
Now that error injection by default injects fewer bytes per block,
provide an option to allow it to behave in the old way, i.e. injecting
the entire block.
The downside of these reworks is that where as the old way injected the
entire address range in one command, this now issues an ndctl command
Updates to the error injection facilities in libndctl and ndctl that:
1. Inject fewer bytes per injected block:
It is sufficient to inject even a single byte (cache line) for Linux
to mark the entire block as a badblock. Reduce the number of injected
bytes per block to the unit reported
The original message was received at Sat, 28 Apr 2018 11:06:14 +0800
from lists.01.org [176.93.34.168]
- The following addresses had permanent fatal errors -
- Transcript of session follows -
while talking to lists.01.org.:
>>> MAIL From:"Automatic
:
<linux-nvdimm@lists.01.org>
Please reply to postmas...@lists.01.org
if you feel this message to be in error.
___
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
õ?îLK¶H7$~Á}4Ú¥(ÀסÅc
Hîeg»Í-·`îG%æÐÒf(L4xDû"ò#Tý"ª«Ë`þ¯°#bÐd7àjøë¾øÀ(D.Åé<
õ
X«©Ò¾%ëÎc¥ÃH¶ÈúÀóþü:áÎj7¿Áïͬ³âH#|ëQjßø ±¡T6QT¢UÀR1x´R¸(>ª8àQ0XB
`Úõ²d×U/ÅÂàZõuQáw¨¢ôI6nåPc7À¨:oPbHlø?¹5ëÌsDçlÆTCE%ì<ò_Pbèv|ñ5¿äwQKvV1hu\8ñ×ä.â¦Mï²·/q3í
The original message was received at Wed, 11 Apr 2018 11:29:58 +0800
from lists.01.org [3.200.103.101]
- The following addresses had permanent fatal errors -
___
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
Given that libnvdimm driver stack takes specific actions on DIMM command
error codes like -EACCES, provide a facility to inject custom failures.
Signed-off-by: Dan Williams <dan.j.willi...@intel.com>
---
tools/testing/nvdimm/test/nfit.c | 38 +-
Stephen reports that an x86 allmodconfig build fails to build the
of_pmem driver due to a missing definition of of_node_to_nid(). That
helper is currently only exported in the OF_NUMA=y case. In other cases,
ppc and sparc, it is a weak symbol, and outside of those platforms it is
a static inline.
The original message was received at Mon, 9 Apr 2018 10:58:22 +0800
from lists.01.org [46.168.176.223]
- The following addresses had permanent fatal errors -
___
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
nÆM?Ø{aÖ¸#©sa¯úów|z¸
j°2[O¡t#·|Ë^U¡!ÒGýR Pà*{2þû¸mî2%dxJ_²¶.Qt
Hßê¸2PÇÝ©|ÔãÜ1Ü
ר6³¨L°T*¯°P»±ùä§
såÂ,e±åÞ}Våò«ü¿3c!j¶}ðÔ¤æ)ØBûÙ>Ô[Îî09z³´Ì·
'3"x¡ÄÒbÜI,¼e¦Xçô3'*Ç3Mjþ·C8$Y fD¸Þlئӯ)ÁPêñ)oCk\9
úGí,ÐDjú¸w¦AÃ
úÎ
8±ôq¿;µ¬ÐµqøqTôÌös^ô
___
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
nction 'fs_dax_claim_bdev':
drivers//dax/super.c:207:2: error: implicit declaration of function
'blk_queue_dax' [-Werror=implicit-function-declaration]
if (!blk_queue_dax(bdev->bd_queue))
^
>> drivers//dax/super.c:209:44: error: dereferencing pointer to incomplete type
dax_dev = fs_
nction 'fs_dax_claim_bdev':
>> drivers//dax/super.c:207:7: error: implicit declaration of function
>> 'blk_queue_dax' [-Werror=implicit-function-declaration]
if (!blk_queue_dax(bdev->bd_queue))
^
drivers//dax/super.c:209:44: error: dereferencing pointer to incomplete
Hi Dave,
I love your patch! Yet something to improve:
[auto build test ERROR on pm/linux-next]
[also build test ERROR on v4.16-rc7 next-20180329]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits
On Thu, Mar 29, 2018 at 4:18 PM, Vishal Verma wrote:
> We were returning a raw '-1' in one case, and a couple of other 'errno'
> returns without making them negative. Fix them to make the returns
> consistent.
>
> Cc: Dan Williams
>
We were returning a raw '-1' in one case, and a couple of other 'errno'
returns without making them negative. Fix them to make the returns
consistent.
Cc: Dan Williams
Signed-off-by: Vishal Verma
---
ndctl/check.c | 6 +++---
1 file changed,
s)
- return;
+ return -ENXIO;
while (remain > sizeof(struct acpi_bert_region)) {
if (cper_estatus_check(estatus)) {
pr_err(FW_BUG "Invalid error record.\n");
- return;
The original message was received at Tue, 27 Mar 2018 11:26:12 +0800
from lists.01.org [187.102.34.159]
- The following addresses had permanent fatal errors -
___
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
The original message was received at Thu, 22 Mar 2018 11:05:53 +0800
from hocevar.net [106.146.195.149]
- The following addresses had permanent fatal errors -
- Transcript of session follows -
while talking to lists.01.org.:
>>> MAIL
:
<linux-nvdimm@lists.01.org>
Please reply to postmas...@jdom.org
if you feel this message to be in error.
___
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
Terminate the buffer for sysfs_read_attr() users that might not
properly handle the error code.
Signed-off-by: Dan Williams <dan.j.willi...@intel.com>
---
util/sysfs.c |1 +
1 file changed, 1 insertion(+)
diff --git a/util/sysfs.c b/util/sysfs.c
index e067f065a820..0440fd0f49a3
The original message was received at Fri, 16 Mar 2018 15:49:57 +0800
from lists.01.org [140.63.74.149]
- The following addresses had permanent fatal errors -
___
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
The original message was received at Wed, 14 Mar 2018 11:25:45 +0800
from linux.vnet.ibm.com [21.189.161.32]
- The following addresses had permanent fatal errors -
- Transcript of session follows -
while talking to lists.01.org.:
>>> MAIL
Öº±gqRnÈZèÞX
ô>ï2w·ÔýB½ôeYu)tXjú8!j>iªChí$ZgøSÙWw?ÓZß.ßNá߯N(¬
¤wÅx6±$£¡»O1<ýå¢l)¥â"CÆêÈ&ëvÔYe
FáÐä¨üMfÕhñÇö«»Ë.ÆzÎÜÛ%w[s*mÔÞck£Öñ
]ïYS
ÍêÝ°3øR[ò¾ÄjuA
YbEÔ¢L
eXùÀL»¾TLõ¤èÀÐ7£g8
z±ëc¸KNbþÖĵVÆoC'¶ø6÷-ÒÌ£2ïA¿Z¯ï7b(£T2(
ö8&¸!ï3ý»Ã.¾Ogñfg1âZ¦av¢E"¨DÒZ)Oãøµõ
:
<linux-nvdimm@lists.01.org>
Please reply to postmas...@lists.01.org
if you feel this message to be in error.
___
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
When you load nfit_test you currently see the following error in dmesg:
nfit_test nfit_test.0: found a zero length table '0' parsing nfit
This happens because when we parse the nfit_test.0 table via
acpi_nfit_init(), we specify a size of nfit_test->nfit_size. For the first
pass thro
On Wed, Feb 21, 2018 at 3:20 PM, Vishal Verma <vishal.l.ve...@intel.com> wrote:
> When we updated from using canned badblocks to injected errors in
> nfit_test, we ended up breaking the tests for older kernels that didn't
> have error injection capabilities.
>
> Fix t
On Thu, Feb 22, 2018 at 12:49 PM, Dave Jiang <dave.ji...@intel.com> wrote:
> update-firmware is missing verbose option for debug outputs. Also adding
> additional error outs to give better indication if something has failed
> and why.
>
> Signed-off-by: Dave Jiang <dave.ji.
update-firmware is missing verbose option for debug outputs. Also adding
additional error outs to give better indication if something has failed
and why.
Signed-off-by: Dave Jiang <dave.ji...@intel.com>
Reviewed-by: Dan Williams <dan.j.willi...@intel.com>
---
ndctl/upd
On Wed, Feb 21, 2018 at 2:05 PM, Dave Jiang <dave.ji...@intel.com> wrote:
> update-firmware is missing verbose option for debug outputs. Also adding
> additional error outs to give better indication if something has failed
> and why.
Looks good to me.
Reviewed-by: Dan Willia
When we updated from using canned badblocks to injected errors in
nfit_test, we ended up breaking the tests for older kernels that didn't
have error injection capabilities.
Fix this by first checking if badblocks already exist. If they do, we
have an older kernel with canned badblocks, and we can
update-firmware is missing verbose option for debug outputs. Also adding
additional error outs to give better indication if something has failed
and why.
Signed-off-by: Dave Jiang <dave.ji...@intel.com>
---
ndctl/update.c | 99 +++-
When an invalid namespace was specified, inject-error would simply walk
through a loop trying to matching namespace, and at the end, exit out
silently. This could make it look as though the operation had been
successful, when in reality, nothing had been done.
Fix to print a message, and exit
When an invalid namespace was specified, inject-error would simply walk
through a loop trying to matching namespace, and at the end, exit out
silently. This could make it look as though the operation had been
successful, when in reality, nothing had been done.
Fix to print a message, and exit
On Fri, 2018-02-02 at 12:31 -0800, Dan Williams wrote:
> On Fri, Feb 2, 2018 at 1:00 PM, Toshi Kani <toshi.k...@hpe.com> wrote:
> > A NULL pointer reference kernel bug was observed when
> > acpi_nfit_add_dimm() called in acpi_nfit_register_dimms()
> > failed. This error
On Fri, Feb 2, 2018 at 1:00 PM, Toshi Kani <toshi.k...@hpe.com> wrote:
> A NULL pointer reference kernel bug was observed when
> acpi_nfit_add_dimm() called in acpi_nfit_register_dimms()
> failed. This error path does not set nfit_mem->nvdimm, but
> the 2nd list_
A NULL pointer reference kernel bug was observed when
acpi_nfit_add_dimm() called in acpi_nfit_register_dimms()
failed. This error path does not set nfit_mem->nvdimm, but
the 2nd list_for_each_entry() loop in the function assumes
it's always set. Add a check to nfit_mem->nvdimm.
Sign
e³DT,õR8ó!}º[rE²'ÍÆQ¯Ê¹A¹_"çþÓßÙô»p.V{%é(FÞµèÏxýFÑÓ«ÃÕ(¬i}Xô¤-ÄÄx~¡4Ѿ4
ÔYE;o-¹¿}^¦÷Ù´9µKfô®v4YÆQ)Òûíʸ¥`!TÝéâî{.O7¼5""qò¡çâ\ÆL¯vòõ°Míb_¶wð¹
`^®jÔ(]Âoó]?³ïYYf~ÓÍ
#«ÀoÞؤ®
úPÖ½ý»],çXQ[Ñö§ù7WZÀÄ0éåæUïýaèE±M½]wèfHùa0/2Ö½tßÞc²mR&íëAOud·b¡Dòz;y?xu«BZÖYþÏ?ÓG2]«ü}L¾ãõ½[F«î
±øÕWSħ¡,y$/>Ù^r
øÝÎ
®VøóáceäÒ£VËÎSÛPh
ï)ËXEN{K#03Êú6JFÔ
Á×Üæaw^y%RØ4ioè;¦¢iGá±üìqsT
:
<linux-nvdimm@lists.01.org>
Please reply to postmas...@lists.01.org
if you feel this message to be in error.
___
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
On Wed, Jan 03, 2018 at 11:08:43AM +0100, Jan Kara wrote:
> Ext4 needs to pass through error from its iomap handler to the page
> fault handler so that it can properly detect ENOSPC and force
> transaction commit and retry the fault (and block allocation). Add
> argument to dax
Ext4 needs to pass through error from its iomap handler to the page
fault handler so that it can properly detect ENOSPC and force
transaction commit and retry the fault (and block allocation). Add
argument to dax_iomap_fault() for passing such error.
Reviewed-by: Ross Zwisler <ross.z
.#ï|?±¢Ó#ãßy÷»?í»¶æ$áñÐÅ
)ù_NÄõåЦá÷Oàï}gG'bP3í5BY
¿J&Û¨0òmÇ£.Ù76,Ï7&©×ª.<ºèµëvtªYé
×ã°°Î\
On Tue, Jan 2, 2018 at 10:54 AM, Jan Kara <j...@suse.cz> wrote:
> On Thu 21-12-17 09:12:52, Dan Williams wrote:
>> On Thu, Dec 21, 2017 at 8:30 AM, Jan Kara <j...@suse.cz> wrote:
>> > Ext4 needs to pass through error from its iomap handler to the page
>> >
On Thu 21-12-17 09:12:52, Dan Williams wrote:
> On Thu, Dec 21, 2017 at 8:30 AM, Jan Kara <j...@suse.cz> wrote:
> > Ext4 needs to pass through error from its iomap handler to the page
> > fault handler so that it can properly detect ENOSPC and force
> > transaction
___
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
On Thu, Dec 21, 2017 at 05:30:54PM +0100, Jan Kara wrote:
> Ext4 needs to pass through error from its iomap handler to the page
> fault handler so that it can properly detect ENOSPC and force
> transaction commit and retry the fault (and block allocation). Add
> argument to dax
On Thu, Dec 21, 2017 at 8:30 AM, Jan Kara <j...@suse.cz> wrote:
> Ext4 needs to pass through error from its iomap handler to the page
> fault handler so that it can properly detect ENOSPC and force
> transaction commit and retry the fault (and block allocation). Add
> argument
Ext4 needs to pass through error from its iomap handler to the page
fault handler so that it can properly detect ENOSPC and force
transaction commit and retry the fault (and block allocation). Add
argument to dax_iomap_fault() for passing such error.
Signed-off-by: Jan Kara <j...@suse.cz>
-
Ext4 needs to pass through error from its iomap handler to the page
fault handler so that it can properly detect ENOSPC and force
transaction commit and retry the fault (and block allocation). Add
argument to dax_iomap_fault() for passing such error.
Signed-off-by: Jan Kara <j...@suse.cz>
-
The general parameter parsing error message in parse_region_options()
was copied from the initial "disable-region" command implementation. Fix
it up to be more general and valid for all region commands.
Signed-off-by: Dan Williams <dan.j.willi...@intel.com>
---
ndctl/region.c |
JDÅ$~,ºõcooóÂ8ÃlL#¸ÇGÊ)~#/*ÝEnµ¹çzpô½¤Éûk^[,8Ü\
ã\ÝI¸¥¼ÊmÏÃPà'l§ißWؤÖîØ8Å»0óñ`~cî¨ÀüG#¨èÛvÄæç
Æ«Ù Ñz^6÷áI÷ÚfÊí\
ùx
ÂÞWm#tAJÐ2Gl¿U3ÏÂݤY®ÍÓõßîóIdo2*(>ªÑÓ%Êó5i§k4
gúÏèiD!Nº*
¤¡æØuPL.
Å
_×.Ë
ÔCzEͨ{©×ßOY3ÓêâhiÊ:%}
Validate command parsing in acpi_nfit_ctl for the clear error command.
This tests for a crash condition introduced by commit 4b27db7e26cd
"acpi, nfit: add support for the _LSI, _LSR, and _LSW label methods".
Cc: Vishal Verma <vishal.l.ve...@intel.com>
Signed-off-by: Dan Willi
On Thu, Nov 9, 2017 at 1:08 PM, Vishal Verma <vishal.l.ve...@intel.com> wrote:
>
> The input/output size bounds being set in the various nd_bus_cmd_new_*
> helpers for error injection commands were larger than they needed to be,
> and platforms could reject these. Fix the bo
The input/output size bounds being set in the various nd_bus_cmd_new_*
helpers for error injection commands were larger than they needed to be,
and platforms could reject these. Fix the bounds to be exactly as the
spec describes.
Cc: Dan Williams <dan.j.willi...@intel.com>
Reported-by: D
ut size bounds being set in the various
> > > nd_bus_cmd_new_*
> > > helpers for error injection commands were larger than they needed
> > > to be,
> > > and platforms could reject these. Fix the bounds to be exactly as
> > > the
> > > spec describes
On Wed, Nov 8, 2017 at 10:07 AM, Dan Williams <dan.j.willi...@intel.com> wrote:
> On Tue, Nov 7, 2017 at 2:50 PM, Vishal Verma <vishal.l.ve...@intel.com> wrote:
>> The input/output size bounds being set in the various nd_bus_cmd_new_*
>> helpers for error injectio
On Tue, Nov 7, 2017 at 2:50 PM, Vishal Verma <vishal.l.ve...@intel.com> wrote:
> The input/output size bounds being set in the various nd_bus_cmd_new_*
> helpers for error injection commands were larger than they needed to be,
> and platforms could reject these. Fix the bound
On Tue, Nov 7, 2017 at 2:48 PM, Vishal Verma <vishal.l.ve...@intel.com> wrote:
> Ensure that the in/out sizes passed in the nd_cmd_package are sane for
> the fixed output size commands (i.e. inject error and clear injected
> error).
>
> Cc: Dan Williams <dan.j.willi...
The input/output size bounds being set in the various nd_bus_cmd_new_*
helpers for error injection commands were larger than they needed to be,
and platforms could reject these. Fix the bounds to be exactly as the
spec describes.
Cc: Dan Williams <dan.j.willi...@intel.com>
Reported-by: D
The iteration helper ndctl_namespace_bb_foreach ensures bb cannot be
NULL in the loop, so an explicit check for it is not necessary. Remove
it.
Cc: Dan Williams
Signed-off-by: Vishal Verma
---
ndctl/inject-error.c | 3 ---
1 file changed, 3
Static analysis complains that we could be passing a negative value to
close(). The root of the problem is that we neglect to error-check the
return from open(). Add that to correctly fix the problem. Also fix a
whitespace error in close().
Cc: Dan Williams <dan.j.willi...@intel.com>
Sign
If transaction starting fails, just bail out of the function immediately
instead of checking for that condition throughout the function.
Reviewed-by: Ross Zwisler
Signed-off-by: Jan Kara
---
fs/ext4/file.c | 13 +++--
1 file changed, 7
The new error injection command allows us to inject errors that persist
through changing the mode of a BTT namespace to 'raw' and back. This
allows us to test error clearing with a BTT by adding a selective error
block to the raw namespace, enabling the BTT, and then clearing it via a
write.
Cc
:
- rename 'clear' to 'uninject' use 'block' instead of 'sector' (Dan)
- cleanup the manpage to remove ACPI/NFIT references.
patch 4:
- Add the actual inject-error unit test instead of just test
boilerplate
These patches add a new command to ndctl for error injection. They are
implemented
Add a new unit test to test all the features of the inject-error
command.
Cc: Dan Williams <dan.j.willi...@intel.com>
Signed-off-by: Vishal Verma <vishal.l.ve...@intel.com>
---
test/Makefile.am | 3 +-
test/inject-error.sh | 120
Add an inject-error command to ndctl. This uses the error injection DSMs
in ACPI6.2 to provide a generic error injection and management
interface. Once can inject errors, and view as well as clear injected
errors using these commands.
Cc: Dan Williams <dan.j.willi...@intel.com>
Sign
Add interfaces to enable error injection commands. Add nfit specific
error injection helpers in ndctl/lib/nfit.c, and generic wrappers for
them in libndctl.
Cc: Dan Williams <dan.j.willi...@intel.com>
Signed-off-by: Vishal Verma <vishal.l.ve...@intel.com>
---
ndctl/lib/Makefi
If transaction starting fails, just bail out of the function immediately
instead of checking for that condition throughout the function.
Reviewed-by: Ross Zwisler
Signed-off-by: Jan Kara
---
fs/ext4/file.c | 13 +++--
1 file changed, 7
1?^cµd§)¸©~¨uðqlÎȶsºæÓw¡Iw½×úÒFrVúXc×½8aô®ûì
ÙXÏAYÆ5Í$ |ÓT¢Ó&/0¾ØNÓOvvµ´(N»²U'°LiÁS$?äÛK¬
_½{tíJZæíâaÃÈßI峡köh5ãÑ#ôGIä»ñVÛneDÂáôÅ\ÈÎO
öÝóòzg(L<*}¤Ù´»{ba½HõÒ8QH`ߧA:%¼¥Ï¶ú¸y\êgî$ÃRÃÊ-b(#ÁÅÎÛ63oròäÅ¿®êûª4þø)jÐ3düʽÝÏ4
ÊÉÓ]dÝw°I^áů¸ØQ¶·ÂÕH¨©í¦Ñª
SK?°
!
O ÎmæÃco;>FP2vN¦m ¤óô©usòÑ
Ô³®K2
²õð¾ÖeToì7êA<å¬Ñô0oa ç`äB¸ôMÀ>5ML5>å¥Ã±F)Joà³Nþ¼ýhk|$4n>º¿ª3Mb0
6ŨpãÀX´(À>Z9CªùÇËaØ;¨UD
×KÊ߶· µäu¸¯Õ©ýȽNÃ
42u-\öJïÜðéloëðrY
Ê?´\Æ©{,kUòâ³÷(yZã»Gc/MÀûcr0zÏ(|±vP ó¸Í <ÏvQ ¿4ê!1^½WÃòÁä9ÖC¼~b
On Fri, 2017-10-13 at 16:07 -0700, Dan Williams wrote:
> On Thu, Oct 12, 2017 at 5:10 PM, Vishal Verma <vishal.l.verma@intel.c
> om> wrote:
> > Add interfaces to enable error injection commands. Add nfit
> > specific
> > error injection helpers in ndctl/li
On Thu, Oct 12, 2017 at 5:10 PM, Vishal Verma <vishal.l.ve...@intel.com> wrote:
> The new error injection command allows us to inject errors that persist
> through changing the mode of a BTT namespace to 'raw' and back. This
> allows us to test error clearing with a BTT by adding a
On Thu, Oct 12, 2017 at 5:10 PM, Vishal Verma <vishal.l.ve...@intel.com> wrote:
> Add a new unit test to test all the features of the inject-error
> command.
>
> Cc: Dan Williams <dan.j.willi...@intel.com>
> Signed-off-by: Vishal Verma <vishal.
On Thu, Oct 12, 2017 at 5:10 PM, Vishal Verma <vishal.l.ve...@intel.com> wrote:
> Add interfaces to enable error injection commands. Add nfit specific
> error injection helpers in ndctl/lib/nfit.c, and generic wrappers for
> them in libndctl.
>
> Cc: Dan Williams <
On Thu, Oct 12, 2017 at 5:10 PM, Vishal Verma <vishal.l.ve...@intel.com> wrote:
> Add an inject-error command to ndctl. This uses the error injection DSMs
> in ACPI6.2 to provide a generic error injection and management
> interface. Once can inject errors, and view as well as
The new error injection command allows us to inject errors that persist
through changing the mode of a BTT namespace to 'raw' and back. This
allows us to test error clearing with a BTT by adding a selective error
block to the raw namespace, enabling the BTT, and then clearing it via a
write.
Cc
Add a new unit test to test all the features of the inject-error
command.
Cc: Dan Williams <dan.j.willi...@intel.com>
Signed-off-by: Vishal Verma <vishal.l.ve...@intel.com>
---
test/Makefile.am | 3 +-
test/inject-error.sh | 120
Until now, various unit tests related to error handling used to expect
'canned' errors to be present in the middle of every nfit_test
namespace. With the ACPI error injection patches for nfit_test, this is
no longer the case. Update the existing unit tests it inject any errors
they need
the manpage to remove ACPI/NFIT references.
patch 4:
- Add the actual inject-error unit test instead of just test
boilerplate
These patches add a new command to ndctl for error injection. They are
implemented such that the interface provided to a user is consistent
with the kernel - i.e
Add an inject-error command to ndctl. This uses the error injection DSMs
in ACPI6.2 to provide a generic error injection and management
interface. Once can inject errors, and view as well as clear injected
errors using these commands.
Cc: Dan Williams <dan.j.willi...@intel.com>
Sign
Add interfaces to enable error injection commands. Add nfit specific
error injection helpers in ndctl/lib/nfit.c, and generic wrappers for
them in libndctl.
Cc: Dan Williams <dan.j.willi...@intel.com>
Signed-off-by: Vishal Verma <vishal.l.ve...@intel.com>
---
ndctl/lib/Makefi
ã~EYNzf´ó)Á³#ËïªË§þq¬8ÐÃXÅr媻ýÉ_í¼Óv
/§ÅÛ£5§L±6,M²åÖ?ä«ñ[?IC,iȯl;;;áë«üU·Í;w²sÞ¸µÅJZí»?÷»RO¬0þ-ÐúÓoHhÆn9¥Qïf-ñÏKð©s4BÏu
Ø
uq¹äæò§·ëSRdÒH{\ÏCAóºâA&$Iþºä*2TîÊó±h¸Ã
}OçÌQÍÇ£¸é<_î ¡¬øCGf7
QeõªD^ÓsGëÊGCÎÀ¹xY©¨Ôø}gÖû!UØdi8ëdÀeu´âOª`A²Ú),àÛ÷²Ï0
dÖ!ßâR
On Thu, 2017-10-05 at 19:54 -0600, Vishal Verma wrote:
> +do_tests()
> +{
> + # TODO
> + return
> +}
Not sure how this happened, but I managed to include a stale version of
this file or something, that only has the boilerplate. I'll fix up for
the next rev.
From: Dave Jiang <dave.ji...@intel.com>
Add nfit_test emulation for the new ACPI 6.2 error injectino DSMs.
This will allow unit tests to selectively inject the errors they wish to
test for.
Signed-off-by: Dave Jiang <dave.ji...@intel.com>
[vishal: Move injection functions to ND_CMD_C
outside of nfit_test (Dan)
These patches add error injection support to nfit_test by emulating the
ACPI6.2 ARS error injection commands. The commands are sent via the
ND_CMD_CALL interface, so only nfit_test knows of the various
definitions related to this.
Note that this patch set will break
From: Dave Jiang <dave.ji...@intel.com>
Add nfit_test emulation for the new ACPI 6.2 error injectino DSMs.
This will allow unit tests to selectively inject the errors they wish to
test for.
Signed-off-by: Dave Jiang <dave.ji...@intel.com>
[vishal: Add badrange.o to nfit_test's Kbu
v2:
patch 1:
- change all instances of 'be' to 'bre' to avoid confusion with
big endian (Dan)
patch 2:
- move an injection related define to a local nfit_test header
since it is not used outside of nfit_test (Dan)
These patches add error injection support to nfit_test
On Mon, Oct 9, 2017 at 1:25 PM, Verma, Vishal L
wrote:
> On Sat, 2017-10-07 at 10:07 -0700, Dan Williams wrote:
>> On Thu, Oct 5, 2017 at 6:53 PM, Vishal Verma > > wrote:
>
> []
>
>> > NFIT_ARS_TIMEOUT = 90,
>> > +
On Thu, Oct 5, 2017 at 6:54 PM, Vishal Verma <vishal.l.ve...@intel.com> wrote:
> Add an inject-error command to ndctl. This uses the error injection DSMs
> in ACPI6.2 to provide a generic error injection and management
> interface. Once can inject errors, and view as well as
On Thu, Oct 5, 2017 at 6:53 PM, Vishal Verma <vishal.l.ve...@intel.com> wrote:
> From: Dave Jiang <dave.ji...@intel.com>
>
> From: Dave Jiang <dave.ji...@intel.com>
>
> Add nfit_test emulation for the new ACPI 6.2 error injectino DSMs.
> This will allow unit te
The new error injection command allows us to inject errors that persist
through changing the mode of a BTT namespace to 'raw' and back. This
allows us to test error clearing with a BTT by adding a selective error
block to the raw namespace, enabling the BTT, and then clearing it via a
write.
Cc
These patches add a new command to ndctl for error injection. They are
implemented such that the interface provided to a user is consistent
with the kernel - i.e. all media errors are expected/displayed in terms
of 512 byte sectors. The underlying ACPI DSMs need and provide byte
relative offsets
Add a new unit test to test all the features of the inject-error
command.
Cc: Dan Williams <dan.j.willi...@intel.com>
Signed-off-by: Vishal Verma <vishal.l.ve...@intel.com>
---
test/Makefile.am | 3 +-
test/inject-error.sh | 89 +
From: Dave Jiang <dave.ji...@intel.com>
From: Dave Jiang <dave.ji...@intel.com>
Add nfit_test emulation for the new ACPI 6.2 error injectino DSMs.
This will allow unit tests to selectively inject the errors they wish to
test for.
Signed-off-by: Dave Jiang <dave.ji...@intel.co
301 - 400 of 541 matches
Mail list logo