Re: [alsa-devel] [RESEND PATCH v3 2/5] ARM: OMAP4: Assign IDs to DSS HDMI devices

2013-01-25 Thread Ricardo Neri
Hi Sebastien, On 01/25/2013 08:44 AM, Sebastien Guiriec wrote: Hi Ricardo, You need to rebase this patch as the code has been moved to dss-common.c file now. So it would not apply. Thanks! I will send a new rebased version. Ricardo Sebastien On 01/05/2013 12:26 AM, Ricardo Neri wrote

[PATCH] OMAPDSS: HDMI: Rework function to calculate N/CTS params

2013-01-10 Thread Ricardo Neri
to an integer CTS value for such use case. Signed-off-by: Ricardo Neri rn...@dextratech.com --- drivers/video/omap2/dss/hdmi.c | 142 1 file changed, 70 insertions(+), 72 deletions(-) diff --git a/drivers/video/omap2/dss/hdmi.c b/drivers/video/omap2/dss

Re: [PATCH v3 0/5] ARM: OMAP4+: HDMI: Update platform devices for audio

2013-01-04 Thread Ricardo Neri
Hi Mark, On 01/04/2013 04:42 AM, Mark Brown wrote: On Thu, Jan 03, 2013 at 11:33:12AM -0600, Ricardo Neri wrote: Just wondering if you had a chance to take a look at these patches. Don't top post. Sorry, my bad. Won't do it again. Whatever patches you're talking about I don't have them

[RESEND PATCH v3 0/5] ARM: OMAP4+: HDMI: Update platform devices for audio

2013-01-04 Thread Ricardo Neri
functionality in any patch. Also, the names of the platform devices are changed to give them more logical and more descriptive names. As the commit commit 14840b9a83c6a56629db2ba0ec247503e975f143 Author: Ricardo Neri ricardo.n...@ti.com Date: Tue Nov 6 00:19:17 2012 -0600 OMAPDSS: HDMI

[RESEND PATCH v3 1/5] ARM: OMAP4+: HDMI: Rename platform devices for ASoC drivers

2013-01-04 Thread Ricardo Neri
are also updated accordingly. Signed-off-by: Ricardo Neri rn...@dextratech.com --- arch/arm/mach-omap2/devices.c |4 ++-- sound/soc/omap/omap-hdmi-card.c |4 ++-- sound/soc/omap/omap-hdmi.c |2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/arm/mach-omap2

[RESEND PATCH v3 2/5] ARM: OMAP4: Assign IDs to DSS HDMI devices

2013-01-04 Thread Ricardo Neri
. Signed-off-by: Ricardo Neri rn...@dextratech.com --- arch/arm/mach-omap2/board-4430sdp.c|3 +++ arch/arm/mach-omap2/board-omap4panda.c |3 +++ 2 files changed, 6 insertions(+) diff --git a/arch/arm/mach-omap2/board-4430sdp.c b/arch/arm/mach-omap2/board-4430sdp.c index 3669c12

[RESEND PATCH v3 3/5] ARM4: OMAP4+: HDMI: Relocate devices for audio codec and card

2013-01-04 Thread Ricardo Neri
is not implemented. Signed-off-by: Ricardo Neri rn...@dextratech.com --- arch/arm/mach-omap2/board-4430sdp.c|6 -- arch/arm/mach-omap2/board-omap4panda.c |6 -- arch/arm/mach-omap2/devices.c |7 --- arch/arm/mach-omap2/display.c | 31

[RESEND PATCH v3 4/5] ARM: OMAP4+: HDMI: Relocate the device for audio interface

2013-01-04 Thread Ricardo Neri
HDMI driver to create the platform driver with the required resources. Signed-off-by: Ricardo Neri rn...@dextratech.com --- arch/arm/mach-omap2/devices.c | 24 drivers/video/omap2/dss/hdmi.c | 59 2 files changed, 59 insertions(+), 24

[RESEND PATCH v3 5/5] ARM: OMAP4+: HDMI: Refine the DMA port resource for audio

2013-01-04 Thread Ricardo Neri
such resource. Signed-off-by: Ricardo Neri rn...@dextratech.com --- drivers/video/omap2/dss/hdmi.c |9 ++--- sound/soc/omap/omap-hdmi.c |3 +-- sound/soc/omap/omap-hdmi.h |2 -- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/video/omap2/dss/hdmi.c b/drivers

Re: [PATCH v3 0/5] ARM: OMAP4+: HDMI: Update platform devices for audio

2013-01-03 Thread Ricardo Neri
Hi Mark, Tomi, Just wondering if you had a chance to take a look at these patches. Thanks! Ricardo On 12/17/2012 07:30 PM, Ricardo Neri wrote: Hi Mark, Tomi, Liam, Tony, This set aims to be the version 3 of my previous submission[1] and aims to address the comments that Mark and Tomi kindly

[PATCH v3 1/5] ARM: OMAP4+: HDMI: Rename platform devices for ASoC drivers

2012-12-17 Thread Ricardo Neri
are also updated accordingly. Signed-off-by: Ricardo Neri rn...@dextratech.com --- arch/arm/mach-omap2/devices.c |4 ++-- sound/soc/omap/omap-hdmi-card.c |4 ++-- sound/soc/omap/omap-hdmi.c |2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/arm/mach-omap2

[PATCH v3 2/5] ARM: OMAP4: Assign IDs to DSS HDMI devices

2012-12-17 Thread Ricardo Neri
. Signed-off-by: Ricardo Neri rn...@dextratech.com --- arch/arm/mach-omap2/board-4430sdp.c|3 +++ arch/arm/mach-omap2/board-omap4panda.c |3 +++ 2 files changed, 6 insertions(+) diff --git a/arch/arm/mach-omap2/board-4430sdp.c b/arch/arm/mach-omap2/board-4430sdp.c index 3669c12

[PATCH v3 0/5] ARM: OMAP4+: HDMI: Update platform devices for audio

2012-12-17 Thread Ricardo Neri
are changed to give them more logical and more descriptive names. As the commit commit 14840b9a83c6a56629db2ba0ec247503e975f143 Author: Ricardo Neri ricardo.n...@ti.com Date: Tue Nov 6 00:19:17 2012 -0600 OMAPDSS: HDMI: Create platform device for audio support is reverted in Tomi's git

[PATCH v3 3/5] ARM4: OMAP4+: HDMI: Relocate devices for audio codec and card

2012-12-17 Thread Ricardo Neri
is not implemented. Signed-off-by: Ricardo Neri rn...@dextratech.com --- arch/arm/mach-omap2/board-4430sdp.c|6 -- arch/arm/mach-omap2/board-omap4panda.c |6 -- arch/arm/mach-omap2/devices.c |7 --- arch/arm/mach-omap2/display.c | 31

[PATCH v3 4/5] ARM: OMAP4+: HDMI: Relocate the device for audio interface

2012-12-17 Thread Ricardo Neri
HDMI driver to create the platform driver with the required resources. Signed-off-by: Ricardo Neri rn...@dextratech.com --- arch/arm/mach-omap2/devices.c | 24 drivers/video/omap2/dss/hdmi.c | 59 2 files changed, 59 insertions(+), 24

[PATCH v3 5/5] ARM: OMAP4+: HDMI: Refine the DMA port resource for audio

2012-12-17 Thread Ricardo Neri
such resource. Signed-off-by: Ricardo Neri rn...@dextratech.com --- drivers/video/omap2/dss/hdmi.c |9 ++--- sound/soc/omap/omap-hdmi.c |3 +-- sound/soc/omap/omap-hdmi.h |2 -- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/video/omap2/dss/hdmi.c b/drivers

Re: [PATCH v2 2/2] ARM: OMAP4+: HDMI: Rearrange platform devices for ASoC drivers

2012-11-23 Thread Ricardo Neri
On 11/22/2012 08:12 PM, Mark Brown wrote: On Thu, Nov 22, 2012 at 08:03:53PM -0600, Ricardo Neri wrote: On 11/21/2012 07:03 PM, Mark Brown wrote: instantiation infrastructure in there which is rather Linux specific. But the board files are only for Linux, right? The ASoC drivers

Re: [PATCH v2 2/2] ARM: OMAP4+: HDMI: Rearrange platform devices for ASoC drivers

2012-11-22 Thread Ricardo Neri
Hi Tomi, Mark, On 11/19/2012 07:15 PM, Mark Brown wrote: On Mon, Nov 19, 2012 at 02:58:41PM +0200, Tomi Valkeinen wrote: I still don't understand why the codec and machine drivers need to be created in the board file. That just forces us to replicate the same code for all OMAP boards that

Re: [PATCH v2 2/2] ARM: OMAP4+: HDMI: Rearrange platform devices for ASoC drivers

2012-11-22 Thread Ricardo Neri
Hi Tomi, Sorry for the delayed response. On 11/19/2012 06:58 AM, Tomi Valkeinen wrote: On 2012-11-16 20:05, Ricardo Neri wrote: I hope the explanation above provides more clarity to you. I think HDMI does not fit seamlessly into the ASoC driver model, as we don't have a real codec

Re: [PATCH v2 2/2] ARM: OMAP4+: HDMI: Rearrange platform devices for ASoC drivers

2012-11-22 Thread Ricardo Neri
Hi Mark, On 11/21/2012 07:03 PM, Mark Brown wrote: On Wed, Nov 21, 2012 at 06:20:00PM -0600, Ricardo Neri wrote: On 11/19/2012 07:15 PM, Mark Brown wrote: Yes, this would be more sensible if there's no board specifics involved. I think they are truly board-specific. For instance

Re: [PATCH v2 2/2] ARM: OMAP4+: HDMI: Rearrange platform devices for ASoC drivers

2012-11-22 Thread Ricardo Neri
On 11/22/2012 06:52 AM, Tomi Valkeinen wrote: On 2012-11-22 02:20, Ricardo Neri wrote: Hi Tomi, Mark, On 11/19/2012 07:15 PM, Mark Brown wrote: On Mon, Nov 19, 2012 at 02:58:41PM +0200, Tomi Valkeinen wrote: I still don't understand why the codec and machine drivers need to be created

Re: [PATCH v2 1/2] ARM: OMAP2+: HDMI: Relocate audio platform device creation

2012-11-16 Thread Ricardo Neri
Hi Tomi, On 11/16/2012 01:38 AM, Tomi Valkeinen wrote: Hi, On 2012-11-16 03:36, Ricardo Neri wrote: Creating the accessory devices (such as audio) from the HDMI driver, allows to regard HDMI as a single entity with audio an display functionality. This intends to follow the design of drivers

Re: [PATCH v2 2/2] ARM: OMAP4+: HDMI: Rearrange platform devices for ASoC drivers

2012-11-16 Thread Ricardo Neri
On 11/16/2012 01:52 AM, Tomi Valkeinen wrote: On 2012-11-16 03:36, Ricardo Neri wrote: This relocates and renames the platform devices for ASoC HDMI drivers to give them a more logical structure. The previous omap-hdmi-audio device is renamed as omap-hdmi-audio-card and is relocated

Re: [PATCH 3/3] ASoC: OMAP: HDMI: Obtain DMA port from resources

2012-11-15 Thread Ricardo Neri
Hi Mark, On 11/14/2012 10:10 PM, Mark Brown wrote: On Wed, Nov 14, 2012 at 08:33:11PM -0600, Ricardo Neri wrote: On 11/14/2012 05:08 PM, Mark Brown wrote: Don't do this. With a change like this which must be made at the same time over multiple subsystems it is very important that you send

[PATCH v2 0/2] ARM: OMAP2+: HDMI: Update platform devices for audio

2012-11-15 Thread Ricardo Neri
. This intends to give to the platform devices more descriptive names and create them from more relevant locations. This set of patches requires that commit 14840b9a83c6a56629db2ba0ec247503e975f143 Author: Ricardo Neri ricardo.n...@ti.com Date: Tue Nov 6 00:19:17 2012 -0600 OMAPDSS: HDMI

[PATCH v2 1/2] ARM: OMAP2+: HDMI: Relocate audio platform device creation

2012-11-15 Thread Ricardo Neri
. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- arch/arm/mach-omap2/devices.c | 14 - drivers/video/omap2/dss/hdmi.c | 62 sound/soc/omap/omap-hdmi.c |3 +- sound/soc/omap/omap-hdmi.h |2 - 4 files changed, 63 insertions(+), 18

[PATCH v2 2/2] ARM: OMAP4+: HDMI: Rearrange platform devices for ASoC drivers

2012-11-15 Thread Ricardo Neri
, the name refers only to OMAP HDMI audio functionality, irrespective of the board. The names of the ASoC drivers are also updated accordingly. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- arch/arm/mach-omap2/board-4430sdp.c|6 ++ arch/arm/mach-omap2/board-omap4panda.c |6

Re: [PATCH 3/3] ASoC: OMAP: HDMI: Obtain DMA port from resources

2012-11-15 Thread Ricardo Neri
Hi Tomi, On 11/15/2012 06:36 AM, Tomi Valkeinen wrote: On 2012-11-15 11:45, Tomi Valkeinen wrote: On 2012-11-15 04:33, Ricardo Neri wrote: Hi Mark, On 11/14/2012 05:08 PM, Mark Brown wrote: On Wed, Nov 14, 2012 at 11:07:09AM -0600, Ricardo Neri wrote: On 11/13/2012 09:27 PM, Mark Brown

Re: [PATCH 1/3] ASoC: OMAP: HDMI: Update machine driver name

2012-11-14 Thread Ricardo Neri
Hi Liam, Thanks for reviewing! On 11/14/2012 04:16 AM, Liam Girdwood wrote: On 14/11/12 02:30, Ricardo Neri wrote: Being the name of a machine driver, it aims to describe the connection between the HDMI IP of the processor and the companion chip it uses to connect to the outside world

Re: [PATCH 3/3] ASoC: OMAP: HDMI: Obtain DMA port from resources

2012-11-14 Thread Ricardo Neri
Hi Mark, Thanks for reviewing! On 11/13/2012 09:27 PM, Mark Brown wrote: On Tue, Nov 13, 2012 at 08:30:49PM -0600, Ricardo Neri wrote: Instead of defining the address offset of the DMA port for transfers of audio samples, obtain this information from the resources

Re: [PATCH 3/3] ASoC: OMAP: HDMI: Obtain DMA port from resources

2012-11-14 Thread Ricardo Neri
Hi Mark, On 11/14/2012 05:08 PM, Mark Brown wrote: On Wed, Nov 14, 2012 at 11:07:09AM -0600, Ricardo Neri wrote: On 11/13/2012 09:27 PM, Mark Brown wrote: Presumably this needs some other corresponding change in the resource setup to go in simultaneously... Yes, the change

Re: [PATCH 1/6] ARM/dts: omap4-panda: Add pinmux configuration for HDMI

2012-11-13 Thread Ricardo Neri
Hi Tomi, On 11/05/2012 07:14 AM, Tomi Valkeinen wrote: From: Ricardo Neri ricardo.n...@ti.com Add the pinmux configuration for HDMI and TPD12S015A. Configure the gpios for the TPD12S015A and SDA, SCL and CEC for HDMI. Do you plan to upstream the complete DT-boot support for DSS

[PATCH 0/3] Updated names for ASoC OMAP HDMI drivers

2012-11-13 Thread Ricardo Neri
[1]. http://www.mail-archive.com/linux-omap@vger.kernel.org/msg79795.html Ricardo Neri (3): ASoC: OMAP: HDMI: Update machine driver name ASoC: OMAP: HDMI: Update CPU DAI driver name ASoC: OMAP: HDMI: Obtain DMA port from resources sound/soc/omap/omap-hdmi-card.c |4 ++-- sound/soc

[PATCH 2/3] ASoC: OMAP: HDMI: Update CPU DAI driver name

2012-11-13 Thread Ricardo Neri
. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- sound/soc/omap/omap-hdmi-card.c |2 +- sound/soc/omap/omap-hdmi.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/omap/omap-hdmi-card.c b/sound/soc/omap/omap-hdmi-card.c index 184180e..d6f4dba 100644

[PATCH 1/3] ASoC: OMAP: HDMI: Update machine driver name

2012-11-13 Thread Ricardo Neri
companion chip for DC-DC step-up, I2C level shifter and low-capacitance ESD protection. This chip is used on all OMAP4 Pandaboards an SDPs as well as in OMAP5 EVMs. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- sound/soc/omap/omap-hdmi-card.c |2 +- 1 files changed, 1 insertions(+), 1 deletions

[PATCH 3/3] ASoC: OMAP: HDMI: Obtain DMA port from resources

2012-11-13 Thread Ricardo Neri
Instead of defining the address offset of the DMA port for transfers of audio samples, obtain this information from the resources of the device. This device and its resources are created by the OMAPDSS HDMI driver. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- sound/soc/omap/omap-hdmi.c

[PATCH] OMAPDSS: HDMI: Remove __exit macro from hdmi_uninit_display

2012-11-06 Thread Ricardo Neri
This function is now used in the driver init path to handle probe errors properly. Thus, it may be possible to use this function outside the exit path. Reported-by: Fengguang Wu fengguang...@intel.com Reported-by: Yuanhan Liu yuanhan@linux.intel.com Signed-off-by: Ricardo Neri ricardo.n

Re: [PATCH 1/6] ARM/dts: omap4-panda: Add pinmux configuration for HDMI

2012-11-05 Thread Ricardo Neri
Hi Tomi, On 11/05/2012 07:17 AM, Tomi Valkeinen wrote: Hi Ricardo, On 2012-11-05 15:14, Tomi Valkeinen wrote: From: Ricardo Neri ricardo.n...@ti.com Add the pinmux configuration for HDMI and TPD12S015A. Configure the gpios for the TPD12S015A and SDA, SCL and CEC for HDMI. Signed-off

Re: [PATCH v2 7/7] OMAPDSS: HDMI: Create platform device for audio support

2012-11-05 Thread Ricardo Neri
Hi Tomi, Thanks for reviewing. On 11/05/2012 02:46 AM, Tomi Valkeinen wrote: On 2012-11-03 02:31, Ricardo Neri wrote: Creating the accessory devices, such as audio, from the HDMI driver allows to regard HDMI as a single entity with audio an display functionality. This intends to follow

[PATCH v3 0/7] Create platform device for audio support

2012-11-05 Thread Ricardo Neri
, Ricardo Ricardo Neri (7): OMAPDSS: HDMI: Rename resource variable at probe. OMAPDSS: HDMI: Convert to devm_request_and_ioremap OMAPDSS: HDMI: Make panel return dssdev register errors OMAPDSS: HDMI: Handle panel init error at probe OMAPDSS: HDMI: Uninit display on device add error OMAPDSS

[PATCH v3 1/7] OMAPDSS: HDMI: Rename resource variable at probe.

2012-11-05 Thread Ricardo Neri
Minor cleanup to give to the resource variable a more proper name. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/hdmi.c |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/video/omap2/dss/hdmi.c b/drivers/video/omap2/dss/hdmi.c

[PATCH v3 2/7] OMAPDSS: HDMI: Convert to devm_request_and_ioremap

2012-11-05 Thread Ricardo Neri
Using devm_request_and_ioremap provides better memory handling and improves readability. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/hdmi.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/video/omap2/dss/hdmi.c b/drivers/video

[PATCH v3 6/7] OMAPDSS: HDMI: Add op to get audio DMA port address offset

2012-11-05 Thread Ricardo Neri
It could be possible that the DMA port differs accross diferent HDMI IPs. Thus, add an IP-specific function to obtain the address offset and size of the DMA data port. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/dss_features.c|1 + drivers/video/omap2/dss

[PATCH v3 3/7] OMAPDSS: HDMI: Make panel return dssdev register errors

2012-11-05 Thread Ricardo Neri
Do not assume blindly that the DSS driver was registered successfully. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/hdmi_panel.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/video/omap2/dss/hdmi_panel.c b/drivers/video/omap2

[PATCH v3 5/7] OMAPDSS: HDMI: Uninit display on device add error

2012-11-05 Thread Ricardo Neri
The display must be uninitialized in order to free the requested GPIOs. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/hdmi.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/video/omap2/dss/hdmi.c b/drivers/video/omap2/dss/hdmi.c

[PATCH v3 7/7] OMAPDSS: HDMI: Create platform device for audio support

2012-11-05 Thread Ricardo Neri
are then used by domain-specific drivers; audio in this case. Also, this is in line with the DT implementation of HDMI, in which we will have a single node to describe this feature of the OMAP SoC. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/hdmi.c | 62

[PATCH v3 4/7] OMAPDSS: HDMI: Handle panel init error at probe

2012-11-05 Thread Ricardo Neri
Do not blindly assume that the panel could be initialized. While there, group mutex initialization at a single place. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/hdmi.c | 14 +++--- 1 files changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers

[PATCH v2 0/7] Create platform device for audio support

2012-11-02 Thread Ricardo Neri
. *Obtain the DMA port address offset and size from the HDMI IP-specific library. v1 is accessible here: http://www.mail-archive.com/linux-omap@vger.kernel.org/msg77861.html BR, Ricardo Ricardo Neri (7): OMAPDSS: HDMI: Rename resource variable at probe. OMAPDSS: HDMI: Convert

[PATCH v2 1/7] OMAPDSS: HDMI: Rename resource variable at probe.

2012-11-02 Thread Ricardo Neri
Minor cleanup to give to the resource variable a more proper name. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/hdmi.c |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/video/omap2/dss/hdmi.c b/drivers/video/omap2/dss/hdmi.c

[PATCH v2 2/7] OMAPDSS: HDMI: Convert to devm_request_and_ioremap

2012-11-02 Thread Ricardo Neri
Using devm_request_and_ioremap provides better memory handling and improves readability. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/hdmi.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/video/omap2/dss/hdmi.c b/drivers/video

[PATCH v2 7/7] OMAPDSS: HDMI: Create platform device for audio support

2012-11-02 Thread Ricardo Neri
are then used by domain-specific drivers; audio in this case. Also, this is in line with the DT implementation of HDMI, in which we will have a single node to describe this feature of the OMAP SoC. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/hdmi.c | 62

[PATCH v2 5/7] OMAPDSS: HDMI: Uninit display on device add error

2012-11-02 Thread Ricardo Neri
The display must be uninitialized in order to free the requested GPIOs. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/hdmi.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/video/omap2/dss/hdmi.c b/drivers/video/omap2/dss/hdmi.c

[PATCH v2 4/7] OMAPDSS: HDMI: Handle panel init error at probe

2012-11-02 Thread Ricardo Neri
Do not blindly assume that the panel could be initialized. While there, group mutex initialization at a single place. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/hdmi.c | 14 +++--- 1 files changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers

[PATCH v2 3/7] OMAPDSS: HDMI: Make panel return dssdev register errors

2012-11-02 Thread Ricardo Neri
Do not assume blindly that the DSS driver was registered successfully. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/hdmi_panel.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/video/omap2/dss/hdmi_panel.c b/drivers/video/omap2

[PATCH v2 6/7] OMAPDSS: HDMI: Add op to get audio DMA port address offset

2012-11-02 Thread Ricardo Neri
It could be possible that the DMA port differs accross diferent HDMI IPs. Thus, add an IP-specific function to obtain the address offset and size of the DMA data port. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/dss_features.c|1 + drivers/video/omap2/dss

Re: [PATCH 6/6] OMAPDSS: HDMI: Create platform device to support audio

2012-10-25 Thread Ricardo Neri
On 10/23/2012 11:29 PM, Tomi Valkeinen wrote: On 2012-10-23 20:21, Ricardo Neri wrote: If so, you could pass only that one address, instead of the whole HDMI register space? Yes, that could work. I thought about that but the common HDMI driver would have to know the the IP-specific register

Re: [PATCH 6/6] OMAPDSS: HDMI: Create platform device to support audio

2012-10-25 Thread Ricardo Neri
On 10/25/2012 09:54 AM, Tomi Valkeinen wrote: On 2012-10-25 17:31, Ricardo Neri wrote: On 10/23/2012 11:29 PM, Tomi Valkeinen wrote: On 2012-10-23 20:21, Ricardo Neri wrote: If so, you could pass only that one address, instead of the whole HDMI register space? Yes, that could work. I

Re: [PATCH 6/6] OMAPDSS: HDMI: Create platform device to support audio

2012-10-23 Thread Ricardo Neri
On 10/23/2012 04:37 AM, Tomi Valkeinen wrote: On 2012-10-23 03:48, Ricardo Neri wrote: +#if defined(CONFIG_OMAP4_DSS_HDMI_AUDIO) +#define HDMI_AUDIO_MEM_RESOURCE 0 +#define HDMI_AUDIO_DMA_RESOURCE 1 I don't see much point with these definitions. They are hdmi.c internal, so the audio

Re: [PATCH 6/6] OMAPDSS: HDMI: Create platform device to support audio

2012-10-23 Thread Ricardo Neri
On 10/23/2012 11:17 AM, Tomi Valkeinen wrote: On 2012-10-23 18:42, Ricardo Neri wrote: What registers does the audio side need to access? It only needs access to the DMA audio data port. All other operations that the audio driver needs are done through the omapdss audio interface. Hmm

Re: [PATCH 2/6] OMAPDSS: Convert to devm_ioremap

2012-10-22 Thread Ricardo Neri
Hi Tomi, On 10/22/2012 02:22 AM, Tomi Valkeinen wrote: On 2012-10-16 04:27, Ricardo Neri wrote: Using devm_ioremap provides better memory handling and improves readability. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/hdmi.c | 11 +++ 1 files

Re: [PATCH 6/6] OMAPDSS: HDMI: Create platform device to support audio

2012-10-22 Thread Ricardo Neri
Hi Tomi, Thanks for reviewing! On 10/22/2012 02:40 AM, Tomi Valkeinen wrote: On 2012-10-16 04:27, Ricardo Neri wrote: Creating the accessory devices, such as audio, from the HDMI driver allows to regard HDMI as a single entity with audio an display functionality. This intends to follow

Re: [PATCH 6/6] OMAPDSS: HDMI: Create platform device to support audio

2012-10-16 Thread Ricardo Neri
Hi Peter, Thanks for reviewing! On 10/16/2012 04:30 AM, Péter Ujfalusi wrote: On 10/16/2012 03:27 AM, Ricardo Neri wrote: Creating the accessory devices, such as audio, from the HDMI driver allows to regard HDMI as a single entity with audio an display functionality. This intends to follow

[PATCH 1/6] OMAPDSS: HDMI: Rename resource variable at probe.

2012-10-15 Thread Ricardo Neri
Minor cleanup to give to the resource variable a more proper name. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/hdmi.c |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/video/omap2/dss/hdmi.c b/drivers/video/omap2/dss/hdmi.c

[PATCH 0/6] Create platform device for audio support

2012-10-15 Thread Ricardo Neri
for audio, I also did minor cleanup to the OMAPDSS HDMI driver probe. BR, Ricardo Ricardo Neri (6): OMAPDSS: HDMI: Rename resource variable at probe. OMAPDSS: Convert to devm_ioremap OMAPDSS: HDMI: Make panel return error if cannot register driver OMAPDSS: HDMI: Uninit display if unable

[PATCH 5/6] OMAPDSS: HDMI: Handle error when initing the display at probe

2012-10-15 Thread Ricardo Neri
Do not blindly assume that the panel could be init'ed. While there, put mutex initialization in the same place. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/hdmi.c | 14 +++--- 1 files changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/video

[PATCH 2/6] OMAPDSS: Convert to devm_ioremap

2012-10-15 Thread Ricardo Neri
Using devm_ioremap provides better memory handling and improves readability. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/hdmi.c | 11 +++ 1 files changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/video/omap2/dss/hdmi.c b/drivers/video/omap2

[PATCH 6/6] OMAPDSS: HDMI: Create platform device to support audio

2012-10-15 Thread Ricardo Neri
are then used by domain-specific drivers; audio in this case. Also, this is in line with the DT implementation of HDMI, in which we will have a single node to describe this feature of the OMAP SoC. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/hdmi.c | 68

[PATCH 4/6] OMAPDSS: HDMI: Uninit display if unable to register device

2012-10-15 Thread Ricardo Neri
The display must be uninit'ed in order to free the requested GPIOs. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/hdmi.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/video/omap2/dss/hdmi.c b/drivers/video/omap2/dss/hdmi.c index

[PATCH 3/6] OMAPDSS: HDMI: Make panel return error if cannot register driver

2012-10-15 Thread Ricardo Neri
Do not assume blindly that the DSS driver was registered successfully. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/hdmi_panel.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/video/omap2/dss/hdmi_panel.c b/drivers/video/omap2

Re: [PATCH] ARM: OMAP4: hwmod data: Add McASP data port address space

2012-10-11 Thread Ricardo Neri
Hi Benoit, Thanks for reviewing! On 10/11/2012 05:29 AM, Benoit Cousson wrote: Hi Ricardo, On 10/09/2012 04:15 PM, Ricardo Neri wrote: Hi Benoit, Have you had a chance to look at this patch? Maybe you want me to submit it differently or to a different list? Sorry, I missed it. It looks

Re: [PATCH] ARM: OMAP4: hwmod data: Add McASP data port address space

2012-10-09 Thread Ricardo Neri
Hi Benoit, Have you had a chance to look at this patch? Maybe you want me to submit it differently or to a different list? Thanks! Ricardo On 09/27/2012 11:33 AM, Ricardo Neri wrote: McASP has a configuration port and a data port. This patch adds the address space entry for the data port

[PATCH] ARM: OMAP4: hwmod data: Add McASP data port address space

2012-09-27 Thread Ricardo Neri
McASP has a configuration port and a data port. This patch adds the address space entry for the data port as described in the OMAP4 TRM. Also, add names to the address spaces. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- arch/arm/mach-omap2/omap_hwmod_44xx_data.c |6 ++ 1 files

Re: [alsa-devel] [PATCH v3 00/15] ASoC: OMAP: Convert to use dmaengine

2012-09-24 Thread Ricardo Neri
and this causes a build break with omap2plus_defconfig. Not sure if this is expected, Most likely not. Tested-by: Ricardo Neri ricardo.n...@ti.com Ricardo -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo

Re: [alsa-devel] [RFC] ASoC: snd_soc_jack for HDMI audio: does it make sense?

2012-08-23 Thread Ricardo Neri
Hi Takashi, On 08/22/2012 02:55 AM, Takashi Iwai wrote: At Tue, 21 Aug 2012 19:58:02 -0500, Ricardo Neri wrote: On 08/21/2012 07:39 AM, Clark, Rob wrote: On Tue, Aug 21, 2012 at 1:01 AM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Mon, 2012-08-20 at 20:47 -0500, Ricardo Neri wrote

Re: [RFC] ASoC: snd_soc_jack for HDMI audio: does it make sense?

2012-08-21 Thread Ricardo Neri
On 08/21/2012 07:39 AM, Clark, Rob wrote: On Tue, Aug 21, 2012 at 1:01 AM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Mon, 2012-08-20 at 20:47 -0500, Ricardo Neri wrote: Hello! I have been working on prototypes for the ASoC OMAP HDMI audio driver to propagate events from the HDMI output

Re: [alsa-devel] [RFC] ASoC: snd_soc_jack for HDMI audio: does it make sense?

2012-08-21 Thread Ricardo Neri
On 08/21/2012 08:16 AM, Mark Brown wrote: On Tue, Aug 21, 2012 at 02:30:51PM +0200, David Henningsson wrote: On 08/21/2012 02:05 PM, Mark Brown wrote: - sound/core/ctljack.c which was added later and provides separate in-kernel and userspace APIs and is currently only used by HDA.

[RFC] ASoC: snd_soc_jack for HDMI audio: does it make sense?

2012-08-20 Thread Ricardo Neri
Hello! I have been working on prototypes for the ASoC OMAP HDMI audio driver to propagate events from the HDMI output (e.g., display getting enabled/disabled/suspended). This for the users of the driver to react to such events. For instance, if the display is disabled or disconected, audio

Re: [alsa-devel] [PATCH 07/11] ASoC: omap-mcbsp: Sidetone: Use SIDLE bits in SYSCONFIG register to select noidle mode

2012-08-09 Thread Ricardo Neri
Hi Peter, On 08/09/2012 02:05 AM, Peter Ujfalusi wrote: Hi Ricardo, On 08/09/2012 01:12 AM, Ricardo Neri wrote: Is this another case in which it is required to change the idle-mode on a per-use-case basis? In the past I was trying to do the same with HDMI [1]. In that case it was decided

Re: [alsa-devel] [PATCH 07/11] ASoC: omap-mcbsp: Sidetone: Use SIDLE bits in SYSCONFIG register to select noidle mode

2012-08-08 Thread Ricardo Neri
On 08/08/2012 04:11 AM, Peter Ujfalusi wrote: Instead of the callback (which modifies control module register) use the McBSP module's SYSCONFIG register to disable smart-idle mode when the sidetone is enabled. Store the original SIDLEMODE configuration and restore it when the sidetone has been

Re: [PATCH v3 RESEND] OMAPDSS: DISPC: Improvements to DIGIT sync signal selection

2012-08-01 Thread Ricardo Neri
On 08/01/2012 01:28 AM, Tomi Valkeinen wrote: On Tue, 2012-07-31 at 18:56 -0500, Ricardo Neri wrote: DSS code wrongly assumes that VENC is always available as source for the external sync signal for the display controller DIGIT channel. One cannot blindly write/read the value of DSS_CONTROL

[PATCH v4] OMAPDSS: DISPC: Improvements to DIGIT sync signal selection

2012-08-01 Thread Ricardo Neri
-off-by: Ricardo Neri ricardo.n...@ti.com --- v4: add WARN_ONs to signal invalid selections. v3: instead of BUG_ON calls, select only if both VENC and HDMI are available. v2: use BUG_ON() to simplify handling of invalid cases. drivers/video/omap2/dss/dss.c | 16 ++-- 1 files changed

Re: [PATCH v2] OMAPDSS: DISPC: Improve DIGIT channel sync signal selection

2012-07-31 Thread Ricardo Neri
On 07/31/2012 12:46 AM, Tomi Valkeinen wrote: On Mon, 2012-07-30 at 19:11 -0500, Ricardo Neri wrote: DSS code wrongly assumes that VENC is always available as source for the external sync signal for the display controller DIGIT channel. One cannot blindly rely only on the value of DSS_CONTROL

[no subject]

2012-07-31 Thread Ricardo Neri
From 8b0f9153d078b7182efd604ef8525d50899ce1a3 Mon Sep 17 00:00:00 2001 From: Ricardo Neri ricardo.n...@ti.com Date: Mon, 30 Jul 2012 17:54:59 -0500 Subject: [PATCH v3] OMAPDSS: DISPC: Improvements to DIGIT sync signal selection DSS code wrongly assumes that VENC is always available as source

[PATCH v3 RESEND] OMAPDSS: DISPC: Improvements to DIGIT sync signal selection

2012-07-31 Thread Ricardo Neri
-off-by: Ricardo Neri ricardo.n...@ti.com --- v3: instead of BUG_ON calls, select only if both VENC and HDMI are available. v2: use BUG_ON() to simplify handling of invalid cases. drivers/video/omap2/dss/dss.c | 12 ++-- 1 files changed, 10 insertions(+), 2 deletions(-) diff --git

Re:

2012-07-31 Thread Ricardo Neri
On 07/31/2012 06:52 PM, Ricardo Neri wrote: From 8b0f9153d078b7182efd604ef8525d50899ce1a3 Mon Sep 17 00:00:00 2001 From: Ricardo Neriricardo.n...@ti.com Date: Mon, 30 Jul 2012 17:54:59 -0500 Subject: [PATCH v3] OMAPDSS: DISPC: Improvements to DIGIT sync signal selection A small issue while

Re: [PATCH 0/2] OMAPDSS: DISPC: Improvements to DIGIT sync signal selection

2012-07-30 Thread Ricardo Neri
Hi Tomi, Archit, Thanks for your feedback. On 07/30/2012 06:48 AM, Archit Taneja wrote: On Monday 30 July 2012 04:41 PM, Tomi Valkeinen wrote: On Fri, 2012-07-27 at 19:21 -0500, Ricardo Neri wrote: Hello, DSS code wrongly assumes that VENC is always available as source for the external sync

[PATCH v2] OMAPDSS: DISPC: Improve DIGIT channel sync signal selection

2012-07-30 Thread Ricardo Neri
is selected. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- v2: use BUG_ON() to simplify handling of invalid cases. drivers/video/omap2/dss/dss.c | 13 +++-- 1 files changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/video/omap2/dss/dss.c b/drivers/video/omap2/dss/dss.c

[PATCH] OMAPDSS: HDMI: Disable PLL properly in case of error at power_on

2012-07-30 Thread Ricardo Neri
Small patch to disable the PLL appropriately before runtime_put in case an error occurs while enabling the PHY. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/hdmi.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/video/omap2/dss

[PATCH 0/2] OMAPDSS: DISPC: Improvements to DIGIT sync signal selection

2012-07-27 Thread Ricardo Neri
to correctly set/get the sync signal based on the available displays in the DIGIT channel. For the HDMI driver, handle the error in the selection of the source. BR, Ricardo Ricardo Neri (2): OMAPDSS: DISPC: Improve logic of selection of external sync signal OMAPDSS:HDMI: Improve error handling

[PATCH 1/2] OMAPDSS: DISPC: Improve logic of selection of external sync signal

2012-07-27 Thread Ricardo Neri
/setting the source. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/dss.c | 19 +-- drivers/video/omap2/dss/dss.h |2 +- 2 files changed, 18 insertions(+), 3 deletions(-) diff --git a/drivers/video/omap2/dss/dss.c b/drivers/video/omap2/dss/dss.c

[PATCH 2/2] OMAPDSS:HDMI: Improve error handling at power on

2012-07-27 Thread Ricardo Neri
Handle the errors that may occur when selecting the source of the sync signal for the DIGIT channel of the display controller and when enabling the PHY. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/hdmi.c | 10 -- 1 files changed, 8 insertions(+), 2

[PATCH RESEND] ARM: OMAP4: hwmod data: add HWMOD_SWSUP_SIDLE to dss_hdmi to data

2012-06-20 Thread Ricardo Neri
wrapper audio FIFO. If no-idle mode is not used, audio could be choppy, have bad quality or not be audible at all. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- arch/arm/mach-omap2/omap_hwmod_44xx_data.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach

Re: [RFC] ARM: OMAP4: hwmod data: add HWMOD_SWSUP_SIDLE to dss_hdmi to data

2012-06-19 Thread Ricardo Neri
On 06/18/2012 04:22 PM, Paul Walmsley wrote: Hi On Sat, 16 Jun 2012, Ricardo Neri wrote: I would like to revive an old discussion regarding how to use a particular idle mode for a specific use-case[1]. As per the OMAP4 documentation, audio over HDMI should be transmitted in no-idle mode

[RFC] ARM: OMAP4: hwmod data: add HWMOD_SWSUP_SIDLE to dss_hdmi to data

2012-06-16 Thread Ricardo Neri
/linux-omap@vger.kernel.org/msg60226.html [2].http://www.mail-archive.com/linux-omap@vger.kernel.org/msg60236.html [3].http://www.mail-archive.com/linux-omap@vger.kernel.org/msg60316.html [4].http://www.mail-archive.com/linux-omap@vger.kernel.org/msg60252.html Signed-off-by: Ricardo Neri ricardo.n

Re: Compile err when enable CONFIG_SND_OMAP_SOC_OMAP_HDMI

2012-06-05 Thread Ricardo Neri
Hi Xiao, On 06/04/2012 11:15 PM, Xiao Jiang wrote: Ricardo Neri wrote: Hi Xiao, Tomi, Jarkko, On 05/30/2012 11:27 PM, Xiao Jiang wrote: Ricardo Neri wrote: +Tomi Hi Xiao, On 05/30/2012 02:14 AM, Xiao Jiang wrote: Hello, After enable SND_OMAP_SOC_OMAP_HDMI with omap2plus_defconfig, I got

Re: Compile err when enable CONFIG_SND_OMAP_SOC_OMAP_HDMI

2012-06-04 Thread Ricardo Neri
Hi Xiao, Tomi, Jarkko, On 05/30/2012 11:27 PM, Xiao Jiang wrote: Ricardo Neri wrote: +Tomi Hi Xiao, On 05/30/2012 02:14 AM, Xiao Jiang wrote: Hello, After enable SND_OMAP_SOC_OMAP_HDMI with omap2plus_defconfig, I got some err infos with latest Linus's tree, does somebody also has the same

Re: Compile err when enable CONFIG_SND_OMAP_SOC_OMAP_HDMI

2012-05-30 Thread Ricardo Neri
+Tomi Hi Xiao, On 05/30/2012 02:14 AM, Xiao Jiang wrote: Hello, After enable SND_OMAP_SOC_OMAP_HDMI with omap2plus_defconfig, I got some err infos with latest Linus's tree, does somebody also has the same issue? sound/soc/omap/omap-hdmi.c:45:24: error: field 'dss_audio' has incomplete type

[PATCH] OMAPDSS: HDMI: OMAP4: Update IRQ flags for the HPD IRQ request

2012-05-21 Thread Ricardo Neri
IRQF_ONESHOT. Also, remove the IRQF_DISABLED as the flag is now a NOOP and has been deprecated. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/ti_hdmi_4xxx_ip.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/video/omap2/dss

[PATCH] OMAPDSS: HDMI: OMAP4: Fix request_irq for HPD

2012-05-21 Thread Ricardo Neri
will fail. Also, while there, I removed the IRQF_DISABLED flag as it is now deprecated. If you are OK with the change, I hope it could be merged for K3.5 otherwise HDMI will fail. [1].http://www.spinics.net/lists/linux-tip-commits/msg14974.html Ricardo Neri (1): OMAPDSS: HDMI: OMAP4: Update IRQ

[PATCH 03/11] ASoC: OMAP: HDMI: Change error values in HDMI CPU DAI

2012-05-18 Thread Ricardo Neri
When getting the needed resources fails, return -ENODEV. This is more in line with other drivers do and it gives a more descriptive error. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- sound/soc/omap/omap-hdmi.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git

  1   2   3   >