Re: [PATCHv2 2/2] OMAP: add omap_device_reset()

2011-05-30 Thread Tomi Valkeinen
On Sun, 2011-05-29 at 20:15 -0600, Paul Walmsley wrote: On Fri, 27 May 2011, Tomi Valkeinen wrote: However, VENC doesn't use the standard syscontrol mechanism, so that cannot be done via omap_device interface anyway. struct omap_hwmod_class has a .reset function pointer for this

Re: [PATCHv2 2/2] OMAP: add omap_device_reset()

2011-05-30 Thread Cousson, Benoit
On 5/30/2011 4:15 AM, Paul Walmsley wrote: On Fri, 27 May 2011, Tomi Valkeinen wrote: However, VENC doesn't use the standard syscontrol mechanism, so that cannot be done via omap_device interface anyway. struct omap_hwmod_class has a .reset function pointer for this purpose. It's already

Re: [PATCHv2 2/2] OMAP: add omap_device_reset()

2011-05-29 Thread Paul Walmsley
On Fri, 27 May 2011, Tomi Valkeinen wrote: However, VENC doesn't use the standard syscontrol mechanism, so that cannot be done via omap_device interface anyway. struct omap_hwmod_class has a .reset function pointer for this purpose. It's already been necessary to deal with the I2C IP block:

Re: [PATCHv2 2/2] OMAP: add omap_device_reset()

2011-05-29 Thread Paul Walmsley
Hi Tomi, On Fri, 27 May 2011, Tomi Valkeinen wrote: DSS driver has been designed so that it resets the HW before it begins programming it. That way we get the HW into known state. Otherwise we need to be extra careful to program all possible registers to a sane value. Not impossible, of

Re: [PATCHv2 2/2] OMAP: add omap_device_reset()

2011-05-29 Thread Tomi Valkeinen
On Sun, 2011-05-29 at 20:24 -0600, Paul Walmsley wrote: Hi Tomi, On Fri, 27 May 2011, Tomi Valkeinen wrote: DSS driver has been designed so that it resets the HW before it begins programming it. That way we get the HW into known state. Otherwise we need to be extra careful to program

[PATCHv2 2/2] OMAP: add omap_device_reset()

2011-05-27 Thread Tomi Valkeinen
Add omap_device_reset() function which can be used to reset the hwmods associated with the given platform device. Signed-off-by: Tomi Valkeinen tomi.valkei...@ti.com --- arch/arm/plat-omap/include/plat/omap_device.h |1 + arch/arm/plat-omap/omap_device.c | 23

Re: [PATCHv2 2/2] OMAP: add omap_device_reset()

2011-05-27 Thread Cousson, Benoit
Hi Tomi, On 5/27/2011 9:38 AM, Valkeinen, Tomi wrote: Add omap_device_reset() function which can be used to reset the hwmods associated with the given platform device. We've never exposed it because we are trying to avoid that any driver play with asynchronous HW reset. That can lead to

Re: [PATCHv2 2/2] OMAP: add omap_device_reset()

2011-05-27 Thread Tomi Valkeinen
On Fri, 2011-05-27 at 14:38 +0200, Cousson, Benoit wrote: Hi Tomi, On 5/27/2011 9:38 AM, Valkeinen, Tomi wrote: Add omap_device_reset() function which can be used to reset the hwmods associated with the given platform device. We've never exposed it because we are trying to avoid that

Re: [PATCHv2 2/2] OMAP: add omap_device_reset()

2011-05-27 Thread Cousson, Benoit
On 5/27/2011 2:46 PM, Valkeinen, Tomi wrote: On Fri, 2011-05-27 at 14:38 +0200, Cousson, Benoit wrote: Hi Tomi, On 5/27/2011 9:38 AM, Valkeinen, Tomi wrote: Add omap_device_reset() function which can be used to reset the hwmods associated with the given platform device. We've never exposed

Re: [PATCHv2 2/2] OMAP: add omap_device_reset()

2011-05-27 Thread Santosh Shilimkar
On 5/27/2011 8:13 PM, Cousson, Benoit wrote: On 5/27/2011 2:46 PM, Valkeinen, Tomi wrote: On Fri, 2011-05-27 at 14:38 +0200, Cousson, Benoit wrote: Hi Tomi, On 5/27/2011 9:38 AM, Valkeinen, Tomi wrote: Add omap_device_reset() function which can be used to reset the hwmods associated with the

Re: [PATCHv2 2/2] OMAP: add omap_device_reset()

2011-05-27 Thread Cousson, Benoit
On 5/27/2011 4:51 PM, Shilimkar, Santosh wrote: On 5/27/2011 8:13 PM, Cousson, Benoit wrote: On 5/27/2011 2:46 PM, Valkeinen, Tomi wrote: On Fri, 2011-05-27 at 14:38 +0200, Cousson, Benoit wrote: Hi Tomi, On 5/27/2011 9:38 AM, Valkeinen, Tomi wrote: Add omap_device_reset() function which

Re: [PATCHv2 2/2] OMAP: add omap_device_reset()

2011-05-27 Thread Santosh Shilimkar
On 5/27/2011 8:30 PM, Cousson, Benoit wrote: On 5/27/2011 4:51 PM, Shilimkar, Santosh wrote: On 5/27/2011 8:13 PM, Cousson, Benoit wrote: On 5/27/2011 2:46 PM, Valkeinen, Tomi wrote: On Fri, 2011-05-27 at 14:38 +0200, Cousson, Benoit wrote: Hi Tomi, On 5/27/2011 9:38 AM, Valkeinen, Tomi

Re: [PATCHv2 2/2] OMAP: add omap_device_reset()

2011-05-27 Thread Tomi Valkeinen
On Fri, 2011-05-27 at 16:43 +0200, Cousson, Benoit wrote: On 5/27/2011 2:46 PM, Valkeinen, Tomi wrote: On Fri, 2011-05-27 at 14:38 +0200, Cousson, Benoit wrote: Hi Tomi, On 5/27/2011 9:38 AM, Valkeinen, Tomi wrote: Add omap_device_reset() function which can be used to reset the hwmods