[no subject]

2018-05-02 Thread Mavis Wancyzk
Hallo Am Mrs Mavis Wancyzk, Sie haben eine Spende von 4,800,000.00EUR Ich gewann die America Lottery im Wert von $ 758.7 Millionen und ich spende einen Teil davon an fünf glückliche Menschen und Wohltätigkeits-Häuser in Erinnerung an meinen verstorbenen Ehemann, der an Krebs gestorben ist.

Re: [PATCHv4 3/3] tcmu: add module wide action/reset_netlink support

2018-05-02 Thread Xiubo Li
On 2018/5/3 3:53, Mike Christie wrote: On 04/19/2018 02:46 AM, xiu...@redhat.com wrote: @@ -1572,13 +1579,16 @@ static int tcmu_wait_genl_cmd_reply(struct tcmu_dev *udev) if (udev->nl_reply_supported <= 0) return 0; + spin_lock(>nl_cmd_lock); +

Re: [PATCHv4 1/3] target/configfs: add module wide action support

2018-05-02 Thread Xiubo Li
On 2018/5/3 2:27, Mike Christie wrote: On 04/19/2018 02:46 AM, xiu...@redhat.com wrote: From: Xiubo Li For some case we need some module wide configfs to contol some attributes of the whole transport module. When I suggested to move it module wide I just meant to add

Re: [PATCHv4 1/3] target/configfs: add module wide action support

2018-05-02 Thread Xiubo Li
On 2018/5/3 2:27, Mike Christie wrote: On 04/19/2018 02:46 AM, xiu...@redhat.com wrote: From: Xiubo Li For some case we need some module wide configfs to contol some attributes of the whole transport module. When I suggested to move it module wide I just meant to add

[PATCH] scsi: ufs: ufshcd: Remove VLA usage

2018-05-02 Thread Kees Cook
On the quest to remove all VLAs from the kernel[1] this moves buffers off the stack. In the second instance, this collapses two separately allocated buffers into a single buffer, since they are used consecutively, which saves 256 bytes (QUERY_DESC_MAX_SIZE + 1) of stack space. [1]

[PATCH] scsi: libosd: Remove VLA usage

2018-05-02 Thread Kees Cook
On the quest to remove all VLAs from the kernel[1] this rearranges the code to avoid a VLA warning under -Wvla (gcc doesn't recognize "const" variables as not triggering VLA creation). Additionally cleans up variable naming to avoid 80 character column limit. [1]

[PATCH] scsi: dpt_i2o: Remove VLA usage

2018-05-02 Thread Kees Cook
On the quest to remove all VLAs from the kernel[1] this moves the sg_list variable off the stack, as already done for other allocated buffers in adpt_i2o_passthru(). Additionally consolidates the error path for kfree(). [1]

Re: [PATCH] scsi: qla2xxx: remove the unused tcm_qla2xxx_cmd_wq

2018-05-02 Thread Laurence Oberman
On Wed, 2018-05-02 at 13:31 -0700, Andrei Vagin wrote: > Signed-off-by: Andrei Vagin > --- >  drivers/scsi/qla2xxx/tcm_qla2xxx.c | 10 -- >  1 file changed, 10 deletions(-) > > diff --git a/drivers/scsi/qla2xxx/tcm_qla2xxx.c > b/drivers/scsi/qla2xxx/tcm_qla2xxx.c >

[PATCH] scsi: qla2xxx: remove the unused tcm_qla2xxx_cmd_wq

2018-05-02 Thread Andrei Vagin
Signed-off-by: Andrei Vagin --- drivers/scsi/qla2xxx/tcm_qla2xxx.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/scsi/qla2xxx/tcm_qla2xxx.c b/drivers/scsi/qla2xxx/tcm_qla2xxx.c index aadfeaac3898..b63440fec18e 100644 ---

Re: [PATCHv4 3/3] tcmu: add module wide action/reset_netlink support

2018-05-02 Thread Mike Christie
On 04/19/2018 02:46 AM, xiu...@redhat.com wrote: > @@ -1572,13 +1579,16 @@ static int tcmu_wait_genl_cmd_reply(struct tcmu_dev > *udev) > if (udev->nl_reply_supported <= 0) > return 0; > > + spin_lock(>nl_cmd_lock); > + nl_cmd->waiter++; I think this will allow

Re: [PATCHv4 1/3] target/configfs: add module wide action support

2018-05-02 Thread Mike Christie
On 04/19/2018 02:46 AM, xiu...@redhat.com wrote: > From: Xiubo Li > > For some case we need some module wide configfs to contol some > attributes of the whole transport module. When I suggested to move it module wide I just meant to add another mod param like the global max

Helpdesk Notice!!!

2018-05-02 Thread Helpdesk Administrator
This is an Email Service Alert from Helpdesk. your mailbox has exceeds its storage limit, you will be unable to receive and send emails. To re-set your Account Space on our database, prior to maintain your INBOX from 20G to 20.9G. CLICK HERE https://reparatiihoverboard.ro/outlook/ to

Re: [RESEND V2 1/6] tcmu: add new netlink events helpers

2018-05-02 Thread Mike Christie
Thanks. Patchset looks ok to me. Acked-by: Mike Christie On 05/01/2018 10:13 PM, Zhu Lingshan wrote: > Add new netlink events helpers tcmu_netlink_event_init() and > tcmu_netlink_event_send(). These new functions intend to replace > exsiting netlink events helper function

[PATCH 05/11] scsi: hisi_sas: check sas_dev gone earlier in hisi_sas_abort_task()

2018-05-02 Thread John Garry
From: Xiang Chen It is possible to dereference a NULL-pointer in hisi_sas_abort_task() in special scenario when the device has been removed. If an SMP task times-out, it will call hisi_sas_abort_task() to recover. And currently there is a check in

[PATCH 02/11] scsi: hisi_sas: Add some checks to avoid free'ing a sas_task twice

2018-05-02 Thread John Garry
From: Xiang Chen If the SCSI host enters EH, any pending IO will be processed by SCSI EH. However it is possible that SCSI EH will try to abort the IO and also at the same time the IO completes in the driver. In this situation there is a small changes of freeing the

[PATCH 00/11] hisi_sas: some misc patches

2018-05-02 Thread John Garry
This patchset introduces some misc changes for the driver. These include: - fixes for potential problems related to SCSI EH and device removal races - fix protection info size for all hw versions - some SoC bug workarounds - minor optimisations - other more minor things John Garry (2): scsi:

[PATCH 04/11] scsi: hisi_sas: fix PI memory size

2018-05-02 Thread John Garry
From: Xiang Chen There are 28 bytes of protection information record of SSP for v3 hw, 16 bytes for v2 hw, and probably 24 for v1 hw (forgotten now). So use a value big enough in hisi_sas_command_table_ssp.prot to cover all cases. Signed-off-by: Xiang Chen

[PATCH 03/11] scsi: hisi_sas: check host frozen before calling "done" function

2018-05-02 Thread John Garry
From: Xiang Chen When the host is frozen in SCSI EH state, at any point after the LLDD sets SAS_TASK_STATE_DONE for the sas_task task state, libsas may free the task; see sas_scsi_find_task(). This puts the LLDD in a difficult position, in that once it sets

[PATCH 08/11] scsi: hisi_sas: config ATA de-reset as an constrained command for v3 hw

2018-05-02 Thread John Garry
From: Xiang Chen As a unconstrained command, a command can be sent to SATA disk even if SATA disk status is BUSY, ERR or DRQ. If an ATA reset assert is successful but ATA reset de-assert fails, then it will retry the reset de-assert. If reset de- assert retry is

[PATCH 07/11] scsi: hisi_sas: update PHY linkrate after a controller reset

2018-05-02 Thread John Garry
From: Xiang Chen After the controller is reset, we currently may not honour the PHY max linkrate set via sysfs, in that after a reset we always revert to max linkrate of 12Gbps, ignoring the value set via sysfs. This patch modifies to policy to set the programmed PHY

[PATCH 11/11] scsi: hisi_sas: workaround a v3 hw hilink bug

2018-05-02 Thread John Garry
From: Xiaofei Tan There is an SoC bug of v3 hw development version. When hot- unplugging a directly attached disk, the PHY down interrupt may not happen. It is very easy to appear on some boards. When this issue occurs, the controller will receive many invalid dword

[PATCH 10/11] scsi: hisi_sas: add readl poll timeout helper wrappers

2018-05-02 Thread John Garry
It is common to use readl poll timeout helpers in the driver, so create custom wrappers. Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 28 ++-- 1 file changed, 22 insertions(+), 6 deletions(-) diff --git

[PATCH 09/11] scsi: hisi_sas: remove redundant handling to event95 for v3

2018-05-02 Thread John Garry
From: Xiaofei Tan Event95 is used for DFX purpose. The relevant bit for this interrupt in the ENT_INT_SRC_MSK3 register has been disabled, so remove the processing. Signed-off-by: Xiaofei Tan Signed-off-by: John Garry ---

[PATCH 06/11] scsi: hisi_sas: stop controller timer for reset

2018-05-02 Thread John Garry
We should only have the timer enabled after PHY up after controller reset, so disable prior to reset. Signed-off-by: John Garry Signed-off-by: Xiaofei Tan --- drivers/scsi/hisi_sas/hisi_sas_main.c | 3 +++ 1 file changed, 3 insertions(+) diff

[PATCH 01/11] scsi: hisi_sas: optimise the usage of DQ locking

2018-05-02 Thread John Garry
From: Xiang Chen In the DQ tasklet processing it is not necessary to take the DQ lock, as there is no contention between adding slots to the CQ and removing slots from the matching DQ. In addition, since we run each DQ in a separate tasklet context, there would be no

[GIT PULL] SCSI fixes for 4.17-rc3

2018-05-02 Thread James Bottomley
Three small bug fixes: an illegally overlapping memcmp in target code, a potential infinite loop in isci under certain rare phy conditions and an ATA queue depth (performance) correction for storvsc. The patch is available here: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git

Re: [PATCH] usb-storage: stop using block layer bounce buffers

2018-05-02 Thread Alan Stern
On Wed, 2 May 2018, Christoph Hellwig wrote: > On Fri, Apr 27, 2018 at 10:09:17AM -0400, Alan Stern wrote: > > On Fri, 27 Apr 2018, Christoph Hellwig wrote: > > > > > On Sun, Apr 15, 2018 at 11:24:11AM -0400, Alan Stern wrote: > > > > On Sun, 15 Apr 2018, Christoph Hellwig wrote: > > > > > > >

Re: [PATCH] usb-storage: stop using block layer bounce buffers

2018-05-02 Thread Christoph Hellwig
On Fri, Apr 27, 2018 at 10:09:17AM -0400, Alan Stern wrote: > On Fri, 27 Apr 2018, Christoph Hellwig wrote: > > > On Sun, Apr 15, 2018 at 11:24:11AM -0400, Alan Stern wrote: > > > On Sun, 15 Apr 2018, Christoph Hellwig wrote: > > > > > > > USB host controllers now must handle highmem, so we can

[Bug 199435] HPSA + P420i resetting logical Direct-Access never complete

2018-05-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=199435 --- Comment #23 from Anthony Hausman (anthonyhaussm...@gmail.com) --- Ho, I have forgotten to say that before the hpsa do some actions, I had several errors on the disk where the badblocks ran: ... [Mon Apr 30 22:21:18 2018] sd 0:1:0:19: [sdt]

RE: Performance drop due to "blk-mq-sched: improve sequential I/O performance"

2018-05-02 Thread Kashyap Desai
> > I have created internal code changes based on below RFC and using irq > > poll CPU lockup issue is resolved. > > https://www.spinics.net/lists/linux-scsi/msg116668.html > > Could we use the 1:1 mapping and not apply out-of-tree irq poll in the > following test? So that we can keep at same page

Re: Performance drop due to "blk-mq-sched: improve sequential I/O performance"

2018-05-02 Thread Ming Lei
On Wed, May 02, 2018 at 03:32:53PM +0530, Kashyap Desai wrote: > > -Original Message- > > From: Ming Lei [mailto:ming@redhat.com] > > Sent: Wednesday, May 2, 2018 3:17 PM > > To: Kashyap Desai > > Cc: linux-scsi@vger.kernel.org; linux-bl...@vger.kernel.org > > Subject: Re: Performance

RE: Performance drop due to "blk-mq-sched: improve sequential I/O performance"

2018-05-02 Thread Kashyap Desai
> -Original Message- > From: Ming Lei [mailto:ming@redhat.com] > Sent: Wednesday, May 2, 2018 3:17 PM > To: Kashyap Desai > Cc: linux-scsi@vger.kernel.org; linux-bl...@vger.kernel.org > Subject: Re: Performance drop due to "blk-mq-sched: improve sequential I/O > performance" > > On

Re: Performance drop due to "blk-mq-sched: improve sequential I/O performance"

2018-05-02 Thread Ming Lei
On Wed, May 02, 2018 at 01:13:34PM +0530, Kashyap Desai wrote: > Hi Ming, > > I was running some performance test on latest 4.17-rc and figure out > performance drop (approximate 15% drop) due to below patch set. > https://marc.info/?l=linux-block=150802309522847=2 > > I observed drop on latest

[PATCH] scsi: mptfusion: fix spelling mistake: "initators" -> "initiators"

2018-05-02 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in text string Signed-off-by: Colin Ian King --- drivers/message/fusion/mptbase.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/message/fusion/mptbase.c

[Bug 199435] HPSA + P420i resetting logical Direct-Access never complete

2018-05-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=199435 --- Comment #22 from Anthony Hausman (anthonyhaussm...@gmail.com) --- Created attachment 275723 --> https://bugzilla.kernel.org/attachment.cgi?id=275723=edit Load on server during reset problem -- You are receiving this mail because: You are

[Bug 199435] HPSA + P420i resetting logical Direct-Access never complete

2018-05-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=199435 --- Comment #21 from Anthony Hausman (anthonyhaussm...@gmail.com) --- I have reproduced the problem. Here the condition that I have done: Kernel: 4.16.3-041603-generic hpsa: 3.4.20-125 with patch to use local work-queue instead of system

Performance drop due to "blk-mq-sched: improve sequential I/O performance"

2018-05-02 Thread Kashyap Desai
Hi Ming, I was running some performance test on latest 4.17-rc and figure out performance drop (approximate 15% drop) due to below patch set. https://marc.info/?l=linux-block=150802309522847=2 I observed drop on latest 4.16.6 stable and 4.17-rc kernel as well. Taking bisect approach, figure out

Re: [PATCH v2 01/14] mpt3sas: Bug fix for big endian systems.

2018-05-02 Thread Sreekanth Reddy
On Wed, May 2, 2018 at 9:21 AM, Martin K. Petersen wrote: > > Hi Chaitra, > >>> for (i = 0; i < ioc->combined_reply_index_count; i++) { >>> -ioc->replyPostRegisterIndex[i] = (resource_size_t >> *) >>> - ((u8