Re: [PATCH] mpt3sas: correct reset of smid while clearing scsi tracker

2018-07-23 Thread Sreekanth Reddy
Any update on this patch!. Thanks, Sreekanth On Fri, Jul 20, 2018 at 5:56 PM, Sreekanth Reddy wrote: > In mpt3sas_base_clear_st() function smid value is reseted in wrong line, > i.e. driver should reset smid value to zero after decrementing chain_offset > counter in chain_lookup table but in

[PATCH 9/9] tcmu: use u64 for dev_size

2018-07-23 Thread Mike Christie
We use unsigned long, size_t and u64 for dev_size. This has us standardize on u64. Signed-off-by: Mike Christie --- drivers/target/target_core_user.c | 21 - 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/drivers/target/target_core_user.c

[PATCH 5/9] tcmu: check if dev is configured before block/reset

2018-07-23 Thread Mike Christie
Do not allow userspace to block or reset the ring until the device has been configured. This will prevent the bug where userspace can write to those files and access mb_addr before it has been setup. Signed-off-by: Mike Christie --- drivers/target/target_core_user.c | 10 ++ 1 file

[PATCH 4/9] tcmu: use lio core se_device configuration helper

2018-07-23 Thread Mike Christie
Use the lio core helper to check if the device is configured. Signed-off-by: Mike Christie --- drivers/target/target_core_user.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/target/target_core_user.c b/drivers/target/target_core_user.c index

[PATCH 8/9] tcmu: use match_int for dev params

2018-07-23 Thread Mike Christie
Instead of doing strdup and kstrto* just use match_int for dev params. It will be ok to use int instead of unsigned long in tcmu_set_dev_attrib because that is only being used for max sectors and block size and the supported values for them are well under the max possible integer value.

[PATCH 7/9] tcmu: do not set max_blocks if data_bitmap has been setup

2018-07-23 Thread Mike Christie
This patch prevents a bug where data_bitmap is allocated in tcmu_configure_device, userspace changes the max_blocks setting, the device is mapped to a LUN, then we try to access the data_bitmap based on the new max_blocks limit which may now be out of range. To prevent this, we just check if

[PATCH 0/9] tcmu: configuration fixes and cleanups

2018-07-23 Thread Mike Christie
The following patches were made over Martin's for-next branch. The first patch fixes a locking bug in the command setup path. The rest of the patches fix several bugs and cleanup the setup and configuration code paths.

[PATCH 2/9] tcmu: initialize list head

2018-07-23 Thread Mike Christie
Use INIT_LIST_HEAD to initialize node list head. Signed-off-by: Mike Christie --- drivers/target/target_core_user.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/target/target_core_user.c b/drivers/target/target_core_user.c index fafe65f..b010ed7 100644 ---

[PATCH 6/9] tcmu: unmap if dev is configured

2018-07-23 Thread Mike Christie
The tcmu dev is added to the list of tcmu devices during configuration. At this time the tcmu setup has completed, but lio core has not completed its setup. The device is not yet usable so do not try to unmap blocks from it Signed-off-by: Mike Christie --- drivers/target/target_core_user.c | 5

[PATCH 3/9] target: add helper to check if dev is configured

2018-07-23 Thread Mike Christie
This just adds a helper function to check if a device is configured and it converts the target users to use it. The next patch will add a backend module user so those types of modules do not have to know the lio core details. Signed-off-by: Mike Christie ---

[PATCH 1/9] target_core_user: fix double unlock

2018-07-23 Thread Mike Christie
The caller of queue_cmd_ring grabs and releases the lock, so the tcmu_setup_cmd_timer failure handling inside queue_cmd_ring should not call mutex_unlock. Signed-off-by: Mike Christie --- drivers/target/target_core_user.c | 1 - 1 file changed, 1 deletion(-) diff --git

[no subject]

2018-07-23 Thread Mavis Wancyzk
-- Hallo Am Mrs Mavis Wancyzk, Sie haben eine Spende von 4,800,000.00EUR Ich gewann die America Lottery im Wert von $ 758.7 Millionen und ich spende einen Teil davon an fünf glückliche Menschen und Wohltätigkeits-Häuser in Erinnerung an meinen verstorbenen Ehemann, der an Krebs gestorben ist.