On 12/2/18 11:13 PM, Finn Thain wrote:
On Sun, 2 Dec 2018, Hannes Reinecke wrote:
On 12/2/18 10:21 PM, Finn Thain wrote:
On Sun, 2 Dec 2018, Hannes Reinecke wrote:
Well, that lone 'kmap' is due to a quirk/errata in the datasheet;
essentially
we have to PIO a lone byte out of the FIFO
On 12/2/18 10:21 PM, Finn Thain wrote:
On Sun, 2 Dec 2018, Hannes Reinecke wrote:
Well, that lone 'kmap' is due to a quirk/errata in the datasheet; essentially
we have to PIO a lone byte out of the FIFO to clear it up.
And this byte is technically still part of the SCSI data, so we need
On 11/26/18 10:46 AM, Finn Thain wrote:
On Mon, 26 Nov 2018, Christoph Hellwig wrote:
On Thu, Nov 22, 2018 at 09:02:13AM +1100, Finn Thain wrote:
you in the To list maintain or wrote SCSI drivers that set the
DISABLE_CLUSTERING flag, which basically disable merges of any
bio segments. We
On 12/1/18 12:34 AM, David Disseldorp wrote:
Initialise the t10_wwn vendor, model and revision defaults when a
device is allocated instead of when it's enabled. This ensures that
custom vendor or model strings set prior to enablement are not later
overwritten with default values.
Signed-off-by:
ers/target/target_core_spc.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
I would have merged it with the previous patch, but anyway:
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
en wanting to do this for a long time now ...
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
-
drivers/target/target_core_spc.c | 7 ++---
drivers/target/target_core_stat.c | 32 +--
include/target/target_core_base.h | 14 +++---
6 files changed, 61 insertions(+), 73 deletions(-)
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
-by: David Disseldorp
Reviewed-by: Christoph Hellwig
Reviewed-by: Bryant G. Ly
Reviewed-by: Lee Duncan
---
drivers/target/target_core_spc.c | 17 -
1 file changed, 12 insertions(+), 5 deletions(-)
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
On 11/16/18 3:19 PM, Steffen Maier wrote:
On 11/16/2018 12:17 PM, Hannes Reinecke wrote:
On 11/8/18 3:44 PM, Steffen Maier wrote:
Use the already defined enum for this purpose to get at least some build
checking (even though an enum is type equivalent to an int in C).
v2.6.27 commit
| 4
drivers/scsi/megaraid/megaraid_sas_base.c | 15 +++
2 files changed, 19 insertions(+)
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49 911 74053
default:
- return NULL;
}
WARN_ON_ONCE(erp_action->adapter != adapter);
Same here.
If you don't expect the code to run into this case, please do add a
WARN_ON() or something so that it can be tracked down.
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage
need = 0;
- break;
}
return need;
If you 'should' not run through this code path, doesn't it warrant a
WARN_ON() or something?
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49
/* already closed, fall through */
+ /* already closed */
+ /* fall through */
case ZFCP_ERP_STEP_LUN_CLOSING:
if (atomic_read(_sdev->status) & ZFCP_STATUS_COMMON_OPEN)
return ZFCP_ERP_FAILED;
Review
+-
drivers/s390/scsi/zfcp_fsf.c | 14 +-
drivers/s390/scsi/zfcp_qdio.c | 3 +--
5 files changed, 22 insertions(+), 16 deletions(-)
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@sus
deletions(-)
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmany
zfcp_scsi_dev_lun(sdev),
(unsigned long long)zfcp_sdev->port->wwpn,
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49 911 7405
unlock:
write_unlock_irqrestore(>erp_lock, flags);
- if (retval != ZFCP_ERP_CONTINUES)
- zfcp_erp_action_cleanup(erp_action, retval);
+ if (result != ZFCP_ERP_CONTINUES)
+ zfcp_erp_action_cleanup(erp_action, result);
kref_put(>ref, zfcp
cify all remaining
cases, so 'default:' seems to match here pretty well ...
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J.
wed-by: Benjamin Block
---
drivers/s390/scsi/zfcp_dbf.c | 2 +-
drivers/s390/scsi/zfcp_def.h | 20 +++-
drivers/s390/scsi/zfcp_erp.c | 77 +---
3 files changed, 56 insertions(+), 43 deletions(-)
Reviewed-by: Hannes Reinecke
Cheers,
Hann
gned-off-by: Steffen Maier
Reviewed-by: Benjamin Block
---
drivers/s390/scsi/zfcp_erp.c | 92 ++-
drivers/s390/scsi/zfcp_ext.h | 8 ++--
drivers/s390/scsi/zfcp_qdio.c | 8 ++--
3 files changed, 57 insertions(+), 51 deletions(-)
Reviewed-by: Hannes R
up - Start ERP thread for adapter
* @adapter: Adapter to start the ERP thread for
*
- * Returns 0 on success or error code from kernel_thread()
+ * Return: 0 on success, or error code from kthread_run().
*/
int zfcp_erp_thread_setup(struct zfcp_adapter *adapter)
{
Reviewed-by: Hanne
req->qtcb->bottom.io.fcp_cmnd_length);
zfcp_erp_adapter_shutdown(req->adapter, 0, "fssfch4");
req->status |= ZFCP_STATUS_FSFREQ_ERROR;
break;
Really? You're only fixing the message, not the adapter behaviour.
Ca
Maier
Reviewed-by: Benjamin Block
---
drivers/s390/scsi/zfcp_dbf.c | 2 +-
drivers/s390/scsi/zfcp_def.h | 2 --
drivers/s390/scsi/zfcp_fsf.c | 1 -
3 files changed, 1 insertion(+), 4 deletions(-)
Makes one wonder what we need the sequence number for ...
Reviewed-by: Hannes Reinecke
4 ++--
drivers/s390/scsi/zfcp_def.h | 7 +--
drivers/s390/scsi/zfcp_fsf.c | 14 ++
drivers/s390/scsi/zfcp_scsi.c | 4 +++-
5 files changed, 20 insertions(+), 17 deletions(-)
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Stor
; /* requested action code */
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upm
| 4 ++--
2 files changed, 9 insertions(+), 9 deletions(-)
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
G
-by: Steffen Maier
Reviewed-by: Benjamin Block
---
drivers/s390/scsi/zfcp_def.h | 58 ++--
1 file changed, 29 insertions(+), 29 deletions(-)
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networki
is a mask for bitwise 'and' with status values.
*/
#define ZFCP_COMMON_FLAGS 0xfff0
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49 911 74053 688
S
nitialized by
scsi_device->eh_timeout ...
But that's probably something for a bigger review affecting all drivers.
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49 911 74053 688
t;zfcp_qdio.h"
-struct zfcp_reqlist;
-
/* SCSI SPECIFIC DEFINES
*/
#define ZFCP_SCSI_ER_TIMEOUT(10*HZ)
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Sto
ons(+), 45 deletions(-)
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild,
`pool'
pointer in mempool_destroy()")]
Signed-off-by: Steffen Maier
---
drivers/s390/scsi/zfcp_aux.c | 21 +++--
1 file changed, 7 insertions(+), 14 deletions(-)
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networkin
LPFC_SLI3_CRP_ENABLED |
- LPFC_SLI3_BG_ENABLED |
LPFC_SLI3_DSS_ENABLED);
if (rc != MBX_SUCCESS) {
lpfc_printf_log(phba, KERN_ERR, LOG_INIT,
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes Reinecke
On 11/15/18 5:40 PM, Ewan D. Milne wrote:
On Thu, 2018-11-15 at 13:52 +0100, Hannes Reinecke wrote:
On 11/14/18 6:13 PM, Ewan D. Milne wrote:
On Tue, 2018-11-13 at 09:49 -0800, Bart Van Assche wrote:
On Tue, 2018-11-13 at 17:38 +, Madhani, Himanshu wrote:
On Nov 13, 2018, at 6:23 AM
OT_ do this; better rely on common mechanisms here.
And please, next time please cc linux-nvme so that we can track it better.
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49 911 74053 688
SUSE LIN
. *
***/
-#define LPFC_DRIVER_VERSION "12.0.0.7"
+#define LPFC_DRIVER_VERSION "12.0.0.8"
#define LPFC_DRIVER_NAME "lpfc"
/* Used for SLI 2/3 */
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Sto
/scsi/lpfc/lpfc_sli.c | 11 +++
drivers/scsi/lpfc/lpfc_sli4.h| 13
12 files changed, 474 insertions(+)
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49 911
+
drivers/scsi/lpfc/lpfc_els.c | 10 +-
drivers/scsi/lpfc/lpfc_hbadisc.c | 29 ++
drivers/scsi/lpfc/lpfc_hw.h| 1 +
drivers/scsi/lpfc/lpfc_hw4.h | 4 +
drivers/scsi/lpfc/lpfc_nportdisc.c | 13 ++-
9 files changed, 275 insertions(+), 4 deletions(-)
Reviewed-by: Hannes
in this area as well.
Signed-off-by: Dick Kennedy
Signed-off-by: James Smart
---
drivers/scsi/lpfc/lpfc_els.c | 27 +++
drivers/scsi/lpfc/lpfc_nportdisc.c | 5 +++--
2 files changed, 26 insertions(+), 6 deletions(-)
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
| 1 +
drivers/scsi/lpfc/lpfc_els.c | 66
drivers/scsi/lpfc/lpfc_hbadisc.c | 9 ++
3 files changed, 64 insertions(+), 12 deletions(-)
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
l_els_rsp;
phba->fc_stat.elsXmitLSRJT++;
rc = lpfc_sli_issue_iocb(phba, LPFC_ELS_RING, elsiocb, 0);
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
to
be related to not performing FCF discovery between FLOGI's.
Fix by monitoring FLOGI failures and once a repeated error is
seen repeat FCF discovery.
Signed-off-by: Dick Kennedy
Signed-off-by: James Smart
---
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
to dynamically
update.
Signed-off-by: Dick Kennedy
Signed-off-by: James Smart
---
drivers/scsi/lpfc/lpfc_bsg.c | 64 +---
1 file changed, 25 insertions(+), 39 deletions(-)
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
insertions(+), 1 deletion(-)
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
| 49 --
drivers/scsi/lpfc/lpfc_nportdisc.c | 5
2 files changed, 26 insertions(+), 28 deletions(-)
Good point about being able to ignore LOGO failures :-)
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
phba);
if (vports != NULL) {
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
(-)
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
testing here.
I've found that testing on large configurations on iSER or SRP tend to
excite the issues.
Can you check against those, too?
I'll see to give it a spin on my test bed.
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@sus
On 10/22/18 10:17 AM, John Garry wrote:
On 19/10/2018 17:46, chris.mo...@microchip.com wrote:
-Original Message-
From: linux-scsi-ow...@vger.kernel.org On Behalf Of John Garry
Sent: Friday, October 19, 2018 2:19 AM
To: Chris Moore - C33997 ; h...@suse.de;
linux-scsi@vger.kernel.org;
devsize);
}
raid_set_resync(myrs_raid_template, dev, percent_complete);
}
Thanks James.
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
The WARN_ON() is pointless as the rport is placed in SDEV_TRANSPORT_OFFLINE
at that time, so no new commands can be submitted via srp_queuecommand()
Signed-off-by: Hannes Reinecke
Reviewed-by: Jens Axboe
Reviewed-by: Johannes Thumshirn
---
drivers/infiniband/ulp/srp/ib_srp.c | 7 ---
1
The WARN_ON() is pointless as the rport is placed in SDEV_TRANSPORT_OFFLINE
at that time, so no new commands can be submitted via srp_queuecommand()
Signed-off-by: Hannes Reinecke
Reviewed-by: Jens Axboe
Reviewed-by: Johannes Thumshirn
---
drivers/infiniband/ulp/srp/ib_srp.c | 7
1
Indeed.
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu,
--
include/linux/blkdev.h| 7 ++
9 files changed, 194 insertions(+), 198 deletions(-)
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de
request.
Signed-off-by: Damien Le Moal
Reviewed-by: Christoph Hellwig
---
block/blk-zoned.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@sus
goto err;
+ }
/* The drive satisfies the kernel restrictions: set it up */
ret = sd_zbc_setup(sdkp, zone_blocks);
Remaining bits are okay.
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49
lpfc_nlp_get() in lpfc_els_unsol_buffer() is not running under a
lock, so there is a chance that it might actually fail. But as we
never check the return value we'll get a crash in lpfc_nlp_put()
later on trying to free an invalid buffer.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/lpfc
ecking the device after RSCN is a sensible choice.
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D.
From: Hannes Reinecke
When an RSCN gets delayed (or not being sent at all) the transport
class will detect an error, EH kicks in, and eventually will be
setting the device to offline.
If we receive an RSCN after that the device will stay in 'offline'.
This patch allows for an 'offline
From: Hannes Reinecke
When we fail to analyse the payload of a PRLI response we should
reset the state machine to retry the PRLI; eventually we will be
getting a proper frame.
Not doing so will result in a stuck state machine and the port
never to be presented to the systsm.
Suggested-by: Chad
from
OFFLINE to BLOCKED, as during RSCN processing the devices
will be set to blocked, and so I found it only reasonable
to allow this transition.
But as usual, comments and reviews are welcome.
Hannes Reinecke (2):
scsi: Allow state transitions from OFFLINE to BLOCKED
libfc: retry PRLI if we
From: Thomas Abraham
We should not assume the payload of a PRLI or PLOGI
respons is always present.
Signed-off-by: Thomas Abraham
Reviewed-by: Hannes Reinecke
---
drivers/scsi/libfc/fc_rport.c | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi
ppreciated, and you really would
get brownie points if you make this generic for the block layer :-)
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnbe
or
vanishes.
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
The WARN_ON() is pointless as the rport is placed in SDEV_TRANSPORT_OFFLINE
at that time, so no new commands can be submitted via srp_queuecomment()
Signed-off-by: Hannes Reinecke
---
drivers/infiniband/ulp/srp/ib_srp.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers
On 09/05/2018 04:09 PM, Martin Wilck wrote:
> On Wed, 2018-09-05 at 15:53 +0200, Hannes Reinecke wrote:
>> test_bit() is atomic, test_bit() || test_bit() is not.
>> So protect consecutive bit tests with a lock to avoid races.
>>
>> Signed-off-by: Hannes Reinecke
&
Signed-off-by: Hannes Reinecke
---
drivers/scsi/qedf/qedf_main.c | 11 ---
1 file changed, 11 deletions(-)
diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c
index 3407a05e898b..2bedad13f3f4 100644
--- a/drivers/scsi/qedf/qedf_main.c
+++ b/drivers/scsi/qedf
and reviews are welcome.
Hannes Reinecke (5):
qedf: fixup bit operations
qedf: fixup locking in qedf_restart_rport()
qedf: missing kref_put in qedf_xmit()
qedf: remove stale variables in qedf_eh_XXX functions
qedf: fc_rport_priv reference counting fixes
drivers/scsi/qedf/qedf_els.c | 26
qedf_xmit() calls fc_rport_lookup(), but discards the returned
rdata structure almost immediately without decreasing the refcount.
This leads to a refcount leak and the rdata never to be freed.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/qedf/qedf_main.c | 4 +++-
1 file changed, 3
The fc_rport_priv structure is reference counted, so we need to
ensure that the reference is increased before accessing the structure.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/qedf/qedf_els.c | 12 ++--
drivers/scsi/qedf/qedf_io.c | 32 ++--
drivers
test_bit() is atomic, test_bit() || test_bit() is not.
So protect consecutive bit tests with a lock to avoid races.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/qedf/qedf_els.c | 9 +++--
drivers/scsi/qedf/qedf_main.c | 5 -
2 files changed, 11 insertions(+), 3 deletions(-)
diff
fc_rport_create() needs to be called with disc_mutex held.
And we should re-assign the 'rdata' pointer in case it got changed.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/qedf/qedf_els.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/qedf/qedf_els.c b
n, cnt, PCI_IRQ_MSIX);
> if (cnt < 0)
> return cnt;
>
>
Hmm.
That patch (and the reasoning leading up to it) really sound dodgy.
I'd rather fix the interrupt affinity code to handle this case correctly.
Thomas, can you help here?
Cheers,
Hannes
--
Dr. Hannes Reineck
On 07/30/2018 08:01 PM, Bart Van Assche wrote:
On Sun, 2018-07-29 at 16:33 +0300, Avri Altman wrote:
Here is a proposal to use the scsi transport subsystem to manage
ufs devices.
scsi transport is a framework that allow to send scsi commands to
a non-scsi devices. Still, it is flexible enough
fc_rport_recv_plogi_req() needs the lport mutex to be held; the
rport mutex will be acquired in the function itself.
Fixes: ee35624e1e4e ("scsi: libfc: Add lockdep annotations")
Reported-by: Stephen Rothwell
Signed-off-by: Hannes Reinecke
---
drivers/scsi/libfc/fc_rport.c | 2
() /
fc_rport_logoff(), which in turn would be acquiring a mutex.
So this patchset fixes up the remoaining uses, and also adds a warining
to catch reference counting issues.
As usual, comments and reviews are welcome.
Hannes Reinecke (4):
libfc: fixup lockdep annotations
libfc: hold disc_mutex
of a list.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/libfc/fc_rport.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/libfc/fc_rport.c b/drivers/scsi/libfc/fc_rport.c
index 3d51a936f6d5..d69531ab2db8 100644
--- a/drivers/scsi/libfc/fc_rport.c
+++ b/drivers/scsi/libfc/fc_rport.c
Signed-off-by: Hannes Reinecke
---
drivers/scsi/libfc/fc_disc.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/scsi/libfc/fc_disc.c b/drivers/scsi/libfc/fc_disc.c
index c1756b9b3ea5..f969a71348ef 100644
--- a/drivers/scsi/libfc/fc_disc.c
+++ b/drivers/scsi/libfc
to use krefs to ensure that the rport
object will not be freed from under us.
Fixes: a407c593398c ("scsi: libfc: Fixup disc_mutex handling")
Signed-off-by: Hannes Reinecke
---
drivers/scsi/fcoe/fcoe_ctlr.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git
any list manipulation.
Fixes: a407c593398c ("scsi: libfc: Fixup disc_mutex handling")
Signed-off-by: Hannes Reinecke
---
drivers/scsi/libfc/fc_disc.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/libfc/fc_disc.c b/drivers/scsi/libfc/fc_di
any list manipulation.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/libfc/fc_disc.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/libfc/fc_disc.c b/drivers/scsi/libfc/fc_disc.c
index 6125df787200..c1756b9b3ea5 100644
--- a/drivers/scsi/libfc/fc_disc.c
Convert the free text locking notes into proper lockdep annotations.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/libfc/fc_disc.c | 32 +
drivers/scsi/libfc/fc_lport.c | 108 +-
drivers/scsi/libfc/fc_rport.c | 99
unsigned char *rec;
> unsigned int buf_len;
> unsigned int list_length;
> - int ret;
> + s64 ret;
> u8 same;
>
> /* Get a buffer */
>
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage
On 06/23/2018 12:22 PM, Douglas Gilbert wrote:
The scsi_io_completion function contains three BUG() and BUG_ON() calls.
Replace them with WARN variants.
Signed-off-by: Douglas Gilbert
Reviewed-by: Johannes Thumshirn
Reviewed-by: Bart Van Assche
---
drivers/scsi/scsi_lib.c | 15
; this should allow more other code to fit in the instruction
cache.
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
-by: Bart Van Assche
---
drivers/scsi/scsi_lib.c | 41 ++---
1 file changed, 18 insertions(+), 23 deletions(-)
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
's name.
Signed-off-by: Douglas Gilbert
Reviewed-by: Johannes Thumshirn
Reviewed-by: Bart Van Assche
---
drivers/scsi/scsi_lib.c | 329 +---
1 file changed, 175 insertions(+), 154 deletions(-)
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
drivers/scsi/scsi_lib.c | 132 +++-
1 file changed, 75 insertions(+), 57 deletions(-)
Still looks ugly, but then it's only a helper function.
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
++---
1 file changed, 39 insertions(+), 33 deletions(-)
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
_status_t error,
unsigned int bytes, unsigned int bidi_bytes)
{
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
mes.sm...@broadcom.com>
> ---
> drivers/scsi/lpfc/lpfc_init.c | 21 ++---
> 1 file changed, 18 insertions(+), 3 deletions(-)
>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
> Signed-off-by: James Smart <james.sm...@broadcom.com>
> ---
> drivers/scsi/lpfc/lpfc_nvme.c | 9 +
> 1 file changed, 9 insertions(+)
>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
gt;
> Signed-off-by: James Smart <james.sm...@broadcom.com>
> ---
> drivers/scsi/lpfc/lpfc_hw4.h | 11 ---
> drivers/scsi/lpfc/lpfc_init.c | 9 +
> drivers/scsi/lpfc/lpfc_sli4.h | 1 -
> 3 files changed, 1 insertion(+), 20 deletions(-)
>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
h
> @@ -20,7 +20,7 @@
> * included with this package. *
> ***/
>
> -#define LPFC_DRIVER_VERSION "12.0.0.3"
> +#define LPFC_DRIVER_VERSION "12.0.0.4"
>
rivers/scsi/lpfc/lpfc_nportdisc.c | 6 ++
> drivers/scsi/lpfc/lpfc_nvme.c | 23 +++
> 3 files changed, 32 insertions(+), 4 deletions(-)
>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
t; loopback is running.
>
> Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com>
> Signed-off-by: James Smart <james.sm...@broadcom.com>
> ---
> drivers/scsi/lpfc/lpfc_hbadisc.c | 3 +--
> drivers/scsi/lpfc/lpfc_sli.c | 19 ---
> 2 files chang
MQ_RQ_IN_FLIGHT);
write_seqcount_end(>gstate_seq);
preempt_enable();
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
ed, 18 deletions(-)
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
ame issue which triggered this patchset in the first place.
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
_TIMER,
+ BLK_EH_DONE,/* drivers has completed the command */
+ BLK_EH_RESET_TIMER, /* reset timer and try again */
};
typedef enum blk_eh_timer_return (rq_timed_out_fn)(struct request *);
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
1 - 100 of 4557 matches
Mail list logo
