Re: [PATCH] scsi: lpfc: Uninitialized variable in lpfc_debugfs_nodelist_data()

On Mon, 2018-10-22 at 09:50 +0300, Dan Carpenter wrote: > There was a merge problem and we accidentally removed the "nrport" > initialization. > > Fixes: 77c5bf5647b5 ("Merge branch 'misc' into for-next") > Signed-off-by: Dan Carpenter > --- > drivers/scsi/lpfc/lpfc_debugfs.c | 2 +- > 1 file

[PATCH] scsi: myrs: fix build failure on 32 bit

test robot Signed-off-by: James Bottomley --- drivers/scsi/myrs.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/myrs.c b/drivers/scsi/myrs.c index b02ee0b0dd55..a9f9c77e889f 100644 --- a/drivers/scsi/myrs.c +++ b/drivers/scsi/myrs.c @@ -1978

Re: [scsi:misc 194/233] ERROR: "__aeabi_uldivmod" [drivers/scsi/myrs.ko] undefined!

On Thu, 2018-10-18 at 10:28 -0700, James Bottomley wrote: > On Fri, 2018-10-19 at 01:18 +0800, kbuild test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.g > > it > > misc > > head: 4d5b4ac1eae471bcd0fa381a

Re: [scsi:misc 194/233] ERROR: "__aeabi_uldivmod" [drivers/scsi/myrs.ko] undefined!

On Fri, 2018-10-19 at 01:18 +0800, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git > misc > head: 4d5b4ac1eae471bcd0fa381ab4099cc33e94e15d > commit: 77266186397c6c782a3f670d32808a9671806ec5 [194/233] scsi: > myrs: Add Mylex RAID controller (SCSI

Re: [possible bug] critical target error (out of range) when sending UNMAP on lsi2308 (mpt3sas) for the last sector of the drive

On Wed, 2018-10-10 at 16:55 +0200, Michal Soltys wrote: > Hi, > > I have a server with old server with lsi2308 ("it" mode) and sas2x36 > expander in front. I've been testing how it handles ssd drives (among > those if/how it copes with unmap). And it looks like > stomped on a bug (it's 100%

Re: [PATCH] mpt3sas: Fix for regression caused due to cf6bf9710c patch

On Tue, 2018-07-03 at 22:49 +0900, David Miller wrote: > From: Sreekanth Reddy > Date: Tue, 3 Jul 2018 17:48:49 +0530 > > > Any suggestion/update over my previous mail. I am using 4.13 > kernel. > > I think the issue is that if you are reading a 32-bit word and then > interpreting it as a

Re: [PATCH] mpt3sas: Fix for regression caused due to cf6bf9710c patch

On Fri, 2018-06-29 at 10:58 -0400, Chaitra P B wrote: >  "scsi: mpt3sas: Bug fix for big endian systems" > > Above patch with commit id "cf6bf9710cabba1fe94a4349f4eb8db623c77ebc" > was posted to fix sparse warnings. While posting this patch it was > assumed that readl() & writel() APIs internally

Re: [PATCH v2] scsi: qla2xxx: Spinlock recursion in qla_target

On Wed, 2018-06-13 at 16:13 +, Madhani, Himanshu wrote: > > On Jun 13, 2018, at 6:05 AM, Mikhail Malygin > > wrote: > > > > Here is the patch used for verification: > > > > [PATCH] scsi: qla2xxx: Fixup spinlock recursion in qla_target > > > > The patch reverts changes done in

Re: sd 6:0:0:0: [sdb] Unaligned partial completion

On Mon, 2018-06-11 at 14:59 -0700, Ted Cabeen wrote: > On 06/11/2018 02:40 PM, James Bottomley wrote: > > On Mon, 2018-06-11 at 12:20 -0400, Douglas Gilbert wrote: > > > I have also seen Aborted Command sense when doing heavy testing > > > on one or more SAS disks b

Re: RAID6: "Bad block number requested"

On Mon, 2018-06-11 at 17:56 -0400, Bryan Gurney wrote: > On Mon, Jun 11, 2018 at 1:00 PM, Anthony Youngman > wrote: > > On 11/06/18 16:06, James Bottomley wrote: > > > Well, this is the problem: a 4k logical (presumably 4k physical) > > > drive cannot

Re: sd 6:0:0:0: [sdb] Unaligned partial completion

[readd linux-scsi] On Mon, 2018-06-11 at 14:43 -0700, Ted Cabeen wrote: > On 06/11/2018 02:40 PM, James Bottomley wrote: > > > I have also seen Aborted Command sense when doing heavy testing > > > on one or more SAS disks behind a SAS expander. I put it down to > >

Re: sd 6:0:0:0: [sdb] Unaligned partial completion

On Mon, 2018-06-11 at 12:20 -0400, Douglas Gilbert wrote: > On 2018-06-11 12:07 PM, Ted Cabeen wrote: > > I'm seeing a similar behavior on my system, but across multiple > > devices on a SAS drive array (front bays on a Supermicro-based > > system with onboard mpt3sas card).  > > The Sense Key

Re: RAID6: "Bad block number requested"

On Mon, 2018-06-11 at 11:18 -0400, Douglas Gilbert wrote: > On 2018-06-11 11:06 AM, James Bottomley wrote: > > On Mon, 2018-06-11 at 16:24 +0200, Sebastian Hegler wrote: > > > Dear all, > > > > > > First off: sorry for cross-posting. I don't know if this i

Re: RAID6: "Bad block number requested"

On Mon, 2018-06-11 at 16:24 +0200, Sebastian Hegler wrote: > Dear all, > > First off: sorry for cross-posting. I don't know if this is a RAID > issue or a SCSI issue, so I'll just ask y'all. > > > For a RAID6 capacity upgrade (higher capacity drives), we bought some > 10TB disks: >

Re: [PATCH] mpt3sas: Add an i/o barrier

On Thu, 2018-05-24 at 17:31 +0200, Tomas Henzl wrote: > On 05/24/2018 05:19 PM, James Bottomley wrote: > > On Thu, 2018-05-24 at 17:12 +0200, Tomas Henzl wrote: > > > A barrier should be added to ensure proper ordering of memory > > > mapped > > > writes. >

Re: [PATCH] mpt3sas: Add an i/o barrier

On Thu, 2018-05-24 at 17:12 +0200, Tomas Henzl wrote: > A barrier should be added to ensure proper ordering of memory mapped > writes. > > Signed-off-by: Tomas Henzl > --- >  drivers/scsi/mpt3sas/mpt3sas_base.c | 1 + >  1 file changed, 1 insertion(+) > > diff --git

[GIT PULL] SCSI fixes for 4.17-rc6

Two driver fixes (zfcp and target core), one information leak in sg and one build clean up. The patch is available here: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-fixes The short changelog is: Alexander Potapenko (1): scsi: sg: allocate with __GFP_ZERO in

[GIT PULL] SCSI fixes for 4.17-rc5

Two small driver fixes: aacraid to fix an unknown IU type on task management functions which causes a firmware fault and vmw_pvscsi to change a return code to retry the operation instead of causing an immediate error The patch is available here:

[GIT PULL] SCSI fixes for 4.17-rc3

Three small bug fixes: an illegally overlapping memcmp in target code, a potential infinite loop in isci under certain rare phy conditions and an ATA queue depth (performance) correction for storvsc. The patch is available here: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git

[GIT PULL] SCSI fixes for 4.17-rc2

8 bug fixes, one spelling update and one tracepoint addition. The most serious is probably the mpt3sas write same fix because it means anyone using these controllers sees errors when modern filesystems try to issue discards (if the drive supports the WRITE SAME variant). The patch is available

Re: [PATCH] bsg referencing bus driver module

On Fri, 2018-04-20 at 16:44 -0600, Anatoliy Glagolev wrote: >   > > This patch isn't applyable because your mailer has changed all the > > tabs to spaces. > > > > I also think there's no need to do it this way.  I think what we > > need is for fc_bsg_remove() to wait until the bsg queue is > >

Re: [PATCH] bsg referencing bus driver module

On Thu, 2018-04-19 at 15:10 -0700, Anatoliy Glagolev wrote: > Updated: rebased on recent Linux, cc-ed maintainers per instructions > in MAINTAINERS file > > From df939b80d02bf37b21efaaef8ede86cfd39b0cb8 Mon Sep 17 00:00:00 > 2001 > From: Anatoliy Glagolev > Date: Thu,

Re: [PATCH] isci: Fix infinite loop in while loop

On Fri, 2018-04-20 at 10:03 +0100, Colin King wrote: > From: Colin Ian King > > In the case when the phy_mask is bitwise anded with the > phy_index bit is zero the continue statement currently jumps > to the next iteration of the while loop and phy_index is > never

Re: usercopy whitelist woe in scsi_sense_cache

On Mon, 2018-04-16 at 20:12 -0700, Kees Cook wrote: > I still haven't figured this out, though... any have a moment to look > at this? Just to let you know you're not alone ... but I can't make any sense of this either. The bfdq is the elevator_data, which is initialised when the scheduler is

Re: MPT Fusion - ext4 delayed allocation failed errors on 4.14!

On Mon, 2018-04-16 at 23:25 -0400, Martin K. Petersen wrote: > Nikola, > > > thanks for explanation. but disabling write same for now is safe, > > right? > > I was hoping we'd be able to disable it for SATA devices only. > > > root@siv-70140:~ # sg_vpd /dev/sda > > Supported VPD pages VPD page:

[GIT PULL] final round of SCSI updates for the 4.16+ merge window

This is a set of minor (and safe changes) that didn't make the initial pull request plus some bug fixes. The status handling code is actually a running regression from the previous merge window which had an incomplete fix (now reverted) and most of the remaining bug fixes are for problems older

Re: [PATCH] Waiting for scsi_host_template release

On Wed, 2018-04-11 at 12:22 -0700, Anatoliy Glagolev wrote: > Hannes, James, thanks a lot for taking a look! > > On the problem the patch is solving: it is in the "Description" part > of my initial e-mail. If you agree that a Scsi_Host may be around > after a driver has unloaded, the problem

Re: [PATCH] Waiting for scsi_host_template release

On Wed, 2018-04-11 at 16:11 +0200, Hannes Reinecke wrote: > On Mon, 9 Apr 2018 23:23:51 -0700 > Anatoliy Glagolev wrote: > > > Description: > > SCSI mid-layer may hold references to Scsi_Host structs when > > the owning module has already unloaded. Scsi_Host release path > >

[GIT PULL] first round of SCSI updates for the 4.16+ merge window

This is mostly updates of the usual drivers: arcmsr, qla2xx, lpfc, ufs, mpt3sas, hisi_sas. In addition we have removed several really old drivers: sym53c416, NCR53c406a, fdomain, fdomain_cs and removed the old scsi_module.c initialization from all remaining drivers. Plus an assortment of bug

[GIT PULL] SCSI fixes for 4.16-rc7

Two driver fixes (ibmvfc, iscsi_tcp) and a USB fix for devices that give the wrong return to Read Capacity and cause a huge log spew.  The remaining 5 patches all try to fix commit 84676c1f21e8ff5 "genirq/affinity: assign vectors to all possible CPUs") which broke the non-mq I/O path. The patch

[GIT PULL] SCSI fixes for 4.16-rc6

One driver patch (qla2xxx) which fixes a problem caused by an existing regression fix (FCP discovery is failing) and one generic fix to a longstanding bug in libsas that causes I/O eventually to hang to the device in the face of ATA error recovery. The patch is available here:

Re: How to Locate drive directly attached to mpt3sas HBA

On Mon, 2018-03-19 at 17:30 +0100, Jack Wang wrote: > > > > > > > > > > And I think either mpt2sas and/or mpt3sas HBAs (I don't have my > > > hardware > > > nearby) have a SMP target hidden away somewhere. Perhaps someone > > > from > > > LSI/Avago/Broadcom could supply more information about

Re: How to Locate drive directly attached to mpt3sas HBA

On Mon, 2018-03-19 at 15:20 +0100, Douglas Gilbert wrote: > On 2018-03-19 11:40 AM, Jack Wang wrote: > > > > Hi list, > > > > Any one knows how can I locate a HDD directly attached to mpt3sas, > > sas3ircu only supports LOCATE commd to locates driver installed in > > a > > disk enclosure, but

Re: [PATCH v2] scsi: Avoid that .queuecommand() gets called for a quiesced SCSI device

On Fri, 2018-03-16 at 23:10 +, Bart Van Assche wrote: > On Fri, 2018-03-16 at 15:49 -0700, James Bottomley wrote: > > > > In your new code you have > > > > +   if (sdev->sdev_state != SDEV_QUIESCE) > > +   rtn = shost->hostt->q

Re: [PATCH v2] scsi: Avoid that .queuecommand() gets called for a quiesced SCSI device

On Fri, 2018-03-16 at 22:40 +, Bart Van Assche wrote: > On Fri, 2018-03-16 at 15:31 -0700, James Bottomley wrote: > > > > On Fri, 2018-03-16 at 22:21 +, Bart Van Assche wrote: > > > > > > On Fri, 2018-03-16 at 15:00 -0700, James Bottomley wrote: > >

Re: [PATCH v2] scsi: Avoid that .queuecommand() gets called for a quiesced SCSI device

On Fri, 2018-03-16 at 22:21 +, Bart Van Assche wrote: > On Fri, 2018-03-16 at 15:00 -0700, James Bottomley wrote: > > > > On Fri, 2018-03-16 at 10:40 -0700, Bart Van Assche wrote: > > > > > > @@ -1050,7 +1050,22 @@ static int scsi_send_eh_cmnd(struct >

Re: [PATCH v2] scsi: Avoid that .queuecommand() gets called for a quiesced SCSI device

On Fri, 2018-03-16 at 10:40 -0700, Bart Van Assche wrote: > @@ -1050,7 +1050,22 @@ static int scsi_send_eh_cmnd(struct scsi_cmnd > *scmd, unsigned char *cmnd, >   >   scsi_log_send(scmd); >   scmd->scsi_done = scsi_eh_done; > - rtn = shost->hostt->queuecommand(shost, scmd); > +

[GIT PULL] SCSI fixes for 4.16-rc5

This is four patches, consisting of one regression from the merge window (qla2xxx) one lonstanding memory leak (sd_zbc) one event queue mislabelling which we want to eliminate to discourage the pattern (mpt3sas) and one behaviour change because re-reading the partition table shouldn't clear the ro

Re: [PATCH, resend] scsi: Avoid that .queuecommand() gets called for a quiesced SCSI device

On Wed, 2018-03-14 at 15:45 -0700, Bart Van Assche wrote: > Several SCSI transport and LLD drivers surround code that does not > tolerate concurrent calls of .queuecommand() with scsi_target_block() > / > scsi_target_unblock(). These last two functions use > blk_mq_quiesce_queue() /

Re: [PATCH] scsi: resolve COMMAND_SIZE at compile time

On Sat, 2018-03-10 at 14:29 +0100, Stephen Kitt wrote: > Hi Bart, > > On Fri, 9 Mar 2018 22:47:12 +, Bart Van Assche c.com> > wrote: > > > > On Fri, 2018-03-09 at 23:33 +0100, Stephen Kitt wrote: > > > > > > +/* > > > + * SCSI command sizes are as follows, in bytes, for

Re: [PATCH] lpfc: Resolve static check error in lpfc_nvmet.c

Really, the commit message has to be descriptive.  This makes me think this is about some annoying policy of making everything static rather than a critical bug. What's wrong with lpfc: add missing unlock on defer WQFULL path ?  You can then expand on the static checker discovery in the main

Re: [PATCH 6/6] lib/scatterlist: Drop order argument from sgl_free_n_order

On Wed, 2018-03-07 at 12:47 +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin Firstly, I don't see any justifiable benefit to churning this API, so why bother? but secondly this: > We can derive the order from sg->length and so do not need to pass it > in explicitly.

[GIT PULL] SCSI fixes for 4.16-rc4

This patch is mostly fixes for driver specific issues (nine of them) and the storvsc performance improvement with interrupt handling which was dropped from the previous fixes pull request.  We also have two regressions: one is a double call_rcu() in ATA error handling and the other is a missed

Re: [PATCH] lpfc: use __raw_writeX on DPP copies

On Mon, 2018-03-05 at 09:03 -0800, James Smart wrote: > This patch replaces: > https://www.spinics.net/lists/linux-scsi/msg117838.html > > A prior lpfc patch: > scsi: lpfc: Add push-to-adapter support to sli4 > commitid=1351e69fc6db30e186295f1c9495d03cef6a01a2 > > Fails compilation on some

Re: [PATCH] qla2xxx: Fix NULL pointer crash due to active timer for ABTS

On Mon, 2018-02-12 at 10:28 -0800, Himanshu Madhani wrote: [...] > Cc: #4.4+ This is the wrong stable tag, which would lead to stable not picking up the patch automatically.  The correct stable address is Cc: #4.4+                  ^^

Re: [GIT PULL] SCSI fixes for 4.16-rc2

On Thu, 2018-02-22 at 16:37 -0800, Linus Torvalds wrote: > On Thu, Feb 22, 2018 at 11:28 AM, James Bottomley > <james.bottom...@hansenpartnership.com> wrote: > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi- > > fixes > > Wh

[GIT PULL] SCSI fixes for 4.16-rc2

These are mostly fixes for problems with merge window code.  In addition we have one doc update (alua) and two dead code removals (aiclib and octogon) a spurious assignment removal (csiostor) and a performance improvement for storvsc involving better interrupt spreading and increasing the command

Re: [GIT PULL] SCSI fixes for 4.16-rc1

On Wed, 2018-02-14 at 12:19 -0800, James Bottomley wrote: > These are mostly fixes for problems with merge window code.  In > addition we have one doc update (alua) and two dead code removals > (aiclib and octogon) a spurious assignment removal (csiostor) and a > performance

[GIT PULL] SCSI fixes for 4.16-rc1

These are mostly fixes for problems with merge window code.  In addition we have one doc update (alua) and two dead code removals (aiclib and octogon) a spurious assignment removal (csiostor) and a performance improvement for storvsc involving better interrupt spreading and increasing the command

Re: [PATCH v1] scsi: mpt3sas: Use lo_hi_writeq() helper

On Wed, 2018-02-14 at 21:48 +0200, Andy Shevchenko wrote: > On Wed, 2018-02-14 at 11:40 -0800, James Bottomley wrote: > > > > On Wed, 2018-02-14 at 20:10 +0200, Andy Shevchenko wrote: > > > > > > Since we have a writeq() for 32-bit architectures as provided by

Re: [PATCH v1] scsi: mpt3sas: Use lo_hi_writeq() helper

On Wed, 2018-02-14 at 20:10 +0200, Andy Shevchenko wrote: > Since we have a writeq() for 32-bit architectures as provided by IO > non-atomic helpers, there is no need to open code it. > > Moreover sparse complains about this: > > drivers/scsi/mpt3sas/mpt3sas_base.c:2975:16: expected unsigned

[GIT PULL] SCSI postmerge updates for the 4.15+ merge window

This is a set of three patches that depended on mq and zone changes in the block tree (now upstream). The patch is available here: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-postmerge The short changelog is: Bart Van Assche (1): scsi: scsi-mq-debugfs: Show more

Re: [GIT PULL] first round of SCSI updates for the 4.14+ merge window

On Wed, 2018-01-31 at 11:29 -0800, Linus Torvalds wrote: > On Wed, Jan 31, 2018 at 9:42 AM, James Bottomley > <james.bottom...@hansenpartnership.com> wrote: > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi- > > misc > > Ok, n

Sorry about all the patch dropped email noise

If you received it, just ignore it.  I didn't initialize my fixes tree correctly before pulling in Martin's branch, so it wrongly sent a patch dropped email for every patch in the misc tree (which has already been routed to Linus). James

[GIT PULL] first round of SCSI updates for the 4.14+ merge window

This is mostly updates of the usual driver suspects: arcmsr, scsi_debug, mpt3sas, lpfc, cxlflash, qla2xxx, aacraid, megaraid_sas, hisi_sas.  We also have a rework of the libsas hotplug handling to make it more robust, a slew of 32 bit time conversions and fixes, and a host of the usual minor

Re: [LSF/MM TOPIC] Two blk-mq related topics

On Mon, 2018-01-29 at 14:00 -0700, Jens Axboe wrote: > On 1/29/18 1:56 PM, James Bottomley wrote: > > > > On Mon, 2018-01-29 at 23:46 +0800, Ming Lei wrote: > > [...] > > > > > > 2. When to enable SCSI_MQ at default again? > > > > I'm not

Re: [LSF/MM TOPIC] Two blk-mq related topics

On Mon, 2018-01-29 at 23:46 +0800, Ming Lei wrote: [...] > 2. When to enable SCSI_MQ at default again? I'm not sure there's much to discuss ... I think the basic answer is as soon as Christoph wants to try it again. > SCSI_MQ is enabled on V3.17 firstly, but disabled at default. In > V4.13-rc1,

Re: [PATCH resend 0/6] Fix cdrom autoclose

On Fri, 2018-01-26 at 17:58 +0100, Michal Suchanek wrote: > First time I did not get any feedback for the patches. This is likely because no-one who might inspect the code saw the patches ... what list are they going to?  I'm on the block, scsi and ide mailing lists and I only saw a doc patch the

Re: [LSF/MM TOPIC] Patch Submission process and Handling Internal Conflict

On Wed, 2018-01-24 at 19:26 +, Bart Van Assche wrote: > On Wed, 2018-01-24 at 11:05 -0800, James Bottomley wrote: > > > > 2. Handling Internal Conflict > > > > My observation here is that actually most conflict is generated by > > the review process (I

Re: [LSF/MM TOPIC] Patch Submission process and Handling Internal Conflict

On Wed, 2018-01-24 at 11:20 -0800, Mike Kravetz wrote: > On 01/24/2018 11:05 AM, James Bottomley wrote: > > > > I've got two community style topics, which should probably be > > discussed > > in the plenary > > > > 1. Patch Submission Process >

[LSF/MM TOPIC] Patch Submission process and Handling Internal Conflict

I've got two community style topics, which should probably be discussed in the plenary 1. Patch Submission Process Today we don't have a uniform patch submission process across Storage, Filesystems and MM.  The question is should we (or at least should we adhere to some minimal standards).  The

[GIT PULL] SCSI fixes for 4.15-rc8

One fix for SAS attached SATA CD-ROMs.  It turns out that the libata handling of CD devices relies on the SCSI error handler, so disable async aborts (which don't start the error handler) for these devices. The patch is available here: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git

Re: [PATCH] sd: succeed check_event if device is not removable

On Thu, 2018-01-18 at 17:22 +0100, Jack Wang wrote: > From: Jack Wang > > The check_events interface was added for check if device changes, > mainly for device is removable eg. CDROM > > In sd_open, it checks if device is removable then check_disk_change. > > when

Re: [PATCH v2] scsi: sd: add new match array for cache_type

On Thu, 2018-01-18 at 22:19 +0800, weiping zhang wrote: > - return sprintf(buf, "%s\n", sd_cache_types[ct]); > + return sprintf(buf, "%s\n%s\nwrite:%s, read:%s\n", > sd_cache_types[ct], > + sd_wce_rcd[ct], sdkp->WCE ? "on" : "off", > + sdkp->RCD ?

Re: [PATCH] scsi: handle ABORTED_COMMAND on Fujitsu ETERNUS

On Thu, 2018-01-18 at 11:17 +0100, Hannes Reinecke wrote: > On 01/18/2018 03:43 AM, Martin K. Petersen wrote: > > > > > > Martin, > > > > > > > > You'd like to spend a precious BLIST bit for this single device > > > which uses vendor-specific ASC/Q? > > > > I really don't want string

Re: [Lsf-pc] [LSF/MM TOPIC] A high-performance userspace block driver

On Tue, 2018-01-16 at 18:23 -0500, Theodore Ts'o wrote: > On Tue, Jan 16, 2018 at 06:52:40AM -0800, Matthew Wilcox wrote: > > > > > > I see the improvements that Facebook have been making to the nbd > > driver, and I think that's a wonderful thing.  Maybe the outcome of > > this topic is simply:

Re: [PATCH 10/18] qla2xxx: prevent bounds-check bypass via speculative execution

On Fri, 2018-01-12 at 08:27 +0100, Greg KH wrote: > On Thu, Jan 11, 2018 at 02:15:12PM -0800, Dan Williams wrote: > > > > On Sat, Jan 6, 2018 at 1:03 AM, Greg KH > > wrote: > > > > > > On Fri, Jan 05, 2018 at 05:10:48PM -0800, Dan Williams wrote: > > > > > > > >

Re: [PATCH v2 17/19] qla2xxx: prevent bounds-check bypass via speculative execution

On Thu, 2018-01-11 at 21:38 -0800, Dan Williams wrote: > On Thu, Jan 11, 2018 at 5:19 PM, James Bottomley > <j...@linux.vnet.ibm.com> wrote: > > > > On Thu, 2018-01-11 at 16:47 -0800, Dan Williams wrote: > > > > > > Static analysis reports that 'ha

Re: [PATCH v2 17/19] qla2xxx: prevent bounds-check bypass via speculative execution

On Thu, 2018-01-11 at 16:47 -0800, Dan Williams wrote: > Static analysis reports that 'handle' may be a user controlled value > that is used as a data dependency to read 'sp' from the > 'req->outstanding_cmds' array. Greg already told you it comes from hardware, specifically the hardware response

[GIT PULL] SCSI fixes for 4.15-rc5

Two simple fixes, both of which cause I/O hangs.  The storvsc one is from the hyper-v which can hang under certain hot add/remove conditions and the other is generally, where removing a target and a device in close proximity can result in the release method being executed twice (and subsequent

Re: [PATCH 2/3] ses: skip error messages for invalid LUNs

On Thu, 2017-12-21 at 12:22 +0100, Hannes Reinecke wrote: > Some storage array set the 'Embedded enclosure' bit even though > no LUN is present, causing the first RECEIVE DIAGNOSTIC call to > be returned with sense code 'LOGICAL UNIT NOT SUPPORTED'. > This patch skips the annoying 'Failed to get

Re: [PATCH 1/3] ses: make initial allocation size configurable

On Thu, 2017-12-21 at 12:22 +0100, Hannes Reinecke wrote: > Some storage arrays have an incorrect SES implementation which will > always return the allocation length of the CDB instead of the true > length of the requested page. That's a pretty gross standards violation, is this common?  When the

Re: [PATCH 3/3] ses: Retry Power-on-reset check condition

On Thu, 2017-12-21 at 12:22 +0100, Hannes Reinecke wrote: > During startup any SCSI request might encounter a 'Power-on/reset' > sense code, which just can be retried. > In the case of ses it needs to be retried, otherwise ses will > errorneously detect this as a failure and not attach the driver.

[GIT PULL] SCSI fixes for 4.15-rc4

Two simple fixes: one for sparse warnings that were introduced by the merge window conversion to blist_flags_t and the other to fix dropped I/O during reset in aacraid. The patch is available here: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-fixes The short changelog is:

[GIT PULL] SCSI fixes for 4.15-rc3

The most important one is the bfa fix because it's easy to oops the kernel with this driver (this includes the commit that corrects the compiler warning in the original), a regression in the new timespec conversion in aacraid and a regression in the Fibre Channel ELS handling patch.  The other

Re: [BUG] scsi/qla2xxx: a possible sleep-in-atomic bug in qlt_get_tag

On Wed, 2017-12-13 at 11:18 +0800, Jia-Ju Bai wrote: > The driver may sleep under a spinlock. > The function call paths are: > qlt_handle_abts_recv_work (acquire the spinlock) >    qlt_response_pkt_all_vps >  qlt_response_pkt >    qlt_handle_cmd_for_atio >  qlt_get_tag >    

Re: [GIT PULL] SCSI fixes for 4.15-rc3

On Tue, 2017-12-12 at 09:32 -0800, Linus Torvalds wrote: > On Tue, Dec 12, 2017 at 9:22 AM, Martin K. Petersen > wrote: > > > > > > Arnd and Johannes fixed this up right away: > > The commit you point to _is_ the probnlem. It does: > > struct bfad_im_port_s

Re: [GIT PULL] SCSI fixes for 4.15-rc3

On Tue, 2017-12-12 at 12:22 -0500, Martin K. Petersen wrote: > Linus, > > > > > This is utter shite, and doesn't even compile cleanly. > > > > Sure, it's "just" a warning, and the code works. But no, I'm not > > pulling crap like this. If you save a pointer in an integer > > "hostdata[0]"

[GIT PULL] SCSI fixes for 4.15-rc3

The most important one is the bfa fix because it's easy to oops the kernel with this driver, a regression in the new timespec conversion in aacraid and a regression in the Fibre Channel ELS handling patch.  The other three are a theoretical problem with termination in the vendor/host matching code

Re: [PATCH] bfa: fix access to bfad_im_port_s

On Wed, 2017-12-06 at 09:07 +0100, Johannes Thumshirn wrote: > James Bottomley <james.bottom...@hansenpartnership.com> writes: > > > > On Tue, 2017-11-28 at 16:26 +0100, Johannes Thumshirn wrote: > > > > > > Commit 'cd21c605b2cf ("scsi: fc: provide fc_

Re: [PATCH] bfa: fix access to bfad_im_port_s

On Tue, 2017-11-28 at 16:26 +0100, Johannes Thumshirn wrote: > Commit 'cd21c605b2cf ("scsi: fc: provide fc_bsg_to_shost() helper")' > changed access to bfa's 'struct bfad_im_port_s' by using shost_priv() > instead of shost->hostdata[0]. > > This lead to crashes like in the following back-trace: >

Re: [PATCH] scsi: fix race condition when removing target

On Wed, 2017-12-06 at 08:41 +0800, Jason Yan wrote: > On 2017/12/5 23:37, James Bottomley wrote: > > > > On Tue, 2017-12-05 at 20:37 +0800, Jason Yan wrote: > > > > > > > > > On 2017/12/1 23:35, James Bottomley wrote: > > > > > > >

[GIT PULL] SCSI fixes for 4.15-rc2

We have a bunch of fixes for aacraid, a set of coherency fixes that only affect non-coherent platforms and one coccinelle detected null check after use. The patch is available here: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-fixes The short changelog is: Christoph Hellwig

Re: [PATCH 1/2] scsi-mq: Only show the CDB if available

On Wed, 2017-12-06 at 00:38 +0800, Ming Lei wrote: > On Tue, Dec 05, 2017 at 04:22:33PM +, Bart Van Assche wrote: > > > > On Tue, 2017-12-05 at 13:00 +0800, Ming Lei wrote: > > > > > > No, do not mix two different things in one patch, especially the > > > fix part need to be backported to

Re: [PATCH] scsi: fix race condition when removing target

On Tue, 2017-12-05 at 20:37 +0800, Jason Yan wrote: > > On 2017/12/1 23:35, James Bottomley wrote: > > > > On Fri, 2017-12-01 at 16:40 +0800, Jason Yan wrote: > > > > > > On 2017/12/1 7:56, James Bottomley wrote: > > > > > > >

Re: [PATCH] scsi: fix race condition when removing target

On Fri, 2017-12-01 at 16:40 +0800, Jason Yan wrote: > On 2017/12/1 7:56, James Bottomley wrote: > > b/include/scsi/scsi_device.h > > index 571ddb49b926..2e4d48d8cd68 100644 > > --- a/include/scsi/scsi_device.h > > +++ b/include/scsi/scsi_device.h > > @@ -380,6 +38

Re: [PATCH] scsi: fix race condition when removing target

On Thu, 2017-11-30 at 16:08 +, Bart Van Assche wrote: > On Thu, 2017-11-30 at 09:18 +0800, Jason Yan wrote: > > > > Hi Bart, I chose the approach in my patch because it has been used > > in scsi_device_get() for years and been proved safe. I think using > > kobject_get_unless_zero() is safe

Re: [PATCH] scsi: fix race condition when removing target

On Wed, 2017-11-29 at 17:34 +0100, Christoph Hellwig wrote: > On Wed, Nov 29, 2017 at 08:31:48AM -0800, James Bottomley wrote: > > > > This analysis fails here: get_device() on something with refcount 0 > > returns NULL.  That triggers the if clause to ignore this device

Re: [PATCH] scsi: fix race condition when removing target

On Wed, 2017-11-29 at 11:05 +0800, Jason Yan wrote: > In commit fbce4d97fd43 ("scsi: fixup kernel warning during rmmod()"), > we > removed scsi_device_get() and directly called get_device() to > increase > the refcount of the device. But actullay scsi_device_get() will fail > in > three cases: >

Re: UFS utilities

On Wed, 2017-11-29 at 15:39 +, Bean Huo (beanhuo) wrote: > Thread-Topic: UFS utilities > Thread-Index: AdNpKDYJWTPjczfxQHC/pD9WNnnl4w== Could you fix your mail transfer agent?  It's using these non standard headers instead of the RFC mandated In-Reply-To: and References: The problem is that

[GIT PULL] final round of SCSI updates for the 4.14+ merge window

Two basic fixes: one for the sparse problem with the blacklist flags and another for a hang forever in bnx2i. The patch is available here: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-fixes The short changelog is: Chad Dupuis (1): scsi: bnx2fc: Fix hung task messages

Re: Seagate External SMR drive USB resets (was: Re: [PATCH] uas: Add US_FL_NO_ATA_1X quirk for one more Seagate device)

On Wed, 2017-11-15 at 17:02 -0500, Alan Stern wrote: > On Wed, 15 Nov 2017, Jérôme Carretero wrote: > > >   Because with several of these drives / lots of activity / > occasional > > >   issues, it looks like it will be hard to catch (yes I can use > > > usbmon). > > >  > > > - It looks like there

Re: [PATCH V4] scsi_debugfs: fix crash in scsi_show_rq()

On Wed, 2017-11-15 at 18:09 +0800, Ming Lei wrote: > On Tue, Nov 14, 2017 at 10:14:52AM -0800, James Bottomley wrote: > > > > On Tue, 2017-11-14 at 08:55 +0800, Ming Lei wrote: > > > > > > Hi James, > > > > > > On Mon, Nov

Re: [GIT PULL] first round of SCSI updates for the 4.14+ merge window

On Tue, 2017-11-14 at 16:33 -0800, Linus Torvalds wrote: > On Tue, Nov 14, 2017 at 8:36 AM, James Bottomley > <james.bottom...@hansenpartnership.com> wrote: > > > > > > Hannes Reinecke (14): > >   scsi: scsi_devinfo: Reformat blacklist flags > > U

Re: [PATCH V4] scsi_debugfs: fix crash in scsi_show_rq()

On Tue, 2017-11-14 at 08:55 +0800, Ming Lei wrote: > Hi James, > > On Mon, Nov 13, 2017 at 10:55:52AM -0800, James Bottomley wrote: > > > > On Sat, 2017-11-11 at 10:43 +0800, Ming Lei wrote: > > > > > > So from CPU1's review, cmd->cmnd is in a rem

[GIT PULL] first round of SCSI updates for the 4.14+ merge window

This is mostly updates of the usual suspects: lpfc, qla2xxx, hisi_sas, megaraid_sas, pm80xx, mpt3sas, be2iscsi, hpsa. and a host of minor updates. There's no major behaviour change or additions to the core in all of this, so the potential for regressions should be small (biggest potential being

Re: [PATCH V4] scsi_debugfs: fix crash in scsi_show_rq()

On Sat, 2017-11-11 at 10:43 +0800, Ming Lei wrote: > On Fri, Nov 10, 2017 at 08:51:58AM -0800, James Bottomley wrote: > > > > On Fri, 2017-11-10 at 17:01 +0800, Ming Lei wrote: > > > > > > cmd->cmnd can be allocated/freed dynamically in case of > > >

Re: [PATCH V4] scsi_debugfs: fix crash in scsi_show_rq()

not syncing: Fatal exception > [  252.963007] Dumping ftrace buffer: > [  252.963007](ftrace buffer empty) > [  252.963007] Kernel Offset: disabled > [  252.963007] ---[ end Kernel panic - not syncing: Fatal exception > > Fixes: 0eebd005dd07(scsi: Implement blk_mq_ops.show_rq())

Re: target-pending/for-next patches

On Wed, 2017-11-08 at 01:37 -0800, Nicholas A. Bellinger wrote: > On Sun, 2017-11-05 at 08:05 -0800, James Bottomley wrote: > > > > On Sat, 2017-11-04 at 18:14 -0700, Nicholas A. Bellinger wrote: > > > > > > Hi all, > > > > > > Just a fr

Re: [PATCH V3] scsi_debugfs: fix crash in scsi_show_rq()

2.963007] Kernel Offset: disabled > [  252.963007] ---[ end Kernel panic - not syncing: Fatal exception > > Fixes: 0eebd005dd07(scsi: Implement blk_mq_ops.show_rq()) > Cc: Bart Van Assche <bart.vanass...@sandisk.com> > Cc: Omar Sandoval <osan...@fb.com> > Cc: Martin

  1   2   3   4   5   6   7   8   9   10   >