Re: [PATCH 03/10] gdth: remove gdth_{alloc,free}_ioctl

On 06/12/2018 17:50, Johannes Thumshirn wrote: > Why not calling dma_alloc_coherent() directly instead of using the > pci_alloc_consistent() wrapper? Ah should've read the whole series -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@s

Re: [PATCH 03/10] gdth: remove gdth_{alloc,free}_ioctl

emaining one. This avoids a case where we might > be doing a memory allocation under a spinlock with irqs disabled. Why not calling dma_alloc_coherent() directly instead of using the pci_alloc_consistent() wrapper? Johannes -- Johannes ThumshirnSUSE Labs File

Re: [PATCH -next] scsi: libfc: Remove set but not used variable 'disc'

Looks good, Reviewed-by: Johannes Thumshirn

Re: [PATCH 3/8] sg: split header, expand and correct descriptions

There are no _t variants for the above, or am I missing something? -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Gr

Re: [PATCH 4/8] sg: expand request states

Looks good (but the ifdefs are creepy), Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard

Re: [PATCH 2/8] sg: introduce sg_log macro

\ > + } while (0) Hi Doug, have you considered using the kernel's dynamic debug infrastructure instead? -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 S

Re: [PATCH 1/8] sg: types and naming cleanup

is is highly appreciated. I have one minor Nit if you need to resend the series, please remove the casts form void* (mostly filp->private_data). Otherwise: Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jth

Re: [PATCH 28/28] mesh: switch to generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 27/28] ips: switch to generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 26/28] smartpqi: fully convert to the generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 25/28] vmw_pscsi: switch to generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 24/28] snic: switch to generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 23/28] qla4xxx: fully convert to the generic DMA API

u zap that: At exit, the @ha's flags.enable_64bit_addressing set to indicated supported addressing method. Comment in the function description as well? It wasn't even correct with the initial submission of qla4xxx (according to git blame. Otherwise, Reviewed-by: Johannes Thumshirn -

Re: [PATCH 22/28] qla2xxx: fully convert to the generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 21/28] qla1280: switch to generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 20/28] qedi: fully convert to the generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 19/28] qedf: fully convert to the generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 17/28] nsp32: switch to generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 18/28] pm8001: switch to generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 16/28] mvsas: fully convert to the generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 15/28] mvumi: switch to generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 14/28] mpt3sas: switch to generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 13/28] megaraid_sas: switch to generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 13/28] megaraid_sas: switch to generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 12/28] megaraid_mbox: switch to generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 10/28] fnic: switch to generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 11/28] hpsa: switch to generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 09/28] csiostor: switch to generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 08/28] be2iscsi: switch to generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 07/28] atp870u: switch to generic DMA API

dma_alloc_coherent(_dev->pdev->dev, 1024, &(atp_dev->id[c][k].prd_bus), > GFP_KERNEL); > if (!atp_dev->id[c][k].prd_table) { > printk("atp870u_init_tables fail\n"); >

Re: [PATCH 06/28] a100u2w: switch to generic DMA API

nt(pdev, sz, >escb_phys); > + host->escb_virt = dma_zalloc_coherent(>dev, sz, >escb_phys, > + GFP_KERNEL); and here. Otherwise, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de

Re: [PATCH 05/28] BusLogic: switch to generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 04/28] 3w-sas: fully convert to the generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 03/28] 3w-xxx: fully convert to the generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 02/28] 3w-9xxx: fully convert to the generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 01/28] aic94xx: fully convert to the generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH] megaraid_mbox: remove bogus use of pci_dma_sync_sg_* APIs

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH] lpfc: remove a bogus pci_dma_sync_single_for_device call

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH] lpfc: fixup crash in lpfc_els_unsol_buffer()

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH] ib_srp: Remove WARN_ON in srp_terminate_io()

On Fri, Sep 21, 2018 at 02:15:05PM +0200, Hannes Reinecke wrote: > The WARN_ON() is pointless as the rport is placed in SDEV_TRANSPORT_OFFLINE > at that time, so no new commands can be submitted via srp_queuecomment() s/srp_queuecomment/srp_queuecommand/ -- Johannes Thu

Re: [PATCH -next] scsi: libfc: remove set but not used variable 'rpriv'

Acked-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key

Re: [PATCH] libfc: remove unnecessary condition check

Acked-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key

Re: [PATCH] Simplify nvmet_init to remove extra out label

please send this patch to the correct mailing list (linux-n...@lists.infradead.org) -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer

Re: [PATCH] Remove extra goto label from nvmet_ns_enable

please send this patch to the correct mailing list (linux-n...@lists.infradead.org) -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer

Re: [PATCH] scsi: aic94xx: fix an error code in aic94xx_init()

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH] sr: Avoid that opening a CD-ROM hangs with runtime power management enabled

On Fri, Aug 03, 2018 at 10:28:45AM +0200, Johannes Thumshirn wrote: > On Thu, Aug 02, 2018 at 10:44:42AM -0700, Bart Van Assche wrote: > > Surround scsi_execute() calls with scsi_autopm_get_device() and > > scsi_autopm_put_device(). Note: removing sr_mutex protection from >

Re: next/master boot: 179 boots: 11 failed, 167 passed with 1 offline (next-20180731)

ivers/ata/libata-scsi.c | 1 + 4 files changed, 51 insertions(+), 14 deletions(-) I'll be looking into it. -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg

Re: next/master boot: 179 boots: 11 failed, 167 passed with 1 offline (next-20180731)

gt; CONFIG_BLK_DEV_RAM=y on top of defconfig: > > > https://people.collabora.com/~gtucker/lava/boot/debug/bzImage-85eac382fa06-blk-dev.config OK, this is a deviation from what I see here (on mkp's 4.19/scsi-queue not next though). -- Johannes Thumshirn

Re: next/master boot: 179 boots: 11 failed, 167 passed with 1 offline (next-20180731)

EMU DVD-ROM, 2.5+, max UDMA/100 [2.072269] scsi 1:0:0:0: CD-ROMQEMU QEMU DVD-ROM 2.5+ P5 [2.107220] sr 1:0:0:0: [sr0] scsi3-mmc drive: 4x/4x cd/rw xa/form2 tray [2.107675] cdrom: Uniform CD-ROM driver Revision: 3.20 [2.111851] sr 1:0:0:0: Attached scsi CD-

Re: next/master boot: 179 boots: 11 failed, 167 passed with 1 offline (next-20180731)

reproduce this issue with above script/initrd/kernel config, and looks > the issue disappeared after 'scsi_mod.use_blk_mq=0' is passed. > > Not see such issue with zero-day ktest config. > > Looks a bit weird, given SCSI_MQ is nothing related with ramdisk. Ahm and: qemu [...] -app

Re: next/master boot: 179 boots: 11 failed, 167 passed with 1 offline (next-20180731)

hich includes the url of the ramdisk and kernel: > http://lava.streamtester.net/scheduler/job/138067/definition#defline76 I grabbed your qemu cmdline and kernel config and try to reproduce it locally. Johannes -- Johannes Thumshirn St

Re: next/master boot: 179 boots: 11 failed, 167 passed with 1 offline (next-20180731)

using virtio (as Ming already suggested). What medium are you booting off? Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix I

Re: [PATCH 1/6] scsi: Add ufs transport class

host->next_port_id); Any reason you can't use an IDA for the port->id? [...] > + > + error = device_add(dev); > + > + if (error) > + return error; No blank line please. [...] > +#define dev_to_ufs_port(d) \ > + container_of((d), struct ufs_port,

Re: FCOE vn2vn memory leaks in 4.14

the temperature has > dropped to 29.8 . So I've fixed one use-after-free and one memory leak, but the one you reported is still on the TODO list. Long story short, I can reproduce it here and I'm working on it. Thanks for your patience, Johannes -- Johannes Thumshirn

Re: FCOE vn2vn memory leaks in 4.14

On Fri, Jul 27, 2018 at 12:49:55AM +0200, ard wrote: > Hi, > > On Thu, Jul 26, 2018 at 05:05:37PM +0200, Johannes Thumshirn wrote: > > On Thu, Jul 26, 2018 at 04:25:24PM +0200, ard wrote: > > > The system itself is an exynos 5422 arm. It worked perfectly fine > > &g

Re: FCOE vn2vn memory leaks in 4.14

this one sticks out: ea0a95d7f162 ("fcoe: Use kfree_skb() instead of kfree()") While I think it is necessary to release a skb with kfree_skb() it still might be worth trying to revert it for a test run. Thanks, Johannes -- Johannes Thumshirn

Re: FCOE vn2vn memory leaks in 4.14

environment here and try to reproduce. In the meanwhile I have your report and try to narrow down the leak(s). -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg

Re: FCOE vn2vn memory leaks in 4.14

> on one of the targets, it probably auto registers a dependency) > This is outside the scope of this ticket though. > > The system with the memory leak is a system intended to run 24/7. > > If anyone can point me to the right place, or help me... > > Regards, > Ard

Re: [PATCH, RESEND] Avoid that SCSI device removal through sysfs triggers a deadlock

>From my limited insight into this: Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, J

Re: [PATCH 4/4] fcoe: hold disc_mutex when traversing rport lists

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 3/4] libfc: Add WARN_ON() when deleting rports

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 2/4] libfc: hold disc_mutex in fc_disc_stop_rports()

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 1/4] libfc: fixup lockdep annotations

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCHv2] libfc: fixup 'sleeping function called from invalid context'

Acked-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key

Re: [PATCH] libfc: Add lockdep annotations

Acked-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key

Re: [PATCH] sd_zbc: Remove an assignment from sd_zbc_setup_report_cmnd()

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH v6 7/7] scsi_io_completion convert BUGs to WARNs

the reasons why it happened. Byte, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nür

Re: [PATCH] qedi: Fix misleading indentation

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 6/8] mpt3sas: Fix _transport_smp_handler() error path

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 5/8] mpt3sas: Introduce struct mpt3sas_nvme_cmd

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 3/8] mpt3sas: Annotate switch/case fall-through

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 1/8] mpt3sas: Fix indentation

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 2/8] mpt3sas: Remove set-but-not-used variables

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 2/2] qla2xxx: remove irq save in qla2x00_poll()

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 1/2] libsas: remove irq save in sas_ata_qc_issue()

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 2/3] scsi: be2iscsi: Add warnings for unsupported adapters

On Thu, Jun 07, 2018 at 01:54:42PM +0530, Jitendra Bhivare wrote: > From: Ketan Mukadam > > Add a warning message to indicate obsolete/unsupported > BE3 Adapter Family devices. Ahm no. The upstream Linux kernel doesn't deprecate specific hardware. -- Johann

Re: [PATCH] aacraid: remove bogus GFP_DMA32 specifies

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 1/2] libsas: remove irq save in sas_ata_qc_issue()

nted to say lockdep_assert_irqs_disabled(). Either way, please never ever use BUG_ON() (even WARN_ON() is questionable as some people actually use panic_on_oops). It causes nasty bugs at customer sites. Byte, Johannes -- Johannes Thumshirn St

Re: [PATCH 07/14] scsi_transport_fc: complete requests from ->timeout

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCH 06/14] null_blk: complete requests from ->timeout

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCH 05/14] mtip32xx: complete requests from ->timeout

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCH 03/14] nvme: return BLK_EH_DONE from ->timeout

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCH 02/14] block: rename BLK_EH_NOT_HANDLED to BLK_EH_DONE

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCH v2] scsi_transport_srp: Fix shost to rport translation

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCH] scsi_transport_sas: don't bounce highmem pages for the smp handler

On Sun, Apr 15, 2018 at 04:52:37PM +0200, Christoph Hellwig wrote: > All three instance of ->smp_handler deal with highmem backed requests > just fine. That's my conclusion as well. Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Joh

Re: [PATCH] scsi_transport_sas: don't bounce highmem pages for the smp handler

have a look. Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key finger

Re: [PATCH] scsi_debug: replace SDEG_RES_IMMED_MASK with cmnd flag

log.com> > --- Thanks for having a look into this. Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N

Re: [VERY EARLY RFC 08/13] treewide: use set_host_byte

backwards. Is > there a better helper for this? Yes I think a set_scsi_result(cmd, 0, DID_*, 0, 0); should be way to go as Hannes said. Byte, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUS

Re: [VERY EARLY RFC 12/13] reewide: introduce clear_scsi_result() and convert drivers

On Thu, Apr 19, 2018 at 08:15:47AM +0200, Hannes Reinecke wrote: > On Wed, 18 Apr 2018 17:01:15 +0200 > Johannes Thumshirn <jthumsh...@suse.de> wrote: > > > Introduce clear_scsi_result() and convert drivers over to use the new > > function. > > > > [ .. ]

Re: [VERY EARLY RFC 00/13] Rework SCSI results handling

and use set_scsi_result() for it. This way we zap one of these helpers. Actually we could even use it for all and thus could eliminate all the set_{host,driver,msg}_byte() accessors. Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de

[VERY EARLY RFC 10/13] scsi: introduce set_status_byte and convert LLDDs to use it

@@ struct scsi_cmnd *c; expression E1; @@ ( -c->result |= E1; +set_status_byte(c, E1); | -c->result |= (E1); +set_status_byte(c, E1); ) Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- drivers/ata/libata-scsi.c| 20 drivers/infiniband/ulp/

[VERY EARLY RFC 06/13] scsi: introduce set_scsi_result

lt; @@ -c->result = ScsiResult(E1, E2); +set_scsi_result(c, 0, E1, 0, E2); @@ identifier ScsiResult, host_code,scsi_code; @@ ( -#define ScsiResult(host_code, scsi_code) (((host_code) << 16) | scsi_code) | -#define ScsiResult(host_code, scsi_code) (((host_code) << 16) + ((scsi_

[VERY EARLY RFC 13/13] scsi: introduce struct scsi_result

Introduce struct scsi_result. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> Suggested-by: Bart Van Assche <bart.vanass...@wdc.com> --- block/bsg-lib.c | 8 -- block/bsg.c | 8 -- block/

[VERY EARLY RFC 05/13] scsi: add enum for message byte codes

Add enum for message byte codes and adopt set_msg_byte()'s signature. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> Suggested-by: Bart Van Assche <bart.vanass...@wdc.com> --- include/scsi/scsi.h | 79 +--- include/scsi/scsi

[VERY EARLY RFC 11/13] scsi: Change status bytes to use SAM-3 version

Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- drivers/ata/libata-scsi.c | 2 +- drivers/scsi/3w-9xxx.c| 2 +- drivers/scsi/3w-.c| 6 -- drivers/scsi/arcmsr/arcmsr_hba.c | 4 ++-- drivers/scsi/dc395x.c

[VERY EARLY RFC 03/13] scsi: add enum for host byte codes

Add enum for host byte codes and adopt set_host_byte()'s and host_byte()'s signature. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> Suggested-by: Bart Van Assche <bart.vanass...@wdc.com> --- drivers/scsi/dc395x.c | 3 +-- drivers/scsi/megaraid.c | 6 --

[VERY EARLY RFC 02/13] scsi: remove Scsi_Cmnd typedef

clean. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- drivers/scsi/3w-.c | 2 +- drivers/scsi/advansys.c | 2 +- drivers/scsi/aha152x.c | 71 +--- drivers/scsi/aha1740.c | 9 ++--- drivers/scsi/aha

[VERY EARLY RFC 07/13] scsi: use set_driver_byte

lt = 0; + set_driver_byte(c, E1); | - c->result |= E1 << 24; + set_driver_byte(c, E1); ) Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- drivers/ata/libata-scsi.c | 2 +- drivers/scsi/advansys.c | 1 - drivers/scsi/aic7xxx/aic79xx_osm

[VERY EARLY RFC 00/13] Rework SCSI results handling

://git.kernel.org/pub/scm/linux/kernel/git/jth/linux.git/log/?h=scsi-results Johannes Thumshirn (13): scsi: use host_byte() accessor scsi: remove Scsi_Cmnd typedef scsi: add enum for host byte codes scsi: add enum for driver byte codes scsi: add enum for message byte codes scsi: introduce

[VERY EARLY RFC 09/13] scsi: use set_msg_byte

g_byte(c, E1); | - c->result |= E1 << 8; + c->result = 0; + set_msg_byte(c, E1); | - c->result = (E1 << 8); + set_msg_byte(c, E1); | - c->result |= (E1 << 8); + set_msg_byte(c, E1); ) Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- drivers/scsi/adva

  1   2   3   4   5   6   7   8   9   10   >