James,
> Update lpfc to revision 12.0.0.9
>
> This patch contains lpfc bug fixes
Applied to 4.21/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Dan,
> If "interface" is NULL then we can't release it and trying to will
> only lead to an Oops.
Applied to 4.20/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Himanshu,
> This reverts commit db186382af21e926e90df19499475f2552192b77.
>
> This commit introduced regression with FCP discovery so revert it back
> to fix discovery for FCP luns
Applied to 4.20/scsi-fixes.
--
Martin K. Petersen Oracle Linux Engineering
t;)
>> Signed-off-by: Dan Carpenter
>
> Nice catch, thanks for the fix.
>
> Reviewed-by: Keith Busch
Acked-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
Steffen,
> One new recovery fix, which is not urgent, for an old bug. It's
> sufficient to apply it on top of the previously sent 23 zfcp updates
> for the v4.21 merge window
Applied to 4.21/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
David,
> This patch-set allows for the modification of the T10 Vendor
> Identification string returned in the SCSI INQUIRY response, via the
> target/core/$backstore/$name/wwn/vendor_id ConfigFS path.
Applied to 4.21/scsi-queue, thank you!
--
Martin K. Petersen Oracle Linux Engineering
Bart,
> Nesting in __qla2x00_abort_all_cmds() is way too deep. Reduce the
> nesting level by introducing a helper function. This patch does not
> change any functionality.
Applied to 4.21/scsi-queue. Thank you.
--
Martin K. Petersen Oracle Linux Engineering
Varun,
> flush_scheduled_work() is not required as csio_hw_exit_workers() calls
> cancel_work_sync() for hw->evtq_work.
Applied to 4.21/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Steffen,
> Introduce separate zfcp module parameters to individually select
> support for: DIF which should work (zfcp.dif, which used to be
> DIF+DIX, disabled) or DIX+DIF which can cause trouble (zfcp.dix, new,
> disabled).
Applied to 4.21/scsi-queue.
--
Martin K. Petersen
Avri,
> By spec, the ufs sense data is 18 bytes long.
Applied to 4.21/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
David,
> Indeed, the comment should refer to page 0x83.
> @Martin: all patches in this series have now been reviewed+acked. Can
> you fix the above comment (s/0x80/0x83) if/when you merge, or
>should I resend the series with this fixed?
I'll fix it up.
--
Martin
ot to block numbers.
--
Martin K. Petersen Oracle Linux Engineering
han having to backtrack and spot the
u32 in the function definition. I generally appreciate some sort of
commentary around a return statement if the value deviates from the
ordinary.
The parentheses around the shift value irk me but had to leave those in
place to silence gcc.
--
Martin K. Petersen Or
ty profile.
This in turn caused read/write failures on PI-formatted disks attached to
an mpt3sas controller.
Fixes: ddd0bc756983 ("block: move ref_tag calculation func to the block layer")
Cc: sta...@vger.kernel.org # 4.19+
Reported-by: John Garry
Signed-off-by: Martin K. Petersen
---
includ
Bart,
> The two patches in this series make the qla2xxx driver source code
> easier to read without changing the driver functionality. Please
> consider these patches for kernel v4.21.
I applied patch #1. #2 had conflicts, please rebase.
Thanks!
--
Martin K. Petersen Ora
Nilesh,
> Please consider below patch set for next 'scsi-fixes' submission.
Some of these smelled more like features than bug fixes. So I applied
the series to 4.21/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
here the protection is generated over a whole bio at a time, you
can get away with something smaller.
Anyway. I don't have any problems with you making DIX experimental for
zfcp. Just want to make sure it's done for the right reasons (i.e. not
problems in SCSI or the block layer).
--
Martin K. Petersen Oracle Linux Engineering
ric_ops.name
> and fabric_ops.get_fabric_name() - use a new fabric_ops.fabric_alias
> member to handle the iscsi_target_mod special case.
Applied to 4.21/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
lied to 4.20/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
tics during device discovery. That's
always a tricky game to play.
Hope that makes sense?
--
Martin K. Petersen Oracle Linux Engineering
> Since f44ac12f1dcc, BG enablement is tracked with the
> LPFC_SLI3_BG_ENABLED bit, which is set in lpfc_get_cfgparam before
> lpfc_sli_config_sli_port() is called. The bit shouldn't be cleared
> before checking the feature.
James, please review.
Thanks!
--
Martin K. Petersen
ver used since commit
> cf4e6363859d ("[SCSI] bnx2i: Add bnx2i iSCSI driver.")
Applied to 4.21/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
PCI_IRQ_MSIX | PCI_IRQ_AFFINITY, );
> + cnt = pci_alloc_irq_vectors(hw->pdev, min, cnt, PCI_IRQ_MSIX);
> if (cnt < 0)
> return cnt;
--
Martin K. Petersen Oracle Linux Engineering
Christoph,
> aha1542 is one of the last users of the legacy isa_*_to_bus APIs, which
> also isn't portable enough. Convert it to the proper DMA mapping API.
Applied to 4.21/scsi-queue, thank you!
--
Martin K. Petersen Oracle Linux Engineering
Shivasharan,
> This patch adds support for MegaRAID Aero controller PCI IDs.
> Throw a message when a Configurable secure type controller is
> encountered.
Applied to 4.21/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
mit description. Fixed it up.
> v2 change set:
> Replaced dev_warn() with dev_info() function while
> displaying above message.
Applied to 4.21/scsi-queue. Thanks.
--
Martin K. Petersen Oracle Linux Engineering
t;
> It no used any more after
> commit baa6719f902a （"libfc: Update rport reference counting")
^^^
Please run checkpatch. Fixed it up and applied to 4.21/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
wing clustered (e.g. tcm-user) backends to block such requests,
> avoiding the multi-node reservation state propagation.
>
> When explicitly disabled, PR and RESERVE/RELEASE requests receive
> Invalid Command Operation Code response sense data.
Applied to 4.21/scsi-queue. Thank you!
--
n
be fixed rather than circumventing them through driver module parameter.
Hope that makes sense.
--
Martin K. Petersen Oracle Linux Engineering
Christoph,
> Various dma relates cleanups
Applied to 4.21/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Christoph,
> Various SCSI drivers that otherwise use the generic DMA API
> still use pci_set_dma_mask, so switch them over to dma_set_mask
> and dma_set_mask_and_coherent.
Applied to 4.21/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
Sreekanth,
>> Display below warning message only up on detection of
>> Configurable secure type controllers.
Actually, same question as for Shivasharan: Why a warning?
--
Martin K. Petersen Oracle Linux Engineering
Shivasharan,
> This patch adds support for MegaRAID Aero controller PCI IDs.
> Throw a warning message when a Configurable secure type controller is
> encountered.
> + dev_warn(>dev, "Adapter is in configurable secure
> mode\n");
Why warn and not i
Bill,
> When doing a surprise removal of an adapter, some in flight I/Os can get
> stuck and take a while to complete (they actually timeout and are
> retried). We are not handling an early error exit from
> qla2xxx_eh_abort properly.
Applied to 4.20/scsi-fixes, thank you.
WRITE SAME. So if you guys are seeing failures, it must be due to zfcp
not handling the scsi_cmnd prot_op/prot_flags or the command PROTECT bit
correctly.
> or due to unstable page writes.
BDI_CAP_STABLE_WRITES should take care of this. What's the configuration
that fails?
--
Martin K.
Sreekanth,
> Display below warning message only up on detection of
> Configurable secure type controllers.
>
> "HBA is in Configurable Secure mode"
Applied to 4.21/scsi-queue, thanks.
--
Martin K. Petersen Oracle Linux Engineering
James,
> This patch contains lpfc bug fixes and 2 enhancements.
Applied to 4.21/scsi-queue. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
Christoph,
> Some drivers make very odd decisions on when to use support for
> 64-bit addressing. Fix this up a bit.
Applied to 4.21/scsi-queue. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
Christoph,
> Cleans up various oddities found during a code audit.
Applied to 4.21/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Chengguang,
> mempool_destroy() can handle NULL pointer correctly, so there is
> no need to check NULL pointer before calling mempool_destroy().
Applied to 4.21/scsi-queue. Thank you.
--
Martin K. Petersen Oracle Linux Engineering
Chengguang,
> dma_pool_destroy() can handle NULL pointer correctly, so there is
> no need to check NULL pointer before calling dma_pool_destroy().
Applied to 4.21/scsi-queue, thanks.
--
Martin K. Petersen Oracle Linux Engineering
Himanshu,
> This patch initializes port speed so that firmware does not set lower
> operating speed. Setting lower speed in firmware impacts WRITE
> perfomance.
Applied to 4.20/scsi-fixes.
> Singed-off-by: Quinn Tran
Pitch Perfect but not Patch Perfect. Fixed.
--
Martin
ort properly.
--
Martin K. Petersen Oracle Linux Engineering
Shivasharan,
> Can you please let us know if above patch series is good to be picked
> for the next kernel version?
The submission window for 4.21 just opened yesterday (You were too late
for 4.20).
I applied the series to 4.21/scsi-queue.
Thanks!
--
Martin K. Petersen Oracle
ic set of things that would be useful to inspect
in the sg state, by all means introduce trace points for them.
--
Martin K. Petersen Oracle Linux Engineering
Dan,
>> +if (value < 0 || value > 2)
>> return -EINVAL;
>
> It's not actually clear to me why we allow 2. Shouldn't we just use
> kstrtobool()?
Hannes?
--
Martin K. Petersen Oracle Linux Engineering
commit
> 20b09c2992fe ("[SCSI] mvsas: add support for 94xx; layout change; bug fixes")
Applied to 4.20/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
Bart,
> This is a series with mostly trivial patches for the qla2xxx
> driver. These patches address warnings reported by gcc and by the
> smatch and sparse static analyzers. Please consider these patches for
> kernel v4.20.
Applied to 4.20/scsi-queue. Thanks!
--
Martin
ormation out to the user these days. No need to resort to arcane
logging masks and the like.
--
Martin K. Petersen Oracle Linux Engineering
Dan,
> The || was supposed to be |. The original code just sets ->result to 1.
Applied to 4.20/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Dan,
> If both processors are absent then it's supposed to print that, but
> instead we print that just the second processor is absent.
Applied to 4.20/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
gt; KASAN which will trigger an info leak warning when that happens.
s/kstrtoint/kstrtouint/?
--
Martin K. Petersen Oracle Linux Engineering
surrounding code has
changed significantly.
--
Martin K. Petersen Oracle Linux Engineering
James,
> For 32 bit versions we have to be careful about divisions of 64 bit
> quantities so use do_div() instead of a direct division. This fixes a
> warning about _uldivmod being undefined in certain configurations
Applied to 4.20/scsi-queue.
--
Martin K. Petersen Ora
Jens,
> Would be nice to fix up the SCSI midlayer instead, but this will
> do for now.
Applied to 4.20/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
Christoph,
> A lot of SCSI drivers still use the legacy PCI DMA API. While a few
> of them have various oddities that should be deal with separately,
> most of them can be very trivially converted over.
Applied to 4.20/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
Christoph,
> A few bits found when auditing DMA API use. The first list cleanup
> isn't directly related, but I had to to do this first to fully
> understand the code..
Applied to 4.20/scsi-queue. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
Laurence,
Patch completely mangled by your mailer, please use git send-email for
submissions. I applied the change by hand.
Thanks!
--
Martin K. Petersen Oracle Linux Engineering
o we
> can fix this issue by removing the call to target_wait_for_sess_cmd()
> altogether.
Applied to 4.20/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
ed since 2b65e18202fd ("scsi: lpfc: NVME Target: Add debugfs
> support")
Applied to 4.20/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
2c ("scsi: lpfc: NVME Initiator: Base modifications")
> 'psli' is not used any more.
Applied to 4.20/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
msr/arcmsr_hba.c:1320:6: warning:
> variable 'id' set but not used [-Wunused-but-set-variable]
Applied to 4.20/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Jens,
> We just need to free the request here. Additionally, this is
> currently wrong for a queue that's using MQ currently, it'll
> crash.
Applied to 4.20/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
Jens,
> This is currently wrong since it isn't dependent on if we're using
> mq or not. At least now it'll be correct when we force mq.
Applied to 4.20/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
I was waiting for Hannes to address the feedback from Bart and
Johannes.
--
Martin K. Petersen Oracle Linux Engineering
unnecessary
> serialization between sd_probe() and sd_remove() because this could
> lead to a deadlock.
I like it.
What kind of testing have you done with $BIGNUM devices? Got any numbers
to share?
--
Martin K. Petersen Oracle Linux Engineering
> reports.
Yes, please. Patchwork can't handle individual patches getting updated
either.
Applied to 4.20/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
the
> ndlp structure could be going away, perhaps we should be looking more
> closely at the code in lpfc_nlp_get() that uses the structure a bunch of
> times, including dereferencing ndlp->phba and taking the phba->nlp_lock
> before taking a kref on it? (As well as the debugging
nk we'll have to have the ability to distinguish
between offlined-by-user-action, offlined-by-device-error, and
offlined-by-transport-event as Ewan pointed out.
--
Martin K. Petersen Oracle Linux Engineering
Christoph,
> Mostly to avoid methods calls for dma mapping, but also to tidy up
> a few bits found while doing that.
Applied to 4.20/scsi-queue. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
Christoph,
> dma_alloc_coherent allocates memory that can be used by the cpu and the
> device at the same time, calls to pci_dma_sync_* are not required, and
> in fact actively harmful on some architectures like arm.
Applied to 4.20/scsi-queue, thanks!
--
Martin K. Petersen Ora
ome
> reason.
>
> Also remove the now pointless megaraid_mbox_sync_scb function.
Applied to 4.20/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
ore transport/bsg/ufs patches to make it
> relevant.
Applied to 4.20/scsi-queue, thank you!
--
Martin K. Petersen Oracle Linux Engineering
Himanshu,
> This patch fixes commit bcc71cc3cde1468958a3ea859276d8d1a1a68265 which
> misplaced code in worng routines.
>
> Also updated the use of WARN_ON() to WARN_ON_ONCE() to prevent
> flooding log messages.
Applied to 4.20/scsi-queue, thanks!
--
Martin K. Petersen
nnes Reinecke was cherry-picked from his 'eh-reset.v5'
> branch.
Applied to 4.20/scsi-queue, thank you!
--
Martin K. Petersen Oracle Linux Engineering
de against 4.19/fixes branch. Please consider this
> for next rc inclusion.
Even though the changes were individually pretty trivial, it was a big
amount of churn this late in the cycle. So I applied the series to
4.20/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
Nilesh,
> Fix kernel NULL pointer dereference,
Applied to 4.19/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Dan,
> We shouldn't allow negative thresholds. I don't know what it would do
> but it can't be good.
Applied to 4.20/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Masanari,
> Default value of ql2xasynctmfenable for qla2xxx driver was set to 1 in
> commit 043dc1d7e8501. But comment in MODULE_PARAM_DESC was not
> modified.
Applied to 4.20/scsi-queue. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
le
Also, when you repost, please make sure to carry over Reviewed-by: tags
received for patches you haven't (substantially) changed.
Looking over these yesterday, I noticed they were a blank slate in the
tags department and that's very unusual for a 6th iteration of a patch
set.
--
Martin K. Pe
set to? And how to tweak
it?
So I don't think the log level issue is particularly interesting in
itself. I think it would be more worthwhile to massage the message.
--
Martin K. Petersen Oracle Linux Engineering
Greg,
> Split the PI SGL across the bios in the command, so each bio's
> bio_integrity_payload contains the protection information for the data
> in the bio.
That is indeed how the bio integrity code is intended to be used. I have
queued it up. Thanks!
--
Martin K. Petersen Ora
reated as an error.
> There are many portable drives that don't have a write cache.
We have it at error level because many consumer devices lie about having
caches and we would like the users to know that their data integrity may
be at risk.
--
Martin K. Petersen Oracle Linux Engineering
ect by using locks to synchronize the dereferences.
Applied to 4.19/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
i-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
m_posted, sgl_size;
> ^
Applied to 4.20/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
YueHaibing,
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/scsi/bnx2fc/bnx2fc_fcoe.c: In function 'bnx2fc_rcv':
> drivers/scsi/bnx2fc/bnx2fc_fcoe.c:435:17: warning:
> variable 'oxid' set but not used [-Wunused-but-set-variable]
Applied to 4.20/scsi-queue, thanks
si-queue, thank you!
--
Martin K. Petersen Oracle Linux Engineering
i-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
> drivers/scsi/pm8001/pm8001_sas.c: In function 'pm8001_abort_task':
> drivers/scsi/pm8001/pm8001_sas.c:1191:6: warning:
> variable 'device_id' set but not used [-Wunused-but-set-variable]
Applied to 4.20/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Viswas,
> This patch set include some bug fixes for pm80xx driver.
Applied to 4.20/scsi-queue, thank you!
--
Martin K. Petersen Oracle Linux Engineering
Dan,
> We should first do the le16_to_cpu endian conversion and then apply
> the FCP_CMD_LENGTH_MASK mask.
Applied to 4.19/scsi-fixes, thank you!
--
Martin K. Petersen Oracle Linux Engineering
YueHaibing,
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/scsi/libfc/fc_fcp.c: In function 'fc_queuecommand':
> drivers/scsi/libfc/fc_fcp.c:1875:30: warning:
> variable 'rpriv' set but not used [-Wunused-but-set-variable]
Applied to 4.20/scsi-queue. Thank you
James,
> This patch contains lpfc bug fixes, a couple of performance mods, and
> a new diagnostic ability
Applied to 4.20/scsi-queue, thank you!
--
Martin K. Petersen Oracle Linux Engineering
Himanshu,
> This patch series fixes issues found during our testing for qla2xxx.
Also applied. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
Himanshu,
> This series updates driver for ABTS handling and rport management.
>
> Please queue this patches to 4.20/scsi-misc at your earliest convenience.
Applied to 4.20/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
Himanshu,
> This series contains support for ZIO interrupt threashold and
> cleanups.
Applied!
--
Martin K. Petersen Oracle Linux Engineering
Chengguang,
> kmem_cache_destroy() can handle NULL pointer correctly, so there is
> no need to check NULL pointer before calling kmem_cache_destroy()
Applied to 4.20/scsi-queue, thank you.
--
Martin K. Petersen Oracle Linux Engineering
i-queue, thank you!
--
Martin K. Petersen Oracle Linux Engineering
Faisal,
> 'NEGOTIATION' was misspelled as 'NEGOTATION'. Fixed it. It is a coding
> style change which should have no impact on runtime execution of code.
Applied to 4.20/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
1 - 100 of 2771 matches
Mail list logo
