Dne 6.12.2018 v 11:34 Maurizio Lombardi napsal(a):
> This is what I see when a cd burn operation completes:
>
This is the complete blktrace log:
11,034 0.81759 11653 D W 63488 (2a 00 00 03 3c 29 00 00
1f 00 ..) [wodim]
11,034 0.81759 11
Hi Jens,
Dne 20.6.2018 v 16:09 Jens Axboe napsal(a):
> On 6/20/18 5:52 AM, Maurizio Lombardi wrote:
>> Hi Jens,
>>
>> Dne 23.5.2018 v 16:42 Jens Axboe napsal(a):
>>> On 5/23/18 3:19 AM, Maurizio Lombardi wrote:
>>>>
>>>>
>>>> Dne
hen the
CONFIG_VMAP_STACK option is enabled.
This patch modifies the code so the buffer will be allocated on the heap
and adds a pointer to it in the iscsi_conn structure.
v2: allocate conn_rx_buf in iscsi_target_login_thread()
and fix a memory leak
Signed-off-by: Maurizio Lombardi
---
drivers/target/is
Hi Jens,
Dne 23.5.2018 v 16:42 Jens Axboe napsal(a):
> On 5/23/18 3:19 AM, Maurizio Lombardi wrote:
>>
>>
>> Dne 22.5.2018 v 16:47 Jens Axboe napsal(a):
>>> It's been many years, but back in the day the program writing the cd
>>> would eject the disc on
Dne 23.5.2018 v 16:42 Jens Axboe napsal(a):
> On 5/23/18 3:19 AM, Maurizio Lombardi wrote:
>>
>>
>> Dne 22.5.2018 v 16:47 Jens Axboe napsal(a):
>>> It's been many years, but back in the day the program writing the cd
>>> would eject the disc on
Dne 22.5.2018 v 16:47 Jens Axboe napsal(a):
> It's been many years, but back in the day the program writing the cd
> would eject the disc once done. This of course forces a reload of
> the toc and clearing of the flag. What program is this? Seems like
> it should probably eject when it's done.
ble to you? Do you have different ideas?
Maurizio Lombardi (1):
sr: mark device as changed when performing a write SG_IO operation
drivers/scsi/sr.c | 8
1 file changed, 8 insertions(+)
--
Maurizio Lombardi
Signed-off-by: Maurizio Lombardi <mlomb...@redhat.com>
---
drivers/scsi/sr.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/scsi/sr.c b/drivers/scsi/sr.c
index 3f3cb72..e64311d 100644
--- a/drivers/scsi/sr.c
+++ b/drivers/scsi/sr.c
@@ -49,6 +49,7 @@
#include
#i
and then the s_umount lock.
This patch fixes the issue by moving check_disk_change() out of
cdrom_open() and let the caller take care of it.
Signed-off-by: Maurizio Lombardi <mlomb...@redhat.com>
---
drivers/block/paride/pcd.c | 2 ++
drivers/cdrom/cdrom.c | 3 ---
drivers/cdrom/gdrom
cc1: warnings being treated as errors
drivers/scsi/lpfc/lpfc_init.c: In function 'lpfc_get_wwpn':
drivers/scsi/lpfc/lpfc_init.c:3253: error: integer constant is too large for
'long' type
Signed-off-by: Maurizio Lombardi <mlomb...@redhat.com>
v2: use rol64()
---
drivers/scsi/lpfc/lpfc_
Dne 27.7.2017 v 14:57 Martin K. Petersen napsal(a):
>> diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
>> index 491aa95..e992dc1 100644
>> --- a/drivers/scsi/lpfc/lpfc_init.c
>> +++ b/drivers/scsi/lpfc/lpfc_init.c
>> @@ -3710,8 +3710,8 @@
>> if (phba->sli_rev ==
cc1: warnings being treated as errors
drivers/scsi/lpfc/lpfc_init.c: In function 'lpfc_get_wwpn':
drivers/scsi/lpfc/lpfc_init.c:3253: error: integer constant is too large for
'long' type
Signed-off-by: Maurizio Lombardi <mlomb...@redhat.com>
---
drivers/scsi/lpfc/lpfc_init.c | 4 ++--
Douglas,
> Has there been any progress with getting this patch accepted?
>
It has been merged already.
It's in linux-next, commit 62e62ffd95539b9220894a7900a619e0f3ef4756
https://kernel.googlesource.com/pub/scm/linux/kernel/git/next/linux-next/+/62e62ffd95539b9220894a7900a619e0f3ef4756
The enclosure_add_device() function should fail if it can't
create the relevant sysfs links.
Signed-off-by: Maurizio Lombardi <mlomb...@redhat.com>
---
drivers/misc/enclosure.c | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/drivers/misc/enclosure.c b/d
Dne 16.6.2017 v 18:08 Douglas Miller napsal(a):
> Just to respond to James' question on the cause. What I observed was a race
> condition between udevd (ses_init()) and a worker thread (do_scan_async()),
> where the worker thread is creating the directories that are the target of
> the
Dne 16.6.2017 v 14:40 Douglas Miller napsal(a):
>
> I'd like to add that we are seeing this problem with singlepath installations
> and need to get this fixed upstream as soon as possible. RHEL new product
> contains this fix and is working for us, but we need to be able to offer
> other
x20 [scsi_transport_fc]
[] ? dev_attr_show+0x27/0x50
[] ? __get_free_pages+0xe/0x50
[] ? sysfs_read_file+0x111/0x200
[] ? vfs_read+0xb5/0x1a0
[] ? fget_light_pos+0x16/0x50
[] ? sys_read+0x51/0xb0
[] ? __audit_syscall_exit+0x25e/0x290
[] ? system_call_fastpath+0x16/0x1b
Signed-off-by: Maurizio Lombardi <
Signed-off-by: Maurizio Lombardi <mlomb...@redhat.com>
---
drivers/scsi/ses.c | 21 +
1 file changed, 13 insertions(+), 8 deletions(-)
diff --git a/drivers/scsi/ses.c b/drivers/scsi/ses.c
index f1cdf32..0ac45be 100644
--- a/drivers/scsi/ses.c
+++ b/drivers/scsi/ses.c
@@ -604,6
This patch fixes a potential buffer overflow in lpfc_nvme_info_show().
Signed-off-by: Maurizio Lombardi <mlomb...@redhat.com>
---
drivers/scsi/lpfc/lpfc_attr.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_
Dne 21.3.2017 v 10:58 Maurizio Lombardi napsal(a):
> I will ask our customer to test your patch,
> there is only a small problem: you can't set cdev->dev = NULL
> and then call enclosure_add_links(cdev) because you will end up dereferencing
> a NULL pointer.
> I suggest a
Dne 16.3.2017 v 19:49 James Bottomley napsal(a):
> diff --git a/drivers/misc/enclosure.c b/drivers/misc/enclosure.c
> index 65fed71..ae89082 100644
> --- a/drivers/misc/enclosure.c
> +++ b/drivers/misc/enclosure.c
> @@ -375,6 +375,7 @@ int enclosure_add_device(struct enclosure_device *edev,
>
] enclosure_add_device(0:0:27:0) called, device already exists
This patch modifies the code so the driver will detect this condition
and will retry to create the symlinks when enclosure_add_device() is called.
Signed-off-by: Maurizio Lombardi <mlomb...@redhat.com>
---
drivers/misc/enclosure.c
Hi James,
have you noticed this patch?
Dne 7.2.2017 v 15:08 Maurizio Lombardi napsal(a):
> With multipath, it may happen that the same device is passed
> to enclosure_add_device() multiple times and that the enclosure_add_links()
> function fails to create the symlinks because the
immediately
without retrying to create the symlinks.
Maurizio Lombardi (1):
enclosure: fix sysfs symlinks creation when using multipath
drivers/misc/enclosure.c | 16 ++--
include/linux/enclosure.h | 1 +
2 files changed, 15 insertions(+), 2 deletions(-)
--
Maurizio Lombardi
the subsequent
calls to enclosure_add_device() will immediately fail with EEXIST.
This patch modifies the code so the driver will detect this condition
and will retry to create the symlinks when enclosure_add_device() is called.
Signed-off-by: Maurizio Lombardi <mlomb...@redhat.com>
---
driver
The "fcp_rsp_code = %d" message isn't an error, it's meant to
be informative only.
This patch prevents a flood of such messages in some situations.
Tested-by: Laurence Oberman <lober...@redhat.com>
Signed-off-by: Maurizio Lombardi <mlomb...@redhat.com>
---
drivers/scsi/
On 03/08/2016 03:03 AM, Martin K. Petersen wrote:
>>>>>> "Maurizio" == Maurizio Lombardi <mlomb...@redhat.com> writes:
>
> Maurizio,
>
> Maurizio> In beiscsi_setup_boot_info(), the boot_kset pointer should be
> Maurizio> set to NULL in
In beiscsi_setup_boot_info(), the boot_kset pointer should be set
to NULL in case of failure otherwise an invalid pointer dereference
may occur later.
Signed-off-by: Maurizio Lombardi <mlomb...@redhat.com>
---
drivers/scsi/be2iscsi/be_main.c | 1 +
1 file changed, 1 insertion(+)
diff
If the link is not ready, the bnx2fc_eh_abort() function
should return FAILED.
Signed-off-by: Maurizio Lombardi <mlomb...@redhat.com>
---
drivers/scsi/bnx2fc/bnx2fc_io.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/bnx2fc/bnx2fc_io.c b/drivers/scsi/
The pd_seq_sync pointer can't be NULL, we have to check
its entries instead.
Signed-off-by: Maurizio Lombardi <mlomb...@redhat.com>
---
drivers/scsi/megaraid/megaraid_sas_base.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/scsi/me
Please ignore this one, I sent a V2
On 11/18/2015 02:18 PM, Maurizio Lombardi wrote:
> If cdev_add() returns an error, the code calls
> cdev_del() passing the STm->cdevs[rew] pointer as parameter;
> the problem is that the pointer has not been initialized yet.
>
> This patch
o sets STm->devs[rew] = NULL if device_create() fails, just to be
sure we won't end up calling device_unregister() with an invalid pointer.
Signed-off-by: Maurizio Lombardi <mlomb...@redhat.com>
---
drivers/scsi/st.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/driv
particular -
those characters make the code look weird.
It's not a real issue so if you want to keep them it's ok for me.
Regards,
Maurizio Lombardi
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo in
Signed-off-by: Maurizio Lombardi <mlomb...@redhat.com>
---
drivers/scsi/st.c | 24
1 file changed, 8 insertions(+), 16 deletions(-)
diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c
index b37b9b0..7c4e518 100644
--- a/drivers/scsi/st.c
+++ b/drivers/scsi/st.c
@@
>
If kzalloc() fails perhaps the function should return -ENOMEM, not zero.
Regards,
Maurizio Lombardi
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
In case of error, the memory allocated for phwi_ctrlr was not freed.
Signed-off-by: Maurizio Lombardi <mlomb...@redhat.com>
---
drivers/scsi/be2iscsi/be_main.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_
Hi James,
the following patch for bnx2fc has been acked by QLogic but has never been
included
into the scsi branch.
Can you please merge it?
http://marc.info/?l=linux-scsi=140207797017410=2
Thanks,
Maurizio Lombardi
--
To unsubscribe from this list: send the line "unsubscribe linux
i_debug/map
0-15
# lvcreate -V200m -l99%FREE -T tsvg/pool -n lv1 --discards ignore
Logical volume "lv1" created.
# cat /sys/bus/pseudo/drivers/scsi_debug/map
0-31,2048-2055,501760-501871
Thanks,
Maurizio Lombardi
>
> add/remove: 18/16 grow/shrink: 3/2 up/down: 5551/-5775
ping?
On 08/12/2015 05:00 PM, Maurizio Lombardi wrote:
> the kernel prints some warnings when compiled with CONFIG_DMA_API_DEBUG.
> This is because the fnic driver doesn't check the return value of
> pci_map_single().
>
> [ 11.942770] scsi host12: fnic
> [ 11.950811]
check_unmap+0x47b/0x920()
[ 11.950821] fnic :0c:00.0: DMA-API: device driver failed to check map
error[device address=0x002020a30040] [size=44 bytes] [mapped as single]
Signed-off-by: Maurizio Lombardi mlomb...@redhat.com
---
drivers/scsi/fnic/fnic_fcs.c | 46
,
Maurizio Lombardi
Maurizio Lombardi mlomb...@redhat.com writes:
the kernel prints some warnings when compiled with CONFIG_DMA_API_DEBUG.
This is because the fnic driver doesn't check the return value of
pci_map_single().
[ 11.942770] scsi host12: fnic
}
[..]
void fnic_free_rq_buf
check_unmap+0x47b/0x920()
[ 11.950821] fnic :0c:00.0: DMA-API: device driver failed to check map
error[device address=0x002020a30040] [size=44 bytes] [mapped as single]
Signed-off-by: Maurizio Lombardi mlomb...@redhat.com
---
drivers/scsi/fnic/fnic_fcs.c | 32
I forgot the signed-off-by, I'll send a new version.
On Fri, 2015-03-06 at 14:52 +0100, Maurizio Lombardi wrote:
---
drivers/scsi/be2iscsi/be_iscsi.c | 3 +--
drivers/scsi/be2iscsi/be_main.c | 3 +--
drivers/scsi/be2iscsi/be_mgmt.c | 3 +--
3 files changed, 3 insertions(+), 6 deletions
, sizeof(*req));
spin_lock(ctrl-mbox_lock);
memset(wrb, 0, sizeof(*wrb));
be_wrb_hdr_prepare(wrb, sizeof(*req), false, 1);
--
Maurizio Lombardi
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More
]---
Signed-off-by: Maurizio Lombardi mlomb...@redhat.com
Acked-by: Chad Dupuis chad.dup...@qlogic.com
---
drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
index 79e5c94..72533c5 100644
Hi Chad,
Thanks.
CC James and Christoph
On Fri, 2014-11-14 at 16:26 -0500, Chad Dupuis wrote:
Maurizio, we've been running this for a little while with no issues so
it's good to go from our perspective.
Acked-by: Chad Dupuis chad.dup...@qlogic.com
On Fri, 14 Nov 2014, Maurizio Lombardi
Hi Chad,
On Fri, 2014-08-22 at 16:02 -0700, Eddie Wai wrote:
On Fri, 2014-07-25 at 10:12 +0200, Maurizio Lombardi wrote:
On 07/25/2014 10:02 AM, Maurizio Lombardi wrote:
In some cases, the fcoe_rx_list may contains multiple instances
of the same skb (the so called shared skbs
8820b0da3b68
CR2: 004c
Signed-off-by: Maurizio Lombardi mlomb...@redhat.com
---
drivers/scsi/bnx2fc/bnx2fc_els.c | 2 --
drivers/scsi/bnx2fc/bnx2fc_io.c | 19 ++-
2 files changed, 10 insertions(+), 11 deletions(-)
diff --git a/drivers/scsi/bnx2fc/bnx2fc_els.c b/drivers/scsi
S_IRUGO;
default:
return 0;
Can you merge this patch? It has been ACKed already.
Thanks,
Maurizio Lombardi
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info
]---
Signed-off-by: Maurizio Lombardi mlomb...@redhat.com
---
drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
index 79e5c94..72533c5 100644
--- a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
+++ b
Hi Eddie,
On 08/20/2014 07:35 PM, Eddie Wai wrote:
On Mon, 2014-08-04 at 10:20 +0200, Maurizio Lombardi wrote:
In the bnx2fc_map_sg() function, the original behaviour is to
allocate the DMA memory by directly calling dma_map_sg()
instead of using scsi_dma_map().
In contrast
it.
So far, I didn't get any error or strange behaviour after this change.
Eddie, what do you think about it?
Regards,
Maurizio Lombardi
diff --git a/drivers/scsi/bnx2fc/bnx2fc_io.c b/drivers/scsi/bnx2fc/bnx2fc_io.c
index 32a5e0a..8b4adcf 100644
--- a/drivers/scsi/bnx2fc/bnx2fc_io.c
+++ b
] ? kthread_create_on_node+0x170/0x170
[56069.689416] [816ca3bc] ret_from_fork+0x7c/0xb0
[56069.715510] [810a42c0] ? kthread_create_on_node+0x170/0x170
Signed-off-by: Maurizio Lombardi mlomb...@redhat.com
---
drivers/scsi/bnx2fc/bnx2fc_io.c | 6 ++
1 file changed, 2 insertions(+), 4
the qla4xxx_alloc_fw_dump() calls dma_alloc_coherent() but does not
check its return value.
Signed-off-by: Maurizio Lombardi mlomb...@redhat.com
---
drivers/scsi/qla4xxx/ql4_init.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/scsi/qla4xxx/ql4_init.c b/drivers/scsi/qla4xxx
]---
Signed-off-by: Maurizio Lombardi mlomb...@redhat.com
---
drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
index 785d0d7..a190ab6 100644
--- a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
+++ b
:
Delivery has failed to these recipients or groups:
dept_linux...@qlogic.commailto:dept_linux...@qlogic.com
Your message can't be delivered because delivery to this address is restricted.
On 07/25/2014 10:02 AM, Maurizio Lombardi wrote:
In some cases, the fcoe_rx_list may contains
because it does not add useful information.
Signed-off-by: Maurizio Lombardi mlomb...@redhat.com
---
drivers/scsi/scsi_lib.c | 40
1 file changed, 4 insertions(+), 36 deletions(-)
diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index f7e3163
Lombardi
Signed-off-by: Maurizio Lombardi mlomb...@redhat.com
Acked-by: Jack Wang xjtu...@gmail.com
Acked-by: Suresh Thiagarajan suresh.thiagara...@pmcs.com
---
drivers/scsi/pm8001/pm8001_init.c | 13 ++---
1 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/drivers
tempted to agree and just remove the description. Do you want to
send a patch for this?
So I'll get rid of the description string completely...
I'm going to send a new patch later today.
Regards,
Maurizio Lombardi
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body
in sd_probe?
is there any benefit to do so?
A possible explanation may be that sd_probe_async() calls sd_spinup_disk(),
this function spins up the drive and
may block for some seconds, so it is better to do that asynchronously.
Regards,
Maurizio Lombardi
--
To unsubscribe from this list: send
the return 0; ?
Regards,
Maurizio Lombardi
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
The if_info pointer is not released by the mgmt_set_ip() function
Signed-off-by: Maurizio Lombardi mlomb...@redhat.com
---
drivers/scsi/be2iscsi/be_mgmt.c | 20 +++-
1 file changed, 11 insertions(+), 9 deletions(-)
diff --git a/drivers/scsi/be2iscsi/be_mgmt.c b/drivers/scsi
;
if (boot_proto == ISCSI_BOOTPROTO_DHCP) {
if (if_info-dhcp_state) {
beiscsi_log(phba, KERN_WARNING, BEISCSI_LOG_CONFIG,
BG_%d : DHCP Already Enabled\n);
goto exit;
}
Regards,
Maurizio
the function
behaviour)
but helped to spot a defect.
But I'll make a new patch then, with = 3 ?
Yes, please submit a new patch which sets custom_length = 3 at the end of the
function.
Thanks,
Maurizio Lombardi
--
To unsubscribe from this list: send the line unsubscribe linux-scsi
On 06/26/2014 10:09 AM, Jack Wang wrote:
Thanks Rickard,
From my point of view, looks good, but I'd like to get review from Anand
(cc-ed).
I would like to add that I noticed that this fields is only set and appears to
be never used,
maybe it could be completely removed.
Regards,
Maurizio
In the beiscsi_conn_get_stats() function, custom_length should be set
to 1 to take into account the eh_abort_cnt field at custom[0].
Signed-off-by: Maurizio Lombardi mlomb...@redhat.com
---
drivers/scsi/be2iscsi/be_iscsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On 06/26/2014 02:05 PM, Joe Perches wrote:
On Thu, 2014-06-26 at 13:54 +0200, Rickard Strandqvist wrote:
A struct member variable is set to different values without having used in
between.
[]
diff --git a/drivers/scsi/bnx2i/bnx2i_iscsi.c
b/drivers/scsi/bnx2i/bnx2i_iscsi.c
[]
@@
On 06/26/2014 01:54 PM, Rickard Strandqvist wrote:
A struct member variable is set to different values without having used in
between.
It is almost ok for me but I think you should mention that it also fixes a bug,
or the commit message will be misleading.
This was found using a static
?
No, I missed it, thanks for pointing it out to me.
Thanks,
Maurizio Lombardi
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
-custom[2].value = conn-eh_abort_cnt;
stats-digest_err = 0;
Eddie,
The code modifies the content of stats-custom[2], so shouldn't custom_length
be set to 3?
Why is it set to zero at the end of this function?
Regards,
Maurizio Lombardi
--
To unsubscribe from this list: send the line
This one looks good to me,
Reviewed-by: Maurizio Lombardi mlomb...@redhat.com
On 06/25/2014 04:01 PM, Rickard Strandqvist wrote:
A struct member variable is set to different values without having used in
between.
This was found using a static code analysis program called cppcheck
Signed
ACK and it takes precedence in any case,
am I wrong?
Regards,
Maurizio Lombardi
thanks,
Purush
On Wed, Jun 25, 2014 at 8:34 AM, Maurizio Lombardi mlomb...@redhat.com
wrote:
This one looks good to me,
Reviewed-by: Maurizio Lombardi mlomb...@redhat.com
On 06/25/2014 04:01 PM
, cmd);
}
cancel_delayed_work() may return while the abort handler is still running,
the problem is that __scsi_put_command() frees the cmd pointer that
is still used by the abort handler.
Is it correct? Isn't safer to use cancel_delayed_work_sync() here?
Thanks,
Maurizio Lombardi
--
To unsubscribe
before calling bnx2fc_cmd_mgr_free().
Signed-off-by: Maurizio Lombardi mlomb...@redhat.com
---
drivers/scsi/bnx2fc/bnx2fc_io.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/scsi/bnx2fc/bnx2fc_io.c b/drivers/scsi/bnx2fc/bnx2fc_io.c
index 32a5e0a..7bc47fc 100644
--- a/drivers/scsi
The pm8001_get_phy_settings_info() function does not check
the kzalloc() return value and does not free the allocated memory.
Signed-off-by: Maurizio Lombardi mlomb...@redhat.com
---
drivers/scsi/pm8001/pm8001_init.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff
minutes.
Thanks,
Maurizio Lombardi
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
as it indicates
something that is not addressed by the mid layer.
This patch removes Unhandled error code and replaces Unhandled sense code
with Failing command with sense code:.
Signed-off-by: Maurizio Lombardi mlomb...@redhat.com
---
drivers/scsi/scsi_lib.c | 6 ++
1 file changed, 2
)
There was already a patchset trying to modify the code in a different way than
mine:
https://groups.google.com/forum/#!msg/linux.kernel/3IanUpBVhFQ/3Xbg3yLRFp4J
but it has been ignored and in my opinion it takes a more
complicated approach.
Regards,
Maurizio Lombardi
--
To unsubscribe from this list: send
().
But it shouldn't have been related with current virtio-blk problem.
This is a valid point, bi_iter.bi_size influences the behaviour of
blk_recount_segments(). Maybe Jens can confirm your observation.
Anyway it doesn't explain the reason behind the regression
introduced by commit 3979ef4dcf
Maurizio
as it indicates
something that is not addressed by the mid layer.
This patch replaces Unhandled error code with Extended error description
not available.
Signed-off-by: Maurizio Lombardi mlomb...@redhat.com
---
drivers/scsi/scsi_lib.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
Hi,
On Mon, May 26, 2014 at 09:25:06AM -0700, Christoph Hellwig wrote:
On Mon, May 26, 2014 at 12:13:24PM +0200, Maurizio Lombardi wrote:
During IO with fabric faults, one generally sees several Unhandled error
code messages in the syslog as shown below:
sd 4:0:6:2: [sdbw] Unhandled
version
of the patch (http://www.spinics.net/lists/linux-scsi/msg73984.html)?
We could proceed to rewrite the functions later.
Thanks,
Maurizio Lombardi
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info
not make use of scsi_execute():
http://www.spinics.net/lists/linux-scsi/msg73984.html
Maurizio Lombardi
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
the previous number of segments but left
the BIO_SEG_FLAG set.
To avoid problems, after the page is removed from the bio vec,
V3 performs a recount of the segments in the error code path.
Signed-off-by: Maurizio Lombardi mlomb...@redhat.com
---
fs/bio.c | 48
in case blk_execute_rq() returns an error.
Maurizio Lombardi
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
can be easily reproduced with the st driver:
1) set CONFIG_SCSI_MPT2SAS_MAX_SGE or CONFIG_SCSI_MPT3SAS_MAX_SGE to 16
2) modprobe st buffer_kbs=1024
3) #dd if=/dev/zero of=/dev/st0 bs=1M count=10
dd: error writing ‘/dev/st0’: Device or resource busy
Signed-off-by: Maurizio Lombardi mlomb
can be easily reproduced with the st driver:
1) set CONFIG_SCSI_MPT2SAS_MAX_SGE or CONFIG_SCSI_MPT3SAS_MAX_SGE to 16
2) modprobe st buffer_kbs=1024
3) #dd if=/dev/zero of=/dev/st0 bs=1M count=10
dd: error writing ‘/dev/st0’: Device or resource busy
Signed-off-by: Maurizio Lombardi mlomb
Sorry I did a mistake in this patch: on failure I should restore the original
value
of bi_phys_segments.
I'm going to send a new version.
Maurizio Lombardi
On Tue, Apr 29, 2014 at 04:58:18PM +0200, Maurizio Lombardi wrote:
The original behaviour is to refuse to add a new page if the maximum
to that.
Yes I think you are right, I'm trying to write a patch to get rid of all
this duplicated code.
I'll publish a patchset next week.
Thanks,
Maurizio Lombardi
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo
Signed-off-by: Maurizio Lombardi mlomb...@redhat.com
---
drivers/scsi/device_handler/scsi_dh_alua.c | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/drivers/scsi/device_handler/scsi_dh_alua.c
b/drivers/scsi/device_handler/scsi_dh_alua.c
index 5248c88
In case of error, the bnx2fc_allocate_hash_table() didn't free
all the memory it allocated.
Signed-off-by: Maurizio Lombardi mlomb...@redhat.com
---
drivers/scsi/bnx2fc/bnx2fc_hwi.c | 31 +++
1 file changed, 19 insertions(+), 12 deletions(-)
diff --git a/drivers/scsi
hash_table_size is not used by the bnx2fc_free_hash_table() function.
Signed-off-by: Maurizio Lombardi mlomb...@redhat.com
---
drivers/scsi/bnx2fc/bnx2fc_hwi.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/scsi/bnx2fc/bnx2fc_hwi.c b/drivers/scsi/bnx2fc/bnx2fc_hwi.c
index 46a3765
-by: Maurizio Lombardi mlomb...@redhat.com
---
drivers/scsi/bnx2fc/bnx2fc_hwi.c | 34 --
1 file changed, 20 insertions(+), 14 deletions(-)
diff --git a/drivers/scsi/bnx2fc/bnx2fc_hwi.c b/drivers/scsi/bnx2fc/bnx2fc_hwi.c
index 261af2a..f83bae4 100644
--- a/drivers/scsi
in the bnx2fc_allocate_hash_table() function.
Maurizio Lombardi (3):
bnx2fc: remove unused variable hash_table_size
bnx2fc: fix memory leak and potential NULL pointer dereference.
bnx2fc: fix memory leak in bnx2fc_allocate_hash_table()
drivers/scsi/bnx2fc/bnx2fc_hwi.c | 64
The scsi_get_command() function returns NULL if
it fails to allocate the scsi_cmnd structure.
If this happens, a NULL pointer will be dereferenced.
Signed-off-by: Maurizio Lombardi mlomb...@redhat.com
---
drivers/scsi/scsi_error.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers
On Tue, Mar 25, 2014 at 06:13:06AM -0700, Christoph Hellwig wrote:
diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c
index 78b004d..4021849 100644
--- a/drivers/scsi/scsi_error.c
+++ b/drivers/scsi/scsi_error.c
@@ -2289,6 +2289,9 @@ scsi_reset_provider(struct scsi_device
in the
bnx2fc_free_hash_table() function
that may happen if bnx2fc_allocate_hash_table() fails.
PATCH 3/3 fixes a memory leak in the bnx2fc_allocate_hash_table() function.
Maurizio Lombardi (3):
bnx2fc: remove unused variable hash_table_size
bnx2fc: fix memory leak and potential NULL pointer
In case of error, the bnx2fc_allocate_hash_table() didn't free
all the memory it allocated.
Signed-off-by: Maurizio Lombardi mlomb...@redhat.com
---
drivers/scsi/bnx2fc/bnx2fc_hwi.c | 31 +++
1 file changed, 19 insertions(+), 12 deletions(-)
diff --git a/drivers/scsi
hash_table_size is not used by the bnx2fc_free_hash_table() function.
Signed-off-by: Maurizio Lombardi mlomb...@redhat.com
---
drivers/scsi/bnx2fc/bnx2fc_hwi.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/scsi/bnx2fc/bnx2fc_hwi.c b/drivers/scsi/bnx2fc/bnx2fc_hwi.c
index 46a3765
-by: Maurizio Lombardi mlomb...@redhat.com
---
drivers/scsi/bnx2fc/bnx2fc_hwi.c | 34 --
1 file changed, 20 insertions(+), 14 deletions(-)
diff --git a/drivers/scsi/bnx2fc/bnx2fc_hwi.c b/drivers/scsi/bnx2fc/bnx2fc_hwi.c
index 261af2a..f83bae4 100644
--- a/drivers/scsi
1 - 100 of 108 matches
Mail list logo