Re: [PATCH 15/22] arch: vdso: consolidate gettime prototypes

2023-11-24 Thread Mark Brown
On Wed, Nov 08, 2023 at 01:58:36PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > The VDSO functions are defined as globals in the kernel sources but intended > to be called from userspace, so there is no need to declare them in a kernel > side header. This is in -next as commit

Re: [PATCH v9 01/42] mm: Rename arch pte_mkwrite()'s to pte_mkwrite_novma()

2023-07-17 Thread Mark Brown
On Mon, Jul 17, 2023 at 03:55:50PM +, Edgecombe, Rick P wrote: > On Fri, 2023-07-14 at 23:57 +0100, Mark Brown wrote: > > The same issue seems to apply with the version that was in -next > > based > > on v6.4-rc4 too. > The version in your branch is not the same as t

Re: [PATCH v9 01/42] mm: Rename arch pte_mkwrite()'s to pte_mkwrite_novma()

2023-07-14 Thread Mark Brown
On Mon, Jun 12, 2023 at 05:10:27PM -0700, Rick Edgecombe wrote: > The x86 Shadow stack feature includes a new type of memory called shadow > stack. This shadow stack memory has some unusual properties, which requires > some core mm changes to function properly. This seems to break

Re: [PATCH mm-unstable v1 04/26] arm/mm: support __HAVE_ARCH_PTE_SWP_EXCLUSIVE

2023-02-08 Thread Mark Brown
On Wed, Feb 08, 2023 at 03:12:06PM +0100, David Hildenbrand wrote: > On 07.02.23 01:32, Mark Brown wrote: > > Today's -next (and at least back to Friday, older logs are unclear - I > > only noticed -next issues today) fails to NFS boot on an AT91SAM9G20-EK > > (

Re: [PATCH mm-unstable v1 04/26] arm/mm: support __HAVE_ARCH_PTE_SWP_EXCLUSIVE

2023-02-06 Thread Mark Brown
On Fri, Jan 13, 2023 at 06:10:04PM +0100, David Hildenbrand wrote: > Let's support __HAVE_ARCH_PTE_SWP_EXCLUSIVE by stealing one bit from the > offset. This reduces the maximum swap space per file to 64 GiB (was 128 > GiB). > > While at it drop the PTE_TYPE_FAULT from __swp_entry_to_pte() which

Re: [PATCH V12] mm/debug: Add tests validating architecture page table helpers

2020-01-28 Thread Mark Brown
On Tue, Jan 28, 2020 at 02:12:56AM -0500, Qian Cai wrote: > > On Jan 28, 2020, at 1:13 AM, Christophe Leroy > > wrote: > > ppc32 an indecent / legacy platform ? Are you kidying ? > > Powerquicc II PRO for instance is fully supported by the > > manufacturer and widely used in many small

Applied "ASoC: dwc: Add irq parameter to DOCUMENTATION" to the asoc tree

2016-06-13 Thread Mark Brown
rruptions of the I2S controller was added. Signed-off-by: Jose Abreu <joab...@synopsys.com> Acked-by: Rob Herring <r...@kernel.org> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Mark Brown <broo...@kernel.org> Cc: Liam Girdwood <lgirdw...@gmail.com> Cc: Jaroslav Kysel

Applied "ASoC: dwc: Add PIO PCM extension" to the asoc tree

2016-06-13 Thread Mark Brown
reu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Mark Brown <broo...@kernel.org> Cc: Liam Girdwood <lgirdw...@gmail.com> Cc: Jaroslav Kysela <pe...@perex.cz> Cc: Takashi Iwai <ti...@suse.com> Cc: Rob Herring <r...@kernel.org> Cc: Al

Re: [PATCH 1/2 v8] ASoC: dwc: Add PIO PCM extension

2016-06-07 Thread Mark Brown
On Mon, May 30, 2016 at 10:53:15AM +0100, Jose Abreu wrote: A few small things but this looks basically fine. > + if (isr[i] & 0x33) > + irq_valid = true; This checks for a mask of 0x33 but... > + > + /* > + * Check if TX fifo is empty.

Re: [PATCH 3/4 v7] ASoC: dwc: Add PIO PCM extension

2016-05-25 Thread Mark Brown
On Wed, May 25, 2016 at 11:49:12AM +0100, Jose Abreu wrote: > Ok, will do that. I noticed the last I2S patch that you merged > ("ASoC: dwc: Add helper functions to disable/enable irqs") is not > in for-next yet. Should I base my work on 'topic/dwc' branch? We are in the merge window. No new

Re: [PATCH 3/4 v7] ASoC: dwc: Add PIO PCM extension

2016-05-24 Thread Mark Brown
On Tue, May 24, 2016 at 06:07:14PM +0100, Jose Abreu wrote: > On 24-05-2016 17:41, Mark Brown wrote: Please fix your mail client to word wrap within paragraphs at something substantially less than 80 columns. Doing this makes your messages much easier to read and reply to. > >>i

Re: [PATCH 2/4 v7] ASoC: dwc: Do not use devm_clk_get() if using platform data

2016-05-23 Thread Mark Brown
On Mon, May 23, 2016 at 11:02:23AM +0100, Jose Abreu wrote: > When using platform data the devm_clk_get() function is > called causing a probe failure if the clock is not > declared. As we can pass the clock handler by platform > data call only devm_clk_get() when platform data is not > used.

Re: [PATCH 1/2 v6] ASoC: dwc: Add custom PCM driver

2016-05-04 Thread Mark Brown
On Wed, Apr 27, 2016 at 11:05:19AM +0100, Jose Abreu wrote: > + for (i = 0; i < 4; i++) > + isr[i] = i2s_read_reg(dev->i2s_base, ISR(i)); > + > + i2s_clear_irqs(dev, SNDRV_PCM_STREAM_PLAYBACK); > + i2s_clear_irqs(dev, SNDRV_PCM_STREAM_CAPTURE); > + > + if

Re: [PATCH 2/2 v6] ASoC: dwc: Update DOCUMENTATION for I2S Driver

2016-05-04 Thread Mark Brown
On Wed, Apr 27, 2016 at 06:37:47PM +0100, Jose Abreu wrote: > This patch updates documentation for the Designware I2S > driver. Why is the DOCUMENTATION being updated and why are we shouting about it? You need to describe what the change does so that it's possible to review if the change is doing

Re: [PATCH 1/2 v6] ASoC: dwc: Add custom PCM driver

2016-04-29 Thread Mark Brown
On Fri, Apr 29, 2016 at 10:02:59AM +0100, Jose Abreu wrote: > Hi Mark, > > Can you give me some comments regarding this patch? Am I following the right > track? This is the first time that I am using ALSA SoC so pardon me if I am > making some mistake. I would appreciate some kind of input. I

Re: [PATCH 2/2 v6] ASoC: dwc: Update DOCUMENTATION for I2S Driver

2016-04-27 Thread Mark Brown
On Wed, Apr 27, 2016 at 06:32:42PM +0100, Jose Abreu wrote: > Hi Mark, > > Sorry. Follows bellow. > > On 27-04-2016 11:05, Jose Abreu wrote: I can't apply a quote of a patch, please resend. signature.asc Description: PGP signature ___ linux-snps-arc

Applied "ASoC: dwc: Use fifo depth to program FCR" to the asoc tree

2016-04-07 Thread Mark Brown
ifo depth value to program the fifo configuration register instead of using hardcoded values. Signed-off-by: Jose Abreu <joab...@synopsys.com> Signed-off-by: Mark Brown <broo...@kernel.org> --- sound/soc/dwc/designware_i2s.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-

Re: [PATCH 5/5 v4] ASoC: dwc: Update DOCUMENTATION for I2S Driver

2016-04-07 Thread Mark Brown
On Thu, Apr 07, 2016 at 05:53:59PM +0100, Jose Abreu wrote: > + Optional properties: > + - snps,use-dmaengine: If set the driver will use ALSA DMA engine. If set > + it is required to use the properties 'dmas' and 'dma-names'. This is not a good interface, it's describing Linux internal APIs.

Re: [PATCH 2/3 v2] ASoC: dwc: Add I2S HDMI audio support

2016-03-29 Thread Mark Brown
On Tue, Mar 29, 2016 at 07:03:01PM +0100, Jose Abreu wrote: > The major part of this patch is the adding of an ALSA platform driver so that > audio comes out of the box in AXS boards but we also added functionalities to > the i2s driver and performed one bug fix related with the mask/unmask of >

Re: [PATCH 2/3 v2] ASoC: dwc: Add I2S HDMI audio support

2016-03-29 Thread Mark Brown
On Mon, Mar 28, 2016 at 03:36:10PM +0100, Jose Abreu wrote: > HDMI audio support was added to the AXS board using an > I2S cpu driver and a custom platform driver. > > The platform driver supports two channels @ 16 bits with > rates 32k, 44.1k and 48k. ALSA Simple audio card is used to > glue the

Re: [PATCH 0/3 v2] Add I2S/ADV7511 audio support for ARC AXS10x boards

2016-03-29 Thread Mark Brown
On Mon, Mar 28, 2016 at 03:36:08PM +0100, Jose Abreu wrote: > ARC AXS10x platforms consist of a mainboard with several peripherals. > One of those peripherals is an HDMI output port controlled by the ADV7511 > transmitter. I'm going to tell you the same thing I tell everyone else working on HDMI