Looks like there might be an infinite number of these devices. Should
we continue to add them one by one, or would it be better to create a
Huawei vendor rule and additionally test the number of endpoints to
avoid any RNDIS devices? All the ACM like serial functions I've seen so
far have only 2
Hi,
On Tue, Feb 26, 2013 at 01:04:50PM +0800, Soar Hung wrote:
Hi all, thanks for your help.
I just ran 10K resets with each of 3 different devices (USB3
HDD, USB2 pendrive and a mouse) and I didn't see the problem you're
saying here.
Tested with TUSB7340EVM on v3.8.0.
Maybe I
Hi folks,
sorry fort he patch bomb, but I have been busy lately and I pretty
much forgot which patches I had already sent and which needed to be
sent again, so I'm sending everything I have already which *will be*
queued for v3.10 merge window.
Please go over the patches and scream if you see
We don't need to register that device ourselves
if we simply set gadget-register_my_device.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/dwc3/gadget.c | 17 ++---
1 file changed, 2 insertions(+), 15 deletions(-)
diff --git a/drivers/usb/dwc3/gadget.c
By simply setting a flag, we can delete a little
boilerplate code.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/musb/musb_gadget.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/usb/musb/musb_gadget.c b/drivers/usb/musb/musb_gadget.c
index
By simply setting a flag, we drop some boilerplate
code.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/gadget/omap_udc.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/gadget/omap_udc.c b/drivers/usb/gadget/omap_udc.c
index
By simply setting a flag, we can drop some
boilerplate code.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/gadget/atmel_usba_udc.c | 13 +
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/drivers/usb/gadget/atmel_usba_udc.c
By simply setting a flag, we can drop some
boilerplate code.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/gadget/bcm63xx_udc.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/usb/gadget/bcm63xx_udc.c b/drivers/usb/gadget/bcm63xx_udc.c
index
By simply setting a flag, we can drop some
boilerplate code.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/gadget/fsl_qe_udc.c | 15 ++-
1 file changed, 2 insertions(+), 13 deletions(-)
diff --git a/drivers/usb/gadget/fsl_qe_udc.c b/drivers/usb/gadget/fsl_qe_udc.c
index
By simply setting a flag, we can drop some
boilerplate code.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/gadget/dummy_hcd.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/usb/gadget/dummy_hcd.c b/drivers/usb/gadget/dummy_hcd.c
index
By simply setting a flag, we can drop some
boilerplate code.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/gadget/lpc32xx_udc.c | 11 +--
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/usb/gadget/lpc32xx_udc.c b/drivers/usb/gadget/lpc32xx_udc.c
index
By simply setting a flag, we can drop some
boilerplate code.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/gadget/mv_u3d_core.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/usb/gadget/mv_u3d_core.c b/drivers/usb/gadget/mv_u3d_core.c
index
Fix the following compile warning:
mv_u3d_core.c:1766:12: warning: 'mv_u3d_remove' \
defined but not used [-Wunused-function]
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/gadget/mv_u3d_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
By simply setting a flag, we can drop some
boilerplate code.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/gadget/mv_udc_core.c | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/drivers/usb/gadget/mv_udc_core.c b/drivers/usb/gadget/mv_udc_core.c
index
By simply setting a flag, we can drop some
boilerplate code.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/gadget/pch_udc.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/usb/gadget/pch_udc.c b/drivers/usb/gadget/pch_udc.c
index a787a8e..7032145
By simply setting a flag, we can drop some
boilerplate code.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/gadget/s3c-hsudc.c | 11 +--
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/usb/gadget/s3c-hsudc.c b/drivers/usb/gadget/s3c-hsudc.c
index
By simply setting a flag, we can drop some
boilerplate code.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/gadget/s3c2410_udc.c | 12 +---
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/usb/gadget/s3c2410_udc.c b/drivers/usb/gadget/s3c2410_udc.c
index
By simply setting a flag, we can drop some
boilerplate code.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/gadget/pxa25x_udc.c | 12 +---
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/usb/gadget/pxa25x_udc.c b/drivers/usb/gadget/pxa25x_udc.c
index
we have generic implementations for a reason,
let's use them.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/gadget/s3c-hsotg.c | 46 +-
1 file changed, 5 insertions(+), 41 deletions(-)
diff --git a/drivers/usb/gadget/s3c-hsotg.c
we have generic implementations for a reason,
let's use them
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/gadget/lpc32xx_udc.c | 39 ---
1 file changed, 4 insertions(+), 35 deletions(-)
diff --git a/drivers/usb/gadget/lpc32xx_udc.c
we have generic implementations for a reason,
let's use them
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/gadget/mv_udc_core.c | 53 +---
1 file changed, 6 insertions(+), 47 deletions(-)
diff --git a/drivers/usb/gadget/mv_udc_core.c
Make the call to dwc3_event_buffers_setup()
and dwc3_event_buffers_cleanup() explicit,
so it's easier to implement PM.
Tested-by: Vivek Gautam gautam.vi...@samsung.com
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/dwc3/core.c | 32 +---
1 file changed, 17
we don't need to enable IRQs until we have
a gadget driver loaded and ready to work,
so let's delay IRQ enable to -udc_start()
and IRQ disable to -udc_stop().
While at that, also move the related use of
request_irq() and free_irq().
Tested-by: Vivek Gautam gautam.vi...@samsung.com
Signed-off-by:
we have generic implementations for a reason,
let's use them
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/musb/musb_gadget.c | 158 ++---
1 file changed, 53 insertions(+), 105 deletions(-)
diff --git a/drivers/usb/musb/musb_gadget.c
On Sun, Feb 17, 2013 at 05:24:34PM +0800, Peter Chen wrote:
Hi Alex,
Ping
Changes for v9:
- Some small comments from Alex like: variable comment for otg event
additional newline. [3/9]
- Import function tell show if the controller has otg capable, if
the controller supports
Add support for basic power management on
the dwc3 driver. While there is still lots
to improve for full PM support, this minimal
patch will already make sure that we survive
suspend-to-ram and suspend-to-disk without
major issues.
Cc: Vikas C Sajjan vikas.saj...@linaro.org
Tested-by: Vivek
this patch adds basic PM support for the
PCI glue layer.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/dwc3/dwc3-pci.c | 38 ++
1 file changed, 38 insertions(+)
diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c
index
OMAP5 won't support non-DT boot, so instead of:
if (node)
foo();
return 0;
which returns zero even on non-DT boot, we have
to bail out early if node isn't a valid pointer:
if (!node)
return -ENODEV;
foo();
return 0;
Signed-off-by: Felipe Balbi ba...@ti.com
---
From: Vikas Sajjan vikas.saj...@linaro.org
Adds suspend and resume callbacks to exynos dwc3 driver as part of
power management support.
This change does gating of dwc3 clock during suspend/resume cycles.
Signed-off-by: Abhilash Kesavan a.kesa...@samsung.com
Signed-off-by: Vikas C Sajjan
Those comments haven't been updated for a long
time, so much that they don't make sense anymore.
Best to remove them.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/musb/musb_gadget.c | 108 -
1 file changed, 108 deletions(-)
diff --git
those two glues are still including mach/
headers and no active developement has been
going on those glues for quite some time.
Apparently, for da8xx glue, only initial commit
3ee076de (usb: musb: introduce DA8xx/OMAP-L1x
glue layer) has been tested. All other patches
seem to have been
linux/sizes.h is the header defining SZ_4
and SZ_16M, we shouldn't depend on indirect
inclusion so let's explicitly include it.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/musb/musb_dsps.c | 1 +
drivers/usb/musb/ux500_dma.c | 1 +
2 files changed, 2 insertions(+)
diff --git
if CONFIG_OF is disabled, np will be unused
and that will give us a compile warning. This
patch just avoids it.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/musb/musb_dsps.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/usb/musb/musb_dsps.c
Fix the following compile warning:
drivers/usb/musb/musb_gadget.c: In function ‘rxstate’:
drivers/usb/musb/musb_gadget.c:714:22: warning: comparison of distinct pointer
types lacks a cast [enabled by default]
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/musb/musb_gadget.c | 13
those glues can build cleanly anywhere.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/musb/Kconfig | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig
index 0f1d3e0..f55d1fc 100644
--- a/drivers/usb/musb/Kconfig
+++
that irq field has been removed already. This
patch just removes its documentation.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/dwc3/core.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
index 52e48e2..80f763f 100644
---
that way we know if a particular event buffer
has pending events, or not.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/dwc3/core.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
index 80f763f..e7b0679 100644
---
we can cache the last read value of the event
buffer count register on this field, for later
handling.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/dwc3/core.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
index
by moving to threaded IRQs, we allow our IRQ
priorities to be configurable when running with
realtime patch. Also, since we're running in
thread context, we can call functions which
might sleep, such as sysfs_notify() without
problems.
Signed-off-by: Felipe Balbi ba...@ti.com
---
this function will receive enum usb_device_state
and return a human-readable string from it or,
case an unknown value is passed as argument,
the string UNKNOWN.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/usb-common.c | 21 +
include/linux/usb/ch9.h | 9
commit 3921426 (usb: dwc3: core: move
event buffer allocation out of
dwc3_core_init()) introduced a memory leak
of the coherent memory we use as event
buffers on dwc3 driver.
If the driver is compiled as a dynamically
loadable module and use constantly loads
and unloads the driver, we will
We can reuse the generic implementation via
our struct usb_gadget.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/dwc3/core.h | 7 ---
drivers/usb/dwc3/ep0.c | 34 +-
2 files changed, 17 insertions(+), 24 deletions(-)
diff --git
for Reset and Resume we were going to print
UNKNOWN when we actually knew what those
were.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/dwc3/debugfs.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/usb/dwc3/debugfs.c b/drivers/usb/dwc3/debugfs.c
index
Whenever -udc_start() gets called, gadget driver
has already being bound to the udc controller, which
means that gadget-dev had to be already initialized
and added to driver model.
This patch fixes pxa27x mistake.
Tested-by: Robert Jarzmik robert.jarz...@free.fr
Signed-off-by: Felipe Balbi
nobody should be modifying that structure and
debugfs has already being fixed to take const
arguments, so we won't cause any new compile
warnings.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/dwc3/debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
whenever we grab an unknown link_state we
were printing the entire register value as
a integer but that's hardly useful; instead,
let's print only the bogus state value.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/dwc3/debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
add missing semicolon to fix compile breakage.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/gadget/s3c2410_udc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/s3c2410_udc.c b/drivers/usb/gadget/s3c2410_udc.c
index 9404858..08f8965 100644
---
trivial patch to avoid over 80-chars rule
break. No functional changes.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/dwc3/core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index 75a9f88..b81b335 100644
---
udc-core now sets dma-related and parent fields
for us, we don't need to do it ourselves.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/gadget/atmel_usba_udc.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/usb/gadget/atmel_usba_udc.c
udc-core nos sets dma-related and parent fields
for us, we don't need to do it ourselves.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/gadget/fusb300_udc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/gadget/fusb300_udc.c b/drivers/usb/gadget/fusb300_udc.c
index
udc-core now sets dma-related and parent fields
for us, we don't need to do it ourselves.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/gadget/goku_udc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/gadget/goku_udc.c b/drivers/usb/gadget/goku_udc.c
index
udc-core now sets dma-related and parent fields
for us, we don't need to do it ourselves.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/dwc3/gadget.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index 6e168df..0e05485
udc-core now sets dma-related and parent fields
for us, we don't need to do it ourselves.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/gadget/net2272.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/gadget/net2272.c b/drivers/usb/gadget/net2272.c
index
udc-core now sets dma-related and parent fields
for us, we don't need to do it ourselves.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/gadget/net2280.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/gadget/net2280.c b/drivers/usb/gadget/net2280.c
index
udc-core now sets dma-related and parent fields
for us, we don't need to do it ourselves.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/gadget/omap_udc.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/usb/gadget/omap_udc.c b/drivers/usb/gadget/omap_udc.c
index
udc-core now sets dma-related and parent fields
for us, we don't need to do it ourselves.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/gadget/pxa25x_udc.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/usb/gadget/pxa25x_udc.c b/drivers/usb/gadget/pxa25x_udc.c
index
udc-core now sets dma-related and parent fields
for us, we don't need to do it ourselves.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/gadget/pxa27x_udc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/gadget/pxa27x_udc.c b/drivers/usb/gadget/pxa27x_udc.c
index
udc-core now sets dma-related and parent fields
for us, we don't need to do it ourselves.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/gadget/s3c2410_udc.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/usb/gadget/s3c2410_udc.c b/drivers/usb/gadget/s3c2410_udc.c
index
udc-core now sets dma-related and parent fields
for us, we don't need to do it ourselves.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/musb/musb_gadget.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/musb/musb_gadget.c b/drivers/usb/musb/musb_gadget.c
index
udc-core now sets dma-related and parent fields
for us, we don't need to do it ourselves.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/gadget/mv_udc_core.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/gadget/mv_udc_core.c b/drivers/usb/gadget/mv_udc_core.c
index
udc-core now sets dma-related and parent fields
for us, we don't need to do it ourselves.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/gadget/pch_udc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/gadget/pch_udc.c b/drivers/usb/gadget/pch_udc.c
index
udc-core now sets dma-related and parent fields
for us, we don't need to do it ourselves.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/gadget/s3c-hsotg.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget/s3c-hsotg.c
index
udc-core now sets dma-related and parent fields
for us, we don't need to do it ourselves.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/gadget/r8a66597-udc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/gadget/r8a66597-udc.c
b/drivers/usb/gadget/r8a66597-udc.c
udc-core now sets dma-related and parent fields
for us, we don't need to do it ourselves.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/gadget/s3c-hsudc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/gadget/s3c-hsudc.c b/drivers/usb/gadget/s3c-hsudc.c
index
DMA_ADDR_INVALID isn't used anymore on goku_udc,
we can just delete it.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/gadget/goku_udc.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/usb/gadget/goku_udc.c b/drivers/usb/gadget/goku_udc.c
index c02cbdd..1c070f4 100644
---
udc-core now sets dma-related and parent fields
for us, we don't need to do it ourselves.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/gadget/mv_u3d_core.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/gadget/mv_u3d_core.c b/drivers/usb/gadget/mv_u3d_core.c
index
udc-core now sets dma-related and parent fields
for us, we don't need to do it ourselves.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/gadget/amd5536udc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/gadget/amd5536udc.c b/drivers/usb/gadget/amd5536udc.c
index
udc-core now sets dma-related and parent fields
for us, we don't need to do it ourselves.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/gadget/imx_udc.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/usb/gadget/imx_udc.c b/drivers/usb/gadget/imx_udc.c
index
udc-core now sets dma-related and parent fields
for us, we don't need to do it ourselves.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/gadget/m66592-udc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/gadget/m66592-udc.c b/drivers/usb/gadget/m66592-udc.c
index
udc-core now sets dma-related and parent fields
for us, we don't need to do it ourselves.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/chipidea/udc.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c
index 1b65ac8..e303fd4
This driver can compile in any arch quite
easily by just removing a few headers and
dropping cpu_is_* check from module_init.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/gadget/Kconfig | 1 -
drivers/usb/gadget/pxa27x_udc.c | 11 ++-
2 files changed, 2 insertions(+),
just removing some boilerplate code.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/gadget/pxa27x_udc.c | 15 +++
1 file changed, 3 insertions(+), 12 deletions(-)
diff --git a/drivers/usb/gadget/pxa27x_udc.c b/drivers/usb/gadget/pxa27x_udc.c
index def73f2..3276a6d 100644
if udc-core always does it, we can delete
some extra lines from all UDC drivers. Besides,
it avoids mistakes from happening and propagating.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/gadget/udc-core.c | 1 +
1 file changed, 1 insertion(+)
diff --git
gadget's device pointer now is guaranteed to
have valid dma_mask, dma_parms and coherent_dma_mask
fields since we're always copying from our
parent device.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/gadget/udc-core.c | 4
1 file changed, 4 insertions(+)
diff --git
From: Kishon Vijay Abraham I kis...@ti.com
The current ordering in makefile makes gadget
drivers be loaded before usb functions which
causes usb_get_function_instance() to fail when
gadget modules are statically linked to the
kernel binary.
Changed the ordering here so that USB functions
are
Whenever -udc_start() gets called, gadget driver
has already being bound to the udc controller, which
means that gadget-dev had to be already initialized
and added to driver model.
This patch fixes pxa25x mistake.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/gadget/pxa25x_udc.c | 20
when commit 388e5c5 (usb: dwc3: remove dwc3
dependency on host AND gadget.) changed the
way debugfs files are created, it failed to
note that 'mode' is necessary in Dual Role
mode only while 'testmode' and 'link_state'
are valid in Dual Role and Peripheral-only
builds. Fix this while also
Whenever -udc_start() gets called, gadget driver
has already being bound to the udc controller, which
means that gadget-dev had to be already initialized
and added to driver model.
This patch fixes s3c2410 mistake.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/gadget/s3c2410_udc.c |
Don't register anything non-generic under
the gadget's device as we don't really *own*
it.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/chipidea/udc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c
s/matach/match
No functional changes
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/dwc3/dwc3-omap.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c
index 22f337f..90171f7 100644
---
the params variables on dwc3_gadget_conndone_interrupt()
is only memset() to zero but never used in
that function, so we can safely drop the variable
and memset() call.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/dwc3/gadget.c | 3 ---
1 file changed, 3 deletions(-)
diff --git
remove inclusion of core.h from all glue
layers as they don't need to know details
about the core IP.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/dwc3/dwc3-exynos.c | 2 --
drivers/usb/dwc3/dwc3-omap.c | 2 --
drivers/usb/dwc3/dwc3-pci.c| 2 --
3 files changed, 6 deletions(-)
that's useful information to expose to userland.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/gadget/udc-core.c | 23 +++
include/linux/usb/gadget.h| 9 +
2 files changed, 32 insertions(+)
diff --git a/drivers/usb/gadget/udc-core.c
Hi all,
here are the fixes I plan to send when v3.9-rc1. There's
still time to change things as the merge window hasn't
closed, so please test and let me know.
cheers
Felipe Balbi (10):
usb: dwc3: core: don't forget to free coherent memory
usb: dwc3: omap: fix a typo on of_device_id
usb:
There was a possibility that we would leak
two nop-xceiv platform_devices, leave pm runtime
counter incremented (unbalanced), leave
pm_runtime_enable()'d and IRQs unmasked.
Fix all of those in one go.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/dwc3/dwc3-omap.c | 27
there's really no need for that message. It's
been a while since it printed something useful.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/musb/musb_core.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
index
MUSB still needs lots of work on the DMA part
if we want to enable multiple DMA engines on
a multiplatform kernel. Meanwhile, we're forcing
PIO-only so that we, at least, have a working
driver.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/musb/Kconfig | 1 +
1 file changed, 1
this patch implements basic suspend/resume
functionality for the OMAP glue layer.
Tested-by: Vivek Gautam gautam.vi...@samsung.com
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/dwc3/dwc3-omap.c | 56
1 file changed, 56 insertions(+)
diff
they will be re-used on suspend/resume implementation.
Tested-by: Vivek Gautam gautam.vi...@samsung.com
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/dwc3/dwc3-omap.c | 45 +---
1 file changed, 30 insertions(+), 15 deletions(-)
diff --git
this will make sure that request_memory_region() will
be called and that we don't need to manually call
iounmap() on -remove().
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/musb/musb_core.c | 11 ++-
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git
we're not using those fields of the structure,
might as well remove them.
Tested-by: Vivek Gautam gautam.vi...@samsung.com
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/dwc3/dwc3-omap.c | 12
1 file changed, 12 deletions(-)
diff --git a/drivers/usb/dwc3/dwc3-omap.c
This will be used during resume to verify
if we should reconnect our pullups or not.
Tested-by: Vivek Gautam gautam.vi...@samsung.com
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/dwc3/core.h | 1 +
drivers/usb/dwc3/gadget.c | 2 ++
2 files changed, 3 insertions(+)
diff --git
we have generic implementations for a reason,
let's use them
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/gadget/fusb300_udc.c | 17 +++--
1 file changed, 7 insertions(+), 10 deletions(-)
diff --git a/drivers/usb/gadget/fusb300_udc.c b/drivers/usb/gadget/fusb300_udc.c
By simply setting a flag, we can drop some
boilerplate code.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/gadget/pxa27x_udc.c | 12 +---
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/usb/gadget/pxa27x_udc.c b/drivers/usb/gadget/pxa27x_udc.c
index
By simply setting a flag, we can drop some
boilerplate code.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/renesas_usbhs/mod_gadget.c | 11 ++-
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/drivers/usb/renesas_usbhs/mod_gadget.c
we have generic implementations for a reason,
let's use them
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/gadget/fsl_udc_core.c | 51 ++-
1 file changed, 13 insertions(+), 38 deletions(-)
diff --git a/drivers/usb/gadget/fsl_udc_core.c
We don't need the -register_my_device flag
anymore because all UDC drivers have been
properly converted.
Let's remove every history of it.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/chipidea/udc.c | 1 -
drivers/usb/dwc3/gadget.c | 1 -
By simply setting a flag, we can drop some
boilerplate code.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/chipidea/udc.c | 13 ++---
1 file changed, 2 insertions(+), 11 deletions(-)
diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c
index f64fbea..e95e8bb
By simply setting a flag, we can drop some
boilerplate code.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/gadget/r8a66597-udc.c | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/drivers/usb/gadget/r8a66597-udc.c
b/drivers/usb/gadget/r8a66597-udc.c
By simply setting a flag, we can drop some
boilerplate code.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/gadget/s3c-hsotg.c | 14 +-
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget/s3c-hsotg.c
index
1 - 100 of 363 matches
Mail list logo