Re: [PATCH] usb: dwc3: fix EP_BUSY in case of dequeue

2013-03-01 Thread Pratyush Anand
On 3/1/2013 12:10 PM, Felipe Balbi wrote: Hi, [...] dep-flags = ~DWC3_EP_BUSY; ^ and here udelay(100); } ?? Ohhh.. I missed this patch in my repo.. usb: dwc3: gadget: fix 'endpoint always busy' bug -- To unsubscribe from this list: send the

[PATCH] usb: correctly enable interrupts for xhci

2013-03-01 Thread Hannes Reinecke
xhci might run with MSI/MSI-X only, with no support for legacy interrupts. On these devices the request_irq() call in usb_add_hcd() will fail, causing the entire device to fail. For xhci this is especially painful as the driver will enable interrupts during xhci_run(), so the initial call to

Re: [PATCH] usb: correctly enable interrupts for xhci

2013-03-01 Thread David Härdeman
On Fri, Mar 01, 2013 at 09:52:54AM +0100, Hannes Reinecke wrote: xhci might run with MSI/MSI-X only, with no support for legacy interrupts. On these devices the request_irq() call in usb_add_hcd() will fail, causing the entire device to fail. For xhci this is especially painful as the driver will

[PATCH 0/5] usb: chipidea: udc: fixes, iso ep and multi td support

2013-03-01 Thread Michael Grzeschik
Hi, this series includes support to manage the transfer descriptors with an linked list to manage a dynamic amount of data being enqueued in hardware. It also addresses the isochronous support for the chipidea udc and removes not needed lock state juggling. The series applies on current

[PATCH 5/5] usb: chipidea: udc: add multiple td support to hardware_{en,de}queue

2013-03-01 Thread Michael Grzeschik
This patch removes the limitation of having a limited amount of only four active tds on one endpoint. We use the linked list implementation to manage all tds which get added and removed by hardware_{en,de}queue. Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de ---

[PATCH v2 2/5] usb: chipidea: udc: configure iso endpoints

2013-03-01 Thread Michael Grzeschik
The implementation is derived from the fsl_udc_core code in fsl_ep_enable and makes basic iso handling possible. Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de Signed-off-by: Marc Kleine-Budde m...@pengutronix.de --- Changes since v1: - fixed coding style issues mentioned by Sergei

[PATCH v2 1/5] usb: chipidea: udc: move _ep_queue into an unlocked function

2013-03-01 Thread Michael Grzeschik
There is no need to call ep_queue unlocked inside the own driver. We move its functionionality into an unlocked version. This patch removes potential unlocked timeslots inside isr_setup_status_phase and isr_get_status_response, in which the lock got released just before acquired again inside

[PATCH 4/5] usb: chipidea: udc: manage dynamic amount of tds with an linked list

2013-03-01 Thread Michael Grzeschik
Instead of having a limited number of usable tds in the udc we use a linked list to support dynamic amount of needed tds for all special gadget types. This improves throughput. This patch also adresses a possible momory leak in _ep_nuke found while porting the request handling to an linked list.

[PATCH 3/5] usb: chipidea: udc: add the define TD_COUNT and fix all users

2013-03-01 Thread Michael Grzeschik
A static count of transfer descriptors was used everywhere in the driver with the fixed number 4. This patch adds a define, named TD_COUNT, and replaces all users of this value. This way its possible to have only one parameter to change and limit the amount of tds per transfer. Signed-off-by:

Re: [PATCH] usb: correctly enable interrupts for xhci

2013-03-01 Thread Alan Stern
On Fri, 1 Mar 2013, Hannes Reinecke wrote: xhci might run with MSI/MSI-X only, with no support for legacy interrupts. On these devices the request_irq() call in usb_add_hcd() will fail, causing the entire device to fail. For xhci this is especially painful as the driver will enable

isp1760: ptd and payload data flow

2013-03-01 Thread Richard Retanubun
Hello, I am studying the isp1760-hcd code, trying to figure out the logic of the data flow going in and out of the driver. I have a few gaps in my understanding and was hoping to get help from you guys: 1. Once a PTD is schedule and its valid bit is set, what will trigger the isp1760 to scan

Re: [PATCH 0/5] usb: chipidea: udc: fixes, iso ep and multi td support

2013-03-01 Thread Steffen Trumtrar
On Fri, Mar 01, 2013 at 03:42:22PM +0100, Michael Grzeschik wrote: Hi, this series includes support to manage the transfer descriptors with an linked list to manage a dynamic amount of data being enqueued in hardware. It also addresses the isochronous support for the chipidea udc and

[PATCH 2/2] USB: EHCI: don't check DMA values in QH overlays

2013-03-01 Thread Alan Stern
This patch (as1661) fixes a rather obscure bug in ehci-hcd. In a couple of places, the driver compares the DMA address stored in a QH's overlay region with the address of a particular qTD, in order to see whether that qTD is the one currently being processed by the hardware. (If it is then the

Re: [PATCH] usb: dwc3: fix EP_BUSY in case of dequeue

2013-03-01 Thread Felipe Balbi
On Fri, Mar 01, 2013 at 01:45:06PM +0530, Pratyush Anand wrote: On 3/1/2013 12:10 PM, Felipe Balbi wrote: Hi, [...] dep-flags = ~DWC3_EP_BUSY; ^ and here udelay(100); } ?? Ohhh.. I missed this patch in my repo.. usb: dwc3: gadget: fix 'endpoint always

Re: [PATCH 0/5] usb: chipidea: udc: fixes, iso ep and multi td support

2013-03-01 Thread Fabio Estevam
Hi Steffen, On Fri, Mar 1, 2013 at 12:39 PM, Steffen Trumtrar s.trumt...@pengutronix.de wrote: This series for imx28: Tested-by: Steffen Trumtrar s.trumt...@pengutronix.de May I see your imx28-evk.dts with USB udc support, please? Thanks, Fabio Estevan -- To unsubscribe from this

Re: [regression] external HDD in USB3 enclosure cannot be dynamically removed (Re: Linux 3.7.5)

2013-03-01 Thread Greg KH
On Wed, Feb 13, 2013 at 02:12:50PM -0800, Sarah Sharp wrote: On Wed, Feb 13, 2013 at 01:31:29PM -0800, Greg KH wrote: On Wed, Feb 13, 2013 at 01:08:46PM -0800, Sarah Sharp wrote: On Wed, Feb 13, 2013 at 09:04:13PM +0100, Matthias Schniedermeyer wrote: On 13.02.2013 11:33, Sarah Sharp

Re: [PATCH 0/5] usb: chipidea: udc: fixes, iso ep and multi td support

2013-03-01 Thread Steffen Trumtrar
On Fri, Mar 01, 2013 at 01:00:16PM -0300, Fabio Estevam wrote: Hi Steffen, On Fri, Mar 1, 2013 at 12:39 PM, Steffen Trumtrar s.trumt...@pengutronix.de wrote: This series for imx28: Tested-by: Steffen Trumtrar s.trumt...@pengutronix.de May I see your imx28-evk.dts with USB

[PATCH 01/12] usb: gadget/uvc: Clarify comment about string descriptors

2013-03-01 Thread Laurent Pinchart
The comment that describes string descriptors allocation isn't clear, fix it. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/usb/gadget/f_uvc.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/usb/gadget/f_uvc.c

Re: [PATCH] drivers/usb/gadget: using strlcpy instead of strncpy

2013-03-01 Thread Laurent Pinchart
Hi Felipe, On Wednesday 27 February 2013 10:26:23 Felipe Balbi wrote: On Sat, Feb 02, 2013 at 03:48:54PM +0800, Chen Gang wrote: for NUL terminated string, better notice '\0' in the end. Signed-off-by: Chen Gang gang.c...@asianux.com Laurent, are you taking this patch or should I ?

[PATCH 03/12] usb: gadget/uvc: Fix coding style issues introduced by SS support

2013-03-01 Thread Laurent Pinchart
Let's keep the code consistent, people might want to read it. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/usb/gadget/f_uvc.c | 58 +++--- drivers/usb/gadget/f_uvc.h | 12 +- 2 files changed, 35 insertions(+), 35

[PATCH 11/12] usb: gadget/uvc: Use GFP_ATOMIC under spin lock

2013-03-01 Thread Laurent Pinchart
From: Cyril Roelandt tipec...@gmail.com Found using the following semantic patch: spml @@ @@ spin_lock_irqsave(...); ... when != spin_unlock_irqrestore(...); * GFP_KERNEL /spml Signed-off-by: Cyril Roelandt tipec...@gmail.com Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com ---

[PATCH 09/12] usb: gadget/uvc: Delay the status stage when setting alternate setting 1

2013-03-01 Thread Laurent Pinchart
From: Bhupesh Sharma bhupesh.sha...@st.com This patch adds the support in UVC webcam gadget design for providing USB_GADGET_DELAYED_STATUS in response to a set_interface(alt setting 1) command issue by the Host. The current UVC webcam gadget design generates a STREAMON event corresponding to a

[PATCH 10/12] usb: gadget/uvc: Make video streaming buffer size comply with USB3.0 SS

2013-03-01 Thread Laurent Pinchart
From: Bhupesh Sharma bhupesh.sha...@st.com As per the USB3.0 specs, the bandwidth requirements of a UVC's video streaming endpoint will change to support super-speed. These changes will be dependent on whether the UVC video streaming endpoint is Bulk or Isochronous: - If video streaming endpoint

[PATCH 06/12] usb: gadget/uvc: Configure the streaming endpoint based on the speed

2013-03-01 Thread Laurent Pinchart
Call the appropriate usb_ep_autoconf*() function depending on the device speed, and pass it the corresponding streaming endpoint. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/usb/gadget/f_uvc.c | 19 --- 1 file changed, 12 insertions(+), 7

[PATCH 05/12] usb: gadget/uvc: Merge the streaming maxpacket and mult parameters

2013-03-01 Thread Laurent Pinchart
Compute the multiplier from the maximum packet size based on the speed. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/usb/gadget/f_uvc.c | 120 ++--- 1 file changed, 60 insertions(+), 60 deletions(-) diff --git

[PATCH 02/12] usb: gadget/uvc: Rename STATUS_BYTECOUNT to UVC_STATUS_MAX_PACKET_SIZE

2013-03-01 Thread Laurent Pinchart
Descriptive names make the code more readable. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/usb/gadget/f_uvc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/usb/gadget/f_uvc.c b/drivers/usb/gadget/f_uvc.c index

Re: [PATCH resubmit] ax88179_178a: ASIX AX88179_178A USB 3.0/2.0 to gigabit ethernet adapter driver

2013-03-01 Thread David Miller
From: Freddy Xin fre...@asix.com.tw Date: Wed, 27 Feb 2013 20:01:58 +0800 + eeprom_buff = kmalloc(sizeof(u16) * (last_word - first_word + 1), + GFP_KERNEL); + if (!eeprom_buff) + return -ENOMEM; + + /* ax88179/178A returns 2 bytes from

[PATCH v2 0/2] Chipidea driver support for the AR933x platform

2013-03-01 Thread Svetoslav Neykov
Add support for the usb controller in AR933x platform. The processor is big-endian so all multi-byte values of the usb descriptors must be converted explicitly. Another difference is that the controller supports both host and device modes but not OTG. The patches are tested on WR703n router

[GIT PATCH] USB patch revert for 3.9-rc1

2013-03-01 Thread Greg KH
The following changes since commit 74e1a2a39355b2d3ae8c60c78d8add162c6d7183: Merge tag 'usb-3.9-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb (2013-02-21 12:20:00 -0800) are available in the git repository at:

Re: [PATCH 0/5] usb: musb: am335x support

2013-03-01 Thread Daniel Mack
On 01.03.2013 22:57, Daniel Mack wrote: Hi Afzal, everyone, On 03.11.2012 08:33, Mohammed, Afzal wrote: * Daniel Mack, November 03, 2012 1:06 AM: I'm testing these patches with an AM33xx board that has the first musb port wired to an USB type A plug, but it doesn't yet work for me. So