Re: [RFC PATCH 0/4] USB: HCD/EHCI: giveback of URB in tasklet context

2013-06-14 Thread Greg Kroah-Hartman
On Fri, Jun 14, 2013 at 09:53:52AM +0800, Ming Lei wrote: On Fri, Jun 14, 2013 at 8:35 AM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Thu, Jun 13, 2013 at 03:41:17PM -0400, Alan Stern wrote: On Thu, 13 Jun 2013, Greg Kroah-Hartman wrote: On Thu, Jun 13, 2013 at 10:54:13AM

Re: [RFC PATCH 1/4] arm: omap: Add phy binding info for musb in plat data

2013-06-14 Thread Tomi Valkeinen
On 14/06/13 08:47, Tony Lindgren wrote: * Kishon Vijay Abraham I kis...@ti.com [130613 22:41]: Hi, On Thursday 13 June 2013 06:35 PM, Tomi Valkeinen wrote: Hi, On 28/05/13 08:18, Kishon Vijay Abraham I wrote: Hi Tony, On Friday 17 May 2013 06:52 PM, Kishon Vijay Abraham I wrote: In

[PATCH v2] extcon: Add an API to get extcon device from dt node

2013-06-14 Thread Chanwoo Choi
From: Kishon Vijay Abraham I kis...@ti.com Added an API of_extcon_get_extcon_dev() to be used by drivers to get extcon device in the case of dt boot (this can be used instead of extcon_get_extcon_dev()). Signed-off-by: Kishon Vijay Abraham I kis...@ti.com Signed-off-by: Chanwoo Choi

Re: [RFC PATCH 1/4] arm: omap: Add phy binding info for musb in plat data

2013-06-14 Thread Tony Lindgren
* Tomi Valkeinen tomi.valkei...@ti.com [130613 23:42]: On 14/06/13 08:47, Tony Lindgren wrote: * Kishon Vijay Abraham I kis...@ti.com [130613 22:41]: Hi, On Thursday 13 June 2013 06:35 PM, Tomi Valkeinen wrote: Hi, On 28/05/13 08:18, Kishon Vijay Abraham I wrote: Hi Tony, On

Re: [RFC PATCH 1/4] arm: omap: Add phy binding info for musb in plat data

2013-06-14 Thread Tomi Valkeinen
On 14/06/13 10:33, Tony Lindgren wrote: If we want to fix something this late in the merge window, the patches must have a clear description what caused the regression and what happens without the patches. These patches don't have that. And they are marked RFC also. So actually I'm not

Re: [PATCH] MIPS: Kconfig: Select USB_EHCI_HCD if USB_SUPPORt is enabled

2013-06-14 Thread Markos Chandras
On 06/13/13 17:41, David Daney wrote: On 06/13/2013 08:42 AM, Markos Chandras wrote: Commit 94d83649e1c2f25c87dc4ead9c2ab073305 USB: remove USB_EHCI_BIG_ENDIAN_{DESC,MMIO} depends on architecture symbol caused the following regression in cavium_octeon_defconfig: warning: (MIPS_SEAD3 PMC_MSP

Re: [GIT PULL] USB patches for v3.11 merge window

2013-06-14 Thread Roger Quadros
On 06/13/2013 05:55 PM, Felipe Balbi wrote: HI, On Thu, Jun 13, 2013 at 05:53:50PM +0300, Roger Quadros wrote: On 06/13/2013 05:17 PM, Felipe Balbi wrote: Hi, On Thu, Jun 13, 2013 at 12:05:36PM +0300, Roger Quadros wrote: On 06/13/2013 01:37 AM, Greg KH wrote: On Wed, Jun 12, 2013 at

Re: [PATCH v2] extcon: Add an API to get extcon device from dt node

2013-06-14 Thread Kishon Vijay Abraham I
Hi, On Friday 14 June 2013 12:45 PM, Chanwoo Choi wrote: From: Kishon Vijay Abraham I kis...@ti.com Added an API of_extcon_get_extcon_dev() to be used by drivers to get extcon device in the case of dt boot (this can be used instead of extcon_get_extcon_dev()). Signed-off-by: Kishon Vijay

Re: [PATCH v2] extcon: Add an API to get extcon device from dt node

2013-06-14 Thread Chanwoo Choi
On 06/14/2013 05:36 PM, Kishon Vijay Abraham I wrote: Hi, On Friday 14 June 2013 12:45 PM, Chanwoo Choi wrote: From: Kishon Vijay Abraham I kis...@ti.com Added an API of_extcon_get_extcon_dev() to be used by drivers to get extcon device in the case of dt boot (this can be used instead of

Re: [PATCh V10 04/12] usb: ehci: ehci-mv: use PHY driver for ehci

2013-06-14 Thread Roger Quadros
On 06/13/2013 06:08 PM, Alan Stern wrote: On Thu, 13 Jun 2013, Chao Xie wrote: These operations sound generic enough to be done at HCD layer, no? So no need to replicate the same stuff in ohci, ehci, xhci, etc. The HCD layer handles suspend and resume only for PCI host controllers. Not

Re: Proposed modification to PL2303 driver

2013-06-14 Thread Mastro Gippo
Hi Greg, thanks for your reply. I spent some free time this week trying to compile and use the modified driver, but I'm unable to compile it, I'm not an expert in compiling linux drivers, I may reinstall a fresh linux version this weekend as I think I messed up something. BTW; I'm quite sure that

Re: [RFC PATCH 1/4] arm: omap: Add phy binding info for musb in plat data

2013-06-14 Thread Kishon Vijay Abraham I
Hi, On Friday 14 June 2013 01:47 PM, Tomi Valkeinen wrote: On 14/06/13 10:33, Tony Lindgren wrote: If we want to fix something this late in the merge window, the patches must have a clear description what caused the regression and what happens without the patches. These patches don't have

[PATCH v3 1/2] USB: PHY: Make PHY driver selection possible by controller drivers

2013-06-14 Thread Roger Quadros
Convert PHY Drivers from menuconfig to menu so that the PHY drivers can be explicitely selected by the controller drivers. USB_PHY is no longer a user visible option. It is upto to the PHY drivers to select it if needed. This patch does so for the existing PHY drivers that use the USB_PHY

[PATCH v3 2/2] USB: ehci-omap: select NOP_USB_XCEIV PHY driver

2013-06-14 Thread Roger Quadros
ehci-omap needs NOP_USB_XCEIV PHY driver to function properly, so select it. As the USB PHY drivers no longer depend on USB_PHY, it is safe to select the PHY drivers. Signed-off-by: Roger Quadros rog...@ti.com Tested-by: Adrien Vergé adrienve...@gmail.com --- drivers/usb/host/Kconfig |4 +---

[PATCH v3 0/2] USB: PHY: Improve PHY selection logic

2013-06-14 Thread Roger Quadros
Hi, Improve Kconfig so that the relevant PHY driver can be explicitely selected by the controller driver instead of relying on the user to do so. Detailed description in patch 1. v3: - Fix linking problem when CONFIG_USB is m v2: - Merge patches 3-5 into the first patch to prevent circular

xhci oops ~3.10-rc4

2013-06-14 Thread Pontus Fuchs
Hi, I recently got an oops with ~3.10-rc4. The crash happened right after I connected my android phone. I have not been able to reproduce it. PC is at ring_doorbell_for_active_rings Photo of oops: http://postimg.org/image/bhdk7xszr/ Cheers, Pontus Fuchs -- To unsubscribe from this list:

Re: [RFC PATCH 0/4] USB: HCD/EHCI: giveback of URB in tasklet context

2013-06-14 Thread Ming Lei
On Fri, Jun 14, 2013 at 2:05 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Fri, Jun 14, 2013 at 09:53:52AM +0800, Ming Lei wrote: On Fri, Jun 14, 2013 at 8:35 AM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Thu, Jun 13, 2013 at 03:41:17PM -0400, Alan Stern wrote:

Re: [PATCH 20/20] usb: chipidea: drop 13xxx infix

2013-06-14 Thread Alexander Shishkin
Peter Chen peter.c...@freescale.com writes: On Thu, Jun 13, 2013 at 06:00:04PM +0300, Alexander Shishkin wrote: ci13xxx is bad for at least the following reasons: * people often mistype it * it doesn't add any informational value to the names it's used in * it needlessly attracts mail

[PATCH] USB: EHCI: tegra: Fix oops in error cleanup

2013-06-14 Thread Thierry Reding
Under some circumstances it happens that the connected PHY can't be powered up properly, in which case the cleanup path currently crashes because it checks the tegra-transceiver field using !IS_ERR(), which will succeed because it is in fact NULL. Dereferencing that pointer causes an oops in

Re: [PATCH 1/3] usb: chipidea: add CSR SiRFSoC ci13xxx usb driver

2013-06-14 Thread Alexander Shishkin
Barry Song 21cn...@gmail.com writes: +if USB_CHIPIDEA_UDC USB_CHIPIDEA_HOST + +config USB_CHIPIDEA_SIRF + depends on ARCH_SIRF + bool SiRF USB controller ChipIdea driver binding + default y + help + Say Y here to enable sirf usb ChipIdea driver binding. + +config

Re: [PATCH 1/3] usb: chipidea: add CSR SiRFSoC ci13xxx usb driver

2013-06-14 Thread Barry Song
2013/6/14 Alexander Shishkin alexander.shish...@linux.intel.com: Barry Song 21cn...@gmail.com writes: +if USB_CHIPIDEA_UDC USB_CHIPIDEA_HOST + +config USB_CHIPIDEA_SIRF + depends on ARCH_SIRF + bool SiRF USB controller ChipIdea driver binding + default y + help +

Re: [PATCH 1/3] usb: chipidea: add CSR SiRFSoC ci13xxx usb driver

2013-06-14 Thread Alexander Shishkin
Barry Song 21cn...@gmail.com writes: 2013/6/14 Alexander Shishkin alexander.shish...@linux.intel.com: Barry Song 21cn...@gmail.com writes: +if USB_CHIPIDEA_UDC USB_CHIPIDEA_HOST + +config USB_CHIPIDEA_SIRF + depends on ARCH_SIRF + bool SiRF USB controller ChipIdea driver binding

[PATCH v4] usb: dwc3: use extcon fwrk to receive connect/disconnect

2013-06-14 Thread Kishon Vijay Abraham I
Modified dwc3-omap to receive connect and disconnect notification using extcon framework. Also did the necessary cleanups required after adapting to extcon framework. Signed-off-by: Kishon Vijay Abraham I kis...@ti.com Acked-by: Felipe Balbi ba...@ti.com --- This patch depends on

[RFC PATCH] usb: hcd: warn about URB buffers that are not DMA aligned and are about to be DMA mapped

2013-06-14 Thread Jussi Kivilinna
Appearently some out-of-tree USB host drivers do not handle DMA alignment for URB buffers and let core/hcd.c to do the mapping on architectures that have minimum DMA alignment requirements. This leads to random memory corruptions and crashes when using USB device drivers that use unaligned URB

[PATCH] USB: ehci-omap: Tweak PHY initialization sequence

2013-06-14 Thread Roger Quadros
For PHY mode, the PHYs must be brought out of reset before the EHCI controller is started. This patch fixes the issue where USB devices are not found on Beagleboard/Beagle-xm if USB has been started previously by the bootloader. (e.g. by usb start command in u-boot) Tested on Beagleboard,

Re: [PATCH 1/3] usb: chipidea: add CSR SiRFSoC ci13xxx usb driver

2013-06-14 Thread Barry Song
2013/6/14 Alexander Shishkin alexander.shish...@linux.intel.com: Barry Song 21cn...@gmail.com writes: 2013/6/14 Alexander Shishkin alexander.shish...@linux.intel.com: Barry Song 21cn...@gmail.com writes: +if USB_CHIPIDEA_UDC USB_CHIPIDEA_HOST + +config USB_CHIPIDEA_SIRF + depends on

Re: [RFC PATCH 0/4] USB: HCD/EHCI: giveback of URB in tasklet context

2013-06-14 Thread Ming Lei
On Fri, Jun 14, 2013 at 10:56 PM, Alan Stern st...@rowland.harvard.edu wrote: On Fri, 14 Jun 2013, Ming Lei wrote: On Fri, Jun 14, 2013 at 3:41 AM, Alan Stern st...@rowland.harvard.edu wrote: The main reason for moving away from the current scheme is to reduce latency for other

Re: [PATCH] USB: EHCI: tegra: Fix oops in error cleanup

2013-06-14 Thread Stephen Warren
On 06/14/2013 05:21 AM, Thierry Reding wrote: Under some circumstances it happens that the connected PHY can't be powered up properly, in which case the cleanup path currently crashes because it checks the tegra-transceiver field using !IS_ERR(), which will succeed because it is in fact NULL.

Re: [RFC PATCH] usb: hcd: warn about URB buffers that are not DMA aligned and are about to be DMA mapped

2013-06-14 Thread Greg Kroah-Hartman
On Fri, Jun 14, 2013 at 04:38:03PM +0300, Jussi Kivilinna wrote: Appearently some out-of-tree USB host drivers do not handle DMA alignment for URB buffers and let core/hcd.c to do the mapping on architectures that have minimum DMA alignment requirements. This leads to random memory corruptions

Re: [PATCH 0/1] USB: wusbcore: add sysfs attribute for DNTS count and interval

2013-06-14 Thread Greg KH
On Thu, Jun 13, 2013 at 12:20:30PM -0500, Thomas Pugliese wrote: This patch adds a sysfs attribute for the wireless USB host controller device notification transmit slot(DNTS) count and interval. It also changes the defaults from 16 slots in every MMC to a more reasonable 4 slots every

[GIT PATCH] USB fixes for 3.10-rc5

2013-06-14 Thread Greg KH
The following changes since commit 317ddd256b9c24b0d78fa8018f80f1e495481a10: Linux 3.10-rc5 (2013-06-08 17:41:04 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-3.10-rc5 for you to fetch changes up to

[GIT PATCH] USB fixes for 3.10-rc6

2013-06-14 Thread Greg KH
[resend with fixed subject] The following changes since commit 317ddd256b9c24b0d78fa8018f80f1e495481a10: Linux 3.10-rc5 (2013-06-08 17:41:04 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-3.10-rc5 for you to fetch

Re: Proposed modification to PL2303 driver

2013-06-14 Thread Greg KH
A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Fri, Jun 14, 2013 at 11:20:01AM +0200, Mastro Gippo wrote: Hi Greg, thanks for your reply. I spent some free time this week trying to compile and use the modified driver, but I'm unable to

Re: [PATCH V3 REPOST 0/7] USB: tegra: support building as a module

2013-06-14 Thread Thierry Reding
On Thu, Jun 13, 2013 at 11:24:06AM -0600, Stephen Warren wrote: From: Stephen Warren swar...@nvidia.com I'm reposting this because I originally thought Felipe would apply it to his PHY tree, since it's based on other work there. Now that tree has been merged into Greg's main USB tree, I

Re: [RFC PATCH 1/1] Intel xhci: refactor EHCI/xHCI port switching

2013-06-14 Thread Sarah Sharp
On Wed, Jun 12, 2013 at 03:32:14PM -0700, Greg KH wrote: Thanks for the explaination, if you are ok with this, I have no objections. Feel free to queue it up in your next round of patches if you want to. So you're fine with the global variable as well? Sarah Sharp -- To unsubscribe from this

Re: [RFC PATCH 0/1] Intel xhci: rework EHCI/xHCI port switching

2013-06-14 Thread Sarah Sharp
On Wed, Jun 12, 2013 at 07:11:22PM +0300, Mathias Nyman wrote: Hi This is a proposal for simplifying the EHCI/xHCI portswitching It's a lot simpler than before. There's now only one funtion for enabling xhci ports, and we only once walk through pci devices to find Intel EHCI and xHCI

Re: [RFC PATCH 0/1] Intel xhci: rework EHCI/xHCI port switching

2013-06-14 Thread Greg KH
On Wed, Jun 12, 2013 at 07:11:22PM +0300, Mathias Nyman wrote: Hi This is a proposal for simplifying the EHCI/xHCI portswitching It's a lot simpler than before. There's now only one funtion for enabling xhci ports, and we only once walk through pci devices to find Intel EHCI and xHCI

Re: [RFC PATCH] usb: hcd: warn about URB buffers that are not DMA aligned and are about to be DMA mapped

2013-06-14 Thread Greg Kroah-Hartman
On Fri, Jun 14, 2013 at 08:24:24PM +0300, Jussi Kivilinna wrote: On 14.06.2013 19:05, Greg Kroah-Hartman wrote: On Fri, Jun 14, 2013 at 04:38:03PM +0300, Jussi Kivilinna wrote: Appearently some out-of-tree USB host drivers do not handle DMA alignment for URB buffers and let core/hcd.c to

Re: [PATCH 0/1] USB: wusbcore: add sysfs attribute for DNTS count and interval

2013-06-14 Thread Thomas Pugliese
Sorry about that. It was my first attempt at a multi-part patch. I'll update the documentation, renumber and resend. Tom On Fri, 14 Jun 2013, Greg KH wrote: On Thu, Jun 13, 2013 at 12:20:30PM -0500, Thomas Pugliese wrote: This patch adds a sysfs attribute for the wireless USB host

Re: [GIT PULL] USB patches for v3.11 merge window

2013-06-14 Thread Felipe Balbi
Hi, On Fri, Jun 14, 2013 at 11:28:51AM +0300, Roger Quadros wrote: On 06/13/2013 05:55 PM, Felipe Balbi wrote: HI, On Thu, Jun 13, 2013 at 05:53:50PM +0300, Roger Quadros wrote: On 06/13/2013 05:17 PM, Felipe Balbi wrote: Hi, On Thu, Jun 13, 2013 at 12:05:36PM +0300, Roger Quadros

Re: [PATCh V10 04/12] usb: ehci: ehci-mv: use PHY driver for ehci

2013-06-14 Thread Alan Stern
On Fri, 14 Jun 2013, Roger Quadros wrote: hi The following is my understanding. I think for PHY initialization and shutdown part, it is generic for other parts. PHY initialization need to be called before hc_driver-reset is called. I think it can be added at usb_add_hcd. For PHY

Re: [PATCH V2 0/6] USB: OHCI: more bus glues as separate modules

2013-06-14 Thread Alan Stern
On Fri, 14 Jun 2013, Manjunath Goudar wrote: HI Alan, Can you review this patch series. I will, but I won't get to it for a while. I have a lot of other stuff to work on first. Alan Stern -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to

Re: [RFC PATCH] usb: hcd: warn about URB buffers that are not DMA aligned and are about to be DMA mapped

2013-06-14 Thread Alan Stern
On Fri, 14 Jun 2013, Jussi Kivilinna wrote: Appearently some out-of-tree USB host drivers do not handle DMA alignment for URB buffers and let core/hcd.c to do the mapping on architectures that have minimum DMA alignment requirements. This leads to random memory corruptions and crashes when

Re: [RFC PATCH 0/4] USB: HCD/EHCI: giveback of URB in tasklet context

2013-06-14 Thread Alan Stern
On Fri, 14 Jun 2013, Ming Lei wrote: With the two trace points of irq_handler_entry and irq_handler_exit, the interrupt latency(or the time taken by hard irq handler) isn't hard to measure. One simple script can figure out the average/maximum latency for one irq handler, like I did in

Re: [RFC PATCH 0/4] USB: HCD/EHCI: giveback of URB in tasklet context

2013-06-14 Thread Thomas Gleixner
On Fri, 14 Jun 2013, Alan Stern wrote: On Fri, 14 Jun 2013, Ming Lei wrote: With the two trace points of irq_handler_entry and irq_handler_exit, the interrupt latency(or the time taken by hard irq handler) isn't hard to measure. One simple script can figure out the average/maximum

Re: [RFC PATCH 0/1] Intel xhci: rework EHCI/xHCI port switching

2013-06-14 Thread Sarah Sharp
On Fri, Jun 14, 2013 at 10:41:39AM -0700, Greg KH wrote: On Wed, Jun 12, 2013 at 07:11:22PM +0300, Mathias Nyman wrote: Hi This is a proposal for simplifying the EHCI/xHCI portswitching It's a lot simpler than before. There's now only one funtion for enabling xhci ports, and we

Re: [RFC PATCH 0/1] Intel xhci: rework EHCI/xHCI port switching

2013-06-14 Thread Greg KH
On Fri, Jun 14, 2013 at 02:16:50PM -0700, Sarah Sharp wrote: On Fri, Jun 14, 2013 at 10:41:39AM -0700, Greg KH wrote: On Wed, Jun 12, 2013 at 07:11:22PM +0300, Mathias Nyman wrote: Hi This is a proposal for simplifying the EHCI/xHCI portswitching It's a lot simpler than before.

Re: [RFC PATCH 0/1] Intel xhci: rework EHCI/xHCI port switching

2013-06-14 Thread Alan Stern
On Fri, 14 Jun 2013, Sarah Sharp wrote: On Wed, Jun 12, 2013 at 07:11:22PM +0300, Mathias Nyman wrote: Hi This is a proposal for simplifying the EHCI/xHCI portswitching It's a lot simpler than before. There's now only one funtion for enabling xhci ports, and we only once walk

Re: [RFC PATCH 0/4] USB: HCD/EHCI: giveback of URB in tasklet context

2013-06-14 Thread Ming Lei
On Sat, Jun 15, 2013 at 4:23 AM, Alan Stern st...@rowland.harvard.edu wrote: Not entirely. On a UP system, leaving interrupts disabled for a long time (which is what we do now) increases the delay between when the IRQ is raised and when it is serviced. On an SMP system, a long-running Yes,

Re: [PATCH] USB: EHCI: tegra: Fix oops in error cleanup

2013-06-14 Thread Alan Stern
On Fri, 14 Jun 2013, Thierry Reding wrote: Under some circumstances it happens that the connected PHY can't be powered up properly, in which case the cleanup path currently crashes because it checks the tegra-transceiver field using !IS_ERR(), which will succeed because it is in fact NULL.

Re: [PATCh V10 04/12] usb: ehci: ehci-mv: use PHY driver for ehci

2013-06-14 Thread Alan Stern
On Fri, 14 Jun 2013, Chao Xie wrote: I checked with the code in our 3.4 git. we really did a lot of things when suspend/resume, and at that point the patch for ehci_resume and ehci_suspend are not added. i think the driver can make use of ehci_resume/ehci_suspend. For PHY, we have to