On 7/17/2014 8:06 PM, Felipe Balbi wrote:
that's good, thanks. But my tree is now closed for v3.17, once v3.17-rc1
is out I'll start queueing for v3.18.
No probs!
I'll send the patch with updated commit msg.
BTW, I think you mean you'll queue for kernel v3.17 (v3.16 is yet to be
released as
Problem Summary: Problem has been observed generally with PM states
where VBUS goes off during suspend. There are some SS USB devices which
take longer time for link training compared to many others. Such
devices fail to reconnect with same old address which was associated
with it before suspend.
On Thu, 17 Jul 2014, Felipe Balbi wrote:
Hi,
On Thu, Jul 17, 2014 at 06:13:33PM +0100, Lee Jones wrote:
This patch provides mechanism for subordinate devices to check
whether the DWC3 core probed successfully or otherwise. Useful
if PHYs are required to configure controllers, but
Replace the VDBG and DBG macro with the kernels proper debug macros
(dev_vdbg and dev_dbg) in f_acm.c, f_obex.c f_serial.c
Signed-off-by: Richard Leitner richard.leit...@skidata.com
---
drivers/usb/gadget/f_acm.c| 41 -
drivers/usb/gadget/f_obex.c
On Thu, 2014-07-17 at 17:13 -0700, Greg KH wrote:
On Mon, Jul 14, 2014 at 10:47:55PM +0200, Oliver Neukum wrote:
I see no sane way to come up with numbers.
Unless you want to measure the time between spurious event.
But that would really be overkill. I'd rather fix a concrete
issue.
- remove comma after end of list delimiter
The empty entry must always be the last item in the list, thus there
is no point in having a trailing comma to facilitate adding
succeding entries.
Remove the comma, so that inadvertedly adding an entry after the end
of list sentinel will
Without this patch overriding the USBOTG_ID pin by setting the iddig
bit in the USB_MODE register doesn't work because it happens too late
to be recognized correctly.
Signed-off-by: Lothar Waßmann l...@karo-electronics.de
---
drivers/usb/musb/musb_core.c | 12 +++-
1 file changed, 7
Make sure all parameters are correctly set up before registering the
PHY with the USB framework.
Signed-off-by: Lothar Waßmann l...@karo-electronics.de
---
drivers/usb/phy/phy-am335x.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/phy/phy-am335x.c
There is no need to throw the baby out with the bath due to a bad
failure analysis. The commit:
7adb5c876e9c usb: musb: Fix panic upon musb_am335x module removal
came to a wrong conclusion about the cause of the crash it was
fixing. The real culprit was the phy-am335x module that was removed
from
Signed-off-by: Lothar Waßmann l...@karo-electronics.de
---
drivers/usb/musb/musb_core.c |4
1 file changed, 4 deletions(-)
diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
index b841ee0..8623112 100644
--- a/drivers/usb/musb/musb_core.c
+++
Signed-off-by: Lothar Waßmann l...@karo-electronics.de
---
drivers/usb/phy/phy-am335x.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/phy/phy-am335x.c b/drivers/usb/phy/phy-am335x.c
index b70e055..91c71ab 100644
--- a/drivers/usb/phy/phy-am335x.c
+++
The first three patches do some source code cleanup in the files that
are modified in the subsequent patches.
Patch 4 carries the proper fix reported in commit:
7adb5c876e9c (usb: musb: Fix panic upon musb_am335x module removal)
Patch 6 makes the USBOTG_ID pin override via the USB_MODE
Signed-off-by: Lothar Waßmann l...@karo-electronics.de
---
drivers/usb/musb/musb_core.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
index 8623112..f867b44 100644
--- a/drivers/usb/musb/musb_core.c
+++
This patch fixes the real cause of the crash that was fixed by
commit 7adb5c876e9c usb: musb: Fix panic upon musb_am335x module removal
Signed-off-by: Lothar Waßmann l...@karo-electronics.de
---
drivers/usb/phy/phy-am335x-control.c | 10 ++
1 file changed, 10 insertions(+)
diff --git
This patch makes it possible to use the musb driver with HW that
requires external regulators or clocks.
Signed-off-by: Lothar Waßmann l...@karo-electronics.de
---
drivers/usb/phy/phy-am335x.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/phy/phy-am335x.c
Remove the ttyGS PREFIX macro from u_serial.c and replace all occurences with
the hardcoded ttyGS string.
This macro was mostly used in a few debug/warning messages and a lot of
hardcoded ttyGS existed beneath. It may have been used for renaming the
tty, but if done so most debug messages would
Hello Jim Baxter,
This is a semi-automatic email about new static checker warnings.
The patch 6d3865f9d41f: usb: gadget: NCM: Add transmit multi-frame.
from Jul 7, 2014, leads to the following Smatch complaint:
drivers/usb/gadget/function/u_ether.c:564 eth_start_xmit()
error: we
tested-by: Prakash Burla prakash.bu...@smartplayin.com
This driver tested on IFC6410 with USB Driver.
On Fri, Jul 18, 2014 at 1:46 AM, Srinivas Kandagatla
srinivas.kandaga...@linaro.org wrote:
This patch makes the phy reset clk and reset line optional as this clk
is not available on boards like
On 07/16/2014 09:58 PM, Paul Zimmerman wrote:
From: Robert Baldyga [mailto:r.bald...@samsung.com]
Sent: Wednesday, July 16, 2014 3:22 AM
Because we have not enough memory to have each TX FIFO of size at least 3072
bytes (the maximum single packet size), we create four FIFOs of lenght 1024,
When device is stopped or suspended clock is not needed so we
can disable it for this time.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
---
drivers/usb/dwc2/gadget.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
index
From: Marek Szyprowski m.szyprow...@samsung.com
This patch fixes kernel panic/interrupt storm/etc issues if bootloader
left s3c-hsotg module in enabled state. Now interrupt handler is enabled
only after proper configuration of hardware registers.
Signed-off-by: Marek Szyprowski
From: Marek Szyprowski m.szyprow...@samsung.com
This patch fixes possible freeze caused by infinite loop in interrupt
context.
Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com
Signed-off-by: Robert Baldyga r.bald...@samsung.com
---
drivers/usb/dwc2/gadget.c | 1 +
1 file changed, 1
Because we have not enough memory to have each TX FIFO of size at least
3072 bytes (the maximum single packet size with 3 transactions per
microframe), we create four FIFOs of lenght 1024, and four of length
3072 bytes, and assing them to endpoints dynamically according to
maxpacket size value of
From: Marek Szyprowski m.szyprow...@samsung.com
This leads to potential spinlock recursion in composite framework, other
udc drivers also don't call it directly from pullup method.
Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com
Signed-off-by: Robert Baldyga r.bald...@samsung.com
---
From: Kamil Debski k.deb...@samsung.com
When the driver is removed s3c_hsotg_phy_disable is called three times
instead of once. This results in decreasing of the phy reference counter
below zero and thus consecutive inserts of the module fails.
This patch removes calls to s3c_hsotg_phy_disable
Hello,
This patchset contains fixes for dwc2 gadget driver. It touches PHY,
FIFO configuration, initialization sequence and adds many other small fixes.
Best regards
Robert Baldyga
Samsung RD Institute Poland
Changelog:
v3:
- use endpoint index instead of FIFO index for EPFIFO
- extend patch
On 7/17/2014 8:25 PM, Alan Stern wrote:
I can't say this is actually wrong, but have you ever encountered a
situation where this would be needed? How often does anyone need to do
a multi-packet transfer over an interrupt endpoint?
Honestly, I haven't found any such real device yet. I did this
HI,
On Fri, Jul 18, 2014 at 11:31:22AM +0200, Lothar Waßmann wrote:
no commit log == no commit, also the worst thing you can do is have your
bug fixes depend on cleanups. This is *not* a bug fix by any stretch of
the imagination.
Signed-off-by: Lothar Waßmann l...@karo-electronics.de
---
On Fri, Jul 18, 2014 at 11:31:23AM +0200, Lothar Waßmann wrote:
no commit log. Not a bug fix.
Signed-off-by: Lothar Waßmann l...@karo-electronics.de
---
drivers/usb/phy/phy-am335x.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/phy/phy-am335x.c
On Fri, Jul 18, 2014 at 11:31:24AM +0200, Lothar Waßmann wrote:
- remove comma after end of list delimiter
The empty entry must always be the last item in the list, thus there
is no point in having a trailing comma to facilitate adding
succeding entries.
Remove the comma, so that
On Fri, Jul 18, 2014 at 11:31:25AM +0200, Lothar Waßmann wrote:
This patch fixes the real cause of the crash that was fixed by
commit 7adb5c876e9c usb: musb: Fix panic upon musb_am335x module removal
Signed-off-by: Lothar Waßmann l...@karo-electronics.de
what is the real cause of the crash ?
On Fri, Jul 18, 2014 at 11:31:26AM +0200, Lothar Waßmann wrote:
no commit log. Not a bug fix.
Signed-off-by: Lothar Waßmann l...@karo-electronics.de
---
drivers/usb/musb/musb_core.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/musb/musb_core.c
On Fri, Jul 18, 2014 at 11:31:27AM +0200, Lothar Waßmann wrote:
Without this patch overriding the USBOTG_ID pin by setting the iddig
bit in the USB_MODE register doesn't work because it happens too late
to be recognized correctly.
and how did you test this ? Why is it too late ? What was your
On Fri, Jul 18, 2014 at 11:31:28AM +0200, Lothar Waßmann wrote:
Make sure all parameters are correctly set up before registering the
PHY with the USB framework.
Signed-off-by: Lothar Waßmann l...@karo-electronics.de
---
drivers/usb/phy/phy-am335x.c |5 +++--
1 file changed, 3
Hi,
On Fri, Jul 18, 2014 at 11:31:29AM +0200, Lothar Waßmann wrote:
This patch makes it possible to use the musb driver with HW that
requires external regulators or clocks.
can you provide an example of such HW ? Are you not using the internal
PHYs ?
Signed-off-by: Lothar Waßmann
Hi,
On 07/10/2014 01:17 PM, Hans de Goede wrote:
Hi Sarah, Matthias, et al,
I've been running a full Linux distro from an uas enclosure with a ssd
for testing purposes (mostly for testing the distro on different
hardware but also for uas testing).
While testing this on a Thinkpad T440s I
Hi,
On 07/17/2014 06:08 PM, Hans de Goede wrote:
Hi all,
It has cost me quite some time to get to the bottom of this (which is
not even the real bottom).
When I generate heavy-io (make -j4 modules or cp -pr a git clone
of the kernel), urbs start completing with EPROTO errors when using a
On a Intel E660/EG20T system I can observe the following lockdep splats:
[ 10.154920] =
[ 10.156026] [ INFO: inconsistent lock state ]
[ 10.156026] 3.16.0-rc5+ #13 Not tainted
[ 10.156026] -
[ 10.156026] inconsistent
Hi All,
Here is a small patch-set fixing the following error:
xhci error: Transfer event TRB DMA ptr not part of current TD
Being logged when using uas on a Haswell chipset xhci controller.
The first 2 patches just add some debugging output which I've found to be
helpful to solve this bug and
To help debugging xhci problems.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/host/xhci.c | 4
drivers/usb/host/xhci.h | 2 ++
2 files changed, 6 insertions(+)
diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
index 7436d5f..7d02e1b 100644
---
When using a Renesas uPD720231 chipset usb-3 uas to sata bridge with a 120G
Crucial M500 ssd, model string: Crucial_ CT120M500SSD1, together with a
the integrated Intel xhci controller on a Haswell laptop:
00:14.0 USB controller [0c03]: Intel Corporation 8 Series USB xHCI HC
[8086:9c31] (rev 04)
These errors should never happen, so lets add some extra info when they happen
to make figuring out what is going on easier.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/host/xhci-ring.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git
From: Hans de Goede
These errors should never happen, so lets add some extra info when they happen
to make figuring out what is going on easier.
I've previously posted a patch that include the 'DMA ptr' itself.
IIRC I was generating one of the error events where the pointer is
the address of a
On Thu, 17 Jul 2014, Greg KH wrote:
On Thu, Jul 17, 2014 at 04:32:26PM -0400, Alan Stern wrote:
The debug routine fill_async_buffer() in ohci-hcd is buggy: It never
produces any output because it forgets to initialize the output buffer
size. Also, the debug routine ohci_dump() has an
On Fri, 18 Jul 2014, Amit Virdi wrote:
On 7/17/2014 8:25 PM, Alan Stern wrote:
I can't say this is actually wrong, but have you ever encountered a
situation where this would be needed? How often does anyone need to do
a multi-packet transfer over an interrupt endpoint?
Honestly, I
Hi,
On Fri, Jul 18, 2014 at 08:11:15AM +0100, Lee Jones wrote:
snip
diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index eb69eb9..171ca52 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb/dwc3/core.c
@@ -47,6 +47,14 @@
/*
On Fri, 18 Jul 2014, Pratyush Anand wrote:
Following sparse warnings were reported by kbuild test bot
drivers/usb/misc/lvstest.c:314:28: sparse: incorrect type in assignment
(different base types)
drivers/usb/misc/lvstest.c:314:28:expected unsigned short [unsigned]
[usertype]
On Fri, 18 Jul 2014, Pratyush Anand wrote:
Problem Summary: Problem has been observed generally with PM states
where VBUS goes off during suspend. There are some SS USB devices which
take longer time for link training compared to many others. Such
devices fail to reconnect with same old
Seems interesting
That's fine.
Acked-By: Enrico Mioso mrkiko...@gmail.com
On Thu, 17 Jul 2014, Bjørn Mork wrote:
==Date: Thu, 17 Jul 2014 13:34:09
==From: Bjørn Mork bj...@mork.no
==To: net...@vger.kernel.org
==Cc: linux-usb@vger.kernel.org, Bjørn Mork bj...@mork.no,
==Enrico Mioso
Hi Lothar,
On 18 Jul 11:31 AM, Lothar Waßmann wrote:
The first three patches do some source code cleanup in the files that
are modified in the subsequent patches.
I've applied patches 4 and 9 on a recent -next, after fixing a conflict
due to patch 3 (usb: musb_am335x: source cleanup):
Hi,
On Fri, Jul 18, 2014 at 01:16:36PM -0300, Ezequiel Garcia wrote:
Hi Lothar,
On 18 Jul 11:31 AM, Lothar Waßmann wrote:
The first three patches do some source code cleanup in the files that
are modified in the subsequent patches.
I've applied patches 4 and 9 on a recent -next,
This adds USB PHY and USB controller nodes. Vybrid SoCs have two
independent USB cores which each supports DR (dual role). However,
real OTG is not supported since the OTG ID pin is not available.
The PHYs are located within the anadig register range, hence we need
to change the length of the
This adds support for the USB PHY in Vybrid VF610. We assume that
the disconnection without VBUS is also needed for Vybrid. For all
other flags, the presumption of innocence applies.
Signed-off-by: Stefan Agner ste...@agner.ch
---
drivers/usb/phy/phy-mxs-usb.c | 5 +
1 file changed, 5
This commit adds PLL7 which is required for USBPHY1. It also adds
the USB PHY and USB Controller clocks and the gates to enable them.
Signed-off-by: Stefan Agner ste...@agner.ch
---
All the main PLLs are currently turned on by boot ROM or boot loader, within
the kernel we only set the fixed
This adds Vybrid VF610 SoC support. The IP is very similar to i.MX6,
however the non-core registers are spread in two different register
areas. Hence we support multiple registers which are addressed by
the index of usbmisc.
Signed-off-by: Stefan Agner ste...@agner.ch
---
I tried first to create
This patchset adds USB support for Vybrid VF610 SoC. It extends the
clock framework to support the USB PHY cocks, extends the device
tree files and adds support for the non-core registers in the
usbmisc_imx driver.
This patchset needs the eSDHC length fix available in Shawn's
for-next branch.
Add device tree node for usbmisc which controls the non-core USB
registers. This is required to use the property to disable the over-
current detection.
Signed-off-by: Stefan Agner ste...@agner.ch
---
arch/arm/boot/dts/vf610.dtsi | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
hi Paul:
Driver prepare ep ring like below
xhci.0: @2796e150 279cfb04 000404fc 80021415 //xx
xhci.0: @2796e160 279d 06f8 0625 //normal
xhci.0: @2796e170 279d06f8 0bf4 80021625
but event ring get below
On Fri, Jul 18, 2014 at 10:45 AM, Alan Stern st...@rowland.harvard.edu wrote:
On Fri, 18 Jul 2014, Nick Krause wrote:
I am assuming this is a stupid question but since I am new I will ask it
anyway.
Can the usb_bus structure be Null? If can I will send it a patch removing
the
fix mes on
On 07/18/2014 10:45 AM, Nick Krause wrote:
Hey Greg and others,
When I built the usb directory today to check a patch I am also
sending to. I seem to hitting
a few compiler errors and a lot of warnings. I am going to attach a
file of my log of this build.
Cheers Nick
Hi,
What command(s)
From: vichy [mailto:vichy@gmail.com]
Sent: Friday, July 18, 2014 10:13 AM
Driver prepare ep ring like below
xhci.0: @2796e150 279cfb04 000404fc 80021415 //xx
xhci.0: @2796e160 279d 06f8 0625 //normal
xhci.0:
On Fri, 18 Jul 2014, Nicholas Krause wrote:
I am removing two fix mes in this file as after dicussing then it seems
there is no reason to check against Null for usb_device as it can never
be NULL and this is check is therefore not needed.
Signed-off-by: Nicholas Krause xerofo...@gmail.com
From: Robert Baldyga [mailto:r.bald...@samsung.com]
Sent: Friday, July 18, 2014 4:39 AM
This patchset contains fixes for dwc2 gadget driver. It touches PHY,
FIFO configuration, initialization sequence and adds many other small fixes.
Best regards
Robert Baldyga
Samsung RD Institute
On Fri, Jul 18, 2014 at 10:17:20AM -0400, Alan Stern wrote:
On Thu, 17 Jul 2014, Greg KH wrote:
On Thu, Jul 17, 2014 at 04:32:26PM -0400, Alan Stern wrote:
The debug routine fill_async_buffer() in ohci-hcd is buggy: It never
produces any output because it forgets to initialize the
On Fri, Jul 18, 2014 at 3:09 PM, Alan Stern st...@rowland.harvard.edu wrote:
On Fri, 18 Jul 2014, Nicholas Krause wrote:
I am removing two fix mes in this file as after dicussing then it seems
there is no reason to check against Null for usb_device as it can never
be NULL and this is check
On Fri, Jul 18, 2014 at 2:10 PM, Randy Dunlap rdun...@infradead.org wrote:
On 07/18/2014 10:45 AM, Nick Krause wrote:
Hey Greg and others,
When I built the usb directory today to check a patch I am also
sending to. I seem to hitting
a few compiler errors and a lot of warnings. I am going to
This patch reverts the important parts of commit 89a0fd18a96e (USB:
OHCI handles more ZFMicro quirks), namely, the parts related to
handling orphan TDs for interrupt endpoints. A later patch in this
series will introduce a more general mechanism that applies to all
endpoint types and all
When an URB is unlinked from a dead controller, ohci-hcd gives back
the URB with no regard for cleaning up the internal data structures.
This won't play nicely with the upcoming changes to the TD done
list.
Therefore make ohci_urb_dequeue() call finish_unlinks(), which uses
td_done() to do a
This patch changes the way ohci-hcd handles the TD done list. In
addition to relying on the TD pointers stored by the controller
hardware, we need to handle TDs that the hardware has forgotten about.
This means the list has to exist even while the dl_done_list() routine
isn't running. That
Some OHCI controllers (most notably those made by NVIDIA, but others
too) sometimes lose track of completed Transfer Descriptors. When a TD
completes, the controller is supposed to add it to the start of the
Done Queue, to let the driver know the transfer is finished. The buggy
controllers
URBs for a particular endpoint should complete sequentially. That is,
we shouldn't call the completion handler for one URB until the handler
for the previous URB has returned.
When the OHCI watchdog routine is added, there will be two paths for
completing URBs: interrupt handler and watchdog
This patch adds an extra check to ohci-hcd's I/O watchdog routine. If
the controller stops updating the frame counter, we will assume it is
dead. But there has to be an exception: Some controllers stop the
frame counter when no ports are connected. Check to make sure there
is at least one
Some OHCI controllers have a bug: They fail to add completed TDs to
the done queue. Examining this queue is the only method ohci-hcd has
for telling when a transfer is complete; failure to add a TD can
result in an URB that never completes and cannot be unlinked.
This patch adds a watchdog
On Fri, Jul 18, 2014 at 08:48:19AM +0200, Oliver Neukum wrote:
On Thu, 2014-07-17 at 17:13 -0700, Greg KH wrote:
On Mon, Jul 14, 2014 at 10:47:55PM +0200, Oliver Neukum wrote:
I see no sane way to come up with numbers.
Unless you want to measure the time between spurious event.
But
On 07/18/2014 12:59 PM, Nick Krause wrote:
On Fri, Jul 18, 2014 at 2:10 PM, Randy Dunlap rdun...@infradead.org wrote:
On 07/18/2014 10:45 AM, Nick Krause wrote:
Hey Greg and others,
When I built the usb directory today to check a patch I am also
sending to. I seem to hitting
a few compiler
On Fri, Jul 18, 2014 at 04:25:23PM -0400, Alan Stern wrote:
Some OHCI controllers (most notably those made by NVIDIA, but others
too) sometimes lose track of completed Transfer Descriptors. When a TD
completes, the controller is supposed to add it to the start of the
Done Queue, to let the
On Fri, Jul 18, 2014 at 7:29 PM, Randy Dunlap rdun...@infradead.org wrote:
On 07/18/2014 12:59 PM, Nick Krause wrote:
On Fri, Jul 18, 2014 at 2:10 PM, Randy Dunlap rdun...@infradead.org wrote:
On 07/18/2014 10:45 AM, Nick Krause wrote:
Hey Greg and others,
When I built the usb directory today
On 07/18/2014 01:34 PM, Nicholas Krause wrote:
I am removing two fix mes in this file as after dicussing then it seems
there is no reason to check against Null for usb_device as it can never
be NULL and this is check is therefore not needed.
Signed-off-by: Nicholas Krause
Sorry didn't run spell check. I will resend this patch with the
correct information
as needed. Thanks for the advice, Sasha.
Cheers Nick
On Fri, Jul 18, 2014 at 10:36 PM, Sasha Levin sas...@kernel.org wrote:
On 07/18/2014 01:34 PM, Nicholas Krause wrote:
I am removing two fix mes in this file
Since upgrading from 3.12.24 kernel to 3.14.10, and today, .12 kernel
log and dmesg are flooded with constant messages
option1 ttyUSB0: option_instat_callback: error -2
The device still works, it sends and receives SMS's as well,
I tried setting verbose usb debug to see if it offers any more
80 matches
Mail list logo
